From nobody Fri Oct 3 23:02:06 2025 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1C94D8F7D for ; Fri, 22 Aug 2025 19:01:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889312; cv=none; b=rGCUhKkMzCo+qtaHklkEbTrR1QPEtVu/Mv6Ssx8nVxNqT4Q3lwpr2WHihYK77Pw7RUkUvXL5wH6wUQe6xmk8cU4KAEWJvw11zXoMPQ5CECTqCEWG+9Ue5b0a4EEOed4k93kkXhGdj5rRU48lqg1MqbPQkqix8o+0kyf4OfD5l6c= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889312; c=relaxed/simple; bh=mlcQtSh0hqaRcHWIznFySlhxi/4/Wh0665fCG2bxdAg=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ieIBusDjhi8o/kjcjxmwLO/MeeqMwQLb/35IV/aA7MEQhspJJoCr0re/eXXyKQO+lOhyB3EFQppXmRlIMTeMWBTdrAuP3iHcRfworXiaSkX1ZCRd89HMaQxwG3BrJ4CSRokX4Njr41m3BRaFqjVeIZS+7a9MlGRo4iNrHDuljO0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=SF0kEHzP; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="SF0kEHzP" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-7702fc617e9so1080247b3a.1 for ; Fri, 22 Aug 2025 12:01:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755889310; x=1756494110; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=xLGTqHSiHacelS/0B9Hd+pXTKy+T7n8diYWFTswYvyc=; b=SF0kEHzPnOCeYmGlIxZwQLR6dsHE1tlahNfcY3JEuIsHke5gpzkyAmjLjYYHn46kD3 iYISTwLlxKy4RmJs1EpUkbtwVUwyS7k8tJ+M5gvBHOvD8ihy8XsEZbzRYrPwE/W+fXr5 WXG2lbflK3ARx2JrwghrqVAU90hy7n4uD10Zs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755889310; x=1756494110; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=xLGTqHSiHacelS/0B9Hd+pXTKy+T7n8diYWFTswYvyc=; b=e3uWoLCQa2FrhXa4FM4sxozYfnFGrOnXzrtouK4ZXbzzUFV0eBjnOTvDel0mCc9+4/ FL0AU4llbavOOu/tSh7CL7ucjcUbmwVnf2E7IIiAH4mr0nfZ0rurlqd7XWNb1gg1MFGv +J3ehyAX6J4otAsyQ2XSMMuAN7eTDAE/LIabxu2nG8i3kdsGnVQBjsiiTWK4eHcuq6c1 yDkPQc7tYO8YeLRAwgqsTdBgJfhnjTrvifJikGxLjrqGWEZoXribqyVdNGRD9t9ZGFuc 5mFQ2jf2lvJfBIZvYRTjnsSzVNwYzr7J6bDArHEWxCy2g782kOKpgR7GtrXKxYroUflV Plog== X-Forwarded-Encrypted: i=1; AJvYcCVNEOXFHgXHvY5bdk6EZ7ChQSZABE1B02VR4enCQphs8k668+3aeqaR8P4NitZBbQIviWbQVrD3ikE7ZW8=@vger.kernel.org X-Gm-Message-State: AOJu0YxBCleXBXJ3BKrMaPY/AWn5MNIQIskXdYoxNdjAnPcmubtk58UX aX8tKxiMkS/cANgGJU2YyfM3BkoucFaWpAii6iUcRvVI5QdRZYyXMthZS+G67grEL7AwBh6YNn5 3/hw= X-Gm-Gg: ASbGncspGQZNnK2Fdv40sWqnvwGr3kEg4KE+EBZv8v5G4mrmYdL72sWm31XNLlYxbF4 IWtY7CAggrp6zN1Pr1Epr04+CR+joyG/bJZ7ER51dXFxOR2WR7E2J/Paydzv1WTZbhIqTK4gJIz 6WZBxkdcaYylPK+MC/nFg1Wx3KPM5SEUSxTE2plGf3BRz2GJILeBddXYqRDpcL0W7wej6mRei/Z smuA1bESfr1arq13LADSoFfDcqYUJtW6xKQ7ZP1oS8SqZ3mR4Hoah3b/zGFSWf1d9e6Nm09lP63 CfqrjUB2bwoSjz5wg+VOlhKZNGjtEc6PQh9/M3xtTGTWc5VzFu/hNs7b3ORnwRDR2fTlvA/7Tl4 bkZPnpl49qUB4L7g2S6+CrwGbBRTnQbVRvjFlprKUkAqyMyL9FT8zB9TTVJLGDcix+sSn/g== X-Google-Smtp-Source: AGHT+IEJpVJX7aV2ACIw6Rj4vHW2PTWmPuZyvJSxgQtwFFTZFJR0kuL4UoyLgKSxesSQJr+uWR1Ysw== X-Received: by 2002:a05:6a21:33a2:b0:240:1dca:d13d with SMTP id adf61e73a8af0-24340d4407dmr6792727637.43.1755889310348; Fri, 22 Aug 2025 12:01:50 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:154c:8cf:f7d0:c083]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-3254a4d9159sm559489a91.13.2025.08.22.12.01.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Aug 2025 12:01:49 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , linux-kernel@vger.kernel.org, Guenter Roeck , Geert Uytterhoeven , kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH v2 1/6] genirq/test: Select IRQ_DOMAIN Date: Fri, 22 Aug 2025 11:59:02 -0700 Message-ID: <20250822190140.2154646-2-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250822190140.2154646-1-briannorris@chromium.org> References: <20250822190140.2154646-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" These tests use irq_domain_alloc_descs() and so require CONFIG_IRQ_DOMAIN. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Closes: https://lore.kernel.org/lkml/ded44edf-eeb7-420c-b8a8-d6543b955e6e@r= oeck-us.net/ Signed-off-by: Brian Norris Reviewed-by: David Gow Tested-by: Guenter Roeck --- (no changes since v1) kernel/irq/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig index 1da5e9d9da71..08088b8e95ae 100644 --- a/kernel/irq/Kconfig +++ b/kernel/irq/Kconfig @@ -148,6 +148,7 @@ config IRQ_KUNIT_TEST bool "KUnit tests for IRQ management APIs" if !KUNIT_ALL_TESTS depends on KUNIT=3Dy default KUNIT_ALL_TESTS + select IRQ_DOMAIN imply SMP help This option enables KUnit tests for the IRQ subsystem API. These are --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 23:02:06 2025 Received: from mail-pf1-f174.google.com (mail-pf1-f174.google.com [209.85.210.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4A422C158E for ; Fri, 22 Aug 2025 19:01:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889314; cv=none; b=WSu8GXuAHS98+mpYS17ZOg1cX9XCV2+jfpqyKgGBSxxlkYNnXy32HktTugL8T6iv93pPIcZLG6zTRimbbLaEOWXcKqyiRqacixQB/bRHf2Gun92QLI7BzwPdDnTMsfXglSlNDPn1B7wRjuNJZJtXhLQ5b2SHrVn9t6KFnWzCl5w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889314; c=relaxed/simple; bh=s8o27wutxxP824eD7n2DJmP4a/bKEEeG15vJQ/GWeAU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=J1FLtJHwmnuILBlrETKEvu7X5jJrV+2Aw9nylpeVGUneDfu9TH8jGwfa8fjfmk6//n2gMzhPfIMD+if6NxC3n1huJ9qeZRmVbZrGkZkcqvaBUsjgxjOetE2vtq61Wy87RPTuAnuWDaGm3AxQi9q+tyAmkSKSLC/Hdv0ZGJNp39M= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=bcXKEibR; arc=none smtp.client-ip=209.85.210.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="bcXKEibR" Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-7702fc617e9so1080266b3a.1 for ; Fri, 22 Aug 2025 12:01:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755889312; x=1756494112; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5P5K3mPltz8r7A6bRlNvjhmzHKYbAkNrG3FC1k+yO8g=; b=bcXKEibR/TOW4qQhkN0k+oygixYmrzSTkzdnmuD9scGEhlHTz/h5mL29tYvcCyM7uj 4jiHB6F4M4wOoQ2Dl9rH0+mfZQRbP1Mest9WJLjv1jOCFgbuwldCWY/2vt0lYOL8HNF4 4mS8tCBvR74HwqU0gk0wrdYKJkRZxGjXtMa08= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755889312; x=1756494112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5P5K3mPltz8r7A6bRlNvjhmzHKYbAkNrG3FC1k+yO8g=; b=YpJCcK4AdNoGJFXm9llIjRq66/3E5Gy8oXdJSvvu9f62JzUO6DU3HdC3eEbs/YCn6K IxxoUC4DcC07bT/Q4U9e62zHJeM07+2xQ7nIBbAw9Shwpzy0ojNrGtVeCMU1f/yVErbw dCzRQ5enH+7q+NYH/yKrwm1em0brWLYXtik/QAWGuA3R13IoQ38w9739hTTyQgPhkac2 +ungcYf5HpgtsatkV9NoS7W3m+j1u5TLduSt7Fm7lJ20n8RQfZuSMT4Rgb/noxrMKK0y eIydevGZpjrRCWFWEEzX+f25UZV9rGMugX0At8US/vh1YA+f9+XLKl4wvaM0Foh/zmep SAsQ== X-Forwarded-Encrypted: i=1; AJvYcCXxObgZauBNdbjSzMr6lQ79TarxLSPLY+h+HPMiKaAA63kEqADZogHa0+O47kHEWhNzG426MEkuFJGa8lQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyVLp7qj6cPIBP5p8q0MEUYYXWHksmyd7BZ5qwJDBAJUyPLrqd9 dT/jV634oLoUCvRjoq0wHqh8eqJcURSOvDUoK/BIJHBDJCW8v3LZVTu5qYaAscph+A== X-Gm-Gg: ASbGncsYt4qBCajeJnauX6VP1gNO6hIRMu+Nxy5wtLJt6hfQn5VCvDFZORDl6mJ0uKD Q4LDRWSEIEMAYQaGXFJqNzk/Hq0JUXIMQhQCo4YiGZ7Jt9im7rvY45rLtsnPUy4V66/yjUIIWeh ClE5trVDYwxziE94nCDpMUy1ajQ9psXC9UYUVFOPM5rsHcrRSC3i8sDPnOGgggZC5Fvvg9BfYCT 4QHrO0FczCsG+a+sWL/+UF6g1zOx9237I9ufAvT4mjYP6nj6HZ9lm8tQgRHNlMN9Zbl2cLYQxZF EiQC2NMoWKE/R8JBdceb3Dtmbixl/7jpNZgOpSrF4uoemA0WLd94M4jln72Y6331c2WXz/lZAFN aMeagCFTVarwj2uhhsS+HhOThTb7Flc1IceWCHAXjvglzyFyBqN2kFHgsrxQ= X-Google-Smtp-Source: AGHT+IEyL7CtRorFuyVMJrXwp1XmudkMytMaot7DDilcf3dCUoF43F6oklAUdmg5o84LFLbzCjs4pA== X-Received: by 2002:a17:902:e888:b0:240:a54e:21a0 with SMTP id d9443c01a7336-2462ee13154mr57026715ad.19.1755889311840; Fri, 22 Aug 2025 12:01:51 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:154c:8cf:f7d0:c083]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-246688801bdsm3186255ad.123.2025.08.22.12.01.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Aug 2025 12:01:51 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , linux-kernel@vger.kernel.org, Guenter Roeck , Geert Uytterhoeven , kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH v2 2/6] genirq/test: Factor out fake-virq setup Date: Fri, 22 Aug 2025 11:59:03 -0700 Message-ID: <20250822190140.2154646-3-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250822190140.2154646-1-briannorris@chromium.org> References: <20250822190140.2154646-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" We have to repeat a few things in tests. Factor out the creation of fake IRQs. Signed-off-by: Brian Norris Reviewed-by: David Gow Tested-by: Guenter Roeck --- (no changes since v1) kernel/irq/irq_test.c | 45 +++++++++++++++++++------------------------ 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index e220e7b2fc18..f8f4532c2805 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -41,15 +41,15 @@ static struct irq_chip fake_irq_chip =3D { .flags =3D IRQCHIP_SKIP_SET_WAKE, }; =20 -static void irq_disable_depth_test(struct kunit *test) +static int irq_test_setup_fake_irq(struct kunit *test, struct irq_affinity= _desc *affd) { struct irq_desc *desc; - int virq, ret; + int virq; =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, NULL); + virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, affd); KUNIT_ASSERT_GE(test, virq, 0); =20 - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + irq_set_chip_and_handler(virq, &fake_irq_chip, handle_simple_irq); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); @@ -57,6 +57,19 @@ static void irq_disable_depth_test(struct kunit *test) /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ irq_settings_clr_norequest(desc); =20 + return virq; +} + +static void irq_disable_depth_test(struct kunit *test) +{ + struct irq_desc *desc; + int virq, ret; + + virq =3D irq_test_setup_fake_irq(test, NULL); + + desc =3D irq_to_desc(virq); + KUNIT_ASSERT_PTR_NE(test, desc, NULL); + ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); KUNIT_EXPECT_EQ(test, ret, 0); =20 @@ -76,17 +89,11 @@ static void irq_free_disabled_test(struct kunit *test) struct irq_desc *desc; int virq, ret; =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, NULL); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, NULL); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); KUNIT_EXPECT_EQ(test, ret, 0); =20 @@ -118,17 +125,11 @@ static void irq_shutdown_depth_test(struct kunit *tes= t) if (!IS_ENABLED(CONFIG_SMP)) kunit_skip(test, "requires CONFIG_SMP for managed shutdown"); =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, &affinity); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &dummy_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, &affinity); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - data =3D irq_desc_get_irq_data(desc); KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 @@ -181,17 +182,11 @@ static void irq_cpuhotplug_test(struct kunit *test) =20 cpumask_copy(&affinity.mask, cpumask_of(1)); =20 - virq =3D irq_domain_alloc_descs(-1, 1, 0, NUMA_NO_NODE, &affinity); - KUNIT_ASSERT_GE(test, virq, 0); - - irq_set_chip_and_handler(virq, &fake_irq_chip, handle_simple_irq); + virq =3D irq_test_setup_fake_irq(test, &affinity); =20 desc =3D irq_to_desc(virq); KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 - /* On some architectures, IRQs are NOREQUEST | NOPROBE by default. */ - irq_settings_clr_norequest(desc); - data =3D irq_desc_get_irq_data(desc); KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 23:02:06 2025 Received: from mail-pf1-f173.google.com (mail-pf1-f173.google.com [209.85.210.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 686C52D0C75 for ; Fri, 22 Aug 2025 19:01:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889315; cv=none; b=bEPiX3s81nnx1HP9Loi3tSZ31oGpAvSr1CnLxA2Q1qEOHuLHIe1SYGctHr0KPPhLqZ0xEJVA2u0UAltX5C8dVXGsHtGhniZRXgJP37/DlEhCtqB9O7mHUIiWtersxrUNN6r5Gw582vq//L49EEWBJLceeUTzrYrocOZ62HnVW4w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889315; c=relaxed/simple; bh=cWxJVSCR6Z5YpDq7Nb824hJk5EnRMEes73DhMMFvzTw=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=DmJkjsMI27hUOglxLGZRn4ZcQj+XWO636wKAin3rK3DsiY0/I9phgTIWpZ3qV97Ep4BIqiKlIKa2tlBxpG8BrpQj66xrIuFPRF6RjCakLYSZi75I3Pcoaahjfzcc46G2drZZtB7yzvjOiyaNa9GjSgkdiStplzfzSlKZEOtznFU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=QF6T6KQJ; arc=none smtp.client-ip=209.85.210.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="QF6T6KQJ" Received: by mail-pf1-f173.google.com with SMTP id d2e1a72fcca58-76e2ea94c7cso2327839b3a.2 for ; Fri, 22 Aug 2025 12:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755889314; x=1756494114; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0JBmJP/TLWjJ8U7y1ITV3vUcgsR6oiKteW9+ZGeDW40=; b=QF6T6KQJYWo4pKAAkJ/Fu3+kaz1iYauZz6IJ+nuMQ/F96tUeFzG9hmNiNca7+1QDBb UxVrcHK6VPla6gc3Vu7LP0D2FIRTFphJEw0sXYLOfXj9WazEGQe7kjpK3z5ZSSYRBEI1 Et4ItcBQ8aKRZuwGZaryd9RjjKLkwH4ZQO2W4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755889314; x=1756494114; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0JBmJP/TLWjJ8U7y1ITV3vUcgsR6oiKteW9+ZGeDW40=; b=ovo3Mwx1jkShzW5VsUWLzm1sY62CGrwuPZFAgtNM6lgJgFWolMjoNyEagQ4fy4a4PE +gi0Ea8OLuftjBOsvXUgF6TDeeocPs6m15zQlIRcix0Zwbn0+kGrOVSugf9dguDEUK4T ICwMK9A1Q0OmMKL57z+IrPQv4nIM9+T+Kv04zHWqhEsOz+bMIBnRSdWxHSMupCjwARyk KGMLac86e1smg01SeOQQzqo7QaJv7gdoM5paAbC2IR87W9T1+z832ACEc7Rm9LQIHChe PQpbiEagigDqh9mv/t79etcxud0yBvHvATR1pPa6Kn5FAUN1l58WE8cocDXKU6CrBxY5 BfkQ== X-Forwarded-Encrypted: i=1; AJvYcCUit4BmXop/u1UfAGhqcaZsWhha98YPHS++v5MQ5ct8VxyB75K6Jc/hJBLtP3MWAqQpuMNZImni1Q5axQs=@vger.kernel.org X-Gm-Message-State: AOJu0YwYfR3dU6EPvx6rFbOqzTArBj2o/XBodD8ttARWX6ZJBHa7Lits Q3qIZUxvTFnzb0/khlywadx41lA5y6CTWZzVy9BWmqmjXq3l58z2/79lF3Sp+HSkvw== X-Gm-Gg: ASbGncu33fUDlsSPFWEglJoDEqNnXS0GpKxMyoUNuzlAMjqpITuNWtwkq5n7lgV715F ssY2jmKduWlsZ+8hI1TlU8a65l/E9lEr4ybtWZ5nrQtWqNXvO+hIjFYazPGKSdZtjjWvwkyOqCU V5Q30ETpcHMa1PwKmOTlZl8C9NWAt9y6wZQxmkCYEzPPt+BZEu9Wz6pOnPDuI9zoZtFKrkcFxk8 /3yzpvBwaGNGawu1ANHuWYVvceZPMVPW4TrzcAiB2Vu1EAcuaVSpTi5FCVjtGijLN+0oEdkdILA eY1/2K9KzL3gOGffFAp6iaahWKoIlMDCN+hQiZec4uE+rgpDldxPmHxHnaDJJcqUH3I+vLO9Bvv T59WWV1b0KKPL7HPcXJl8c6kE0D5zZQ8g+7H8HQ0zoer2sUlJpSJNzcnCy4E= X-Google-Smtp-Source: AGHT+IEYMj43iQarvl5ZATwez4b8yP9DJINCX4H7ZcT6d/vhB9KinVjiExt4tW5yIdovYyH/SKo4PQ== X-Received: by 2002:a05:6a20:2449:b0:239:a3b:33e5 with SMTP id adf61e73a8af0-24340d91844mr6212979637.39.1755889313625; Fri, 22 Aug 2025 12:01:53 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:154c:8cf:f7d0:c083]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-3254aa4fa20sm537789a91.17.2025.08.22.12.01.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Aug 2025 12:01:52 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , linux-kernel@vger.kernel.org, Guenter Roeck , Geert Uytterhoeven , kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH v2 3/6] genirq/test: Fail early if we can't request an IRQ Date: Fri, 22 Aug 2025 11:59:04 -0700 Message-ID: <20250822190140.2154646-4-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250822190140.2154646-1-briannorris@chromium.org> References: <20250822190140.2154646-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Requesting the IRQ is part of basic setup of the test. If it fails, most of the subsequent tests are likely to fail, and the output gets noisy. Use "assert" to fail early. Signed-off-by: Brian Norris Reviewed-by: David Gow Tested-by: Guenter Roeck --- (no changes since v1) kernel/irq/irq_test.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index f8f4532c2805..56baeb5041d6 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -71,7 +71,7 @@ static void irq_disable_depth_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_EQ(test, desc->depth, 0); =20 @@ -95,7 +95,7 @@ static void irq_free_disabled_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, desc, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_EQ(test, desc->depth, 0); =20 @@ -106,7 +106,7 @@ static void irq_free_disabled_test(struct kunit *test) KUNIT_EXPECT_GE(test, desc->depth, 1); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); KUNIT_EXPECT_EQ(test, desc->depth, 0); =20 free_irq(virq, NULL); @@ -134,7 +134,7 @@ static void irq_shutdown_depth_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_TRUE(test, irqd_is_activated(data)); KUNIT_EXPECT_TRUE(test, irqd_is_started(data)); @@ -191,7 +191,7 @@ static void irq_cpuhotplug_test(struct kunit *test) KUNIT_ASSERT_PTR_NE(test, data, NULL); =20 ret =3D request_irq(virq, noop_handler, 0, "test_irq", NULL); - KUNIT_EXPECT_EQ(test, ret, 0); + KUNIT_ASSERT_EQ(test, ret, 0); =20 KUNIT_EXPECT_TRUE(test, irqd_is_activated(data)); KUNIT_EXPECT_TRUE(test, irqd_is_started(data)); --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 23:02:06 2025 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 305DA2D190C for ; Fri, 22 Aug 2025 19:01:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889318; cv=none; b=o3onK0P8hf78kT4gppBnNrgg88xLTx+QPGi0dp5AdzdaWu8zC2ai/L+uP5t+cSXC04Url7FlIkHXzsuOxw91qsPhehhW8onVYXos48uE24GGLR4DTUWiTv4pV46Tlj5+1B4xqfwjg4pr+mdIVzAbG4gqTrmjyvuqnPP9a4dtWRM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889318; c=relaxed/simple; bh=Z9+YIhD1uTOT5saJkNAsez0Hs6ARMCMfX4GIc4ITcto=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=FclqWrKea9F/pSYChd7/rplhqBT58ko0SCOPhZIW2atPfjOpFF6q5DsrU4X020saiidE+G1dOKpp3cLwPXodJghmQs/mo65H8HujFTyw5SfPeBbqMBlJVc+w3GFQquLIU5VTKh2ybeC0mr8Gzjy/iP3pXl+aP3dELR3ptPm5mTo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=k0Yu2GqY; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="k0Yu2GqY" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-32326e5f0bfso2026758a91.3 for ; Fri, 22 Aug 2025 12:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755889316; x=1756494116; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ysw+3hrIgiJrYdQABB3+Dt5DgMOw9tDOT9yOl9vUjGI=; b=k0Yu2GqYzip6XibRR2bsbzbHDosvwNLw/QIWNcCeGnor08Kpu7TEc+iPR3qLEfwoDT D2zgIey6Hv+3HkYouZcWD3M7h5z8h0A9Bdhh4kF0zKTgYAe0PnsrIVP86yenoFiGbeOx NYE8x2OX/Nldivgptk10mEhmdSWY//gFq1QhA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755889316; x=1756494116; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ysw+3hrIgiJrYdQABB3+Dt5DgMOw9tDOT9yOl9vUjGI=; b=cwRooqWYBufOfadqBPrvqcLmeyaUlk6p4zMi1PDKeI6XWgHtyP+wJDXSHA8Xduqu15 cu0S9ui9xwtys+adCsKTVBlJGFdgemzMH92HNIjO8XmYBgZ9OI0etbvxTTN5b3iqzC8m cqB+68DiRq6uVTFMqOWvPR29IYl5Hm0B5Ui6oGzwvKNIQZ8GjX5oWL1ci7i5IOXaz5P3 ceJqvxHxPlinUBpqBxSFxYEGxq1QUsC5vlaGCeTL2X0I+jDjeEN9Hcl2M3Sd2A5HjrKR MvLKrehbAMWL/2+JDuNjtOtdgFnmC95mqBVwQbz3U7C4DuV6NITOIn5tp/85czMPxcB/ XGQA== X-Forwarded-Encrypted: i=1; AJvYcCWqM3jCNSVGWEauzLSE4CMIzbF+8Vd/SgM8XXo/dMzuXGN5EitQbZAl6O/vJAsPn9K58eYkUsDvhPAp7Zc=@vger.kernel.org X-Gm-Message-State: AOJu0YyEnxTqtahhH6KBxn3/aXwDlQK5oN5Xmi0RJbx75859Dz6/jtQj rKinbo+jpI6Aw8M5eXCrSF/tpWHdErB2hphlu6tM/z/KeuFUSBpZrKSsd5uUP+mA5w== X-Gm-Gg: ASbGncvixsoocp64U5pMlqYpY9z3SfmdrBgsTRZF9uur/3mtAcKIB0IrNQw9B9BrcJi TNnwKNrWjttpw5j5QxSW1pBju15M2tj2zX2exR9hgn1lVQOc1eHh3Bk77qEFd4DJSvBUIeiZIFz yZAgr18NMxkFGgvgkSvmNttnghtDb5oW35w2zju/MxCN27yw6+nX2wt7D2hoJ3CZFDjXYqs7qS1 7YlwBVUJYJoVLdQepFJk7TeGg9dUfIQOCQ6lXwqvjjZnFqKTSD6VwJT8Qrh5s5xxPZhCQhRvK/5 /WF0RfyOQc5KC0iUk8y6R3iSt76VcDjXRgTWYV9w/gEpS1orxzhO/ceA9uai7Eqa/DZEeuBS1+f HFMIn803wUVtwwGEH1xXKfjKgZgXlVtH2pXJBOi2czSALM25cqfQZtxMjGZLVwFnODe2opQ== X-Google-Smtp-Source: AGHT+IEqFAw76Lki0zkjH8qAF8RoMhFiXS9rdvzirdsLGc0PWioCNOpwr2TSYXdI2BqzX0XONe8bMQ== X-Received: by 2002:a17:90b:1dce:b0:315:af43:12ee with SMTP id 98e67ed59e1d1-32515ef8aebmr6307614a91.16.1755889315976; Fri, 22 Aug 2025 12:01:55 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:154c:8cf:f7d0:c083]) by smtp.gmail.com with UTF8SMTPSA id 98e67ed59e1d1-3254ae898fdsm401806a91.7.2025.08.22.12.01.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Aug 2025 12:01:55 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , linux-kernel@vger.kernel.org, Guenter Roeck , Geert Uytterhoeven , kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH v2 4/6] genirq/test: Depend on SPARSE_IRQ Date: Fri, 22 Aug 2025 11:59:05 -0700 Message-ID: <20250822190140.2154646-5-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250822190140.2154646-1-briannorris@chromium.org> References: <20250822190140.2154646-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Some architectures have a rather static IRQ layout, with a limited NR_IRQS. Without SPARSE_IRQ, we may not be able to allocate any new fake IRQs, and the test will fail. (This occurs on ARCH=3Dm68k, for example.) Additionally, managed-affinity is only supported with CONFIG_SPARSE_IRQ=3Dy, so irq_shutdown_depth_test() and irq_cpuhotplug_test() would fail without it. Add a 'SPARSE_IRQ' dependency to avoid these problems. Many architectures 'select SPARSE_IRQ', so this is easy to miss. Notably, this also excludes ARCH=3Dum from running any of these tests, even though some of them might work. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Signed-off-by: Brian Norris Reviewed-by: David Gow Tested-by: Guenter Roeck --- Changes in v2: * Make all tests depend on SPARSE_IRQ, not just a few (resolves ARCH=3Dm68k issues) kernel/irq/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/Kconfig b/kernel/irq/Kconfig index 08088b8e95ae..a75df2bb9db6 100644 --- a/kernel/irq/Kconfig +++ b/kernel/irq/Kconfig @@ -147,6 +147,7 @@ config GENERIC_IRQ_KEXEC_CLEAR_VM_FORWARD config IRQ_KUNIT_TEST bool "KUnit tests for IRQ management APIs" if !KUNIT_ALL_TESTS depends on KUNIT=3Dy + depends on SPARSE_IRQ default KUNIT_ALL_TESTS select IRQ_DOMAIN imply SMP --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 23:02:06 2025 Received: from mail-pg1-f177.google.com (mail-pg1-f177.google.com [209.85.215.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 904072D1F72 for ; Fri, 22 Aug 2025 19:01:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889320; cv=none; b=GYAxpHImNTFw+IOx76/XujqAaU5Sdwcapqed5t26VRZXKOQwJ3nPQ+n/CVU6tza7tYqtvafyRp6Eku9GLPgJ08G5fXSOnivY8zis6rKCpwDU96ZbZjSi1yWmeqlUjuC/LDsyIZ17+l5f6TUusD6cW2vWJ7qbKalPFkpc3dZ/e0Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889320; c=relaxed/simple; bh=T9Xl7UOSJb9bzLmKUWoy6oZTyLj8Bqzr11x7wqMwQ3U=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=a5TQYpqQRQALkAv2UQ8Tqu/YbxcyCSfFZuDve3JtHF9AgSGmxeq87MYy1A2GB8CjGgvVbmB6xEVloHl0vg0U4NMGTLduSG++8irccKvmMZe+/vxeS3JCFzmGt7u1ezFDPa7VGOILP+nemt6OpOl0WaXSi8VpYWOrEgUCvdZJ+jA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=LRLBgq0g; arc=none smtp.client-ip=209.85.215.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="LRLBgq0g" Received: by mail-pg1-f177.google.com with SMTP id 41be03b00d2f7-b47475cf8ecso1748975a12.0 for ; Fri, 22 Aug 2025 12:01:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755889318; x=1756494118; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=qQFaJ4AT7s0VyfipZWYXejbB1s7k8OeAeFLkpqOojDk=; b=LRLBgq0gWoq4oe33JtYY5EyN+MKqY2+G1BIP2Y0jY3XF4acKP0+xq8B8lYsSb9aSh9 XLgEPGqykvnnX09T6PsRK7Lb1KEKRcEUalp2bBGDqmnFZWw3VHoVG/QFGQZzwiU7AWKs 9WWno3bxXjeetiKUVz1m+j8PtrBE3A3CsOYek= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755889318; x=1756494118; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=qQFaJ4AT7s0VyfipZWYXejbB1s7k8OeAeFLkpqOojDk=; b=EckCeZDKdmpMuo3xw0FtscdU61HPe1CZbUhIflh2Lt14UFvfs649kjhhXUfECTasiV 5knGn7OfVxIrf6TziXq/m0TfNGUWNSj6x8IRkgOx8VDD5sALBEocJTHhIuvDk5Gf4AmL 1fpvQBg2iGgsBo5jFyCsyVDmXylAQwIzHA+KBWzsfNlxg/udQelVCXGTsCWP/++7TRY5 x/XeTWC5ORPMLTeS/shwb59geEP2IsGyslv3mOtkPveIkEzkaOgDEQoliE3UOJeFkMZ4 4F65oklNN7O5yipPAug7p/0+GooOUZEOjUeTReQ4Dg+dyHvKklNnILCbxY9QDMn6y5Qg BWaw== X-Forwarded-Encrypted: i=1; AJvYcCW8Ubz9D7Juit2jZUMO/KT3dT89nljiwfVMVft1c2jEajXf22U9YqRCIZgo3bwUvqgcemC29VlxpGuf7do=@vger.kernel.org X-Gm-Message-State: AOJu0YwvF54LiSeaL8UQwMI7BnPt+/pLk19LDsqyrwRiQ9F5yVvBZ6v3 IOs0JgYuhxZeebIRu7Ld/cmFtaQ/4ID5tl6pG7X8/SDMXCDUG6tpt8Io8UCdlIr8Mw== X-Gm-Gg: ASbGncukTzOtKcPMKT6+8qgGhkTiShW+CjiZqn7YAx02NkrdnMVlr7c+yNP6IqmE0Mo rHMoYK4EvHOl03XUYsnR35l3nQBo4AKRXu9RxXFl85dHbGYjPBdUhpFW3xOebbeDtF35zoZfJzN WymwF0ckX6LIvCi/S9uvYhpxMFHYNc+8h6euoftJIA3r/CHpx1afOcEtNTLpk6bpxEA6sUbnAcV tCU71xoleZ33jE3k5Bi50i8mD5XDpay5RsUw+95lTDvSuwSs83bOsdV6p9Ym/4R5Jod16g81pTM SbdDw+Fs3BXyzy3IiNo2pe2Cuagv0DQPmxfoAfpfEn9tHJ32K0Mw4VcuwEAH3Gqm0021AkMqy5j fJAxx8WAESu/ozWQg/E4FFkJ6zqA7Jx60zyY/QBZFhN2mlb/PHe3C3G84EHw= X-Google-Smtp-Source: AGHT+IE7/lr1yAQ07k6SksI7di9GFkZg/VTeRFaVY3AiRILkRCeCyUcKXcDhSV/7rbuWZWKVSC5mEA== X-Received: by 2002:a17:902:d592:b0:240:3f3d:fd37 with SMTP id d9443c01a7336-2462ee80b64mr49717985ad.27.1755889317735; Fri, 22 Aug 2025 12:01:57 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:154c:8cf:f7d0:c083]) by smtp.gmail.com with UTF8SMTPSA id d9443c01a7336-246687af23fsm3346895ad.51.2025.08.22.12.01.56 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Aug 2025 12:01:56 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , linux-kernel@vger.kernel.org, Guenter Roeck , Geert Uytterhoeven , kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH v2 5/6] genirq/test: Drop CONFIG_GENERIC_IRQ_MIGRATION assumptions Date: Fri, 22 Aug 2025 11:59:06 -0700 Message-ID: <20250822190140.2154646-6-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250822190140.2154646-1-briannorris@chromium.org> References: <20250822190140.2154646-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Not all platforms use the generic IRQ migration code, even if they select GENERIC_IRQ_MIGRATION. (See, for example, powerpc / pseries_cpu_disable().) If such platforms don't perform managed shutdown the same way, the IRQ may not actually shut down, and we'll fail these tests: [ 4.357022][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:211 [ 4.357022][ T101] Expected irqd_is_activated(data) to be false, bu= t is true [ 4.358128][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:212 [ 4.358128][ T101] Expected irqd_is_started(data) to be false, but = is true [ 4.375558][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:216 [ 4.375558][ T101] Expected irqd_is_activated(data) to be false, bu= t is true [ 4.376088][ T101] # irq_cpuhotplug_test: EXPECTATION FAILED at ker= nel/irq/irq_test.c:217 [ 4.376088][ T101] Expected irqd_is_started(data) to be false, but = is true [ 4.377851][ T1] # irq_cpuhotplug_test: pass:0 fail:1 skip:0 tota= l:1 [ 4.377901][ T1] not ok 4 irq_cpuhotplug_test [ 4.378073][ T1] # irq_test_cases: pass:3 fail:1 skip:0 total:4 Rather than test that PowerPC performs migration the same way as the IRQ core, let's just drop the state checks. The point of the test was to ensure we kept |depth| balanced, and we can still test for that. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Signed-off-by: Brian Norris Reviewed-by: David Gow Tested-by: Guenter Roeck --- (no changes since v1) kernel/irq/irq_test.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index 56baeb5041d6..bbb89a3e1153 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -203,13 +203,9 @@ static void irq_cpuhotplug_test(struct kunit *test) KUNIT_EXPECT_EQ(test, desc->depth, 1); =20 KUNIT_EXPECT_EQ(test, remove_cpu(1), 0); - KUNIT_EXPECT_FALSE(test, irqd_is_activated(data)); - KUNIT_EXPECT_FALSE(test, irqd_is_started(data)); KUNIT_EXPECT_GE(test, desc->depth, 1); KUNIT_EXPECT_EQ(test, add_cpu(1), 0); =20 - KUNIT_EXPECT_FALSE(test, irqd_is_activated(data)); - KUNIT_EXPECT_FALSE(test, irqd_is_started(data)); KUNIT_EXPECT_EQ(test, desc->depth, 1); =20 enable_irq(virq); --=20 2.51.0.rc2.233.g662b1ed5c5-goog From nobody Fri Oct 3 23:02:06 2025 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 838CC2D29DB for ; Fri, 22 Aug 2025 19:02:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889322; cv=none; b=UVzmruFRyPVNpBsZ8tl4hSBfldfAafiZHj/N9AqJPDhTuoe5xLFOySgZHv39hftuGS5tIZzLOOOr+5uqNBP3DsTK+cGMSz3lrvoiJty8tpbMRLEKOUajCrxUjHw7LiYo4ayw5HkoUsSzzaJUjlr89WOLus9U5YbdSeb4wiHoDPI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1755889322; c=relaxed/simple; bh=n6toBV9/E43mV3bFSotlKlEdZsvEcL1F7i2m03IpKuc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=EqE0J5IwH1Tm/+igTKfhYGrCTfaLPBVO/of9xxfGzoMasWmQKMsI5O+EQcsQBmRuYodoMD9XOriXemH/0nOau+XrIQltmXc0vf6VMN/01TxpnE5r3jshTpzvs+LaxDvZsIghMMuA+ymAcZ414HXa645HIDgBGCgAeoMgGqgYhO4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=V1tptwAk; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="V1tptwAk" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-b471754c159so1665804a12.3 for ; Fri, 22 Aug 2025 12:02:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1755889320; x=1756494120; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Q2KczgQGxGJ8RIuPHcEG6UwnRo5SfqUAX44DQ5/YPlA=; b=V1tptwAkrHo+XI2Oy5KCfSSuHgJFa3Da8djykD6hCv0urDVZH5kP8gIfuDfWHGF3Bf 1xikgeghIb32ibwPsERe8gCM9tFY86YxR+dxfBreQMWy/P/UOEFRgqCre+oOQ388/oKe EaZabHCDeLNhmPDQymcq8H141kEi61iv2ksrQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1755889320; x=1756494120; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Q2KczgQGxGJ8RIuPHcEG6UwnRo5SfqUAX44DQ5/YPlA=; b=ES9jZvLR0IiIJBey6eyTfuzVZbmbNrLYZmxAjFilqi3fEuxldCVkc0OR8E5YlliUG/ 3HUWoUuGC0dUkK+ro8mNcNsWzljhpt48qzYdM/coYSqzPNpE5eaZDgVTBKMceHym6jOC /C7sCHx0W4eE6Vnw4Z3rOHlYvJuZGA+VxG499/ZNy4WyjNPvV40mS1NTlNkk65EFvbr+ tz4ZiwwCiYTjV5QPjpxxrQy4CCP3XqJe3e7HygOq2JDarsei/RBMFmYYDa/n+dcctRSm yBJHpcvbqTnv/iKSTKq096UmdsQ968RKVBlCywolJrkznME+4JDd4StfS7N3RVFJ5tQv uNDQ== X-Forwarded-Encrypted: i=1; AJvYcCXkE7Nm5ftFrvWx+wDfZuzgjYhM0VOueBLUqFhpjsqkATbvYRsi4uZbBDKnvAVpf64Sw062qO4iP8+d9HI=@vger.kernel.org X-Gm-Message-State: AOJu0YwYnqD0R0tsDiSrLZSSrv+Z+O3zqLInTzl44BpSGU7MovlrE5Ln ivCQGKMvktJlGzQpKUazW2ukZnGZGMCyKz69XkcEnIthUlED3JHAqRmEZIZ2EO67PQ== X-Gm-Gg: ASbGncuA/2lmvgZOu2oi3O++KRKr/vYlfq0yZUH3iT4LMvFDB8LCCUJKCrQiQq9hyfa FXErjxJm/H9mejtpY3mlmUsIDa3sNYALbfOX9+PDr4V5U6ovS+sEXIzucgsRlpwm0SK5RT0QmNR l+ndtxBHFlkZiGwdOxU915KsKtDwGI4qDdMLwsSucPF6/StJt87yETp+tn+CDXx7Cm8OJgnMoFu 1uqwRhVyADXDYDLQULGKXJbW4BpZEVpJTkozLmT2zq0GdogV21ZVz5h84qYwn8Tzb2Z+QewXYHE j2IjZfKWkf6iIsJeqna1J+mI+9Mc5v7xSE/zbfJPuktP/4PJMb6EDRcOYPh44Y2mUbFJg7uSLPF vh+WQwENqWXJesqMrR5C/I6w0UfgOrc1evFjMsxF6+kNkjnKPIuR2TvHSaZGdAD+D87Gbnw== X-Google-Smtp-Source: AGHT+IEkAYbFXJfvERFeRy+iBP0RnG0l2hEWY0aJzOQFI/VovM3OrRaH1jMB6Vh2mtc7UdBmAp8Gug== X-Received: by 2002:a17:903:228f:b0:246:61e:b562 with SMTP id d9443c01a7336-2462f1d5493mr52797145ad.59.1755889319635; Fri, 22 Aug 2025 12:01:59 -0700 (PDT) Received: from localhost ([2a00:79e0:2e14:7:154c:8cf:f7d0:c083]) by smtp.gmail.com with UTF8SMTPSA id 41be03b00d2f7-b49cb8b4b98sm472066a12.19.2025.08.22.12.01.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Aug 2025 12:01:58 -0700 (PDT) From: Brian Norris To: Thomas Gleixner Cc: David Gow , linux-kernel@vger.kernel.org, Guenter Roeck , Geert Uytterhoeven , kunit-dev@googlegroups.com, Brian Norris Subject: [PATCH v2 6/6] genirq/test: Ensure CPU 1 is online for hotplug test Date: Fri, 22 Aug 2025 11:59:07 -0700 Message-ID: <20250822190140.2154646-7-briannorris@chromium.org> X-Mailer: git-send-email 2.51.0.rc2.233.g662b1ed5c5-goog In-Reply-To: <20250822190140.2154646-1-briannorris@chromium.org> References: <20250822190140.2154646-1-briannorris@chromium.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" It's possible to run these tests on platforms that think they have a hotpluggable CPU1, but for whatever reason, CPU1 is not online and can't be brought online: # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:210 Expected remove_cpu(1) =3D=3D 0, but remove_cpu(1) =3D=3D 1 (0x1) CPU1: failed to boot: -38 # irq_cpuhotplug_test: EXPECTATION FAILED at kernel/irq/irq_test.c:214 Expected add_cpu(1) =3D=3D 0, but add_cpu(1) =3D=3D -38 (0xffffffffffffffda) Check that CPU1 is actually online before trying to run the test. Fixes: 66067c3c8a1e ("genirq: Add kunit tests for depth counts") Reported-by: Guenter Roeck Signed-off-by: Brian Norris Reviewed-by: David Gow Tested-by: Guenter Roeck --- (no changes since v1) kernel/irq/irq_test.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/irq/irq_test.c b/kernel/irq/irq_test.c index bbb89a3e1153..e2d31914b3c4 100644 --- a/kernel/irq/irq_test.c +++ b/kernel/irq/irq_test.c @@ -179,6 +179,8 @@ static void irq_cpuhotplug_test(struct kunit *test) kunit_skip(test, "requires more than 1 CPU for CPU hotplug"); if (!cpu_is_hotpluggable(1)) kunit_skip(test, "CPU 1 must be hotpluggable"); + if (!cpu_online(1)) + kunit_skip(test, "CPU 1 must be online"); =20 cpumask_copy(&affinity.mask, cpumask_of(1)); =20 --=20 2.51.0.rc2.233.g662b1ed5c5-goog