.../devicetree/bindings/arm/ti/k3.yaml | 1 + .../hwmon/kontron,sl28cpld-hwmon.yaml | 1 + .../bindings/mfd/kontron,sl28cpld.yaml | 7 +- .../nvmem/layouts/kontron,sl28-vpd.yaml | 7 +- .../watchdog/kontron,sl28cpld-wdt.yaml | 7 +- arch/arm64/boot/dts/ti/Makefile | 6 + .../dts/ti/k3-am67a-kontron-sa67-base.dts | 1092 +++++++++++++++++ .../dts/ti/k3-am67a-kontron-sa67-gbe1.dtso | 19 + .../ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso | 24 + drivers/hwmon/sl28cpld-hwmon.c | 76 +- 10 files changed, 1234 insertions(+), 6 deletions(-) create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-base.dts create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-gbe1.dtso create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso
Now that the PMIC support is there, we can finally, upstream the support for this board. Besides the usual device tree, this patchset contains the support for the on-board house keeping MCU. It make extensive reuse of the drivers for the former SMARC-sAL28 board. Besides different hwmon sensors, all the dt binding patches will just add a board specific compatible (in addition to the old sl28 compatible) to make any future board specific quirks possible. I'm aware that there is a patch [1] which moves the sl28cpld MFD schema to a different directory. Once that patch is merged, I'll repost this series. But I already want to get some early feedback. [1] https://lore.kernel.org/r/20250822075712.27314-2-krzysztof.kozlowski@linaro.org/ Michael Walle (7): dt-bindings: arm: ti: Add bindings for Kontron SMARC-sAM67 module dt-bindings: mfd: sl28cpld: add sa67mcu compatible dt-bindings: hwmon: sl28cpld: add sa67mcu compatible dt-bindings: watchdog: add SMARC-sAM67 support dt-bindings: nvmem: sl28cpld: add sa67mcu compatible hwmon: sl28cpld: add SMARC-sAM67 support arm64: dts: ti: Add support for Kontron SMARC-sAM67 .../devicetree/bindings/arm/ti/k3.yaml | 1 + .../hwmon/kontron,sl28cpld-hwmon.yaml | 1 + .../bindings/mfd/kontron,sl28cpld.yaml | 7 +- .../nvmem/layouts/kontron,sl28-vpd.yaml | 7 +- .../watchdog/kontron,sl28cpld-wdt.yaml | 7 +- arch/arm64/boot/dts/ti/Makefile | 6 + .../dts/ti/k3-am67a-kontron-sa67-base.dts | 1092 +++++++++++++++++ .../dts/ti/k3-am67a-kontron-sa67-gbe1.dtso | 19 + .../ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso | 24 + drivers/hwmon/sl28cpld-hwmon.c | 76 +- 10 files changed, 1234 insertions(+), 6 deletions(-) create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-base.dts create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-gbe1.dtso create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso -- 2.39.5
On Fri, 22 Aug 2025 15:15:24 +0200, Michael Walle wrote: > Now that the PMIC support is there, we can finally, upstream the > support for this board. Besides the usual device tree, this > patchset contains the support for the on-board house keeping MCU. It > make extensive reuse of the drivers for the former SMARC-sAL28 > board. Besides different hwmon sensors, all the dt binding patches > will just add a board specific compatible (in addition to the old > sl28 compatible) to make any future board specific quirks possible. > > I'm aware that there is a patch [1] which moves the sl28cpld MFD > schema to a different directory. Once that patch is merged, I'll > repost this series. But I already want to get some early feedback. > > [1] https://lore.kernel.org/r/20250822075712.27314-2-krzysztof.kozlowski@linaro.org/ > > Michael Walle (7): > dt-bindings: arm: ti: Add bindings for Kontron SMARC-sAM67 module > dt-bindings: mfd: sl28cpld: add sa67mcu compatible > dt-bindings: hwmon: sl28cpld: add sa67mcu compatible > dt-bindings: watchdog: add SMARC-sAM67 support > dt-bindings: nvmem: sl28cpld: add sa67mcu compatible > hwmon: sl28cpld: add SMARC-sAM67 support > arm64: dts: ti: Add support for Kontron SMARC-sAM67 > > .../devicetree/bindings/arm/ti/k3.yaml | 1 + > .../hwmon/kontron,sl28cpld-hwmon.yaml | 1 + > .../bindings/mfd/kontron,sl28cpld.yaml | 7 +- > .../nvmem/layouts/kontron,sl28-vpd.yaml | 7 +- > .../watchdog/kontron,sl28cpld-wdt.yaml | 7 +- > arch/arm64/boot/dts/ti/Makefile | 6 + > .../dts/ti/k3-am67a-kontron-sa67-base.dts | 1092 +++++++++++++++++ > .../dts/ti/k3-am67a-kontron-sa67-gbe1.dtso | 19 + > .../ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso | 24 + > drivers/hwmon/sl28cpld-hwmon.c | 76 +- > 10 files changed, 1234 insertions(+), 6 deletions(-) > create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-base.dts > create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-gbe1.dtso > create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso > > -- > 2.39.5 > > > My bot found new DTB warnings on the .dts files added or changed in this series. Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings are fixed by another series. Ultimately, it is up to the platform maintainer whether these warnings are acceptable or not. No need to reply unless the platform maintainer has comments. If you already ran DT checks and didn't see these error(s), then make sure dt-schema is up to date: pip3 install dtschema --upgrade This patch series was applied (using b4) to base: Base: attempting to guess base-commit... Base: tags/next-20250822 (exact match) If this is not the correct base, please add 'base-commit' tag (or use b4 which does this automatically) New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/ti/' for 20250822131531.1366437-1-mwalle@kernel.org: arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-base.dtb: pmic@44 (ti,tps652g1): 'gpio-line-names' does not match any of the regexes: '^buck([1-5]|12|34|123|1234)-supply$', '^ldo[1-4]-supply$', '^pinctrl-[0-9]+$' from schema $id: http://devicetree.org/schemas/mfd/ti,tps6594.yaml#
On Fri Aug 22, 2025 at 11:27 PM CEST, Rob Herring (Arm) wrote: > New warnings running 'make CHECK_DTBS=y for arch/arm64/boot/dts/ti/' for 20250822131531.1366437-1-mwalle@kernel.org: > > arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-base.dtb: pmic@44 (ti,tps652g1): 'gpio-line-names' does not match any of the regexes: '^buck([1-5]|12|34|123|1234)-supply$', '^ldo[1-4]-supply$', '^pinctrl-[0-9]+$' > from schema $id: http://devicetree.org/schemas/mfd/ti,tps6594.yaml# Damn, very late change on the device tree :o I'll add a new patch to add gpio-line-names: true to bindings/mfd/ti,tps6594.yaml -michael
On 15:15-20250822, Michael Walle wrote: > Now that the PMIC support is there, we can finally, upstream the > support for this board. Besides the usual device tree, this > patchset contains the support for the on-board house keeping MCU. It > make extensive reuse of the drivers for the former SMARC-sAL28 > board. Besides different hwmon sensors, all the dt binding patches > will just add a board specific compatible (in addition to the old > sl28 compatible) to make any future board specific quirks possible. > > I'm aware that there is a patch [1] which moves the sl28cpld MFD > schema to a different directory. Once that patch is merged, I'll > repost this series. But I already want to get some early feedback. > > [1] https://lore.kernel.org/r/20250822075712.27314-2-krzysztof.kozlowski@linaro.org/ > > Michael Walle (7): > dt-bindings: arm: ti: Add bindings for Kontron SMARC-sAM67 module > dt-bindings: mfd: sl28cpld: add sa67mcu compatible > dt-bindings: hwmon: sl28cpld: add sa67mcu compatible > dt-bindings: watchdog: add SMARC-sAM67 support > dt-bindings: nvmem: sl28cpld: add sa67mcu compatible > hwmon: sl28cpld: add SMARC-sAM67 support > arm64: dts: ti: Add support for Kontron SMARC-sAM67 Since this goes through multiple maintainers, may I suggest the following strategy? for this window: * send dts and board binding changes dropping the nodes that are yet to be upstream * send the compatible changes to each of the maintainers Next window: * add the nodes based on acceptance of the driver bindings This removes multiple maintainers needing to give me immutable tags etc. What do you think? > > .../devicetree/bindings/arm/ti/k3.yaml | 1 + > .../hwmon/kontron,sl28cpld-hwmon.yaml | 1 + > .../bindings/mfd/kontron,sl28cpld.yaml | 7 +- > .../nvmem/layouts/kontron,sl28-vpd.yaml | 7 +- > .../watchdog/kontron,sl28cpld-wdt.yaml | 7 +- > arch/arm64/boot/dts/ti/Makefile | 6 + > .../dts/ti/k3-am67a-kontron-sa67-base.dts | 1092 +++++++++++++++++ > .../dts/ti/k3-am67a-kontron-sa67-gbe1.dtso | 19 + > .../ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso | 24 + > drivers/hwmon/sl28cpld-hwmon.c | 76 +- > 10 files changed, 1234 insertions(+), 6 deletions(-) > create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-base.dts > create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-gbe1.dtso > create mode 100644 arch/arm64/boot/dts/ti/k3-am67a-kontron-sa67-rtc-rv8263.dtso > > -- > 2.39.5 > -- Regards, Nishanth Menon Key (0xDDB5849D1736249D) / Fingerprint: F8A2 8693 54EB 8232 17A3 1A34 DDB5 849D 1736 249D https://ti.com/opensource
On Fri Aug 22, 2025 at 5:23 PM CEST, Nishanth Menon wrote: > On 15:15-20250822, Michael Walle wrote: > > Now that the PMIC support is there, we can finally, upstream the > > support for this board. Besides the usual device tree, this > > patchset contains the support for the on-board house keeping MCU. It > > make extensive reuse of the drivers for the former SMARC-sAL28 > > board. Besides different hwmon sensors, all the dt binding patches > > will just add a board specific compatible (in addition to the old > > sl28 compatible) to make any future board specific quirks possible. > > > > I'm aware that there is a patch [1] which moves the sl28cpld MFD > > schema to a different directory. Once that patch is merged, I'll > > repost this series. But I already want to get some early feedback. > > > > [1] https://lore.kernel.org/r/20250822075712.27314-2-krzysztof.kozlowski@linaro.org/ > > > > Michael Walle (7): > > dt-bindings: arm: ti: Add bindings for Kontron SMARC-sAM67 module > > dt-bindings: mfd: sl28cpld: add sa67mcu compatible > > dt-bindings: hwmon: sl28cpld: add sa67mcu compatible > > dt-bindings: watchdog: add SMARC-sAM67 support > > dt-bindings: nvmem: sl28cpld: add sa67mcu compatible > > hwmon: sl28cpld: add SMARC-sAM67 support > > arm64: dts: ti: Add support for Kontron SMARC-sAM67 > > Since this goes through multiple maintainers, may I suggest the > following strategy? > > for this window: > * send dts and board binding changes dropping the nodes that are yet to > be upstream > * send the compatible changes to each of the maintainers > > Next window: > * add the nodes based on acceptance of the driver bindings > > This removes multiple maintainers needing to give me immutable tags etc. > > What do you think? Not sure, if this needs an IB anyway or if the DTS can be pulled by the corresponding SoC subsys and the DT binding can go through another tree in the same cycle. If not, I can certainly split the device tree (to my knowledge, it was said that it should be a complete description :). I'd expect that Lee is picking up the first 6 patches after they got an ACK. Please correct me if I'm wrong, Lee. In any case, I'd give this v1 some time to get some feedback on the patches. -michael
> I'd expect that Lee is picking up the first 6 patches after they got > an ACK. Please correct me if I'm wrong, Lee. Ah my bad, patches 2-6, i.e. everything belonging to the MFD driver. -michael
On Fri, 22 Aug 2025 15:15:24 +0200, Michael Walle wrote:
> Now that the PMIC support is there, we can finally, upstream the
> support for this board. Besides the usual device tree, this
> patchset contains the support for the on-board house keeping MCU. It
> make extensive reuse of the drivers for the former SMARC-sAL28
> board. Besides different hwmon sensors, all the dt binding patches
> will just add a board specific compatible (in addition to the old
> sl28 compatible) to make any future board specific quirks possible.
>
> [...]
Applied, thanks!
[5/7] dt-bindings: nvmem: sl28cpld: add sa67mcu compatible
commit: 530c7063f753e18a8c4b793cc9e96e3b529dc81d
Best regards,
--
Srinivas Kandagatla <srini@kernel.org>
© 2016 - 2025 Red Hat, Inc.