.../boot/dts/exynos/exynos2200-pinctrl.dtsi | 2 +- arch/arm64/boot/dts/exynos/exynos2200.dtsi | 1433 ++++++++++++++++- 2 files changed, 1398 insertions(+), 37 deletions(-)
Hey, folks! This patchset adds serial busses, implemented in usi, for exynos2200. It's missing spi, due to me having troubles with reads when testing. Serial_0/1 have not been included in the patchset, as it seems like they're encapsulated in usi blocks, but are the only implemented protocol and/or do not have a dedicated register for setting other protocols in a sysreg. That'd at least require patches in the usi driver and bindings to add support for. About the naming convention for usi nodes, I've chosen to keep the downstream one instead of relabelling all to avoid confusion when cross-referencing the vendor DT and to keep consistency with clock names. They're labelled the same in the bootloader too. Best regards, Ivaylo Changes in v3: - drop the serial_0/1 patch - add r-b tags from Sam - increase the size of all syscon to 0x10000 and not 0x3000 - change description of last patch to be more meaningful regarding the usiN and usiN_i2c mess - s/usi6_i2c_cmgp/usi_i2c_cmgp6, following the TRM naming convention Changes in v2: - add a patch that switches address and size cells to 1 in /soc - adjust all new nodes to define reg props with 2 cells in total instead of 4 Ivaylo Ivanov (4): arm64: dts: exynos2200: fix typo in hsi2c23 bus pins label arm64: dts: exynos2200: use 32-bit address space for /soc arm64: dts: exynos2200: increase the size of all syscons arm64: dts: exynos2200: define all usi nodes .../boot/dts/exynos/exynos2200-pinctrl.dtsi | 2 +- arch/arm64/boot/dts/exynos/exynos2200.dtsi | 1433 ++++++++++++++++- 2 files changed, 1398 insertions(+), 37 deletions(-) -- 2.43.0
On Fri, Aug 15, 2025 at 2:05 AM Ivaylo Ivanov <ivo.ivanov.ivanov1@gmail.com> wrote: > > Hey, folks! > > This patchset adds serial busses, implemented in usi, for exynos2200. > It's missing spi, due to me having troubles with reads when testing. > Serial_0/1 have not been included in the patchset, as it seems like > they're encapsulated in usi blocks, but are the only implemented > protocol and/or do not have a dedicated register for setting other > protocols in a sysreg. That'd at least require patches in the usi > driver and bindings to add support for. > > About the naming convention for usi nodes, I've chosen to keep the > downstream one instead of relabelling all to avoid confusion when > cross-referencing the vendor DT and to keep consistency with clock > names. They're labelled the same in the bootloader too. > > Best regards, > Ivaylo > > Changes in v3: > - drop the serial_0/1 patch Why did you decide to drop it? As I understand, having a serial console enabled can be quite valuable for this platform bring up. If you don't know how to add the related USI node -- it's ok, can be done later, as soon as the serial works without it. > - add r-b tags from Sam > - increase the size of all syscon to 0x10000 and not 0x3000 > - change description of last patch to be more meaningful regarding the > usiN and usiN_i2c mess > - s/usi6_i2c_cmgp/usi_i2c_cmgp6, following the TRM naming convention > > Changes in v2: > - add a patch that switches address and size cells to 1 in /soc > - adjust all new nodes to define reg props with 2 cells in total instead of 4 > > Ivaylo Ivanov (4): > arm64: dts: exynos2200: fix typo in hsi2c23 bus pins label > arm64: dts: exynos2200: use 32-bit address space for /soc > arm64: dts: exynos2200: increase the size of all syscons > arm64: dts: exynos2200: define all usi nodes > > .../boot/dts/exynos/exynos2200-pinctrl.dtsi | 2 +- > arch/arm64/boot/dts/exynos/exynos2200.dtsi | 1433 ++++++++++++++++- > 2 files changed, 1398 insertions(+), 37 deletions(-) > > -- > 2.43.0 > >
On 8/16/25 20:29, Sam Protsenko wrote: > On Fri, Aug 15, 2025 at 2:05 AM Ivaylo Ivanov > <ivo.ivanov.ivanov1@gmail.com> wrote: >> Hey, folks! >> >> This patchset adds serial busses, implemented in usi, for exynos2200. >> It's missing spi, due to me having troubles with reads when testing. >> Serial_0/1 have not been included in the patchset, as it seems like >> they're encapsulated in usi blocks, but are the only implemented >> protocol and/or do not have a dedicated register for setting other >> protocols in a sysreg. That'd at least require patches in the usi >> driver and bindings to add support for. >> >> About the naming convention for usi nodes, I've chosen to keep the >> downstream one instead of relabelling all to avoid confusion when >> cross-referencing the vendor DT and to keep consistency with clock >> names. They're labelled the same in the bootloader too. >> >> Best regards, >> Ivaylo >> >> Changes in v3: >> - drop the serial_0/1 patch > Why did you decide to drop it? As I understand, having a serial > console enabled can be quite valuable for this platform bring up. On the only board that is supported (g0s), serial can either be accessed via a special usb-c cable, whose way of working only Samsung knows, or soldering to uart pads on a tiny masked jtag (?) connector on the motherboard. The latter I'm not sure exists, as I haven't checked on g0s. (it does on dreamlte). Using uart is not really viable for debugging, framebuffer/usb work too :) > If you don't know how to add the related USI node -- it's ok, can be done > later, as soon as the serial works without it. I can't test that. On dreamlte a similar scenario exists, however usiv1 does not require the clock gating code, so not encapsulating it in a USI node is fine. Not sure about g0s, however. Best regards, Ivaylo > >> - add r-b tags from Sam >> - increase the size of all syscon to 0x10000 and not 0x3000 >> - change description of last patch to be more meaningful regarding the >> usiN and usiN_i2c mess >> - s/usi6_i2c_cmgp/usi_i2c_cmgp6, following the TRM naming convention >> >> Changes in v2: >> - add a patch that switches address and size cells to 1 in /soc >> - adjust all new nodes to define reg props with 2 cells in total instead of 4 >> >> Ivaylo Ivanov (4): >> arm64: dts: exynos2200: fix typo in hsi2c23 bus pins label >> arm64: dts: exynos2200: use 32-bit address space for /soc >> arm64: dts: exynos2200: increase the size of all syscons >> arm64: dts: exynos2200: define all usi nodes >> >> .../boot/dts/exynos/exynos2200-pinctrl.dtsi | 2 +- >> arch/arm64/boot/dts/exynos/exynos2200.dtsi | 1433 ++++++++++++++++- >> 2 files changed, 1398 insertions(+), 37 deletions(-) >> >> -- >> 2.43.0 >> >>
On 8/15/25 10:04, Ivaylo Ivanov wrote: > Hey, folks! > > This patchset adds serial busses, implemented in usi, for exynos2200. > It's missing spi, due to me having troubles with reads when testing. > Serial_0/1 have not been included in the patchset, as it seems like > they're encapsulated in usi blocks, but are the only implemented > protocol and/or do not have a dedicated register for setting other > protocols in a sysreg. That'd at least require patches in the usi > driver and bindings to add support for. > > About the naming convention for usi nodes, I've chosen to keep the > downstream one instead of relabelling all to avoid confusion when > cross-referencing the vendor DT and to keep consistency with clock > names. They're labelled the same in the bootloader too. BUMP - when is this going to get merged? I had a few other things I wanted to upstream before merge cycle. Best regards, Ivaylo > > Best regards, > Ivaylo > > Changes in v3: > - drop the serial_0/1 patch > - add r-b tags from Sam > - increase the size of all syscon to 0x10000 and not 0x3000 > - change description of last patch to be more meaningful regarding the > usiN and usiN_i2c mess > - s/usi6_i2c_cmgp/usi_i2c_cmgp6, following the TRM naming convention > > Changes in v2: > - add a patch that switches address and size cells to 1 in /soc > - adjust all new nodes to define reg props with 2 cells in total instead of 4 > > Ivaylo Ivanov (4): > arm64: dts: exynos2200: fix typo in hsi2c23 bus pins label > arm64: dts: exynos2200: use 32-bit address space for /soc > arm64: dts: exynos2200: increase the size of all syscons > arm64: dts: exynos2200: define all usi nodes > > .../boot/dts/exynos/exynos2200-pinctrl.dtsi | 2 +- > arch/arm64/boot/dts/exynos/exynos2200.dtsi | 1433 ++++++++++++++++- > 2 files changed, 1398 insertions(+), 37 deletions(-) >
On 29/08/2025 12:40, Ivaylo Ivanov wrote: > On 8/15/25 10:04, Ivaylo Ivanov wrote: >> Hey, folks! >> >> This patchset adds serial busses, implemented in usi, for exynos2200. >> It's missing spi, due to me having troubles with reads when testing. >> Serial_0/1 have not been included in the patchset, as it seems like >> they're encapsulated in usi blocks, but are the only implemented >> protocol and/or do not have a dedicated register for setting other >> protocols in a sysreg. That'd at least require patches in the usi >> driver and bindings to add support for. >> >> About the naming convention for usi nodes, I've chosen to keep the >> downstream one instead of relabelling all to avoid confusion when >> cross-referencing the vendor DT and to keep consistency with clock >> names. They're labelled the same in the bootloader too. > > BUMP - when is this going to get merged? I had a few other things OSSE25... You can help out by reviewing other patches on the mailing lists in order to relieve the burden of maintainers and move your patches higher up the list. > I wanted to upstream before merge cycle. You should have posted them already. b4 handles dependencies, this maintainer can read cover letters. I plan to clear my todo queue this weekend and close my merge window within two weeks due to travel. Best regards, Krzysztof
On 8/29/25 13:55, Krzysztof Kozlowski wrote: > On 29/08/2025 12:40, Ivaylo Ivanov wrote: >> On 8/15/25 10:04, Ivaylo Ivanov wrote: >>> Hey, folks! >>> >>> This patchset adds serial busses, implemented in usi, for exynos2200. >>> It's missing spi, due to me having troubles with reads when testing. >>> Serial_0/1 have not been included in the patchset, as it seems like >>> they're encapsulated in usi blocks, but are the only implemented >>> protocol and/or do not have a dedicated register for setting other >>> protocols in a sysreg. That'd at least require patches in the usi >>> driver and bindings to add support for. >>> >>> About the naming convention for usi nodes, I've chosen to keep the >>> downstream one instead of relabelling all to avoid confusion when >>> cross-referencing the vendor DT and to keep consistency with clock >>> names. They're labelled the same in the bootloader too. >> BUMP - when is this going to get merged? I had a few other things > OSSE25... Ah right, my bad. > > You can help out by reviewing other patches on the mailing lists in > order to relieve the burden of maintainers and move your patches higher > up the list. Yeah, sure. I never really did reviews before because I felt like mine wouldn't hold much weight. But sure, I certainly can (and will). Thanks for your work :D > > >> I wanted to upstream before merge cycle. > You should have posted them already. b4 handles dependencies, this > maintainer can read cover letters. Yeah. I do things via send-email still, so rebasing is a bit of a pain when I need to change stuff in previous patches. And I don't do new branches per patchset, my hardware isn't.. the best. Best regards, Ivaylo > > I plan to clear my todo queue this weekend and close my merge window > within two weeks due to travel. > > Best regards, > Krzysztof
On Fri, 15 Aug 2025 10:04:56 +0300, Ivaylo Ivanov wrote:
> Hey, folks!
>
> This patchset adds serial busses, implemented in usi, for exynos2200.
> It's missing spi, due to me having troubles with reads when testing.
> Serial_0/1 have not been included in the patchset, as it seems like
> they're encapsulated in usi blocks, but are the only implemented
> protocol and/or do not have a dedicated register for setting other
> protocols in a sysreg. That'd at least require patches in the usi
> driver and bindings to add support for.
>
> [...]
Applied, thanks!
[1/4] arm64: dts: exynos2200: fix typo in hsi2c23 bus pins label
https://git.kernel.org/krzk/linux/c/1219992e16689f4937a333c98d90cf80ba91860a
[2/4] arm64: dts: exynos2200: use 32-bit address space for /soc
https://git.kernel.org/krzk/linux/c/ad8ea30db80f825215d071370989b8ac45298a1a
[3/4] arm64: dts: exynos2200: increase the size of all syscons
https://git.kernel.org/krzk/linux/c/0dff00633bbc8566fed6483daddddfa0dfdcf83a
[4/4] arm64: dts: exynos2200: define all usi nodes
https://git.kernel.org/krzk/linux/c/1bc8f09ce98ca8a56f2059c9a8fe26cc351318f0
Best regards,
--
Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
© 2016 - 2025 Red Hat, Inc.