Add FSD CSI support

[PATCH v2 00/12] Add FSD CSI support

Posted by Inbaraj E 1 month, 3 weeks ago

FSD CSI(Camera Serial Interface) IP bundles Link controller and DMA
controller for receiving frames. FSD SoC has 12 instances of CSI IP and
3 D-PHY. 4 instances of CSI IP use 1 D-PHY.

This patch series does the following:
1) Refactor the imx-mipi-csis driver to support platform specific
clock names and interrupt handlers through device specific data
(struct mipi_csis_info).
2) Add FSD CSI link controller support in imx-mipi-csis driver.
3) Introduce a new media driver for FSD CSI DMA providing support for
video capture and streaming.
 
These patches were tested on the FSD platform using the
capture_raw_frames application.

Changes since v1:
1. Addressed review comments from Laurent Pinchart to integrate the
with imx-mipi-csis.c to handle the CSIS and expose it as a subdev.

Here is the link to v1 patch for reference:
https://patchwork.kernel.org/project/linux-media/patch/7e7832c16925386b771ddb7e00e08661115aa0ea.1668963790.git.sathya@samsung.com/

Inbaraj E (12):
  dt-bindings: clock: Add CAM_CSI clock macro for FSD
  clk: samsung: fsd: Add clk id for PCLK and PLL in CAM_CSI block
  dt-bindings: media: nxp: Add support for FSD SoC
  arm64: dts: fsd: Add CSI nodes
  media: imx-mipi-csis: Move clk to mipi_csis_info structure
  media: imx-mipi-csis: Move irq flag and handler to mipi_csis_info
    structure
  media: imx-mipi-csis: Add support to configure specific vc
  media: imx-mipi-csis: Add support to dump all vc regs
  media: imx-mipi-csis: Add support for FSD CSI Rx
  dt-bindings: media: fsd: Document CSIS DMA controller
  arm64: defconfig: Enable FSD CSIS DMA driver
  media: fsd-csis: Add support for FSD CSIS DMA

 .../bindings/media/nxp,imx-mipi-csi2.yaml     |   88 +-
 .../bindings/media/tesla,fsd-csis-media.yaml  |   74 +
 MAINTAINERS                                   |    8 +
 arch/arm64/boot/dts/tesla/fsd-evb.dts         |   96 +
 arch/arm64/boot/dts/tesla/fsd.dtsi            |  552 ++++++
 arch/arm64/configs/defconfig                  |    1 +
 drivers/clk/samsung/clk-fsd.c                 |   28 +-
 drivers/media/platform/nxp/imx-mipi-csis.c    |  354 +++-
 drivers/media/platform/samsung/Kconfig        |    1 +
 drivers/media/platform/samsung/Makefile       |    1 +
 .../media/platform/samsung/fsd-csis/Kconfig   |   16 +
 .../media/platform/samsung/fsd-csis/Makefile  |    3 +
 .../platform/samsung/fsd-csis/fsd-csis.c      | 1730 +++++++++++++++++
 include/dt-bindings/clock/fsd-clk.h           |   13 +
 14 files changed, 2890 insertions(+), 75 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/media/tesla,fsd-csis-media.yaml
 create mode 100644 drivers/media/platform/samsung/fsd-csis/Kconfig
 create mode 100644 drivers/media/platform/samsung/fsd-csis/Makefile
 create mode 100644 drivers/media/platform/samsung/fsd-csis/fsd-csis.c

-- 
2.49.0

Re: [PATCH v2 00/12] Add FSD CSI support

Posted by Krzysztof Kozlowski 1 month, 2 weeks ago

On 14/08/2025 16:09, Inbaraj E wrote:
> FSD CSI(Camera Serial Interface) IP bundles Link controller and DMA
> controller for receiving frames. FSD SoC has 12 instances of CSI IP and
> 3 D-PHY. 4 instances of CSI IP use 1 D-PHY.
> 
> This patch series does the following:
> 1) Refactor the imx-mipi-csis driver to support platform specific
> clock names and interrupt handlers through device specific data
> (struct mipi_csis_info).
> 2) Add FSD CSI link controller support in imx-mipi-csis driver.
> 3) Introduce a new media driver for FSD CSI DMA providing support for
> video capture and streaming.
>  
> These patches were tested on the FSD platform using the
> capture_raw_frames application.
> 
> Changes since v1:
> 1. Addressed review comments from Laurent Pinchart to integrate the
> with imx-mipi-csis.c to handle the CSIS and expose it as a subdev.
> 
> Here is the link to v1 patch for reference:
> https://patchwork.kernel.org/project/linux-media/patch/7e7832c16925386b771ddb7e00e08661115aa0ea.1668963790.git.sathya@samsung.com/

Use lore links. b4 gives them for free..

> 
> Inbaraj E (12):
>   dt-bindings: clock: Add CAM_CSI clock macro for FSD
>   clk: samsung: fsd: Add clk id for PCLK and PLL in CAM_CSI block
>   dt-bindings: media: nxp: Add support for FSD SoC
>   arm64: dts: fsd: Add CSI nodes

Please split patches targeting different subsystems, since they are
completely independent. There is little benefit in combining independent
work into one huge patchset.
Best regards,
Krzysztof

RE: [PATCH v2 00/12] Add FSD CSI support

Posted by Inbaraj E 1 month, 1 week ago

Hi Krzysztof

> >
> > Changes since v1:
> > 1. Addressed review comments from Laurent Pinchart to integrate the
> > with imx-mipi-csis.c to handle the CSIS and expose it as a subdev.
> >
> > Here is the link to v1 patch for reference:
> > https://patchwork.kernel.org/project/linux-media/patch/7e7832c16925386
> > b771ddb7e00e08661115aa0ea.1668963790.git.sathya@samsung.com/
> 
> Use lore links. b4 gives them for free..

I'll use lore links from next patchset.

> 
> >
> > Inbaraj E (12):
> >   dt-bindings: clock: Add CAM_CSI clock macro for FSD
> >   clk: samsung: fsd: Add clk id for PCLK and PLL in CAM_CSI block
> >   dt-bindings: media: nxp: Add support for FSD SoC
> >   arm64: dts: fsd: Add CSI nodes
> 
> Please split patches targeting different subsystems, since they are
> completely independent. There is little benefit in combining independent
> work into one huge patchset.

I'll spilt into different patchset according to the subsystem

> Best regards,
> Krzysztof

Regards,
Inbaraj E