[net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100

Jacky Chou posted 4 patches 4 months ago
There is a newer version of this series
.../bindings/net/faraday,ftgmac100.yaml       | 50 ++++++++++-
.../boot/dts/aspeed/aspeed-ast2600-evb.dts    | 16 +++-
arch/arm/boot/dts/aspeed/aspeed-g6.dtsi       | 24 +++++-
drivers/net/ethernet/faraday/ftgmac100.c      | 86 +++++++++++++++++++
drivers/net/ethernet/faraday/ftgmac100.h      | 12 +++
5 files changed, 179 insertions(+), 9 deletions(-)
[net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100
Posted by Jacky Chou 4 months ago
This patch series adds support for configuring RGMII internal delays for the 
Aspeed AST2600 FTGMAC100 Ethernet MACs. It introduces new compatible strings to 
distinguish between MAC0/1 and MAC2/3, as their delay chains and configuration 
units differ.
The device tree bindings are updated to restrict the allowed phy-mode and delay 
properties for each MAC type. Corresponding changes are made to the device tree 
source files and the FTGMAC100 driver to support the new delay configuration.

Summary of changes:
- dt-bindings: net: ftgmac100: Add conditional schema for AST2600 MAC0/1 and 
  MAC2/3, restrict phy-mode and delay properties, and require SCU phandle.
- ARM: dts: aspeed-g6: Add ethernet aliases, update MAC compatibles, and add 
  SCU phandle for delay configuration.
- ARM: dts: aspeed-ast2600-evb: Add rx/tx-internal-delay-ps properties and 
  update phy-mode for MACs.
- net: ftgmac100: Add driver support for configuring RGMII delay for AST2600 
  MACs via SCU.

This enables precise RGMII timing configuration for AST2600-based platforms, 
improving interoperability with various PHYs.

Jacky Chou (4):
  dt-bindings: net: ftgmac100: Restrict phy-mode and delay properties
    for AST2600
  ARM: dts: aspeed-g6: Add ethernet alise and update MAC compatible
  ARM: dts: aspeed: ast2600evb: Add delay setting for MAC
  net: ftgmac100: Add RGMII delay configuration for AST2600

 .../bindings/net/faraday,ftgmac100.yaml       | 50 ++++++++++-
 .../boot/dts/aspeed/aspeed-ast2600-evb.dts    | 16 +++-
 arch/arm/boot/dts/aspeed/aspeed-g6.dtsi       | 24 +++++-
 drivers/net/ethernet/faraday/ftgmac100.c      | 86 +++++++++++++++++++
 drivers/net/ethernet/faraday/ftgmac100.h      | 12 +++
 5 files changed, 179 insertions(+), 9 deletions(-)

---
v2:
 - added new compatible strings for MAC0/1 and MAC2/3
 - updated device tree bindings to restrict phy-mode and delay properties
 - refactored driver code to handle rgmii delay configuration
---

-- 
2.43.0
Re: [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100
Posted by Andrew Lunn 4 months ago
On Wed, Aug 13, 2025 at 02:32:57PM +0800, Jacky Chou wrote:
> This patch series adds support for configuring RGMII internal delays for the 
> Aspeed AST2600 FTGMAC100 Ethernet MACs.

So i think you are doing things in the wrong order. You first need to
sort out the mess of most, if not all, AST2600 have the wrong
phy-mode, because the RGMII delay configuration is hidden, and set
wrongly.

Please fix that first.

Then consider how you can add fine tuning of the delays. Maybe that
needs to wait for AST2700.

	Andrew
Re: [net-next v2 0/4] Add AST2600 RGMII delay into ftgmac100
Posted by Jakub Kicinski 4 months ago
On Wed, 13 Aug 2025 14:32:57 +0800 Jacky Chou wrote:
> This patch series adds support for configuring RGMII internal delays for the 
> Aspeed AST2600 FTGMAC100 Ethernet MACs. It introduces new compatible strings to 
> distinguish between MAC0/1 and MAC2/3, as their delay chains and configuration 
> units differ.
> The device tree bindings are updated to restrict the allowed phy-mode and delay 
> properties for each MAC type. Corresponding changes are made to the device tree 
> source files and the FTGMAC100 driver to support the new delay configuration.

First patch doesn't apply cleanly, please respin.
-- 
pw-bot: cr