ext4: fix incorrect function name in comment

[PATCH v1] ext4: fix incorrect function name in comment

Posted by Baolin Liu 1 month, 3 weeks ago

From: Baolin Liu <liubaolin@kylinos.cn>

The comment mentions block_write_begin(), but the actual function
called is ext4_block_write_begin().
Fix the comment to match the real function name.

Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
---
 fs/ext4/inode.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
index ed54c4d0f2f9..b0e3814f8502 100644
--- a/fs/ext4/inode.c
+++ b/fs/ext4/inode.c
@@ -3155,7 +3155,7 @@ static int ext4_da_write_begin(const struct kiocb *iocb,
 		folio_unlock(folio);
 		folio_put(folio);
 		/*
-		 * block_write_begin may have instantiated a few blocks
+		 * ext4_block_write_begin may have instantiated a few blocks
 		 * outside i_size.  Trim these off again. Don't need
 		 * i_size_read because we hold inode lock.
 		 */
-- 
2.39.2

Re: [PATCH v1] ext4: fix incorrect function name in comment

Posted by Theodore Ts'o 1 month, 3 weeks ago

On Tue, 12 Aug 2025 10:17:09 +0800, Baolin Liu wrote:
> The comment mentions block_write_begin(), but the actual function
> called is ext4_block_write_begin().
> Fix the comment to match the real function name.
> 
> 

Applied, thanks!

[1/1] ext4: fix incorrect function name in comment
      commit: 757fc66da91b54d4fbc414bee5c440b52560d3b7

Best regards,
-- 
Theodore Ts'o <tytso@mit.edu>

Re: [PATCH v1] ext4: fix incorrect function name in comment

Posted by Darrick J. Wong 1 month, 3 weeks ago

On Tue, Aug 12, 2025 at 10:17:09AM +0800, Baolin Liu wrote:
> From: Baolin Liu <liubaolin@kylinos.cn>
> 
> The comment mentions block_write_begin(), but the actual function
> called is ext4_block_write_begin().
> Fix the comment to match the real function name.
> 
> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>

Heh, that comment was copy-pasted too :/

Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>

--D

> ---
>  fs/ext4/inode.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
> index ed54c4d0f2f9..b0e3814f8502 100644
> --- a/fs/ext4/inode.c
> +++ b/fs/ext4/inode.c
> @@ -3155,7 +3155,7 @@ static int ext4_da_write_begin(const struct kiocb *iocb,
>  		folio_unlock(folio);
>  		folio_put(folio);
>  		/*
> -		 * block_write_begin may have instantiated a few blocks
> +		 * ext4_block_write_begin may have instantiated a few blocks
>  		 * outside i_size.  Trim these off again. Don't need
>  		 * i_size_read because we hold inode lock.
>  		 */
> -- 
> 2.39.2
> 
>

Re: [PATCH v1] ext4: fix incorrect function name in comment

Posted by liubaolin 1 month, 2 weeks ago

> Since commit 6b730a405037 “ext4: hoist ext4_block_write_begin and replace the __block_write_begin”, the comment should be updated accordingly from '__block_write_begin' to 'ext4_block_write_begin'.



在 2025/8/13 1:20, Darrick J. Wong 写道:
> On Tue, Aug 12, 2025 at 10:17:09AM +0800, Baolin Liu wrote:
>> From: Baolin Liu <liubaolin@kylinos.cn>
>>
>> The comment mentions block_write_begin(), but the actual function
>> called is ext4_block_write_begin().
>> Fix the comment to match the real function name.
>>
>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
> 
> Heh, that comment was copy-pasted too :/
> 
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> 
> --D
> 
>> ---
>>   fs/ext4/inode.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index ed54c4d0f2f9..b0e3814f8502 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -3155,7 +3155,7 @@ static int ext4_da_write_begin(const struct kiocb *iocb,
>>   		folio_unlock(folio);
>>   		folio_put(folio);
>>   		/*
>> -		 * block_write_begin may have instantiated a few blocks
>> +		 * ext4_block_write_begin may have instantiated a few blocks
>>   		 * outside i_size.  Trim these off again. Don't need
>>   		 * i_size_read because we hold inode lock.
>>   		 */
>> -- 
>> 2.39.2
>>
>>

Re: [PATCH v1] ext4: fix incorrect function name in comment

Posted by liubaolin 1 month, 3 weeks ago

> Since commit 6b730a405037 “ext4: hoist ext4_block_write_begin and replace the __block_write_begin”, the comment should be updated accordingly from '__block_write_begin' to 'ext4_block_write_begin'.


在 2025/8/13 1:20, Darrick J. Wong 写道:
> On Tue, Aug 12, 2025 at 10:17:09AM +0800, Baolin Liu wrote:
>> From: Baolin Liu <liubaolin@kylinos.cn>
>>
>> The comment mentions block_write_begin(), but the actual function
>> called is ext4_block_write_begin().
>> Fix the comment to match the real function name.
>>
>> Signed-off-by: Baolin Liu <liubaolin@kylinos.cn>
> 
> Heh, that comment was copy-pasted too :/
> 
> Reviewed-by: "Darrick J. Wong" <djwong@kernel.org>
> 
> --D
> 
>> ---
>>   fs/ext4/inode.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/fs/ext4/inode.c b/fs/ext4/inode.c
>> index ed54c4d0f2f9..b0e3814f8502 100644
>> --- a/fs/ext4/inode.c
>> +++ b/fs/ext4/inode.c
>> @@ -3155,7 +3155,7 @@ static int ext4_da_write_begin(const struct kiocb *iocb,
>>   		folio_unlock(folio);
>>   		folio_put(folio);
>>   		/*
>> -		 * block_write_begin may have instantiated a few blocks
>> +		 * ext4_block_write_begin may have instantiated a few blocks
>>   		 * outside i_size.  Trim these off again. Don't need
>>   		 * i_size_read because we hold inode lock.
>>   		 */
>> -- 
>> 2.39.2
>>
>>