[v2] rust: use `kernel::{fmt,prelude::fmt!}`

[PATCH v2 0/8] rust: use `kernel::{fmt,prelude::fmt!}`

Posted by Tamir Duberstein 2 months, 2 weeks ago

This is series 2a/5 of the migration to `core::ffi::CStr`[0].
20250704-core-cstr-prepare-v1-0-a91524037783@gmail.com.

This series depends on the prior series[0] and is intended to go through
the rust tree to reduce the number of release cycles required to
complete the work.

Subsystem maintainers: I would appreciate your `Acked-by`s so that this
can be taken through Miguel's tree (where the other series must go).

[0] https://lore.kernel.org/all/20250704-core-cstr-prepare-v1-0-a91524037783@gmail.com/

Signed-off-by: Tamir Duberstein <tamird@gmail.com>
---
Changes in v2:
- Rebase on rust-next.
- Drop pin-init patch, which is no longer needed.
- Link to v1: https://lore.kernel.org/r/20250709-core-cstr-fanout-1-v1-0-64308e7203fc@gmail.com

---
Tamir Duberstein (8):
      gpu: nova-core: use `kernel::{fmt,prelude::fmt!}`
      rust: alloc: use `kernel::{fmt,prelude::fmt!}`
      rust: block: use `kernel::{fmt,prelude::fmt!}`
      rust: device: use `kernel::{fmt,prelude::fmt!}`
      rust: file: use `kernel::{fmt,prelude::fmt!}`
      rust: kunit: use `kernel::{fmt,prelude::fmt!}`
      rust: seq_file: use `kernel::{fmt,prelude::fmt!}`
      rust: sync: use `kernel::{fmt,prelude::fmt!}`

 drivers/block/rnull.rs               | 2 +-
 drivers/gpu/nova-core/gpu.rs         | 3 +--
 drivers/gpu/nova-core/regs/macros.rs | 6 +++---
 rust/kernel/alloc/kbox.rs            | 2 +-
 rust/kernel/alloc/kvec.rs            | 2 +-
 rust/kernel/alloc/kvec/errors.rs     | 2 +-
 rust/kernel/block/mq.rs              | 2 +-
 rust/kernel/block/mq/gen_disk.rs     | 2 +-
 rust/kernel/block/mq/raw_writer.rs   | 3 +--
 rust/kernel/device.rs                | 6 +++---
 rust/kernel/fs/file.rs               | 5 +++--
 rust/kernel/kunit.rs                 | 8 ++++----
 rust/kernel/seq_file.rs              | 6 +++---
 rust/kernel/sync/arc.rs              | 2 +-
 scripts/rustdoc_test_gen.rs          | 2 +-
 15 files changed, 26 insertions(+), 27 deletions(-)
---
base-commit: cc84ef3b88f407e8bd5a5f7b6906d1e69851c856
change-id: 20250709-core-cstr-fanout-1-f20611832272
prerequisite-change-id: 20250704-core-cstr-prepare-9b9e6a7bd57e:v1
prerequisite-patch-id: 83b1239d1805f206711a5a936bbb61c83227d573
prerequisite-patch-id: a0355dd0efcc945b0565dc4e5a0f42b5a3d29c7e
prerequisite-patch-id: 8585bf441cfab705181f5606c63483c2e88d25aa
prerequisite-patch-id: 04ec344c0bc23f90dbeac10afe26df1a86ce53ec
prerequisite-patch-id: a2fc6cd05fce6d6da8d401e9f8a905bb5c0b2f27
prerequisite-patch-id: f14c099c87562069f25fb7aea6d9aae4086c49a8

Best regards,
--  
Tamir Duberstein <tamird@gmail.com>

Re: [PATCH v2 0/8] rust: use `kernel::{fmt,prelude::fmt!}`

Posted by Miguel Ojeda 2 months, 2 weeks ago

On Sun, Jul 20, 2025 at 12:42 AM Tamir Duberstein <tamird@gmail.com> wrote:
>
> Subsystem maintainers: I would appreciate your `Acked-by`s so that this
> can be taken through Miguel's tree (where the other series must go).

Same here as in step 2b/5, i.e. Danilo's Acked-by was picked up for
things he didn't Acked-by.

I imagine it was automatically done by `b4`, but that is why we need
to be careful about automatically applying tags. I am mentioning this
mainly to confirm I am not confused and to avoid forgetting about it,
and also I hope it helps if you eventually apply patches yourself,
e.g. if you eventually take care of a branch yourself.

Cheers,
Miguel

Re: [PATCH v2 0/8] rust: use `kernel::{fmt,prelude::fmt!}`

Posted by Tamir Duberstein 2 months, 2 weeks ago

On Mon, Jul 21, 2025 at 4:25 PM Miguel Ojeda
<miguel.ojeda.sandonis@gmail.com> wrote:
>
> On Sun, Jul 20, 2025 at 12:42 AM Tamir Duberstein <tamird@gmail.com> wrote:
> >
> > Subsystem maintainers: I would appreciate your `Acked-by`s so that this
> > can be taken through Miguel's tree (where the other series must go).
>
> Same here as in step 2b/5, i.e. Danilo's Acked-by was picked up for
> things he didn't Acked-by.

Yes, you are right.

>
> I imagine it was automatically done by `b4`, but that is why we need
> to be careful about automatically applying tags. I am mentioning this
> mainly to confirm I am not confused and to avoid forgetting about it,
> and also I hope it helps if you eventually apply patches yourself,
> e.g. if you eventually take care of a branch yourself.

You're not confused, and I appreciate you calling it out. I'll look
out for this kind of thing in the future.

Thanks Miguel.
Tamir