From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f178.google.com (mail-qk1-f178.google.com [209.85.222.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D747C1C5D7D; Sat, 19 Jul 2025 22:42:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964931; cv=none; b=H/kk+lhrGvRfh1GCULe6mJBfdgRQVJlcxXH2fBEYtuxmoHV0IsQU6w3ouM4Luot0LONeNm2IOQK5nCEGL6VLwUHKQqvAyw5XZNfLTeUUn0wnWuL/ffP4XyTQD1RTLgwrIuGmbua56xpTyVcoh9LCO32DJ/G3DNOvwGRjq0qyP5k= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964931; c=relaxed/simple; bh=iDkIB5rvX8tJR4OLhXYS4HL4jEYmtSfHiux6Jv9xhWk=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=uekvHg7ZDrUh0Yrb7ffGHOsgFxcScZFHZISSxPykVB5GHmQB6kq17EajGB8aScQgKX/dCdbGu+5segCGrX2nq2nPf+cuWCnam/SWK4YOoXiSZ0DMD3/KxT4S1E740k1IiCLVCIcNYLMh3BBbK8PgZkAK05e7rdtBcKRcLRoCM80= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FPSx9Tia; arc=none smtp.client-ip=209.85.222.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FPSx9Tia" Received: by mail-qk1-f178.google.com with SMTP id af79cd13be357-7e2c920058fso417362485a.0; Sat, 19 Jul 2025 15:42:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964929; x=1753569729; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zFFgiza+Dl5GdaqwlbzwLTdeCZ/jp+2BcZVRLKHMbXE=; b=FPSx9TialU2rcMTHvy/HUT2x1sZ9Nj55A8EWYE1NXnoV1dD07J5xTJWF09RxD10mq3 vKtn8ihMRS3aeTqqXaIsMuF+DSAHjwy+8oypbPENxsrIeSFaYTx305bQBtvBXk1Td3WC Lkl7E8ZIvRzu6oi2QY6KCXWq3ko+IfyWYR8maVT7FFW4LTGxe7uOyBEZLYIMuCfCIXM8 MoeTJbIgVBz6J7W/j7Rvbm/F0lC8NMqHRyy4B04kBrW4pjAS977xSAq7rtrZGxgBLyUk SU+pOd63qw5b228WpyxWnt76sbW2bsYYlCc5AbDtlUt3vBJdKU1TF6f8QjWyU9R9dHo+ f6Vw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964929; x=1753569729; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zFFgiza+Dl5GdaqwlbzwLTdeCZ/jp+2BcZVRLKHMbXE=; b=TBzyJWFr1WVlT9iGOnfG1E9RuJ3LB+hWXtohRn7wAe+DXnys+ufdt10BZbn9n4ADCj ZasLEdJTIW3UafCkYc5QkFgdQhJKlJNNl17WFQgSOju+ZaJC08FzGIDgqXBbYYiPqJ0u K8b8KSrQHkAquYNXTccUKjtaLMDQxHYkpmApUaHCf9NUrtmA3kYBnEALK+A1PSk7G716 D6SyG/Kxvp5czvFgiMhii2vFORN5eJp/oun1P+lVC7bMDk0aA8XjwFHg2UeIv8GbUGGv ul0m3yv6JdQz/tRwz1tJz/LOXYA9PUu8vXnGWtO+jM2+JTVotqLRfgzbRA7YMx00mUP+ KJkQ== X-Forwarded-Encrypted: i=1; AJvYcCVppMcJvopUqjENCLw08GV7ZtgsNzr+iFs4JAPu3CXjcuqVZjYbWZ4isDyOcXkAwfw0waLft4cWntkmXzar@vger.kernel.org, AJvYcCW+7orWczmfDJxFVWHRufLLAlEiv6qlbKZcmt28gFjzzPOw/CwaHnKWwosE6AG4hdn2/o5CCbdhnAbVGg==@vger.kernel.org, AJvYcCWLDETsMfQtzgIXZbHjU8wQzmEufWo4iPQXlmx0NJHunKOPvkJ3BlSLw7XePgqNxS+p3NW71whK7VXVOU/JIXfv@vger.kernel.org, AJvYcCWjUZdVQj+wiwkyOqR3Gm+3HLCm3AvTAuiIpRmulUzOy7sUhzmh4fb2SXYtVeVDAI+IAXGP6kUfNDtPJIGjs+w=@vger.kernel.org X-Gm-Message-State: AOJu0YyqblM1cGJS6IG0xfkG5eVvt8mYZSnAZA+ywuAnh8OXmuP16GPd +h2PXNZPuVMfekq4OjmbVnUESUgPqWSLSiKCHkHSZSgxYlCjEzWlLdLu X-Gm-Gg: ASbGnctKda07KVdchqYowTSLMimXDxAWuDrqunlMopKHGrwh+Cz9W9bmHoU9Dfqsavb LOBb2jVnLQ4RUsoGBB/7OFOWt8hvR/LO73xoVL6KkOQW2r1R8VGeWXN5jW4vaT66v58VsbRiBiD jijDry2Gd4T55QB3PLVGSpN9H64sl2H1MYlmZy+gfAo24SGCOT7KZtD7RYSGXHGP8+I2veg2HSS 6mumCkiGGB1VXqDJqkf1Nfd9NULS6uOITS9lvJwPCJPD2Ajb/6iwt2HkxN7oCqLW3FXd2fqi0YH vw3fIa4kMfkt6zdVkTRv7nRAsyiI6bg6Q/vqXocLwuJ9fsIh2YfOc6tkaN/EeeXKkfx1HgCS3Bq LuOIdYY9ktYUk4rB1+0rAK90Fj1F4LCi8fPhV+9HX3ya7fEampU3icj6xbV7DlkYQgygjWpI1Oh m/DmUKUamr6rTk6okTIepM3W2dvT9e X-Google-Smtp-Source: AGHT+IGidME1gL5I/0fPjfeSylawYS4pDe10fawmQtGosH0orgzM7W+Vd2E9cgU88UEhGWwteFt0yg== X-Received: by 2002:a05:620a:f0b:b0:7e0:e2d7:e03 with SMTP id af79cd13be357-7e34d11a7e5mr1856621385a.7.1752964928659; Sat, 19 Jul 2025 15:42:08 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:07 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:50 -0400 Subject: [PATCH v2 1/8] gpu: nova-core: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-1-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964923; l=2160; i=tamird@gmail.com; h=from:subject:message-id; bh=iDkIB5rvX8tJR4OLhXYS4HL4jEYmtSfHiux6Jv9xhWk=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QCEQK33g2u0Gt1gVO/tbX+OT6Hyrjr11/cEuKmthxY1k5d8m0r0rWBWJTpdLTKfL3Hd05d1yLgf tmc3AOoa3WAQ= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- drivers/gpu/nova-core/gpu.rs | 3 +-- drivers/gpu/nova-core/regs/macros.rs | 6 +++--- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/nova-core/gpu.rs b/drivers/gpu/nova-core/gpu.rs index 60b86f370284..f1d72da7fddd 100644 --- a/drivers/gpu/nova-core/gpu.rs +++ b/drivers/gpu/nova-core/gpu.rs @@ -1,12 +1,11 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use kernel::{device, devres::Devres, error::code::*, pci, prelude::*}; +use kernel::{device, devres::Devres, error::code::*, fmt, pci, prelude::*}; =20 use crate::driver::Bar0; use crate::firmware::{Firmware, FIRMWARE_VERSION}; use crate::regs; use crate::util; -use core::fmt; =20 macro_rules! define_chipset { ({ $($variant:ident =3D $value:expr),* $(,)* }) =3D> diff --git a/drivers/gpu/nova-core/regs/macros.rs b/drivers/gpu/nova-core/r= egs/macros.rs index 6851af8b5885..759773a19480 100644 --- a/drivers/gpu/nova-core/regs/macros.rs +++ b/drivers/gpu/nova-core/regs/macros.rs @@ -106,10 +106,10 @@ macro_rules! register { =20 // TODO: display the raw hex value, then the value of all the fiel= ds. This requires // matching the fields, which will complexify the syntax considera= bly... - impl ::core::fmt::Debug for $name { - fn fmt(&self, f: &mut ::core::fmt::Formatter<'_>) -> ::core::f= mt::Result { + impl ::kernel::fmt::Debug for $name { + fn fmt(&self, f: &mut ::kernel::fmt::Formatter<'_>) -> ::kerne= l::fmt::Result { f.debug_tuple(stringify!($name)) - .field(&format_args!("0x{0:x}", &self.0)) + .field(&::kernel::prelude::fmt!("0x{0:x}", &self.0)) .finish() } } --=20 2.50.1 From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB38E287513; Sat, 19 Jul 2025 22:42:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964933; cv=none; b=uotp+XfWyhk9mpAQZOJ83lqzdG8yddGyDs+ffyurOtu5kYhdDGq6yCwIr2rxCdYxXgAHm6cVXeJoEXZmCoviOSzPYbxr0zqHXsf0Um8b1rsFDCZcLTFXvveInoJY1Av/F4szvvmKxoEjT84k2yU3+rtWcPTecLURnfHC9ADyBeU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964933; c=relaxed/simple; bh=PSL4iigvbqQ2ksUQBIiw94ADQQA5vnHuf37BheuwWG4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=g0TIm1lPud8S8EO3A+6ib9QHRfWfe+mz1nAhkC5Un4ft4ZRw1XILm/OVVqV/DZRnNmPVyFiBb/8HYNbRwZs4ldPbIwtqt3YIlXq6RSau5yPpgOWT4zUdZw3bDFHK5xGpLa+J+8h5oRe8gFE3qkFsVkSDoYK/SIHszelpVKCn2mY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=CVOo+m7o; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CVOo+m7o" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7e29616cc4fso327775485a.0; Sat, 19 Jul 2025 15:42:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964930; x=1753569730; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k8zwWmF5N009AGIXlDD+XsD4K4+mEgy8HqbF8g/gLNE=; b=CVOo+m7o5uI/E8/Lh68fpZoaGO+teZpK7MNmftdTUMsP/yrnWBiCVOdiEGw/QFOMuE z0SSkmTDjLbEm2+UtbwRmJHrpQu+RR4WcT2pgKw/jg9FXzDMw/GeTtwlYbN0L1DI9yxg 1Fuu8PX2S8aBg9tVJOfh32AtjRMxzFPEsi8a7PLa5SLRWWHiDxjQYfG8zLA8MY38z4Qs uUSX3Kmwn9bS3s6UwGoTEqzneAd0SE3UZrXmupGaJMP5ivIn9CrqxkilLc3hDAJSBkV1 E/PNBQ+E1492hlBFjoxfT6SrTkGRwhM44DMGhuZp16GenpUKSkSpI4h5mAhfut/o1YzK XG/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964930; x=1753569730; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k8zwWmF5N009AGIXlDD+XsD4K4+mEgy8HqbF8g/gLNE=; b=UoKsvLCtZ8KuJsjo1wrQyhv86laV7Udhq0y8qSyCJhcHbGlZAEh+Q+ei/11rQgZwxo PC/NU+dFadPau0v9L4WPgQ7jmAxoIfGfXlp+mBGMe19oX16ctAlj9wFSALzQHl70EFEr BFGce1TgcuNtOzRGNcAs+GgssEfZEknm/W0dhX3PhmLROx6LQV37oNx3BVz1uf/oW8t5 1g1fZa+O7Tx/j0UQbmqTUx1aRp/7+1CyIjGEeVU356KL2F2WyMAwD6aFS6CilT3cTgse iZ6uhhjhVX1hxtYnFWSFRBDEwOx+7RPXa66YJfEXugZsjdp3ZJk1gaFkzwL6t81YHeIE f9Sw== X-Forwarded-Encrypted: i=1; AJvYcCUd6d6wMCgMEk77MnYQoqrWk8JuK02VClKxdxsStfAK8+I08cuDtn+XpnUzQrMiWBhh4is7QzM5suY9loWYeWk=@vger.kernel.org, AJvYcCUvQTQVGRGmpM2/WQ2LqyVlFjh8KYmEmWjaTDm2Aqk2BIW3sKeZlq07Rrlac/J0AcoMTvpAYxK84Vq2ZwNJ@vger.kernel.org, AJvYcCUy9Eauxuw7NKYjvICzCwiChGZsuymcPfiOz6A3HOekLUkxDN/To7f6qYGWKOh98ZxcEBDROoI3ITdJdw==@vger.kernel.org, AJvYcCWlO/LNfovNxFoyahNvw/Edy8W9Va47ZGcZwIvYmOb/JEnW6t0ZhHStL7xaPiyg3WYaQCUfSYT8XXwVAiT5EebB@vger.kernel.org X-Gm-Message-State: AOJu0Yyqqvl5vlvnlU+vKdhT8eD2bg/NYTxJOfq/zRUi4QynIxNBUETz UuDujPF8zX1WAjm8XIHkSjmRRkY5lKmWARfcgZOBJemo/rtjNlLOGOX/ X-Gm-Gg: ASbGncth7L3W+kDUqgP7c/2k1N6M1+W20BZAWK8bZRPCwHe7bSLewAOPcEHqyt4uJ9F pxIi7xQyQKJEjEHHkIAAzJ/kiBgG6kRdpA7NGplsOjp+k87wvhIiTa+3P6ztTVLK7WbPmdhAOnE OGkN45Gx0GFWzmENIkZ5Fi0v14ZCAx0tpU2MPXkKoiHLtI5CsSFSxHguepCYD2I8PRID7ZmdKMG AYqGrVU3enEKm744NRCOA5EJSSoYtwwtpqo3oe1AdVx94JKjr1b46l4FS9YVaG5Xy0251i2XNKf q1kiiyTvRwDukxTKfGsbTTrpF1+kMlQCc1n83hTYkMT+oT+aJHaZz6zIVl5B5BSwO3AJMq1+kQB HUDdQIKq4hyF+vDeEcMnZ25AxhVNarzXDq8SvrVid+uOBIugOSRinQj+fvqxyTw1JMIDrPR0D0i qfWOe1aYYbqudzp4VQpFuYe4KyAfWb X-Google-Smtp-Source: AGHT+IFcM5vlTfHbMZcHG4vqLu6GDVA0CvWxAR99Lsxdw7SvuJC/8vqOcsbiSG0Ai/sIgQPyOGsC9g== X-Received: by 2002:a05:620a:4113:b0:7e3:46da:9e2f with SMTP id af79cd13be357-7e346daa47bmr1530803485a.34.1752964930511; Sat, 19 Jul 2025 15:42:10 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.08 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:09 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:51 -0400 Subject: [PATCH v2 2/8] rust: alloc: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-2-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964924; l=2090; i=tamird@gmail.com; h=from:subject:message-id; bh=PSL4iigvbqQ2ksUQBIiw94ADQQA5vnHuf37BheuwWG4=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QAwYmtmzbTS+G2HAZWq+qi6aK1Plu95PH7CqyAf94mKBaAcFJcRxRwncs1NkLrq9OJGSXys5/Ti sWn8TxIy+UgQ= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/alloc/kbox.rs | 2 +- rust/kernel/alloc/kvec.rs | 2 +- rust/kernel/alloc/kvec/errors.rs | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/alloc/kbox.rs b/rust/kernel/alloc/kbox.rs index 856d05aa60f1..563187d09a8e 100644 --- a/rust/kernel/alloc/kbox.rs +++ b/rust/kernel/alloc/kbox.rs @@ -7,7 +7,6 @@ use super::{AllocError, Allocator, Flags}; use core::alloc::Layout; use core::borrow::{Borrow, BorrowMut}; -use core::fmt; use core::marker::PhantomData; use core::mem::ManuallyDrop; use core::mem::MaybeUninit; @@ -17,6 +16,7 @@ use core::result::Result; =20 use crate::ffi::c_void; +use crate::fmt; use crate::init::InPlaceInit; use crate::types::ForeignOwnable; use pin_init::{InPlaceWrite, Init, PinInit, ZeroableOption}; diff --git a/rust/kernel/alloc/kvec.rs b/rust/kernel/alloc/kvec.rs index 3c72e0bdddb8..4a1b2c26209a 100644 --- a/rust/kernel/alloc/kvec.rs +++ b/rust/kernel/alloc/kvec.rs @@ -7,9 +7,9 @@ layout::ArrayLayout, AllocError, Allocator, Box, Flags, }; +use crate::fmt; use core::{ borrow::{Borrow, BorrowMut}, - fmt, marker::PhantomData, mem::{ManuallyDrop, MaybeUninit}, ops::Deref, diff --git a/rust/kernel/alloc/kvec/errors.rs b/rust/kernel/alloc/kvec/erro= rs.rs index 348b8d27e102..21a920a4b09b 100644 --- a/rust/kernel/alloc/kvec/errors.rs +++ b/rust/kernel/alloc/kvec/errors.rs @@ -2,7 +2,7 @@ =20 //! Errors for the [`Vec`] type. =20 -use core::fmt::{self, Debug, Formatter}; +use kernel::fmt::{self, Debug, Formatter}; use kernel::prelude::*; =20 /// Error type for [`Vec::push_within_capacity`]. --=20 2.50.1 From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f172.google.com (mail-qk1-f172.google.com [209.85.222.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86512288C19; Sat, 19 Jul 2025 22:42:13 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964935; cv=none; b=doQe/2fi+lC5g7AzuKGfD4TFBnWctELXIpKmLybNN+AbHb/JOa+pZq3FJk4v/Pmo/FFjR4D0imM6MuYqthUQAniEhoct1ncRKwbUV3B3rURkR7T+0awlhBifO+X9fNJpSwRuwnf06JVrCNbwsQqqghVSaq2n6xx/oskbFgrszBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964935; c=relaxed/simple; bh=vuDgQYV2nbF6wDrYHHf8eMvazUJvWvWnDsga4yR8ZwA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=irUqY455QqWH6WmeBHiovH1RVzoMmrlwege4Utg4xjmhLueIkwNckpdppeLmq9c0+VLNtDEVUQidJ02ByEqHUIiZjhzheA3qE2MWCqxLCg5QetP6gIuoLIEbFb0pQ6zuMjYLymnNQ2t0VxaZmRk8VY2T5pIbmS7PlOW9bzipzKA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=EZT+h0TU; arc=none smtp.client-ip=209.85.222.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="EZT+h0TU" Received: by mail-qk1-f172.google.com with SMTP id af79cd13be357-7e1f3b95449so411533185a.1; Sat, 19 Jul 2025 15:42:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964932; x=1753569732; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Aw7v9AoXajCiA3y3c/HUxv7RbEkPrpCQfUUsk1ERQPc=; b=EZT+h0TU0oLwbPuinnLgsShLRTetSzye2dsR3wdyhgg0d12WUyzJnmLQoSpac8ZNf+ OH9nUwv+MAxxkFcDflvL1/tOrBc4uaA6LDlew9rQvQixvopecB59Pi+oRhHiv5VleUNs Wm8RSN+3j+zgk2aRinWA5Em56dxKM2qwcR59yXPdtNIZa3/1mg/lZuolVWnWe/XIvgNs qwAk9SZnRDAxy1qzTuakL4PVvyXX3mNboMNIEdbSjCbvz7TUYFgYiMQ1QLXKLwiq/qKO uLmC/7Zf/ruvXaTDVWXelKriwhQ8HjD17/rjfNbc30zLiX5htYUIXLLB8M85Af/j6K1F F7mA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964932; x=1753569732; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Aw7v9AoXajCiA3y3c/HUxv7RbEkPrpCQfUUsk1ERQPc=; b=cNw0pgqddN5R4gh0FSLltZVBtdW0ISFocG0hNgN1saeEA6wwsIE0FojWYcJrame/k5 5cGrWpdPRAMzEB3d0jwBmJedxSDxYWhsVclR6J1uz9rC9Fvb58jzBe6ehkAlLX12ewbb pBgsQNNCHoUnTJEg0mNmLXjGKsb8SkK/MTJXJVDCZDvZE4nZBQT3V/TQHCFqamIdMOLB OolBCscQcUsUo08Z7pBN3Z1aoEzHc+U+pQbdZxSDODoQMH/4U84iE0L/KWFTge4VQtqZ d5VhlJYpcmuoJ7JDp4fZVQoGMhkjmrwD6c9TQttv0ObME/pPyjUOw0sWd5OxJUBg6eWh gaGA== X-Forwarded-Encrypted: i=1; AJvYcCVn2HcwcUW2XzLzs4ucVHNYPAjt8bcAXwBdgAY8QhITjQbwIume6okgn1LErRyxPLDutya6Q1CTLJXrTY8pk3U=@vger.kernel.org, AJvYcCVuYafe+FjNeBy27u+GkteHIOFuVDYPiergucWFmwGP6E+KKaK5mNAA0kGyNJiiU8etIpIwyfqeQQGRSw==@vger.kernel.org, AJvYcCWJM+GrfgYPqkFUo6MNXgrsb1HmQVSR1j3ioh5HBu4r3mfRuAjVFaHNHJguaGhCzf+6bHwdaYHZF/WhKiGg2dQG@vger.kernel.org, AJvYcCX4W6WGxr5R7k9q91v/j55+hVOndoynmBuZo8gyL+yGWgMAZWzh3yn3WdnSEi0NhPkUToCS8S6OBKllx9h2@vger.kernel.org X-Gm-Message-State: AOJu0Yyi5pylgMIDG2HavTl1F2kW9CzAWHRx/fjkGBgumfEabx/OMele R7sMufrvXOdxMR8iGAoJX5XXGpgt5NcAxp0f3xxTM6QN9fXc1iXeybic X-Gm-Gg: ASbGnctzVIr8lKxObXNLzVB3pCnGPa7rb0hA+jUT+WDKMVOiro+wTcVTfgF/u3mKXwA Qp6YvCGOZvA2Cu67MpdzAEwmyFqB+Bu4fkYff+V5em2vl5wB2B5m8FzCub9JstSHlZR6QkYm7Qh afS0xrKeJsxmtt5AzS21kT2cFQNzJ3ElOan+sSAaH55eOGfUq+CN6DORRvq+Yqd3tCfoczrY9KA ppwzMtHBO4wlqyZroFH/e85bCcu9qH3xczvdHSkgnWaUH04O+fqiYja5wctkUh4qW+soXZsZ2rk k8FDmctJ+rctUimR+WSRwhGtfl7UUYB9OdpeKTV59OGjdcQFSgdHTU0ip7MWnOQKmF5pFLjL3vm 7VKQ7aM9RH3huVRK39cBNALs0J0yiCb4USVdUVhfXppTtLvh8CYJtq2HoWkSZfcmOHyx4ejkbRT MdXJVC4M+1OntyZwLdMikfCVE/BoUP X-Google-Smtp-Source: AGHT+IHTev6teKqBxr3yVPaGIfkg92j5uUM5edVfrIYIKgPuAl81m1vfH5UUeD5NEDYnMWK+yKJIxw== X-Received: by 2002:a05:620a:1a25:b0:7e3:3682:6dee with SMTP id af79cd13be357-7e34d1094b5mr1835427185a.4.1752964932457; Sat, 19 Jul 2025 15:42:12 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:11 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:52 -0400 Subject: [PATCH v2 3/8] rust: block: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-3-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964924; l=2909; i=tamird@gmail.com; h=from:subject:message-id; bh=vuDgQYV2nbF6wDrYHHf8eMvazUJvWvWnDsga4yR8ZwA=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QHc+KbWe0mrNmiJ0AautqYraxFDr7unwZE/5c0RQ2Ojk4ru4U2Oae0ZmVmEDXv7ZRDiXgq3EQH3 G6511ib+cXQs= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Suggested-by: Alice Ryhl Link: https://rust-for-linux.zulipchat.com/#narrow/channel/288089-General/t= opic/Custom.20formatting/with/516476467 Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein Acked-by: Andreas Hindborg --- drivers/block/rnull.rs | 2 +- rust/kernel/block/mq.rs | 2 +- rust/kernel/block/mq/gen_disk.rs | 2 +- rust/kernel/block/mq/raw_writer.rs | 3 +-- 4 files changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/block/rnull.rs b/drivers/block/rnull.rs index d07e76ae2c13..6366da12c5a5 100644 --- a/drivers/block/rnull.rs +++ b/drivers/block/rnull.rs @@ -51,7 +51,7 @@ fn init(_module: &'static ThisModule) -> impl PinInit { .logical_block_size(4096)? .physical_block_size(4096)? .rotational(false) - .build(format_args!("rnullb{}", 0), tagset) + .build(fmt!("rnullb{}", 0), tagset) })(); =20 try_pin_init!(Self { diff --git a/rust/kernel/block/mq.rs b/rust/kernel/block/mq.rs index 831445d37181..61ea35bba7d5 100644 --- a/rust/kernel/block/mq.rs +++ b/rust/kernel/block/mq.rs @@ -82,7 +82,7 @@ //! Arc::pin_init(TagSet::new(1, 256, 1), flags::GFP_KERNEL)?; //! let mut disk =3D gen_disk::GenDiskBuilder::new() //! .capacity_sectors(4096) -//! .build(format_args!("myblk"), tagset)?; +//! .build(fmt!("myblk"), tagset)?; //! //! # Ok::<(), kernel::error::Error>(()) //! ``` diff --git a/rust/kernel/block/mq/gen_disk.rs b/rust/kernel/block/mq/gen_di= sk.rs index cd54cd64ea88..494c95623b97 100644 --- a/rust/kernel/block/mq/gen_disk.rs +++ b/rust/kernel/block/mq/gen_disk.rs @@ -6,9 +6,9 @@ //! C header: [`include/linux/blk_mq.h`](srctree/include/linux/blk_mq.h) =20 use crate::block::mq::{raw_writer::RawWriter, Operations, TagSet}; +use crate::fmt::{self, Write}; use crate::{bindings, error::from_err_ptr, error::Result, sync::Arc}; use crate::{error, static_lock_class}; -use core::fmt::{self, Write}; =20 /// A builder for [`GenDisk`]. /// diff --git a/rust/kernel/block/mq/raw_writer.rs b/rust/kernel/block/mq/raw_= writer.rs index 7e2159e4f6a6..d311e24e2595 100644 --- a/rust/kernel/block/mq/raw_writer.rs +++ b/rust/kernel/block/mq/raw_writer.rs @@ -1,8 +1,7 @@ // SPDX-License-Identifier: GPL-2.0 =20 -use core::fmt::{self, Write}; - use crate::error::Result; +use crate::fmt::{self, Write}; use crate::prelude::EINVAL; =20 /// A mutable reference to a byte buffer where a string can be written int= o. --=20 2.50.1 From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f177.google.com (mail-qk1-f177.google.com [209.85.222.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6AFFA28936F; Sat, 19 Jul 2025 22:42:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964937; cv=none; b=owAytI03YPDWwBTkyab0O3l9WXq379o/gaFNU4/XmPdQKQSfJtxBwtbXEDSgMjuJjEBI9blSKpket9ohHERuoRx/pyOr92skGFmmhfGSoir4ojxWNIbbcmvU1DiGpSyC7bIgv+KUOdWpyi+HdoakVgLmOdJGfe7C0UMKv02kHog= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964937; c=relaxed/simple; bh=CRl/lQSZVYzZ8ljWAUnUAXiehzAwEFBaZRkNdCXXhsU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=jDXP25utuZRfiJWgVorhkGB3nojVPKDbGlgDT5DjrDN/VUPCZQc1zoRtedFQPQ9FpbwnWj8Yn60Jnm2Mk97kVQ4w5S5jmy/g8+Jt7eooW1pStMqJY9P0/I4CfvQosNT0NMpWnlfYNDhTlf1odDQc/efTaaUuWCRX2ljsnhbkfIw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=XrV8+c8o; arc=none smtp.client-ip=209.85.222.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XrV8+c8o" Received: by mail-qk1-f177.google.com with SMTP id af79cd13be357-7dd8773f9d9so310923885a.2; Sat, 19 Jul 2025 15:42:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964934; x=1753569734; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=pBla166t5r/3r2D+ChYAZke2nd+xgoyT3sVy8XOPMb0=; b=XrV8+c8ougIEpE+S15aQJqU2b5mGe+hObFmsOEJGRhVsZE5CFinLNhOFV4WUnNzUBs zw//CORsQCZWYP8JBYwCgugTUvBPulxC9eAD0t2O5BGXOU8Jpy1tZP+33j//QfC8Zi7Q FQNcGCSK6jhhhX34FtzYBqIUvarCAig7Zag4ROZ9Dvno3TsWe1BpWmxfGF2VfGH0OymW uz66Zf8IK60eyuMun5xng7y2tNQ8CyjtrBJII/suusDXaKvjHkYQH4r8t0cQtuvW7JtQ PCnnwnDtCKPWyejau5mf4N9VC/aw5WVIiJaj7lVmkdIYds+GjRnU/onBvPbYYorWTXri MHQA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964934; x=1753569734; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=pBla166t5r/3r2D+ChYAZke2nd+xgoyT3sVy8XOPMb0=; b=ulHlnC0MO/LpvBcovWEo7pjkjpZoE3F7x1akHmpMYKK2LbtDmFcB7Hbi1RSsUFU+Eh W8xYr36Lz4s6RCLeGYZQngeL4to1OtfDcxAqNQeEx09g0uIJdANJtezidrmm+KiOj931 wz4r/qdLzFKTm38mbronlFk474rQwKRNw6iN9ZaM4RMueW9ibFQs/Q3HsXFIjUoPnP9P tl9XutJYpXeXWZ92++7etfPe/+Q6FgQkcOl4S0NXUeZsVwAhODjHZsdvNJg7F0t7aG2t RNTMLGvAxOva0WTWrMCMgOuHUq7q3g9Zot8ssYLZOqPYPxzpJfqhXQetoz5zlZFdiayG r2cA== X-Forwarded-Encrypted: i=1; AJvYcCUw9T9YJqapwzyodkuJ9FTTWPhq4LXhqh5NT/JNzbSz7Rn4b9BLJq/xdw/O9TZYWBUtmTm1xKQ0MwxYPTqDtlbN@vger.kernel.org, AJvYcCV14Eu7j/404N9bLfMcvLkrleqs4KvAqen7PtmzYE6NBXHGCvaW2ByDzn9hPd3HopHs8KI4HixsQ/h0091noUY=@vger.kernel.org, AJvYcCVQ/wJqjxbC0TiQe32Vd9ga6fFDCOHSLTOxkPNQoOjQB5FEF0Eab6FS+dRbPrTWuLlxurL0orRC1ESQ7FqT@vger.kernel.org, AJvYcCXBE9aUI7LRKQvXQGqO0CRNYsYhHwc1oMOyZdL8kiZHfU3AK1jogY5mzyfL4Z8G2zq/y2XXb02iOZ5P7g==@vger.kernel.org X-Gm-Message-State: AOJu0YwuVLtoemxd+mfFa936xynrlIIzVwYWGwXu2RApxqYodIa8bR1G Mc/kD+YfW3a6km5uGSDIOuPRmjMZhFFx9FX+UzzdTKaXWS6Lg6eIpfxf X-Gm-Gg: ASbGncsx7wdC6eTqd3qN8bZtFgSTSD82jHTj6C+iH9Il0On0p4egP4lAbKMjBqVob1D mYz+dNJL0AWQIDx5z9mLgo91k/LbAuf70k+RGqG8Joyv9XXB4XPylZZjRgqUeYHVUsDTN6zoEUx 7arPykl695nh0a7HI+Isva/sPUJvduTMez3LIl9lcRjwEft9ZY/MrdLzDJ3w8PijJpvDdQp722S wkS6d43ojAoMEEA16w7S87bPdJLVSBteyC5OU+twRsUZ6LUuzJi62KvQlkNrAQ9Fk83uzdjHECJ 0HR3jhd5q0mCrFSuG58L1BtQKdAFCPaRfcHM9mGDeojC4IsXUl8P7RGsk9r8Oazy8VaYrqrzpzs rj8JyOp6st/+19suI3jwqofJ+2nAfx/I11W4SzQRWtUSzJXn0eL+L4wmeySI+5Y2oKfgKO13KeO AgaTojhvLR0s3LfUAU1VEQxADRsks2 X-Google-Smtp-Source: AGHT+IESl2YLjvcT4j9is52UMA6fKdbfS1rWW+Nul6Pb+u8f5NHy8MCnsJDoGVOb40bOsnG8e/xlag== X-Received: by 2002:a05:620a:371a:b0:7e3:4899:28ab with SMTP id af79cd13be357-7e348992b22mr1949092085a.57.1752964934197; Sat, 19 Jul 2025 15:42:14 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:13 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:53 -0400 Subject: [PATCH v2 4/8] rust: device: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-4-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964924; l=1290; i=tamird@gmail.com; h=from:subject:message-id; bh=CRl/lQSZVYzZ8ljWAUnUAXiehzAwEFBaZRkNdCXXhsU=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QAdqNNzgmFK7wLExHbGwFaZHfT+WPObXmybruma+nVHZ+/uH3ldrzJxHVRnirRqQXJe3FqZDEn+ f9lwVHboijg0= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/device.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/device.rs b/rust/kernel/device.rs index 5c946af3a4d5..9e9ecdb1beec 100644 --- a/rust/kernel/device.rs +++ b/rust/kernel/device.rs @@ -5,11 +5,11 @@ //! C header: [`include/linux/device.h`](srctree/include/linux/device.h) =20 use crate::{ - bindings, + bindings, fmt, str::CStr, types::{ARef, Opaque}, }; -use core::{fmt, marker::PhantomData, ptr}; +use core::{marker::PhantomData, ptr}; =20 #[cfg(CONFIG_PRINTK)] use crate::c_str; @@ -345,7 +345,7 @@ macro_rules! impl_device_context_into_aref { macro_rules! dev_printk { ($method:ident, $dev:expr, $($f:tt)*) =3D> { { - ($dev).$method(::core::format_args!($($f)*)); + ($dev).$method($crate::prelude::fmt!($($f)*)); } } } --=20 2.50.1 From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f171.google.com (mail-qk1-f171.google.com [209.85.222.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20BC6289838; Sat, 19 Jul 2025 22:42:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964938; cv=none; b=MnSRF+8REkpqiZp5h/ullpj0/KYM2riPByfDoM4RQUT6d8DJFUCGvy92Prmh9IuOtR4RUq8PRtxbmAZZn2Bo3or1VKHtrj2lQ5huKJqI6Ft94DLUrS/KIGxrbD/4B1G+nvuNqmhiUpq7NPuv7e7urvgQEpQBN5F4sI4G8VTZEx0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964938; c=relaxed/simple; bh=pXR+pneQEkVan1ORZtdC4QLLw1pF+V8ExOh8drAAHsM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=UkFbBtRcQsmemAQUtGKW9GaU2zV7BJI5lc0qYqECVcCSera4qxe3DN+fj7YyIdcnTpOtxqOdHKub9Q5Q4JZvY+sEWIwN9Bcc++/vV77sHIzw0rpx1ZxrKmyklQtCIHypJyAwYPaj5YBuNaCO4Ci/+4SksFCGSjUAYmrRf0VeUVE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Hx8vUb0O; arc=none smtp.client-ip=209.85.222.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Hx8vUb0O" Received: by mail-qk1-f171.google.com with SMTP id af79cd13be357-7df981428abso516425885a.1; Sat, 19 Jul 2025 15:42:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964936; x=1753569736; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=cMiFmax83DBHXL/VqrofbEg17y34QjNQwBZrlkLA1Pc=; b=Hx8vUb0OYyMNOqy1dbmXDGxbec/RnuYnJzcp8tkoTvn1FlJAXyJ7IVHWJbfbI4NAZQ ZVCOL2Wuehrd4TXu86GFPLluvG8O9u+sTvyPlHu8/D8ZS/Y2UuvoIprjCV6lr+EqoI7w AeavHqKXwB12Uwc3UXdXrvWLSbENPqePXcbdmXfWV1Gab5CTXQEGKMDMS/QfiAoBXb02 mQTK0c2sHGY66JwfS31xjXC27Nyqjy8wdc2/H4YSyj61NxmovFIgdTJP2VcOWYR5IHH4 4YLHoawbdw9DalO/outZU7eZ0mTRy++R5oikplWlbjDM3gqwSkuFgUhtEBBNmJaDRUhK 7EkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964936; x=1753569736; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cMiFmax83DBHXL/VqrofbEg17y34QjNQwBZrlkLA1Pc=; b=lDHoVl8Os/rhdvCVPrGQh8FtFxXYtL1amf/g8KfCdLSlA8wCzcSkATCD/k+pFvyHfu IiCI8TY6cY1NqwS09h12xihghHeu2PfGwc4QApLtI5owhWnOfjYsHr2L5CVIgyw2l5ja Ios7Ee7YuG7HXWuhGMJf0prcRaN3vXa4LtVufw5mJ1oQ7cG61hjhB1RXCIjGySW+484g rwuP6prgkxTTD2Tc9B2sq6VyPAmr20Osu+ViUlfTdOGSAkNpZlOBVfAPserLqPsidVap 6sJ5+eDHKbGyfVrG4bzSRkexc80Ywe8tg8H8xHJHN0cjeJrp8546Xm+WEXmBh97sUOox c/RA== X-Forwarded-Encrypted: i=1; AJvYcCUZOcOy98OtY6AeThZrV82RYpT4jG11B68o4N9dbIfxnrqW9mI7Fu5bm1VfzT58gOY33LwaSSIlHnZFOFctRhw=@vger.kernel.org, AJvYcCVB5bOFkd6TNVWz5/A7x9zLMLdGH+tig9pibpDtXLxDQOg8BLAo78NG5G2/xWaVgqw3DcQodCBSECwWdYng@vger.kernel.org, AJvYcCWRg18kwFKGErjpjlZx7mbEnbABlDh9rULR7bEidvIGemQASfZvOvciH0GHpBqGuOUPEOxWck7Crona7Ygiv0Uj@vger.kernel.org, AJvYcCXN7agd8tQHOmGCRymdvzEF1fXQ1dBA2awueOUBqhFUtlMnyVproGinaE5xA2QfUbMi8jaBOMLN4i2Bmg==@vger.kernel.org X-Gm-Message-State: AOJu0Yw03BPHrXdmnULW7bQerqrGVSVbfGUluxaeUj8bmTLJZ+2Qd/Di Oqi2IrTjg25XIO8ZPf0zDXYrhcuKcikK/7Z6JIE7IIl9rnrueFkmz6q9 X-Gm-Gg: ASbGncsa0FcoYAOZd+ncBEUzK2PHZTYnyaOj5Cd5B3N5hEH4OKzqbdYvRR9bcTlACrd sO2m18VaV2HnCVn3vyJVZ6+tTa6ju2y91Br6/qoQvhEEEsgp4oESNEN7hUzRjZeLmtEyczRG757 mGc5VfgrdPbQDAW4XF2CLrfH9EP2i85fVy4tC9VIwEbqdoZwJyiZUSiwWBeumJU1xHXiBkH84Hi +pfPK8lAGZT9Eg8vxx2j7TEczHeO13fRl62UjUDDB3aP8/LQOcwqlzqH950Ku8aD6WqP5VY+E1W ECVDftppQbQimMaGAS71T/kTblvbq53iwTllyh1LuB9Do1VbIh8Jwx0BQYs7fyV+s8CBYQ3JkMW HHxPEmnu+tBPitzI+y3i4CHq2j0KgsTTtzGPJHlAiKLh/H5Sid3oJF0xlovyc/pGYScSI0PeaGv jRwkOsdSOj58ifweXL3Cq32J1J6z88 X-Google-Smtp-Source: AGHT+IGVo1i2TaQIfqAE4SlKOOW0XT2MULeIOXkGaUKBOzQ48pQ7CM6UfPlu3A7MsQxB2vk/ikPF8g== X-Received: by 2002:a05:620a:4095:b0:7e3:3da8:1d06 with SMTP id af79cd13be357-7e356b282efmr1102367685a.54.1752964936028; Sat, 19 Jul 2025 15:42:16 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:15 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:54 -0400 Subject: [PATCH v2 5/8] rust: file: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-5-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964924; l=1180; i=tamird@gmail.com; h=from:subject:message-id; bh=pXR+pneQEkVan1ORZtdC4QLLw1pF+V8ExOh8drAAHsM=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QDn9tcAkIdM1tWcaE/g1fRFUadSDfcLW0qfYjUzPTHiL3CXZbnVUx7cxTfPOCZum2i3seyeZdwF 2Wk7ChT8O9A8= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/fs/file.rs | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/rust/kernel/fs/file.rs b/rust/kernel/fs/file.rs index 35fd5db35c46..67a3654f0fd3 100644 --- a/rust/kernel/fs/file.rs +++ b/rust/kernel/fs/file.rs @@ -11,6 +11,7 @@ bindings, cred::Credential, error::{code::*, Error, Result}, + fmt, types::{ARef, AlwaysRefCounted, NotThreadSafe, Opaque}, }; use core::ptr; @@ -460,8 +461,8 @@ fn from(_: BadFdError) -> Error { } } =20 -impl core::fmt::Debug for BadFdError { - fn fmt(&self, f: &mut core::fmt::Formatter<'_>) -> core::fmt::Result { +impl fmt::Debug for BadFdError { + fn fmt(&self, f: &mut fmt::Formatter<'_>) -> fmt::Result { f.pad("EBADF") } } --=20 2.50.1 From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0E91928A1D7; Sat, 19 Jul 2025 22:42:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964940; cv=none; b=KV6DuUi31dAys1W4mJtzdmNVM7tYMRtZ48mOq6Es07o4tfgMjYS5D3x8hxfeRRsNXKDFb81oMZcDmk1nvHtGDO1Ux18+zPedn8koHC8TMLqmAoq5XUr8z2S2P83PnAepEQezgyih2x+0EeGcighrcusdBeBKOvhCSu3jTEStUAY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964940; c=relaxed/simple; bh=jyqFD6nM8ro9Ks9YCIIHVd34qdVyENgV6xpP2iUg/jQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qnL+uoCEkraGGf6atRbKo0RfQjRF7cpxUH12PAI0hTkxHaNkhePjx2h1+3d0RB6Tfrj4JHtxMMP1wbna0ZzmB3pACs79wJFS60uk/puQez/qvIbStWqcHMXYyG1nPr6AJj6BPAqKx88mSimI8w9d5ocmdmG5y6/cAPnFdFOWUPs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=FXq9Cboq; arc=none smtp.client-ip=209.85.222.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FXq9Cboq" Received: by mail-qk1-f173.google.com with SMTP id af79cd13be357-7e34399cdb2so344326585a.3; Sat, 19 Jul 2025 15:42:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964938; x=1753569738; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=1rs1DGyghn6m5F7YPyJpVWwpTqkEtp8qoCALsZqeRz8=; b=FXq9Cboq+oT/fzSrphlsy+HQsi82AdP+VMsfeS+1Xdh7vez+U2IBHswHd7TIG4XUll XTBQ16r52tFYTrEBeyUxlcap8NhHJdHhFuW/f/jotelM1w9dHdICQv8SQyYHEh4geX3a oqf9UJYIovAXzGyVzvHvFqOaLX7J5zi82D7RacxFcrGzvUnHnEqBTwcDOvHe4Bq5AnN2 I5X586tlC15ztx4buiAcFnlVcOcp5jLNds9Ra3wQllRcPQHxVlAR8qH8SyBgvO/uiKZ9 Q2/3tNemw66nHeyw7K1hH3E/sJjzOzb0elXeVK6oW/ZHq6Rng2mehkiZFHsytvkk3bfH H3fQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964938; x=1753569738; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1rs1DGyghn6m5F7YPyJpVWwpTqkEtp8qoCALsZqeRz8=; b=wEIIq4/pwSWc//fW1alJZKjFy7aYO8SLmMPEKN6/Innr9VgUYDX3/ZljXtClBUxQxb NvCcxyVA9azoQcQ5VTtK0tTCU3nB4VaILp0Lg0waEd2J94xIDhyNccPQRyvH+E0Xbr7v AYCCy13UPB5yWVWBO/cAOxPOnpTXJXns8xbLlxrcei6m9sxJHO1NNEBDSXOfxyBWsfsy Y/Kh7LQLVdxdTm93VXMc7GxlpOFsjUop/Hr16sKwLm+IEqk6Mudbdww3z9HYnNviRfZO Y1rLsSJPzNeXKXlZ3Gr7OTBtGXvCBiV4QekEpabTRCBWE3EVDjTakJFaqGvzP3irf7dt A12g== X-Forwarded-Encrypted: i=1; AJvYcCUWxqxGR72YfqlozO8OdN+kxQiUPcVVHuFAJoIY9j4HM3ZC0mh1lKRkSynHjRqICJqjSIvwinrppPbbwRZSvXv+@vger.kernel.org, AJvYcCVGtoWWXkta9hZeGyCYBIqt3SVY3QytDr1IDS+/cGWrPscX3H2ZIo8srL8XegONOpUV4FKmEQxBrCqmtw==@vger.kernel.org, AJvYcCVVNovyfeRr511OANIuhXl1w8Miqe0J8ErGTV5tz0QvElAU+Er1AvWhQvc6vPWOLydTY9nMSURXfRQujpVU0iM=@vger.kernel.org, AJvYcCXIrQ/S8imTZjElLJIv897ybakr+45VKkC3IM6EuclKgBLm0/0jzvxZ/x0Fh0Enyvoa93OBO+SRxguQCJ0z@vger.kernel.org X-Gm-Message-State: AOJu0YyfXZtL7i8OfGEyqRgC91frT235XmgTcAoiyRJfwGDK5pDGGndX s9ws5NmvIeNf6Y/MXRRkYD3FPCYn/oZ7wyNzJzEeVy7XpzE4X4CfUTtb X-Gm-Gg: ASbGncvcn2Tke/X31V2z7eOjZRhrE0a2/NPzeHvANd7Qy0kYEsAv0it6//SiSoFgQwQ wJJmitX+00EadkQp1dxREd55BY4hcIrJpD8cr4emdaqqZR63pV9SWGW14z9FEgh6bYV0t7jLhRM DzpmfUktI/sXpko9ahJ+gBDStkjxyeprzyunXKwK1c94oWbQpIsr+68mGuYqnORb7PHXpSHXBd8 D6R4OHo7KvwLaF9a0qyhEn42RdbzdBsMOXAhi2m63Q0I1S4CXaLvlfde2LErFJkazyDQ+GR4lId 9tY/JdcagPodYjdnnxwp+lb4ttd+Yl2wXr8gCq427Fr2GKgcX7wM6wbk2ECwxq8AW3ezlHRlomQ 7pXZU3vTCsfNmpHZ5AIxz6QNs0snrERNEhDep0yk5t2SGCUkbZ2UVW80m4OXvxOUriUO1q/Of1Y Ii/PrMy7+MsoiKRm7AXff/Td+13DUg6mDb9GZxObE= X-Google-Smtp-Source: AGHT+IFtOTZ/PrQwepu0hwdAQftEUkuWxYVHS9B8D5JpfvXd++3lzu/pWaap3iuGs4DIwGCQ04QMyQ== X-Received: by 2002:a05:620a:7203:b0:7e3:4601:9721 with SMTP id af79cd13be357-7e34601a170mr1752546885a.44.1752964937883; Sat, 19 Jul 2025 15:42:17 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:17 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:55 -0400 Subject: [PATCH v2 6/8] rust: kunit: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-6-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964924; l=2517; i=tamird@gmail.com; h=from:subject:message-id; bh=jyqFD6nM8ro9Ks9YCIIHVd34qdVyENgV6xpP2iUg/jQ=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QNOn8Tovv2dHgoqC1i0lAp321l6XEurS5uFMegrG079Th4U9L3wXbn9B8imJH6UktgvZZeU5c9O yz00xKgktJQE= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/kunit.rs | 8 ++++---- scripts/rustdoc_test_gen.rs | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs index 099a61bbb8f4..42498cb93f33 100644 --- a/rust/kernel/kunit.rs +++ b/rust/kernel/kunit.rs @@ -6,8 +6,8 @@ //! //! Reference: =20 +use crate::fmt; use crate::prelude::*; -use core::fmt; =20 #[cfg(CONFIG_PRINTK)] use crate::c_str; @@ -74,14 +74,14 @@ macro_rules! kunit_assert { // mistake (it is hidden to prevent that). // // This mimics KUnit's failed assertion format. - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " # {}: ASSERTION FAILED at {FILE}:{LINE}\n", $name )); - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " Expected {CONDITION} to be true, but is false\n" )); - $crate::kunit::err(format_args!( + $crate::kunit::err($crate::prelude::fmt!( " Failure not reported to KUnit since this is a non= -KUnit task\n" )); break 'out; diff --git a/scripts/rustdoc_test_gen.rs b/scripts/rustdoc_test_gen.rs index 1ca253594d38..507d36875196 100644 --- a/scripts/rustdoc_test_gen.rs +++ b/scripts/rustdoc_test_gen.rs @@ -201,7 +201,7 @@ macro_rules! assert_eq {{ // This follows the syntax for declaring test metadata in the proposed= KTAP v2 spec, which may // be used for the proposed KUnit test attributes API. Thus hopefully = this will make migration // easier later on. - ::kernel::kunit::info(format_args!(" # {kunit_name}.location: {real= _path}:{line}\n")); + ::kernel::kunit::info(fmt!(" # {kunit_name}.location: {real_path}:{= line}\n")); =20 /// The anchor where the test code body starts. #[allow(unused)] --=20 2.50.1 From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f176.google.com (mail-qk1-f176.google.com [209.85.222.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C1E5228A409; Sat, 19 Jul 2025 22:42:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964942; cv=none; b=m2pLXH3F8/aNe61LW12tBtEBXrF1PiB0uvWCfI0bREQQjYQNxYX1jGqQDiGdcs6DO+fNZKxCTJmVcVqXgZ2blSgKTPWK0dWr6vc+xP1YRrCrgAb3C6d6DudhYyD3bYLaQ5h6aAo/9t8R76r7yitSoKXiqxytsQ/xjJGem+i9PU0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964942; c=relaxed/simple; bh=gHz4toQCU6anYJFOzHxe6eDUDf8ThYIsMKIWmLd67QA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XX7qUtCa4q4OHu2n67n/aAU9VG+iU20+scAvCQPTNhhpeMM4cd2SXmrHFsuqAYk0e1YHgnJcv1ly/t7Rz82hv+a7vlIczM7Qb+CKbRqle7fyys3h4moIXW85lant7H2zSr1bAXgcXNo+OPzMoZ1qqcmm2nW3JUjwvPoJxKKCuFQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=H/qjclBn; arc=none smtp.client-ip=209.85.222.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="H/qjclBn" Received: by mail-qk1-f176.google.com with SMTP id af79cd13be357-7e2c920058fso417370685a.0; Sat, 19 Jul 2025 15:42:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964940; x=1753569740; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=VZcvS4JIeKOz3OyYrU6VSPD/RKPN1X8doP0FytHrmgA=; b=H/qjclBnALVYY/UuMkoiQ1H5gWJEpp98GX7RvW6vqDxiXC5GdodpI14KBqPcWWCWR7 shCA84YAOWgLwRXa+zzx2U6mqLg7Hf8WFyVOmdX4OzIANf7Wd43udK/Eu7zJECZ8FQ9t 5z+2+lhXBeglIWzFStQ/q10GJfP9j2Mg7Hj/xYbi1pfQeahbI6UzB5c1p8JrrtFEY+IE pjtyLv15Fa/IQybkZx5BltJ8T0jWHzRpG4B4K6laSdcwxAMCDybLgDJSoDzrAtMP/N56 A47WxGd78cRSwNuLr5XvJKOq6RDV1gPQeavRNyM6FDWpHsBu2Xoy/Yx+pTswcA2fxGUr uaFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964940; x=1753569740; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VZcvS4JIeKOz3OyYrU6VSPD/RKPN1X8doP0FytHrmgA=; b=qBMeudAQscAqe0JnJrBD5B7Uf6wSaZ1Aiv3bJmYSLvPawfmtOhKSNZEb+9GPpgvYWK OXbnjfSIHhDCFHmbmDTef3APgjXj/hM1rvShUxI0btWeCklLUjiBGkbhwrHdq7jvZNL0 tPnkmyLs1uKAmnFy9XYOxSszHuwrN3/BBvAa6/YFJRr5p1lnTVpVoe6txE0Vw4fxmxZm w6GmyCwOGzlVf1oYHeauJmF/U1ar2pDVOZvVz+yEX/dWIpaDEjeVWck6X6WoLhv+mSEz 2UhiKjx8paQbO89kaff4Ys5kNxBogGdQ3stZyX+yRmhUzfYKHki5hTQz9Ys62GBHrqaw C4QQ== X-Forwarded-Encrypted: i=1; AJvYcCVp6ITHHrPCeg1KCcYlDwJRxwRhuz9R4PgxM34yfOdF3TLkmJ66JNzo/awWR5D25/otS6XUoWuXFfXd0niC5sM8@vger.kernel.org, AJvYcCX/YMOw4++zCNK07O44hB7b8Qo5DHbxWSZtJs6SGYynH+BXof5FpEkBeeO2FZ8ZIEkDDqo59J7qh8QD7fFM@vger.kernel.org, AJvYcCXdkdGkbNJhrl4CcT/XUR6ztwULGNnrlVTbhCAVNz1OX2Juh/7iklP6H6EJ6qHvhHHV4scJn/z2nw6mZ6VH/uE=@vger.kernel.org, AJvYcCXxSBY+zIrmP885UhPow33f6KUPKRAS7jnWLAG05xH+Qy+LYCluOHgvVlwUVyZ+L7HOMY+EcPeKGUmCtg==@vger.kernel.org X-Gm-Message-State: AOJu0Yye+Fsu6nZASvXktYjcB0abird69vLp5lg2mM7ynFLAzh4Rt6xx U6Mxp2/Frsy7av8bkJ82603E9eUit+UT4FRRk9Du6kMIBgapWl/wJ0hw X-Gm-Gg: ASbGncu6Qd+9r1/X2NNxQe9imkEpiy94Pn7jeBLsYAEVGGuaOKZ/sd/Hyyg5G/oMYjo WZ4xTqeEIuOdUpM6GaldktzW80g1VxQszn59PGo6F2Eb8cR7zztQ+QbvMlNz3CwEnMRdMgBtugZ YjtR2AclF1VLwQqu59vbzOImOJov1jRVBwobOGmBU/omD6rhiGu0yKibJUIRPs+In72WC++wtoW FFevNBPkbZP/+ScOm3gJrSBYlgtx4n6LTnd4wGZQE6TjgkrGGuc5NpeWU+ODUUoP0gpfJnHeHch TFIvnc9XyxVUqI8oiPtQnAdq1LZ/jPQH7XVEP/WLucpfwytA0SI6Uq/Hb9rj53JjW/Pb56e4mCV +GdrZEsOgA2YEErR7IPDrxB2z8j1YSgGDXDw3i9XBlzPhIonGT1lqXWhXBgKfK9YyasWGcnoNGK ThkC6xHECAKXUj+l23WquOZhtmM3jzt6xWkRDWTmg= X-Google-Smtp-Source: AGHT+IHV2N3qMrMs14RixVMrz4N7FPqczHbGPdgP1qIFChDpfiZUqiOOYjpmsvCFrdcWFOVKjkhmCg== X-Received: by 2002:a05:620a:2307:b0:7e3:328c:b7eb with SMTP id af79cd13be357-7e34d25445cmr1248059085a.21.1752964939622; Sat, 19 Jul 2025 15:42:19 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:19 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:56 -0400 Subject: [PATCH v2 7/8] rust: seq_file: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-7-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964924; l=1715; i=tamird@gmail.com; h=from:subject:message-id; bh=gHz4toQCU6anYJFOzHxe6eDUDf8ThYIsMKIWmLd67QA=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QE/CoWxTuDiUL7P9sRtLudjxXtE9D5paPxY0RwUT1Ot1C5eNVZBHb7FvDXrP2kLzdXk8G/yjl4P KRF2R/+b7PAs= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/seq_file.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/seq_file.rs b/rust/kernel/seq_file.rs index 8f199b1a3bb1..59fbfc2473f8 100644 --- a/rust/kernel/seq_file.rs +++ b/rust/kernel/seq_file.rs @@ -4,7 +4,7 @@ //! //! C header: [`include/linux/seq_file.h`](srctree/include/linux/seq_file.= h) =20 -use crate::{bindings, c_str, types::NotThreadSafe, types::Opaque}; +use crate::{bindings, c_str, fmt, types::NotThreadSafe, types::Opaque}; =20 /// A utility for generating the contents of a seq file. #[repr(transparent)] @@ -31,7 +31,7 @@ pub unsafe fn from_raw<'a>(ptr: *mut bindings::seq_file) = -> &'a SeqFile { =20 /// Used by the [`seq_print`] macro. #[inline] - pub fn call_printf(&self, args: core::fmt::Arguments<'_>) { + pub fn call_printf(&self, args: fmt::Arguments<'_>) { // SAFETY: Passing a void pointer to `Arguments` is valid for `%pA= `. unsafe { bindings::seq_printf( @@ -47,7 +47,7 @@ pub fn call_printf(&self, args: core::fmt::Arguments<'_>)= { #[macro_export] macro_rules! seq_print { ($m:expr, $($arg:tt)+) =3D> ( - $m.call_printf(format_args!($($arg)+)) + $m.call_printf($crate::prelude::fmt!($($arg)+)) ); } pub use seq_print; --=20 2.50.1 From nobody Mon Oct 6 15:13:24 2025 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6C10F28AAE6; Sat, 19 Jul 2025 22:42:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964943; cv=none; b=OkoOmyxs+twst6uNegRvypdl8XnK04xKP1vhYrOM0icGQWcQ5fSDsQUIkgLOpY7+I+HY06MzNGsWaz88VxKX4YNZmi5neGJ+KqMoH/HYohxgLHfxmc118igNKPZPnbGspjNE+DhoODWQApf+ed8S5i3VGOUrtQb9PDsxfgT0k18= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1752964943; c=relaxed/simple; bh=JT4wt4ZGHRcX28Gp51Np/HdVIFSoSzvSxV6NKAkiYZQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=GfxoCTTqNhHRj7sXAa1iXQeWrjn8jhwkaVGO5iwRYRJvFnD48bF3ZSyAanbQEQJ63l2uEJmrlzwCug7Ov5CvSBhS2b4MIhUy6tTRAQBpcpaF4vxmZLeuHP6W0Oh1DrITKVZAKTRkj5bCTmQVQ/AqgQVQ8bn1UourPt9NP7Oc2bE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=g1sZbMIe; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="g1sZbMIe" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7d45f5fde50so289197685a.2; Sat, 19 Jul 2025 15:42:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752964941; x=1753569741; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QdbbYgm/iXkAkxwQMWH0ycz2sZVChnbra180vU+zHz0=; b=g1sZbMIeEXbvKaUyQ8zDJF+7Gq+GDF58AgjGvX6vsiz2IxK0+Je9KyXjvWrzjhmZ3k 2R7jR3tnFWXzxlNWMXIQ7iv+xtfQT2AkRvSHIQQGZqRWZx+7UHSncZlyz6SSlo6bfYPe uResAh1DtdBZnq48EA1TPifoiElI4m0Gb6Wi6Uk0GCOTv6zGAxfAQ0ZidXkHPgaYWtbg BUzaoynCAwxbuFvmoSnoDda0W17ED4xMhdJ0GTz+TVBHH3ZpCVaCNo6oAe8kbQG7ndde WuETqZiKDc5fY3MLCI0ULfpZ0XGjSws1nVsxNafeHbFDnmPyXHMuJ2/o1ZcWwQe/aFTF /t3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752964941; x=1753569741; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QdbbYgm/iXkAkxwQMWH0ycz2sZVChnbra180vU+zHz0=; b=ZsVrj+03q1tIsPJpuQWe9w9d1sD78AY67nLYKsQpL9YHrMU3aeA5FvOTb9/L8yg1cw 1NJcQjKCcLNjlGUrHGTtg9PjWWL1cjRezayCL5BnOJcsx3bclxh696HogQoCPOctiXgU bPxy8OXo5Ib2LyDLASxhBvh5XKP1cfl9Oz6xboGSS0jjs21z6TKEI+Ywe7ZhP6s1W6Td 0JWIHY0AlmcQd7w6V/gYQgZ6kH9L81yVuaIIv2Apde/hD+4EvCrKdyrACwQ2yB7qUZTx RokS3f0kkPh0QAmC5LHR4lvNaEoXxCAe6tOv492hXpdJ5JN7DuYPn2jArb0UH98KWanC FqEw== X-Forwarded-Encrypted: i=1; AJvYcCU7Gb1rNJ+aoT8J+hzNL5DkQ05HuzMBM3hIm5475FZC+txzjGilcY2yLu517buz5py32y0yxFGewytH9DHT@vger.kernel.org, AJvYcCVTgTtJVsgd2nNR9k6nAL988BGSLv4GdD7uauxUBu2mkiIFv1CIwHguOVbaLhWQFNoxqa20d3EodY5x73STEJ59@vger.kernel.org, AJvYcCXCcoUq+neXJYmq6ejutaOxKAapjoPrgPQy3wiivGtIV+WKpPHqW2alxAQ2iDDYJ0N5fPT8VQlZuOp6MRCaDVw=@vger.kernel.org, AJvYcCXaxemWeeCtaXmTe+QiUbXfSmHU2Cwvzm1MHsIPwH8LJ/IHaKQ8XLrPKQK8adRMCFQoYPllIybWV8ATOA==@vger.kernel.org X-Gm-Message-State: AOJu0YxEZ9h/mJTQ88zsmQKgwgds7V2uBsnc11vyxoRfPFJTdTvIBuJE hpoH5TZQeSaSA0+GV/zoI+focv3hp3i8RCVUJ6EVOdQsa8o5aHbkTyH3 X-Gm-Gg: ASbGncsTC11YtVzYFaC7xigXioHNfk2XpA674VrG3NAN64HsnZRpgo1VFL3BhJRxmsX sSCfvC+9kPg+0bbbsOEJoLZLOcewF4Kjr3R5bN3GrWG1poUp2KoUbknePk0yKqtNV/cB54JQvNT fuXhI3U5B+XKG7yWzpD8QcwvvRjjROT81XvAN3snnI/fV9JpmgKBFvjsM731B6tOttX9BdY3VAK KoOhjQo0emsdYIKcWpEEwXLbKjHeQ0q/0ymjdy8MbTcKrqcA9MgfRGH2vkLVTqF1KsTjryU6D6F /R0n3XqW5++sO6+6iWPcNiKast7AUgCpG1IVZz3AGAAqti3wtYyAvWoqddNUSVTo5VpkrtDoGLN R0Z84MlXriIr+JGQLPg+X3qn6yzEr9TcoNeH5376WHo6il8d3fMxufkVE4V0T9FdszL6BfnMW0Q mJscajDZE3NH2xryZMdb/yfhMo0X0E X-Google-Smtp-Source: AGHT+IExJ0S3QQDaiGbPTBsZmpSjuOQIlR5bLS/MkE3qOes24LnmbTk8ROv7AcJo9jNAjk73PAhZ2Q== X-Received: by 2002:a05:620a:2603:b0:7d6:f963:8764 with SMTP id af79cd13be357-7e342b37069mr1693903085a.34.1752964941355; Sat, 19 Jul 2025 15:42:21 -0700 (PDT) Received: from 1.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.0.ip6.arpa ([2600:4041:5c29:e400:78d6:5625:d350:50d1]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7e356c75cf5sm251550785a.84.2025.07.19.15.42.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 19 Jul 2025 15:42:20 -0700 (PDT) From: Tamir Duberstein Date: Sat, 19 Jul 2025 18:41:57 -0400 Subject: [PATCH v2 8/8] rust: sync: use `kernel::{fmt,prelude::fmt!}` Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250719-core-cstr-fanout-1-v2-8-1ab5ba189c6e@gmail.com> References: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> In-Reply-To: <20250719-core-cstr-fanout-1-v2-0-1ab5ba189c6e@gmail.com> To: Danilo Krummrich , David Airlie , Simona Vetter , Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jens Axboe , Greg Kroah-Hartman , "Rafael J. Wysocki" , Brendan Higgins , David Gow , Rae Moar , Lorenzo Stoakes , Vlastimil Babka , "Liam R. Howlett" , Uladzislau Rezki Cc: nouveau@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, kunit-dev@googlegroups.com, Tamir Duberstein X-Mailer: b4 0.15-dev X-Developer-Signature: v=1; a=openssh-sha256; t=1752964924; l=1044; i=tamird@gmail.com; h=from:subject:message-id; bh=JT4wt4ZGHRcX28Gp51Np/HdVIFSoSzvSxV6NKAkiYZQ=; b=U1NIU0lHAAAAAQAAADMAAAALc3NoLWVkMjU1MTkAAAAgtYz36g7iDMSkY5K7Ab51ksGX7hJgs MRt+XVZTrIzMVIAAAAGcGF0YXR0AAAAAAAAAAZzaGE1MTIAAABTAAAAC3NzaC1lZDI1NTE5AAAA QLEQxox4uw29M7Ga/wSxO4/q3iC5xttqA8XggKW3e209GRzKxBr13fwKRE/61UufHZ5HECtWBet gOEf03vWiSw8= X-Developer-Key: i=tamird@gmail.com; a=openssh; fpr=SHA256:264rPmnnrb+ERkS7DDS3tuwqcJss/zevJRzoylqMsbc Reduce coupling to implementation details of the formatting machinery by avoiding direct use for `core`'s formatting traits and macros. Acked-by: Greg Kroah-Hartman Reviewed-by: Alice Ryhl Reviewed-by: Benno Lossin Acked-by: Danilo Krummrich Signed-off-by: Tamir Duberstein --- rust/kernel/sync/arc.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/sync/arc.rs b/rust/kernel/sync/arc.rs index 63a66761d0c7..4f3c1c2ff05e 100644 --- a/rust/kernel/sync/arc.rs +++ b/rust/kernel/sync/arc.rs @@ -20,6 +20,7 @@ alloc::{AllocError, Flags, KBox}, bindings, ffi::c_void, + fmt, init::InPlaceInit, try_init, types::{ForeignOwnable, Opaque}, @@ -27,7 +28,6 @@ use core::{ alloc::Layout, borrow::{Borrow, BorrowMut}, - fmt, marker::PhantomData, mem::{ManuallyDrop, MaybeUninit}, ops::{Deref, DerefMut}, --=20 2.50.1