[PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup

Rosen Penev posted 6 patches 3 months ago
There is a newer version of this series
.../bindings/net/wireless/ralink,rt2800.yaml  |  49 +++++++++
arch/mips/boot/dts/ralink/mt7620a.dtsi        |  10 ++
drivers/net/wireless/ralink/rt2x00/Kconfig    |   2 +-
.../net/wireless/ralink/rt2x00/rt2800soc.c    |  75 ++++++++++++-
.../net/wireless/ralink/rt2x00/rt2x00soc.c    | 104 ------------------
.../net/wireless/ralink/rt2x00/rt2x00soc.h    |   2 +-
6 files changed, 133 insertions(+), 109 deletions(-)
create mode 100644 Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml
[PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup
Posted by Rosen Penev 3 months ago
It doesn't even compile. Added OF bindings, documentation, and other
stuff to hopefully this doesn't happen again.

Rosen Penev (6):
  wifi: rt2x00: fix compilation
  wifi: rt2x00: remove mod_name from platform_driver
  wifi: rt2800soc: allow loading from OF
  wifi: rt2x00: soc: move and modernize probe
  dt-bindings: net: wireless: rt2800: add
  MIPS: dts: ralink: mt7628a: add wifi binding

 .../bindings/net/wireless/ralink,rt2800.yaml  |  49 +++++++++
 arch/mips/boot/dts/ralink/mt7620a.dtsi        |  10 ++
 drivers/net/wireless/ralink/rt2x00/Kconfig    |   2 +-
 .../net/wireless/ralink/rt2x00/rt2800soc.c    |  75 ++++++++++++-
 .../net/wireless/ralink/rt2x00/rt2x00soc.c    | 104 ------------------
 .../net/wireless/ralink/rt2x00/rt2x00soc.h    |   2 +-
 6 files changed, 133 insertions(+), 109 deletions(-)
 create mode 100644 Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml

-- 
2.50.0
Re: [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup
Posted by Johannes Berg 3 months ago
On Sun, 2025-07-06 at 14:41 -0700, Rosen Penev wrote:
> It doesn't even compile. Added OF bindings, documentation, and other
> stuff to hopefully this doesn't happen again.
> 
> Rosen Penev (6):
>   wifi: rt2x00: fix compilation
> 

That was half covered by Felix already, and really shouldn't do two
things at the same time anyway.

Also please add [PATCH wireless] or [PATCH wireless-next] prefix when
you submit patches, to make it clear where the series is targeted. In
this case, you probably should've split it up, but Felix already covered
the immediate bug.

johannes
Re: [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup
Posted by Rosen Penev 3 months ago
On Mon, Jul 7, 2025 at 2:01 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Sun, 2025-07-06 at 14:41 -0700, Rosen Penev wrote:
> > It doesn't even compile. Added OF bindings, documentation, and other
> > stuff to hopefully this doesn't happen again.
> >
> > Rosen Penev (6):
> >   wifi: rt2x00: fix compilation
> >
>
> That was half covered by Felix already, and really shouldn't do two
> things at the same time anyway.
Just saw what you're talking about. That's gonna be annoying though.
The COMPILE_TEST commit will cause compilation to fail and the bot to
complain before Felix' patch gets merged.
>
> Also please add [PATCH wireless] or [PATCH wireless-next] prefix when
> you submit patches, to make it clear where the series is targeted. In
> this case, you probably should've split it up, but Felix already covered
> the immediate bug.
Will do.
>
> johannes
Re: [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup
Posted by Johannes Berg 3 months ago
On Mon, 2025-07-07 at 10:41 -0700, Rosen Penev wrote:
> On Mon, Jul 7, 2025 at 2:01 AM Johannes Berg <johannes@sipsolutions.net> wrote:
> > 
> > On Sun, 2025-07-06 at 14:41 -0700, Rosen Penev wrote:
> > > It doesn't even compile. Added OF bindings, documentation, and other
> > > stuff to hopefully this doesn't happen again.
> > > 
> > > Rosen Penev (6):
> > >   wifi: rt2x00: fix compilation
> > > 
> > 
> > That was half covered by Felix already, and really shouldn't do two
> > things at the same time anyway.
> Just saw what you're talking about. That's gonna be annoying though.
> The COMPILE_TEST commit will cause compilation to fail and the bot to
> complain before Felix' patch gets merged.
> 

Yeah well. That doesn't really mean it should be merged together though,
and we can pretty easily make that work by just putting the further work
in after net/wireless is merged back.

johannes
Re: [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup
Posted by Rosen Penev 3 months ago
On Mon, Jul 7, 2025 at 11:36 AM Johannes Berg <johannes@sipsolutions.net> wrote:
>
> On Mon, 2025-07-07 at 10:41 -0700, Rosen Penev wrote:
> > On Mon, Jul 7, 2025 at 2:01 AM Johannes Berg <johannes@sipsolutions.net> wrote:
> > >
> > > On Sun, 2025-07-06 at 14:41 -0700, Rosen Penev wrote:
> > > > It doesn't even compile. Added OF bindings, documentation, and other
> > > > stuff to hopefully this doesn't happen again.
> > > >
> > > > Rosen Penev (6):
> > > >   wifi: rt2x00: fix compilation
> > > >
> > >
> > > That was half covered by Felix already, and really shouldn't do two
> > > things at the same time anyway.
> > Just saw what you're talking about. That's gonna be annoying though.
> > The COMPILE_TEST commit will cause compilation to fail and the bot to
> > complain before Felix' patch gets merged.
> >
>
> Yeah well. That doesn't really mean it should be merged together though,
> and we can pretty easily make that work by just putting the further work
> in after net/wireless is merged back.
Looking at it again, I'm effectively removing rt2x00soc.c . Meaning
Felix' patch is mostly useless here.

It might make more sense to submit this series at a later time.
>
> johannes
Re: [PATCH 0/6] wifi: rt2x00: add OF bindings + cleanup
Posted by Johannes Berg 3 months ago
On Mon, 2025-07-07 at 15:55 -0700, Rosen Penev wrote:
> > 
> > Yeah well. That doesn't really mean it should be merged together though,
> > and we can pretty easily make that work by just putting the further work
> > in after net/wireless is merged back.
> Looking at it again, I'm effectively removing rt2x00soc.c . Meaning
> Felix' patch is mostly useless here.

But we're not going to put your changes into 6.16. They're not even
entirely ready yet, from what I see in the thread.

> It might make more sense to submit this series at a later time.
> 

By end of the week Felix's patch should be in wireless-next too, if I
get all the things done right...

johannes