From nobody Tue Oct 7 19:53:38 2025 Received: from mail-pf1-f169.google.com (mail-pf1-f169.google.com [209.85.210.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90FD11E008B; Sun, 6 Jul 2025 21:41:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838077; cv=none; b=J2ee7CzBa2b+qjSTTogONPJYm2oZU8o8it/7RKL7GlUB/xKLV/r4X3N7qWrm9sk6PIbzSenCZSuMUBJQvNAQ4OCMeICW3+D58qFfX/m9EK7lJ00sNJd+Lvg1cUneCckM3Rz1hGZfmcx/pcAhkwmDWKw68C7IQ1In0gpC2C5yqJ0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838077; c=relaxed/simple; bh=aazGO021bpAZfDCePBJnyp53QYIweGV/gZ21+LQWiDo=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=M22kinfzUnppgXtpFMpsfkQwzB0WymT1onUFyxA4a4w/sYLfw3s9ROHWxvaTH8hEbhAdQPRWF7BnWsC0edDqfduUYjq3+UIpFDiTGbIfQPGXzZehGqoeCWVgBg43gdDql6YChFkpkN9AQp+uzsBRcqaK98heNkyymX2plg77YGQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Cq9AJ5np; arc=none smtp.client-ip=209.85.210.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Cq9AJ5np" Received: by mail-pf1-f169.google.com with SMTP id d2e1a72fcca58-73c17c770a7so3127798b3a.2; Sun, 06 Jul 2025 14:41:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751838075; x=1752442875; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KIiqXz9LsgS5XmKPI7jHGuK8VIEq2ClzFVk908OgH1k=; b=Cq9AJ5npe66cW3ztTKMTC/1MQYyxxFmlx451oE5D3BBd5ruOUDgAzEuCfTQ+/at/mb wq8SIeDgKG+jh3Fd9HvWO4a4anTkXnDDmahO1z0/0Km6mP0Xyd5ia684xjcfmK2EfHGA XwWi4ChRFW7tAM3Ha1PqZUeMWIGiUkeO+cCvTW+/FjJFla+k4Rcv4nXOfSk0DM7P51Ki HuvEud65dq/VepxWdzF8XfVz+1uyo9Vj/gydkrpIaNRxblekmEZbUYILpt/2IHpKhV7U xlLwlKo1kavvXOp524m5X7Y72b4pYDOFRtDtJZCyi/XVAtXsHESsM2t7OlvT+hY0/S+F iNFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751838075; x=1752442875; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KIiqXz9LsgS5XmKPI7jHGuK8VIEq2ClzFVk908OgH1k=; b=BpYf/GbUBH+U0UdRPnvkVHi94d0oeH9jRYmy9my5Xv6l2u8q8FVaos/IJ+ghM4wRNJ 0eBZ4vlcBaaVSWd4oNuxnb1K3yG057njOTapOQ9tlx1CxEpImMZEZWk1SsSHzyPU8GnD 2W+YCDONfdapqFrb4HHF2jnQ6EerCYsVEGOw0/2WRqJksvbzJG1m4zUzAjMrORv6v4O4 EpaxU1sujTXxOEtVRUNZbNbpnzX7CyuFCVW9UlaEmc0XSeZilLrZhDZwTDTfb1swoz42 JiRzdtqC8G8SqR6Z3oLimm00CZWem/a5ZcsWFts50ef5fxc3Su5DxzVxLWVj1fnBvPor D1iQ== X-Forwarded-Encrypted: i=1; AJvYcCW0cdsoQfsO9R/6ryF4LrxDrJ8gBptg4m/UJqtfRZIbFQhKSHqhNeGZGHItzI23VYcrtny8+oUvG+aK@vger.kernel.org, AJvYcCXK6vTDy/YpQkGOuBy3wLMtPieOVyi2oTfYkKm1922r+SbKmdM7fTY3/+NbIFHsdCCqRVBJdKLuJeLjlg==@vger.kernel.org, AJvYcCXSYkTYROylOopu28lDXVdcfCIVlfz3B7e2TuIw7+zsGfLB5AIi0gdpR+fCT+D/hak01nxq8XDxgzjJJeVr@vger.kernel.org X-Gm-Message-State: AOJu0YwVo9xI2vTWFAukF3fdSNdGxgK1u45eQyhO2Z2kiv32qUrCy+bG pG847YgTIBwweOIz///UU2nN+YFw4fABKe6iOC64qV7lPa9vIoizkxW+TeGBFMeuqms= X-Gm-Gg: ASbGnctu4yivmLZT+4vYfTKnsQsPUqugqqhrEIdOp7WCkHL7F1D3Zt+O6o07hAyAa3r 2vxHksdWGOAnsHi8IaZ+IHOvqWuXVL6U75rW7kbib1W9A5EyB/IWg4g1L4D4l+KDcj3gZ2cqpsb q6IENeHJvsrm4CXOopaFM5+4ac4wogwxqukBS/NhdDVLNxWHQG6vEs24/Jgf9/GGU+I+GtMLFAu 5NJAxLX3L/PJBbvLqG6jxn9PmJsB2/++XlXYYGrjEqCMPDw48htjbzwxAeIZyQwqu8pu/JEyaA5 gSKx55SuWC4ivh8OSeFtFCnMDmat7SGciQaa5dNmSSY= X-Google-Smtp-Source: AGHT+IEwlHfBS1DHzBD9Lj+YLxDEJbYcNB+0NkMuq5is6NeWi5/aui1kdvGuU4/F3aaylahetEIVfg== X-Received: by 2002:a05:6a21:6497:b0:215:d565:3026 with SMTP id adf61e73a8af0-2260c33514bmr14391573637.20.1751838074724; Sun, 06 Jul 2025 14:41:14 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:dab8::1f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74cfad75020sm4126416b3a.109.2025.07.06.14.41.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 14:41:14 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Johannes Berg , yangshiji66@qq.com, ansuelsmth@gmail.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Matthias Brugger , AngeloGioacchino Del Regno , Stanislaw Gruszka , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH 1/6] wifi: rt2x00: fix compilation Date: Sun, 6 Jul 2025 14:41:06 -0700 Message-ID: <20250706214111.45687-2-rosenp@gmail.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250706214111.45687-1-rosenp@gmail.com> References: <20250706214111.45687-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" The .remove prototype commits seem to have missed this driver. Probably because COMPILE_TEST is missing. This is a mess anyway. These non static functions will be moved to their proper place. Signed-off-by: Rosen Penev Reviewed-by: Sergio Paracuellos --- drivers/net/wireless/ralink/rt2x00/Kconfig | 2 +- drivers/net/wireless/ralink/rt2x00/rt2x00soc.c | 4 +--- drivers/net/wireless/ralink/rt2x00/rt2x00soc.h | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/Kconfig b/drivers/net/wirel= ess/ralink/rt2x00/Kconfig index d1fd66d44a7e..3a32ceead54f 100644 --- a/drivers/net/wireless/ralink/rt2x00/Kconfig +++ b/drivers/net/wireless/ralink/rt2x00/Kconfig @@ -202,7 +202,7 @@ endif =20 config RT2800SOC tristate "Ralink WiSoC support" - depends on SOC_RT288X || SOC_RT305X || SOC_MT7620 + depends on SOC_RT288X || SOC_RT305X || SOC_MT7620 || COMPILE_TEST select RT2X00_LIB_SOC select RT2X00_LIB_MMIO select RT2X00_LIB_CRYPTO diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c b/drivers/net/w= ireless/ralink/rt2x00/rt2x00soc.c index eface610178d..f7f3a2340c39 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c @@ -108,7 +108,7 @@ int rt2x00soc_probe(struct platform_device *pdev, const= struct rt2x00_ops *ops) } EXPORT_SYMBOL_GPL(rt2x00soc_probe); =20 -int rt2x00soc_remove(struct platform_device *pdev) +void rt2x00soc_remove(struct platform_device *pdev) { struct ieee80211_hw *hw =3D platform_get_drvdata(pdev); struct rt2x00_dev *rt2x00dev =3D hw->priv; @@ -119,8 +119,6 @@ int rt2x00soc_remove(struct platform_device *pdev) rt2x00lib_remove_dev(rt2x00dev); rt2x00soc_free_reg(rt2x00dev); ieee80211_free_hw(hw); - - return 0; } EXPORT_SYMBOL_GPL(rt2x00soc_remove); =20 diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.h b/drivers/net/w= ireless/ralink/rt2x00/rt2x00soc.h index 021fd06b3627..d6226b8a10e0 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.h +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00soc.h @@ -17,7 +17,7 @@ * SoC driver handlers. */ int rt2x00soc_probe(struct platform_device *pdev, const struct rt2x00_ops = *ops); -int rt2x00soc_remove(struct platform_device *pdev); +void rt2x00soc_remove(struct platform_device *pdev); #ifdef CONFIG_PM int rt2x00soc_suspend(struct platform_device *pdev, pm_message_t state); int rt2x00soc_resume(struct platform_device *pdev); --=20 2.50.0 From nobody Tue Oct 7 19:53:38 2025 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA5EE2882C9; Sun, 6 Jul 2025 21:41:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838078; cv=none; b=G8rWGrZC+xr7oPHjYA8zzd++V4MgIA3hMkuLGTRs28KS1Po+CNDjc66ny5BD3EYEtM8VMuxBLXxAUInrQdcxMMXW0fosCdyx7lakqQhWL2fi2gIPgdzgCBx/sMDX4oSq3cWETe2e3x5iVmS3CnXWNBtPVUPUqubKfEJr02EEesY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838078; c=relaxed/simple; bh=b6gbwR2gSs7Kmg85siBAQ4vpuSplRso9xZ9HTGNhXoI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=hWUWMzQlKVhiGzcNEE6mQl2+UuawUXG/Obcpsugl9sSbzePAl+xXpi4B5LrA2GezTNSYvg5dUamNudqEpqsNbay8urlSrcyM0lrQIVnSJ8Wn6iKQjr0gSivrjZ5MY8gvYGJRqg2OlPUu6f2iYQQFQo0/EiCqr0I1usumJ8Gu210= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gWxI2NAf; arc=none smtp.client-ip=209.85.210.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gWxI2NAf" Received: by mail-pf1-f180.google.com with SMTP id d2e1a72fcca58-74924255af4so2283363b3a.1; Sun, 06 Jul 2025 14:41:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751838076; x=1752442876; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=iX+WqYiCw5qRjWmx7tMtJD8AKsU6fZ26cq9/PxDn0ME=; b=gWxI2NAfQ0FFXOdknOIw72wZC+nXmRKtWKX5eMU361AR7TFgb8VaBnvjETuELeb12G jgJIwQ7DPz3kbrgLMV7725KKtsXzzDRfW3E2zUZ2ideKVOlVNj2velQDIb9JIPiY9GNq gvIuT9eQJ4nLioW+cRcI0TfKSHFwQ+GEbZY6WGibVU2AThlEOd62g3+9e1YfA4+O+KjS 3NL/VMwC3fPKoKHqH07R7sRFsfkxR8l1EP+Ru8kAaAm2k4FCzPnAWTQLc6TrumlCv+KU 8UJlRQOZ7DpWoNLVfZlcMfIrx5jfNe042bZU1KrJAcj0tKs8zG+zY9dp7lNRbBCEJl9q XDhg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751838076; x=1752442876; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=iX+WqYiCw5qRjWmx7tMtJD8AKsU6fZ26cq9/PxDn0ME=; b=W60QoK1i3e594GBk3oKM5ncDR0zZ97op14VMsheZ3D8+P9M0TXF3m+anJ762U1yBji AUZRr9LH7bjBjHQOIhVNvsN0C2tC3ptUsU2IGwszFdxjaY8WJTToTDOJyG85a5rzDbBo fcI0PSvjzZKUdf5g+YZSaoRvIrU70y2Jfj0VTwWz9mVbVCcqPKcl++j/JeJIFzh97o1m o58OYssUXUnY1YqJ9PP2DPImFQ+QJboHoNzafQYmF3MrAp5qfqCSV8UTPp9UblekFWND TXuScjKQ8CmilaQZx2cOwMdjMhURlRMHHCdcOnrTw7WlCJjlYueOxwO64rXJY4MY3y10 ns7A== X-Forwarded-Encrypted: i=1; AJvYcCVAh22V2VpjFycAQiaatsS+B+fenYBh5SjIqJ7BGZ+TRJgwDKfeQU/nIrWocq/neUrqYvmGyC4bf3mg@vger.kernel.org, AJvYcCVg3m/GDgMzUi2DONx+rXe9HdbvNKaA9sr56a1EIo7Q8XTz5eOeT29aXhfbAhzKZUxM3CQL1kglcJBWqQ==@vger.kernel.org, AJvYcCWHEt6LwLUQhgebfOTJWO491/ReORr6s0SoqmixgSqeLz600+IDlwEqmv4L4zxXO8Kqkt62aJTOUy0T2OqH@vger.kernel.org X-Gm-Message-State: AOJu0Yw4P183JQY+pxz8aMvea82h+yjgeBjL/nBSUoyxeZ5BeuGpBvwS AJ8rxd1iCN1SNssgLVqnb1ygIwIXq/K1MSnXiBCYt04xk/iIUJhvdE/5CWhy0UQfgg0= X-Gm-Gg: ASbGncuj7dfLz1Nvba7i0qbGzWjxMvP7Hpcg2T76bsTdAO9iNUxoYAHksltqKogSAN0 xbZn2RZiQOOYjHx8YjUdIfiNcJ2C7IR2ycmZW+3jbfFYoMxwaSpxG56e3GXzg4g787Fz56IsDKi ceICE2Nh4uduFb/tyLN/eZu3/LmnM3Aqk93RM5IUNJURzZByotPdaXcN1CBMz7YzhVfeabUmZED cmVhouhhHottgFOc6r79/WZ4UEJOS7dMkw19jG751MjnpUA9k6mjxopFcJJWA2uYMRZ/cT3YD2d +a5SdLGIwoZg2S38EgvhdNQCdMuThIBBx7xB866p638= X-Google-Smtp-Source: AGHT+IGfAFzujLmWILt8UVxmRYxZiuG97IHsQSc+DfTggeEZMyI9sqg7u8YqmP6IrvzcHwDGVbxv/w== X-Received: by 2002:a05:6a00:124f:b0:746:3200:5f8 with SMTP id d2e1a72fcca58-74ce8af2e9cmr13029730b3a.22.1751838076031; Sun, 06 Jul 2025 14:41:16 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:dab8::1f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74cfad75020sm4126416b3a.109.2025.07.06.14.41.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 14:41:15 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Johannes Berg , yangshiji66@qq.com, ansuelsmth@gmail.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Matthias Brugger , AngeloGioacchino Del Regno , Stanislaw Gruszka , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH 2/6] wifi: rt2x00: remove mod_name from platform_driver Date: Sun, 6 Jul 2025 14:41:07 -0700 Message-ID: <20250706214111.45687-3-rosenp@gmail.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250706214111.45687-1-rosenp@gmail.com> References: <20250706214111.45687-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mod_name is a legacy debugging feature with no real modern use. An analysis of the underlying MIPS setup code reveals it to also be unused. Signed-off-by: Rosen Penev Reviewed-by: Sergio Paracuellos --- drivers/net/wireless/ralink/rt2x00/rt2800soc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800soc.c b/drivers/net/w= ireless/ralink/rt2x00/rt2800soc.c index 701ba54bf3e5..e73394cf6ea6 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800soc.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800soc.c @@ -246,7 +246,6 @@ static int rt2800soc_probe(struct platform_device *pdev) static struct platform_driver rt2800soc_driver =3D { .driver =3D { .name =3D "rt2800_wmac", - .mod_name =3D KBUILD_MODNAME, }, .probe =3D rt2800soc_probe, .remove =3D rt2x00soc_remove, --=20 2.50.0 From nobody Tue Oct 7 19:53:38 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 29B7C2BCF6C; Sun, 6 Jul 2025 21:41:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838079; cv=none; b=uygtKwsVXW8oT2IecdiMazxArLd9Y5FiOd62xswMmzuG9m1bVoiqUecd3SE0L5uqZ0V56bz43Fo9pmbjl8UE62QgcPIh1JxZ5i25qZSNNBhIngZTU4z7AYm8SG6CKMF9n4+BLFNUBiSlhnjmxSnS8P7qRP3XXSlzdPDqhXmPh04= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838079; c=relaxed/simple; bh=ISJUnyKEjL2GUKAhw9PQ/SluS9XWJMt6wPNGEkcIaB8=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ADRe4xmc4bRKEtxT9K8qWg0l16AoD6kS7VyDV9iErQI59altCa8ihphsWXqJ4RHT6mwhpq7RcnARG01KVi9WFE2/DiLRjX8AZky0qx9gWAQDbAnjODuLe7x/JB1EnwH/fng8MZ2TbI9Uo3WqQwNGYQl2TZFtO43dIBv88nJcsrw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZXRe1Nt0; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZXRe1Nt0" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-7490702fc7cso1424629b3a.1; Sun, 06 Jul 2025 14:41:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751838077; x=1752442877; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=swOgqNchoKoKbvtt/1M0CeLEVRw2Niempvg5FVKkFhI=; b=ZXRe1Nt0WNqOaVmqLpF0cwQR5JiRYGhWtp3gz7pJqmnJo9KQ4kaa0PJKwH8Dkxgy4+ Gf1/aLCtQuHUPvenYUEZoRyiIygojEeKljyGmq8xeVAuNKl0FGnWgJXelH8IMP5wMb2N ddXXzZpVixNdMFlD7ePuaD7HlqNm/8cOsd0eLy1sPXuCUEBZruDNtyiOGFQkWwOwm2mG h0X1StkF8jvTLcW2avyejMMQsdBUssuQu65JeL6LjSk47IY/VIEEMgtVfh9tlJM9x2a7 2JgUZpFYIiXxSpIx6EhVuV38WFsjLoqvTWoG1QMCjoFUxvX15/fnhw2gKkmKIxqPGEV/ Fb8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751838077; x=1752442877; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=swOgqNchoKoKbvtt/1M0CeLEVRw2Niempvg5FVKkFhI=; b=vncDN5lUPVf+lzn+2VB/ylbW0u7h83W5xb8+VpHV3rXO3QPw+egHJQojhrw6SsC8nn PPWEjA+cv6hzHZLT74qbYWQ9PaGLLBksFTyGmpOfgHvlTM1Ov1lkGiQLca2nrs4TTsf9 fRKCiZmYeEoclR2IueyfoVVwu14NvKbw2bC9h8oIXY1vBx513PEDrQs9rHcxwc8v4ETC 8LLAgp1/Ohd0Ncz10oCEJdIVp4UYlcTx7323Dg3tIkm6tHkxyrOztCbofS+T21i8F0Yz jWqVfqQf2CBiBM7dPYHSIupM6fbx86xvp5wxCne+iKBHxk7IS3pWXygXm/kE0PIOF5n4 WzIw== X-Forwarded-Encrypted: i=1; AJvYcCWx/MaWwM/C7aorNAOPIlGP54F2OyYnIFoq1y1d8Izj8eHXTEvwG638xw80F69rDFXlQSDZGl34sxcr+zm8@vger.kernel.org, AJvYcCXVbS7bha2kHwNuiVyNBqdY79AcaDDqea48JWMBqKLCZEq6hTGZnLVx1D9OD2tKcJkWctlofIuD2GFk@vger.kernel.org, AJvYcCXx1AG4hghZtLyGgZb67g6MUk/GbqPd7p52X+tSkkxqbi2zKT68SQKvEoVivF0c+RO8kJpSPIuM/hHM9Q==@vger.kernel.org X-Gm-Message-State: AOJu0YzzqcEfh8SMRrTvhLQtxKXSXUyIWT7l7RKRCOuEDZ+vPI4CCR+K V0uV3EEp2lkcFfo3RBCA5/2Y/Pgfzd1KkmbCXsVW5iBB7kh3euj78QQ1qoOuOVNrIFE= X-Gm-Gg: ASbGncv//7u+JdIck7bnfPOf1e9jyfw+VASPNfyTYHXlX5LUd0FaTeUsw7aSsjVsnya 0aCeDUsPn4D1RPy9mOzUpNT1Xi4WKe6BaRakP6bULieWc6myFYWiBHlKFlJOHTwcjXv5gwsyT0k Ncaz/2+dVMaE0u+QMYsFy7YBS1JTzpakjnQxYDW6WFvU0WPCDlNHcoVTZk0iFw3F5C+KRBxfmdd PrZsGZ8qWONMQQP+b+nVsVYAoMBHBeb9Y0jv0Hhuiv3EHWSI2P5ZP5FFAgm5FMcatlZzPNxohzG wuLJKcz0S7zxrcefM1ZuzlMBLJZ4gQV+OqZKf5C/ktE= X-Google-Smtp-Source: AGHT+IHSFD8W/9aMoucidCPvq+qMXi+IdM35I/qq7pBEKJHsLmkxu5ounpaoHPbBTKQ79HMYjGlkSw== X-Received: by 2002:a05:6a00:3a1b:b0:748:e38d:fecc with SMTP id d2e1a72fcca58-74cf700d34bmr8770853b3a.22.1751838077394; Sun, 06 Jul 2025 14:41:17 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:dab8::1f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74cfad75020sm4126416b3a.109.2025.07.06.14.41.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 14:41:17 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Johannes Berg , yangshiji66@qq.com, ansuelsmth@gmail.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Matthias Brugger , AngeloGioacchino Del Regno , Stanislaw Gruszka , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH 3/6] wifi: rt2800soc: allow loading from OF Date: Sun, 6 Jul 2025 14:41:08 -0700 Message-ID: <20250706214111.45687-4-rosenp@gmail.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250706214111.45687-1-rosenp@gmail.com> References: <20250706214111.45687-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add a single bindng to help the already present dts files load the driver. More are possible but there doesn't seem to be a significant difference between them to justify this. Use wifi name per dtschema requirements. The data field will be used to remove the custom non static probe function and use of_device_get_match_data. Signed-off-by: Rosen Penev Reviewed-by: Sergio Paracuellos --- drivers/net/wireless/ralink/rt2x00/rt2800soc.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800soc.c b/drivers/net/w= ireless/ralink/rt2x00/rt2800soc.c index e73394cf6ea6..db8d01f0cdc3 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800soc.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800soc.c @@ -243,9 +243,16 @@ static int rt2800soc_probe(struct platform_device *pde= v) return rt2x00soc_probe(pdev, &rt2800soc_ops); } =20 +static const struct of_device_id rt2880_wmac_match[] =3D { + { .compatible =3D "ralink,rt2880-wifi", .data =3D &rt2800soc_ops }, + {}, +}; +MODULE_DEVICE_TABLE(of, rt2880_wmac_match); + static struct platform_driver rt2800soc_driver =3D { .driver =3D { .name =3D "rt2800_wmac", + .of_match_table =3D rt2880_wmac_match, }, .probe =3D rt2800soc_probe, .remove =3D rt2x00soc_remove, --=20 2.50.0 From nobody Tue Oct 7 19:53:38 2025 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 85B822BE035; Sun, 6 Jul 2025 21:41:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838083; cv=none; b=RFKjdjXUDBDzu+ubi7+4+haL1B1C7hWKliZwZFceVMn8fl4ONPCxNj/kYv8prA/k/2IqylrnFfLv5Pgn0nCjw5krJ6DQltZi4NlWkqLpzytRyW9r5JJWFRi0SwBEuCPyPUUAiHyjjVpyxiUPywzXgTfAhlv5f4eNIJCCbUKfjno= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838083; c=relaxed/simple; bh=cKFUB3fcfogVv4nS3uoMT9JStbO37J3Ecty0niFdrcc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MtegnQD3Lo+N63iqwHNdOUQOcFnx/FI/WrPOBSrSdgvlrL9l+UjgAbnsAQB/RrYlGUuNkS+mPN+SYhGIm9a9PLJPwom3o+KLKeBximbnJTPXehzeiAX7gBHtUQjrJ78oQND948y5EDt9dgzP+7xIQvCV/sJqesIZfCnqiRaKGtE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=BVqUjF2s; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="BVqUjF2s" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-747fba9f962so1852296b3a.0; Sun, 06 Jul 2025 14:41:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751838079; x=1752442879; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=AWkIKGkA990tICWBb/AzCkdqkS98YDkqouTWupGfwu8=; b=BVqUjF2ssjt0EcmdT5HCLtVKqhInOkVFBz/RjoqsC+4upOa9VVnBjAGI4Cc9TS7C4t ZR2aHWr/ENsyuLdDO4iH9dLDC7QpWJPIKM5AyD3DIeMhYBCI390v8o61EsUcVsyTF5g7 wmfaF6ADVsSkEWSmvyDVn7Qoqu3Q/nY19RppHDv0p/69ayECFfTqM3+6KKMdGb/BBeWL t3wOvSc3AMydRb1/TTq8QMeX0EZ4v3MrKVvo7mZPs7Q0tcDIoQWMfa/GUxWFDENntX5L fzb5LpVU/iwQCnEupX5tbccjBd31nRe8Gxis0q2tOdLUok05xs2ZD1ONIqvw/XO36iYG v9NQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751838079; x=1752442879; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=AWkIKGkA990tICWBb/AzCkdqkS98YDkqouTWupGfwu8=; b=nkAcRtLlPjKjlzY5cpWWQammEHo2uMU5+HrquhLmW5MKIF15h0QOmTS3JovBvPIVq+ v9CMoHBOziKFNJUbMsqjnVCVHp9XWTO22yUnPDV3enahcxgsGDjzIQ5CZ+21CZiOvlpA D1AA/b0gpwRKGok7FijMuBtRBgPNHtJBS2FcuqTuk5dWh5e8+gNnRYZMx4DKOIFGoSTo yVcr32r5DLHC8rmSA0CAxzo4iUtJGs0JVBnPBmbTrT9bTpLZp++zXcZc+SHxVVDdqEYs os0w2/9N5vY0gbxW/PxwZ2MDiRAGjxFI9Un19pfp6+S/DaSzoQ3STAnfuo+wY7acJvUm gmag== X-Forwarded-Encrypted: i=1; AJvYcCUrU5339vloDppg1jitUUXabEmFO0Nl9lJKKSM6ICWmfm2cQohmAsftHUcOVzDaBXDgZOIlW/Ao7K7H3g==@vger.kernel.org, AJvYcCV1/wFnaujTzjsCWujAOfFUg01cU1bqwNsa95SnQM0NcTDzSwn7W2gh/d0EU4l2EPPPlS7V4nZw/OYe@vger.kernel.org, AJvYcCWDQ3wHedrmZvcMYkG8W2C+Z3hiunqpTmWRYgob4nInaDyyNacyoDWWnHiRSMb5ZeD7WquigWAHGDg4XbUQ@vger.kernel.org X-Gm-Message-State: AOJu0Yy3nqWXjsOYvtNpJHx9nTM4yJDl47KLm+U5OCKvPWT+AYS1jfjD cMmMvRAzaw+WMjESsnwcd6HjYIdVFn15T4dZ6IexIXLSsZs6kNFQvmyX9utMqV4cIYA= X-Gm-Gg: ASbGncvws5s24urobyr1nwkgKF0BYEfEUH2iS1lHWQVqqce24Gghn1T5NbsNY8ocABD R3vjPLbx/YaFOoaKOaxinaObsE7RXvgL8PGnH6ACkVKPB1N2qwxKyO6NGQwZ9JXE5rbfrlHO+MK bkiiXDNeKhOtt6XkIQw+8lsDV/5al0HR/3NFG4XTncQVuhGJaMD0qjwhVm9u8epLP8T3keyBPj3 Fd6A6im3uJcnUq7oPqGQfl0b0YqW1PE65blq2nhXstkcshsUHSBpdWfKwCwSs6WePwTnzdD6NU7 GxVRmfCQCqn6QVXw1vafaa6u9yuR/gbKnbNmg6krm7RDQDcQDfriQw== X-Google-Smtp-Source: AGHT+IHHOmTsiBLo3z6UMMswYtFY9ObAPDGTYpD1AOLGuigpAPh9rfOATyQ8i/rlbaFuXtxZ+xyf4w== X-Received: by 2002:a05:6a00:240d:b0:742:ae7e:7da1 with SMTP id d2e1a72fcca58-74ce5de7884mr14558457b3a.0.1751838078711; Sun, 06 Jul 2025 14:41:18 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:dab8::1f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74cfad75020sm4126416b3a.109.2025.07.06.14.41.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 14:41:18 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Johannes Berg , yangshiji66@qq.com, ansuelsmth@gmail.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Matthias Brugger , AngeloGioacchino Del Regno , Stanislaw Gruszka , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH 4/6] wifi: rt2x00: soc: move and modernize probe Date: Sun, 6 Jul 2025 14:41:09 -0700 Message-ID: <20250706214111.45687-5-rosenp@gmail.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250706214111.45687-1-rosenp@gmail.com> References: <20250706214111.45687-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" By moving functions from rt2x00soc to rt2800soc, the driver benefits with potentially smaller compiled size. It also becomes much easier to remove a bunch of manual memory management and use devm. Signed-off-by: Rosen Penev Reviewed-by: Sergio Paracuellos --- .../net/wireless/ralink/rt2x00/rt2800soc.c | 67 +++++++++++- .../net/wireless/ralink/rt2x00/rt2x00soc.c | 102 ------------------ 2 files changed, 65 insertions(+), 104 deletions(-) diff --git a/drivers/net/wireless/ralink/rt2x00/rt2800soc.c b/drivers/net/w= ireless/ralink/rt2x00/rt2800soc.c index db8d01f0cdc3..e2c05ead9b25 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2800soc.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2800soc.c @@ -18,6 +18,7 @@ #include #include #include +#include #include =20 #include "rt2x00.h" @@ -240,7 +241,69 @@ static const struct rt2x00_ops rt2800soc_ops =3D { =20 static int rt2800soc_probe(struct platform_device *pdev) { - return rt2x00soc_probe(pdev, &rt2800soc_ops); + const struct rt2x00_ops *ops =3D of_device_get_match_data(&pdev->dev); + struct rt2x00_dev *rt2x00dev; + struct ieee80211_hw *hw; + int retval; + + hw =3D ieee80211_alloc_hw(sizeof(struct rt2x00_dev), ops->hw); + if (!hw) { + rt2x00_probe_err("Failed to allocate hardware\n"); + return -ENOMEM; + } + + platform_set_drvdata(pdev, hw); + + rt2x00dev =3D hw->priv; + rt2x00dev->dev =3D &pdev->dev; + rt2x00dev->ops =3D ops; + rt2x00dev->hw =3D hw; + rt2x00dev->irq =3D platform_get_irq(pdev, 0); + rt2x00dev->name =3D pdev->dev.driver->name; + rt2x00dev->clk =3D devm_clk_get_optional(&pdev->dev, NULL); + + rt2x00_set_chip_intf(rt2x00dev, RT2X00_CHIP_INTF_SOC); + + rt2x00dev->csr.base =3D devm_platform_ioremap_resource(pdev, 0); + if (IS_ERR(rt2x00dev->csr.base)) { + retval =3D PTR_ERR(rt2x00dev->csr.base); + goto exit_free_device; + } + + rt2x00dev->eeprom =3D devm_kzalloc(&pdev->dev, rt2x00dev->ops->eeprom_siz= e, GFP_KERNEL); + if (!rt2x00dev->eeprom) { + retval =3D -ENOMEM; + goto exit_free_device; + } + + rt2x00dev->rf =3D devm_kzalloc(&pdev->dev, rt2x00dev->ops->rf_size, GFP_K= ERNEL); + if (!rt2x00dev->rf) { + retval =3D -ENOMEM; + goto exit_free_device; + } + + retval =3D rt2x00lib_probe_dev(rt2x00dev); + if (retval) + goto exit_free_device; + + return 0; + +exit_free_device: + ieee80211_free_hw(hw); + + return retval; +} + +static void rt2800soc_remove(struct platform_device *pdev) +{ + struct ieee80211_hw *hw =3D platform_get_drvdata(pdev); + struct rt2x00_dev *rt2x00dev =3D hw->priv; + + /* + * Free all allocated data. + */ + rt2x00lib_remove_dev(rt2x00dev); + ieee80211_free_hw(hw); } =20 static const struct of_device_id rt2880_wmac_match[] =3D { @@ -255,7 +318,7 @@ static struct platform_driver rt2800soc_driver =3D { .of_match_table =3D rt2880_wmac_match, }, .probe =3D rt2800soc_probe, - .remove =3D rt2x00soc_remove, + .remove =3D rt2800soc_remove, .suspend =3D rt2x00soc_suspend, .resume =3D rt2x00soc_resume, }; diff --git a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c b/drivers/net/w= ireless/ralink/rt2x00/rt2x00soc.c index f7f3a2340c39..9fd763f2fcde 100644 --- a/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c +++ b/drivers/net/wireless/ralink/rt2x00/rt2x00soc.c @@ -20,108 +20,6 @@ #include "rt2x00.h" #include "rt2x00soc.h" =20 -static void rt2x00soc_free_reg(struct rt2x00_dev *rt2x00dev) -{ - kfree(rt2x00dev->rf); - rt2x00dev->rf =3D NULL; - - kfree(rt2x00dev->eeprom); - rt2x00dev->eeprom =3D NULL; - - iounmap(rt2x00dev->csr.base); -} - -static int rt2x00soc_alloc_reg(struct rt2x00_dev *rt2x00dev) -{ - struct platform_device *pdev =3D to_platform_device(rt2x00dev->dev); - struct resource *res; - - res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -ENODEV; - - rt2x00dev->csr.base =3D ioremap(res->start, resource_size(res)); - if (!rt2x00dev->csr.base) - return -ENOMEM; - - rt2x00dev->eeprom =3D kzalloc(rt2x00dev->ops->eeprom_size, GFP_KERNEL); - if (!rt2x00dev->eeprom) - goto exit; - - rt2x00dev->rf =3D kzalloc(rt2x00dev->ops->rf_size, GFP_KERNEL); - if (!rt2x00dev->rf) - goto exit; - - return 0; - -exit: - rt2x00_probe_err("Failed to allocate registers\n"); - rt2x00soc_free_reg(rt2x00dev); - - return -ENOMEM; -} - -int rt2x00soc_probe(struct platform_device *pdev, const struct rt2x00_ops = *ops) -{ - struct ieee80211_hw *hw; - struct rt2x00_dev *rt2x00dev; - int retval; - - hw =3D ieee80211_alloc_hw(sizeof(struct rt2x00_dev), ops->hw); - if (!hw) { - rt2x00_probe_err("Failed to allocate hardware\n"); - return -ENOMEM; - } - - platform_set_drvdata(pdev, hw); - - rt2x00dev =3D hw->priv; - rt2x00dev->dev =3D &pdev->dev; - rt2x00dev->ops =3D ops; - rt2x00dev->hw =3D hw; - rt2x00dev->irq =3D platform_get_irq(pdev, 0); - rt2x00dev->name =3D pdev->dev.driver->name; - - rt2x00dev->clk =3D clk_get(&pdev->dev, NULL); - if (IS_ERR(rt2x00dev->clk)) - rt2x00dev->clk =3D NULL; - - rt2x00_set_chip_intf(rt2x00dev, RT2X00_CHIP_INTF_SOC); - - retval =3D rt2x00soc_alloc_reg(rt2x00dev); - if (retval) - goto exit_free_device; - - retval =3D rt2x00lib_probe_dev(rt2x00dev); - if (retval) - goto exit_free_reg; - - return 0; - -exit_free_reg: - rt2x00soc_free_reg(rt2x00dev); - -exit_free_device: - ieee80211_free_hw(hw); - - return retval; -} -EXPORT_SYMBOL_GPL(rt2x00soc_probe); - -void rt2x00soc_remove(struct platform_device *pdev) -{ - struct ieee80211_hw *hw =3D platform_get_drvdata(pdev); - struct rt2x00_dev *rt2x00dev =3D hw->priv; - - /* - * Free all allocated data. - */ - rt2x00lib_remove_dev(rt2x00dev); - rt2x00soc_free_reg(rt2x00dev); - ieee80211_free_hw(hw); -} -EXPORT_SYMBOL_GPL(rt2x00soc_remove); - #ifdef CONFIG_PM int rt2x00soc_suspend(struct platform_device *pdev, pm_message_t state) { --=20 2.50.0 From nobody Tue Oct 7 19:53:38 2025 Received: from mail-pf1-f178.google.com (mail-pf1-f178.google.com [209.85.210.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C0FA22BE03C; Sun, 6 Jul 2025 21:41:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838082; cv=none; b=ecD5jgXA1ezvH/0CndML06A5XUglh2O5ccGUxo8Hvg7PSyrhYTo1pbJ1XaJroCU7LJHVroWZ/RjO0nzdTQgMdKemT79OF1L11tQVeVpabIQbXY09cUlCCJRVzV56/eH2UEwK/5BYxZsdbmvcAI74JpnPHeaq0sl+EaZ/WWkyzZQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838082; c=relaxed/simple; bh=yBJJa2SxaH/20HN8IUkuBJ0osc9IVDpyvHaHFs4BpWc=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YZWop9lNVFH6C58jYUvZdx0488IkSJd14IgfHi/c34TSc4rNTlFHruRLhqOROeB7TZLtqqoKoK0DUT22ZdibZV4xPSjQpsJwUoA0e7uQo0y2oRKx0Q6S0gPa7MiCPCVzScwH1aSYKPmQVKPMEmGll7rDeJM18oPpUzVqWVY7m0s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TQbjm2MN; arc=none smtp.client-ip=209.85.210.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TQbjm2MN" Received: by mail-pf1-f178.google.com with SMTP id d2e1a72fcca58-748feca4a61so1327861b3a.3; Sun, 06 Jul 2025 14:41:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751838080; x=1752442880; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=bjpHESv7Px3oV3ysOGVoWTf3bwmuOKueJ9TXRndyrNg=; b=TQbjm2MNux9uTV75q1+k7yqw2PtBp6IpCiwBsgmwQdgnDcGbpj0KwA7V4CoKhQDY7I PM5qlyrAi1qsl841yEFVdak7ESNSw7QiQH63eyS5k8rfw6mAwYIVFAhgd0Fpw42T1CJk aShCrn29BhpJcD6rtM7RkvkxcIRuRNbR6UIaybFuxGMmKd46Df+6Dk7X/PxWVDtuEzHK aSIkjws0Cp0u5Gp2EqCLRzTJPmyvc2hOBFy3ApohgrgQ0jnXAACBtnlM7tWuVyEw7q3K PeSaaQQTOZZYJ3hRf9xPHOSaTvBvhr/1cT29MGe6UdOsGUrMLwnVpnapnwnR4vCNbdPn ZcCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751838080; x=1752442880; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=bjpHESv7Px3oV3ysOGVoWTf3bwmuOKueJ9TXRndyrNg=; b=Yj2aYLTAb6LZkhoxS5/wI4zQTNe3y4urIK/o9XFD5NppQyBn9xFjoVuTs340sg3/MF oyr4FGti+T8WmN0kblHJICIicnZuMqh5OR6hqDNWvTun13QInnSI2L/KWn7zVg9mHEDD iN990LPGLESrWqiPTnDm9VGJUqfC3HqbUcCkIFAy3gseujwR5aBrj9BlaBXlq5x6W8mB 8GeA5vIUzCTFuFeWErlP5nU/m7eYc8zgVuvkM4UmegWxUheokWS0vW10zq4vkQ7vFxAD 5DZEzTX836cpxLoNUqJXpJIlzPuKqN49Zi75GtV1u2JPMvLtJBDF12f3bHFFxMjkU24Z sg7A== X-Forwarded-Encrypted: i=1; AJvYcCVFpGmjFNIEg6KvCDOOYqdV0AfF9sCjksFIAQyxPY8fBGrECjc67MyJ/qogccWS6RDRSz9TbpLI3iWn@vger.kernel.org, AJvYcCWKVys50rTcIZScm7F6rVYEeZb4mfrT9SRPCfJ65mjuCDssvtBoEBeJO1Cu9QrMaBV+Kx1GCSxa4oUIKA==@vger.kernel.org, AJvYcCWj+oh6WeEGyrcy1N7WiEuEKp3czzAD/VGsp/A5cZEZYlalYOAMFIADq71pkKMQFcgcweKqmgMMtYw3C6WW@vger.kernel.org X-Gm-Message-State: AOJu0Yz7mWsFqmPSvUktzo2xasp71Ko9mF89xN/inOC61/EhZk/r8Grd G+goOV/VWt1pA77aLQ85FEw+bw235AhJ8UwZZF9og4txfPwv2aof4TeEWSpnysXBgdA= X-Gm-Gg: ASbGncsK8jZIJnITPFiSLvi/QC+qzHfemYvYQmQxUclIBeZ70uHPmmnNR3vy/634NQv Ar92GJTdGupa2J+EkjBU2wBGCJB4tbbWJbVhrR0HWJusczEKMbbehWfqKJOPX3cgRRkQ6iweaSv opqcrtBxNMJzmX7w3y8c3XHC1ZKkW4afbHtbJAd0zWFm6Rt5jVAeVgTiMzht+mOVnk+MRpVUuKc ybviTSVTWSaI081XblFlYtOpMdtdJT7wolXKXRA8za0VYMyRNvo0IPL/a6xVmeiFvJ57JsOw9+v wgZXONsEpw9lvqYYm993Ql+BHOs4eTiktYU6H6ZHpWPCHuFY3uOVEQ== X-Google-Smtp-Source: AGHT+IHwiZU5cyKcS3pY2lliuwvqMo5NFkP/fRh4U3ufXzqxUy0ex0mXgD2pjjdqIUXlLCc7QhSCgA== X-Received: by 2002:a05:6a00:194a:b0:742:3cc1:9485 with SMTP id d2e1a72fcca58-74ce8a8ddb0mr12232948b3a.12.1751838080087; Sun, 06 Jul 2025 14:41:20 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:dab8::1f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74cfad75020sm4126416b3a.109.2025.07.06.14.41.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 14:41:19 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Johannes Berg , yangshiji66@qq.com, ansuelsmth@gmail.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Matthias Brugger , AngeloGioacchino Del Regno , Stanislaw Gruszka , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH 5/6] dt-bindings: net: wireless: rt2800: add Date: Sun, 6 Jul 2025 14:41:10 -0700 Message-ID: <20250706214111.45687-6-rosenp@gmail.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250706214111.45687-1-rosenp@gmail.com> References: <20250706214111.45687-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add device-tree bindings for the RT2800 SOC wifi device found in older Ralink/Mediatek devices. Signed-off-by: Rosen Penev --- .../bindings/net/wireless/ralink,rt2800.yaml | 49 +++++++++++++++++++ 1 file changed, 49 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/wireless/ralink,r= t2800.yaml diff --git a/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.y= aml b/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml new file mode 100644 index 000000000000..fef14ca20983 --- /dev/null +++ b/Documentation/devicetree/bindings/net/wireless/ralink,rt2800.yaml @@ -0,0 +1,49 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/net/wireless/ralink,rt2800.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Ralink RT2800 wireless devices + +maintainers: + - Stanislaw Gruszka + +description: | + This node provides properties for configuring RT2800 SOC wifi device. + The node is expected to be specified as a root node of the device. + +allOf: + - $ref: ieee80211.yaml# + +properties: + compatible: + enum: + - ralink,rt2800-wifi + + reg: + maxItems: 1 + + clocks: + maxItems: 1 + + interrupt-parent: + maxItems: 1 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + wifi@110180000 { + compatible =3D "ralink,rt2880-wifi"; + reg =3D <0x10180000 0x40000>; + clocks =3D <&sysc 16>; + interrupt-parent =3D <&cpuintc>; + interrupts =3D <6>; + }; --=20 2.50.0 From nobody Tue Oct 7 19:53:38 2025 Received: from mail-pf1-f175.google.com (mail-pf1-f175.google.com [209.85.210.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B9F31E8335; Sun, 6 Jul 2025 21:41:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838083; cv=none; b=Sso4q7M1kdWHsq7S3u3Gg43Z0yNajexu9aabusXdQhpwtCvICw1Vc/VVOTV+FlVNbEwP24vIfCtPmyPLfCGsKLlIwNi5Ahs6XowPyRBf9D4bxQW+OAlcMIxpQGAh7DX1wjjLkKJbJOkh4ATBu+Nq9Pt4ct2z3Yekmm0js+zb4ck= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1751838083; c=relaxed/simple; bh=oso3s84HHIL4dE7V1UAH+9yd50ezAj1vpkwyK51jz3M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=bQXu9/stezz9MNqQDLdCZwNpRzFsgcVDwW2I3r4xAUs0IPgp7Xo6QKSYOJs9bdQxONJs42ywlKunzKl3C02P1KYKV8CteunMprqp4uXHey5ArOoZeMkH+vzPldncBrF/4fUcJUYk5Pmvhsy3xNdCBa1M869NJvYgIt/WWqnpmIk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=eNo9iAVx; arc=none smtp.client-ip=209.85.210.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="eNo9iAVx" Received: by mail-pf1-f175.google.com with SMTP id d2e1a72fcca58-74b54cead6cso1488432b3a.1; Sun, 06 Jul 2025 14:41:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1751838081; x=1752442881; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=RvZgwDhd8R+31/oVgTrgK7V+PUBtSsqxq+ciLntuUVw=; b=eNo9iAVx3h26F51EjW9ES7u7jGyMg0T3E+20kHdefK8iN+/ZswlboQ4IWssKcxEZrb QyfuDGViAyLP2UV2EEO2aj31/tx+TkB1m0A/uMz7MFViYKfQx7n39UpcvYWOntbIqZ6G mdID9Ypc2phcVW+rriSB7VcJPLkCvaqbDrU/LpS50SvdaMolhPe1M65BnLz52XCERqh7 PO9byeMEctY5qXRc7riTC4FsUlqVrieqm4egmME8Lhbg/dv7E+FeQ+FGkEbN6ll2ee0u nlIQLpidHg5i1Pgh2VUI6R7kPbTmc69G1uVqnR7hmGbs29ZZahKO4RItWbw5VVEpB3t/ KrqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1751838081; x=1752442881; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RvZgwDhd8R+31/oVgTrgK7V+PUBtSsqxq+ciLntuUVw=; b=HltTuGNYzLSXoIR0z9BtybciNjmzeAkDWO8fqIDXRTVLqUAtSXMOfhdX8AztEfbjZ8 aEvw4NIUOR2cq8bClCVwwIaArfbjjpyTGzR0A31BssIKwh2E8b3JFViXHI2+pBYAWYFo iEdaItaXyubHOFP4IlleVvgZ4ugiYFUyEblzEn01oMefOP95uTOybIiGfvxvjh4KwwAo 9T+62sfvfUxnxIdj6/8VMeGkASSZWnfJDBbIfN0M5Y7OeKPRzW8l6A7M8E9xAVLJtRv3 fRGJIGRPmaImehIN7Dl0mm6+6ARAPjTth0THPmx1Aw6VX9TFprAORkTtKRyX0ve9rBYK 2ckw== X-Forwarded-Encrypted: i=1; AJvYcCUWmFK6BB1oggFUXs70tQ2FGjEHcv/8wE25o7amL86FymminxZ5fDnojWhsfeRNAJbB97SRdW5ppxrZIR+5@vger.kernel.org, AJvYcCVaQjNRMvEYNTiiiZDP+jg01y4ElaFlEygh2YpySXhVTeo2XchWsNVMUDbIxwhSFvMgmzUamZ0uQamlEQ==@vger.kernel.org, AJvYcCWqxcdZEoaUR/G4p90Mm/7P3WpjxsRgfNrsGCms5GN125YlqaZmNftKbzzC7PunnMs9sS7nPpFyj/K8@vger.kernel.org X-Gm-Message-State: AOJu0YyNPFEx1NVCzxHnOFCRiIxVBSomll79+A2Y28tqNuTv2cPqJFvp Bs8FgqLPVsjlOZD2QURTYTx77GbZm82dqXKjkEpYxNT/JPAeWrHI5bEd8VVmGv3dOFc= X-Gm-Gg: ASbGnctwO1h7pnREFWg+xMe77pNpX2TkCPR/u813bJtEThug9BtznbWuJyYejdjt6AL 08Pm2tnK6oVIAWRrp+b5kzxtwZFRvO/tTx2CEAsOuULoQxHSSCrZB4UXUSk5Eg32tWJJ6eOT5IQ nH+7/5hw0/WrFYzm4BKU6kaXy11HQod6NeNmFXlE4WVXtgtSPPo8IZGVmZnEb1+SPVU2BjnK1sh q9WkFqfyYbf8ikpk8Ab88MB2I0VxXfdl45oLGcrd3HEQml+vkKKbtWyVUoMDMRn8ltkhN3Oxmwb bscdOMlOb6unNFjJXWtQoOqUXMOQ6RGu95LoxDWi1iQ= X-Google-Smtp-Source: AGHT+IEphJnWnMpJ5IZuXkzIdAl/4PySIfNR7SCiDO+NvDhnTpiFTe9sAWW/ka2hDv/gm3VHHolLYQ== X-Received: by 2002:a05:6a21:3282:b0:21e:7d1b:4401 with SMTP id adf61e73a8af0-225b9484b0bmr16419609637.22.1751838081538; Sun, 06 Jul 2025 14:41:21 -0700 (PDT) Received: from archlinux.lan ([2601:644:8200:dab8::1f6]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-74cfad75020sm4126416b3a.109.2025.07.06.14.41.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 06 Jul 2025 14:41:21 -0700 (PDT) From: Rosen Penev To: linux-wireless@vger.kernel.org Cc: Johannes Berg , yangshiji66@qq.com, ansuelsmth@gmail.com, Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Matthias Brugger , AngeloGioacchino Del Regno , Stanislaw Gruszka , devicetree@vger.kernel.org (open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS), linux-kernel@vger.kernel.org (open list), linux-mips@vger.kernel.org (open list:MIPS), linux-arm-kernel@lists.infradead.org (moderated list:ARM/Mediatek SoC support), linux-mediatek@lists.infradead.org (moderated list:ARM/Mediatek SoC support) Subject: [PATCH 6/6] MIPS: dts: ralink: mt7628a: add wifi binding Date: Sun, 6 Jul 2025 14:41:11 -0700 Message-ID: <20250706214111.45687-7-rosenp@gmail.com> X-Mailer: git-send-email 2.50.0 In-Reply-To: <20250706214111.45687-1-rosenp@gmail.com> References: <20250706214111.45687-1-rosenp@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" MT7620A devices all contain a wifi device as part of the SOC. Add it here to get it working. Signed-off-by: Rosen Penev --- arch/mips/boot/dts/ralink/mt7620a.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/arch/mips/boot/dts/ralink/mt7620a.dtsi b/arch/mips/boot/dts/ra= link/mt7620a.dtsi index d66045948a83..460164bdd430 100644 --- a/arch/mips/boot/dts/ralink/mt7620a.dtsi +++ b/arch/mips/boot/dts/ralink/mt7620a.dtsi @@ -62,4 +62,14 @@ uartlite@c00 { reg-shift =3D <2>; }; }; + + wmac: wifi@10180000 { + compatible =3D "ralink,rt2880-wifi"; + reg =3D <0x10180000 0x40000>; + + clocks =3D <&sysc 16>; + + interrupt-parent =3D <&cpuintc>; + interrupts =3D <6>; + }; }; --=20 2.50.0