From: Michael Riesch <michael.riesch@collabora.com>
The Rockchip RK3588 variant of the CSI-2 DPHY features two reset lines.
Add the variant and allow for the additional reset.
Signed-off-by: Michael Riesch <michael.riesch@collabora.com>
---
.../bindings/phy/rockchip-inno-csi-dphy.yaml | 50 +++++++++++++++++++++-
1 file changed, 49 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
index 9ad72518e6da..e37c9fd74788 100644
--- a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
+++ b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml
@@ -21,6 +21,7 @@ properties:
- rockchip,rk3326-csi-dphy
- rockchip,rk3368-csi-dphy
- rockchip,rk3568-csi-dphy
+ - rockchip,rk3588-csi-dphy
reg:
maxItems: 1
@@ -40,11 +41,15 @@ properties:
resets:
items:
- - description: exclusive PHY reset line
+ - description: APB reset line
+ - description: PHY reset line
+ minItems: 1
reset-names:
items:
- const: apb
+ - const: phy
+ minItems: 1
rockchip,grf:
$ref: /schemas/types.yaml#/definitions/phandle
@@ -64,6 +69,30 @@ allOf:
then:
required:
- power-domains
+ - if:
+ properties:
+ compatible:
+ contains:
+ enum:
+ - rockchip,px30-csi-dphy
+ - rockchip,rk1808-csi-dphy
+ - rockchip,rk3326-csi-dphy
+ - rockchip,rk3368-csi-dphy
+ - rockchip,rk3568-csi-dphy
+ then:
+ properties:
+ resets:
+ maxItems: 1
+
+ reset-names:
+ maxItems: 1
+ else:
+ properties:
+ resets:
+ minItems: 2
+
+ reset-names:
+ minItems: 2
required:
- compatible
@@ -91,3 +120,22 @@ examples:
reset-names = "apb";
rockchip,grf = <&grf>;
};
+ - |
+ #include <dt-bindings/clock/rockchip,rk3588-cru.h>
+ #include <dt-bindings/reset/rockchip,rk3588-cru.h>
+
+ soc {
+ #address-cells = <2>;
+ #size-cells = <2>;
+
+ phy@fedc0000 {
+ compatible = "rockchip,rk3588-csi-dphy";
+ reg = <0x0 0xfedc0000 0x0 0x8000>;
+ clocks = <&cru PCLK_CSIPHY0>;
+ clock-names = "pclk";
+ #phy-cells = <0>;
+ resets = <&cru SRST_P_CSIPHY0>, <&cru SRST_CSIPHY0>;
+ reset-names = "apb", "phy";
+ rockchip,grf = <&csidphy0_grf>;
+ };
+ };
--
2.39.5On Mon, Sep 01, 2025 at 10:47:44PM +0200, Michael Riesch wrote: > The Rockchip RK3588 variant of the CSI-2 DPHY features two reset lines. > Add the variant and allow for the additional reset. > > Signed-off-by: Michael Riesch <michael.riesch@collabora.com> > --- > .../bindings/phy/rockchip-inno-csi-dphy.yaml | 50 +++++++++++++++++++++- > 1 file changed, 49 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml > index 9ad72518e6da..e37c9fd74788 100644 > --- a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml > +++ b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml > @@ -21,6 +21,7 @@ properties: > - rockchip,rk3326-csi-dphy > - rockchip,rk3368-csi-dphy > - rockchip,rk3568-csi-dphy > + - rockchip,rk3588-csi-dphy > > reg: > maxItems: 1 > @@ -40,11 +41,15 @@ properties: > > resets: > items: > - - description: exclusive PHY reset line > + - description: APB reset line > + - description: PHY reset line That's changing the order, before first was the phy.... > + minItems: 1 > > reset-names: > items: > - const: apb > + - const: phy Although here first was apb? Quite confusing. Anyway "phy" reset for "phy" is pretty non-informative, please give some useful name. > + minItems: 1 Best regards, Krzysztof
Hi Krzysztof, Thanks for your comments. On 9/2/25 09:55, Krzysztof Kozlowski wrote: > On Mon, Sep 01, 2025 at 10:47:44PM +0200, Michael Riesch wrote: >> The Rockchip RK3588 variant of the CSI-2 DPHY features two reset lines. >> Add the variant and allow for the additional reset. >> >> Signed-off-by: Michael Riesch <michael.riesch@collabora.com> >> --- >> .../bindings/phy/rockchip-inno-csi-dphy.yaml | 50 +++++++++++++++++++++- >> 1 file changed, 49 insertions(+), 1 deletion(-) >> >> diff --git a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml >> index 9ad72518e6da..e37c9fd74788 100644 >> --- a/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml >> +++ b/Documentation/devicetree/bindings/phy/rockchip-inno-csi-dphy.yaml >> @@ -21,6 +21,7 @@ properties: >> - rockchip,rk3326-csi-dphy >> - rockchip,rk3368-csi-dphy >> - rockchip,rk3568-csi-dphy >> + - rockchip,rk3588-csi-dphy >> >> reg: >> maxItems: 1 >> @@ -40,11 +41,15 @@ properties: >> >> resets: >> items: >> - - description: exclusive PHY reset line >> + - description: APB reset line >> + - description: PHY reset line > > That's changing the order, before first was the phy.... See reset-names below... > >> + minItems: 1 >> >> reset-names: >> items: >> - const: apb >> + - const: phy > > Although here first was apb? Quite confusing. Confusing indeed. IMHO the description "exclusive PHY reset line" is misleading. In the existing device trees there are hints that this is an APB related reset. These are only hints, of course, but they are the best info we have. I can add a remark that we are fixing the misleading description while at it. > > Anyway "phy" reset for "phy" is pretty non-informative, please give some > useful name. As far as the additional reset is concerned, I do not have any info at all what it is related to. Therefore, it is hard to give a useful name. Also, to be frank, I have no intention to haggle around with Rockchip support to find out a more meaningful name (I tried to do that in the past, only to find that the time spent on that is almost definitely wasted). Similar PHY blocks are using "phy" or "pipe" or simply "reset" as names, so I went for that. Any suggestions are warmly welcome. "aux"? "reset2"? ...? Best regards, Michael > >> + minItems: 1 > > Best regards, > Krzysztof >
© 2016 - 2025 Red Hat, Inc.