iio: amplifiers: ada4250: various cleanups

[PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups

Posted by David Lechner 4 months ago

While investigating some potential bugs, we noticed quite a few
opportunities for small improvements in the ada4250 driver.

---
Changes in v3:
- Split into multiple patches.
- Added even more cleanups.
- Link to v2: https://lore.kernel.org/r/20250418-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v2-1-1bf9b033aaf5@baylibre.com

Changes in v2:
- Totally new patch.
- Link to v1: https://lore.kernel.org/r/20250418-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v1-1-7e7bd6dad423@baylibre.com

---
David Lechner (5):
      iio: amplifiers: ada4250: used dev local variable
      iio: amplifiers: ada4250: don't fail on bad chip ID
      iio: amplifiers: ada4250: use devm_regulator_get_enable_read_voltage()
      iio: amplifiers: ada4250: move offset_uv in struct
      iio: amplifiers: ada4250: use dev_err_probe()

 drivers/iio/amplifiers/ada4250.c | 45 ++++++++++++----------------------------
 1 file changed, 13 insertions(+), 32 deletions(-)
---
base-commit: 4c6073fec2fee4827fa0dd8a4ab4e6f7bbc05ee6
change-id: 20250418-iio-amplifiers-ada4250-simplify-data-buffer-in-init-93ebb1344295

Best regards,
-- 
David Lechner <dlechner@baylibre.com>

Re: [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups

Posted by Andy Shevchenko 4 months ago

On Wed, Jun 11, 2025 at 04:33:00PM -0500, David Lechner wrote:
> While investigating some potential bugs, we noticed quite a few
> opportunities for small improvements in the ada4250 driver.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

for non-commented patches. Otherwise, feel free to add it there
if my suggestion / assumptions are wrong.

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v3 0/5] iio: amplifiers: ada4250: various cleanups

Posted by Jonathan Cameron 3 months, 4 weeks ago

On Thu, 12 Jun 2025 16:07:00 +0300
Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:

> On Wed, Jun 11, 2025 at 04:33:00PM -0500, David Lechner wrote:
> > While investigating some potential bugs, we noticed quite a few
> > opportunities for small improvements in the ada4250 driver.  
> 
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> for non-commented patches. Otherwise, feel free to add it there
> if my suggestion / assumptions are wrong.
> 

I think, with exception of request for pahole (which is a nice to have
to my eyes rather than a requirement) I think all addressed by David
so applied and tag picked up.

For the pahole thing only thing I can imagine it doing is showing
a less obvious additional move is useful as this one was about as
obvious as they come if IIO_DMA_MINALIGN isn't huge (in which case
it makes no difference as we have a big hole!)

Jonathan