From nobody Sat Oct 11 00:44:27 2025 Received: from mail-oi1-f170.google.com (mail-oi1-f170.google.com [209.85.167.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CC5C239E7A for ; Wed, 11 Jun 2025 21:33:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677630; cv=none; b=HNNZhDcTXxHDOMiEfTIFqgo8XhLOGWk2t3myUf/Z4eNeLhQ7CG+XR74gDAnxQdOGqdymgbvI6BHF9CjSVAblo/v3gFrEyNESxCkxmg4dTIZYniKBY3f5t5VR6fovdpibdPSZINMTEXKcH5wH14ojM5nGDZAmhEtH435eRnKfwzI= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677630; c=relaxed/simple; bh=FLT2npDkqChFx9TKV+HNT+kp0SfQR8B+ElSxgugH4FU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=sg3q6KBIwWmm+QXcfSOnn2nfa8moIix/wjczWcn1Drfv4iC/tkgewXgg45MnAdAnGrYNZnW/8eKUE2yCqyKUyI3mppuQLec97glG7nMAC+Lgqvy0tJNcwwW694Ajk8FOXn1+W4g1HP+CnzEQjr82vrZLZBwyzJgFPiNzkOUudaU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=VkziFPU+; arc=none smtp.client-ip=209.85.167.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="VkziFPU+" Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-407a3c0654aso157887b6e.3 for ; Wed, 11 Jun 2025 14:33:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749677626; x=1750282426; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QFN97YuN8D7QHIfcx7PEu7cdojzHqHSy2OCjFX9bZVM=; b=VkziFPU+Y/KKJcmwivPIUP2CdVqzbNVaFGJMN3r11GsKULoZho3msT7+e6YSWqkRIC GUdO5WIW7daL6EyCT6OHC2LBSrasNEVinabfRJbM1WEWus9WuqwaMcKxV7aYlOCBcH1z 2BIb7zQbFbocQwUHLfpzUWCPNQxxMmZFjvkyO96ovq1lMD/UYtcQEO6DmvtSr9oeJmK8 +nK0+f/8SkG+R7emiGOPd6laR/zNZx1b/CN5eSyptVEgrpvlPEB81hOiHOtt5Prfvrgl sG1/xkgg6zJr2XAEA3rRcclOE225rmn8sG1sAGX2egBJHGIKshoLTDxfTn3OHYnRP3Em V0bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749677626; x=1750282426; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QFN97YuN8D7QHIfcx7PEu7cdojzHqHSy2OCjFX9bZVM=; b=ln/jPlyxbZIWgcOjf9nVUBA6u5EUQGp6XdMH5NgkRtIaUxY4rlwKiq5E0Lrxi62Lbe wisCNp8ffJczs4OBC+/Lxwqedd0SMxY6p3hd4apxFB3UlXN02zwAHiKbzfsPdZVM7fNp uLIKaOcEj3DM0v5C/bmXnNSrsWDl+k2Q8mVfEMlO9frBrDkophd58lL6oXEFifURCNAp WGYdMTyFerU9Cc7kGuLt2kxiRjUw8idYMC4BbD+kXSCS6cmUiLSxc0vSEYMcxTqvhYv7 e7Kxf5sFZN1F9099M3Yd23OpTboB3JiQfbKi3N4TZ3+fJEQn6FIxK44YwavG5bBg86mq zFUg== X-Forwarded-Encrypted: i=1; AJvYcCXqXu/fFCeCBdGTbnUOF78eAswAheprFX/YSd8Dap7GCFlwV9A3dkjYcw10FnJx1y/SbRMV9GT4IZABCo0=@vger.kernel.org X-Gm-Message-State: AOJu0YwYWf0Q2P+WyGPNF51hNNjelzQF68lkW6cgAiC/bLlIewwQqnKk N70SmNom3Z/BX9SkOzgc7uMSAMZVYkRHf9+QKM7Y2xncPbfSKaRGtLjTIQH3zls+EtY= X-Gm-Gg: ASbGncvnbNCNJV0NOPPcb7M7PnV0RU5WvLS880T7KH9JQHE4M+DPnzufj1vbVINAe3T Yqe90CivLYgQy6MJoB4+sMlGyXL1ieTL8Hd4r/DYiUSuEbUmjK+ewsLguyMfJ+BwtnefRBm4ctg NHR5CYGt4H+swwUf+hqsiBk6jzoupChOZCcKOW/rh+RKTBvjfVyOFA8sQqsUWB9KwiJjuJL5g6W AXhJhbb15LkEw5mYHXs9C6i9S5AJp42LI78lS9ES308y3Jg9NhwZRGeJzC5mUfJPhVFxm2YvkKW HloBMCXLb4FKB0H3KNFsaeepTdLxF9sAR4RXpvBivf2zKurjmqRsZ8cpJE6r1B6EBIDwHom8pCG J9WI= X-Google-Smtp-Source: AGHT+IH5i4RvUZM0nPCi7tcfmNvCllRadqHx7du0uAq49bqRQdlg2xae0GaZM3j6FWwZkWAz37bFBQ== X-Received: by 2002:a05:6808:1806:b0:408:ed52:c62f with SMTP id 5614622812f47-40a5d0553a5mr3358437b6e.2.1749677626307; Wed, 11 Jun 2025 14:33:46 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a682fb0bdsm2262b6e.23.2025.06.11.14.33.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 14:33:44 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 16:33:01 -0500 Subject: [PATCH v3 1/5] iio: amplifiers: ada4250: used dev local variable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-1-bf85ddea79f2@baylibre.com> References: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> In-Reply-To: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1839; i=dlechner@baylibre.com; h=from:subject:message-id; bh=FLT2npDkqChFx9TKV+HNT+kp0SfQR8B+ElSxgugH4FU=; b=owGbwMvMwMV46IwC43/G/gOMp9WSGDI8v4nJy6e4KN3q+uPGPL2VJ/3txzP/j3Wo6vYVTmedH FX1Ou5lJ6MxCwMjF4OsmCLLG4mb85L4mq/NuZExA2YQKxPIFAYuTgGYyAQ+9n+am9+av+ffISBq pLB42hT7yta9Duxhr/TKJvzVVnsYtTFOqXuBfo7BGQ+5VPkp1U7zPhtxK1h7PpyRl1bgxr2ko0x /3tqClNtcF9I9t8wU8N2RYZL9NFbpnXjjY8b6vjsCj+Uj+M0yNt69167HyL4iMLVo/x01wZS3BU 5LToQpJS/JEdt/milY79EjzbLV1ytUt3sUm/285cJZXlbAPouxXS5sm5xrkvfG6B0l9pqHTx7hF RHlmhSkdNxs+/XX2ktmfGwLbtln8GW/wI0Jy8Trj0Tv0XJaEcnjUnBScp1yQFHxiYsLLl5oZzd9 cnTXjMOdRRb5FufqrI4JqF/Wry/f0yK1iGlNai/jjDudAA== X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Replace local spi variable with dev in ada4250_init() since spi is not used directly. Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/iio/amplifiers/ada4250.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/iio/amplifiers/ada4250.c b/drivers/iio/amplifiers/ada4= 250.c index f81438460aa51ce30f8f605c60ee5be5c8c251d3..397c1e1545cfccad9b0ff58b133= 796d415130064 100644 --- a/drivers/iio/amplifiers/ada4250.c +++ b/drivers/iio/amplifiers/ada4250.c @@ -299,24 +299,24 @@ static void ada4250_reg_disable(void *data) =20 static int ada4250_init(struct ada4250_state *st) { + struct device *dev =3D &st->spi->dev; int ret; u16 chip_id; - struct spi_device *spi =3D st->spi; =20 - st->refbuf_en =3D device_property_read_bool(&spi->dev, "adi,refbuf-enable= "); + st->refbuf_en =3D device_property_read_bool(dev, "adi,refbuf-enable"); =20 - st->reg =3D devm_regulator_get(&spi->dev, "avdd"); + st->reg =3D devm_regulator_get(dev, "avdd"); if (IS_ERR(st->reg)) - return dev_err_probe(&spi->dev, PTR_ERR(st->reg), + return dev_err_probe(dev, PTR_ERR(st->reg), "failed to get the AVDD voltage\n"); =20 ret =3D regulator_enable(st->reg); if (ret) { - dev_err(&spi->dev, "Failed to enable specified AVDD supply\n"); + dev_err(dev, "Failed to enable specified AVDD supply\n"); return ret; } =20 - ret =3D devm_add_action_or_reset(&spi->dev, ada4250_reg_disable, st->reg); + ret =3D devm_add_action_or_reset(dev, ada4250_reg_disable, st->reg); if (ret) return ret; =20 @@ -333,7 +333,7 @@ static int ada4250_init(struct ada4250_state *st) chip_id =3D le16_to_cpu(st->reg_val_16); =20 if (chip_id !=3D ADA4250_CHIP_ID) { - dev_err(&spi->dev, "Invalid chip ID.\n"); + dev_err(dev, "Invalid chip ID.\n"); return -EINVAL; } =20 --=20 2.43.0 From nobody Sat Oct 11 00:44:27 2025 Received: from mail-oi1-f175.google.com (mail-oi1-f175.google.com [209.85.167.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1F920243968 for ; Wed, 11 Jun 2025 21:33:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.175 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677631; cv=none; b=kWOcZ5z19EDJztu6N33QAX9fp6bl/M8Q+e1IbQkLQG45WOBU7V+2rIH7hpFVk0WYnZeK1bkDesvK+DyWKaucGmOiYCJOqfG/FYjpK6JbnqtR9xY1bcmiZ7ViXyiYoT45nxq8MF2Kj7ZnjezV2bXzsHBJ3p2pIIsCAt7La03ngSs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677631; c=relaxed/simple; bh=8nYNZ0t13n9D/8UdTM9a/nnJ6lObjFa3OXzCbnbLuUQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=LL41/dhey5ttxU5GeBZ0r5y+9Cs6EaswzcclHumotAlOht6cqHd06MrENt1JlChE0ZfbNm/LJmEp4t2JIIOj6IUEMkGa82pyABE2btmr8QM2ONhapTRb0KE+JxR4evHcQYSPSEu+xQlkpKds8ANanDzkWys5EZrvvqAdI2do2uI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=ef4zGzub; arc=none smtp.client-ip=209.85.167.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="ef4zGzub" Received: by mail-oi1-f175.google.com with SMTP id 5614622812f47-408fa4be483so171780b6e.0 for ; Wed, 11 Jun 2025 14:33:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749677628; x=1750282428; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=SzLb/vPlnEIFPDoiLpCdRirb2U4EbQo5sgL+L78nVMk=; b=ef4zGzubYhr2wJ4oAH7a7cuadQ1Fck2VxnZQYI3+7cVt14/zmy2apVOeAqP0/vvpV7 ZVHYQ7UZ7JYuzrkRV3E9sbm1fQ11wjB2DbiYo3zlFlRdO0XJh0EgUBHWV8PROvV8Cxl/ 6aIbPApfB+NKul6LsCT3CO8wGP2wR7pLYe6Z5s0MLXqdmvjKhoBqSgd4jM1LiNSN5hZw hyIG37VhWTaVma6ieT/UyTo88WJ3W+2ULgud/lZeM8JP62sOVlGuKw5A+K0gpofktSfV BI/R3dkYl2mqEaUpXN5q7geYj7T58DYZ3XVapGcJUg86dD4WCOOjjanvoqiv939C+toc piPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749677628; x=1750282428; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SzLb/vPlnEIFPDoiLpCdRirb2U4EbQo5sgL+L78nVMk=; b=hMxKNmAyAO9ZZfdUEo1977+sfaYj8ebxRjuYcvVkxBGILU++2V55pu5F0OGbeK9QTZ par9eNv6Xr7QEda54A5oMaUu1TKKyfuehztGZ6PZl1oiqiZzp0yvooGQ1/Ya9rAfj2nq GooZ9MxrvB7U9a84sEf88dzQ0P7ZvstMGVGxR5pj0c8hSV6qZP/RCvsHr1oEye6Z3iuQ Zol/enqNexoKT6wgqBk+MVjrAOshR+//iu0Iu4c9orop8cr0T6fht49AM2hYlBcVKmC0 3MBF4EiWunZdMd2avFGDPH2ejS2KhCqCOWc4a9m7i/lh128Pzl2lPoZEmWERZSGwXMc9 OHzA== X-Forwarded-Encrypted: i=1; AJvYcCV2qyyKfZ7JIC7aazqMbAvbkVDz6z12+2GJEV2ZQc5LrmtkL/csSmFR5eJJiZ3bdPEfu/0xK556uonZZ+Q=@vger.kernel.org X-Gm-Message-State: AOJu0YzIFHYXWn3iH6qyXJM9gEe04wgt80WLA0KBhby2vilo2xsm1/Ve K/noTUGGuS5meIyuxrck+5NQR/S5OX5ZDgDt9E6wbrCrYD4LqCNLEk7tCu/e3gQO8qI= X-Gm-Gg: ASbGncsJTwV3+Aeof6HGRHysY6Nj/Yt2FT1Q26Nh7zXXh2ycPjyK3Gk9Ad227CK1RHi T+vpOsso6NBSDr1n9nnZOjT7+vYQUT/UsEf3GrrKrRB242XaScyVKin9fEZI61QWq4KiDIzq1Ug JX6FhNoQNrEFpE76c5g2cXGqQTy0UwX/VQQHCCJdabXtHP/hfy+TNX1oVhom1TBZh2QbT0nTXhW KOrabaLHFzsol3Gz8n07tzN3WWRRqsyNELWxvspQBtbK7KGKk7OofBd4Sb30bGAJ/BrdGMGxb+m keVO8dASjJaeubIwaJepvj4bXOIlYGTZf92jAxCBhfE90n6639jZOPUnrpNA/yhgn85/uyqbRJV AKks= X-Google-Smtp-Source: AGHT+IGfTOk9ozSDpoM+4g4Hm+0DH29OFTfuba3qFwOUQuVKZ2xCg+WwfSm/zL+cIAJIoC2uakHA9Q== X-Received: by 2002:a05:6808:2286:b0:406:7a50:947a with SMTP id 5614622812f47-40a66b31f1bmr366446b6e.27.1749677628096; Wed, 11 Jun 2025 14:33:48 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a682fb0bdsm2262b6e.23.2025.06.11.14.33.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 14:33:47 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 16:33:02 -0500 Subject: [PATCH v3 2/5] iio: amplifiers: ada4250: don't fail on bad chip ID Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-2-bf85ddea79f2@baylibre.com> References: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> In-Reply-To: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1278; i=dlechner@baylibre.com; h=from:subject:message-id; bh=8nYNZ0t13n9D/8UdTM9a/nnJ6lObjFa3OXzCbnbLuUQ=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSfYcKVfvHAUfzl0bBKS3Q0CJ5CYc86OmKPceM iLtKwZaC72JATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEn2HAAKCRDCzCAB/wGP wBaFB/4ytHErWauhCNxbfIjhOXWgpbfFh62T8WtVJOGFL/DXdX0uxGAqT/+2k/UhhiJsGO2KQsc azPFnkGeAQtfLJzDQUE0Bxh0mWhCEhHqvj3E+kEMrX0/5wXrm/njroGBuF4Y7p9IC/BGT+Lr+PN frlbQe/EVAuq2DRfHTe20KRF3gxEsg84tYyqOruP0QT63Ooz9/gDzRcnyKoSibLpyRBlrCai2Z9 jv6f1Ksv1KLdzBwtM/UcVXukcyUcYj8R4P82LU1VjLEkraCO3pDOowf4LQEWJM6ZrIoP81CxiXy z+vwXtWcNpnpbA0Bas5T+DIjCyNFHfh0VB7OIRrgXUX32teu X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Only print an information message instead of error message and failing to probe the device if the chip ID is not recognized. Experience shows that this can be fragile and some devices may not return the expected chip ID even though the driver is still able to work with them. Suggested-by: Jonathan Cameron Closes: https://lore.kernel.org/linux-iio/20250421122409.79f5580c@jic23-hua= wei/ Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/iio/amplifiers/ada4250.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/amplifiers/ada4250.c b/drivers/iio/amplifiers/ada4= 250.c index 397c1e1545cfccad9b0ff58b133796d415130064..1bd7c0c3c695b3872b8c389fb4a= e89bf5d24f51c 100644 --- a/drivers/iio/amplifiers/ada4250.c +++ b/drivers/iio/amplifiers/ada4250.c @@ -332,10 +332,8 @@ static int ada4250_init(struct ada4250_state *st) =20 chip_id =3D le16_to_cpu(st->reg_val_16); =20 - if (chip_id !=3D ADA4250_CHIP_ID) { - dev_err(dev, "Invalid chip ID.\n"); - return -EINVAL; - } + if (chip_id !=3D ADA4250_CHIP_ID) + dev_info(dev, "Invalid chip ID: 0x%02X.\n", chip_id); =20 return regmap_write(st->regmap, ADA4250_REG_REFBUF_EN, FIELD_PREP(ADA4250_REFBUF_MSK, st->refbuf_en)); --=20 2.43.0 From nobody Sat Oct 11 00:44:27 2025 Received: from mail-oi1-f172.google.com (mail-oi1-f172.google.com [209.85.167.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C63B624468B for ; Wed, 11 Jun 2025 21:33:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677631; cv=none; b=usdazhxAyxEyplhE4E+bTrcbJL6rTpXf3inWlqPHx6j+57+RtZVuwEXogF8qVFpuuc6C3mB4NvPmrD9HO7nGLocr8aSmqsTae0bOrCZl5W/UWaa4fcMTqg5t8A2U7A2x9eF1VuJzfDKBLD/IqbCGNFAbOe5fQLAdO5IXssmCUoQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677631; c=relaxed/simple; bh=bsXjItfjIlF4mpOX6PIPZMbV+Bz7PTraCSfE6A/WZ2o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=Kji9F8zsUZO/zXphsppgiS3Cp5fLbuc3RYY9mn62B70JVeiGqtubihbALsYkmslTw5yfiaNPqf7zJSccPG56wg6BE8rmX6MNFj6GTZbUU4ogb6kBE927XH40QQnsW3CSw9UMe/NuYHzou05eXe3d167YvUh1nphE8cxnNNrBQdE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=IWyHRAyh; arc=none smtp.client-ip=209.85.167.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="IWyHRAyh" Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-407aac76036so169141b6e.1 for ; Wed, 11 Jun 2025 14:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749677629; x=1750282429; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=QaR1O7T46/e+4OFiKZVwJfA8WtG54T6ucoylR5V5Xto=; b=IWyHRAyh2q23XR+DQSYcUuu9PuyygS8NbEbk5H37heZtsPCRgnSHS6FlFdbWWi2t7u fCBW5Xais9hsJ2mK6tB+avom7Uet25Mti8Alw+hKiq5qBGMI2IjEaMAGsNZdf8CLDjTw g/vZ2LSNC7dk8DwCVHp47DreY0dV9E/YLxiC3XMLGMzcVwJC8jP83Ltr5m4Ojbi0vaAq fRORP8ne18BAAy55ZdyorgSst92ZoCDPzqwDPQ21ARdBODdGSySTbuxeTDAOmHh/6OW5 DTwft1FQ++E1s8yB4Lhk2kZjXVWJVE1guGNwVf3iImrxn6RJZL88nJ4bNuAxvA3AYT29 y6ng== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749677629; x=1750282429; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=QaR1O7T46/e+4OFiKZVwJfA8WtG54T6ucoylR5V5Xto=; b=niX7d2jLTqYqfP6yifrilDCqSgB9TL820QgWGh8ij4rjxr7MZUDHSSt5ZFxn0q2zAq ULn6fvei8mSQf93UotFW5PpMjCyaoLRpc8pQB2KNZcX9CCrOBc8hKhMJIRKTtThEwuLa KXM7zMBBe0idFotOWoMOgKENzTRzbdfdaO9N8Fyo8a82ttRtdkp6mSYktNwoSu7Y5nvx gMnLt5PuqA4KkDZ6lqG/yFJuEVcbSpRfXt0vS9wJ5fKWC8mjSx6w9cTuA2GMZknz4ypy 7FfiozdssHYVvbdWqKBKZkGWy3FHsXnIZlBsAGLpyZqdBAUp7awMuJn1rLkG5Q3yOOPr 67zQ== X-Forwarded-Encrypted: i=1; AJvYcCUvSzQyhGdsynLGpGkY55O30RUSiMoLa7f8ra1nJ5oanf9y6G1TPPyn2Cr6zzA0c99COow3dcbsJkiKXlU=@vger.kernel.org X-Gm-Message-State: AOJu0YywfvyC1wsC1C3LIMvGttFMUwCIRJmfopA3WR7fZK+Oyk/yTZZ5 PfWIGW4GD32DdkJc40+AcCLpoFxjgH7BeVtI3NkkTHY5Hg/+rA8gDCEajSIZ1y4yRiY= X-Gm-Gg: ASbGncvRbmhNWvQs0qXMDTAHhf/0LXvrQXjBd81Y6cpyXe1meOGf1vUnRas0oDJJq27 H2eVGSTVr+1svOBuBxjQWJnhevJ4uBxiDxVU/pXXvnv+JM7bqvi9/SxroTYalVcs8ozJVcioIgh 92l0JjKD96E5mZAaaHnuadRDh2G/o2nNpp3FJ2PFj3JlSJck6tJtSBipZm/fWkTop5/djzKeLvo NCu9nl5ui3IRbMIwBzq+UjuRNHwkd1ZxhJmr1wAivz1AgwdxiB5EVN6/yUZcpva5sQ8j0g+YjCR x1/nnCV5zsVJ22S+7ZhrTm1fNdgWjuKSrTmUMoT9MtE6XXAhOMOpx8U2i9vUL10Xv5ga X-Google-Smtp-Source: AGHT+IHSIqmpgFI704FCWcftRQq8j3a/a2UfDUj0eB9CNGvobPtddrpb4tcsnxsxsDbtHvuDl7rThA== X-Received: by 2002:a05:6808:3087:b0:409:f8e:727c with SMTP id 5614622812f47-40a66a419bemr475432b6e.5.1749677628865; Wed, 11 Jun 2025 14:33:48 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a682fb0bdsm2262b6e.23.2025.06.11.14.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 14:33:48 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 16:33:03 -0500 Subject: [PATCH v3 3/5] iio: amplifiers: ada4250: use devm_regulator_get_enable_read_voltage() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-3-bf85ddea79f2@baylibre.com> References: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> In-Reply-To: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2721; i=dlechner@baylibre.com; h=from:subject:message-id; bh=bsXjItfjIlF4mpOX6PIPZMbV+Bz7PTraCSfE6A/WZ2o=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSfYjPh0zoRqAxnaVZku8YBtsOStzbQ3hW4OWQ 5GqapvEqbSJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEn2IwAKCRDCzCAB/wGP wHzOB/9MY+J7iMqc9X5TjdHUYDxU04NDw/iERF0zwegoZo4pMJxbqEuy6pB31f1jDANUVHCXB7F eBmAlytR+4kcvLH2H5L5Qna/xqyUZeCM8hcrVxa6q/rlhfi1FU996VOal5DiSmUg+r1lf0xMrad rJwx308zXliRqOKo5jxpUqb7A9axg4z2PfqR1lf24d9SLhXy0QUNBFtHE88AbEj6vLEJtQqlaGa EFBq+7kuSXcx+Hs4+fx0kg5CxZm5e4blRd+aXKcTZHq0LdKhFIxy7w7yw054goueh+TVci8O6G1 8dKEVSTRv4vwOx6woFKfigNowbHmSg7Ja5pBPBGpChnm+C9+ X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use devm_regulator_get_enable_read_voltage() to simplify the code. Replace 1000000 with MICRO while we are touching this for better readability. Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- Note for reviewers: if you are tempted to comment on the new variable not being grouped with offset_uv, see the next patch in this series. --- drivers/iio/amplifiers/ada4250.c | 27 ++++++--------------------- 1 file changed, 6 insertions(+), 21 deletions(-) diff --git a/drivers/iio/amplifiers/ada4250.c b/drivers/iio/amplifiers/ada4= 250.c index 1bd7c0c3c695b3872b8c389fb4ae89bf5d24f51c..c367c53a075b26327a221e0c3a9= dc8e788891f32 100644 --- a/drivers/iio/amplifiers/ada4250.c +++ b/drivers/iio/amplifiers/ada4250.c @@ -14,6 +14,7 @@ #include #include #include +#include =20 /* ADA4250 Register Map */ #define ADA4250_REG_GAIN_MUX 0x00 @@ -55,9 +56,9 @@ enum ada4250_current_bias { struct ada4250_state { struct spi_device *spi; struct regmap *regmap; - struct regulator *reg; /* Protect against concurrent accesses to the device and data content */ struct mutex lock; + int avdd_uv; u8 bias; u8 gain; int offset_uv; @@ -91,8 +92,7 @@ static int ada4250_set_offset_uv(struct iio_dev *indio_de= v, if (st->bias =3D=3D 0 || st->bias =3D=3D 3) return -EINVAL; =20 - voltage_v =3D regulator_get_voltage(st->reg); - voltage_v =3D DIV_ROUND_CLOSEST(voltage_v, 1000000); + voltage_v =3D DIV_ROUND_CLOSEST(st->avdd_uv, MICRO); =20 if (st->bias =3D=3D ADA4250_BIAS_AVDD) x[0] =3D voltage_v; @@ -292,11 +292,6 @@ static const struct iio_chan_spec ada4250_channels[] = =3D { } }; =20 -static void ada4250_reg_disable(void *data) -{ - regulator_disable(data); -} - static int ada4250_init(struct ada4250_state *st) { struct device *dev =3D &st->spi->dev; @@ -305,21 +300,11 @@ static int ada4250_init(struct ada4250_state *st) =20 st->refbuf_en =3D device_property_read_bool(dev, "adi,refbuf-enable"); =20 - st->reg =3D devm_regulator_get(dev, "avdd"); - if (IS_ERR(st->reg)) - return dev_err_probe(dev, PTR_ERR(st->reg), + st->avdd_uv =3D devm_regulator_get_enable_read_voltage(dev, "avdd"); + if (st->avdd_uv < 0) + return dev_err_probe(dev, st->avdd_uv, "failed to get the AVDD voltage\n"); =20 - ret =3D regulator_enable(st->reg); - if (ret) { - dev_err(dev, "Failed to enable specified AVDD supply\n"); - return ret; - } - - ret =3D devm_add_action_or_reset(dev, ada4250_reg_disable, st->reg); - if (ret) - return ret; - ret =3D regmap_write(st->regmap, ADA4250_REG_RESET, FIELD_PREP(ADA4250_RESET_MSK, 1)); if (ret) --=20 2.43.0 From nobody Sat Oct 11 00:44:27 2025 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BEDA24679B for ; Wed, 11 Jun 2025 21:33:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677633; cv=none; b=CgskKT75hRdguSPAyJguiiOPH8nfwVrZYPSXBf3B4qcWVgATV4IcxSv7s67OoH0743BhNd5bFTtaBOPMtiZjOkQ/SdBmYdME81eKakRKglJu3AK2T4RZKoOTrHdPlrkZR1UlcsN3P7NWu4qeYfA5d6yu5TKWcjIHNZHYyP4FV/8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677633; c=relaxed/simple; bh=LlWi7e9nfRBdZldq8Xrczi7rWR0APRpPRo7NBynoOIM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=eI/E077k02rUPULHnkNx9t1fTg4XQwgEvYKIav/EoBZUzt3P8w+tlO5WyQXOAJHygKDwHTXteEuXt9DGTUmzOY2n+gMuPkczl3rsLUEsQCAHsNTAraV4mgW34i6NDRjJFnwRwzZsQrtn7/5SKWxCNT3gshDikaq1Kg4Jwm//rN8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=DCjWpjJi; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="DCjWpjJi" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-408d7e2ad03so188232b6e.1 for ; Wed, 11 Jun 2025 14:33:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749677631; x=1750282431; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Z4SaXSyEnDBgBJat/vCjlAxTbS9Xx4wchBNLXn8gtEQ=; b=DCjWpjJia/yjAe+sOB/UyMTZrT6vczMvTqoXb52DkGNqNX+WOciA078zvXCT5eYkHQ aLFbQEFMgkaibkbUPpitYVEIiqErSyfAgRaLMbagTPxiPENWAxfv7YnlXBhx+KhDiYKA hQoKJH/IUXTh88kXEulj4uxKA69PsraFHdZ47xZtswAGZP4N0KPlEA/gBzfzmN9+7oiN HJBcv1rTEGNl18CC/sEZSbNgx6HJjiUDiMrMYqH3mSq8UGCHA2BlhVa3ezFbxD19499q iym2DVXPhxDg33MfndvYEdQ0MoETnVwfztywqEqF1NdInfDusHOoxqfZxAgvo/OSBQJY aFNw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749677631; x=1750282431; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Z4SaXSyEnDBgBJat/vCjlAxTbS9Xx4wchBNLXn8gtEQ=; b=aZYKPnD4J76EftBkcCEYB+DqdD5LYp8WbEl6Fqfv/Pil/Aljb5cv1gLdDqJMWsRgd/ efJDPXxBXMVnWxE2rvR1W0JeM5Dh1kOBpj3iwH8rM8XZTe465O1BX7LShrXJ22DvLiyW 7ioAG5mrcpMhTYUC9MFgc043ZWTujCGrYcHMpztyTGluVesK9KJOngMRuqNtgkI+tQp5 MITPXI62AB6AZ0ZOEuurlIg2FwHFM5gL43F1VcIx3jEFBEKoyCF+/OmpgSgGJtou5JSg XYEskJwBhHtT69MlS7A2MM25oG3v1vwMQQgTpyAPVuBeXOVuLMVurw2dUwit5sXYgWdP Jt+w== X-Forwarded-Encrypted: i=1; AJvYcCWbgc5RHbftyvLBDjkjkC7lHCcjoRzB6qXjK8hFz1FxilVo9R2gNAHhGjJK/rbmMh9xzD6Nb3fVVctPlos=@vger.kernel.org X-Gm-Message-State: AOJu0Yzft28GMuGuDDDtvt+rrXXjBrRrxWhDuIWfLz65UEh/NEGtnuJA O0dVFyMLV+jXEwGpb9vTD6i9ZazDACUQxciw4GMUME8eqOSp8ut3UDiIfVRn/TKxoqg= X-Gm-Gg: ASbGncuhQUqwvXGj8D5gd39sy2RJzb2Y7GwWruFieCBBhUNHDKGGNFQ0WoNcafVt4RG k2AjgrHUyxYTjtLXJnVDrHiuo75PBHeWldi8TDn2Hs8tPfVq0cebOjWce3lRHjE8qI3/eLuLtee zOKTUB7tntIjAEz55NwD7zDo5RxqcV8BLY4vTjGZa6/adc91rv3C0fr1z8AScQNrHXGlOMyB5tN BR0k3mMO1cQBEDQWsfAxPnOENfSuJLHsk49vlXucJ4D9Eyqa1d/8nI9SQpU2fI0c+JsMyRcSow2 rTjPnzoCGPUsCJaK7FBLtuhrKpVwbYnBRMdNSFBBY+9bIuVfp6rGg47B2mbFmFVN4m7BC4PeNNn LpHE= X-Google-Smtp-Source: AGHT+IEinQKOQJo+bthrujO46CMI/J1E68B/eqmJGPvBJm1AVFdFm9iBX53E523/hJ1j1GrhDFz2jQ== X-Received: by 2002:a05:6808:3190:b0:404:1898:c82 with SMTP id 5614622812f47-40a660a144dmr869806b6e.32.1749677630714; Wed, 11 Jun 2025 14:33:50 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a682fb0bdsm2262b6e.23.2025.06.11.14.33.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 14:33:50 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 16:33:04 -0500 Subject: [PATCH v3 4/5] iio: amplifiers: ada4250: move offset_uv in struct Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-4-bf85ddea79f2@baylibre.com> References: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> In-Reply-To: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=843; i=dlechner@baylibre.com; h=from:subject:message-id; bh=LlWi7e9nfRBdZldq8Xrczi7rWR0APRpPRo7NBynoOIM=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSfYpEfFW7bxJ7cb0xHYFKY86SyYWWpIEWzPc+ 2wFe2i12x6JATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEn2KQAKCRDCzCAB/wGP wMZSB/9SYHpDxEcALA6ygZ6HAblzs7li7WWy2wEqtsjhSHzE5BqETXVQmyuHfqZqN/uxsnpYGQH xyLwxxT3wq1+a8PUn442ON1x4iRSGj8RPycUBF06CsRf7yU0Ipm5fvicC2pOLsL1C/wyj1tSdq6 daNjsLbxatI6LfvIEN7Xmo4mCyu2f8fu2LfYNM8yBKh11PUUbVppywpcZxkBiQXXw/qFyX8d7eZ JRWmY5l++mFCSy5U9eNNEI8t2/zSltkgF2gdFgX8ukjnQQRfTpse8EsUQxHbTGwGg/GHEzW3HiE Fksx2xtB2iONCEfs+lMfXv0dFniVASBAQKBbLDeKR0rHZS4L X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Move offset_uv in struct ada4250_state. This keeps things logically grouped and reduces holes in the struct. Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/iio/amplifiers/ada4250.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/amplifiers/ada4250.c b/drivers/iio/amplifiers/ada4= 250.c index c367c53a075b26327a221e0c3a9dc8e788891f32..d20ca410c506226fce7f172632d= 46b2ebb140a12 100644 --- a/drivers/iio/amplifiers/ada4250.c +++ b/drivers/iio/amplifiers/ada4250.c @@ -59,9 +59,9 @@ struct ada4250_state { /* Protect against concurrent accesses to the device and data content */ struct mutex lock; int avdd_uv; + int offset_uv; u8 bias; u8 gain; - int offset_uv; bool refbuf_en; __le16 reg_val_16 __aligned(IIO_DMA_MINALIGN); }; --=20 2.43.0 From nobody Sat Oct 11 00:44:27 2025 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6997E248888 for ; Wed, 11 Jun 2025 21:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.171 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677635; cv=none; b=pxrW82mojMhHRYz8psTjftFBaa65i9BCNGQdElQpSIUiNhUO6gc1421FzbdRd1XGYfOuMUw3xTnbk4CY81EbZ8zNFkECfTcdklZoimwiJPS8x6Ly34RtdqazWvcb8kKJKwCieHOdvxaaRTxVaUNh3x2muonZJDCsQuMtixDHjpg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749677635; c=relaxed/simple; bh=+UrdvpKib6PZ15hVhO/T6ICol7iFeKJg7nNENfElKdg=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=lEh75jaZ8E/Wy03hpj/9R3Xhyq/jb6Nfh1hz6Ez42xTJ7sIQP1CB1Kz+GiBdF+ZHSVK+MpUIYR2t4IplTDRQmq3k7OhtHJabH5DLGxqaU4dhMy35hPgSqtQ4DlPhUSfZcNH3nnSORqCqduyNBDTgEsSr1tRuCDlxkOHV1QS2yxY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=i0HX7Xye; arc=none smtp.client-ip=209.85.167.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="i0HX7Xye" Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-407aaace4daso149168b6e.2 for ; Wed, 11 Jun 2025 14:33:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1749677632; x=1750282432; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=8OTSXfEM4NzvQUr9h5Q4lURNoh1I+2//AZVGJRIuPek=; b=i0HX7Xyeq3GOLWAIAqB2C9YDN5SoksCfwsYpgrMJuvhXyooi0O5LkpKrqZVdxGjKqD K5siStGPAvRu6akKaxLbusA/PCEqB2ibFIO6Wzvm6LMCBqpe3tzX36ia7OlWE/fZsdQy Df3Gpy2iHQ3zOXi3W2RAFfc7l47eIe9wUpXmh3hiu7gpM2fnb7QgtD+cIUU26BmGo27X d6AzvQdtHSlD/jNRrZrWmODwmTSw9o88f30LwSOGxTDAYuIAnEF2Wj36NZD8LIarCStN 4VFPKAk7gv9LMkJcvHuBxT7/RFQW9wjcFMP0DlhHsK25aYqAFwjnI0NTf37Wx3S0em2i ZTEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749677632; x=1750282432; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=8OTSXfEM4NzvQUr9h5Q4lURNoh1I+2//AZVGJRIuPek=; b=RQR5nH/k0VQmVlToMFq3hMeWsfKtajSb7StFQVNYupgRmwbScN1fWitTSFgL4xsiR0 qkHTxcoqVdLhN1p7ggM75wVqBajOSt/fpbO2/e0jjHLr3jBZ0lKL/Ko+0ZpSyEHw4Hw/ sUwvMl4W4zLieSGkq44wFVjJTJOVccR0gJgRIyRg9Lcc3ywj6TxBf02I/vBSQWpSFag5 xnqHi6dxtSIcGCt/6ZD2XLMlQ+5kI5FrQuF6xPl/PbYNT5OCIPriRJQR2q2ffDIEggP8 /TpJa1ajJc4/dMUigfGUQR7kNcOkqK3cA6mzk9ABnOOC6qL1toXTDTJpQH0BMeW7BSPW K0HQ== X-Forwarded-Encrypted: i=1; AJvYcCWfu3lpymGIsbPHZtQbfqcIzlvOnZ9GtEBwyt/rNxidi+JGzn5FFFILU5tGuEACvXgsUZQ2XI0KHW0EHl0=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt/jvRuKfYiRYPF7gjyTFy1nA2Ql8OgkIzN8Abu+K/Bpj51Xvn Y5pkQtBRkC+sOaBdgEiPJO/0VYKtFdrw4xTm86QquIZBPoFbKDtf8rOvjdTl3HN2LT8= X-Gm-Gg: ASbGncu9F7+6dlHsNmFsauKYGGY0NElSBYZBw4XU5jA3YBgyld+ub479XJxKhk1ecuR 9r7fGJQ+GweXKxDZX1Ek1civaCftcvuhkKeAajhqXiFEYx5z1/e4lfV00x1yP0qOlRPBaj4iywP SoeDheWYp+vmqaLS5Kgz/LjcVD6z0sjfKspnof4mIAkcw5NfyVZWeWTCr//Id0RY4z6r+4NU8Ml Yfz6xZ5AR9X0Quwkvwep7PDeKmPFXhxrjurhfwPeKRQ956Ikjoyv8xPLYOSvnn314nG4xvEivfB J4agCAVLzJg7cd2kTTLwqb7paHfb3vE5eVu9BppSRObtYTpfLQxnbFQVNXKSLaVWxb/x X-Google-Smtp-Source: AGHT+IHHvkHFsG56i79uH3ZJj0ZX2FQ7Uce2eVoVKngIj1ZD4gf1DWEsuu9YbaODZNdOFjLj6X/oSw== X-Received: by 2002:a05:6808:3510:b0:3fe:af0b:22f7 with SMTP id 5614622812f47-40a66a70dffmr413438b6e.11.1749677632567; Wed, 11 Jun 2025 14:33:52 -0700 (PDT) Received: from [127.0.1.1] ([2600:8803:e7e4:1d00:4753:719f:673f:547c]) by smtp.gmail.com with ESMTPSA id 5614622812f47-40a682fb0bdsm2262b6e.23.2025.06.11.14.33.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Jun 2025 14:33:51 -0700 (PDT) From: David Lechner Date: Wed, 11 Jun 2025 16:33:05 -0500 Subject: [PATCH v3 5/5] iio: amplifiers: ada4250: use dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-5-bf85ddea79f2@baylibre.com> References: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> In-Reply-To: <20250611-iio-amplifiers-ada4250-simplify-data-buffer-in-init-v3-0-bf85ddea79f2@baylibre.com> To: Lars-Peter Clausen , Michael Hennerich , Antoniu Miclaus , Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=856; i=dlechner@baylibre.com; h=from:subject:message-id; bh=+UrdvpKib6PZ15hVhO/T6ICol7iFeKJg7nNENfElKdg=; b=owEBbQGS/pANAwAKAcLMIAH/AY/AAcsmYgBoSfYwMFTQ8L5z5An13XpNpztYa/Fsr66xfTjAO aTNC8++IIaJATMEAAEKAB0WIQTsGNmeYg6D1pzYaJjCzCAB/wGPwAUCaEn2MAAKCRDCzCAB/wGP wMYCCACFpuIYSrVhrd9L04vPaIBden76mfr11q1AdvBFTtXXtj4AJawZ9JNmpDY+PjEqr2pdgP2 8HFjGcGdpEhu0C9femdF5pHA447DPZSo3DaVwB9Trmcxpe7AMvkwIu1JAt38FUwNGqTtfWclV1o XJIKiVnOLc1Dw33HdOC/BWUL0/z1epeigIVUTk6X7VkaGcwRUiIBHtkicx5uK3E6Zuqa5ZSNIWU 52C8AxvgCS7jcGO6ZgoPWw7mXBLBsGLWC6SO3cROfhu32SU0I6oaMKJGoNf8dFld5fwGawlWRue L1AjDSHH+p5SozGvPlfUUpsBlzdI2FQyh3KRNVUyX52ZyxXv X-Developer-Key: i=dlechner@baylibre.com; a=openpgp; fpr=8A73D82A6A1F509907F373881F8AF88C82F77C03 Use dev_err_probe() when returning an error in the probe function. Signed-off-by: David Lechner Reviewed-by: Andy Shevchenko --- drivers/iio/amplifiers/ada4250.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/iio/amplifiers/ada4250.c b/drivers/iio/amplifiers/ada4= 250.c index d20ca410c506226fce7f172632d46b2ebb140a12..40f396ea906950ab79bf72cdb16= 2794e95f76094 100644 --- a/drivers/iio/amplifiers/ada4250.c +++ b/drivers/iio/amplifiers/ada4250.c @@ -351,10 +351,8 @@ static int ada4250_probe(struct spi_device *spi) mutex_init(&st->lock); =20 ret =3D ada4250_init(st); - if (ret) { - dev_err(&spi->dev, "ADA4250 init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(&spi->dev, ret, "ADA4250 init failed\n"); =20 return devm_iio_device_register(&spi->dev, indio_dev); } --=20 2.43.0