pinctrl: intel: use new GPIO line value setter callbacks

[PATCH 0/4] pinctrl: intel: use new GPIO line value setter callbacks

Posted by Bartosz Golaszewski 4 months ago

Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return
values") added new line setter callbacks to struct gpio_chip. They allow
to indicate failures to callers. We're in the process of converting all
GPIO controllers to using them before removing the old ones. This series
converts all GPIO chips in intel pin control drivers.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (4):
      pinctrl: baytrail: use new GPIO line value setter callbacks
      pinctrl: cherryview: use new GPIO line value setter callbacks
      pinctrl: intel: use new GPIO line value setter callbacks
      pinctrl: lynxpoint: use new GPIO line value setter callbacks

 drivers/pinctrl/intel/pinctrl-baytrail.c   |  8 +++++---
 drivers/pinctrl/intel/pinctrl-cherryview.c |  6 ++++--
 drivers/pinctrl/intel/pinctrl-intel.c      | 19 +++++++++++++------
 drivers/pinctrl/intel/pinctrl-lynxpoint.c  |  6 ++++--
 4 files changed, 26 insertions(+), 13 deletions(-)
---
base-commit: 19272b37aa4f83ca52bdf9c16d5d81bdd1354494
change-id: 20250610-gpiochip-set-rv-pinctrl-intel-e4c791f29a84

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/4] pinctrl: intel: use new GPIO line value setter callbacks

Posted by Andy Shevchenko 4 months ago

On Tue, Jun 10, 2025 at 02:58:46PM +0200, Bartosz Golaszewski wrote:
> Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return
> values") added new line setter callbacks to struct gpio_chip. They allow
> to indicate failures to callers. We're in the process of converting all
> GPIO controllers to using them before removing the old ones. This series
> converts all GPIO chips in intel pin control drivers.

I'll wait for Mika's Ack and apply, the material LGTM, thanks!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH 0/4] pinctrl: intel: use new GPIO line value setter callbacks

Posted by Mika Westerberg 4 months ago

On Tue, Jun 10, 2025 at 11:29:38PM +0300, Andy Shevchenko wrote:
> On Tue, Jun 10, 2025 at 02:58:46PM +0200, Bartosz Golaszewski wrote:
> > Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return
> > values") added new line setter callbacks to struct gpio_chip. They allow
> > to indicate failures to callers. We're in the process of converting all
> > GPIO controllers to using them before removing the old ones. This series
> > converts all GPIO chips in intel pin control drivers.
> 
> I'll wait for Mika's Ack and apply, the material LGTM, thanks!

Looks good to me too,

Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Re: [PATCH 0/4] pinctrl: intel: use new GPIO line value setter callbacks

Posted by Andy Shevchenko 4 months ago

On Wed, Jun 11, 2025 at 07:36:26AM +0300, Mika Westerberg wrote:
> On Tue, Jun 10, 2025 at 11:29:38PM +0300, Andy Shevchenko wrote:
> > On Tue, Jun 10, 2025 at 02:58:46PM +0200, Bartosz Golaszewski wrote:
> > > Commit 98ce1eb1fd87e ("gpiolib: introduce gpio_chip setters that return
> > > values") added new line setter callbacks to struct gpio_chip. They allow
> > > to indicate failures to callers. We're in the process of converting all
> > > GPIO controllers to using them before removing the old ones. This series
> > > converts all GPIO chips in intel pin control drivers.
> > 
> > I'll wait for Mika's Ack and apply, the material LGTM, thanks!
> 
> Looks good to me too,
> 
> Acked-by: Mika Westerberg <mika.westerberg@linux.intel.com>

Pushed to my review and testing queue, thanks!

-- 
With Best Regards,
Andy Shevchenko