From nobody Sat Oct 11 12:08:50 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B06C12BCF6C for ; Tue, 10 Jun 2025 12:58:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560337; cv=none; b=rhkxqU3Cy6CZbYPRT88ClUFHmiXr0NLItena+0veSPQ0wKwfCYcg9MjgLaPwTCtu8NXzOOMWVU6miu1fC6AfKpUTim+TnLmO6pOSE1uDOaUTbFtFuPYEB5uivvtLnc+W3pSw1eldTEJjI1+vL+gdepyPURbwbs9yv1Lz0/XJW/M= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560337; c=relaxed/simple; bh=dg7NTbAf068nkPAyseuYOJ95j/6EnHMv20djyj9AJ+Y=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=QoCexCHUxtv7Ug7De3uEQjPnaYWzOZ9o7eVtX7xMaRXKPGqAQGzpG1hevqrj7i9E0jYOe8dcaBuw+qb/6PPqq3ijta2GDi0UM4bcrN4NNVw3wMvvRBMbxozmz4Jw0hx/F4Dhm4IyPaMPCfqRH6UUIwO08SMPoPVdJUJHd5IEqj4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=fj0ZfVgE; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="fj0ZfVgE" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a4fea34e07so3114356f8f.1 for ; Tue, 10 Jun 2025 05:58:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560334; x=1750165134; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=gjtG0M1yLqqaJE2dvBiQ0tkCCMrIQMLQEJb8hOYQ7U4=; b=fj0ZfVgEShJLEF00AfWncm2gyeOEm0n9F/myoJW1I+ZuqA9uI1Sq0BvP3SGBB5Ypg0 pzyYnEPEGakniXZq0UoU+4l/5bHAkm/fBLEODf6LJ5oU1e/8O6r5BY26q3aJTbdWCi7A Vcax/tc4MYgy2j3ikTHoJHBSTMl8+1P8sbj174uozirS1PgBtFlhFTB1WriKRINEDziX F5ufMU1Y3VV7zuVJOTIp6B0AJAP09qHed1vEQTar3wcjNPJrEb7EQcUD/mzmerwAMmOQ bK+E+mSc5qJtM1KlKfONzdDsgEkuujTsUKb9dsnZYivyaiHm15ruy+ETZrgeTP69zCtL A0Eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560334; x=1750165134; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=gjtG0M1yLqqaJE2dvBiQ0tkCCMrIQMLQEJb8hOYQ7U4=; b=uvn6JFDUvYA5JK7FFExhlMRzETPuOv4ChgdGunXx4cIrTsla3tKZPhs73xIGJTeGlH MLNCfgqLjBD0EnG0g+EVZq+JzH1g46AKDixyACH+fr/SgG8XaBklEOj0TLEUBRkFDf4G qmqJ5jb/NZrZsR3SRFtPkWXdB6nywVlMTNuFVWCu7gINvfBJ6CuWpXjYOhlEb7QTxL+Y gB64JB1opV5qezBV5ZENXR67zkPPHhFPJrFfn+T8MpzbytgAH5W9Ko7iGTC3QHcel6e+ GBHha5zUcTmi1voXxipj4D9tlgfyrBq7zNhuthJBv/dz8cWu5yBbbuRJlhibgn7UttCi EQWw== X-Forwarded-Encrypted: i=1; AJvYcCWODmsLNBISwMzwS7y2Uw6HpQ6Q+SNdcfSi38GLHvuD0pxcdU/thVkzTZn9DzX0ZCfGpKct9M0LARIScoU=@vger.kernel.org X-Gm-Message-State: AOJu0YxuYJrlSVB7LZ0FfvP2Rh8azgBO9aVeJ9QCQk0YI5jRbzn5CMvp tJuF3Mg/AnPS56DLnarBzyKFHimlhl8AUHxeoPY29Vo7ncb7E/m4huie7wSrnMw5gII= X-Gm-Gg: ASbGncsXuWjtNlmoaiiTVmAjfOQSsXSFUMhPVYymkpcpaSgIlPXnoEJ7KJSmdK3KFlR TIg+AT9aN2KZF3uYnfzyI0s6s5Dd4QKI7gnyDTsfnEEXuwryCSu1FzvWhkPdclNLm9jGpHz8Vlo YzCY/Q9Yh9p3DN3C+liLnjP1JFQXwQVNW9zpN6Hx+Wat/YE0pQo7gMnSJHlKs4xX/Zc/hlIA67D OwvLjjXcYmPxL2xQic/XwEemkgV2wclQu/arjTO8Kf9Un1kFCc40PF5gZZqMa2+eVw3jcfhwLwD z/7xUr+P5yCwHL2SdpxNiQsD2Iceuqld3p2ja76JpBcck6pYVJ4Y4A== X-Google-Smtp-Source: AGHT+IG9PzUqyoN06LxiZpOjCCdywW8bf+fgtQ2tu92Z0cLy0kTBBzQ8suzPDSLtmma55Nz49ZsvWw== X-Received: by 2002:a05:6000:381:b0:3a4:e4ee:4ca9 with SMTP id ffacd0b85a97d-3a53189bb71mr14507284f8f.23.1749560333951; Tue, 10 Jun 2025 05:58:53 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:53 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:47 +0200 Subject: [PATCH 1/4] pinctrl: baytrail: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-1-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1892; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=b/W4ziaIZgNvt2gfFSTw+J+YlxD2KTxq4CHCw9mjq48=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwLGwnzqVkLfUS1V0SOYonbSmRblxE+rHBQp gKdYAYGONyJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsCwAKCRARpy6gFHHX cjyLEADFOQ54jPSO1HZsx7GXyUdHxTSOgbMwKyCsouhFb1ic9GsIv81XFtVmDIlfLe42EIZPsrq YzhuHu1Z1uBlqSN20j6lzNUTZDEElUoGkF02jXUQtlEu14Ses7HTX7UWoKQjR2UFrKbwrJtAg/C dH+dIi7HNmOvTFIz6hP9Ucseb5X/qnk3YJxK++l45GkykXw6y56XAl1CRRoQzL/UpzoDkE5RfbZ 1AfQ6jOirYN7jhtpG2k26WLHbdBjzLRtPTe3XvH8VkHbStlh3rXsRODdT4x6lJ7L+Q9yfTaZ4Pb BCLiIDzYCfbDsiECjaGAdJkntnGMsf95nWF7A6B931P1zSaHBvBeOTyvU/KUviN+C2SUsWADSfn K7cL5wHQOBKXS1f+zrKIs04FPoZGOywEhuQ9VwCTgBa3qm+thDcXSX8DwromAtJ962uqvWrMc7o /T5v1SXV0njvWlp1OR991KWFw62yyasWyl6pUrc3me+xV/9MoPcJIh7DyZ2OLBYiGOISTY/IRvS 1beiSF4cisCm2OWopR8NuNzxg5YWIhegNmoBVxgD3z75FUm229GTK8Nr7jf86dZdolOJQmnDsPJ wI/oEITFoAMMtytOHl+G0ao7Z4P2TrY1VuvM2vmqHobdVWbrRxyMXG5m5j87og7gwNzHJHU4biY JisDOVmnzXNNhgA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-baytrail.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-baytrail.c b/drivers/pinctrl/int= el/pinctrl-baytrail.c index 969137c4cb0659fc66bf461bcbcdc60fb2d0dcb6..6eb649f1ffd6e09c0a8c99704eb= 165dac58d9736 100644 --- a/drivers/pinctrl/intel/pinctrl-baytrail.c +++ b/drivers/pinctrl/intel/pinctrl-baytrail.c @@ -1045,7 +1045,7 @@ static int byt_gpio_get(struct gpio_chip *chip, unsig= ned int offset) return !!(val & BYT_LEVEL); } =20 -static void byt_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int byt_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct intel_pinctrl *vg =3D gpiochip_get_data(chip); void __iomem *reg; @@ -1053,7 +1053,7 @@ static void byt_gpio_set(struct gpio_chip *chip, unsi= gned int offset, int value) =20 reg =3D byt_gpio_reg(vg, offset, BYT_VAL_REG); if (!reg) - return; + return -EINVAL; =20 guard(raw_spinlock_irqsave)(&byt_lock); =20 @@ -1062,6 +1062,8 @@ static void byt_gpio_set(struct gpio_chip *chip, unsi= gned int offset, int value) writel(old_val | BYT_LEVEL, reg); else writel(old_val & ~BYT_LEVEL, reg); + + return 0; } =20 static int byt_gpio_get_direction(struct gpio_chip *chip, unsigned int off= set) @@ -1229,7 +1231,7 @@ static const struct gpio_chip byt_gpio_chip =3D { .direction_input =3D byt_gpio_direction_input, .direction_output =3D byt_gpio_direction_output, .get =3D byt_gpio_get, - .set =3D byt_gpio_set, + .set_rv =3D byt_gpio_set, .set_config =3D gpiochip_generic_config, .dbg_show =3D byt_gpio_dbg_show, }; --=20 2.48.1 From nobody Sat Oct 11 12:08:50 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 90A5729615E for ; Tue, 10 Jun 2025 12:58:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560338; cv=none; b=pAWoZ27Lz3AT5wojkzaP61hFUuSVHW6m0SbJmr/iBG8XN8JDhN/wYVp0dpCSwJzySp3uBC8lxNg1b8KFADJ2p00bt+4bciklEjIuBX2/V26n6wijenAlQms28WWqFPKM236QNF9KVRgqQbi2JZQ5qbsfA8DB0wJCW5cV2Hyuoq8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560338; c=relaxed/simple; bh=DdvAUUlpfYflNBsr++lX3Sffa6O7XE3YDx/EEjD7pcc=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=XExWxDrp2rwQSDpQmHNmI/Ifl4737RHoO9TNlgaHg/xh2HWrQlwz8LAkbsggMkZqtIinGgh1zWd7K1D2BOvtTuHUXz1pMBtfe2a8i/JnBoxzkI2CrfHT3+iRZAJkQEfPxGOxdQvmoYBqkFLLbkLigaG5w7aNaVRsYl+ZO/eszk8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=vs7g0i+C; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="vs7g0i+C" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a4fb9c2436so2843975f8f.1 for ; Tue, 10 Jun 2025 05:58:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560335; x=1750165135; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=v2fx/CQtVPLgqKAQGUIys9feEJNoyOh+nIa3K3QYL5w=; b=vs7g0i+C3no14+8TWVhnRCZw0NjYedJV1h73gUAkM4GlGdtj9SDZ/pHWo25vWVA5Bw VPUIbmVISTZ9Uo2vaOsJVdGrRz5i4590KWhr41mU+6dz5ce2M5QTs/SyPWIlc3ON3FUN RDRd3Kx7QEucZbb/+ke9xPEUQ9d+mdOlaI+6fSKGYPo9JLHBWsCA45F1Z2AcbErdNk80 KcmEXy35iYyIc37u6dxmu8OOeKZHaoLdG2NVd7MHHs35bCoAyfgQ+3HX+rh68GCH1SqK OiWP4/mLVria9nLl17tcaRJ+CxS0F2hohqAOzBGHS3twJy8d+gieGMcCsEd7cksoXtBK E2kA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560335; x=1750165135; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v2fx/CQtVPLgqKAQGUIys9feEJNoyOh+nIa3K3QYL5w=; b=AyhwLfdWNLtqQ/FfZP8TbX+ieuLon222vNZuwDaZWZRaE/sl1PYV0ODURzn/XgQD8w kOxM3bQGj/uDBxLY6CnFB6cBpMQiauTyq/Pc7B4VFIY5tZpojpiDWmvA/LHbBeM29IVc Tzr2ezh1d+awqXf1FLBhuXWIPnr4HHjcD/mCBoBb2jCIfEY38gGVcnvtbuWmdchWced8 yiX1Q/is5LR3+2qoLK0OOE9v0vxqVkRx+VUbh389VByP4Odix/hXTo/aGfkzEnJhkhf2 YZl9xr35F0il6VFdG7SWGD3TuiDzutbrePmoCnaBfxkRpm0AFtcM9cNviBPcXRJhfC6F SLbQ== X-Forwarded-Encrypted: i=1; AJvYcCVk7FcB2tiaVxj6q5kTLmI13CqTxX4kA9Z/lNmxRFUT2in6XvSkD7owMlbvsF45PmEa34ci3TL5R1q26NU=@vger.kernel.org X-Gm-Message-State: AOJu0YyRIeEdHR9S4A4AwvAFVg70Rrz4x6xImYdZg3aHntL6VMij3KKi Lu0i+69kAaUl/nfQvqzDSJbaYNxOLVKlaq3KhJJ5gSUoz7lePy3LmUlONcRs4YZL9iI= X-Gm-Gg: ASbGncuycCr6cFbO51AYPyqXNnFND1xz8Rokl7r+zz54C5Gxx4Yw/KOgY3qBMsLBAs/ ehxADplNTUfYPpMAc6xyc35egpm2Dp3hteMyVOUizR6YSfi4FXPsJwJ4MPBPMwl21a7oks/8YeE PWez29MORvHygjmuITb+q7Ppa5vcDDVOFz6AWnb+t+yUCqKB/+fpjlJhPuhojgDe8c5oNvKvskl MdyKzGtPD4OZshpkO1H5PmsHehEhaWUjLWImDUzhc6HP0z4UxOw5ZAH7QTx0pXFqi0VyNF5DtBH 7hSY68/WQE5bjn5wpizzdO81ibsXc6Qt+qHOph20/6E4X3tCGLa3EA== X-Google-Smtp-Source: AGHT+IF+VHD3s49e6mkIi7baJjgBta7jhRVW7T+zJTDwVWSyLkMtpH6WZvfsMNjwBe2x2P104McBsQ== X-Received: by 2002:a05:6000:2287:b0:3a4:eec5:443d with SMTP id ffacd0b85a97d-3a53188e420mr12880272f8f.29.1749560334947; Tue, 10 Jun 2025 05:58:54 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:54 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:48 +0200 Subject: [PATCH 2/4] pinctrl: cherryview: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-2-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1642; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=sQCPPAeXHrozxhJ3sspmTsp1b+UMiXj/1Pgwkfb/eRo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwLNXY2X4JtFYzVdb+ziESNPH6YyzM7IUOtN gi3WIyKNViJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsCwAKCRARpy6gFHHX cgvCD/0ckNOwzxrinNTI5YFdtzkyxslAiEfJyvsHu8k75/3cSGjeB3N0HqgCdpkRegPYOWv5bP8 biZ/vhKj1VICyiSmi4Q6P3VLtPntDEf4uEpw6MOAs3/naM3eil1xknCxKJcwXKoif8fk3hgkEaR pJccbUa0S4Btrnnti+eBFVaFr0Tip/g2t87GFizMMCYwWdbys/zV8whbXSRRpFpTIXV/lZYgtbf tOLzWZvAq+eKzI04mDzjFLyojb3Xb94JVq/pt7vMpKeW9GkPw0LSrPinfQFM5y2K4L/MNfZhRly 3gtidAvCQsnWUYxlnUJwTflV7rdz2ZSxh0BInpTzKbk6XBxfQbE7mkk0AKErYiQBg5ILoYSMvYT zyM1+qOKOjm2d8Dobn+/q4J7TKLiOvSOW/FsCYE0hYu1a2uzO9lpKp//1Ls2k2BxeYRcv9mWts3 7diBoyTJHjPSEsJXn4vXQ1+BYrSaWBivDoLpSrkepbNqmmHWK22ChQ3C94y5NWD2VCRGGGtms5U IN5zSBYEOdFu3R3g0S8phWT1XmSTnxZw6JLsVu9SVFoRlpIp48JcraDCvL9Sabl2CWeqUnJv51F Vq8NBEnZrAETtqNW6KE0Fjqm4ZnwVp8utlHbdS/umHpPeikbrcAqN0qdcjflobRx8od2Ew+S+zH MTvu+FEhDl88m0w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-cherryview.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-cherryview.c b/drivers/pinctrl/i= ntel/pinctrl-cherryview.c index 69b18ce0f68588db30f7954a141641116c9094db..769e8c4102a5f64479201bd8f79= 1d3f155e949b0 100644 --- a/drivers/pinctrl/intel/pinctrl-cherryview.c +++ b/drivers/pinctrl/intel/pinctrl-cherryview.c @@ -1112,7 +1112,7 @@ static int chv_gpio_get(struct gpio_chip *chip, unsig= ned int offset) return !!(ctrl0 & CHV_PADCTRL0_GPIORXSTATE); } =20 -static void chv_gpio_set(struct gpio_chip *chip, unsigned int offset, int = value) +static int chv_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) { struct intel_pinctrl *pctrl =3D gpiochip_get_data(chip); u32 ctrl0; @@ -1127,6 +1127,8 @@ static void chv_gpio_set(struct gpio_chip *chip, unsi= gned int offset, int value) ctrl0 &=3D ~CHV_PADCTRL0_GPIOTXSTATE; =20 chv_writel(pctrl, offset, CHV_PADCTRL0, ctrl0); + + return 0; } =20 static int chv_gpio_get_direction(struct gpio_chip *chip, unsigned int off= set) @@ -1166,7 +1168,7 @@ static const struct gpio_chip chv_gpio_chip =3D { .direction_input =3D chv_gpio_direction_input, .direction_output =3D chv_gpio_direction_output, .get =3D chv_gpio_get, - .set =3D chv_gpio_set, + .set_rv =3D chv_gpio_set, }; =20 static void chv_gpio_irq_ack(struct irq_data *d) --=20 2.48.1 From nobody Sat Oct 11 12:08:51 2025 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8DDBF29899B for ; Tue, 10 Jun 2025 12:58:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560339; cv=none; b=aBRloW/nRvuSSPFWgX6tLFmfoth2pdYFp1CviZQlmfAsVu+iF0LFqPrBV1fbto5VVf4rn6hWe9IMMO+CUCwbsYQFYTDr5vJ2w7P3BiQgq+D3HLYrNAfLYwq84r07Qx+pRuiHH0K5puTTGdgBccVBW4tPV74tz2qRGY/ADt9C+Tg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560339; c=relaxed/simple; bh=17xCbJ24nw7sQxktnCslGe/MRxFJ2bFt5zYCSuRk9uM=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=E2fOoohKkyZuaLC4f/Nv8frQcmsmSr0GrRN+2KHCOFacrmQUrDlAe+DU1kzECkWAvGqcJZ5KXYzlbPL+gsCUY5geBRP5ovnBCDqEUotxtnX+gAH9vx6vj++9NuobKWkuqur+ShFxEshf8BxrjM4atoVRADqkyM7BUMIOIrL4Jec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=eeHJtNGO; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="eeHJtNGO" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-3a375e72473so2758612f8f.0 for ; Tue, 10 Jun 2025 05:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560336; x=1750165136; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=CP0pr1RnwJJZDVZHWlvpAZF1INYr5USAQasxBrkQ0FE=; b=eeHJtNGORp2c4gs30u1SpExUu5dyEWsoZcqeKqrVgUbC7cl3Co5kU5ZO8dGsZacQkr o/FyncMm1Ma9MlJJhz7RybCQm0Zb33lMX+fj7OgXLer/NLJPQ1qdOlw7kTvU2iSew8aO dunC/+9/vYOf4ESS3tKCpyoga76miKQC2rYvEhB69G4vCWAKT8YfJknvI/2jcpGVpZLk YrjC/iPczm0lJ2vSReaxR8PeER1Jr6OpDZ51qJ636KBIyfD1WKlGNmYk3t5w3wywSlSU T8rtAXp9p6hxClkx5jIrwDUkyfmFY4A5E4FwbZHPnvOnXeW9YG9NIGQUY+0QSkfVGzxC RHlQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560336; x=1750165136; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=CP0pr1RnwJJZDVZHWlvpAZF1INYr5USAQasxBrkQ0FE=; b=L/UvACYcxxtsmqq2IIFZYmUL/T2SZEij9eTaEzvwQ7ZD/VgsGoLjCi0gYBiMwK5eZp blJF2o08C4xqcEwB6H4k+gsM8cZ1+AebeCFybHASj0GL9n8deh6KqoVNuq2OgQ/AWxOt dw0H+onLraKQjH95kbHP+/QLy2Z3uMxNfgUiJOF6XBEwcEXA9URclu55i28ranavcXn2 dHgrwqdyU8WdxCcDFuUItHQW34m4F9VSecom/vzex+nb1vVoZZDVT7BDLbCIFYgNGJiz fg83H4VZTCMPj/ScomQbQgqTHE1uVnWMHBjBdV975jEiPWZT8PsH//+27+OmbH539CtB oFSw== X-Forwarded-Encrypted: i=1; AJvYcCXkvqf2MwKf1bPApIDC75kbC4Jik1jg8FHnF+T7gYbacz/QDbosAYavAfuqf5zKz5BPcUS+VGbYh/xISdA=@vger.kernel.org X-Gm-Message-State: AOJu0YwkdH+iarGfnoOT5A9ohgzlAWhk26ACt4QcqWkHcZ1ZSaWQsHDB FrYGylW4tdgb0o1RuT6APxHCuVbrLbbpnWCbaGMPol2zQiiiQC5m8i1TXBsBcFmcjZY= X-Gm-Gg: ASbGncv6TpA6Ceim9Ai8pta0fPmInEyqXX9knAWKdUzV9wng4h6n3tZBzJT9xP4QbFt L5N9tw/XJ44yBPVdNeaYen4T9P0Ac/OeTILDmAqhavx8ulJxxb+9ITzMfmvH2By0BRoiTEh0c85 +CLGFJ+z4mrPoJ9THZnd4mV85g6fny07YLX9JME4U3Kd5Z/7i4+XcbUya88mnE5V0wjHpBKRu7u n7qQ1HgzIfoByU1eGSZe15WnR4Lc7tyhZljN1ovZY4lYsbypyT0/UdAh1arOWtopdQy9d2zpGFR GTX/vaz33M6XgL4ZWYO/PfwVqvqfyRT5ap6EWjY/jZ8HN0lJD1HlQw== X-Google-Smtp-Source: AGHT+IExRR4e9dlTcGN0ufmc1c99ii86pLeqcP2EuDaO9z8bj9vuw25+GX3iaPffRFFpJyv3B0e5Iw== X-Received: by 2002:a5d:5846:0:b0:3a4:e6c6:b8b1 with SMTP id ffacd0b85a97d-3a53189b3f0mr13321169f8f.17.1749560335886; Tue, 10 Jun 2025 05:58:55 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:55 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:49 +0200 Subject: [PATCH 3/4] pinctrl: intel: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-3-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2394; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=ZGNRH3kU8gUncy2AaRa7wuxQkW9WPpCNaL0R2YfhoJI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwMdKsPhgfXUHquenNk6O7A/jRl4HMET9q+Q vCVfzIewKOJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsDAAKCRARpy6gFHHX cn0mEACuGd8lWVugJKtZTsp2ckp+ZOy5qIkiOu0UNfHYwOVPLUVQqrU4nIf7sFW5kEcLyb2GVmR l17L0oGHkynm2j9qDNkIpDcy7wAgZKMELOxF0DDtrrk0dZDahrNR+7ovYixYvIivlcZ6ViMyBnu g/PmF/bj4bkm3+tGcVcx7KnZroUmn3ygekpd7WI9+/VwnqatFqD7hNRoFfcvsaDHxiDs9luvYli RKAoInuHzG+O81vY7hTSjEeajfxLR0oP7T3MX5Rcn9LkX7XpUWhjJS/MmOvYpXXbMcv5O8xXMGi URhroPZQajcaRMAW8MKbcurtmRRxEJrwLczNNXAd5MrIlN33/SY1Fp8Sifr/Fe1EpbfXy9FQFHx eVXJ7mHNAOmPjviFKkOXQVpzczVkmR8i8ccjUttwHIcqTtLk6DdcWhW5COLuj6t8EjTPVYtLyN+ OZ0qesKfituFBYF6U+s+BrlL593yQLFtl+DDqvTWRawXKDmIkRYH7oSfMzWYiiXQQbka83/scO3 8A73lDmyky/V4FBpz7j3JSYhQ636mPn0FBoRt5ZiJNUUzdbBrA+T/OoZHnuxKt/p0JgJtGpUPUI qcXE1fGfrq9c98zvbkgzqlJIvppyHPYRTQpfiswCO5dTaIYmQDhideWchlvW1x+Ohm8IMDZHy7o Oc65rVBuouZ/J+g== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-intel.c | 19 +++++++++++++------ 1 file changed, 13 insertions(+), 6 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-intel.c b/drivers/pinctrl/intel/= pinctrl-intel.c index d889c7c878e2d57eb075f4147a3eb2e2ae05ec5b..846b25ed1cc44cf9549aafc6319= 2c80d8e66a797 100644 --- a/drivers/pinctrl/intel/pinctrl-intel.c +++ b/drivers/pinctrl/intel/pinctrl-intel.c @@ -1033,8 +1033,8 @@ static int intel_gpio_get(struct gpio_chip *chip, uns= igned int offset) return !!(padcfg0 & PADCFG0_GPIORXSTATE); } =20 -static void intel_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int intel_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct intel_pinctrl *pctrl =3D gpiochip_get_data(chip); void __iomem *reg; @@ -1043,11 +1043,11 @@ static void intel_gpio_set(struct gpio_chip *chip, = unsigned int offset, =20 pin =3D intel_gpio_to_pin(pctrl, offset, NULL, NULL); if (pin < 0) - return; + return -EINVAL; =20 reg =3D intel_get_padcfg(pctrl, pin, PADCFG0); if (!reg) - return; + return -EINVAL; =20 guard(raw_spinlock_irqsave)(&pctrl->lock); =20 @@ -1057,6 +1057,8 @@ static void intel_gpio_set(struct gpio_chip *chip, un= signed int offset, else padcfg0 &=3D ~PADCFG0_GPIOTXSTATE; writel(padcfg0, reg); + + return 0; } =20 static int intel_gpio_get_direction(struct gpio_chip *chip, unsigned int o= ffset) @@ -1094,7 +1096,12 @@ static int intel_gpio_direction_input(struct gpio_ch= ip *chip, unsigned int offse static int intel_gpio_direction_output(struct gpio_chip *chip, unsigned in= t offset, int value) { - intel_gpio_set(chip, offset, value); + int ret; + + ret =3D intel_gpio_set(chip, offset, value); + if (ret) + return ret; + return pinctrl_gpio_direction_output(chip, offset); } =20 @@ -1106,7 +1113,7 @@ static const struct gpio_chip intel_gpio_chip =3D { .direction_input =3D intel_gpio_direction_input, .direction_output =3D intel_gpio_direction_output, .get =3D intel_gpio_get, - .set =3D intel_gpio_set, + .set_rv =3D intel_gpio_set, .set_config =3D gpiochip_generic_config, }; =20 --=20 2.48.1 From nobody Sat Oct 11 12:08:51 2025 Received: from mail-wm1-f45.google.com (mail-wm1-f45.google.com [209.85.128.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B07FE2BD03A for ; Tue, 10 Jun 2025 12:58:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560340; cv=none; b=FYJGfSMTb1NK3mqObZLpXRDRdVIvgW2RwJV3uKyws6zJRyuNSyweYcGGprrEXBO/kaVsHFmifniiXhVZE1Bt+DyYyQTpIne/m+Mysbwa8KYvkXTuyj7y1QK0xS/IjT2bi5CvksXP7d9QJLdIIHSzK5bh0PjAXf3GYDe79DbL95E= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1749560340; c=relaxed/simple; bh=oTpSgC31PAVO+aE1pNh07rDeXdPKl1jobKVG3g/UHhs=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gmiyftdKFrGBdWIMMy6lpkE2DFUqIns7a9WBIM0U/+EtFodGWYEw5WRSwRhXk4UY46aK/kHDMpIsh6ldu6FFzAyJz9pWPC0sPjuKR1ginivC7rE7F6TTEEf9nvVq6nTQRak1lmrIK/cHk9R5zwAW782/bnGKNqSTjTQ0TgdQsds= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=En33Eu96; arc=none smtp.client-ip=209.85.128.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="En33Eu96" Received: by mail-wm1-f45.google.com with SMTP id 5b1f17b1804b1-451d6ade159so45864815e9.1 for ; Tue, 10 Jun 2025 05:58:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1749560337; x=1750165137; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=zrVIKmBA62tYbIrJangPWC0arTIQiP6CcWv/1Ljn/5A=; b=En33Eu96zcymiNC2h35W1Xal+iA+QRvuk35z/U0AcTO9tvb/MryxRirrfoQL2EcIr9 11LvL0KfZdQYgqMs+029SghHUo5a+klA9s7JAYEP9oKPam8SoIfximmuJ8R/4/MT3nmf 0Nm3esTDr4x6tC5xmAHKdF3CbCbVPx3V1jCSskYl//rpZtsq4+B8Iza5OmHM2nn+lw7B 0Z8BTSro/QQkwKP3EXvTEfh3kld3tlnDQ4yhRPVBZ7B4H4t/Dss2oSkB34LhKk72L1Lp eMHS02MDIt+2oKSgx2ZVIr06f9iho82KffdFpZjzvPkhvcrQiVat3d0YSLjSmxxgYc1i VVJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749560337; x=1750165137; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zrVIKmBA62tYbIrJangPWC0arTIQiP6CcWv/1Ljn/5A=; b=Y+01eRWu3LsoaNrx8Dcnf++7fkisQDNix0OZgSy3JM2owbKPpA8KYhdNd5hEo2ulbr pUjBZCj96EbSR7BE+lVLgKElrmFtURRbGgau0rjF8BME8fn/N2f3PbT9Zmb4oul+VqKP 0DEtwEluw48gyrdInPqpJSvJcG9JkYTAk5KGxRK8ZJXCljck7nB1UT7n5AEQF5QwOkWR G19KKDs+MJnicGwyUt5sk8gu+G+vEy++WLUlzFxU0NipAOM2lv4MpNzOAFgZFKfarIaT SSy4dTbxWZsx2gEFSy29/It4thMaAZcIjNWtGexxs3FM+bjNB5m5xNRc7gCSp6HTQCqN x8ZA== X-Forwarded-Encrypted: i=1; AJvYcCUwX2zQHUCJ40azDXpDzyCZSPkNDBUG9ENkvxTny7FR+mmvX7YhfHnqBeE8UzA2ZtTrGcAp5k+HIPUHCR4=@vger.kernel.org X-Gm-Message-State: AOJu0YzU/gRIpuSaVWjU8QPOjId8TLQ54nu1nBYn2bMHn6eeZe5LJ96R m/B6pg17AcqMMjj3pgD1q4ir8pIwCvbfvw1hbYIJKBM1kTUv6hQvWZxntHuISGL0Vbw= X-Gm-Gg: ASbGncuecsm6eHAOosnSX55qJGYtcqTjzQHlEh80fukY0L7aNcFhkcPi63C98dymAjM SPapOWrHxJRmw5yLShsz0jdIKmTKE4mZyRH4S7iBfkVARwW25yI8huhRhbXpLzb9WnWqwiUpyRq P+S1e+aDX7u5BCFVpkES/OxfERrFIgnIKQHd6SO9OVY20xgWtXPzSwnM9uJd5POzatr9OyKCMp1 YxijIAU8v8g8oNnRagZtACYw8gYx7LtNvDW4HwMOatRGt8KbGWdpzFFikj5PDHsdsaq8DlsoPZy UYCGFYVFFenEEcWvZ4vIZA9Kd+IplOy3h9RAP4BXpCEjjOUu5PY9rQ== X-Google-Smtp-Source: AGHT+IFdJ91jmVZS5b+CzAH2GS7Lj2zbRrdX46WwyeQXZY1GxVzkN/B3QcrAI/8YtMDq52owlFoArg== X-Received: by 2002:a05:600c:1907:b0:43d:db5:7af8 with SMTP id 5b1f17b1804b1-45201414a65mr127985455e9.21.1749560336865; Tue, 10 Jun 2025 05:58:56 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:4d:e52b:812d:eb7c]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45209ce17f9sm143671135e9.11.2025.06.10.05.58.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jun 2025 05:58:56 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 10 Jun 2025 14:58:50 +0200 Subject: [PATCH 4/4] pinctrl: lynxpoint: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250610-gpiochip-set-rv-pinctrl-intel-v1-4-d7a773ff864e@linaro.org> References: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> In-Reply-To: <20250610-gpiochip-set-rv-pinctrl-intel-v1-0-d7a773ff864e@linaro.org> To: Mika Westerberg , Andy Shevchenko , Linus Walleij , Bartosz Golaszewski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1747; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=pi3gOCuYMaPz/JFg+eWCQsR8jJCkFM1RNWFtAInCAqk=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBoSCwMTeUKdwG9/vVWjkQR0UDigBpG37Jv++1xL lBW+SFGjR6JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCaEgsDAAKCRARpy6gFHHX cih7D/0WJnBIQjNu7CfhOsitHfBqojk2Xrt7W0ojZT/JR/BoihIxylpdRHVhjnAICLkRF+TFS7R N8cNsWHs0YvmW8RXDA6hraMDhrtPxMrK5SCIStK0Al8WwaY+tNXfapYfx/A9c2ZAIQ88hW5JB3X ZO2TLU4+dDdYorYL0pVizwXYHpmATBxLJ5BJShkJs89VRAOOGtznAfRheKiNt+47uNa8hHB2HOZ V6gpfLVhrNQV3qQvpO2AyMehduOtEF3UFI0ilJoW6pdRWl/ed425LwS3fpae3pq0EsoRDlZUSOd 1xqlmO+Lz6bHQROaHJTL7fFtVOcMFHLQx8fkcFzVY66smtmxqP7BSa5Q780wvwKlzV4wwHa5XeS gxs/t5VcqgQBQ7vdUlG4sbznvIVvt7LdcRaipOH1QYvGLUR3UOq0XumfUTTif90pbnrJLuXT1yb MhLkCRPFewQPf47JaIm6TyATI8YdTEcdve0nBboGY4riH80PaQnBJOLgPgyaLWlxavjpZP4j+RU hlUVhglebjCFkQwIbdeDEwYkIMHuZGEwzEU0/zYuROSletrrSh98wPa0ceUNnMNdBt0A1CcJeqz aipK/5PNcKz6WfgVwao5uBRPxFy5mtKi/s8Bh+jEsMNk1/yg6GEAyw5veWppvTaigiX1rzXOyp4 OZDe7EFboNR7XZA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Acked-by: Mika Westerberg --- drivers/pinctrl/intel/pinctrl-lynxpoint.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pinctrl/intel/pinctrl-lynxpoint.c b/drivers/pinctrl/in= tel/pinctrl-lynxpoint.c index ac5459a4c63e054ae4dd975f0a19112e4382aa99..5d4a5dd493d1bfbbc6051163758= fd8a9341b43a8 100644 --- a/drivers/pinctrl/intel/pinctrl-lynxpoint.c +++ b/drivers/pinctrl/intel/pinctrl-lynxpoint.c @@ -503,7 +503,7 @@ static int lp_gpio_get(struct gpio_chip *chip, unsigned= int offset) return !!(ioread32(reg) & IN_LVL_BIT); } =20 -static void lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int v= alue) +static int lp_gpio_set(struct gpio_chip *chip, unsigned int offset, int va= lue) { struct intel_pinctrl *lg =3D gpiochip_get_data(chip); void __iomem *reg =3D lp_gpio_reg(chip, offset, LP_CONFIG1); @@ -514,6 +514,8 @@ static void lp_gpio_set(struct gpio_chip *chip, unsigne= d int offset, int value) iowrite32(ioread32(reg) | OUT_LVL_BIT, reg); else iowrite32(ioread32(reg) & ~OUT_LVL_BIT, reg); + + return 0; } =20 static int lp_gpio_direction_input(struct gpio_chip *chip, unsigned int of= fset) @@ -775,7 +777,7 @@ static int lp_gpio_probe(struct platform_device *pdev) gc->direction_input =3D lp_gpio_direction_input; gc->direction_output =3D lp_gpio_direction_output; gc->get =3D lp_gpio_get; - gc->set =3D lp_gpio_set; + gc->set_rv =3D lp_gpio_set; gc->set_config =3D gpiochip_generic_config; gc->get_direction =3D lp_gpio_get_direction; gc->base =3D -1; --=20 2.48.1