.../bindings/remoteproc/qcom,sm8350-pas.yaml | 54 +- arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 + .../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 + arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 645 ++++++++++++--------- 4 files changed, 414 insertions(+), 297 deletions(-)
SC8280XP features a SLPI, much like its distant relative, SM8350.
This series adds the bindings and dt node for it (also cleaning up the
DTSI in meantime)
Signed-off-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
---
Changes in v2:
- Added FastRPC nodes
- Added the X13s/CRD patches
- Link to v1: https://lore.kernel.org/r/20250503-topic-8280_slpi-v1-0-9400a35574f7@oss.qualcomm.com
---
Dmitry Baryshkov (1):
arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP
Konrad Dybcio (4):
dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP
arm64: dts: qcom: sc8280xp: Fix node order
arm64: dts: qcom: sc8280xp: Add SLPI
arm64: dts: qcom: sc8280xp-crd: Enable SLPI
.../bindings/remoteproc/qcom,sm8350-pas.yaml | 54 +-
arch/arm64/boot/dts/qcom/sc8280xp-crd.dts | 6 +
.../dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 6 +
arch/arm64/boot/dts/qcom/sc8280xp.dtsi | 645 ++++++++++++---------
4 files changed, 414 insertions(+), 297 deletions(-)
---
base-commit: edef457004774e598fc4c1b7d1d4f0bcd9d0bb30
change-id: 20250502-topic-8280_slpi-d152cdad893f
Best regards,
--
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
On Sat, May 17, 2025 at 07:27:49PM +0200, Konrad Dybcio wrote: > SC8280XP features a SLPI, much like its distant relative, SM8350. Please get into the habit of spelling out *and* explaining internal Qualcomm acronyms like "SLPI" so that your cover letter and commit messages makes sense to people outside of Qualcomm. Also say something about whether and how this is useful for anyone currently or if it, for example, depends on Qualcomm proprietary user space bits. > Dmitry Baryshkov (1): > arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP At first I was worried that missing firmware could cause issues here (e.g. drivers not reaching sync state as with venus), but Lenovo has indeed released the SLPI firmware already. Are there any other potential downsides to enabling this (e.g. before anyone can actually use the sensors)? > Konrad Dybcio (4): > dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP > arm64: dts: qcom: sc8280xp: Fix node order > arm64: dts: qcom: sc8280xp: Add SLPI > arm64: dts: qcom: sc8280xp-crd: Enable SLPI Without firmware this results in errors like: remoteproc remoteproc0: slpi is available remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 remoteproc remoteproc0: powering up slpi remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 remoteproc remoteproc0: request_firmware failed: -2 but enabling for the CRD reference design and requiring users (read: developers) to copy it from Windows should be OK. Johan
On 5/19/25 11:35 AM, Johan Hovold wrote: > On Sat, May 17, 2025 at 07:27:49PM +0200, Konrad Dybcio wrote: >> SC8280XP features a SLPI, much like its distant relative, SM8350. > > Please get into the habit of spelling out *and* explaining internal > Qualcomm acronyms like "SLPI" so that your cover letter and commit > messages makes sense to people outside of Qualcomm. It's difficult to judge which acronyms are known when half the words I type on my other computer are TLAs.. > > Also say something about whether and how this is useful for anyone > currently or if it, for example, depends on Qualcomm proprietary user > space bits. > >> Dmitry Baryshkov (1): >> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP > > At first I was worried that missing firmware could cause issues here > (e.g. drivers not reaching sync state as with venus), but Lenovo has > indeed released the SLPI firmware already. > > Are there any other potential downsides to enabling this (e.g. before > anyone can actually use the sensors)? It's probably only upsides resulting from keeping the rproc in a known state > >> Konrad Dybcio (4): >> dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP >> arm64: dts: qcom: sc8280xp: Fix node order >> arm64: dts: qcom: sc8280xp: Add SLPI > >> arm64: dts: qcom: sc8280xp-crd: Enable SLPI > > Without firmware this results in errors like: > > remoteproc remoteproc0: slpi is available > remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 > remoteproc remoteproc0: powering up slpi > remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 > remoteproc remoteproc0: request_firmware failed: -2 > > but enabling for the CRD reference design and requiring users (read: > developers) to copy it from Windows should be OK. We shouldn't expect non-developers to have the CRD on hand, right? ;)
On Tue, May 20, 2025 at 04:29:18PM +0200, Konrad Dybcio wrote: > On 5/19/25 11:35 AM, Johan Hovold wrote: > > On Sat, May 17, 2025 at 07:27:49PM +0200, Konrad Dybcio wrote: > >> Dmitry Baryshkov (1): > >> arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP > > > > At first I was worried that missing firmware could cause issues here > > (e.g. drivers not reaching sync state as with venus), but Lenovo has > > indeed released the SLPI firmware already. > >> Konrad Dybcio (4): > >> dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP > >> arm64: dts: qcom: sc8280xp: Fix node order > >> arm64: dts: qcom: sc8280xp: Add SLPI > > > >> arm64: dts: qcom: sc8280xp-crd: Enable SLPI > > > > Without firmware this results in errors like: > > > > remoteproc remoteproc0: slpi is available > > remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 > > remoteproc remoteproc0: powering up slpi > > remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 > > remoteproc remoteproc0: request_firmware failed: -2 > > > > but enabling for the CRD reference design and requiring users (read: > > developers) to copy it from Windows should be OK. > > We shouldn't expect non-developers to have the CRD on hand, right? ;) That was my point: requiring user of the CRD to install firmware manually is fine (e.g. as they would all be developers and currently all firmware for the CRD needs to be copied from Windows anyway). But we should not enable things like venus (that can prevent the interconnect driver from reaching the sync state) on the X13s which has lots of regular users until the corresponding firmware has been released and is in linux-firmware. Johan
On 20/05/2025 17:29, Konrad Dybcio wrote: > On 5/19/25 11:35 AM, Johan Hovold wrote: >> On Sat, May 17, 2025 at 07:27:49PM +0200, Konrad Dybcio wrote: > >> >>> Konrad Dybcio (4): >>> dt-bindings: remoteproc: qcom,sm8350-pas: Add SC8280XP >>> arm64: dts: qcom: sc8280xp: Fix node order >>> arm64: dts: qcom: sc8280xp: Add SLPI >> >>> arm64: dts: qcom: sc8280xp-crd: Enable SLPI >> >> Without firmware this results in errors like: >> >> remoteproc remoteproc0: slpi is available >> remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 >> remoteproc remoteproc0: powering up slpi >> remoteproc remoteproc0: Direct firmware load for qcom/sc8280xp/qcslpi8280.mbn failed with error -2 >> remoteproc remoteproc0: request_firmware failed: -2 >> >> but enabling for the CRD reference design and requiring users (read: >> developers) to copy it from Windows should be OK. > > We shouldn't expect non-developers to have the CRD on hand, right? ;) Non-developers without Windows can extract the firmware from the corresponding cabinet file. -- With best wishes Dmitry
On Sat, 17 May 2025 19:27:49 +0200, Konrad Dybcio wrote:
> SC8280XP features a SLPI, much like its distant relative, SM8350.
>
> This series adds the bindings and dt node for it (also cleaning up the
> DTSI in meantime)
>
>
Applied, thanks!
[2/5] arm64: dts: qcom: sc8280xp: Fix node order
commit: 9522803addbee74269245259fecbb33d01a4a796
[3/5] arm64: dts: qcom: sc8280xp: Add SLPI
commit: d6470588beafdfebd84c857b78473db6388832a1
[4/5] arm64: dts: qcom: sc8280xp-lenovo-thinkpad-x13s: enable sensors DSP
commit: f5421c52983865c32eef72c4585234d043dd980c
[5/5] arm64: dts: qcom: sc8280xp-crd: Enable SLPI
commit: f285543c5a00b4329a321edfd674010c874e3862
Best regards,
--
Bjorn Andersson <andersson@kernel.org>
© 2016 - 2025 Red Hat, Inc.