tools/testing/selftests/ublk/Makefile | 4 +++- tools/testing/selftests/ublk/kublk.h | 1 - tools/testing/selftests/ublk/test_generic_06.sh | 2 +- 3 files changed, 4 insertions(+), 3 deletions(-)
Fix some more minor issues in ublk selftests.
The first patch is from
https://lore.kernel.org/linux-block/20250423-ublk_selftests-v1-0-7d060e260e76@purestorage.com/
with a modification requested by Jens. The others are new.
Signed-off-by: Uday Shankar <ushankar@purestorage.com>
---
Uday Shankar (3):
selftests: ublk: kublk: build with -Werror iff CONFIG_WERROR=y
selftests: ublk: make test_generic_06 silent on success
selftests: ublk: kublk: fix include path
tools/testing/selftests/ublk/Makefile | 4 +++-
tools/testing/selftests/ublk/kublk.h | 1 -
tools/testing/selftests/ublk/test_generic_06.sh | 2 +-
3 files changed, 4 insertions(+), 3 deletions(-)
---
base-commit: 53ec1abce79c986dc59e59d0c60d00088bcdf32a
change-id: 20250428-ublk_selftests-983240d3a325
Best regards,
--
Uday Shankar <ushankar@purestorage.com>
Hi Jens, Can you take a look at Ming's comment on the first patch and merge the set if things look good? I can rebase/repost it as needed. Thanks, Uday
On Mon, May 05, 2025 at 02:31:40PM -0600, Uday Shankar wrote: > Hi Jens, > > Can you take a look at Ming's comment on the first patch and merge the > set if things look good? I can rebase/repost it as needed. Bleh, sorry, I meant to send this as a reply to v2: https://lore.kernel.org/linux-block/20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com/
On 5/5/25 2:34 PM, Uday Shankar wrote: > On Mon, May 05, 2025 at 02:31:40PM -0600, Uday Shankar wrote: >> Hi Jens, >> >> Can you take a look at Ming's comment on the first patch and merge the >> set if things look good? I can rebase/repost it as needed. > > Bleh, sorry, I meant to send this as a reply to v2: > > https://lore.kernel.org/linux-block/20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com/ Let's give Ming a chance to review v2, then I can get it queued up. -- Jens Axboe
On Mon, May 05, 2025 at 04:44:19PM -0600, Jens Axboe wrote: > On 5/5/25 2:34 PM, Uday Shankar wrote: > > On Mon, May 05, 2025 at 02:31:40PM -0600, Uday Shankar wrote: > >> Hi Jens, > >> > >> Can you take a look at Ming's comment on the first patch and merge the > >> set if things look good? I can rebase/repost it as needed. > > > > Bleh, sorry, I meant to send this as a reply to v2: > > > > https://lore.kernel.org/linux-block/20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com/ > > Let's give Ming a chance to review v2, then I can get it queued up. It looks like he has already reviewed all the patches in the set.
On 5/5/25 4:53 PM, Uday Shankar wrote: > On Mon, May 05, 2025 at 04:44:19PM -0600, Jens Axboe wrote: >> On 5/5/25 2:34 PM, Uday Shankar wrote: >>> On Mon, May 05, 2025 at 02:31:40PM -0600, Uday Shankar wrote: >>>> Hi Jens, >>>> >>>> Can you take a look at Ming's comment on the first patch and merge the >>>> set if things look good? I can rebase/repost it as needed. >>> >>> Bleh, sorry, I meant to send this as a reply to v2: >>> >>> https://lore.kernel.org/linux-block/20250429-ublk_selftests-v2-0-e970b6d9e4f4@purestorage.com/ >> >> Let's give Ming a chance to review v2, then I can get it queued up. > > It looks like he has already reviewed all the patches in the set. You're right, was looking at the other v2 that you posted today. Now queued up! -- Jens Axboe
© 2016 - 2026 Red Hat, Inc.