From nobody Mon Feb 9 13:59:58 2026 Received: from mail-pl1-f226.google.com (mail-pl1-f226.google.com [209.85.214.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 368F6203716 for ; Mon, 28 Apr 2025 23:10:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745881845; cv=none; b=LDM1h+WzpTbonuT7YprnFzf/EiEbyiLhk8dTNQgPuc3EPzpFpOkV7/VT90bR/OJ2nRscGvU0ZvFKIYO0Z7cx8Db4+GU/WZi4SBDd0BfYQ3HNA/AIOZUPBnb9HiMAwhAukR6/68ePnB42IH77pqVTXIZDZH5iWUPx37Sik7mgIt0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745881845; c=relaxed/simple; bh=5R1ihXWNblpTcigqrOrVvxreW0nOHeJ3fH4HtMTNR2o=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=FFa2YS25SnJoDxn3H8ivIAi6uGc3f+ohKXbuEFFhrSrkrM3WCizV+P6Nac4AYUXLih4gWSbAaKy/Gb+Jq1LrIu2UN8vbBpYTTnzRsjE8SPfUegrQJ91hBX54N7cIL91XI5OyOT+km8m1MBcL9ubGAIlUKPvKUJw6RbQK53aeocY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=AD1oepuu; arc=none smtp.client-ip=209.85.214.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="AD1oepuu" Received: by mail-pl1-f226.google.com with SMTP id d9443c01a7336-22d95f0dda4so79679255ad.2 for ; Mon, 28 Apr 2025 16:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1745881842; x=1746486642; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=yN6X8qy6iIXBeRkDCjdD0w88qJ6dcCiPtrqiszUMgAY=; b=AD1oepuu0paRzg6wueEwG+FWx0b0H/PPA7MRK5MOvWF+apvUqAxkD0pj40F5oWvqIk FgPL4hxJI5cOMfO4a4wcEga+8JC7uWbCksIknxRel7aTj39VA4A+xk5pQGFMHjp52aD2 4DoMArpUz1+OtD7HEwvHqShjvo5B4T2u/q5FBthbQsrwDVALlzWiHLQ3VFGxe5DbHSFQ Bo01dyN/fQViqn34hPG2T/wLsO2BgRJIynTwO84LAIzFyvrLKVjXSimdKgypGsJvCQKN gtK8sA1QB2Sw7n2HmIJtO/FphR3xVNrbdT2TuuJFUQbgabzPr6LkCpXVaCnsH5uz+Nsy 8DQQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745881842; x=1746486642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=yN6X8qy6iIXBeRkDCjdD0w88qJ6dcCiPtrqiszUMgAY=; b=Q9OY+p8DsUyDohX2Fwc7ph3CDODNajMuImQ9kPW2CM7pPlGWxHQrM4em5yfopMKjGP ndLauhPX44slQIU3HuUsBv5FNKalQfEljvX/eM/weDfjJTDiBvTOpPqUF/lrgBak1+R5 xIrsdXHEAx5bmKx5wI3nMtItHWoJ9TW8/xzIv2YMldNgbofk0hDPpXKbWBJaJtVRPPI7 gMGAXOoSpk6zJDDrlchOiGBe4y/sqCpjNMdoyuI0eGHUyffVhdpq0zVCZK6Jb7+1Z+MM fK6AwQSVxZXGJDQu9Zzt3kQkFyCECjorOTB+TgoveIBJti9mTppnfk9HmUNAWmEo4DEV U9Rg== X-Forwarded-Encrypted: i=1; AJvYcCU8NLVIMb6jvJYuymGczp8BEEjAk46Oaw30Q2Q+UDoSUM9NliuqmBogDEbnrkXhdnd7VaKFzI98M2bJbi4=@vger.kernel.org X-Gm-Message-State: AOJu0YxH9OL0t7nBmCGz5lg8SnaZVHrzeEsSnFcxjJybEmXWmATpF1kg 2BoKmP2xHVhZH6T37hwuv1E87EXS4P7hIUKAtLTfXRIWNyw/45kLJ/cpmOTWok41g79tdWwsZyQ BXm0UPoCeyGk9DwkuoYlOHH3fCdLQTwfyT+KNn5N33Mq0RtmM X-Gm-Gg: ASbGncuwMnGKM7zbMckew87JwuvJQxxkgeBkkWRPY3faipvh8fseBk6p3i5cZqZZ6M0 OvUkr5UYQc3WtJA1JKeeQeqZiC+7YXJjjef5zG8KVAUAczJgjN79zxM8UeMbqM5IGk4cCqbynGm jJNqLKF/fyOI68Wz4COFBQ2bPHmc6RNv7mcWc5alKF7xWjg56HedVxiUu3yyoFArGdcH3ijWmqu 5adfBXbo62uUUn5zl65gaDNkWZ29rS/yP5u0bdmxgZQitEW8B4M9FDn8wQJ8pRRSPG025bvv/0Q hMfjfnBh6LL4acVnsIM0CrRbGImrApk= X-Google-Smtp-Source: AGHT+IGLl7TOqKFNXF5fmwjy9nOE7m0hNA10OLnBEeDkYFZQHcoN4UwcAMLHuXqjIk6lJT7AmRIwF17PnTRk X-Received: by 2002:a17:903:2284:b0:216:3d72:1712 with SMTP id d9443c01a7336-22de7024ab6mr13691355ad.48.1745881842017; Mon, 28 Apr 2025 16:10:42 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([2620:125:9017:12:36:3:5:0]) by smtp-relay.gmail.com with ESMTPS id d9443c01a7336-22db4de9303sm12508135ad.45.2025.04.28.16.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 16:10:42 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-ushankar.dev.purestorage.com (dev-ushankar.dev.purestorage.com [10.7.70.36]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 4008734065D; Mon, 28 Apr 2025 17:10:41 -0600 (MDT) Received: by dev-ushankar.dev.purestorage.com (Postfix, from userid 1557716368) id 35C66E40B9B; Mon, 28 Apr 2025 17:10:41 -0600 (MDT) From: Uday Shankar Date: Mon, 28 Apr 2025 17:10:20 -0600 Subject: [PATCH 1/3] selftests: ublk: kublk: build with -Werror iff CONFIG_WERROR=y Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-ublk_selftests-v1-1-5795f7b00cda@purestorage.com> References: <20250428-ublk_selftests-v1-0-5795f7b00cda@purestorage.com> In-Reply-To: <20250428-ublk_selftests-v1-0-5795f7b00cda@purestorage.com> To: Ming Lei , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Shankar X-Mailer: b4 0.14.2 Compiler warnings can catch bugs at compile time. They can also produce annoying false positives. Due to this duality, the kernel provides CONFIG_WERROR so that the developer can choose whether or not they want compiler warnings to fail the build. Use this same config options to control whether or not warnings in building kublk fail its build. Signed-off-by: Uday Shankar --- tools/testing/selftests/ublk/Makefile | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/testing/selftests/ublk/Makefile b/tools/testing/selftest= s/ublk/Makefile index ec4624a283bce2ebeed80509be6573c1b7a3623d..86474cfe8d03b2df3f8c9bc1a59= 02701a0f72f58 100644 --- a/tools/testing/selftests/ublk/Makefile +++ b/tools/testing/selftests/ublk/Makefile @@ -1,6 +1,8 @@ # SPDX-License-Identifier: GPL-2.0 =20 -CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall -I $(top_srcdir) +CONFIG =3D $(top_srcdir)/include/config/auto.conf +WERROR =3D $(if $(shell grep CONFIG_WERROR=3Dy ${CONFIG}),-Werror,) +CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall ${WERROR} -I $(top_srcdir) LDLIBS +=3D -lpthread -lm -luring =20 TEST_PROGS :=3D test_generic_01.sh --=20 2.34.1 From nobody Mon Feb 9 13:59:58 2026 Received: from mail-vk1-f226.google.com (mail-vk1-f226.google.com [209.85.221.226]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 37D8A212FBC for ; Mon, 28 Apr 2025 23:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.226 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745881846; cv=none; b=miMZ+3MQ3LEVQVS5ixfpask0MpEvJrNUVzK7dhpo7QrUWzu3ur43DLJ1EgBp3dfh2+iYx3cctpfbHCbwgjw8Y8iHWlcJG0n1QVnyN6UcurXLu+h3A90hTq3Z/3ut103nB0A8ET1GP02UYPoZ9nDaPi/ntcMlF9Chj/zHQ5bxm+Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745881846; c=relaxed/simple; bh=7qGhW0lObjamK2vkejF8Y9mV1B303QKOHDtBCxKSc/k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=cssfx9/OmY+/ZqqmYLv253LW44qE8HE1wfJ719eE1cZQztwdD/gO50fx47Cb+oi6O517QOXuLcoT4HuEYKNmW6p1STH2TE751Fvr6uOTP5MQNLXW4R2TopEKoY5x0Pi4Ve2QYI1w4EvJW7Z//ItbrE0h+VHlAmi8M+mZwFl4bNg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=Qwg3d+sz; arc=none smtp.client-ip=209.85.221.226 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="Qwg3d+sz" Received: by mail-vk1-f226.google.com with SMTP id 71dfb90a1353d-52446b21cfdso2192718e0c.1 for ; Mon, 28 Apr 2025 16:10:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1745881842; x=1746486642; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=Bmz20arlb8RcX2p20KSIo8CkAzDOxhHq99zIjNZrVW8=; b=Qwg3d+szDdvNKGHasY0mJtoELugv8k19HwrB4bG+7fHmF6w/ZdO3bEr2mePCzJtFld 1ZmMqiHlU4FgFJXt0j438mbMt/ujwSl6zN5Barz8N2dCmbe6lCAQjo7JCF0CU5AuNrFg qsyJJdjUCc6JW+5529Q3piA1teaADBVRoIsMe45tCPzTzpW6pmeaMAHlv4b1sLBSWxh9 8Ivybg2vQw6TXY4HifMoefoZrVcf1/nMwjuYjO6i3HyVPow4WW5OBYDhlt5VM2r7ybOn keEZYpueQUFdr4VfY8GB4btyHA9VCwFUZgD10GHBTXWVf6fOsj8mCIdTmZIwk9ziLhIs p1bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745881842; x=1746486642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Bmz20arlb8RcX2p20KSIo8CkAzDOxhHq99zIjNZrVW8=; b=Rc3R9ZQdoYN00wHgfnoc9+qZ7Kw71O8fOV/tgRhiak6GxtaX9o1yoc7ikr20QDcBe1 m1qKP+SfbrcqmdIHwmINY3OiRpz+ZguV8v6lI0UBFq3r2BQlTVxO1rdW1/fRHZXtMMCf A2d4vvh+I1Yviyp8YwPMBFNSKSGKdppAQOqDAyM/s4KgMnx33byG0xOzHeRG9Bt3PgTk t4TG/GcJBPTtaevFLFtpIUIvlsAElBkHtVHagXQJh0uRg56Y6uXbFCnH7kkD/8v52VOz XAypX8bnlBBm4AIF6OEHL/jO9GB0smkWDTNnhHQYjjxCQFtxvV5cYr7aEF69tL2tsFvc mNrQ== X-Forwarded-Encrypted: i=1; AJvYcCV//Ma+a9cP0X475NaZfuoJsgd8Wwee/sphep2IQ1i/AmWMJCXkkkNZx1mTVDJaEK9Rp4h3QC7cCODtdp4=@vger.kernel.org X-Gm-Message-State: AOJu0YyOYtbjAUh4DX1W9b6r1ZcgEJ10XVKvWn+9pOpO3Gr08o8BBXDm wf1RZP9ZvBj8MS0b+NRbpPTYiZLzIehqjK67/7h/afz4/qNvMTG8dnULaOibWfBQAgJJb0iA/+7 zbquslvzjDo/Jd/yzw0grdMulCcvX0N7t X-Gm-Gg: ASbGncv6S6uk3I+JOf+0GxMMIp8vOrTpoChpJtJo2mq8+6mxMfAJGNEwqQfdbcVj5Wt 0I42FcKD46zgQlCnxkH3owBM8XHMmBhWPtFlxX+ZxbYVt/hVgx9N0sxbPL+t9CYaU12fNDWbdKL sFJf/74iYH7F8GLToIYzX5U952WelHecyXcS6IdI259EfYDvj7gi68Qe/tKd3aM3wlGl/WZJeLp O1xiLjxZ9Jnx3IGfPouP28QIYFTwCFbcdm0H2V6zQnjXVBU3eJRgsb2ASyvSodui3v89gDWcezz ktWZoJxt5KesWs86xDxFYHe9Zr9IHgYzZd8SScf4HpOR3g== X-Google-Smtp-Source: AGHT+IGM4smmOhtgP/4+Uo/a8IWC8EW5NjjaSX4wyDUOukBYYBtb2f/7+HWxfvUz6i44U/GswKTrYMpTZVq1 X-Received: by 2002:a05:6122:d04:b0:529:b2:ea5e with SMTP id 71dfb90a1353d-52abf0421e8mr1039622e0c.2.1745881842049; Mon, 28 Apr 2025 16:10:42 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.128]) by smtp-relay.gmail.com with ESMTPS id 71dfb90a1353d-52a993a2955sm790539e0c.10.2025.04.28.16.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 16:10:42 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-ushankar.dev.purestorage.com (dev-ushankar.dev.purestorage.com [10.7.70.36]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 49A673418B8; Mon, 28 Apr 2025 17:10:41 -0600 (MDT) Received: by dev-ushankar.dev.purestorage.com (Postfix, from userid 1557716368) id 3B199E4191F; Mon, 28 Apr 2025 17:10:41 -0600 (MDT) From: Uday Shankar Date: Mon, 28 Apr 2025 17:10:21 -0600 Subject: [PATCH 2/3] selftests: ublk: make test_generic_06 silent on success Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-ublk_selftests-v1-2-5795f7b00cda@purestorage.com> References: <20250428-ublk_selftests-v1-0-5795f7b00cda@purestorage.com> In-Reply-To: <20250428-ublk_selftests-v1-0-5795f7b00cda@purestorage.com> To: Ming Lei , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Shankar X-Mailer: b4 0.14.2 Convention dictates that tests should not log anything on success. Make test_generic_06 follow this convention. Signed-off-by: Uday Shankar Reviewed-by: Ming Lei --- tools/testing/selftests/ublk/test_generic_06.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/ublk/test_generic_06.sh b/tools/testin= g/selftests/ublk/test_generic_06.sh index b67230c42c847c71b0bbe82ad9de1a737ea3cb75..fd42062b7b76b0b3dfae95a39ab= a6ae28facc185 100755 --- a/tools/testing/selftests/ublk/test_generic_06.sh +++ b/tools/testing/selftests/ublk/test_generic_06.sh @@ -17,7 +17,7 @@ STARTTIME=3D${SECONDS} dd if=3D/dev/urandom of=3D/dev/ublkb${dev_id} oflag=3Ddirect bs=3D4k count= =3D1 status=3Dnone > /dev/null 2>&1 & dd_pid=3D$! =20 -__ublk_kill_daemon ${dev_id} "DEAD" +__ublk_kill_daemon ${dev_id} "DEAD" >/dev/null =20 wait $dd_pid dd_exitcode=3D$? --=20 2.34.1 From nobody Mon Feb 9 13:59:58 2026 Received: from mail-io1-f99.google.com (mail-io1-f99.google.com [209.85.166.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B8A12135B2 for ; Mon, 28 Apr 2025 23:10:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.99 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745881845; cv=none; b=q6NJEbUYoCsN2xEmkyomZvmlS6ZPUrorK1GTFfPSZh7hcoWzGgugWNP2S3IsHvoEGFiWL7pR29WZpdKVrlierwONnrVCNIKmIBYNc+R/3zATmrA+4GRv8ikP/jWr/OdTMqy0Ht4bDs6o9ItdraW/u5zqF3wGfVr1D8263xnlaHQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1745881845; c=relaxed/simple; bh=zYkzn89KbbQhJnqGGqmLfnKEczTOQpEO0Hl9akuF+ns=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=TRqVjEHGqjqVOiLqK3qjFHozYpQk20CiW0zEJHltJi+i9IEiKb6WtWVH34Ie3DkGEw1sUt3LqxRF7Qtk8OKCiWzJ4aYYjknUlK6vOAMemff2wUGozFCESC21eIKQ+6Ss9P3t5ombqI2RfNnqXQ7i0WOQ5nOClk5QLizS5gAGMp4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com; spf=fail smtp.mailfrom=purestorage.com; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b=KAFDD7Xt; arc=none smtp.client-ip=209.85.166.99 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=purestorage.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=purestorage.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=purestorage.com header.i=@purestorage.com header.b="KAFDD7Xt" Received: by mail-io1-f99.google.com with SMTP id ca18e2360f4ac-86142446f3fso157927939f.2 for ; Mon, 28 Apr 2025 16:10:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=purestorage.com; s=google2022; t=1745881842; x=1746486642; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=mLVSmwzlmchZcREq1TNVrtwTyqSxYv1rpw5fe1B5uZ4=; b=KAFDD7Xt5ImCRMzR6PGK8qfzJeEMF2QIY8VCAR1qa2KitrfFrmzCdC7+HF9CfpPi3n LXMjsdqfoqkvTvaYx9d558kXs+s7MUEJvkgrW6lcgTS9oVCsEsmPongOnPYKgyKmroUG 7APnGvOy4pF5YkXiRL6i2rzL52G9AH0M2GgEqvktoR7UonXDTaUOi8U7OZ860BB77DRe VWMEKmD7xTCdRVvEBIAgMuPBBnnyB8Z1sLgUzMJAbWE0cH4Rot2Ia+gXEAISemIidij8 kzJBElacK0bWW13wJklffd6LfSpK3lkhQJLwL0dOD0EAqMVyMRXusel8PCCNId5DzdXx HHbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1745881842; x=1746486642; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=mLVSmwzlmchZcREq1TNVrtwTyqSxYv1rpw5fe1B5uZ4=; b=IHyNO5t6nU6GovyOzswYjITJ6gs2mbW5PVm9C5nfm7EY1xP4AuQezPydUQ8Vu8wUOZ 4UzEVSSRg+4Mkg+5iSA6ZhrJEqU9Gjg8XTvuTGrPp0xjRwGRnXNry7H4eP3bvXZlaF+M 6myXdHusjnuu+8R71kHbIjSV9i6Cn4ZS83VRDPVtigAIa0CVLlCAArQA+WdmFXeT1oip Zd1pMdHS85B6sVTADDb17+6ElNU+n5E3+Ie5MtMZRK6ie1UKNTXJPU+gMoOwyaGORii5 rkLzhfPeqvCSoP1aSUf6qgX+t8181Dkll0PqznrnUX86uTWV5pQmbzTOK0kaufvW8djr eE3g== X-Forwarded-Encrypted: i=1; AJvYcCWSkKnY0hZ80iSFt0o5Tv1nwjPrz2ef3z551t1LBKSu6nw4nvgY0SNelYKCyVbxdMYHRPDFEzl1LwOoG+Y=@vger.kernel.org X-Gm-Message-State: AOJu0YzZRE4Tq8sXhSEkWUBxELT7ALgc5miaNJa5P4/LhMCHxN7yHUVM Ln+DbCsD9E4UbMeKPMV2u9QqIImq9V5XVxTG7syMM8aLwzouGcbPFfiiicYehV/hCpkyXYNj8i8 ZDjsErpH9W6XGVjDROEnuVwlRHg/RjEXq X-Gm-Gg: ASbGnctCYAKoLA8PkroHQ/6ilQ7QYeY/Y/HMyT6/ixaySk45gKrAjR63XaYBMAZ+dnF 45exfU/u9WPIBk+dzCfhuBzBfdeDiJ/4XRW7ddfI3TmIcsV/3BD01HD5l51JsvCTlbw10QUH0Zu 1UiGUow074v7mfK+52spBldYkrvpePdQn9ZqtP4g4bRw654mFQUsF4JatNRBr1GgmBdM9ZRHKd+ 3gkQV1AULNoxBHMtDrGCyY/kBpoauQdYiO4Nj42/kbSKXbCcRxoFqos9Ul/t6FgrFyouu69vulA c4Ewn4I5IHiYHFpkfRhob/5TJn7gIIGvF+gTD+EPmmvBhQ== X-Google-Smtp-Source: AGHT+IHTB/M1Wt//8i1xKmZoN1r7dW8BT4GGJKEo8aSzjqlVaNRWtx208jyBoTwQ70qkd+4ZLvbruF0uUhyE X-Received: by 2002:a05:6602:720d:b0:85b:41cc:f709 with SMTP id ca18e2360f4ac-864887dc55dmr225565639f.14.1745881842491; Mon, 28 Apr 2025 16:10:42 -0700 (PDT) Received: from c7-smtp-2023.dev.purestorage.com ([208.88.159.129]) by smtp-relay.gmail.com with ESMTPS id ca18e2360f4ac-8648bf866ebsm779239f.17.2025.04.28.16.10.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 28 Apr 2025 16:10:42 -0700 (PDT) X-Relaying-Domain: purestorage.com Received: from dev-ushankar.dev.purestorage.com (dev-ushankar.dev.purestorage.com [10.7.70.36]) by c7-smtp-2023.dev.purestorage.com (Postfix) with ESMTP id 466CD34175E; Mon, 28 Apr 2025 17:10:41 -0600 (MDT) Received: by dev-ushankar.dev.purestorage.com (Postfix, from userid 1557716368) id 42314E40B9B; Mon, 28 Apr 2025 17:10:41 -0600 (MDT) From: Uday Shankar Date: Mon, 28 Apr 2025 17:10:22 -0600 Subject: [PATCH 3/3] selftests: ublk: kublk: fix include path Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250428-ublk_selftests-v1-3-5795f7b00cda@purestorage.com> References: <20250428-ublk_selftests-v1-0-5795f7b00cda@purestorage.com> In-Reply-To: <20250428-ublk_selftests-v1-0-5795f7b00cda@purestorage.com> To: Ming Lei , Shuah Khan Cc: linux-block@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org, Uday Shankar X-Mailer: b4 0.14.2 Building kublk currently fails (with a "could not find linux/ublk_cmd.h" error message) if kernel headers are not installed in a system-global location (i.e. somewhere in the compiler's default include search path). This failure is unnecessary, as make kselftest installs kernel headers in the build tree - kublk's build just isn't looking for them properly. There is an include path in kublk's CFLAGS which is probably intended to find the kernel headers installed in the build tree; fix it so that it can actually find them. This introduces some macro redefinition issues between glibc-provided headers and kernel headers; fix those by eliminating one include in kublk. Signed-off-by: Uday Shankar Reviewed-by: Caleb Sander Mateos Reviewed-by: Ming Lei --- tools/testing/selftests/ublk/Makefile | 2 +- tools/testing/selftests/ublk/kublk.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/tools/testing/selftests/ublk/Makefile b/tools/testing/selftest= s/ublk/Makefile index 86474cfe8d03b2df3f8c9bc1a5902701a0f72f58..feca641635d706a856898f8e22a= 630f5f47361b6 100644 --- a/tools/testing/selftests/ublk/Makefile +++ b/tools/testing/selftests/ublk/Makefile @@ -2,7 +2,7 @@ =20 CONFIG =3D $(top_srcdir)/include/config/auto.conf WERROR =3D $(if $(shell grep CONFIG_WERROR=3Dy ${CONFIG}),-Werror,) -CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall ${WERROR} -I $(top_srcdir) +CFLAGS +=3D -O3 -Wl,-no-as-needed -Wall ${WERROR} -I $(top_srcdir)/usr/inc= lude LDLIBS +=3D -lpthread -lm -luring =20 TEST_PROGS :=3D test_generic_01.sh diff --git a/tools/testing/selftests/ublk/kublk.h b/tools/testing/selftests= /ublk/kublk.h index 918db5cd633fc1041e1e0805142f00e7e4f28bf7..4b943e57a890e5f14fa11dd19d6= 7c4c8684c4417 100644 --- a/tools/testing/selftests/ublk/kublk.h +++ b/tools/testing/selftests/ublk/kublk.h @@ -19,7 +19,6 @@ #include #include #include -#include #include #include #include --=20 2.34.1