drivers/pci/controller/dwc/pcie-dw-rockchip.c | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-)
1. PCI: dw-rockchip: Remove unused PCIE_CLIENT_GENERAL_DEBUG 2. PCI: dw-rockchip: Reorganize register and bitfield definitions 3. PCI: dw-rockchip: Unify link status checks with FIELD_GET --- https://patchwork.kernel.org/project/linux-pci/patch/20250416151926.140202-1-18255117159@163.com/ Bjorn Helgaas: These would be material for a separate patch: - The #defines for register offsets and bits are kind of a mess, e.g., PCIE_SMLH_LINKUP, PCIE_RDLH_LINKUP, PCIE_LINKUP, PCIE_L0S_ENTRY, and PCIE_LTSSM_STATUS_MASK are in PCIE_CLIENT_LTSSM_STATUS, but you couldn't tell that from the names, and they're not even defined together. - Same for PCIE_RDLH_LINK_UP_CHGED, PCIE_LINK_REQ_RST_NOT_INT, PCIE_RDLH_LINK_UP_CHGED, which are in PCIE_CLIENT_INTR_STATUS_MISC. - PCIE_LTSSM_ENABLE_ENHANCE is apparently in PCIE_CLIENT_HOT_RESET_CTRL? Sure wouldn't guess that from the names or the order of #defines. - PCIE_CLIENT_GENERAL_DEBUG isn't used at all. - Submissions based on the following v5 patches: https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-1-git-send-email-shawn.lin@rock-chips.com/ https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-2-git-send-email-shawn.lin@rock-chips.com/ https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-3-git-send-email-shawn.lin@rock-chips.com/ https://patchwork.kernel.org/project/linux-pci/patch/1744940759-23823-1-git-send-email-shawn.lin@rock-chips.com/ --- Hans Zhang (3): PCI: dw-rockchip: Remove unused PCIE_CLIENT_GENERAL_DEBUG PCI: dw-rockchip: Reorganize register and bitfield definitions PCI: dw-rockchip: Unify link status checks with FIELD_GET drivers/pci/controller/dwc/pcie-dw-rockchip.c | 58 +++++++++---------- 1 file changed, 29 insertions(+), 29 deletions(-) base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472 prerequisite-patch-id: 5d9f110f238212cde763b841f1337d0045d93f5b prerequisite-patch-id: b63975b89227a41b9b6d701c9130ee342848c8b6 prerequisite-patch-id: 46f02da0db4737b46cd06cd0d25ba69b8d789f90 prerequisite-patch-id: d06e25de3658b73ad85d148728ed3948bfcec731 -- 2.25.1
On 2025/4/22 19:28, Hans Zhang wrote: > 1. PCI: dw-rockchip: Remove unused PCIE_CLIENT_GENERAL_DEBUG > 2. PCI: dw-rockchip: Reorganize register and bitfield definitions > 3. PCI: dw-rockchip: Unify link status checks with FIELD_GET > > --- > https://patchwork.kernel.org/project/linux-pci/patch/20250416151926.140202-1-18255117159@163.com/ > > Bjorn Helgaas: > These would be material for a separate patch: > > - The #defines for register offsets and bits are kind of a mess, > e.g., PCIE_SMLH_LINKUP, PCIE_RDLH_LINKUP, PCIE_LINKUP, > PCIE_L0S_ENTRY, and PCIE_LTSSM_STATUS_MASK are in > PCIE_CLIENT_LTSSM_STATUS, but you couldn't tell that from the > names, and they're not even defined together. > > - Same for PCIE_RDLH_LINK_UP_CHGED, PCIE_LINK_REQ_RST_NOT_INT, > PCIE_RDLH_LINK_UP_CHGED, which are in PCIE_CLIENT_INTR_STATUS_MISC. > > - PCIE_LTSSM_ENABLE_ENHANCE is apparently in PCIE_CLIENT_HOT_RESET_CTRL? > Sure wouldn't guess that from the names or the order of #defines. > > - PCIE_CLIENT_GENERAL_DEBUG isn't used at all. > > - Submissions based on the following v5 patches: I'm very sorry. It should be like this: - Submissions based on the following patches: > https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-1-git-send-email-shawn.lin@rock-chips.com/ > https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-2-git-send-email-shawn.lin@rock-chips.com/ > https://patchwork.kernel.org/project/linux-pci/patch/1744850111-236269-3-git-send-email-shawn.lin@rock-chips.com/ > https://patchwork.kernel.org/project/linux-pci/patch/1744940759-23823-1-git-send-email-shawn.lin@rock-chips.com/ > --- > > Hans Zhang (3): > PCI: dw-rockchip: Remove unused PCIE_CLIENT_GENERAL_DEBUG > PCI: dw-rockchip: Reorganize register and bitfield definitions > PCI: dw-rockchip: Unify link status checks with FIELD_GET > > drivers/pci/controller/dwc/pcie-dw-rockchip.c | 58 +++++++++---------- > 1 file changed, 29 insertions(+), 29 deletions(-) > > > base-commit: 9d7a0577c9db35c4cc52db90bc415ea248446472 > prerequisite-patch-id: 5d9f110f238212cde763b841f1337d0045d93f5b > prerequisite-patch-id: b63975b89227a41b9b6d701c9130ee342848c8b6 > prerequisite-patch-id: 46f02da0db4737b46cd06cd0d25ba69b8d789f90 > prerequisite-patch-id: d06e25de3658b73ad85d148728ed3948bfcec731
© 2016 - 2026 Red Hat, Inc.