platform/x86: convert GPIO chips to using new value setters

[PATCH 0/3] platform/x86: convert GPIO chips to using new value setters

Posted by Bartosz Golaszewski 3 weeks, 5 days ago

struct gpio_chip now has callbacks for setting line values that return
an integer, allowing to indicate failures. We're in the process of
converting all GPIO drivers to using the new API. This series converts
all the x86 platform GPIO controllers.

Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
---
Bartosz Golaszewski (3):
      platform/x86: barco-p50: use new GPIO line value setter callbacks
      platform/x86: int0002: use new GPIO line value setter callbacks
      platform/x86: silicom: use new GPIO line value setter callbacks

 drivers/platform/x86/barco-p50-gpio.c      | 10 +++++++---
 drivers/platform/x86/intel/int0002_vgpio.c |  7 ++++---
 drivers/platform/x86/silicom-platform.c    | 11 ++++++-----
 3 files changed, 17 insertions(+), 11 deletions(-)
---
base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
change-id: 20250401-gpiochip-set-rv-platform-x86-86788597f4a4

Best regards,
-- 
Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Re: [PATCH 0/3] platform/x86: convert GPIO chips to using new value setters

Posted by Ilpo Järvinen 3 weeks, 2 days ago

On Tue, 08 Apr 2025 09:19:52 +0200, Bartosz Golaszewski wrote:

> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. We're in the process of
> converting all GPIO drivers to using the new API. This series converts
> all the x86 platform GPIO controllers.
> 
> 


Thank you for your contribution, it has been applied to my local
review-ilpo-next branch. Note it will show up in the public
platform-drivers-x86/review-ilpo-next branch only once I've pushed my
local branch there, which might take a while.

The list of commits applied:
[1/3] platform/x86: barco-p50: use new GPIO line value setter callbacks
      commit: 29ba3b6037dcf73f0fc563611ea81669fb2a3f37
[2/3] platform/x86: int0002: use new GPIO line value setter callbacks
      commit: e0071ad2ee0bf09a06e650cb5d697e6c8a7ca827
[3/3] platform/x86: silicom: use new GPIO line value setter callbacks
      commit: 88f67f2a99f061cb938812db3deb965504cf5c5c

--
 i.

Re: [PATCH 0/3] platform/x86: convert GPIO chips to using new value setters

Posted by Hans de Goede 3 weeks, 5 days ago

Hi Bartosz,

On 8-Apr-25 9:19 AM, Bartosz Golaszewski wrote:
> struct gpio_chip now has callbacks for setting line values that return
> an integer, allowing to indicate failures. We're in the process of
> converting all GPIO drivers to using the new API. This series converts
> all the x86 platform GPIO controllers.
> 
> Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>

Thanks, the entire series looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans




> ---
> Bartosz Golaszewski (3):
>       platform/x86: barco-p50: use new GPIO line value setter callbacks
>       platform/x86: int0002: use new GPIO line value setter callbacks
>       platform/x86: silicom: use new GPIO line value setter callbacks
> 
>  drivers/platform/x86/barco-p50-gpio.c      | 10 +++++++---
>  drivers/platform/x86/intel/int0002_vgpio.c |  7 ++++---
>  drivers/platform/x86/silicom-platform.c    | 11 ++++++-----
>  3 files changed, 17 insertions(+), 11 deletions(-)
> ---
> base-commit: 0af2f6be1b4281385b618cb86ad946eded089ac8
> change-id: 20250401-gpiochip-set-rv-platform-x86-86788597f4a4
> 
> Best regards,