From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wr1-f44.google.com (mail-wr1-f44.google.com [209.85.221.44]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB17D261565 for ; Tue, 8 Apr 2025 07:19:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.44 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096800; cv=none; b=QjuLJv02kauzHAZlF8bvgarRfnlQs68iJAQWNAMPoTTQ5TC8A9uotBWoe3W10yuu6Xe5NWD3bGGJ/Ej41cbaqwYGf9DJ0XlORB1u6S5x7C51PZxiycLmsW93oMrCSqrPxPIWC0uxtEl2NGrXgdoarU83PfMrbOFh3xuijiGAhtc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096800; c=relaxed/simple; bh=T+WH8Iwu/6dtTdR9z5RhK52HiLW1moQVVBrpWP9slQQ=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=h+PzV7r8rYVIDbKVWa1zNAB1xBU25RguhMnbwy+tm1HpMynT5i6kfAJxUAgjHS/fUqhpkapFnthiGfYaC3fQBTsEXiQVKDETce5qgDsmsEflOqh9BO7Rr7nDqnUISS+92KTPQjOnfffF+kKeLPohQVuuao9ctowZlscg74x4uz4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=LtaqNtuk; arc=none smtp.client-ip=209.85.221.44 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="LtaqNtuk" Received: by mail-wr1-f44.google.com with SMTP id ffacd0b85a97d-3913d129c1aso3549166f8f.0 for ; Tue, 08 Apr 2025 00:19:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096797; x=1744701597; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=W4uWWhb4aSngdGHb/52hqhL9aoRrvkL4lHuK2jkEB+c=; b=LtaqNtukZr21XdNC95ivTDk3H8dbbZHVJ5HEEP3zlOJqtJ/s3JU995k3DswgKxct2Y kUTzrvQHl1kyp/xA+lTwBLBltWIc9NPR6qfsrHwVNqrB+7MDUH4FRx8+LA4ADjwYBxk/ AtxduYObAMMNH9jwLcwMpGl5m6+spkuJzwyHaypU7OTFvp+I4vN2Q9mEFqwZuaYsKV1x VKIji82Q2Idgd1UE6IKorC7XtIrwM65px8XMHDQSYdpTn/3L9c+0WQU/QlqdDinDE071 NT0jhzg/bBCuD4jgs9/bGu1sqRRReuI9hw1qfEgxWBZximHxO+zsLP5wAioUjiAichT/ XPXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096797; x=1744701597; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W4uWWhb4aSngdGHb/52hqhL9aoRrvkL4lHuK2jkEB+c=; b=hnilDhaiBs1sDitLFvfKHZvLy6NM1pqrNuMHffbwRJUzXO+I+4itviRIVUNfPIcTqP AM4Wbc/cYRg6dhkvOEzrVxSOw51R8S+TbA2GoGzEOhyIHXt21SemwImKxPdbfqJuqH7F w9NW1LhdCLlyivkexwVW+/8oMAUUO90oxil4KqSgRy3Xs7rmuogtezcjEmK7CULw/wbN E8lLqpvHLBwZQh5QJQzXiYRz9OfFeS743MA/UBdjP78y0UZhKciPQXm2sDQAvoY990gC 2ZXd261LnvmrVZScyaLtblUzhKUTltJwYuG31FwVGIvtXAHz4P2FFhjBQP+iU7L9vCIZ KU7g== X-Forwarded-Encrypted: i=1; AJvYcCXEWBV1ebXZf/5TxbzKtoRLNFiNd/EGzMWUmZ5dBOrvuOq+EiTdjSTXjTEgnGh7kGFWq8Tat9zZSTNdv8c=@vger.kernel.org X-Gm-Message-State: AOJu0Yzka9+r/7q7ou5hF7JW2vBtJTIQ5q6LTZb732OPPsEEhJdj+wte nJCRot3vnihw1ct/Ao0NtaXluqTLzqn0k1mxKBWYxpqQn6IBPhvXBDjwguOcBS5ojr6+ZJUSo19 N3HI= X-Gm-Gg: ASbGnctieE0FcCsl+eYasdtNWev+67sU1J0myb0pUtG9h/8mvtD/2fpjTdYC543WZew ilvxbW4CBBJn3TsnFfOoAEZ2yE/hFtInL/5PdItaF00sa46HAlwGLJkbKUc5ch9w52J6mtLVK5B 9KJlkZjzl3n61ULC/PFjuGPES/mcwDTzy0WdyXKQlMdXqss5zdTA2ARqmyCrG3xjoSnNmf+WeBX 7nkRNDupLVHFOTc+TE24KlkAF3Df8DhuF1eyBtwNvz2QsZfaHbo5YgT2fCRUVbTp0iC0tJGTVUb gigH8KyUDn9SKp4pvtQewH1ASjWqrIakCQLFWA== X-Google-Smtp-Source: AGHT+IGs693SF2skFJxtrnpVyyA4b648Sphiyre1DRml+SY6VGE/qft2VVMjkRtQmhfhLdF6SnmNvw== X-Received: by 2002:a5d:584e:0:b0:390:dec3:2780 with SMTP id ffacd0b85a97d-39d820d2ad3mr1805877f8f.24.1744096797014; Tue, 08 Apr 2025 00:19:57 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301a6608sm13882872f8f.23.2025.04.08.00.19.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:19:56 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:19:53 +0200 Subject: [PATCH 1/3] platform/x86: barco-p50: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-platform-x86-v1-1-6f67e76a722c@linaro.org> References: <20250408-gpiochip-set-rv-platform-x86-v1-0-6f67e76a722c@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-platform-x86-v1-0-6f67e76a722c@linaro.org> To: Santosh Kumar Yadav , Peter Korsgaard , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Linus Walleij , Bartosz Golaszewski Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1503; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=udfDS9lyafCPGV+4xsVQ3dOFwSk2xrKk1FJNtTP7oag=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M4am3gjAMNUbHoWCiCoqknT/AS5a9eegVfGY 4EDrIh9hoaJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOGgAKCRARpy6gFHHX cuBVEADIgfqimyeJOkuRuAVqyxn0sjO5L0hv3Gs6/0y/f8XxZXC6CMs8MzmJkwNa8B6sN8hJ7V4 Dxc0YPdYrGwGVA0+kLo+yH81VAP6MGX6CoxhtN69bGMISiZKHrhflFi/Ji7b6rhj1DT1nNtPBps PtlzfDIoORY0QJaulLpry8OYX93+nuLAM0Bnn7cvoxpXaqLFBr+lSVv7ED1QKTCeCSnHbgJhNd4 Bo0ymRNs1114JMxjTWwS6s+KrJHPL/nw5sEH7S7ysHrdY0SqBhOEvbg/MbMW7ftRZ8EAtAWLnDl AN+WW29LnMLlutf4l9JS/ed52EsUhccwVpS11fHEMGEWj1/RrunaaOrfbYOWEYxC4aa7kimUtoS nf6Qna4mzdxmIxNPQbt4nfJ+VgL2k3SUll4Y0G0C6vTU+TmTJrz651/zSCJ4nv0mU6hhqiUTysM iezog/CtyllMI5/EC7E5ZR/pORd0HeIY9fu3Xfb4VXWBhQ+U7AMzOben1P5mKYegXRjICKjExrx BMXF1kBGuF70i1uaxu0xdz8eypgh72TLFtOk8Aajh0sAViRB0P5lyQT4AXvLLpuHONxeir49P7n XM4KaYnZ8TAE+6fnEEWmRvtDQa/Wzdyd13Nr9fomkeDRXMrhgRizq3iBcjZeI6dzpQ838pNz2ev 0hsGQFUxfxz560w== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Hans de Goede --- drivers/platform/x86/barco-p50-gpio.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/barco-p50-gpio.c b/drivers/platform/x86/b= arco-p50-gpio.c index 143d14548565..bb3393bbfb89 100644 --- a/drivers/platform/x86/barco-p50-gpio.c +++ b/drivers/platform/x86/barco-p50-gpio.c @@ -268,15 +268,19 @@ static int p50_gpio_get(struct gpio_chip *gc, unsigne= d int offset) return ret; } =20 -static void p50_gpio_set(struct gpio_chip *gc, unsigned int offset, int va= lue) +static int p50_gpio_set(struct gpio_chip *gc, unsigned int offset, int val= ue) { struct p50_gpio *p50 =3D gpiochip_get_data(gc); + int ret; =20 mutex_lock(&p50->lock); =20 - p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO, gpio_params[offset], valu= e); + ret =3D p50_send_mbox_cmd(p50, P50_MBOX_CMD_WRITE_GPIO, + gpio_params[offset], value); =20 mutex_unlock(&p50->lock); + + return ret; } =20 static int p50_gpio_probe(struct platform_device *pdev) @@ -312,7 +316,7 @@ static int p50_gpio_probe(struct platform_device *pdev) p50->gc.base =3D -1; p50->gc.get_direction =3D p50_gpio_get_direction; p50->gc.get =3D p50_gpio_get; - p50->gc.set =3D p50_gpio_set; + p50->gc.set_rv =3D p50_gpio_set; =20 =20 /* reset mbox */ --=20 2.45.2 From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wr1-f46.google.com (mail-wr1-f46.google.com [209.85.221.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1E7021ADC7 for ; Tue, 8 Apr 2025 07:19:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.46 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096801; cv=none; b=RWFE6V0o6Mm8nC4+Wamlu4FnfXc/Bq2rW/1GOIj8kh0rnnNwoJvVy5AuUDlWuX+7lTRQDwDA856RiPXnWMIdKIvm26PDVBMdZNQErerE0aK9V2HVZQd4N98xYo2xz3L1JwobdWnc+jXkacMWqMBStuFNrqyM6HTkA+qX4RZZlgk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096801; c=relaxed/simple; bh=v3f75qWk5UlBrcSxxHaEwlLhjR5ljzWaxIyurbTbotE=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=djLNJs4u3I3Y5m6tVzBbjf1VA+3pt2pO4qa6pgLC3GKVuxciVpIvp3d+D6U80uXv4RPUxGlLfPBBM4lNqwV4P4V+I8+YPYhHQhqY2y3aivBl5DkOLEdx+MCepSpCPpLZG48ePbDvF0NtaWKQBj6MUrYGp4CtS5EtRUKMZ/tcel0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=fNEuXXIx; arc=none smtp.client-ip=209.85.221.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="fNEuXXIx" Received: by mail-wr1-f46.google.com with SMTP id ffacd0b85a97d-3914a5def6bso3023794f8f.1 for ; Tue, 08 Apr 2025 00:19:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096798; x=1744701598; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=k7xbBtk4eC6fJYqAEYcPFUg2SaKE0i4AT0w2WPtrU1U=; b=fNEuXXIxmtgV+Ym0dn3ZWl2bqMwskR2yO+q2OAYOXt628nLOXjqheAtRuH9Q+aqp83 yp1og/dXsGEUJxPh5nAjXm8hARGVm2z2zU5KXof8dX5BajB5S5f1i5FqcOqSxsJD8E52 Oa4qbbCWd7TP46t4XeYa6jQEuESvPsOHAwYZ3+RsCOgJDQ0AbfM6a4fg/n9NnkQ62CtB GRlti7Pp12OHp2XVnCfHcW8hT6FbX3QtnVX0rNPRhxzUlKqFNK+wi/b4UbtwMFm1TWSE 4kRvy3z67tI+QBYAZTNrmpulDoIfNcaF8SKFJJR93v43dxjzRKQrMFcSMcs9/4qZd4JL WUvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096798; x=1744701598; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=k7xbBtk4eC6fJYqAEYcPFUg2SaKE0i4AT0w2WPtrU1U=; b=JxcjX1LBeJZe0iBgyohHETnAezfBpkTi9zPewG8t7gvpNqWt+ymRDUReEw2BufN8u0 rO2u2as0xHYNmBLNEq4mjXAXk1jFSIDJOxgL4j2TWwb+VnqCP30H8YQOjo5nAfn+ZcJk UlU5WCepad8M7lt0mw7X8FqzPgwWfhn01kcFvhWU/i2ODGP+3tcGTHWgMs+Q7/Gz+0rq b2yVxxgv6CeRJgbp42jv6zxnOB4ofoW52EXK7Uoa3CPc/CtuENhCkhXQvPkdFVPWm+bq Y3ZsNanFQ8sWl1tMBnQCkUgBnPYkXask4tvvcsp9LPTsxY1A+xIE555WSfyttsISOQ8E mWew== X-Forwarded-Encrypted: i=1; AJvYcCXIntyW6fssev76zNXqqZKVLUgc23xqcPad0BQAYNGaYZqbUkv36XM7bS0Gz/AUGueIjnfNtHmbgNmzC+k=@vger.kernel.org X-Gm-Message-State: AOJu0Yw4Rmk0bhaD8c8d4rScM/9/m0ua4dnOHnxF6CIprgxxts0STI+q w3RC7AfdD/d/uECYDkLfo5ByXdBIvYPrczWS1GMr+K2i9OK0cwVwyzt5QMe37V/ZL+ezqH3RU21 SYIc= X-Gm-Gg: ASbGncsd1+Oy6xeEb8dtOFrpI5gKeMljVDyH6V5I5xZGnOjAh3Tbddsc+CujpWs519k RUIxlGEXOV8c5vbcP5syjWON1mI9e3ViKBRiZ4qOLIJ1uv4UEHdQ/TZFkb5SERLeXNZ9iMBGk54 iI/GHOlKYuFEReYoZxGMJMAU0aqc5p21LRzyCW+iUnd3mNWFP23FhZSiWte/jU6dbfZZECbX3BX Vqo4G/xeQXIxt4BBwjQ1Wwh11vBUL0lZLZMvj+nTLKBTZwEER08X5cp5S+MN1VByxkpDEEu+Ph6 Sh/pgJo4qVi/MZaGBHjewZwz2OlxabFcIV2ucA== X-Google-Smtp-Source: AGHT+IGMaGQ3FEHcV26y5/TeIOw4x15At8bWgEJ3u/wemW35qel1vSayovNdUa6Qrm0LxBKrb4hn2g== X-Received: by 2002:a05:6000:2288:b0:39c:11c0:eb95 with SMTP id ffacd0b85a97d-39cb3595653mr12726016f8f.17.1744096798054; Tue, 08 Apr 2025 00:19:58 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301a6608sm13882872f8f.23.2025.04.08.00.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:19:57 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:19:54 +0200 Subject: [PATCH 2/3] platform/x86: int0002: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-platform-x86-v1-2-6f67e76a722c@linaro.org> References: <20250408-gpiochip-set-rv-platform-x86-v1-0-6f67e76a722c@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-platform-x86-v1-0-6f67e76a722c@linaro.org> To: Santosh Kumar Yadav , Peter Korsgaard , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Linus Walleij , Bartosz Golaszewski Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1345; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=Ca40BBLEcqmdb1vEhG5kN8vjSDgv85IwvijmxSpzX6s=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M4bbIUEwJMcf2l8IfuRxNPaU/VQY/+uzcnav /IUUKIJIr2JAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOGwAKCRARpy6gFHHX ctg6D/9iXRGueeWhRok4PbRGqXtnn16SKVdS3udkt9Vv2lPh7+IKs+vXyhXQ9yensGBZIVI++TW nV7KYN2gVasndMxHedrKSlav5LvCe+6XYvR+C44JxDdVXgR4eNFyxyBSq0oVYtNryDOIK/aCKSd +lNoZkwQCzZjpAyVCwIM7uk8YcclteyzScOtAOMZn7MSXxDsHOpMDEuuewB05vUFSGibb3USlgz DPsaHK3KD1LL6UZ2G3E8GClROcT+EZySP7XhGSaAO4qTZByToPHhGprm8IriMQHPUyWbZf/nFhj JfkkRMrjMGl0Uxaz0XAsrRthsIAsdo/v4ixEjLWzRKz9n0zHqWSdL263Wg4ahr6jc5PeRhHz+SN Q8dGAaTmdpGOrZN8uZiwkHu6+wXfBWUJMQ32arHX+P9pJ/aEaPJJNjVTohTrbb99BV91K57h191 /54kyatX4YUwahXaeISo2YOD820fGOO94rMMLhfAY+Ouun0ZHZKmB3NwAjJwDDeRtfj4ZjV2YdA 5n+t14WM/GLZ4TVCgcxlLwum/nRLu/vhd1kYiDwlSQmyrFzHgz51MpAF3Cl+XkmtosX7P4LLcIK lPqjUmrGE7fYxy21TlaVuzUrnoMH75sKGLvkh19kCqi+AL5oWjmf4qzUIOAzAprCuchzW8cFkcM QbS1WMcoOodnEqA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Hans de Goede --- drivers/platform/x86/intel/int0002_vgpio.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/platform/x86/intel/int0002_vgpio.c b/drivers/platform/= x86/intel/int0002_vgpio.c index 3b48cd7a4075..ab104fddee89 100644 --- a/drivers/platform/x86/intel/int0002_vgpio.c +++ b/drivers/platform/x86/intel/int0002_vgpio.c @@ -65,9 +65,10 @@ static int int0002_gpio_get(struct gpio_chip *chip, unsi= gned int offset) return 0; } =20 -static void int0002_gpio_set(struct gpio_chip *chip, unsigned int offset, - int value) +static int int0002_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { + return 0; } =20 static int int0002_gpio_direction_output(struct gpio_chip *chip, @@ -192,7 +193,7 @@ static int int0002_probe(struct platform_device *pdev) chip->parent =3D dev; chip->owner =3D THIS_MODULE; chip->get =3D int0002_gpio_get; - chip->set =3D int0002_gpio_set; + chip->set_rv =3D int0002_gpio_set; chip->direction_input =3D int0002_gpio_get; chip->direction_output =3D int0002_gpio_direction_output; chip->base =3D -1; --=20 2.45.2 From nobody Thu Dec 18 17:49:43 2025 Received: from mail-wr1-f54.google.com (mail-wr1-f54.google.com [209.85.221.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DD45724C08F for ; Tue, 8 Apr 2025 07:20:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096802; cv=none; b=cIHx0T9ZKYoPrjdct9JkKH6bXUDbgJKuiReR0ZsaBviDczHkLTDch4rKZLE+Q4RmemJUNw4hv87SGbaBfAw6+VP5Uu4MfANTNCIBvwS85EHwgZqvUbwI1FZmkuDJqZFJUTm3Ezjg8L+fbA5zbxNbVDQ8RHsDNIsldbUsckzJKTM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744096802; c=relaxed/simple; bh=sShqp1OG6UzQmWXPboB+sq77y980YHZYBmhVvusKcpU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=o4e4+kqrvdwRFyK71tdk9EdofWgWj8tM8b1GxW0uIbsGtoXw3RnXumRpJqu+LzAlWnq+NH/rsAhd4XbsK+LgO9FakIzCe8vDyksVla2+TlDWshc4YNfWyQE5f36Mmrkveg2lEYdMj54GJM8pRzuieZFg71l6LIsriFQkt3h+Aec= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=x4JwsQuf; arc=none smtp.client-ip=209.85.221.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="x4JwsQuf" Received: by mail-wr1-f54.google.com with SMTP id ffacd0b85a97d-39c31e4c3e5so3177741f8f.0 for ; Tue, 08 Apr 2025 00:20:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744096799; x=1744701599; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=EUcRoGUFSmoPY+d/cL7WrlmVp5gIPvEUp8G2THBFhMk=; b=x4JwsQufZe0nbQ6tzkAU0SU67UjxIC1dO7/k+pdErWeDO8+/iOxOO63bno3j45NrCf EWG49PWYXFMrTUJJ2r1HGBnvGpPONnDPK64x8/a7SlX3NreSRfJpncyzX/wV6mFRQpN/ ybmJBydIKruBO8FYEpxQ4vmnBieXq7C8BdRO2TzW3f1dytpuVxXbDO8IHx3nsKJNExAF B4MtjHT9ZF7tBna+wYmau9qgNmp3WCn7fJfX7Bx6lV+vK6i3z2s09PmcEuO6W3SF8lGQ tLpjBccZLoKJ0Kx1MzuX2UmfNrcX+KgExsYcumwTKZVfuPVbjl01n7yTx/jeAFnkUHOe yxZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744096799; x=1744701599; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=EUcRoGUFSmoPY+d/cL7WrlmVp5gIPvEUp8G2THBFhMk=; b=EgQh8m5L80PC0UaiusupttA8Z7y7R26dH1UWf+feNwrk49kgqZHWNcOhrqawOUVvhT PEI/ctINwyoE5/FcL4e97OH8pCjoMTg2Wfa7r2ZBdDCDJoT2Z+ENh0praijcI8rdu6ud 3SQhu5M6xYLVd0wbvWVIhaVOP7W33MHxc6eQBRB4jGpXZzQWjEX0gw6Ztj59SwibxMGt 5LZa5893+MuXzkyRxYR3UrkRiIftVkImkDE1Eb6nhAz4Yy5XTFihmz2hHr4dVzo6+MDO 3ljnaqIXfBQESG9+a2gK48A16irnn5BiK3e2ODwoaKk+w2+JqCy58yBB4nzFDzGQ+NAG G2NA== X-Forwarded-Encrypted: i=1; AJvYcCUiXZOvQLKnSTBF0Cd5inHXJQkWOtMvOJZ78JdWmTeJ+vC/AfIiI7VyqDBmtoBRyETLXbm2l8Q3PEDtom8=@vger.kernel.org X-Gm-Message-State: AOJu0YwXgwKUIOfIEP5by7uqhW5SnKA1GZwLCM1RMqFaiZ3SknbifZR4 Olzoo5wo2LKN/+BmU9mltq/fFw+m22NqrCVoYujSdxwOW5rMMOvpECwE3H64SdMBHXygEjzRW8s pFHs= X-Gm-Gg: ASbGncvg7WDGFQaIjWna6M1B+RAmLNkQBT153r5v9y16UYeV+OUSCcHErrANeFIHkms T5LPc8LCE3cpj7UvktFfeL1HX13lCcpOFysO4wCUc4xLFwFufwIY8+9UkTO+sT1/1IlMMFOFuvD ov658NKYQYl+ZjdWngr3VigU9B4ypUPUOEPHnrkQ7mf0oiiK2l7jX6lr0EUu5q8jzeTwM5Nqwy5 Vdr+PvFvK6qhbYGgiWWUYOR8wIzTTq8ah1Cgck0j3ChViTDa9/aLkZZ6MaKZpTjqWt8P0NVDn8Y tXnbXJfZNa3G6bVUwOSzaRgRckTPIdm86ZzYZw== X-Google-Smtp-Source: AGHT+IFcB4gkAeFTfcCzb/N2afVDgfBGxr70AKsKJJ8DDnRef5DxEbrBcldQtcrZ4UJzZfAJRHX5wA== X-Received: by 2002:a5d:648a:0:b0:39a:cd84:a77a with SMTP id ffacd0b85a97d-39cba9332b0mr12081546f8f.37.1744096798842; Tue, 08 Apr 2025 00:19:58 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:2adf:eaae:f6ea:1a73]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301a6608sm13882872f8f.23.2025.04.08.00.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Apr 2025 00:19:58 -0700 (PDT) From: Bartosz Golaszewski Date: Tue, 08 Apr 2025 09:19:55 +0200 Subject: [PATCH 3/3] platform/x86: silicom: use new GPIO line value setter callbacks Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250408-gpiochip-set-rv-platform-x86-v1-3-6f67e76a722c@linaro.org> References: <20250408-gpiochip-set-rv-platform-x86-v1-0-6f67e76a722c@linaro.org> In-Reply-To: <20250408-gpiochip-set-rv-platform-x86-v1-0-6f67e76a722c@linaro.org> To: Santosh Kumar Yadav , Peter Korsgaard , Hans de Goede , =?utf-8?q?Ilpo_J=C3=A4rvinen?= , Linus Walleij , Bartosz Golaszewski Cc: platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1643; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=zGzPAe1FrCR6IAcgaEbtX/r63pSis90sCeIpOahYRzI=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn9M4btWQhTbuIhjAMDruf4EOKZZYOjT+a4D7MB UwHgbNHUGSJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/TOGwAKCRARpy6gFHHX crvwD/49t3tuCwiX8O3tRgTSTCK2a9xFiYLZ3C6/gcWXhMKuyPr3YytOWsKYqVE6s2d9XnNgcUK qIEuMJRsjFTzs36EKi7WVXNjbOU6GgE3evVJ2LUksfomsSaXY7jmfo10lhVZyj0ynyHIMKRbYaN SZF5AYIpcTPL5y9DMgDRx2T9U47ieLN6+x/+deywknXw4wpnURRAy0iCLhvVOiVXnfCTCEp1mdg 3ZsIoSXyEn/HWl+zGGtiYKpwsqRygQhDBEmX06f6SYqElu8SKWLTYPLPXBENVRqye8sNQHxUo5K 4MDoFeA6bgvbLSWUSnNvImNTCW2nASW17FgXqhmlRAjKE6JBDkSqZkr82jX9LWxKMUNcL2U/GSm UNKrSXn/ExP2CfnCnIz642iK+kfSzuTyAOaC4/Wu5MPxOJ1UiT/MWhO/aBPXi7zh3DNe5VQABOH EWDxa4at3ym9xhwk7Zkur59BQVtpoSDVKR1VhaMem+ODpQh5XKux23mdf4oPzBmJJG8LCkebjHc mNXd28+FhhlJ48ZH8Kg5NWtP7nemVeBMWrMd6dbrVsk9VWr4JrCGlDnv3/1VSa2z6ywZwiMxIBv Lq5hYQgf73NTRlOBr7V+WI1GaELL+9HjFKYKfntHiqTpFa9FX9EC3Ggm8nbdv6ns0TMzBcp0sTD WC/GqiKu2H4w3NQ== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski Reviewed-by: Hans de Goede --- drivers/platform/x86/silicom-platform.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers/platform/x86/silicom-platform.c b/drivers/platform/x86= /silicom-platform.c index c0910af16a3a..021f3fed197a 100644 --- a/drivers/platform/x86/silicom-platform.c +++ b/drivers/platform/x86/silicom-platform.c @@ -245,18 +245,19 @@ static int silicom_gpio_direction_input(struct gpio_c= hip *gc, return direction =3D=3D GPIO_LINE_DIRECTION_IN ? 0 : -EINVAL; } =20 -static void silicom_gpio_set(struct gpio_chip *gc, - unsigned int offset, - int value) +static int silicom_gpio_set(struct gpio_chip *gc, unsigned int offset, + int value) { int direction =3D silicom_gpio_get_direction(gc, offset); u8 *channels =3D gpiochip_get_data(gc); int channel =3D channels[offset]; =20 if (direction =3D=3D GPIO_LINE_DIRECTION_IN) - return; + return -EPERM; =20 silicom_mec_port_set(channel, !value); + + return 0; } =20 static int silicom_gpio_direction_output(struct gpio_chip *gc, @@ -469,7 +470,7 @@ static struct gpio_chip silicom_gpio_chip =3D { .direction_input =3D silicom_gpio_direction_input, .direction_output =3D silicom_gpio_direction_output, .get =3D silicom_gpio_get, - .set =3D silicom_gpio_set, + .set_rv =3D silicom_gpio_set, .base =3D -1, .ngpio =3D ARRAY_SIZE(plat_0222_gpio_channels), .names =3D plat_0222_gpio_names, --=20 2.45.2