drm/panel: make prepare / enable / disable / unprepare return void

[PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

Posted by Dmitry Baryshkov 8 months, 3 weeks ago

While it makes sense for panel callbacks to be able to return an error,
the state-management functions from drm_panel API are usually called
from atomic callbacks, which can not fails and must return void. Make
drm_panel_prepare(), drm_panel_enable(), drm_panel_disable() and
drm_panel_unprepare() follow the same calling convention and return
void.

Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
---
Dmitry Baryshkov (7):
      drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()
      drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel()
      drm/bridge: analogic_dp: drop panel_is_modeset
      drm/bridge: analogic_dp: drop panel_lock
      drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()
      drm/bridge: analogix_dp: ignore return values of drm_panel_* calls
      drm/panel: make prepare/enable and disable/unprepare calls return void

 drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 107 ++-------------------
 drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |   3 -
 drivers/gpu/drm/drm_panel.c                        |  54 ++++-------
 drivers/gpu/drm/panel/panel-newvision-nv3051d.c    |   9 +-
 include/drm/drm_panel.h                            |   8 +-
 5 files changed, 33 insertions(+), 148 deletions(-)
---
base-commit: bfb20a655848a9088e3e9ae24b1dcce1bbf016c2
change-id: 20250401-panel-return-void-d461c71ebd35

Best regards,
-- 
Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>

Re: [PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

Posted by Neil Armstrong 8 months ago

On 01/04/2025 07:11, Dmitry Baryshkov wrote:
> While it makes sense for panel callbacks to be able to return an error,
> the state-management functions from drm_panel API are usually called
> from atomic callbacks, which can not fails and must return void. Make
> drm_panel_prepare(), drm_panel_enable(), drm_panel_disable() and
> drm_panel_unprepare() follow the same calling convention and return
> void.
> 
> Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> ---
> Dmitry Baryshkov (7):
>        drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()
>        drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel()
>        drm/bridge: analogic_dp: drop panel_is_modeset
>        drm/bridge: analogic_dp: drop panel_lock
>        drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()
>        drm/bridge: analogix_dp: ignore return values of drm_panel_* calls
>        drm/panel: make prepare/enable and disable/unprepare calls return void
> 
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 107 ++-------------------
>   drivers/gpu/drm/bridge/analogix/analogix_dp_core.h |   3 -
>   drivers/gpu/drm/drm_panel.c                        |  54 ++++-------
>   drivers/gpu/drm/panel/panel-newvision-nv3051d.c    |   9 +-
>   include/drm/drm_panel.h                            |   8 +-
>   5 files changed, 33 insertions(+), 148 deletions(-)
> ---
> base-commit: bfb20a655848a9088e3e9ae24b1dcce1bbf016c2
> change-id: 20250401-panel-return-void-d461c71ebd35
> 
> Best regards,

I think you can respin with the warning fix on patch 1 and then apply

Neil

Re: [PATCH 0/7] drm/panel: make prepare / enable / disable / unprepare return void

Posted by Dmitry Baryshkov 8 months ago

On Tue, 01 Apr 2025 08:11:32 +0300, Dmitry Baryshkov wrote:
> While it makes sense for panel callbacks to be able to return an error,
> the state-management functions from drm_panel API are usually called
> from atomic callbacks, which can not fails and must return void. Make
> drm_panel_prepare(), drm_panel_enable(), drm_panel_disable() and
> drm_panel_unprepare() follow the same calling convention and return
> void.
> 
> [...]

Applied to drm-misc-next, thanks!

[1/7] drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel()
      commit: b65cbfe0e1d8bcb74dbeb221d423dd926f326d05
[2/7] drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel()
      commit: 0ce432e18c932a7fd219b9c2bf1db623fb0f7840
[3/7] drm/bridge: analogic_dp: drop panel_is_modeset
      commit: 4fc72e1fc46b0dca74c1f8c94091e524ad5b9fdb
[4/7] drm/bridge: analogic_dp: drop panel_lock
      commit: 62ca1c3a146c73f8b8a381bf4461a82951defb8b
[5/7] drm/bridge: analogix_dp: inline analogix_dp_prepare_panel()
      commit: d5f34ca5df7c0ae075fdfeba20edd6f81c792554
[6/7] drm/bridge: analogix_dp: ignore return values of drm_panel_* calls
      commit: 58a71d2bf103550f809987e16d8c1949be719040
[7/7] drm/panel: make prepare/enable and disable/unprepare calls return void
      commit: dcbd5dcc956e2331414fd7020b4655df08deeb87

Best regards,
-- 
With best wishes
Dmitry