From nobody Fri Dec 19 21:35:41 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8765D1D63DF for ; Tue, 1 Apr 2025 05:11:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484317; cv=none; b=SEyYJ7uhqqZC2QF0VmXLsXfV4vtRHY0NBbf4qUNtm7MCe7WgfrD3NfLRx/VuRO7ZghOrPdJa+Jes120Vu9GsR3NWn2cLInuGhxfy7MZuJK6CqHiah7i85NuW5+k8pPVft5dXm2GDba/wpUU1TO/uDiv8SpTIwqVEKBLFaVon6V8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484317; c=relaxed/simple; bh=yoW5522ZzqPZUOVagrebp1jFhYqOlDKf+OwXbxdaN/M=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=VZ4q29Dk+Gb5+NBNcV1GBINiuxn3ST4ZfwL4GU+pF11L62GRRHvTzxDNQscKXEtI2rxIPW5gBzIXV+PHHAW15GN7GMzOKF1+ft9ra2PXgqQ8IAd4lCAplTS5jhzp8uB3LUXtqLcc2rSJ6/0THw4SxYB84CDuExTLbekZ02nT7sY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=N9rW0mtN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="N9rW0mtN" Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VFCuuF011995 for ; Tue, 1 Apr 2025 05:11:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= y1r0Q6x0yLTab8MbDQMGfrMrTbeTQKCtYurLTk8HHuI=; b=N9rW0mtN6ikW3b1q YdPeg/3NeHnBAkCvm/wBzoW8esFhiXJLQSSbCoOPwNqOtbCkAJlfL9g6/TwGN1/x thZMT6Ly5Mma/2VJd18PdK1MGibF+XDSmVOGYbj/rPrVOWSM3mmxas0/GGomnb76 5yHHFn/IL9mzM6qo/5qqh47oqIfQngdQGDW2ltzDlzqbwfbMpx0QODAJpMkecQLu pxIo117sxMOgdnIFLJvofBTR7vYyll6mzaIr8Nxy8Fb7ChjA9KBD5fuL8Ugs344+ yVVgXh/MIOHb0zeiiXccDEMkLEkA2JpzhZsoUpI8PC9TgCVVFM7Y/2e/x5qbnrSD GADweQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45p9mjpe8h-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 05:11:54 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c54e9f6e00so987512485a.0 for ; Mon, 31 Mar 2025 22:11:54 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743484313; x=1744089113; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=y1r0Q6x0yLTab8MbDQMGfrMrTbeTQKCtYurLTk8HHuI=; b=RNojfa4zkbJeqdsQlxcitJwzPhYOg65MFVsR58tMdyLGvcwRIqJGp/t5PpKPh5A8VO 7Vm311YjS/A7EOZfTKtYH4hO8WD/Yl5fVDMaCS734rUVpl0wNho0IX/gelN4s2pqtP2e LguieTxWdkQkRbqg+VIo6nE5uiJZIUMJnPsCnP2RRCshdWRJYZGy6nANai9SDZJz8Mpt IGXr4vo51vB2DwKu8Ov2/g8luTwyQk0xsvzk34MOVnmOBF/YSy750zv8Wg/zt0QLtzti 6p+bbJAkZb9g/s/LOBYCtjCBi6yj6nUQveSs0VLoOPq2ynKVvARLgHvoAwQAashDeIR0 Ikow== X-Forwarded-Encrypted: i=1; AJvYcCX9nbC38KRt8luJyTyxPDg4Sf4F4Nt+YJqU/jSRhosnZu2LQYBjPisPv+BdFGgNhfFQX2QY3IMeZwaFaPU=@vger.kernel.org X-Gm-Message-State: AOJu0YwhyUH+3cy/zwxjI0UADFcE/MaVNAZa08SJ0wpWwCnFT20ilkSE bV4+rjSFvXPpSR9Fn3rGXw2L2tjfMAXcVhvM4ncKzIA2dpPT4dXUV2T3O99yOpTyDYAIFRBJ1gt y0VG62kvw2l9mlqNwhe0OanAf9fGGroTO3IUtfLmgzD3zefAZ5T4BeUs7+t3i6sU= X-Gm-Gg: ASbGncsInN+lW8hdMenTaRz2ap8svNgalLd4PtKtxNT8r/dl+9KBkaC73ntSorTyZ2i 042I7kHvE65hzqHMQeACA9PI4HHX/l0WfEZqMACEN+JBX/ANxR2TqnKRKPvXqqILyZkeiCz4NWC 7/w/TPcyg0wNOYLxhq1o/sx543AnZ4/a9uL4K3w9dAv0sUUUas3u1D2BnlcdfvrFpHNzTdqua2u Ym8JSRpPGX8QwNhj2kAK0hIC0ukPv/6WQpenuTvt0j6xxgMwGNbyQ6JhRsEDC9icduDx+MlUXEQ +MuosdMNbT1bd38WjVx18qPv5S818B0Pe0TMQMBELeEKyunQ/T+3eL3cp13cc5hzx+GJnEEidK5 20oh2DdBTrh4bREclmvlpZVOhjbes X-Received: by 2002:a05:620a:44d4:b0:7b7:142d:53a8 with SMTP id af79cd13be357-7c62b47efbemr1553548885a.19.1743484313152; Mon, 31 Mar 2025 22:11:53 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG3lexU6EBfcncm54A9Kd24CaLpiEaLaaFnAPz5TDD1Kke4bgebndJIyZ/RegXQxIUw0y9c8Q== X-Received: by 2002:a05:620a:44d4:b0:7b7:142d:53a8 with SMTP id af79cd13be357-7c62b47efbemr1553547285a.19.1743484312792; Mon, 31 Mar 2025 22:11:52 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b095a21b0sm1251697e87.243.2025.03.31.22.11.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 22:11:50 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 01 Apr 2025 08:11:33 +0300 Subject: [PATCH 1/7] drm/bridge: analogix_dp: drop extra calls to analogix_dp_prepare_panel() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250401-panel-return-void-v1-1-93e1be33dc8d@oss.qualcomm.com> References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> In-Reply-To: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2268; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=yoW5522ZzqPZUOVagrebp1jFhYqOlDKf+OwXbxdaN/M=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn63WQNdABavZ64pNwjFHAQter1xgT/pdXOsfS1 AVXUKi4MQ+JATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+t1kAAKCRCLPIo+Aiko 1WovB/4zgZXMr4h83m6nu7k4IPGcuN0P1q3uOAHuxOS3tXLL/Nv6+l7wOGFOE6uQbEjBOiun+Kl 0FbDiTku/4J17/2Y0QAac2UU59sYQyaC5l1A68yAvFAP4IgGxzJa6fXtxJUad1ioIlybRVWdvF3 XprgVePJOdYWN/k7oUErLXI87SO2fh6t27aKoCzNLBRViAJbBr9T57KNEG6kgdxF4qZio6EW2Y/ a5sX7zFCVWGIg7pR1KcMVL3bs/TMfjpQwuq8ZCgPtKbz5ecqY+TS7paVfxxKfviPnpvJLX+AeJm g0B2qFPKg3dbztEnUbvgg0qLjSDgGWlmtIfrAtdHtl8cEI6k X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=Mfhsu4/f c=1 sm=1 tr=0 ts=67eb759a cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=Aj65s_fBnqv-yqA8UToA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-ORIG-GUID: opQizIkReRN_e_Ctp3LPlQt0FCqa9qqx X-Proofpoint-GUID: opQizIkReRN_e_Ctp3LPlQt0FCqa9qqx X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_01,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 mlxlogscore=999 suspectscore=0 clxscore=1015 impostorscore=0 malwarescore=0 spamscore=0 adultscore=0 phishscore=0 mlxscore=0 bulkscore=0 lowpriorityscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010033 The analogix_dp_prepare_panel() returns immediately if there is no attached panel. Drop several calls to this function which are performed when dp->plat_data->panel is NULL. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Tested-by: Damon Ding --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 22 +-----------------= ---- 1 file changed, 1 insertion(+), 21 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 042154e2d8ccd74ac2dc27fe527e810a50e08a09..ab1cfc340aa95bbf13fe021bd33= 227b565a5458d 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1005,17 +1005,11 @@ static int analogix_dp_get_modes(struct drm_connect= or *connector) { struct analogix_dp_device *dp =3D to_dp(connector); const struct drm_edid *drm_edid; - int ret, num_modes =3D 0; + int num_modes =3D 0; =20 if (dp->plat_data->panel) { num_modes +=3D drm_panel_get_modes(dp->plat_data->panel, connector); } else { - ret =3D analogix_dp_prepare_panel(dp, true, false); - if (ret) { - DRM_ERROR("Failed to prepare panel (%d)\n", ret); - return 0; - } - drm_edid =3D drm_edid_read_ddc(connector, &dp->aux.ddc); =20 drm_edid_connector_update(&dp->connector, drm_edid); @@ -1024,10 +1018,6 @@ static int analogix_dp_get_modes(struct drm_connecto= r *connector) num_modes +=3D drm_edid_connector_add_modes(&dp->connector); drm_edid_free(drm_edid); } - - ret =3D analogix_dp_prepare_panel(dp, false, false); - if (ret) - DRM_ERROR("Failed to unprepare panel (%d)\n", ret); } =20 if (dp->plat_data->get_modes) @@ -1087,19 +1077,9 @@ analogix_dp_detect(struct drm_connector *connector, = bool force) if (dp->plat_data->panel) return connector_status_connected; =20 - ret =3D analogix_dp_prepare_panel(dp, true, false); - if (ret) { - DRM_ERROR("Failed to prepare panel (%d)\n", ret); - return connector_status_disconnected; - } - if (!analogix_dp_detect_hpd(dp)) status =3D connector_status_connected; =20 - ret =3D analogix_dp_prepare_panel(dp, false, false); - if (ret) - DRM_ERROR("Failed to unprepare panel (%d)\n", ret); - return status; } =20 --=20 2.39.5 From nobody Fri Dec 19 21:35:41 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DE78A1D95A9 for ; Tue, 1 Apr 2025 05:11:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484318; cv=none; b=U7+htDsXW1CqraHmWbxKsMSs2ZK8JEPFrjxvEhiAnS4vwnXCiJtjsz44rAhawHP0/gDlzKI5sFf2u1bFG4kIxZGt8JeZ6kafLcv1kxwwPkZVVm2hc5ckfCRkH71fzzkJhFASwO/+ZHanp4bG1ynHFbdNWKe9I3eKHXKIf5Nl7io= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484318; c=relaxed/simple; bh=RS0KjeYPoBvamlmnFd2NBoW0tS+Zy7JyWmtQ+gO1iuA=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gxiSal2tP0gxPI/fG1lJLLdIfkaxZkActWf/U84dl6+cyIalMunXz4GZFmrzSZI7dIfGbd8/cRv2uogDv8/MkDOYN3nA21NBDiF+libMQ6ar19s0DwNTaxzfjUCWPZZ1Iw1628B/Prb0QFsFLSaxjusDqDh1Q+0qGRdyNNmUqP0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=AZnrR2RB; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="AZnrR2RB" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VKGQUS008415 for ; Tue, 1 Apr 2025 05:11:55 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= VBSCjPGCW0P1y4nfgwnHBrOMK8O23HlmU6c+y6UxQ9k=; b=AZnrR2RBLclL33yf lE4aAoslAssXRenWwOIZsj19y+kHwGjLhIUzu2c7sKEchcUse+cHfhcKLra1MW7B 5LS51S76TyEqRko9OFw1VV2+gS1/spQ2ErcwzYRsD7SHatKrVLFh+YPle7nTp5yX rcWwgKHhpRclTHtDpgb2r2c1TVNW+nP2LC8MoGP8CYEVLeq8qbl4CsPZIU3crrt/ bErIQt3vUtrXvDekm06xZAIsNnSuNGCcY6YFafMFnjlw9pjgYNEvtJpN5S16UDMp A8peMojvb5Q0cvhMLFqg7X2M27tP07ewc89BgUIRl8ByePDUSmM7LC1UI2w1S67J Y22WXQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45r1xnh0bc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 05:11:55 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5c77aff78so477033685a.0 for ; Mon, 31 Mar 2025 22:11:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743484315; x=1744089115; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VBSCjPGCW0P1y4nfgwnHBrOMK8O23HlmU6c+y6UxQ9k=; b=PXzbyKYxohlfvBLJNpOvoL4Ipa3F8y5+E1FabX2PCm+UCXB9etSqFbOK8vo/YxhfJ2 WvKgA5ZUdz/bsaYtdkkhuJkx9+K+hfNL+qZX1xOhMWGX3xj48FthyYzoLY3Lzzf5twa9 yI6BGQic3SjN6QH6/7zu8usbtFRCKfENenAIfuzW4/kOnmZ8MnYeIgSgn6RQ2bTJFemn zrQk9QHQScbcZpb4BcHm4tN3Qui8Aq8GDw8/QbsQGUo2Lx1wtN1tqh5uqlsWOxY6I0EU WIVwQWFL8OBPvn4Jz0j9V+E3kwGwwR2oCsloIUIxNdEPcObgVq6hQ+Yq5LpoEStEALoN X+uQ== X-Forwarded-Encrypted: i=1; AJvYcCVCKxfQyAh+4DsFmBmqq9wBLQ8HNRWlXRwn4BggngCKZFVyVPXu5He36l618PNLOYPslDceCIkW6EePY6U=@vger.kernel.org X-Gm-Message-State: AOJu0Yz0/7Yx8e0W+pVg91u0jdIIS872J0rtYQzARJs20NmPIEhiQ8q1 yVHrZyrdhoWSUFUXLkqsUpqeOJor4sIOI9Uvf6RGgr/hlqYlfrXmhFYeJ3bUIO5kFfEWeZrMu0J l7j0yWf/vFlyyBElsFq5mB0kNqituHVw624KerveO0kqkGUerULcrq4ShSWKbs1c= X-Gm-Gg: ASbGncstm7xfsQCeNye4mcVclvW086hmQPwmzNmbo5AjW5gETQSkcpAFpQ9eTCoyPaB OTw1hd3YeNicxo+r7xg0lrvoCrghjVOK8E/nOMD4qKXD8zRn5g/fXG5777R/TSwZuOwqr+wPlTH t+s19gzFVO8c8hNMyJKtFv4E1QBVNdDGPR1MkqseZFnlVcxGc5poBl6/JMnLdC0B7ETImubebya wXiFURFH3gw/CaIww1vF0xfw10tjydRaX898MksI34X4+L98zayq+yg9JkXlF+hDlmWxIOXlrrH uQPVW39fUA5FLLfPoYEdXwS4KPUMqBDJP/vXNzKdzrj2zdIM3WLYc+zc58Nyy5EYYwxIybuuepU KowlaU9Lg+o0FpXXUM6OcEa7iIqPb X-Received: by 2002:a05:620a:2904:b0:7c5:6b15:1488 with SMTP id af79cd13be357-7c6862ec10dmr1530046485a.10.1743484314726; Mon, 31 Mar 2025 22:11:54 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmq8v31bGp9RgA36fTNf4A/LLjyL/mIvfn2jtE9aoUU3ok0DTMu2FADrICd9v9edcSjrDYyw== X-Received: by 2002:a05:620a:2904:b0:7c5:6b15:1488 with SMTP id af79cd13be357-7c6862ec10dmr1530043285a.10.1743484314331; Mon, 31 Mar 2025 22:11:54 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b095a21b0sm1251697e87.243.2025.03.31.22.11.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 22:11:53 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 01 Apr 2025 08:11:34 +0300 Subject: [PATCH 2/7] drm/bridge: analogix_dp: drop unused argument to analogix_dp_prepare_panel() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250401-panel-return-void-v1-2-93e1be33dc8d@oss.qualcomm.com> References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> In-Reply-To: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3082; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=RS0KjeYPoBvamlmnFd2NBoW0tS+Zy7JyWmtQ+gO1iuA=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn63WQXl77jaWxK+F7Bmpq6cdN14tgPEK3j0x42 2HTw0DvA1KJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+t1kAAKCRCLPIo+Aiko 1eH8CACjt+43AIX/4PZirqgVYx0D+5t+Yv8ZImawHw8xlKGyQzLeC0N282H+QQrhODQpXHhYdkJ cZf4VprPLKH3cmRRw8qEZmWBl6fPVgvHlPoF5nZfJkaN42VSsgIOstrZyc0DmiBdzkR2CpxaJ/0 jT0fvN3VXrWNwnpWcTkDZin1SjHSb3BARlrzg5WvNT72FoVPpWftW1KjuQrMfzorqbdV+r1KGQx wefK+VLpLlHi96q5Sm0TRB4bh4IbQf9C2ObaztZYmfU5wbvOAiqr8lZiQRXhBAPpMmeL0xCmL8j +WHoN8Yb1kn5p2U+fMxyr9c437rdOGdbFs0QRL/l8OVryT1E X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: nVbbARTQESI9xayhhoZxvbrbbIJYh3SM X-Proofpoint-ORIG-GUID: nVbbARTQESI9xayhhoZxvbrbbIJYh3SM X-Authority-Analysis: v=2.4 cv=Qv1e3Uyd c=1 sm=1 tr=0 ts=67eb759b cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=Vyz2l5lDUG1q_RmMdnAA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_01,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 suspectscore=0 spamscore=0 mlxscore=0 impostorscore=0 adultscore=0 priorityscore=1501 bulkscore=0 phishscore=0 malwarescore=0 mlxlogscore=999 lowpriorityscore=0 clxscore=1015 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010033 After previous cleanup all calling sites pass true as is_modeset_prepare argument to analogix_dp_prepare_panel(). Drop dead code depending on that argument being false. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Tested-by: Damon Ding --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 19 +++++-------------- 1 file changed, 5 insertions(+), 14 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index ab1cfc340aa95bbf13fe021bd33227b565a5458d..82dc4b01806f9728dc882b01281= 71838e81f21b0 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -963,13 +963,13 @@ static int analogix_dp_disable_psr(struct analogix_dp= _device *dp) * If @prepare is true, this function will prepare the panel. Conversely, = if it * is false, the panel will be unprepared. * - * If @is_modeset_prepare is true, the function will disregard the current= state + * The function will disregard the current state * of the panel and either prepare/unprepare the panel based on @prepare. = Once * it finishes, it will update dp->panel_is_modeset to reflect the current= state * of the panel. */ static int analogix_dp_prepare_panel(struct analogix_dp_device *dp, - bool prepare, bool is_modeset_prepare) + bool prepare) { int ret =3D 0; =20 @@ -978,13 +978,6 @@ static int analogix_dp_prepare_panel(struct analogix_d= p_device *dp, =20 mutex_lock(&dp->panel_lock); =20 - /* - * Exit early if this is a temporary prepare/unprepare and we're already - * modeset (since we neither want to prepare twice or unprepare early). - */ - if (dp->panel_is_modeset && !is_modeset_prepare) - goto out; - if (prepare) ret =3D drm_panel_prepare(dp->plat_data->panel); else @@ -993,8 +986,7 @@ static int analogix_dp_prepare_panel(struct analogix_dp= _device *dp, if (ret) goto out; =20 - if (is_modeset_prepare) - dp->panel_is_modeset =3D prepare; + dp->panel_is_modeset =3D prepare; =20 out: mutex_unlock(&dp->panel_lock); @@ -1072,7 +1064,6 @@ analogix_dp_detect(struct drm_connector *connector, b= ool force) { struct analogix_dp_device *dp =3D to_dp(connector); enum drm_connector_status status =3D connector_status_disconnected; - int ret; =20 if (dp->plat_data->panel) return connector_status_connected; @@ -1194,7 +1185,7 @@ static void analogix_dp_bridge_atomic_pre_enable(stru= ct drm_bridge *bridge, if (old_crtc_state && old_crtc_state->self_refresh_active) return; =20 - ret =3D analogix_dp_prepare_panel(dp, true, true); + ret =3D analogix_dp_prepare_panel(dp, true); if (ret) DRM_ERROR("failed to setup the panel ret =3D %d\n", ret); } @@ -1294,7 +1285,7 @@ static void analogix_dp_bridge_disable(struct drm_bri= dge *bridge) =20 pm_runtime_put_sync(dp->dev); =20 - ret =3D analogix_dp_prepare_panel(dp, false, true); + ret =3D analogix_dp_prepare_panel(dp, false); if (ret) DRM_ERROR("failed to setup the panel ret =3D %d\n", ret); =20 --=20 2.39.5 From nobody Fri Dec 19 21:35:41 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1CB151D63DF for ; Tue, 1 Apr 2025 05:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484322; cv=none; b=ZvHWRixR32lo/r5FtwbE0BiVfQPX8C4a8k4LRuzt+J6U71sQGUQZALywtkb6uySDY26EfQRYRnjszQA8a0GaejbxnxqweXR0TiQ5QDD4sNYSFTPFM1vA7aAF2pb1GDL91yxcZwnuIU7WahzNUhGo8Oorvx6n4s+5VJnr8eET4c8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484322; c=relaxed/simple; bh=oOHLXQ/PS1QWkADzzpFvezZg/SQH0pidwF7pgTKLJlU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=c5oWx0+1/5uYMvQUlZH17xctqYhoPQLRgYc8g8S6IHvhXAT+60VNK+8Z+65QphR1pAUWmGPb23qVXqXxKrbcDF/uNTEVMhLNUsScctJ++z1RLzsYU55n2wVrtzPTyHio/N+NO0vj4U/0LJGNRZuFtTuNO8XfWoJU2J2E6tbqepA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=KU7+D20E; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="KU7+D20E" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VG8Klw031775 for ; Tue, 1 Apr 2025 05:12:00 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= o6YZL2XT5oTD9JdY1E8WLZd4k+JqH1zW6qsQBJsA92c=; b=KU7+D20E5808f+KP NgpjbPbLXZFwqtRT2kep7hT1dLmTW5H9Lee/UHQrHgZtHTGrqPO8dslmzFvfbbOK x+/RcMp2M/ZW7J/U5z6qhl36QezoHP8npXFGm+fzLxriDzw/7C+vH78bdaB0Fard uLQg307W3SEOuMG8sqRxv5rdBZltybYEMvsr1LPQNbUweXQABg9yswfLrgb0Cqid FbC7v6rN4Dg4SsMmVIkkEK0F/B5CbWp+xgpYHBKyeetBgEBTZ+WKGhNoiNMBXpN8 zbmmJD5eKSpxh3iSYapclqhfzxBsToFITqoKioLxXXX0fViF/O8VbNc7MhVsST+i R4eOdQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45qxa7sj0a-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 05:12:00 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5cd0f8961so1031021885a.1 for ; Mon, 31 Mar 2025 22:11:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743484318; x=1744089118; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=o6YZL2XT5oTD9JdY1E8WLZd4k+JqH1zW6qsQBJsA92c=; b=Iv7k958kOuI6v0088tRH5SPjLJTbA4a99Tblw4EQb4XOPTyBzSlBk2Ro6wntXDwKzU FGNlZa6DFeqHywIwK8OQ2Ozmoy1Y3XgxBLCSUWIXoPHM9jQe6I5EhkrdDg5YcSoP4V4e xYDCpyv71MGPUx29r3l2b+u9Oghf+w3xJZX5jNPDqK8dX3BQ0FM22PwsjYWFpBZN+upQ WIeWU5vY2eGYrE2HQMqWfPk3YkPpzeV3QEleA6OdEbaP2ZXrcuX6hadwP8sZe8aC2Sxj R06MB8Enm/tVdw8eHza6u6lokrEhcrDaZ9GsCbhaThW38wCsx7ylKfGeLUOwYBua7oBT aGjw== X-Forwarded-Encrypted: i=1; AJvYcCWURpMiiMA9GNN5VkPNm5ODmr+CsUq1Gz7ukSG+AI8oDEvcZl1Sso/HK/b0bTSr7pXJ61lelA9Wv9eXTEI=@vger.kernel.org X-Gm-Message-State: AOJu0Yzk06K5CznfPWvgprFUGpkpfeQShLBNoVTfMv5/qmTEu2YYfUcr g+A4j+cWgpF99/rV2mCWU2QET3A676EBV9IG/OZiTd2IZPSWeMU9V2peest46cwuoKQLtrtjPPa 2kJFvItotjc4HWYAMc/ZWbMknv8LMi/YtzqRnhs1uQbbZ7wtWjt3YHK5Lv2IF+oo= X-Gm-Gg: ASbGncvjU5tXF28EcwXq3aSeJLtvey1k4GorpOp3Wr0Zs6pnm60hhOjfbk544UiIe68 GctopJwXgaDbJQyFF+CegSiMPyOzX+mowpGdKmnZi/Y2Ch2MzIuHGOX/jBiRTx2wUTJ5lxbA4NV h+qMCqRD5Qr68jfRWLnEMxw23geAEaTOKivMkoluvGZbma4Gm5Wfjxp4kpDmUCFy0eNRLZIuJaf 6x3Eg7SWMIEcd65jYrt5Ry1WFdzyyuGWViwYzpvYoWvU6aP/gTfPieVvSItoIl03AInNnhqUL79 Wu3mj193Dn8BMTQ1aobd75H57j582oS+RsoNdAVVdjIeRBWiqLspquO14jQ08uxQ3qJVVqBpQY2 8W40R4o3SWuVjM2yGuQXVptP2ySzI X-Received: by 2002:a05:620a:2908:b0:7c5:5768:40b9 with SMTP id af79cd13be357-7c690875522mr1892740285a.43.1743484318338; Mon, 31 Mar 2025 22:11:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFkkyizkr853F+xZWRcueqn9rSKTA9DxTtGQrKq0tW8dXyPUtTl4nbZ/r8/KPTZYprk3ktRxw== X-Received: by 2002:a05:620a:2908:b0:7c5:5768:40b9 with SMTP id af79cd13be357-7c690875522mr1892738885a.43.1743484318048; Mon, 31 Mar 2025 22:11:58 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b095a21b0sm1251697e87.243.2025.03.31.22.11.54 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 22:11:55 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 01 Apr 2025 08:11:35 +0300 Subject: [PATCH 3/7] drm/bridge: analogic_dp: drop panel_is_modeset Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250401-panel-return-void-v1-3-93e1be33dc8d@oss.qualcomm.com> References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> In-Reply-To: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2305; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=oOHLXQ/PS1QWkADzzpFvezZg/SQH0pidwF7pgTKLJlU=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn63WQTU4MLspe5vr5E+cIuZXf5/aZyt03r8Xtr XhgS0FtIFeJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+t1kAAKCRCLPIo+Aiko 1VQYB/9GP2loEJeNChEDibweW7b8I4wmpDKXFgpsj8RxeJIBeBtu25iwzRmUaqfJHSbXL3O0KpQ VO2jff+Nmbppnt6MfZTXE/h3K4PpitqKfUnNqNR4Q1as1gcXR9us4WjxqoNdFNcKXjs4aj45Has vEHWRq2uV9h4u3MgmCdnBV17mLhqbIkurFSXG97KoY1FZL1bTZ3v/g/1QkTNlzyBSLfPon2MIxj CSvbitfJ3xjpftJ7Om+976ZQN+HOrO3a1BdMyf4Yq0qy0xqkCTxfyaeiTN66rDJdO3KOvdEnCgA ulTL3euYtUMGx5CQz0fQpwPvR0uR43i4YqwcHOLUZs6UZvk0 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: EJOjj260WQg9K5N0kxR30wPKv9t9HKCv X-Proofpoint-GUID: EJOjj260WQg9K5N0kxR30wPKv9t9HKCv X-Authority-Analysis: v=2.4 cv=J9Oq7BnS c=1 sm=1 tr=0 ts=67eb75a0 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=7AO8d6WWEX918e1AdasA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_01,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010033 The dp->panel_is_modeset is now a write-only field. Drop it completely. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Tested-by: Damon Ding --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 11 +---------- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 1 - 2 files changed, 1 insertion(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 82dc4b01806f9728dc882b0128171838e81f21b0..704c6169116eb2601d2ad02dc72= 94455ceff5460 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -964,9 +964,7 @@ static int analogix_dp_disable_psr(struct analogix_dp_d= evice *dp) * is false, the panel will be unprepared. * * The function will disregard the current state - * of the panel and either prepare/unprepare the panel based on @prepare. = Once - * it finishes, it will update dp->panel_is_modeset to reflect the current= state - * of the panel. + * of the panel and either prepare/unprepare the panel based on @prepare. */ static int analogix_dp_prepare_panel(struct analogix_dp_device *dp, bool prepare) @@ -983,12 +981,6 @@ static int analogix_dp_prepare_panel(struct analogix_d= p_device *dp, else ret =3D drm_panel_unprepare(dp->plat_data->panel); =20 - if (ret) - goto out; - - dp->panel_is_modeset =3D prepare; - -out: mutex_unlock(&dp->panel_lock); return ret; } @@ -1532,7 +1524,6 @@ analogix_dp_probe(struct device *dev, struct analogix= _dp_plat_data *plat_data) dp->dpms_mode =3D DRM_MODE_DPMS_OFF; =20 mutex_init(&dp->panel_lock); - dp->panel_is_modeset =3D false; =20 /* * platform dp driver need containor_of the plat_data to get diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.h index 774d11574b095b093ddf2818ad5b84be6605c9bf..b679d5b71d276f458d905c93616= 0f107225bc6c5 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h @@ -170,7 +170,6 @@ struct analogix_dp_device { bool psr_supported; =20 struct mutex panel_lock; - bool panel_is_modeset; =20 struct analogix_dp_plat_data *plat_data; }; --=20 2.39.5 From nobody Fri Dec 19 21:35:41 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 716C71D2F53 for ; Tue, 1 Apr 2025 05:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484325; cv=none; b=QlrFkzVmwTkL54SpZg/3LQ6YGFghIYwSQ0/qDlINPDSh+kXPlW+I9QoBQvRJsHJaQY27e9qdFBXIDXeG43A9FzPf7Lf0n0t8NgqGX7CQGNQ0Y3XB03J1H6ygserTDce3ibubo+lFKAxhcxWn56uYpPrBOUr4MP8iz01uql8gNpY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484325; c=relaxed/simple; bh=ljnxHNh77aJKTn5PBnRyQ46dmjys7Q6lroI6kcr2K88=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=laCj4l1o5RzPinpvHUKB6/E4lWoKshYtYFm9cNUMeNu4poSSEdt1cyzqfyJn/Wz/zQ6DaBd6/V9xsuHjkCe4Eh5Qa923vKTjGLxW3dUDKP4vEfy7z8AlOE6Q5QSCb4OsDXPudjjnEN3itsfRfVz+O2AuBFVkUz0a69PnUrmtIho= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=GySIRYLN; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="GySIRYLN" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VFDx38009286 for ; Tue, 1 Apr 2025 05:12:03 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= su5HDLNPv0sRzcPmNzYwCft3R4LA3Sh56oZUJ6HjWts=; b=GySIRYLNGHbm1OAx K7XD7CAFr9HvrcWsAVJ5zIjE5YtAJJ+q3yAel+r02N50ESi6SggQzJQE1WFgr3e5 DtePswXabB1iK4dAgraXOzCJlWgLCh/2TNAsL9TukKNDXkNfKfhLq6t2nw+KVNRa LQxdDa5VWaIO0Mc58IVdCDTssY/7gyk0pxTR71sN6wLOqr7OHZDsAX6cPpvVwOVb VUvKUsXiNVbZ3pPZZkCG2AZV/Kzn9LknffHnzoH/iwTQg1rvZjnQxpRFytKszn25 Btrwqek5LmwHuaDeGLeYPIN5hxAh++ntsGK3+Wcn4wPVGy5uvDFPtl80UAfkV4Yk n4D/rQ== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45pa1nxdvu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 05:12:03 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c548e16909so487399685a.2 for ; Mon, 31 Mar 2025 22:12:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743484322; x=1744089122; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=su5HDLNPv0sRzcPmNzYwCft3R4LA3Sh56oZUJ6HjWts=; b=R6KsIDvvc715O0VCWZWUyXvjWgRsITsJbKr4bfN1PoftOmSL3f4EmyV7kE5vVTPFnc 7P7uunse8YC4eR7wego+1j2qMK0M9YDKytd+Qrg6JBZOitIwseebXphL/ozgBjApuQGK MbdF7TpSJ2KRSR0qLZrguRI1lrqKGiVVXoBa71p4kuvFVhnV6PfR8PoOgtLyvkDzf4Ay Q4MzbvQU80BtLoaOR5VmCj3Yxc8sMkYphrasJf+NTPiffBI2LXFqPPLsiWUTzAW+hRha I3lL08x7T8Mt1NlzmJftEOHrzx6wrX14dpkRSJfrUhNrmZQ2TInL7bf5zkymvB9EoGyw b91g== X-Forwarded-Encrypted: i=1; AJvYcCUQfN4jqUDGz8kl+1vdqHC/rPT4zk9E0X0hBJHn4YKxh6ngjGQXSjY7fsGGD+7Ea+E6PL/u8+5jYGDuHhA=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvaznt8ScuQD8ZBuYFapGmnTFaaTljlNMxb2CLHOtkQNFjJVQV IQX/3RzqqEgLDgH28lCxeO6jlxIXtgFQ0tTLZFEsZPGP3V86pWzuRenIe60xhRnm9WDd7TSTAZT HJh4Vb1nKO1DIKUsxCfAMRz3tSxVuHd3am4zGmz0QJSBNEPpwMz4WtF/rTBZRtc4= X-Gm-Gg: ASbGncstJdPxjXbTX8D0znS3/dV0i060sq6WF77pWCvK5EN9OKqjjm3JgF+zAzbXt/n tHwOr6DQZhFOUIgtpabTyFbzfd7MBNCWOtOLIG0sCWdwMEaSoHWQnzqmWGKOki01qZCccdiOfz2 OtWH4Sg14sYloGzDWzC3R1NwE1n3b1+2Bh1X9P/t0RIStIGppJA7+Z7CHWHWO0ztN8+BwY0NXYA eOfPtm9GAXVVrC3s7J6BMqFhFNDJkto17RfkFrjIPfN16lpsHEBg58yOm6KGHNIpepLT6xjplRy rFUAIgEXwX3IONF/YwzKR6lbMrKIHKj7G9Gj5PUHTIm/4hiJInN4uWZLS2k/7VJxVHFaGspZ+XH 4KwhDiry2L6kWRFk13oabZeZPvyLk X-Received: by 2002:a05:620a:2a0b:b0:7c5:4b37:ae49 with SMTP id af79cd13be357-7c69089511cmr1850601385a.48.1743484322114; Mon, 31 Mar 2025 22:12:02 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHfkh+VwvyZqGWd26i2DZpAeXVnuJcT2uXByll2V8BgpOUSTAvnwlH3MR5aeFbdPqlccIuedw== X-Received: by 2002:a05:620a:2a0b:b0:7c5:4b37:ae49 with SMTP id af79cd13be357-7c69089511cmr1850598585a.48.1743484321703; Mon, 31 Mar 2025 22:12:01 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b095a21b0sm1251697e87.243.2025.03.31.22.11.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 22:11:59 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 01 Apr 2025 08:11:36 +0300 Subject: [PATCH 4/7] drm/bridge: analogic_dp: drop panel_lock Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250401-panel-return-void-v1-4-93e1be33dc8d@oss.qualcomm.com> References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> In-Reply-To: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=1985; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=ljnxHNh77aJKTn5PBnRyQ46dmjys7Q6lroI6kcr2K88=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn63WQ9JDhpO2O3km+J66d3OvjPxAK1AuTTf1XK 9nMcbqhsXqJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+t1kAAKCRCLPIo+Aiko 1d2jCACvEOox/CQElqeioCPPoLsvAIxMwsML921E+NqK2RDDDcNofLsW12QfFmN4lf9xy3tbJ2h 021oWlZ6tZF0FEUMjYqCe6OgIOaDaOCH2M1x0QVRLzVYOPzh/IAZeVGMA0VCtwylSfD17NqvK91 vJ39nQupM51Yiq1BrM8jXCQG0hHmAfK8L5gpjSbL2Rxz6usoM1fbhtZdzKad+RJb7xsS9+W0DWu wljR/PcNZNKEiZDd5L15P74eNEgh1BAVP3UYCUOWxSJphSs4oHFSKi/KpT23St7eLsPh/S+MR+/ H8xy5QoBR5qqJgTmEQF3iU9JXnBFdY7sXLZmSeGl7g9YrCPQ X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: iMTuo-_TY0CiLpoII72vYc62Gnpk-hHw X-Proofpoint-GUID: iMTuo-_TY0CiLpoII72vYc62Gnpk-hHw X-Authority-Analysis: v=2.4 cv=MPlgmNZl c=1 sm=1 tr=0 ts=67eb75a3 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=KfGKz8IhEdz9gtDduwEA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_01,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 lowpriorityscore=0 malwarescore=0 suspectscore=0 phishscore=0 spamscore=0 clxscore=1015 bulkscore=0 mlxlogscore=999 impostorscore=0 mlxscore=0 adultscore=0 priorityscore=1501 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010033 The analogix_dp_prepare_panel() function is called from bridge's atomic_pre_enable() and atomic_post_disable() callbacks, which can not happen simultaneously. Drop the useless mutex. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Tested-by: Damon Ding --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 5 ----- drivers/gpu/drm/bridge/analogix/analogix_dp_core.h | 2 -- 2 files changed, 7 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 704c6169116eb2601d2ad02dc7294455ceff5460..1ec4d277fe6bb03ad9eb8451ae2= af5ad5ada0978 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -974,14 +974,11 @@ static int analogix_dp_prepare_panel(struct analogix_= dp_device *dp, if (!dp->plat_data->panel) return 0; =20 - mutex_lock(&dp->panel_lock); - if (prepare) ret =3D drm_panel_prepare(dp->plat_data->panel); else ret =3D drm_panel_unprepare(dp->plat_data->panel); =20 - mutex_unlock(&dp->panel_lock); return ret; } =20 @@ -1523,8 +1520,6 @@ analogix_dp_probe(struct device *dev, struct analogix= _dp_plat_data *plat_data) dp->dev =3D &pdev->dev; dp->dpms_mode =3D DRM_MODE_DPMS_OFF; =20 - mutex_init(&dp->panel_lock); - /* * platform dp driver need containor_of the plat_data to get * the driver private data, so we need to store the point of diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.h index b679d5b71d276f458d905c936160f107225bc6c5..2b54120ba4a3ef55af518a0629a= 5c8469f275a0f 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.h @@ -169,8 +169,6 @@ struct analogix_dp_device { bool fast_train_enable; bool psr_supported; =20 - struct mutex panel_lock; - struct analogix_dp_plat_data *plat_data; }; =20 --=20 2.39.5 From nobody Fri Dec 19 21:35:41 2025 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8F9E1E2312 for ; Tue, 1 Apr 2025 05:12:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484329; cv=none; b=EO+XkkAhNjJskqwHQcJm3IIUkQBYokgk7qPdHD5QvFtZqa3+TGxIt2gvQvoUTJ12j1VAG5Hs/o90TJTwKGm06D2kw+1XBDtnHlCLrENwTWOsCHLa0NWlCv1cNvpMd3MZhN2bDfKw0RUqy3l9p2AdD8KuCPGmgkdjD12HfBzF5uU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484329; c=relaxed/simple; bh=MlFndke6G/BiAttpO7gjjEBObPGtgF0yacJKuJFSOi4=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=U5wETS9UMvLYihkkk1G9rksGJ9xJ7bJvs1/Tfi5Hb1W/PmHoGHN8LvDHAGHk4LPtYOZOETsddU+me0/p+rhy1Yb+8wXG1tVQbp05N1cXckgojfASywNfMB13WaJ+vMYzommF7rn1vUKFTFVxNhEOOWoktXFcv6gWBpMJ0qlQlnA= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=jwJh+sYM; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="jwJh+sYM" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VKCt94019810 for ; Tue, 1 Apr 2025 05:12:06 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0UCfqpWUdUcNvimGZ1R1IpBbubClaHeqHcxpWdaScnE=; b=jwJh+sYMtDYECFOC GDaeEH5NXWRKXhM6QRPdmkX2HTCptptJwQQZHu/EL/MDFiWhXCNno9yhamXzGlrp YfS4eMJIQT44YJ1rqPKVRjBONr0LDXZ97LB6bb9Zf1ldaOefLijq3IBjT/v7FnXy TKi9lQqoobD+7eXvheydE5MYxQFbhKGfqYw9m7F7aIeX4b1AKjYBxQ4bDL3bq1qm hGujtoilQUyKBb9oiUJIfAcMTsQHMC29sQ+uG6zaIWALU9Lf/piSiEdqj/EJ9aRp e8MXXozoAXHD4JZ7R7+EgRxa2VnFWmWy8c2Z4XfyUMBd3uaqeImnA75lulQ5KLng iUHvkw== Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45r1vn90hb-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 05:12:06 +0000 (GMT) Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7c5e2872e57so951334385a.0 for ; Mon, 31 Mar 2025 22:12:06 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743484326; x=1744089126; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0UCfqpWUdUcNvimGZ1R1IpBbubClaHeqHcxpWdaScnE=; b=ZEujTNfFZgZtBwSUFGRpY57jX52HalsWvd2cznQR+sxWAGhdN8Qkz85QLJlBglqkqH k3o4M4UtJNbAj6Bk+vvnfochUSEV7p2EfPz5yvJtRclxIaPMErlPGdH6tKGlqOLQdl/l 6V4il7c/3Are1r/fDllDVEw491R6gJgMgmQIqT14R1pjPBp7Tf/z3yvWOA8UR/pE2vW4 Qf3WdRP2DuOt5crhx8S3Uo2LOH3kNMVO0RatPlMq0SrgZFZdF4LOZZWiy6riOGtg6yPn LWEQgtXYnEwUcUFYZPBr/WEfsaQja+abYvzwoMIPBj9EtdH+5Rc7xBmnwaoqxGrRiu4J 7DgQ== X-Forwarded-Encrypted: i=1; AJvYcCW/1qCTAY73+xYxlDpZp0wQG3eBoQAFLEpt/gCMFtKQ/7kepD+0nX76xrf2Psq8QpeigxZq7JvBFDBgoC4=@vger.kernel.org X-Gm-Message-State: AOJu0Yw+51eNycCI6aBmmxP5vKbPEzr/k1JuZ/M3QRZgMfy2VONPMrDr lbNfN5QZO3KRHd9oJAX4vc2sO9jdeOu7dvharCVaaJqWNjNB9wDRmp87pD8wdvHYbj5p/q18FGb LsK0x4IDqFDDSxcxQ50GqOECMZvh3dbpxt+xrM2aCKZhCmaqGEMwWyExPFFr4phQ= X-Gm-Gg: ASbGncs2po25YzHgK5GZ3aXp3hldQGm7XFZnsKlbnL6nn6ttJi4+h0Hm58iYlkOef+d GA2zYs+u+DnzYvUuWqJTrbemTXtKCvVVpnYGCjf//38ay+CVjEGzo+TncpSeH9A7a5oDYNUbiyw V+GfXU7kwW2AAeLSEm7q2tA5uQ671wzG6B4MroBhDhLmStA+bZ+3sDTf0LXDevoJd8Tt7N23IVO K+GdtcGBFDA7pZZAPMfM9pUpRFqcs4sFoNmbXx6sLDfppmxK/n2oClm0EgVqo3Jm6Ur6M2ZWwPw lDrUIG78fBAeAydtnF/tHnvC5jUAjcFPVzPuJBcR6FPotQwhTsvBPV4HoyFq3ZNVxROuP39yAL3 DAg6ar44sVULBV5FF3bGRQPN8pKS2 X-Received: by 2002:a05:620a:294b:b0:7c5:f6d9:86ec with SMTP id af79cd13be357-7c6908757d6mr1708208285a.35.1743484325692; Mon, 31 Mar 2025 22:12:05 -0700 (PDT) X-Google-Smtp-Source: AGHT+IH1zNjxGnB5My+rC0jxfqxqMFbTxnTup9jnK/AiA2lDXPM6z0hy3tkrX7AvXWBzpu54TzEAfQ== X-Received: by 2002:a05:620a:294b:b0:7c5:f6d9:86ec with SMTP id af79cd13be357-7c6908757d6mr1708206585a.35.1743484325402; Mon, 31 Mar 2025 22:12:05 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b095a21b0sm1251697e87.243.2025.03.31.22.12.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 22:12:03 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 01 Apr 2025 08:11:37 +0300 Subject: [PATCH 5/7] drm/bridge: analogix_dp: inline analogix_dp_prepare_panel() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250401-panel-return-void-v1-5-93e1be33dc8d@oss.qualcomm.com> References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> In-Reply-To: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=2731; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=MlFndke6G/BiAttpO7gjjEBObPGtgF0yacJKuJFSOi4=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn63WRhHYAe1OS/1/tk3Sz9qb4KIliPm2jbNOgb RtAp4hv+7yJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+t1kQAKCRCLPIo+Aiko 1SeJB/99DcUiEZ0lm8NGUnz3EMICHzz708VEx8dlGlQCVd6oQueDlCPIK1fl2K/lFHHmcvMg65q 0ijG7EnkVwUj8ILoNZO0VtHSfjZTpfVMWecoSy7cNZJ9HZItlcPZ1ZHui3+bPVz47zMj1geQmGP Rf2VwMzBc4pkhXs51AstB9xkwZj78rjLlQfLzfXpBpryZh4bp/iqRTdWCVppitXBPP6yrTVgeTB fYt0/O7VpAE0+brLpUMLZPY/Bhj/N/6MeJ0BaXi01lXq98yioQWO2xXi/UmdZyVo1jnBcaXIfAF Nmck8Q7RhoU7aCLN4HdVAeqdQEfK5BQ+v07+UFMsGOKylkLb X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Authority-Analysis: v=2.4 cv=UL3dHDfy c=1 sm=1 tr=0 ts=67eb75a6 cx=c_pps a=HLyN3IcIa5EE8TELMZ618Q==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=06SpEF9E26xvXwvOrpsA:9 a=QEXdDO2ut3YA:10 a=bTQJ7kPSJx9SKPbeHEYW:22 X-Proofpoint-ORIG-GUID: z1y9w7-1KCrLRiv8_Q7IA9ZX3bGj-5I4 X-Proofpoint-GUID: z1y9w7-1KCrLRiv8_Q7IA9ZX3bGj-5I4 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_01,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 phishscore=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 spamscore=0 bulkscore=0 clxscore=1015 suspectscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010033 The analogix_dp_prepare_panel() is now only calling a corresponding drm_panel function. Inline it to simplify the code. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Tested-by: Damon Ding --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 43 +++++-------------= ---- 1 file changed, 10 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index 1ec4d277fe6bb03ad9eb8451ae2af5ad5ada0978..f60068011008482f7b7b2edfcab= 5fb1b3e9e130f 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -955,33 +955,6 @@ static int analogix_dp_disable_psr(struct analogix_dp_= device *dp) return analogix_dp_send_psr_spd(dp, &psr_vsc, true); } =20 -/* - * This function is a bit of a catch-all for panel preparation, hopefully - * simplifying the logic of functions that need to prepare/unprepare the p= anel - * below. - * - * If @prepare is true, this function will prepare the panel. Conversely, = if it - * is false, the panel will be unprepared. - * - * The function will disregard the current state - * of the panel and either prepare/unprepare the panel based on @prepare. - */ -static int analogix_dp_prepare_panel(struct analogix_dp_device *dp, - bool prepare) -{ - int ret =3D 0; - - if (!dp->plat_data->panel) - return 0; - - if (prepare) - ret =3D drm_panel_prepare(dp->plat_data->panel); - else - ret =3D drm_panel_unprepare(dp->plat_data->panel); - - return ret; -} - static int analogix_dp_get_modes(struct drm_connector *connector) { struct analogix_dp_device *dp =3D to_dp(connector); @@ -1174,9 +1147,11 @@ static void analogix_dp_bridge_atomic_pre_enable(str= uct drm_bridge *bridge, if (old_crtc_state && old_crtc_state->self_refresh_active) return; =20 - ret =3D analogix_dp_prepare_panel(dp, true); - if (ret) - DRM_ERROR("failed to setup the panel ret =3D %d\n", ret); + if (dp->plat_data->panel) { + ret =3D drm_panel_prepare(dp->plat_data->panel); + if (ret) + DRM_ERROR("failed to prepare the panel ret =3D %d\n", ret); + } } =20 static int analogix_dp_set_bridge(struct analogix_dp_device *dp) @@ -1274,9 +1249,11 @@ static void analogix_dp_bridge_disable(struct drm_br= idge *bridge) =20 pm_runtime_put_sync(dp->dev); =20 - ret =3D analogix_dp_prepare_panel(dp, false); - if (ret) - DRM_ERROR("failed to setup the panel ret =3D %d\n", ret); + if (dp->plat_data->panel) { + ret =3D drm_panel_unprepare(dp->plat_data->panel); + if (ret) + DRM_ERROR("failed to unprepare the panel ret =3D %d\n", ret); + } =20 dp->fast_train_enable =3D false; dp->psr_supported =3D false; --=20 2.39.5 From nobody Fri Dec 19 21:35:41 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 11AE41D9A70 for ; Tue, 1 Apr 2025 05:12:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484333; cv=none; b=I6Uatv+xXgKn/ihb2QIdkiaj8T1ffWu2vQ0G4XdGFZWUlK2gpN6sUYYDgk8pOFpf10/EobeZoIER36ExYl6g+zxAHits+p95ZoooNbDKIWfjFmac8desrYkmVZAWefTPn56Pvh7p7sNnX6BrWSISi5LFAp/BvkaPM9giVa8B34w= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484333; c=relaxed/simple; bh=NJl7bsXfNLqpNqUOkFTfyECJOLD0rCpvvEtqImrQuV8=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qvPy3eP7dWWhTuUxR1Wt8CC/fL54t2xBFWrD/PoFPyy3ey3sgMoOE+HlPNMP7ef8svCf7d0Q1Nqeh4v7vw8M9YKIB7SmaOvW2z5sFPRo4f+qGxu5V9Ky/27fo7Zo2EdIfNMpceH1h2xGIsmm6HhHRdoak2IGYgOWpJf7xZ9BVH8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=OQo7V+Pt; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="OQo7V+Pt" Received: from pps.filterd (m0279867.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VFD4F2026983 for ; Tue, 1 Apr 2025 05:12:11 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= RzXLwKeO3UWlZHuYhJkCQ7vw+BiQ3N3j/vqzkaMxh64=; b=OQo7V+PtnCVB22oV UQzcSe8WKRANQ55hbH1CiU2dY/Hv32wN5yNqAXnCj0DCK7yry+ewzhC1StsxAlka g+8U1zLqeoPGjYN6P+xYoJN+SKpN7yzn9iHOtRGhXpzModLSFTxmL4pnixZl0Qdi rqFbaDeqOV/Rv9Z+pJEmTbO/RhWsrHH26gTzF5t0cHZATiXGSyNUbDMPAXMCRnUZ QyfrUpTkbsp2K0MOrwmRguyHe+0k3r8AyMGllT/wqFp/QjMeINw3dFaH2xtknY/E f+HbJgNv3tv5kTDUcFGJRb839QYeizneGpSErfPLxDBHANf9EuwsTsmRjKBgg0yV FFLFcA== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45p6jhpr1f-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 05:12:10 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-7c54e7922a1so1199649085a.2 for ; Mon, 31 Mar 2025 22:12:10 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743484329; x=1744089129; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=RzXLwKeO3UWlZHuYhJkCQ7vw+BiQ3N3j/vqzkaMxh64=; b=Sq7qaM76gEbVcvFjJwWPl4mTpp8EWzxfdcVcNLZm9KK/YuUs8DhwlyeL1S+A7MNVmg 3mpgBRugAym/fw/5bL8wwXSH+cIWQANbI7qeWW7kWnugwUUHGLBDSmlqV9K8a60yWpEJ 8ZXfmMPdW8kZD80q+yppPnJ4efvgVKVQa+8IW4yE3LHGoGMAQDatoURXiBikj5MFaO3P udtzDKQhrtV+1aYfVu5vtAZxCus3b1OGCVBB9YWtdBxY2HbRA650cJNg5iKsZB4q4FcU DNCRdbEoK2wO7uK96TwIy1C5jWy9kXKy3teFE2+j7ImUmLimG3efedLqieUJAGaVqJYA TcPA== X-Forwarded-Encrypted: i=1; AJvYcCXTYWhAcCUI+R5TJIfLgLyguu7jFtro4xxJ473C3Fknin66e31Li5GhWq3A24Q0iz+zeMgTm1H3hdtM+5o=@vger.kernel.org X-Gm-Message-State: AOJu0YwGRcaYrgXvuJwsazf8FIjDag2KcSiSU8fHr5wxko1wU3NXGjC+ ytr5z2SHzAXsWk7LsYelhRZJSco5gCWv+nIxwcFiFBysSh4NhGoKX1FbjrvxNMuxbyEvnLX8A4J B0bF62aSfXPrVprGLkYptZcMk3Fsd0DO/Qr8IujW52gBpBIDk/GRQ68fzCCU1114= X-Gm-Gg: ASbGncsR1E/pCOMS39efBRVNfZMvb5F/aA8RjRG2aMmN6Evb5xGCpl5r2RC185vHwPb hPZOgGfB3BYekNXOJdroM1bKPD8vPLXbhVq6zkz6NofjZ9S7WE7GQfxJ7GKznoOx7K5zkvB12Ac tW2QIh142BWhyDFzPCcFkFw/7l0cI1Io6JOTQfI1P6ovEsPQBfHhrm5QXaGh0vWEQjh2CH1OYvd jVHFqV822ToezEz5eQRKYGvQK8c2Nfb2L+kMrOz1Q7ocItrwdBdVdOBBha9hauGyVkXVeFA1G1l qDLj+2YTn7wHAlJM1orfp55kYAYVx1lCQxv0USS/Uwu9hJmqocnYNUb2SJ3V/jdLhOWswdrG99L 9iow5YE1oDBTuLOFz+lBevSQGWv1b X-Received: by 2002:a05:620a:3950:b0:7c5:4949:23f2 with SMTP id af79cd13be357-7c6908756d3mr1644562285a.44.1743484329400; Mon, 31 Mar 2025 22:12:09 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEZ/M7+Jnk+uK2Lr8W86kFPh1dzbXpco8cTxC1B6tbBsO/4N53MtP19Yw6evFH+z30KAW771A== X-Received: by 2002:a05:620a:3950:b0:7c5:4949:23f2 with SMTP id af79cd13be357-7c6908756d3mr1644559285a.44.1743484329010; Mon, 31 Mar 2025 22:12:09 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b095a21b0sm1251697e87.243.2025.03.31.22.12.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 22:12:06 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 01 Apr 2025 08:11:38 +0300 Subject: [PATCH 6/7] drm/bridge: analogix_dp: ignore return values of drm_panel_* calls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250401-panel-return-void-v1-6-93e1be33dc8d@oss.qualcomm.com> References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> In-Reply-To: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=3703; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=NJl7bsXfNLqpNqUOkFTfyECJOLD0rCpvvEtqImrQuV8=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn63WRGK/Kq2L2EzNQw3/2jLhnkOU7Fr5jcjpTL n+0mz6GO/eJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+t1kQAKCRCLPIo+Aiko 1bJwB/9wEq7tEGADlYD+RoVIKmJWwgU1otLJ1mX9j6GkBVMnGx1UwZw1OsNcKmJ36nK7ZKughYz 3PXLs4vW0AxOpkk8pWSY3vvnSvxExp4DhNfQKuAl36u1+mLfNDw/QpWcL6MhIT/73Dzco2af0A1 AMf9j+y6n8gwV2uT+8R6Z/inO28KqY0ThHsZaDdmuf8znOdq2SfA0PSOeQrfU+UcUL3FhPV5wSo HnBI0L+3NzIagrb9GzySE4suhsbhm7WhBQR6oCyi89z60XGwmP9Kyqd2d2FFcMvSlhmMJJDpfor j8/FKOleLOG9z/OBh1vm6Nnhm7ouIhofqHCY30Su46Age0Gc X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-GUID: lm52sbIcmNYoPv-2OZuxhAAl7nv17eaz X-Proofpoint-ORIG-GUID: lm52sbIcmNYoPv-2OZuxhAAl7nv17eaz X-Authority-Analysis: v=2.4 cv=bZZrUPPB c=1 sm=1 tr=0 ts=67eb75ab cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=fEsDx3e4H4ijciuaGfYA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_01,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 priorityscore=1501 clxscore=1015 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 spamscore=0 malwarescore=0 mlxscore=0 impostorscore=0 mlxlogscore=999 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010033 Follow the example of other drivers and ignore return values of the drm_panel_prepare() / unprepare() / enable() / disable() calls. There is no possible error recovery, so the driver just logs a message. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong Tested-by: Damon Ding --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 39 ++++--------------= ---- 1 file changed, 6 insertions(+), 33 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/g= pu/drm/bridge/analogix/analogix_dp_core.c index f60068011008482f7b7b2edfcab5fb1b3e9e130f..c7dffdae31877ae194fc6b0a5bf= 21be203f7dcc4 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -838,10 +838,7 @@ static int analogix_dp_commit(struct analogix_dp_devic= e *dp) int ret; =20 /* Keep the panel disabled while we configure video */ - if (dp->plat_data->panel) { - if (drm_panel_disable(dp->plat_data->panel)) - DRM_ERROR("failed to disable the panel\n"); - } + drm_panel_disable(dp->plat_data->panel); =20 ret =3D analogix_dp_train_link(dp); if (ret) { @@ -863,13 +860,7 @@ static int analogix_dp_commit(struct analogix_dp_devic= e *dp) } =20 /* Safe to enable the panel now */ - if (dp->plat_data->panel) { - ret =3D drm_panel_enable(dp->plat_data->panel); - if (ret) { - DRM_ERROR("failed to enable the panel\n"); - return ret; - } - } + drm_panel_enable(dp->plat_data->panel); =20 /* Check whether panel supports fast training */ ret =3D analogix_dp_fast_link_train_detection(dp); @@ -1136,7 +1127,6 @@ static void analogix_dp_bridge_atomic_pre_enable(stru= ct drm_bridge *bridge, struct analogix_dp_device *dp =3D bridge->driver_private; struct drm_crtc *crtc; struct drm_crtc_state *old_crtc_state; - int ret; =20 crtc =3D analogix_dp_get_new_crtc(dp, old_state); if (!crtc) @@ -1147,11 +1137,7 @@ static void analogix_dp_bridge_atomic_pre_enable(str= uct drm_bridge *bridge, if (old_crtc_state && old_crtc_state->self_refresh_active) return; =20 - if (dp->plat_data->panel) { - ret =3D drm_panel_prepare(dp->plat_data->panel); - if (ret) - DRM_ERROR("failed to prepare the panel ret =3D %d\n", ret); - } + drm_panel_prepare(dp->plat_data->panel); } =20 static int analogix_dp_set_bridge(struct analogix_dp_device *dp) @@ -1231,17 +1217,11 @@ static void analogix_dp_bridge_atomic_enable(struct= drm_bridge *bridge, static void analogix_dp_bridge_disable(struct drm_bridge *bridge) { struct analogix_dp_device *dp =3D bridge->driver_private; - int ret; =20 if (dp->dpms_mode !=3D DRM_MODE_DPMS_ON) return; =20 - if (dp->plat_data->panel) { - if (drm_panel_disable(dp->plat_data->panel)) { - DRM_ERROR("failed to disable the panel\n"); - return; - } - } + drm_panel_disable(dp->plat_data->panel); =20 disable_irq(dp->irq); =20 @@ -1249,11 +1229,7 @@ static void analogix_dp_bridge_disable(struct drm_br= idge *bridge) =20 pm_runtime_put_sync(dp->dev); =20 - if (dp->plat_data->panel) { - ret =3D drm_panel_unprepare(dp->plat_data->panel); - if (ret) - DRM_ERROR("failed to unprepare the panel ret =3D %d\n", ret); - } + drm_panel_unprepare(dp->plat_data->panel); =20 dp->fast_train_enable =3D false; dp->psr_supported =3D false; @@ -1678,10 +1654,7 @@ void analogix_dp_unbind(struct analogix_dp_device *d= p) analogix_dp_bridge_disable(dp->bridge); dp->connector.funcs->destroy(&dp->connector); =20 - if (dp->plat_data->panel) { - if (drm_panel_unprepare(dp->plat_data->panel)) - DRM_ERROR("failed to turnoff the panel\n"); - } + drm_panel_unprepare(dp->plat_data->panel); =20 drm_dp_aux_unregister(&dp->aux); =20 --=20 2.39.5 From nobody Fri Dec 19 21:35:41 2025 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1BBB1E51F1 for ; Tue, 1 Apr 2025 05:12:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484338; cv=none; b=bzAh4iAwZzebqNS3N0P2MVAaOy3vKzIpfovnHUdJaMr9C7ewCwkPi3x/kW5n9aQkmHMQ1MxgY1SitmZXwQefTPV9ZXKlt9bwJ2Fkzp521idxNsZsxBFCtkLz8qyv9c1rKmmo1SYRkowGh3o48IaBHhlGRZzuprC5i+VVeMOw4sA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1743484338; c=relaxed/simple; bh=fQDSEEOLghqW0gqjtjiP2QZkz7fbMPIZN5amp5V1z7k=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=qogHLnngg6/OZfMyzn6UsF4c3e4AjgA6QVHFBpCr0GfeDWSYf53Ouup7VXPqpwm6Ecjb3oxXQYLWNaO23yMdRRJq73ufoZaoHu5BreCWBIU/Mt0AaKJksz5PB/eJEdsHFX2RuXU1mAbiucM2fxcbNdtY6/YyDMDiGxS6YCU/3qw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=p3tZmKqC; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="p3tZmKqC" Received: from pps.filterd (m0279863.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 52VG8Ouh031810 for ; Tue, 1 Apr 2025 05:12:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= SufW+r80Y9ER9ibdcVkSFCKfUrwEDR608dkdfliv+88=; b=p3tZmKqCivwj6XHX U5SiYPiT/xpskR9YVFyYuE9Kqe0dp9Jd1L2QedWVS8gxrwiy/oQXMTQ9WndI/wsR u5E9mc8+vL8OR7oP6G52XVWKzj+gfhuxHk8AbIcoNEhm57F6bKP0oXw7Ndz86JFf m1joS18m3iUDxXQYVD7hm0T/QxsoOjFTZhWdv9ia1iekGF432TVC4Ws3ZKMm64mC OnpnI9iVamHMxeKLHl50rLy/K/oO7eODMhi7T27tzsWsQIAt6B2briKShDXV96yI IEQD+6eiRB1pIQzzL6vKRXXQSXeTLDp2U3e/KFFB/lU6Pc5qRx0HhQTPGiKas7/f TVPsWA== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 45qxa7sj14-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 01 Apr 2025 05:12:16 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-6e900f6dcadso108994976d6.3 for ; Mon, 31 Mar 2025 22:12:15 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1743484333; x=1744089133; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=SufW+r80Y9ER9ibdcVkSFCKfUrwEDR608dkdfliv+88=; b=DVIuNtrlD/C+jcmtfd1PNG8dCXfAXjFfvArOpgFoCF0WU7wttypWgNqvfJE+t0KIZ1 5YxvcBSTFd3N6OrsvHMNO1rDezMuZjo0PWg5e5Hbog7VxwllwSgR4rmNpOu4DbniLi+d qPNwQJB0m/nFx1FOAaOhiWN/mcjXneUBQaR4Osms+5QCWum1IXZleLWZRM78c0QPZD16 sXs0yd+5Afchw3mrsMgn7jsLYNxK/IPFCWXkYT0Sx6q5tm24GdLN4vxCrPuQya9a2ov9 +5FrNYcJq2369FwwFMQQDCDmqlp9k1QR7M1uBUWfotK8yOmmvWMlf6C8vV+zl8mVHzy7 Zmwg== X-Forwarded-Encrypted: i=1; AJvYcCXmBTQ0Gaf+kckKtjxax7fAgNUGQa9KsS6II9TIfPcUOomb8j4xoFJIJbOx/zZLK7xskksZ9m46ywWRapQ=@vger.kernel.org X-Gm-Message-State: AOJu0YywSVGfKghbfrnH7Zqx1p0lSZ2JApm81XSGLryRmYDFl0h9ivfS AYzuBmG/lmbrmST5nO2oFRYp/wpQ5I6TYiALZWR/LlYykFgySeDsGFtVF93Q/fdr2yeZ6d72hUs Dp2ReQEJS/npiRlgyH5AzYh1DqgNNQ3vKbI/cZjlOqK+smwsRpTllvUwpKKNG9ls= X-Gm-Gg: ASbGnctNWyaqKeqH9DWM1CojPQkRibo/BrzHsEcuY9nj9tKC2boHIlVYjpa7OKGUZ3K eo06pLUgf31cHA+tGY5m9KcOJsNtpqG1rEQKr4ceW2ph6T0YYMJq4DFwL3JdsDZPeVr5drDi33A d7sr9qnuLWLyvAbZB/pnaKA7191zl6pNHXAu72fuqc5MvpWuwBVbohKEpVVInQSCyXe5mQqXsK9 yo3IJtage1xIpOrSwbNiey1mhzIBFBe1L3/H+9bauj1/IW+zHwtlG7bdmlSeM02WqwktVG4yRiN 21E+d0hHZFznVEI3LRqrXtZqhVzLhEqxStMVUTwBMHkmd099JMQNgoeA93n1IP95twrBgDvojEW ogpYyR2A19H5UwI4QOafnD3saOYTG X-Received: by 2002:a05:620a:2908:b0:7c5:5768:40b9 with SMTP id af79cd13be357-7c690875522mr1892799585a.43.1743484333136; Mon, 31 Mar 2025 22:12:13 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEsior20lc9lixXbnK9mQBmXS1qNDNvJUiHmjCz+r6N/SDHxsQVRBDDeDs6C8IGTz71trkGnw== X-Received: by 2002:a05:620a:2908:b0:7c5:5768:40b9 with SMTP id af79cd13be357-7c690875522mr1892797985a.43.1743484332707; Mon, 31 Mar 2025 22:12:12 -0700 (PDT) Received: from umbar.lan (2001-14ba-a0c3-3a00-264b-feff-fe8b-be8a.rev.dnainternet.fi. [2001:14ba:a0c3:3a00:264b:feff:fe8b:be8a]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-54b095a21b0sm1251697e87.243.2025.03.31.22.12.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 31 Mar 2025 22:12:10 -0700 (PDT) From: Dmitry Baryshkov Date: Tue, 01 Apr 2025 08:11:39 +0300 Subject: [PATCH 7/7] drm/panel: make prepare/enable and disable/unprepare calls return void Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250401-panel-return-void-v1-7-93e1be33dc8d@oss.qualcomm.com> References: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> In-Reply-To: <20250401-panel-return-void-v1-0-93e1be33dc8d@oss.qualcomm.com> To: Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jessica Zhang Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=openpgp-sha256; l=7332; i=dmitry.baryshkov@oss.qualcomm.com; h=from:subject:message-id; bh=fQDSEEOLghqW0gqjtjiP2QZkz7fbMPIZN5amp5V1z7k=; b=owEBbQGS/pANAwAKAYs8ij4CKSjVAcsmYgBn63WRJEYlwE9X9glklAyZRqGVoodvfMuP5sFdR tn4AgM0ExuJATMEAAEKAB0WIQRMcISVXLJjVvC4lX+LPIo+Aiko1QUCZ+t1kQAKCRCLPIo+Aiko 1Y3tB/9MOw1hOc0MzrJv7Ez3RcHJYHujcXQo2I5d1f1gaHB12EZL8MgwagBso+OSR28vrQu58br /ww6UqV0ft6YROBZ+MHu7IWY68AGd3+l2ToCPm7iu9DNAKhInXQlXYwlgXcLiqMwH9LOxKS7FC6 qSUXWxgQIKqe08dlO9jq8w7JkvXVQxtzBQ+2NPNc73q5HZSGT4lbh/V4oxG1arkUcnDFwrJ+fr8 xG+x/98cP0SQB8/9OcgBs6gE7tyqWKkT4xuQPHc6vxLgQKjs6qz4p3uIMziCtA2Q5OtZsF8Rif9 dFkE/xiO2FES1ksV4FIY6TI9H1eNb5xQXj3PT9b25oBzrtj1 X-Developer-Key: i=dmitry.baryshkov@oss.qualcomm.com; a=openpgp; fpr=8F88381DD5C873E4AE487DA5199BF1243632046A X-Proofpoint-ORIG-GUID: GpUJS1BIfcwVuO2XNqlWcHJChF1tdEPi X-Proofpoint-GUID: GpUJS1BIfcwVuO2XNqlWcHJChF1tdEPi X-Authority-Analysis: v=2.4 cv=J9Oq7BnS c=1 sm=1 tr=0 ts=67eb75b0 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=XR8D0OoHHMoA:10 a=EUspDBNiAAAA:8 a=rpcUNz5-J_niPHj66PUA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1095,Hydra:6.0.680,FMLib:17.12.68.34 definitions=2025-04-01_01,2025-03-27_02,2024-11-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 priorityscore=1501 phishscore=0 lowpriorityscore=0 bulkscore=0 malwarescore=0 mlxscore=0 mlxlogscore=999 adultscore=0 spamscore=0 suspectscore=0 impostorscore=0 classifier=spam authscore=0 authtc=n/a authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2502280000 definitions=main-2504010033 Now there are no users of the return value of the drm_panel_prepare(), drm_panel_unprepare(), drm_panel_enable() and drm_panel_disable() calls. Usually these calls are performed from the atomic callbacks, where it is impossible to return an error. Stop returning error codes and return void instead. Signed-off-by: Dmitry Baryshkov Reviewed-by: Neil Armstrong --- drivers/gpu/drm/drm_panel.c | 54 +++++++++------------= ---- drivers/gpu/drm/panel/panel-newvision-nv3051d.c | 9 +---- include/drm/drm_panel.h | 8 ++-- 3 files changed, 26 insertions(+), 45 deletions(-) diff --git a/drivers/gpu/drm/drm_panel.c b/drivers/gpu/drm/drm_panel.c index c627e42a7ce70459f50eb5095fffc806ca45dabf..faa7a76b63b53b3a45b3400d8bf= 3b58a027a340e 100644 --- a/drivers/gpu/drm/drm_panel.c +++ b/drivers/gpu/drm/drm_panel.c @@ -105,21 +105,21 @@ EXPORT_SYMBOL(drm_panel_remove); * * Calling this function will enable power and deassert any reset signals = to * the panel. After this has completed it is possible to communicate with = any - * integrated circuitry via a command bus. - * - * Return: 0 on success or a negative error code on failure. + * integrated circuitry via a command bus. This function cannot fail (as i= t is + * called from the pre_enable call chain). There will always be a call to + * drm_panel_disable() afterwards. */ -int drm_panel_prepare(struct drm_panel *panel) +void drm_panel_prepare(struct drm_panel *panel) { struct drm_panel_follower *follower; int ret; =20 if (!panel) - return -EINVAL; + return; =20 if (panel->prepared) { dev_warn(panel->dev, "Skipping prepare of already prepared panel\n"); - return 0; + return; } =20 mutex_lock(&panel->follower_lock); @@ -138,11 +138,8 @@ int drm_panel_prepare(struct drm_panel *panel) follower->funcs->panel_prepared, ret); } =20 - ret =3D 0; exit: mutex_unlock(&panel->follower_lock); - - return ret; } EXPORT_SYMBOL(drm_panel_prepare); =20 @@ -154,16 +151,14 @@ EXPORT_SYMBOL(drm_panel_prepare); * reset, turn off power supplies, ...). After this function has completed= , it * is usually no longer possible to communicate with the panel until anoth= er * call to drm_panel_prepare(). - * - * Return: 0 on success or a negative error code on failure. */ -int drm_panel_unprepare(struct drm_panel *panel) +void drm_panel_unprepare(struct drm_panel *panel) { struct drm_panel_follower *follower; int ret; =20 if (!panel) - return -EINVAL; + return; =20 /* * If you are seeing the warning below it likely means one of two things: @@ -176,7 +171,7 @@ int drm_panel_unprepare(struct drm_panel *panel) */ if (!panel->prepared) { dev_warn(panel->dev, "Skipping unprepare of already unprepared panel\n"); - return 0; + return; } =20 mutex_lock(&panel->follower_lock); @@ -195,11 +190,8 @@ int drm_panel_unprepare(struct drm_panel *panel) } panel->prepared =3D false; =20 - ret =3D 0; exit: mutex_unlock(&panel->follower_lock); - - return ret; } EXPORT_SYMBOL(drm_panel_unprepare); =20 @@ -209,26 +201,26 @@ EXPORT_SYMBOL(drm_panel_unprepare); * * Calling this function will cause the panel display drivers to be turned= on * and the backlight to be enabled. Content will be visible on screen after - * this call completes. - * - * Return: 0 on success or a negative error code on failure. + * this call completes. This function cannot fail (as it is called from the + * enable call chain). There will always be a call to drm_panel_disable() + * afterwards. */ -int drm_panel_enable(struct drm_panel *panel) +void drm_panel_enable(struct drm_panel *panel) { int ret; =20 if (!panel) - return -EINVAL; + return; =20 if (panel->enabled) { dev_warn(panel->dev, "Skipping enable of already enabled panel\n"); - return 0; + return; } =20 if (panel->funcs && panel->funcs->enable) { ret =3D panel->funcs->enable(panel); if (ret < 0) - return ret; + return; } panel->enabled =3D true; =20 @@ -236,8 +228,6 @@ int drm_panel_enable(struct drm_panel *panel) if (ret < 0) DRM_DEV_INFO(panel->dev, "failed to enable backlight: %d\n", ret); - - return 0; } EXPORT_SYMBOL(drm_panel_enable); =20 @@ -248,15 +238,13 @@ EXPORT_SYMBOL(drm_panel_enable); * This will typically turn off the panel's backlight or disable the displ= ay * drivers. For smart panels it should still be possible to communicate wi= th * the integrated circuitry via any command bus after this call. - * - * Return: 0 on success or a negative error code on failure. */ -int drm_panel_disable(struct drm_panel *panel) +void drm_panel_disable(struct drm_panel *panel) { int ret; =20 if (!panel) - return -EINVAL; + return; =20 /* * If you are seeing the warning below it likely means one of two things: @@ -269,7 +257,7 @@ int drm_panel_disable(struct drm_panel *panel) */ if (!panel->enabled) { dev_warn(panel->dev, "Skipping disable of already disabled panel\n"); - return 0; + return; } =20 ret =3D backlight_disable(panel->backlight); @@ -280,11 +268,9 @@ int drm_panel_disable(struct drm_panel *panel) if (panel->funcs && panel->funcs->disable) { ret =3D panel->funcs->disable(panel); if (ret < 0) - return ret; + return; } panel->enabled =3D false; - - return 0; } EXPORT_SYMBOL(drm_panel_disable); =20 diff --git a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c b/drivers/gpu/= drm/panel/panel-newvision-nv3051d.c index 5d115ecd5dd44c8e5e7d1fb8afe573324e987f59..b6429795e8f518646443dd8179f= 3ec28cef4dc0f 100644 --- a/drivers/gpu/drm/panel/panel-newvision-nv3051d.c +++ b/drivers/gpu/drm/panel/panel-newvision-nv3051d.c @@ -413,15 +413,10 @@ static int panel_nv3051d_probe(struct mipi_dsi_device= *dsi) static void panel_nv3051d_shutdown(struct mipi_dsi_device *dsi) { struct panel_nv3051d *ctx =3D mipi_dsi_get_drvdata(dsi); - int ret; =20 - ret =3D drm_panel_unprepare(&ctx->panel); - if (ret < 0) - dev_err(&dsi->dev, "Failed to unprepare panel: %d\n", ret); + drm_panel_unprepare(&ctx->panel); =20 - ret =3D drm_panel_disable(&ctx->panel); - if (ret < 0) - dev_err(&dsi->dev, "Failed to disable panel: %d\n", ret); + drm_panel_disable(&ctx->panel); } =20 static void panel_nv3051d_remove(struct mipi_dsi_device *dsi) diff --git a/include/drm/drm_panel.h b/include/drm/drm_panel.h index a9c042c8dea1a82ef979c7a68204e0b55483fc28..18bf338c8b96254dc3f2880106b= 944e71ea4c9a7 100644 --- a/include/drm/drm_panel.h +++ b/include/drm/drm_panel.h @@ -275,11 +275,11 @@ void drm_panel_init(struct drm_panel *panel, struct d= evice *dev, void drm_panel_add(struct drm_panel *panel); void drm_panel_remove(struct drm_panel *panel); =20 -int drm_panel_prepare(struct drm_panel *panel); -int drm_panel_unprepare(struct drm_panel *panel); +void drm_panel_prepare(struct drm_panel *panel); +void drm_panel_unprepare(struct drm_panel *panel); =20 -int drm_panel_enable(struct drm_panel *panel); -int drm_panel_disable(struct drm_panel *panel); +void drm_panel_enable(struct drm_panel *panel); +void drm_panel_disable(struct drm_panel *panel); =20 int drm_panel_get_modes(struct drm_panel *panel, struct drm_connector *con= nector); =20 --=20 2.39.5