On Mon, 24 Feb 2025 at 13:16, Lu Baolu <baolu.lu@linux.intel.com> wrote:
>
> None of the drivers implement anything for IOMMU_DEV_FEAT_IOPF anymore,
> remove it to avoid dead code.
>
> Signed-off-by: Lu Baolu <baolu.lu@linux.intel.com>
> Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
Acked-by: Zhangfei Gao <zhangfei.gao@linaro.org>
> ---
> drivers/misc/uacce/uacce.c | 31 -------------------------------
> 1 file changed, 31 deletions(-)
>
> diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c
> index 2a1db2abeeca..42e7d2a2a90c 100644
> --- a/drivers/misc/uacce/uacce.c
> +++ b/drivers/misc/uacce/uacce.c
> @@ -465,31 +465,6 @@ static void uacce_release(struct device *dev)
> kfree(uacce);
> }
>
> -static unsigned int uacce_enable_sva(struct device *parent, unsigned int flags)
> -{
> - int ret;
> -
> - if (!(flags & UACCE_DEV_SVA))
> - return flags;
> -
> - flags &= ~UACCE_DEV_SVA;
> -
> - ret = iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_IOPF);
> - if (ret) {
> - dev_err(parent, "failed to enable IOPF feature! ret = %pe\n", ERR_PTR(ret));
> - return flags;
> - }
> - return flags | UACCE_DEV_SVA;
> -}
> -
> -static void uacce_disable_sva(struct uacce_device *uacce)
> -{
> - if (!(uacce->flags & UACCE_DEV_SVA))
> - return;
> -
> - iommu_dev_disable_feature(uacce->parent, IOMMU_DEV_FEAT_IOPF);
> -}
> -
> /**
> * uacce_alloc() - alloc an accelerator
> * @parent: pointer of uacce parent device
> @@ -509,8 +484,6 @@ struct uacce_device *uacce_alloc(struct device *parent,
> if (!uacce)
> return ERR_PTR(-ENOMEM);
>
> - flags = uacce_enable_sva(parent, flags);
> -
> uacce->parent = parent;
> uacce->flags = flags;
> uacce->ops = interface->ops;
> @@ -533,7 +506,6 @@ struct uacce_device *uacce_alloc(struct device *parent,
> return uacce;
>
> err_with_uacce:
> - uacce_disable_sva(uacce);
> kfree(uacce);
> return ERR_PTR(ret);
> }
> @@ -596,9 +568,6 @@ void uacce_remove(struct uacce_device *uacce)
> unmap_mapping_range(q->mapping, 0, 0, 1);
> }
>
> - /* disable sva now since no opened queues */
> - uacce_disable_sva(uacce);
> -
> if (uacce->cdev)
> cdev_device_del(uacce->cdev, &uacce->dev);
> xa_erase(&uacce_xa, uacce->dev_id);
> --
> 2.43.0
>