From nobody Thu Dec 18 08:27:56 2025 Received: from mgamail.intel.com (mgamail.intel.com [192.198.163.12]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A14591FCD05 for ; Mon, 24 Feb 2025 05:16:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=192.198.163.12 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740374214; cv=none; b=p6SHH6lei6kKbM4kDSuITzQnTupXZbaLaGKrQEhMPeWP1e6281Qcs0+a9VacNYtCepwub9N48v/3Vq3UE1gX0HnByzOnyyVT+geYd2XFnal3IkfR0bgRd8lzqRwv+iZIasqMykXp52NvYTeFjh03WIlC3vCiBuwuozHZdGh2NMs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740374214; c=relaxed/simple; bh=EswJHTflb8JG/PQEfKlYrvy16IWIFI2K2YLSNPbeqDQ=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=neY1OniDokY3zex1NYc1aiTDSA1CNU70AzArYsvFaQ2sxDxwryiPvS2OvRjT7bpQNxRK62VqmKFsMa92yzv0LD72/0RCwpsa6VBKeBYHAiCrlMqLplzpsUOl8YGVSi2177hFz2AVv+8Q4sUHxQV/YQU6Cm5n4TAzh1bB/Sxf84k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com; spf=none smtp.mailfrom=linux.intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=N2W6197D; arc=none smtp.client-ip=192.198.163.12 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=linux.intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="N2W6197D" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1740374213; x=1771910213; h=from:to:cc:subject:date:message-id:in-reply-to: references:mime-version:content-transfer-encoding; bh=EswJHTflb8JG/PQEfKlYrvy16IWIFI2K2YLSNPbeqDQ=; b=N2W6197DenFETjD70ct2KfXinIZ4RNq+zP9uVKc2NVRquaGYCPxruHNd h8C2rI6S++Eg1Xx/B5FPsaMkIiZZhEqPUIzsZH9TZdr+66YrkyFYSf20c KTi2ugPzNWRXo96sswnLE05XLXkJ19E0D6mggvlf+XpdKj7xIVLlWFXIa SkfbeV3Ubhxv7cpb080RgeQ7iMAeB7dCf/GXeAxrUqWrkeflqOeTNBzyC Xy0PTsE7o1gWLQS+tV2EbBpBAftaioQ8DJFQC/2tp/RFg/Xs1TzvkpOMP hIIkyZd5RHgACSJT6tv4UqRprItlf58XeR8QM3Tvo3fac4aY4+ixDzim/ g==; X-CSE-ConnectionGUID: QXSqGVilQy+GodFg73hYjQ== X-CSE-MsgGUID: pLw16UlCTm6/AVXww4qjxQ== X-IronPort-AV: E=McAfee;i="6700,10204,11354"; a="45024282" X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="45024282" Received: from fmviesa008.fm.intel.com ([10.60.135.148]) by fmvoesa106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Feb 2025 21:16:52 -0800 X-CSE-ConnectionGUID: Kar7TYlBSW2flGS1D2NG4g== X-CSE-MsgGUID: opsHVVcySMKP6APxURTLSQ== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,309,1732608000"; d="scan'208";a="116143426" Received: from allen-box.sh.intel.com ([10.239.159.52]) by fmviesa008.fm.intel.com with ESMTP; 23 Feb 2025 21:16:49 -0800 From: Lu Baolu To: Joerg Roedel , Will Deacon , Robin Murphy , Jason Gunthorpe , Kevin Tian Cc: Dave Jiang , Vinod Koul , Fenghua Yu , Zhangfei Gao , Zhou Wang , iommu@lists.linux.dev, linux-kernel@vger.kernel.org, Lu Baolu , Jason Gunthorpe Subject: [PATCH v2 10/12] uacce: Remove unnecessary IOMMU_DEV_FEAT_IOPF Date: Mon, 24 Feb 2025 13:16:24 +0800 Message-ID: <20250224051627.2956304-11-baolu.lu@linux.intel.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20250224051627.2956304-1-baolu.lu@linux.intel.com> References: <20250224051627.2956304-1-baolu.lu@linux.intel.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" None of the drivers implement anything for IOMMU_DEV_FEAT_IOPF anymore, remove it to avoid dead code. Signed-off-by: Lu Baolu Reviewed-by: Jason Gunthorpe Acked-by: Zhangfei Gao Reviewed-by: Kevin Tian --- drivers/misc/uacce/uacce.c | 31 ------------------------------- 1 file changed, 31 deletions(-) diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c index 2a1db2abeeca..42e7d2a2a90c 100644 --- a/drivers/misc/uacce/uacce.c +++ b/drivers/misc/uacce/uacce.c @@ -465,31 +465,6 @@ static void uacce_release(struct device *dev) kfree(uacce); } =20 -static unsigned int uacce_enable_sva(struct device *parent, unsigned int f= lags) -{ - int ret; - - if (!(flags & UACCE_DEV_SVA)) - return flags; - - flags &=3D ~UACCE_DEV_SVA; - - ret =3D iommu_dev_enable_feature(parent, IOMMU_DEV_FEAT_IOPF); - if (ret) { - dev_err(parent, "failed to enable IOPF feature! ret =3D %pe\n", ERR_PTR(= ret)); - return flags; - } - return flags | UACCE_DEV_SVA; -} - -static void uacce_disable_sva(struct uacce_device *uacce) -{ - if (!(uacce->flags & UACCE_DEV_SVA)) - return; - - iommu_dev_disable_feature(uacce->parent, IOMMU_DEV_FEAT_IOPF); -} - /** * uacce_alloc() - alloc an accelerator * @parent: pointer of uacce parent device @@ -509,8 +484,6 @@ struct uacce_device *uacce_alloc(struct device *parent, if (!uacce) return ERR_PTR(-ENOMEM); =20 - flags =3D uacce_enable_sva(parent, flags); - uacce->parent =3D parent; uacce->flags =3D flags; uacce->ops =3D interface->ops; @@ -533,7 +506,6 @@ struct uacce_device *uacce_alloc(struct device *parent, return uacce; =20 err_with_uacce: - uacce_disable_sva(uacce); kfree(uacce); return ERR_PTR(ret); } @@ -596,9 +568,6 @@ void uacce_remove(struct uacce_device *uacce) unmap_mapping_range(q->mapping, 0, 0, 1); } =20 - /* disable sva now since no opened queues */ - uacce_disable_sva(uacce); - if (uacce->cdev) cdev_device_del(uacce->cdev, &uacce->dev); xa_erase(&uacce_xa, uacce->dev_id); --=20 2.43.0