.../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++- arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++- 2 files changed, 785 insertions(+), 10 deletions(-)
Since the driver and dt-bindings have been alread merged, it has been
agreed offline that there is no point of holding on to these DT patches
even though there are some issues with plug/unplug during suspend in
both pmic-glink-altmode and ucsi-glink. These issues are being worked on
meanwhile. Merging these means that even though this will provide external DP
and USB orientation, plug/unplug during suspend will give some splats
and render both the USB orientation and DP broken. But then, other
X Elite boards already have these nodes described, so lets bring the crd
and t14s to the same level.
These patches are just a resend of the ones found in v5 and dropped in the v6
patchset of the driver and dt-bindings.
Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/
Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
---
Abel Vesa (4):
arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers
arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support
arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers
arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support
.../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++-
arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++-
2 files changed, 785 insertions(+), 10 deletions(-)
---
base-commit: 50a0c754714aa3ea0b0e62f3765eb666a1579f24
change-id: 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-325cdb7b097d
Best regards,
--
Abel Vesa <abel.vesa@linaro.org>
On Thu, Feb 20, 2025 at 07:42:29PM +0200, Abel Vesa wrote: > Since the driver and dt-bindings have been alread merged, it has been > agreed offline that there is no point of holding on to these DT patches > even though there are some issues with plug/unplug during suspend in > both pmic-glink-altmode and ucsi-glink. These issues are being worked on > meanwhile. Merging these means that even though this will provide external DP > and USB orientation, plug/unplug during suspend will give some splats > and render both the USB orientation and DP broken. But then, other > X Elite boards already have these nodes described, so lets bring the crd > and t14s to the same level. > > These patches are just a resend of the ones found in v5 and dropped in the v6 > patchset of the driver and dt-bindings. > Thank you, Abel. Unfortunately I merged a X1P series from Konrad, so this no longer applies. Can you please help me rebase it onto linux-next? Regards, Bjorn > Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/ > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Abel Vesa (4): > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support > > .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++- > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++- > 2 files changed, 785 insertions(+), 10 deletions(-) > --- > base-commit: 50a0c754714aa3ea0b0e62f3765eb666a1579f24 > change-id: 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-325cdb7b097d > > Best regards, > -- > Abel Vesa <abel.vesa@linaro.org> >
On Thu, Feb 20, 2025 at 07:42:29PM +0200, Abel Vesa wrote: > Since the driver and dt-bindings have been alread merged, it has been > agreed offline that there is no point of holding on to these DT patches > even though there are some issues with plug/unplug during suspend in > both pmic-glink-altmode and ucsi-glink. These issues are being worked on > meanwhile. Merging these means that even though this will provide external DP > and USB orientation, plug/unplug during suspend will give some splats > and render both the USB orientation and DP broken. But then, other > X Elite boards already have these nodes described, so lets bring the crd > and t14s to the same level. > > These patches are just a resend of the ones found in v5 and dropped in the v6 > patchset of the driver and dt-bindings. > > Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/ > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > --- > Abel Vesa (4): > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support It looks like you've addressed all the comments I had on v1 (except for a stray newline after a t14s port@2 node) and I've been running with these patches for a long time now without any issues (other than the glink hotplug issues mentioned above): Reviewed-by: Johan Hovold <johan+linaro@kernel.org> Tested-by: Johan Hovold <johan+linaro@kernel.org> Johan
On 25-02-21 10:25:00, Johan Hovold wrote: > On Thu, Feb 20, 2025 at 07:42:29PM +0200, Abel Vesa wrote: > > Since the driver and dt-bindings have been alread merged, it has been > > agreed offline that there is no point of holding on to these DT patches > > even though there are some issues with plug/unplug during suspend in > > both pmic-glink-altmode and ucsi-glink. These issues are being worked on > > meanwhile. Merging these means that even though this will provide external DP > > and USB orientation, plug/unplug during suspend will give some splats > > and render both the USB orientation and DP broken. But then, other > > X Elite boards already have these nodes described, so lets bring the crd > > and t14s to the same level. > > > > These patches are just a resend of the ones found in v5 and dropped in the v6 > > patchset of the driver and dt-bindings. > > > > Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/ > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > --- > > Abel Vesa (4): > > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support > > It looks like you've addressed all the comments I had on v1 (except for Oh, sorry, missed that one. Let me respin. > a stray newline after a t14s port@2 node) and I've been running with > these patches for a long time now without any issues (other than the > glink hotplug issues mentioned above): > > Reviewed-by: Johan Hovold <johan+linaro@kernel.org> > Tested-by: Johan Hovold <johan+linaro@kernel.org> > > Johan Thanks for reviewing and testing! Abel
On Fri, Feb 21, 2025 at 11:41:48AM +0200, Abel Vesa wrote: > On 25-02-21 10:25:00, Johan Hovold wrote: > > On Thu, Feb 20, 2025 at 07:42:29PM +0200, Abel Vesa wrote: > > > Abel Vesa (4): > > > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > > > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > > > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > > > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support > > > > It looks like you've addressed all the comments I had on v1 (except for > > Oh, sorry, missed that one. > > Let me respin. I don't think you need to respin over just that. And that extra newline has already been copy-pasted into two more dts in mainline since (yeah, it's odd to see the original patch go in after the copies). We can just take a pass at cleaning this up at some later point. Johan
On 2/20/25 18:42, Abel Vesa wrote: > Since the driver and dt-bindings have been alread merged, it has been > agreed offline that there is no point of holding on to these DT patches > even though there are some issues with plug/unplug during suspend in > both pmic-glink-altmode and ucsi-glink. These issues are being worked on > meanwhile. Merging these means that even though this will provide external DP > and USB orientation, plug/unplug during suspend will give some splats > and render both the USB orientation and DP broken. But then, other > X Elite boards already have these nodes described, so lets bring the crd > and t14s to the same level. > > These patches are just a resend of the ones found in v5 and dropped in the v6 > patchset of the driver and dt-bindings. > > Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/ > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> If you will be respinning, could you please add link-frequencies to enable HBR3 speeds, similarly to [1]? Alternatively, I can also send fixups once this series lands. [1] https://lore.kernel.org/all/20250226231436.16138-1-alex.vinarskis@gmail.com/ Thanks, Alex > --- > Abel Vesa (4): > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support > > .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++- > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++- > 2 files changed, 785 insertions(+), 10 deletions(-) > --- > base-commit: 50a0c754714aa3ea0b0e62f3765eb666a1579f24 > change-id: 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-325cdb7b097d > > Best regards,
On 25-03-07 23:03:07, Aleksandrs Vinarskis wrote: > > > On 2/20/25 18:42, Abel Vesa wrote: > > Since the driver and dt-bindings have been alread merged, it has been > > agreed offline that there is no point of holding on to these DT patches > > even though there are some issues with plug/unplug during suspend in > > both pmic-glink-altmode and ucsi-glink. These issues are being worked on > > meanwhile. Merging these means that even though this will provide external DP > > and USB orientation, plug/unplug during suspend will give some splats > > and render both the USB orientation and DP broken. But then, other > > X Elite boards already have these nodes described, so lets bring the crd > > and t14s to the same level. > > > > These patches are just a resend of the ones found in v5 and dropped in the v6 > > patchset of the driver and dt-bindings. > > > > Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/ > > > > Signed-off-by: Abel Vesa <abel.vesa@linaro.org> > > If you will be respinning, could you please add link-frequencies to > enable HBR3 speeds, similarly to [1]? Alternatively, I can also send > fixups once this series lands. It's already re-spun here: https://lore.kernel.org/all/20250304-x1e80100-dts-crd-t14s-enable-typec-retimers-v6-0-e5a49fae4e94@linaro.org/ Waiting to be merged. Lets make the HBR3 enablement a separate patchset as I'm not able to test it in time, if we want external DP to be part of 6.15. > > [1] > https://lore.kernel.org/all/20250226231436.16138-1-alex.vinarskis@gmail.com/ > > Thanks, > Alex > > > --- > > Abel Vesa (4): > > arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers > > arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support > > arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers > > arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support > > > > .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++- > > arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++- > > 2 files changed, 785 insertions(+), 10 deletions(-) > > --- > > base-commit: 50a0c754714aa3ea0b0e62f3765eb666a1579f24 > > change-id: 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-325cdb7b097d > > > > Best regards, >
On 3/9/25 10:23, Abel Vesa wrote: > On 25-03-07 23:03:07, Aleksandrs Vinarskis wrote: >> >> >> On 2/20/25 18:42, Abel Vesa wrote: >>> Since the driver and dt-bindings have been alread merged, it has been >>> agreed offline that there is no point of holding on to these DT patches >>> even though there are some issues with plug/unplug during suspend in >>> both pmic-glink-altmode and ucsi-glink. These issues are being worked on >>> meanwhile. Merging these means that even though this will provide external DP >>> and USB orientation, plug/unplug during suspend will give some splats >>> and render both the USB orientation and DP broken. But then, other >>> X Elite boards already have these nodes described, so lets bring the crd >>> and t14s to the same level. >>> >>> These patches are just a resend of the ones found in v5 and dropped in the v6 >>> patchset of the driver and dt-bindings. >>> >>> Link to v5: https://lore.kernel.org/all/20241112-x1e80100-ps8830-v5-0-4ad83af4d162@linaro.org/ >>> >>> Signed-off-by: Abel Vesa <abel.vesa@linaro.org> >> >> If you will be respinning, could you please add link-frequencies to >> enable HBR3 speeds, similarly to [1]? Alternatively, I can also send >> fixups once this series lands. > > > It's already re-spun here: > > https://lore.kernel.org/all/20250304-x1e80100-dts-crd-t14s-enable-typec-retimers-v6-0-e5a49fae4e94@linaro.org/ > > Waiting to be merged. My bad, somehow missed the respin. > > Lets make the HBR3 enablement a separate patchset as I'm not able to > test it in time, if we want external DP to be part of 6.15. > Sure. Will send as follow up once its merged. Thanks, Alex >> >> [1] >> https://lore.kernel.org/all/20250226231436.16138-1-alex.vinarskis@gmail.com/ >> >> Thanks, >> Alex >> >>> --- >>> Abel Vesa (4): >>> arm64: dts: qcom: x1e80100-crd: Describe the Parade PS8830 retimers >>> arm64: dts: qcom: x1e80100-crd: Enable external DisplayPort support >>> arm64: dts: qcom: x1e80100-t14s: Describe the Parade PS8830 retimers >>> arm64: dts: qcom: x1e80100-t14s: Enable external DisplayPort support >>> >>> .../dts/qcom/x1e78100-lenovo-thinkpad-t14s.dts | 321 +++++++++++++- >>> arch/arm64/boot/dts/qcom/x1e80100-crd.dts | 474 ++++++++++++++++++++- >>> 2 files changed, 785 insertions(+), 10 deletions(-) >>> --- >>> base-commit: 50a0c754714aa3ea0b0e62f3765eb666a1579f24 >>> change-id: 20250220-x1e80100-dts-crd-t14s-enable-typec-retimers-325cdb7b097d >>> >>> Best regards, >>
© 2016 - 2025 Red Hat, Inc.