[PATCH v3 0/6] rust: treewide: add missing newlines to printing calls

Alban Kurti posted 6 patches 1 year ago
Documentation/rust/testing.rst  |  2 +-
rust/kernel/error.rs            |  2 +-
rust/kernel/init.rs             | 12 ++++++------
rust/kernel/init/macros.rs      |  6 +++---
rust/kernel/sync/locked_by.rs   |  2 +-
rust/kernel/workqueue.rs        |  6 +++---
samples/rust/rust_print_main.rs |  8 ++++----
7 files changed, 19 insertions(+), 19 deletions(-)
[PATCH v3 0/6] rust: treewide: add missing newlines to printing calls
Posted by Alban Kurti 1 year ago
Adding newline at the end of all Rust pr_* and dev_* macro
calls that miss a newline.
`pr_*!` and `dev_*!` macros are supposed to be called
with a newline at the end, just like in the C side
such that independent lines are not visually missed.
There were no dev_*! cases with a missing newline found.

Signed-off-by: Alban Kurti <kurti@invicto.ai>
---
Changes in v3:
- Same code changes to v2, but split patches into multiple patches
  and improved the descriptions

---
Alban Kurti (6):
      rust: docs: add missing newline to printing macro examples
      rust: error: add missing newline to pr_warn! calls
      rust: init: add missing newline to pr_info! calls
      rust: sync: add missing newline in locked_by log example
      rust: workqueue: add missing newline to pr_info! examples
      rust: samples: add missing newline to pr_info! calls in rust_print_main

 Documentation/rust/testing.rst  |  2 +-
 rust/kernel/error.rs            |  2 +-
 rust/kernel/init.rs             | 12 ++++++------
 rust/kernel/init/macros.rs      |  6 +++---
 rust/kernel/sync/locked_by.rs   |  2 +-
 rust/kernel/workqueue.rs        |  6 +++---
 samples/rust/rust_print_main.rs |  8 ++++----
 7 files changed, 19 insertions(+), 19 deletions(-)
---
base-commit: ceff0757f5dafb5be5205988171809c877b1d3e3
change-id: 20250206-printing_fix-e7a7950b9e7c

Best regards,
-- 
Alban Kurti <kurti@invicto.ai>
Re: [PATCH v3 0/6] rust: treewide: add missing newlines to printing calls
Posted by Miguel Ojeda 11 months, 1 week ago
On Thu, Feb 6, 2025 at 10:08 PM Alban Kurti <kurti@invicto.ai> wrote:
>
>       rust: docs: add missing newline to printing macro examples
>       rust: error: add missing newline to pr_warn! calls
>       rust: init: add missing newline to pr_info! calls
>       rust: sync: add missing newline in locked_by log example
>       rust: workqueue: add missing newline to pr_info! examples

Applied these (i.e. the first 5) to `rust-fixes` -- thanks everyone!

    [ Replaced Closes with Link since it fixes part of the issue. - Miguel ]

    [ Replaced Closes with Link since it fixes part of the issue. - Miguel ]

    [ Replaced Closes with Link since it fixes part of the issue. Added
      one more Fixes tag (still same set of stable kernels). - Miguel ]

    [ Replaced Closes with Link since it fixes part of the issue. - Miguel ]

    [ Replaced Closes with Link since it fixes part of the issue. - Miguel ]

Alban: please feel free to send the last one split (please see my
other message) -- thanks!

Cheers,
Miguel