From nobody Sun Feb 8 23:59:07 2026 Received: from black.elm.relay.mailchannels.net (black.elm.relay.mailchannels.net [23.83.212.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EFA771E1035; Thu, 6 Feb 2025 21:26:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=23.83.212.19 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738877170; cv=pass; b=q66puGk6LQtCs9iwgr3nOCSVlK+WBkJx3asjXhI2uuuId6NldvhqM2rLVa3o9fpsaLgt1fp1+czI8EkoqdwtQW1NZ0pPVACkLXbVA2f6jtW+KVPC0znyOpmJuzn9Q2lQpWUOkIXwM9rB0tKDJGHjEd4oLzzKMsRSjpoCmiv+WiA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738877170; c=relaxed/simple; bh=Aoq8DR0tmBwK/2qmp6nHnMm7CfMGYf5gDRatYYdmJS4=; h=From:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc:Date; b=uRZLVF70lCLOqiObr74SwW8pq1j+9qQMp9NW6Z3feEVFgZHnlQzgUanM+YOl5cWyGGj1HGhFANLKsNSAIlMN4oxtcyVsPOBpZYtb7x9uEryWdOk6OGcoJGj5VB8zOFPJEWisqkY0SoyzUH8Dsl+njetYx2cuDwiLk5iCf3ocfKU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai; spf=pass smtp.mailfrom=invicto.ai; dkim=fail (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b=UdaOjjry reason="key not found in DNS"; arc=pass smtp.client-ip=23.83.212.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=invicto.ai Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b="UdaOjjry" X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5B209161EA9; Thu, 6 Feb 2025 21:07:59 +0000 (UTC) Received: from fr-int-smtpout8.hostinger.io (trex-3.trex.outbound.svc.cluster.local [100.125.12.218]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id 169D9161B25; Thu, 6 Feb 2025 21:07:54 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1738876079; a=rsa-sha256; cv=none; b=SS2OZOpxhGLSWS4WYX3g8CdxQUp/uNdJD6w3hcSK3mf2L3zOlZEUWP4nB7d0DQHz97+iHd SbbFLC2/iuehUNzVG5W8qphOeJifufNH/9nEEUkdg8YePQIs5vQoxaKW+n8aJrrb/iku7J GFqRLUaLV62F5EoY6bmAxyQXmHPfHOWN7epPNkFWGbgKr2EfGxTqDOaw3g81ZAF5pvV0AQ saEnNoZesEizafATZYObRGaA7hUIKakk6uXCvWD+oORiWE12zeTtJkW64yP0R8BT7GGSEq 4E7I9G2ANrYN+wKIbZ5h78mUhFTRd7cgynGY/hQfyFJxfVYMVjumx2I4YzLkRQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1738876079; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=QiXyubdeOKIcHLGUBolab2yRgrtdSgwKfCo8KFHBIQ0=; b=W535iN4cjuht4mFgWuEjluFesNq+1YAgpndQrsd5cnJegSOLFU9s8E9KGbf0i5PjRzBayi SKDMz0HTXalG6aUxRlRCX+2tYkO1se+S/uzZURgg6HCSwwKSr8MfqwFMBuWjIjEwscIIxa aNbzXF31wM1j2q/bQBEviZPsRQDwjtJZUT1w7M76DxJ8mCwKUSntEFqe7w6ysil/Jtq1nK jsckRKXHHaAGd9MZ3O/PkHzqsK4vQjOpJfm6sj1h+1emHV5MDdrtO9psTsKSdY2gKiT7ku 1K/NhkS5pA854yfP1MzRuowIjcVUf9J6lz7NjKHeOAJvFosutIZlN3IKhpRYXg== ARC-Authentication-Results: i=1; rspamd-8586946c78-zkzf8; auth=pass smtp.auth=hostingeremail smtp.mailfrom=kurti@invicto.ai X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|kurti@invicto.ai X-MailChannels-Auth-Id: hostingeremail X-Keen-Thread: 40f4450b18a3cc77_1738876079201_511394290 X-MC-Loop-Signature: 1738876079201:1092380178 X-MC-Ingress-Time: 1738876079200 Received: from fr-int-smtpout8.hostinger.io (fr-int-smtpout8.hostinger.io [89.116.146.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.125.12.218 (trex/7.0.2); Thu, 06 Feb 2025 21:07:59 +0000 From: Alban Kurti DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=invicto.ai; s=hostingermail-a; t=1738876073; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QiXyubdeOKIcHLGUBolab2yRgrtdSgwKfCo8KFHBIQ0=; b=UdaOjjrygfJ26g/NDouNl3plGw34C+tlqJfFZScsyxIUXmv8sg88ygyK/Okdg33br2P4VX LQ6NqGbA55PZdviqc7cWl/ScE62QiXoErvufGRJ0KK79/22aNoQROBKF6xOFl6Nr3rjVe2 mHvVwT3sN1gV+qCnuPBZ8guI8e3q+aXwQ+ZKcZZeRJ5OotVlb9R1+24rtvQ3DHaA8i9nVO b5BmaHz7x/TVH6/Xtq1Rtmdt+di7nDjHZvrcnPA2alEpVzZxe5JxT/DgnNZefVrzOIRWAJ JEm9VIt2dHh5CDXO6dvT/vObC+3PcDbrHFKUXqu07LAZDxPm7QXDVDZNBGDFrA== Subject: [PATCH v3 1/6] rust: docs: add missing newline to printing macro examples Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-printing_fix-v3-1-a85273b501ae@invicto.ai> References: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> In-Reply-To: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jonathan Corbet , David Gow , Dirk Behme , Asahi Lina , Wedson Almeida Filho , Wedson Almeida Filho , "Andreas Hindborg (Samsung)" , Tejun Heo , Fiona Behrens , Vincenzo Palazzo , Xiangfei Ding Cc: rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Alban Kurti , Martin Rodriguez Reboredo , Fox Chen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738876070; l=994; i=kurti@invicto.ai; s=20250206; h=from:subject:message-id; bh=Aoq8DR0tmBwK/2qmp6nHnMm7CfMGYf5gDRatYYdmJS4=; b=Eg90l4a/6yjDvdcx9mylSKH9TwrCcYGbL5wRllwirwpydxVlF+6oOrh2toKrQYqOCfGeYTNDK fD5qHTYXdEUDDzYLf/rmLm8HcoHKuAODuKe1m9eJifdWRY0ibabQ93N X-Developer-Key: i=kurti@invicto.ai; a=ed25519; pk=D1lKs+JFapuEVI9zJ2QUTLSf5u4aT12tG0ny6vMMuOc= Date: Thu, 06 Feb 2025 21:07:52 +0000 (UTC) X-CM-Analysis: v=2.4 cv=PMNd+uqC c=1 sm=1 tr=0 ts=67a524a9 a=9/DLicljd4JGVkZ5BRdAJQ==:117 a=9/DLicljd4JGVkZ5BRdAJQ==:17 a=IkcTkHD0fZMA:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=c9EISN1oOV-dU950GokA:9 a=QEXdDO2ut3YA:10 X-CM-Envelope: MS4xfBif+Uu3UMiyyU3J2G4rL9XjRNFgaliUqVvWA+0J0KfByC89iygW/TK7LxcvGtEhR64jjQ/kng2PNfuzzvTZ+KhmSJPXwteMLawGlY0DD1xK005kV+EB aZ+qU8iIURNZz4ohIbaxz/MFrOg/jOdXp0P+zYSBQ6lRRHurwExpxOw3x7h2SicBM18ttiGdmUJRQi+V7zU3l/omDZODpYOxXfDj+OMFwP7brUVUFYDFaXb7 u5dEJ+Wl9/yfGmzhn4/hBeVh/FzpFqq1haYEwI6JvDbVoj5S6R088jYTUpohRw5GQmx3anfX0/yGCz0PKEnUNnNnf3q9944GzVOEpKAJwZz8STjM7qmDWQIj myO/17u+UXeYiFJLwXcIkAELeiYUfOhotSnQVrUCw3VvL9iHWsVWJzPNH3Fk7W2SNiCETWTbL6G6iwiz1FajCu31k/HUxPLhQZ5OlX1cDq1eiQVb0GEtmg7L i2xnGowZkvNgIOAtnzzADarhKZA2XTpMz8VVGJxg0ph83Mp/95vjiIVDkgyDeypCrog7bitWXbU6t45Up9+5Cd0A9+D6e7ZdaV/KdTerNaJNJtRBZJhbRmbE RuDTn8fdxinrdRtVS8VQI1MOh/HwHFTz1qaEqI+YXmyg5RqbredGI1TnV1coW8l5lxdivod0GE1z7nMZPzpRL1qugCN8Le6JTfte1GKsjxHFgIqog+KOIkSk 9sUSqFv6mUKQ0O3CzL2PXQ3kbP46eEMDdjpcgG4q0tT0/qQZMbDTkHVTth2W/UZXwWrGPFGMJ/JpfeTUdS4N6uNyPFjHewO9YLjRQ0FGUOYbhM/11hQPVXMh GfBH6b6pn5GlJuYsxE2rOdFE6U2+tj89REyxi1nHdHOh465Mddf4IcDEMtLCFX6/ZnwpBEo9Ay+5WmiWojoaTNkxNH3hRWB8xUevfH7HS9Xm2VUkmfgqZSGU y96MvbgA8ONk5vq 3Q48kLNBtX5h5GXJywJXSI+/k/xgsFtGz X-AuthUser: kurti@invicto.ai Fix adding a newline at the end of the usage of pr_info! in the documentation Fixes: e3c3d34507c7 ("docs: rust: Add description of Rust documentation tes= t as KUnit ones") Reported-by: Miguel Ojeda Closes: https://github.com/Rust-for-Linux/linux/issues/1139 Signed-off-by: Alban Kurti Reviewed-by: David Gow --- Documentation/rust/testing.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/rust/testing.rst b/Documentation/rust/testing.rst index 568b71b415a4525772cb77ce76c7f9da32fac1c4..180b886e0f1ee997779f04ce85e= ba858e64946c0 100644 --- a/Documentation/rust/testing.rst +++ b/Documentation/rust/testing.rst @@ -97,7 +97,7 @@ operator are also supported as usual, e.g.: =20 /// ``` /// # use kernel::{spawn_work_item, workqueue}; - /// spawn_work_item!(workqueue::system(), || pr_info!("x"))?; + /// spawn_work_item!(workqueue::system(), || pr_info!("x\n"))?; /// # Ok::<(), Error>(()) /// ``` =20 --=20 2.48.1 From nobody Sun Feb 8 23:59:07 2026 Received: from sienna.cherry.relay.mailchannels.net (sienna.cherry.relay.mailchannels.net [23.83.223.165]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E1EBF1CEAC8; Thu, 6 Feb 2025 21:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=23.83.223.165 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876089; cv=pass; b=dlxOGyRmehnQK0YndB+Dua3z+qPECV0VgLVwlJbIbqlDXkC5aZK0C4wpZNTt+cmbyk5TQlD/SsRgIUVlo+8RaMaBPbZRF4hVxr8U3M42I+ZeSy4ucRYuyMV+mmfNwPhdOsTp1axvMUBjnzDNGJRIrTjWYppTLh4WhvZED51GPNI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876089; c=relaxed/simple; bh=7L31dPYGw7Pxe40Cf9TC1lYjwHWfvUUWN98ZTOblSOw=; h=From:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc:Date; b=ae+oKpktqWMSBQociRFcI6RMsNzIPpcPtWbEiccaq8IxLeMeGCUE6Ot8pHfUIYiQR8ljBV8nu9+rBrBLaX0Abnit/366iYErhSGTGMVzEBfuafJ8YpWK4B8F35xgcNmjHe/C0Ev8yYgk2GM0MFYNAolU/MxtPeXbhLx8B3bhrVY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai; spf=pass smtp.mailfrom=invicto.ai; dkim=fail (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b=L+QWLl/N reason="key not found in DNS"; arc=pass smtp.client-ip=23.83.223.165 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=invicto.ai Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b="L+QWLl/N" X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 309A64E4B48; Thu, 6 Feb 2025 21:08:01 +0000 (UTC) Received: from fr-int-smtpout8.hostinger.io (trex-0.trex.outbound.svc.cluster.local [100.127.46.110]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id 339CA4E563E; Thu, 6 Feb 2025 21:07:56 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1738876080; a=rsa-sha256; cv=none; b=3qk3bG01wNKYS3Z+8vCipPFu1fafB2gVQ8idDweUjahL4roEX1CAaTH/Wsh8fzFIbTKMwY yDVcCjluTsMM3VwRFoNpVGXQvr4LDzB3+hN/WmtJ85CcvipdHg8YCU1aDUFeuIRHI2DJs8 EMmQTbvFOKS75GZO9H80olQj/Vuag5zWqnLbRUiL6e3NOypO4qUqgPldo+VgwjNX0Ya6pl VR2ZtSPgkTgkM7KBybcs/AeMbg8r6Vn8ulToc9GUqW0j7sseuX/WU+/CYTsN3jKDHk1BRR 1vSMkH7MgcoqrfwDKLzFXd2dYtlqdqThK3Y1DZF0p+kAHKwzzcj2Qoi1Pr8oIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1738876080; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=mboWAuygJDRJOd489iUzrH063I+FbtqSBfcS25mYKxc=; b=wDcNfOaR/miavz00fjUHj1sAX7Y7Ogdv8KP0IwFRxJTUll56iQUC9HlZ1iWy2XQEpbVmWD S11DUCHoPCjfi63v4OeuB8mBBaZaIktjsKfwqaLgJkqAmxULSwRE8gkUsQVpNik3zGLga9 UqbJRFcH3QYTY67w4GkCWDRB4qgG8d7TbIUa1IBTxZ6EmBTdnKck/Pve3M3V+HsFAuDciD FuD66l+yCOJwkSGfKqUREGtjpMa89UXG8VD9AMv2B5YSPJfHKKCkog32FtWMdfkj9Q46rD Gt0a3PwH0oLbiYb4d+a5Bb0n5mT758gnXXvdT5digTYfBcWtQp81vw8P/evgQg== ARC-Authentication-Results: i=1; rspamd-8586946c78-xmhdh; auth=pass smtp.auth=hostingeremail smtp.mailfrom=kurti@invicto.ai X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|kurti@invicto.ai X-MailChannels-Auth-Id: hostingeremail X-Trouble-Callous: 7200ee0e378d10d3_1738876081058_1262071984 X-MC-Loop-Signature: 1738876081058:3642678018 X-MC-Ingress-Time: 1738876081058 Received: from fr-int-smtpout8.hostinger.io (fr-int-smtpout8.hostinger.io [89.116.146.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.46.110 (trex/7.0.2); Thu, 06 Feb 2025 21:08:01 +0000 From: Alban Kurti DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=invicto.ai; s=hostingermail-a; t=1738876074; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mboWAuygJDRJOd489iUzrH063I+FbtqSBfcS25mYKxc=; b=L+QWLl/NIGljSUgPyFWB0NYmjel8p4RdAxtIbPYzN3RoZTFasyqPIN0TcwWC0wweDt6F3f Wae/td6B5LnjGTEgJDcf1jxTsLdKlece/X2KKxS1PQZ8FfOM/Ydd2/kdYAWEXgQMoJyGRr rSzh6yeqnMQtwoQyq9cizGTyAbAO0g8KLffMjD1MaJzzkB9cKCIZVo0VmRpF2qCynbztxi e1tgkWFvhvELjp94fKyLWW9ShCAA1aX7pOTVh/rXfZB15XTIrjuMW2hAfikGwmTHq358NU 1bItBnuaRwZjxUB3hWBSWjit9K3CX5IRqqs8XAekFNZWnliMT88DEfEqcwBW9w== Subject: [PATCH v3 2/6] rust: error: add missing newline to pr_warn! calls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-printing_fix-v3-2-a85273b501ae@invicto.ai> References: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> In-Reply-To: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jonathan Corbet , David Gow , Dirk Behme , Asahi Lina , Wedson Almeida Filho , Wedson Almeida Filho , "Andreas Hindborg (Samsung)" , Tejun Heo , Fiona Behrens , Vincenzo Palazzo , Xiangfei Ding Cc: rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Alban Kurti , Martin Rodriguez Reboredo , Fox Chen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738876070; l=1035; i=kurti@invicto.ai; s=20250206; h=from:subject:message-id; bh=7L31dPYGw7Pxe40Cf9TC1lYjwHWfvUUWN98ZTOblSOw=; b=5NY9J+xUMZNQlhO9wORf3WMxkYDAqjsEjCtxJK8zBrAIV7XPj9JP9Ro5v6D3uNgJWCm9XMLJy ob7o4tT+2VhBeOsvnpmhcjTGPmajbIXZUEwVmj6Ti3ejd5n1zIDqinY X-Developer-Key: i=kurti@invicto.ai; a=ed25519; pk=D1lKs+JFapuEVI9zJ2QUTLSf5u4aT12tG0ny6vMMuOc= Date: Thu, 06 Feb 2025 21:07:53 +0000 (UTC) X-CM-Analysis: v=2.4 cv=PMNd+uqC c=1 sm=1 tr=0 ts=67a524aa a=9/DLicljd4JGVkZ5BRdAJQ==:117 a=9/DLicljd4JGVkZ5BRdAJQ==:17 a=IkcTkHD0fZMA:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=a7_a2XaVlCDEdv-p5PoA:9 a=QEXdDO2ut3YA:10 X-CM-Envelope: MS4xfGaF6Dw32A7ngSBQwII2tyW85uHilPVB+nnbOOKMIurIo3X5lTWumOjJpiONd6WfhobJa0a8iyYUl1UOeV0RTUDSBC8ATVeZie9E+o+5f3B0LL3tEiKj W+n6ZC6yVV2L9Y4RyyqJAfdjyEbdIkp8prrs3FknMmYgq8U9Yj9NpZ8iQd9tth6sBmKtoQ5KY9c1hrF3/+zfwzseaqyVtpucqJOYMKf0XFQbyTgPVm8RZbu2 bpSskbFmTXpLfclX2YOvSmq/2b9g/7LhCzI3HIdHyqR8QuFnzx5pD0HwB9jS6dc99h2lJ7Uo3vGnkGUrxJsdKfujw3M2tFbCTq7C1AwD/nGo9sk6nOs4B53B 4AefMfFjZnBWWRKyOCUw7A9KCsRM5+anbbm8FdE0dhfvxlDwGKd1ifAEx1gvMqARall3RuSPAXjV3qAvJr6p7HnqtgCF2YSYzfmvJY2hCVSfC+LSR990yL2f RAn9GKmuXi19K/RpEp5AsBuf1zgOsMTthwGBINHHNY8HbMXvVf+N+GG1gizuAQVg2oBWpAdbBdiL4SnXAi0IrCJpRG72qjSGaM85ZFJx4fJV8Vsorp62Vj9r 7G3UQjvHjq1tfDif1KbzcxPsqoDdLwL5slI/XJlXhEWUb4BlBiBoaD24DIgTYBLnjfiY1P/L103qERPjV4HI7GNKbxUQhZZOq1UQvmmyAuljxS6T7T/8p47t 0asC7Be5OKTZxSzVSlAO3t+XdPJqHY+O1w8WvRdPn+q08c9FDGZLJj0URZwxUKMuMEdMJlYRS3yRt6zVNobxO90/KYLQZSosLmeI+KSKAOOY8ykASz4LtN+X JUbfqrQ4tjvXlgiXS5W+ksiohqCem21Hu0diFGoKm62kVGc3WTZbL34L2TJW4umrgGQGnWCvzBivtX59ozdqsvSNe9yVFT4nZkat1kIltDAdwMKoALhkuDjW QS6Kk/PeYaA/f9y IkOZ1INlKCkgL68dOn+usqQZ4/TouDeF8 X-AuthUser: kurti@invicto.ai Added missing newline at the end of pr_warn! usage so the log is not missed. Fixes: 6551a7fe0acb ("rust: error: Add Error::from_errno{_unchecked}()") Reported-by: Miguel Ojeda Closes: https://github.com/Rust-for-Linux/linux/issues/1139 Signed-off-by: Alban Kurti --- rust/kernel/error.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/error.rs b/rust/kernel/error.rs index f6ecf09cb65f4ebe9b88da68b3830ae79aa4f182..a194d83e6835c03b84cc849b641= ce8fff548047d 100644 --- a/rust/kernel/error.rs +++ b/rust/kernel/error.rs @@ -107,7 +107,7 @@ pub fn from_errno(errno: crate::ffi::c_int) -> Error { } else { // TODO: Make it a `WARN_ONCE` once available. crate::pr_warn!( - "attempted to create `Error` with out of range `errno`: {}= ", + "attempted to create `Error` with out of range `errno`: {}= \n", errno ); code::EINVAL --=20 2.48.1 From nobody Sun Feb 8 23:59:07 2026 Received: from buffalo.tulip.relay.mailchannels.net (buffalo.tulip.relay.mailchannels.net [23.83.218.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 33A8A1DD886; Thu, 6 Feb 2025 21:08:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=23.83.218.24 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876090; cv=pass; b=JpNFSNKCtyCkX2KhZ/MkNHQ84iTuLa17KGpeLnzM1lgocWUwWjc0HxIS7wU3sT4DCLLepd4p1sQBcUbIcMbap2qJlq9inAJAkPTXDTDhzEwHUmjVPW3vH6qg6JJD8yZc1HnoTkfTqZJksuc5X7KYAPwgRrZJnnNrPpUJ649Fm50= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876090; c=relaxed/simple; bh=wLsWvO7G2CDgvUsTos23isyBxWnJ4B7OEzDo0wRP9YY=; h=From:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc:Date; b=jgV4bzhmrezO4/CcYpOe6Nv1ynKxgM4ZmoS9PcOAC2LGWcqDwMN1Z2NfcYzX5QPZl7DM7XSUBZ5vs68xUcIFMmvt/trtcc9jK62lbhEPX45IrGaVQZ+nrkfMUxidYn2hCKIXmJP7Lop+YXDI4FgbhZ1CfBTfZZYo4ciCsb4Qsvk= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai; spf=pass smtp.mailfrom=invicto.ai; dkim=fail (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b=dke2mQzD reason="key not found in DNS"; arc=pass smtp.client-ip=23.83.218.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=invicto.ai Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b="dke2mQzD" X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id C3D2D843C48; Thu, 6 Feb 2025 21:08:01 +0000 (UTC) Received: from fr-int-smtpout8.hostinger.io (trex-9.trex.outbound.svc.cluster.local [100.124.213.208]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id 44C3684430A; Thu, 6 Feb 2025 21:07:57 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1738876081; a=rsa-sha256; cv=none; b=KjYspCEyLbv/6H/C7sYirwxoOFyx5/XWo1k8cD8iPHITFKGhTBtRXTpStFz1Y+wbUNYTJv zaGKn6iuKPNeBKVvapPfNhA6NxRjQH4ptYuC/mnYyjqhd+bjKlN9Yq+ALgAH1pmmj8UA6m /R+tK+tRiUCyTM50wEkpdJQ+WVrd3HXXKN2AxZ3GdtgDLeAcAYTTyYyNDVXoUc+hKFYU85 ilAaZ3Vjxtz9dunn89i8WfRiqt3HLIkFIjaEKKEp5yNx2aB92J/6HdqIvV58krkCn1OSLT gobzjxbJUXe8zpIpvDQ3gmT5cC3Z2sj8CacxAbpV87KGVy5QA2ynAzehTvU8Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1738876081; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xe2WLiAkBcHSDkUXsXHhELtyJUZydrkz2mL+/UvVSF8=; b=c0FQ7NzYDk2UGA9PdM7K4NWGAHSrJIDrfEEeVGkA7BP0PYf9hu6mLcJQasxThhd8+up4rr 7F0YysICHtSof+IpwrizZPTYeUyQxUpsvhH1we4BQFjL5XtaODUU/kM+ijPYm4C+vqhgFr Ca6jgMSPQ5JxqnhpuOgVRwAo584ovpz8isbkLu6bhPp9haVCcNuFVjA52GRue1N8o2kh85 7Es8reKNmgu4lHmyrfQXZRWq0XXzjW3OUvu6bERNN+kz9dw8eDho7HdODp1CDHkMWUOSf9 X/gJNJsovEZrr+/263gkHGhqbnHBgwXe95P7+3Q6fqwiu+Wud4ktH2dHPRpdlQ== ARC-Authentication-Results: i=1; rspamd-8586946c78-zkzf8; auth=pass smtp.auth=hostingeremail smtp.mailfrom=kurti@invicto.ai X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|kurti@invicto.ai X-MailChannels-Auth-Id: hostingeremail X-Cure-Plucky: 2d15b524697e6a68_1738876081662_2443359273 X-MC-Loop-Signature: 1738876081662:3814102582 X-MC-Ingress-Time: 1738876081662 Received: from fr-int-smtpout8.hostinger.io (fr-int-smtpout8.hostinger.io [89.116.146.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.124.213.208 (trex/7.0.2); Thu, 06 Feb 2025 21:08:01 +0000 From: Alban Kurti DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=invicto.ai; s=hostingermail-a; t=1738876075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xe2WLiAkBcHSDkUXsXHhELtyJUZydrkz2mL+/UvVSF8=; b=dke2mQzDGh8SPTmOpPHa5ct2vJIz7vgu+ZEYTRaOWXYDC2ave2y17ToaC4vXgDN6Y1FiPe YfonCxNpSJ/o7FPbNMH8GlriVDws9UaYv/x92+tyLhmiMyRJrrq+ZbMQZFZEV2nWF3oZme UehaCzejoMvGwmDEm1epUROgpNwe5iLI20h90YLhqisR5eiXVSPQQI+NadiWDbsBai9dDw H0pbQBBppkbdVdLiSWeged9SUmb1NzLfrdv2YEnpC1Xb4mIsYxwdGLmswvWBvRIOGNfa4r JTkTu/arGexU07Hxh4zY9ibydBmagpXv9QI53LocwMHhKSNwXlWpaD29K+DXbQ== Subject: [PATCH v3 3/6] rust: init: add missing newline to pr_info! calls Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-printing_fix-v3-3-a85273b501ae@invicto.ai> References: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> In-Reply-To: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jonathan Corbet , David Gow , Dirk Behme , Asahi Lina , Wedson Almeida Filho , Wedson Almeida Filho , "Andreas Hindborg (Samsung)" , Tejun Heo , Fiona Behrens , Vincenzo Palazzo , Xiangfei Ding Cc: rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Alban Kurti , Martin Rodriguez Reboredo , Fox Chen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738876070; l=3757; i=kurti@invicto.ai; s=20250206; h=from:subject:message-id; bh=wLsWvO7G2CDgvUsTos23isyBxWnJ4B7OEzDo0wRP9YY=; b=blNhu/kuzLz7yiGjHnvKuuO5uLg9p3v4Nqm53boJPkRRSrFD20BmDnHi4fGqLoWh+mxhRXP3Y QOW9uTjo3xFDxqJPLzYgSAgZBUO9HPqm0EPqqp5eDPKX3dpAJJD6y7m X-Developer-Key: i=kurti@invicto.ai; a=ed25519; pk=D1lKs+JFapuEVI9zJ2QUTLSf5u4aT12tG0ny6vMMuOc= Date: Thu, 06 Feb 2025 21:07:54 +0000 (UTC) X-CM-Analysis: v=2.4 cv=PMNd+uqC c=1 sm=1 tr=0 ts=67a524ab a=9/DLicljd4JGVkZ5BRdAJQ==:117 a=9/DLicljd4JGVkZ5BRdAJQ==:17 a=IkcTkHD0fZMA:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=nqqMFtM_d8z4v-URY_sA:9 a=QEXdDO2ut3YA:10 X-CM-Envelope: MS4xfI1QtWnQWDJVkIqxxdYYDI2N7/H3n6ylZ4xMK6AW5efifmRGYGF/gQ93xH4PKYnFzfGACypazeEmTS08dNiHZE+VDMU0Wx1bGzPUK/ZmT6mORtQdl6YZ kmmQMr05jUP2nbZ5DhkuM+MLNuNb5hW5wnHsxGq/YNoj/Z6+azZXBnoaGXxENRZD3HxZB8tAikIArKpYNhJzul9hxxGLN81zaxLYR71PW2eE9HGlskE3TDop N/pY7RUinWClmSKzIsGuCBg6P4AokQXsnxZcs9x/DN0wOxNaFzHszd91Rbxza919ex7HWFelOZrGbYMtNhWDv2ynw0H5jetE0+STe4g4kD2AyI3si9MRlIFg An38XVd7HV9RggzZCj+3gOBGRl4FemAEfI2quzShYKIJ5NwptrazPtw4yh5HBTUW908VXhm3dXHEkm+gPShAHj1WzU0eo23qQk1P5bx2KTvqNvlf/zYBDL/5 OdIY2QYQoDElHPMAWRj71HRu6y0t9mNuAwoZcIBl3Ivw6ZkABgwdiuVwjVfyEK6vbYqp92wJ/Ep/oUhRnXW30/Dek3ifMVowu1coDLbDGqooh2LObs44m8qH fSCDzx6RoYcgT2PwZao1gFUnTJ64f5J9kOOSZnmmTFemi9k9w3SM37k3yB0nGWC1IWCmOvNgMYuLqo06hyLyN3IZy8ghKwCo83Aq4ztk4/I1qy3T/Colz+C3 LfquipRHVgVNWUVbla6mJpWq9xs5k6tcUAwwD6kpRkhLxpEWLItJS9a7/XVg0joOVEdZsa/2LrIpOkyphR/LB2F0B03eC8x6RQyIhR4ZHVWHlSHtuXHMYYqa TupiEbk2N7ZqWoiz6eyRDhaSBDlyKBnGCAJvPG73VtOPvxq3x6qcO9Oy1yH5WyS5KM1ZCoskC97A99ME/MVqoGVPuogWdXI0zb2IA47MZiQxZN24KZBKmdBX FSbz4gY0X+H+7o0 o9mXu/gv3AZSxJiN88uD7hAaQhIPUAXoQ X-AuthUser: kurti@invicto.ai Several pr_info! calls in rust/kernel/init.rs (both in code examples and macro documentation) were missing a newline, causing logs to run together. This commit updates these calls to include a trailing newline, improving readability and consistency with the C side. Fixes: 6841d45a3030 ("rust: init: add `stack_pin_init!` macro") Fixes: 7f8977a7fe6d ("rust: init: add `{pin_}chain` functions to `{Pin}Init= `") Fixes: d0fdc3961270 ("rust: init: add `PinnedDrop` trait and macros") Reported-by: Miguel Ojeda Closes: https://github.com/Rust-for-Linux/linux/issues/1139 Signed-off-by: Alban Kurti --- rust/kernel/init.rs | 12 ++++++------ rust/kernel/init/macros.rs | 6 +++--- 2 files changed, 9 insertions(+), 9 deletions(-) diff --git a/rust/kernel/init.rs b/rust/kernel/init.rs index 3f9236c1c9d56db33aea4b76f8116175b9b6ce23..8f57d164cdec8aee6c07e258a51= 2ff8171a1b065 100644 --- a/rust/kernel/init.rs +++ b/rust/kernel/init.rs @@ -259,7 +259,7 @@ /// }, /// })); /// let foo: Pin<&mut Foo> =3D foo; -/// pr_info!("a: {}", &*foo.a.lock()); +/// pr_info!("a: {}\n", &*foo.a.lock()); /// ``` /// /// # Syntax @@ -319,7 +319,7 @@ macro_rules! stack_pin_init { /// }, GFP_KERNEL)?, /// })); /// let foo =3D foo.unwrap(); -/// pr_info!("a: {}", &*foo.a.lock()); +/// pr_info!("a: {}\n", &*foo.a.lock()); /// ``` /// /// ```rust,ignore @@ -352,7 +352,7 @@ macro_rules! stack_pin_init { /// x: 64, /// }, GFP_KERNEL)?, /// })); -/// pr_info!("a: {}", &*foo.a.lock()); +/// pr_info!("a: {}\n", &*foo.a.lock()); /// # Ok::<_, AllocError>(()) /// ``` /// @@ -882,7 +882,7 @@ pub unsafe trait PinInit: = Sized { /// /// impl Foo { /// fn setup(self: Pin<&mut Self>) { - /// pr_info!("Setting up foo"); + /// pr_info!("Setting up foo\n"); /// } /// } /// @@ -986,7 +986,7 @@ pub unsafe trait Init: Pin= Init { /// /// impl Foo { /// fn setup(&mut self) { - /// pr_info!("Setting up foo"); + /// pr_info!("Setting up foo\n"); /// } /// } /// @@ -1336,7 +1336,7 @@ fn write_pin_init(mut self, init: impl PinInit) -> Result) { -/// pr_info!("Foo is being dropped!"); +/// pr_info!("Foo is being dropped!\n"); /// } /// } /// ``` diff --git a/rust/kernel/init/macros.rs b/rust/kernel/init/macros.rs index 1fd146a832416514a2bdcb269615509d75e3a559..b7213962a6a5ac167c445a4fdc7= 7f3661639121d 100644 --- a/rust/kernel/init/macros.rs +++ b/rust/kernel/init/macros.rs @@ -45,7 +45,7 @@ //! #[pinned_drop] //! impl PinnedDrop for Foo { //! fn drop(self: Pin<&mut Self>) { -//! pr_info!("{self:p} is getting dropped."); +//! pr_info!("{self:p} is getting dropped.\n"); //! } //! } //! @@ -412,7 +412,7 @@ //! #[pinned_drop] //! impl PinnedDrop for Foo { //! fn drop(self: Pin<&mut Self>) { -//! pr_info!("{self:p} is getting dropped."); +//! pr_info!("{self:p} is getting dropped.\n"); //! } //! } //! ``` @@ -423,7 +423,7 @@ //! // `unsafe`, full path and the token parameter are added, everything e= lse stays the same. //! unsafe impl ::kernel::init::PinnedDrop for Foo { //! fn drop(self: Pin<&mut Self>, _: ::kernel::init::__internal::OnlyC= allFromDrop) { -//! pr_info!("{self:p} is getting dropped."); +//! pr_info!("{self:p} is getting dropped.\n"); //! } //! } //! ``` --=20 2.48.1 From nobody Sun Feb 8 23:59:07 2026 Received: from slategray.cherry.relay.mailchannels.net (slategray.cherry.relay.mailchannels.net [23.83.223.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAB9E15B54A; Thu, 6 Feb 2025 21:15:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=23.83.223.169 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876561; cv=pass; b=ihTZEuzpfN6eBzTLuoZXBE/7VR+oGSBzKe84twk8cmzhCvMZpzacOsmYcyT+qnEzwTSfx30xglefms80ZDbFCX02Z15WPjtrA1LaCQqNG7OXrpnP/x0fDBmsh8K4xMYqynk3YrE0yVLzXdwYqs7WSbubwg3d8dNz94izR8p37hE= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876561; c=relaxed/simple; bh=1lB3R1po6WZgdxaHmY/1OrqiJzK67pHd7MlXm4BGTbs=; h=From:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc:Date; b=hkrQL5kxT36jxTFWxBd7g2/bf8AQ1w4abFW7wMkRMidCevfumMeZnYqMVTiHca3rGiPrnSMZEv7tKvOlLHUiojThlyEqba8zUuUMsBzjeLtMD53ITIvWB6xCwm7JOC6q5dLG22aqHsIILpwal8glNxIWrc5kDkQCyAqyjYEEnNE= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai; spf=pass smtp.mailfrom=invicto.ai; dkim=fail (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b=bVvxAaAD reason="key not found in DNS"; arc=pass smtp.client-ip=23.83.223.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=invicto.ai Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b="bVvxAaAD" X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 358F523E23; Thu, 6 Feb 2025 21:08:03 +0000 (UTC) Received: from fr-int-smtpout8.hostinger.io (trex-0.trex.outbound.svc.cluster.local [100.127.46.110]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id 972352365D; Thu, 6 Feb 2025 21:07:58 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1738876082; a=rsa-sha256; cv=none; b=1Ro95qpUCKFjFPLJNu8SqmKrowz8ebWLBK0ke4hxfPF7go44Bgl8i1EC+3KuECSPtyVOAm Q7MaNFWG8DAJpsHxFK678m7tL76MlHbhD5aV3PVJSOfc1QfAuE3HyNpBNKPF/fpxvvdmgL 1kBuX1D4eFwY7E3BHy0xJW09EgDH9hYKoLHtVVrRFk/jZZyrCR6S3ZFimNZIIwaUhnqgDu 8GwHQTq8RznFaNzrmBIWLzoc8iwDacIq4nqYZ2juVsndjpWWdSWydLypR3lSqJEQB8jOZG syltYKifmR28IuR34GxD+HN73RqWXJfnxZ4BnJpYDc1vRpbOi2UgyRskOvZStA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1738876082; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ao/6CpQGIug2s3g4qNBT7wztDldQnzKpiipkzTE6D5o=; b=5IC4YPNGJIo8Kydl+twjBmAJRqqTcmKAbOJbs1voRM45xPEH+XB+nWW2CBuvF2XIRNM5cL tsmrRDjFw01Dr6eeCDwk8ikdRFeG8Noor1f3qDlM2snYDsSLIrRW/ypvSDoq53siy4LaPS 2VPaB8ARQ97I/BurZW3JZF1rkh9SlfaEatgo/Wa4hzmfWxfWtUPoSkAMSi9W5LGN5pVxXE u1T9gsPNggSjf0yr4rJigyz1uyJKyusMmC6OsodPzD4jaaiyaWkFRAjfUcN28o79UCQZFI Rd5q18ovfYGJGIGN+qA/XWHeomZqvUYzzHTXNvNWyW3XLQG1voemmPJJWQmqew== ARC-Authentication-Results: i=1; rspamd-8586946c78-qtn6w; auth=pass smtp.auth=hostingeremail smtp.mailfrom=kurti@invicto.ai X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|kurti@invicto.ai X-MailChannels-Auth-Id: hostingeremail X-Abaft-Thoughtful: 2d3304e215659c98_1738876082965_3725378742 X-MC-Loop-Signature: 1738876082965:1669363260 X-MC-Ingress-Time: 1738876082965 Received: from fr-int-smtpout8.hostinger.io (fr-int-smtpout8.hostinger.io [89.116.146.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.46.110 (trex/7.0.2); Thu, 06 Feb 2025 21:08:02 +0000 From: Alban Kurti DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=invicto.ai; s=hostingermail-a; t=1738876076; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ao/6CpQGIug2s3g4qNBT7wztDldQnzKpiipkzTE6D5o=; b=bVvxAaADvjx5XLZNsFSnJWB7Q5KkJg0iuA88QTQ/4UDAlzQyo9dCwTL07g0XUI727AxmqF zF1RPn+3/utlITDKEQlxqb8dZo6+gg4qK4/qbGZT7T8InS3BnC1olO3WzLl0JQNPCFYBAa 0UMmVPuiMJbNU8lc9tw8wa53kr47Bpt9I8Rqf7BDD6WScFb2v5tBEZVYciNhIJ8zvwNc8H KmOeICzsGOvkaLLmJR7TVSN8I7yojm92tvgkWM+lvk1Gh2awrHv8OkPD4CowSiMul88buq isNsIMcxVNk72Lc2/vi4K6LVbE8w+EFOtx15QmQkbQtXnEXbnzjL6u2OTuXuqw== Subject: [PATCH v3 4/6] rust: sync: add missing newline in locked_by log example Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-printing_fix-v3-4-a85273b501ae@invicto.ai> References: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> In-Reply-To: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jonathan Corbet , David Gow , Dirk Behme , Asahi Lina , Wedson Almeida Filho , Wedson Almeida Filho , "Andreas Hindborg (Samsung)" , Tejun Heo , Fiona Behrens , Vincenzo Palazzo , Xiangfei Ding Cc: rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Alban Kurti , Martin Rodriguez Reboredo , Fox Chen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738876070; l=1151; i=kurti@invicto.ai; s=20250206; h=from:subject:message-id; bh=1lB3R1po6WZgdxaHmY/1OrqiJzK67pHd7MlXm4BGTbs=; b=T2Q3yA6xogxLqNEE7t5drQ/TCrHRborZiGAai2Ql3KXdyLGKyixlfgH1IPiFUFaAQdR4bEWyB BqAoG05NfyrBrI/phI06pVPYyK9VqR6ZMg7WxcRoyolWYcC70lLeki1 X-Developer-Key: i=kurti@invicto.ai; a=ed25519; pk=D1lKs+JFapuEVI9zJ2QUTLSf5u4aT12tG0ny6vMMuOc= Date: Thu, 06 Feb 2025 21:07:55 +0000 (UTC) X-CM-Envelope: MS4xfNJAmCzuHi2orbdWWk7lB74rjaapN9N8+53MQ/FHyFECiF7kuvBHA5DfX6TCj3cLKJnUaQhp6fGDmlFoc8aEqqBS8RlwS8Ri+WCX02TcGWCXOgwTyQV/ y5/UaSF75T7oo/FG59DEjnX0++CbmR1c2DebI2VcCjMIYbEwd/TzC012ilfGe4MNso4oaO42VgB7wiuLXuOgm9JOTDWnaLKhanzjzca5Wuxrvd1ZeyvAxUBq DT3U6iKrpY1LVtRg+DQNCx1D2YYb7Gat07FUbZgR78MxZqFCZj3ADVs30yolixQ497I2KaS2YDoJCMjPrcqKWxlvO3FomlUvqUQsxp21qD+PYK+yZowri7Xr sRSeMhM8ptzPDqw/TgzoAQZSauS9td6mP8NZOm0k+SWrhkpLwh367IljKaRI+ZToNDwZ9+G+3RqZxD77YRWsp+Tr4ygwlCVD0Tj9KtRaLAbz8JZMDrhniWmx j4PyPGdke0tbKiUQ5KClZ8zCqRf+YANGBnRh6PFqqBv9mF4nt+czyztiGRWcmZJ0jXk6nP2HTMvI8y7mpOW+F/+uw7Gr4tXDEwFZgzvIsPgskx0dinZiusuy GopnleOgR1jVZbs7ekpSXY7ivmL+gEojPF+k2DdFaVNqTcgUFqZ3MVXcQSEz/26H24AdeqSIO4pQAp6WRI0UDVLhhYoqBbLlobtpTaFT05ZGT+K8l3e1ee47 aIgi3xzatQoUdBRTBtV+xh8+6J7kceEhZo5hhVsO4kby/XDtlHP3fGFMNtgiy8NMLvVbSeT1TEO9k/rKeNdCsPR5C51ffFPxItW5rfO04NcQjoeqvri4wNhv QB0SO7sShKHyijxDCGtmPClTw7OKyaEaQI2Z9Jsg/1kq3FDjpyx16F1dT6oH1uuylG7eppiy+LBjVHLBb/3OHLwdMlFhL39SCmS+9MuXClr3Qy9bUGZZfyZR BNUrKZW5a7BXvi/ P/ll+xr5V2zC5/Jr1DK3feMCs9P1eRpxS X-CM-Analysis: v=2.4 cv=PMNd+uqC c=1 sm=1 tr=0 ts=67a524ac a=9/DLicljd4JGVkZ5BRdAJQ==:117 a=9/DLicljd4JGVkZ5BRdAJQ==:17 a=IkcTkHD0fZMA:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=HeOr5W89t27ReWMoupIA:9 a=QEXdDO2ut3YA:10 X-AuthUser: kurti@invicto.ai The pr_info! example in rust/kernel/sync/locked_by.rs was missing a newline. This patch appends the missing newline to ensure that log messages for locked resources display correctly. Fixes: 7b1f55e3a984 ("rust: sync: introduce `LockedBy`") Reported-by: Miguel Ojeda Closes: https://github.com/Rust-for-Linux/linux/issues/1139 Signed-off-by: Alban Kurti --- rust/kernel/sync/locked_by.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/rust/kernel/sync/locked_by.rs b/rust/kernel/sync/locked_by.rs index a7b244675c2b96a36a6fe2e3ddd9a68e6ea01cb7..61f100a45b3507c750c1e3c405f= 9a8f67ced5346 100644 --- a/rust/kernel/sync/locked_by.rs +++ b/rust/kernel/sync/locked_by.rs @@ -55,7 +55,7 @@ /// fn print_bytes_used(dir: &Directory, file: &File) { /// let guard =3D dir.inner.lock(); /// let inner_file =3D file.inner.access(&guard); -/// pr_info!("{} {}", guard.bytes_used, inner_file.bytes_used); +/// pr_info!("{} {}\n", guard.bytes_used, inner_file.bytes_used); /// } /// /// /// Increments `bytes_used` for both the directory and file. --=20 2.48.1 From nobody Sun Feb 8 23:59:07 2026 Received: from shrimp.cherry.relay.mailchannels.net (shrimp.cherry.relay.mailchannels.net [23.83.223.164]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 246411DE3A8; Thu, 6 Feb 2025 21:08:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=23.83.223.164 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876089; cv=pass; b=X5cuvMcuI9H9ZL8E+dcL1OwWhVI9sX2rtLwkjD1U6XF/o2/YZM1OUUgeOEG4/ybzx9YPUHSiDkAKbGk8aJuX+re2C8znvDQI8pHwGNLE/3KPsLLKcNJudhbSQBGVh3ozqSTKtkaUB+f2UWqJ8boURe6qf2iwocNbFHWLMEGTOq0= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876089; c=relaxed/simple; bh=1SWPqf8a5C9NxYJR391AEqJrR+BVnwbgc8HdXRPOySI=; h=From:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc:Date; b=rU/E/vkKi8KPu38D7/w9qTDlZyoH44Ch8puqTp3tM9leX2oaK9VGua2gkSn3mS+tG33cuoiTTwmV1mjTW5HlSijbmBOXzR1jdkUI0CbeT3HUaNtmsVCTAq2+AWYSs5MdmbiWDLTfpxmOUKnDKc6JFuQJBpMZIn2hiS9aDJL3+RU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai; spf=pass smtp.mailfrom=invicto.ai; dkim=fail (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b=lyUORO3r reason="key not found in DNS"; arc=pass smtp.client-ip=23.83.223.164 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=invicto.ai Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b="lyUORO3r" X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 5C2742C4C5D; Thu, 6 Feb 2025 21:08:04 +0000 (UTC) Received: from fr-int-smtpout8.hostinger.io (100-127-46-110.trex-nlb.outbound.svc.cluster.local [100.127.46.110]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id B954C2C45A4; Thu, 6 Feb 2025 21:07:59 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1738876084; a=rsa-sha256; cv=none; b=G2h2w9OJ4Kwr70MSNoMgiIaBXXYzjExK6ZIdluCfT55WNbEX/pG+38Uhkg5/afdC1f9Q8N rTSjCb4JxqUwKYj611yxCMbHhzy9euIn5DIRa3OCI+Kici2ilR5yog9Stxf5Jgn/wcWGrc lp/vJwnMfYAjBS+MNLcEHiAh25BwkW7aKErF7Uz9a1TicpvghRuWlGALEuHJy4Ww/KZfZo fSEnMzIZ1x1MVbFH16AkdxkGbdEpyfkYPPhcyg7MDY90FRRm2qhOLu7JBhcPc7VS3pmqbI gfcqG3rtJhyAaaliC0hWGSfkMegXSuvs9wDXv9lAcTV9Kx+S0tpo23e+EFUHvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1738876084; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UvSNPkaWPAb3Yryh9T+JjK6uH4K1WVGA5oF6rH2lJLI=; b=Q9jLHrbquFe6KLMTo4psb9g8PA0FGpBRNIpy0A4cMrVfKX4sz2a4NZHdlnfS/OtSlQlm+B +c92az+UkG30fe4I7VHz4xCOhkxPNEhWoL63TKJDlPYdXv2LPATxzoIj4c7a2XdpYKScuW XAay2BMd6k7X5rFf3bqBRhJhNqiU3/10LWOlmGhIQF2G7lX/k6pmakFESHDLdAUm9DeRue lMg23CRsMHfuGa0H7xM2WamVOTGKTMOH4Io53979K1awst6R/LF1MP5VEKkPo8LLQ11hga OhETeF/GBsVj+bzVep6baBSTtjU127HanB6SKnrXkx/pMTYTKJQUqnghvOvYtA== ARC-Authentication-Results: i=1; rspamd-8586946c78-rzbvj; auth=pass smtp.auth=hostingeremail smtp.mailfrom=kurti@invicto.ai X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|kurti@invicto.ai X-MailChannels-Auth-Id: hostingeremail X-Callous-Broad: 3b66586c402da879_1738876084222_2093947072 X-MC-Loop-Signature: 1738876084222:3252647735 X-MC-Ingress-Time: 1738876084222 Received: from fr-int-smtpout8.hostinger.io (fr-int-smtpout8.hostinger.io [89.116.146.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.127.46.110 (trex/7.0.2); Thu, 06 Feb 2025 21:08:04 +0000 From: Alban Kurti DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=invicto.ai; s=hostingermail-a; t=1738876077; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=UvSNPkaWPAb3Yryh9T+JjK6uH4K1WVGA5oF6rH2lJLI=; b=lyUORO3rXo/Pz6Zk2MOggpbgNtccRRUyPlpsWIiwO6SiIFAH5nERMQTGVj+T7ugMRnXl7+ Pt0X0GyR5WO4chelN5SI6/D4pmYhrw97aTfOAyb69YjfUSmqTbnGyuiy9rjwC6QMHXKwND mIq/99riiA1iha+ePHMUjXF/sSjULkOCL058Y6TcaBWEQlbHGK4/htkgo5CEfB2E0oe8MK vdoO5CPEdkO4kj4sFI4Vjb2MSSZPZ+lzx0HwrMSalT1e55UFc+A2inSwfPh7kUy3nWBpOv Uw7wZCB1uHXykYaGYiFZkJM4ty6lIXvFs8REE7bb0T+QbF7JApqe/COXNEl2rQ== Subject: [PATCH v3 5/6] rust: workqueue: add missing newline to pr_info! examples Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-printing_fix-v3-5-a85273b501ae@invicto.ai> References: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> In-Reply-To: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jonathan Corbet , David Gow , Dirk Behme , Asahi Lina , Wedson Almeida Filho , Wedson Almeida Filho , "Andreas Hindborg (Samsung)" , Tejun Heo , Fiona Behrens , Vincenzo Palazzo , Xiangfei Ding Cc: rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Alban Kurti , Martin Rodriguez Reboredo , Fox Chen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738876070; l=1526; i=kurti@invicto.ai; s=20250206; h=from:subject:message-id; bh=1SWPqf8a5C9NxYJR391AEqJrR+BVnwbgc8HdXRPOySI=; b=LmrJo+twXvkVHrOjDZszyTqAtMSevdlyJlpzsPHiwXfFkYONoIO5eKkwaAecZshXqxCOn2a+n gpbDfzSbxZsCU+cHD/MtVeG0x+K0eYnPHo6+oX/MrokVP7cfrYhfRM7 X-Developer-Key: i=kurti@invicto.ai; a=ed25519; pk=D1lKs+JFapuEVI9zJ2QUTLSf5u4aT12tG0ny6vMMuOc= Date: Thu, 06 Feb 2025 21:07:56 +0000 (UTC) X-CM-Analysis: v=2.4 cv=PMNd+uqC c=1 sm=1 tr=0 ts=67a524ad a=9/DLicljd4JGVkZ5BRdAJQ==:117 a=9/DLicljd4JGVkZ5BRdAJQ==:17 a=IkcTkHD0fZMA:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=d1_hD_aZrE2QnMCWEikA:9 a=QEXdDO2ut3YA:10 X-CM-Envelope: MS4xfLUMi2wqvpb+tX7MyXm9rUKdWevLEufSMHa+fcmLIMgXIeBRBo98pf4yva//uSDKV2X7jkILyRDM87aYkyyKZ/Zd8zhN7oa398irkTiwLBQ3MEIPQhb+ vpJBj9vg6jn9DQjP3Gl/tizVRkZ/q/YBQw/7dPHmAhTJjEL2gvhrASfhUJyGrFsx6DBIJOW/xQEoRi95UcmAhCjCoamXCmCy2yBKqVEqlfFz3Ped6nRzK7s4 XcvBa8jBPg2rEtv5stSRJL8uSXW15SwQM/p/YAqMKxNQIJaLSB7Dl6fUxRHmmF0hSpw8IthYHQufZKDQOVuH2AEr0fbsv/F/Ol1H2qtr2lw/KsnX1abgiZni JVCWH0yXvWgrvxx0m2RNVRutpkQICYyirfDbilyL5lzyI7EqzT8kN0/oAcIN03jt//rPVXWAqZ1yESzKQSwn9zXeSQkyBAFoipkTkE84EEOYyBdUpOsV02aR zp0fxyNq9Q8Ac5oLm64WPRJvdijTBr61RdRnHgOGrG5KFI5PwptUnIdP4VOiJyz7h59cTh3Zrpz6v/FCIyxLmqFI64PkZf/4qgWLRVIw9tdQc+NJA54Ic3QE I6JgHxSV50ufcXnL/ATSrApNWtmedSo3MhCk25fcVcEdquXOhNZkGPcPRB4Nlq6qYp6eIoia1CUrNXYxvvy+OUa5ivHtM5BiPHJD0xG2bjcFxJt1pye5nTnQ oJbD4LLJLFPM4xx4u8Psy5gA8zKllSRej14lPs8GVxfJ6Wya53rSt4pSB4h0hbPQVgAQF7oVBA3/3WpDevjpJBhLeJrvL2R1nDwjTSyCq/KBQiaBSM/o0Ph4 gtKRuCNpJA4KY5WTphXLWSHwllwES6re9ji7iEeYYNRl5mkIGGCBel2jrNhIWMQPZLypuCM64YWmN+4cHySlW3B9fONQX+hTxzKn9HngNG4qqs86QTvZyiMX LcZpg2+A2JXziSl ntCcroZckRcf8PFBdcPXvrvJFpBy3CQGV X-AuthUser: kurti@invicto.ai The documentation examples in rust/kernel/workqueue.rs use pr_info! calls that lack a trailing newline. To maintain consistency with kernel logging practices, this patch adds the newline to all affected examples. Fixes: 15b286d1fd05 ("rust: workqueue: add examples") Reported-by: Miguel Ojeda Closes: https://github.com/Rust-for-Linux/linux/issues/1139 Signed-off-by: Alban Kurti Reviewed-by: Alice Ryhl --- rust/kernel/workqueue.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/rust/kernel/workqueue.rs b/rust/kernel/workqueue.rs index 1dcd53478edda5fe8cf4e1a034865ecbf70bca79..ebc4b5b4b06db20f57a03b3330f= 932f279e5d0e9 100644 --- a/rust/kernel/workqueue.rs +++ b/rust/kernel/workqueue.rs @@ -60,7 +60,7 @@ //! type Pointer =3D Arc; //! //! fn run(this: Arc) { -//! pr_info!("The value is: {}", this.value); +//! pr_info!("The value is: {}\n", this.value); //! } //! } //! @@ -108,7 +108,7 @@ //! type Pointer =3D Arc; //! //! fn run(this: Arc) { -//! pr_info!("The value is: {}", this.value_1); +//! pr_info!("The value is: {}\n", this.value_1); //! } //! } //! @@ -116,7 +116,7 @@ //! type Pointer =3D Arc; //! //! fn run(this: Arc) { -//! pr_info!("The second value is: {}", this.value_2); +//! pr_info!("The second value is: {}\n", this.value_2); //! } //! } //! --=20 2.48.1 From nobody Sun Feb 8 23:59:07 2026 Received: from seahorse.cherry.relay.mailchannels.net (seahorse.cherry.relay.mailchannels.net [23.83.223.161]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B0ED81DF270; Thu, 6 Feb 2025 21:08:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=pass smtp.client-ip=23.83.223.161 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876098; cv=pass; b=u3KzmXEa0EopA4R/s2HYFbr85gx7B2QKHPSWUFqoP8Y9Tt2wUDI53+u42BQ26oB21X3YSla1LJq1bte3AHx4SPIEQJKKVCduHE/868PQktKEKdXlT3Ds3zPKjjJsdj5Jl8/Zkho1GhDPDmSopasQahpN0vqCbC3pHIllEJW+7zM= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738876098; c=relaxed/simple; bh=Dk/Fa6RXmzhRQdv0qguvoAWvZrZfOdR+7TeALJAqGSU=; h=From:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc:Date; b=YhCx5pulkj2ld3lGW0XcEVVB+lnq2kYG6wCVnWbrobsx+kT7XLYYm9YG21lEWvrtxIMEW5f57FGdjKM47uMMpEVxCXnTXqZxvt+cEW5lf5U91GwdduyoitrddXUoxjBRu24YMBfAcjS9xw3mryk7CM5pidyrgxu2g7W0CX+oKjY= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai; spf=pass smtp.mailfrom=invicto.ai; dkim=fail (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b=U7JYa2M6 reason="key not found in DNS"; arc=pass smtp.client-ip=23.83.223.161 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=invicto.ai Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=invicto.ai Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="key not found in DNS" (0-bit key) header.d=invicto.ai header.i=@invicto.ai header.b="U7JYa2M6" X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 10B931645E9; Thu, 6 Feb 2025 21:08:09 +0000 (UTC) Received: from fr-int-smtpout8.hostinger.io (trex-9.trex.outbound.svc.cluster.local [100.124.213.208]) (Authenticated sender: hostingeremail) by relay.mailchannels.net (Postfix) with ESMTPA id A45EE163EE6; Thu, 6 Feb 2025 21:08:01 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1738876088; a=rsa-sha256; cv=none; b=bSP/4kCY+vXD9FHAxK3ECGmENi3QY9qfv3WNjT9q6RmtIe2NwGbacVflLTsg04thapOsw5 542Bh9ogmjPfH74tatv+o2zhd9nzx7Pm4jPvPjHnioAgLiNViSBTJyQOMpmChE5pa+cQ2J mOSED40yGGEHzchoy9qT3vcaKJOV0KdLTTE/3CYyeV6sdiJRXtYV2jFFKxvMtSQjEhhQd5 odBn5V4Oa1XGALrhMQyf0YAiy2NqeeWKjdtPUIepTpapylqa0HzrXxchOTJS6b8YWe12An 5vDj5d/Wl+PoS9zNt9Ugi/eMyyZggVTroq+6LMrtbG2FMIHFdpgboZSMkOvc2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1738876088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ZhpLIq9iFJvhqgLiSK+xAjgUUwQGLpQH0XTHM0rA0ss=; b=JXkee8M3XhyFrvzjNs0CsX81WRQvumaYdDz21pSlZdeS7MdL4aAGmE6S47GowWOkFWRV0z NDd8YCeQrRmYflseICMBc/BchCBofoGkzBUDqyWimBoUYVXQkp4KJvMGtrUZT90o8/Ujo9 7pGS2ZZ+t4NuLy9uQUJBIELfTWKJOtuYWvNVa8VX+w/pgijua/r+Hs62E2NepWgshPLR4R DAFmZfQLBgdJTIG4JikCI6WLe0qHKv88k28Lm8lJ//IC0HQM/bg7qQBTH2HLImpknbtKYW 7GhsjVklkM3EhLtsriUkhFfuMsFEjK2pMBj0k7bO1bbATn35uiroOS1TJzIj/g== ARC-Authentication-Results: i=1; rspamd-8586946c78-zkzf8; auth=pass smtp.auth=hostingeremail smtp.mailfrom=kurti@invicto.ai X-Sender-Id: hostingeremail|x-authuser|kurti@invicto.ai X-MC-Relay: Neutral X-MailChannels-SenderId: hostingeremail|x-authuser|kurti@invicto.ai X-MailChannels-Auth-Id: hostingeremail X-Plucky-Tart: 67652802074b8bf0_1738876088589_1794236910 X-MC-Loop-Signature: 1738876088589:3020997883 X-MC-Ingress-Time: 1738876088589 Received: from fr-int-smtpout8.hostinger.io (fr-int-smtpout8.hostinger.io [89.116.146.204]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.124.213.208 (trex/7.0.2); Thu, 06 Feb 2025 21:08:08 +0000 From: Alban Kurti DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=invicto.ai; s=hostingermail-a; t=1738876078; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZhpLIq9iFJvhqgLiSK+xAjgUUwQGLpQH0XTHM0rA0ss=; b=U7JYa2M6zLbgdq3dD+J/69XFuwQeETLwF7W9BocTEUKgIUrVBmITzyXod12WJrq+4nH/Y/ ZaZ4UsdUr3l9xWbdmaS1fCpfW8IQNvZeIaFEyQE2E027rfvbNNulBAwhZHpiEZ3EJQoX6h 2ZMy2xsBC5FZGgaEc9CyxefZOjbI1X5vlW9TwjbABqiCDi5Es2F+XaDasKdG0IejXiuA+i G/UwIorbDOBolcL3JQ74WXQ956stcQPBfAcNTIIyGA88tYm8ukYpEcHVs85OwoscUbFLRp gJJUgKrl0M/9cKDGWn3H/baEmzdw0bE0JQsdbHdbRYOsaCCJgGjIoVfT9LmKAg== Subject: [PATCH v3 6/6] rust: samples: add missing newline to pr_info! calls in rust_print_main Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250206-printing_fix-v3-6-a85273b501ae@invicto.ai> References: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> In-Reply-To: <20250206-printing_fix-v3-0-a85273b501ae@invicto.ai> To: Miguel Ojeda , Alex Gaynor , Boqun Feng , Gary Guo , =?utf-8?q?Bj=C3=B6rn_Roy_Baron?= , Benno Lossin , Andreas Hindborg , Alice Ryhl , Trevor Gross , Jonathan Corbet , David Gow , Dirk Behme , Asahi Lina , Wedson Almeida Filho , Wedson Almeida Filho , "Andreas Hindborg (Samsung)" , Tejun Heo , Fiona Behrens , Vincenzo Palazzo , Xiangfei Ding Cc: rust-for-linux@vger.kernel.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, Alban Kurti , Martin Rodriguez Reboredo , Fox Chen X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738876070; l=1836; i=kurti@invicto.ai; s=20250206; h=from:subject:message-id; bh=Dk/Fa6RXmzhRQdv0qguvoAWvZrZfOdR+7TeALJAqGSU=; b=/d2nSDIhhSGGJCAwLpmENScPF0743qpkJbNwez1ylf7fHFNs9PHDMxMFTvGR1ulXE/IKNc9O8 rn0sNEtWgyLBh7g6iVOTC4ifbPpn/mCxliUNgQjSo+niH0wXfM4ewem X-Developer-Key: i=kurti@invicto.ai; a=ed25519; pk=D1lKs+JFapuEVI9zJ2QUTLSf5u4aT12tG0ny6vMMuOc= Date: Thu, 06 Feb 2025 21:07:57 +0000 (UTC) X-CM-Analysis: v=2.4 cv=PMNd+uqC c=1 sm=1 tr=0 ts=67a524ae a=9/DLicljd4JGVkZ5BRdAJQ==:117 a=9/DLicljd4JGVkZ5BRdAJQ==:17 a=IkcTkHD0fZMA:10 a=NEAV23lmAAAA:8 a=VwQbUJbxAAAA:8 a=FcvrMFPuEi2Jl8-4TIoA:9 a=QEXdDO2ut3YA:10 X-CM-Envelope: MS4xfBc1mrP7eMiwYiSWN9lpbOhKgdKFPuGHKx/mBwefHzzLTAFz+TZoaVWCdSpFfFDYzHr3It4Ma8aGSRrsx/uEEeBd/FLUDMf9V3IaIKDNd0FBRpw+Gra1 KDMBpGiCMUz6b8sHhojlsOtJyll4454/+A/KQJ/10sFsWW//UpEpoK7d+3V0ocg5rf20FF+qdCqU3RAvUZlDEp69nRMG6VLmvRrOttd+PsPIOp3vXA3L0HF/ aW+gwaLUMlDUpLeZAavIhRIw7hJ9vC7N1JwnFFpcZmBbd7cVKoyznH/ZJMSqufXvhezcqiL+XRxH5ry+n+JESq78tuDH6tphGmsDEdEwYZdZcktcFspfW52a rY0CM6Jn+D+A3Scxpqq0XUjokT7MKgBmMoBfFFYyhGfOzgDF3iUwkLlsQ1lWj+ZKXXPpZDvcXmLWRk7BTfXl/4tGjffzd1WpwQf+yFehTmRWLGxkOChuEoJl g0TikBpKKS4lj4iVwJPubSTxjrLJlG6Pe1XbNq+/NN8osFfpd6eovj1xsF2DLcF217KH4111vifzlp1gKVUomP5iEn1lk/+JvCmICJIJj54OkYw15aCnddGa AsvQ1LeEsvcWAzp9D27EUj3JcW/+blfVydwGJW1gZH2kx6Owb4WU6AO9d4qJdvi+6vJFA0YCQ2xV3aD9rsG92ocY6xUsJcx0Bmiion20U7R6guNV1leZrU0w 0c9Vdq0SG9PAYnU+0zqCOUCQHATTYtq7e9+xdM3yaWe4EI16h9nidWptEfCDnVASvFfx7joWGdshXJTnG4nQ6tBmlhqgUR9qH4iBOL2fLofMJYkM9JBk24jB CnMNGwxzpxOV/WsgPUKxo2fA+AIw9zpIm83K2BpfCqwNFqdh7R/ZMb60gphRqSXyH6W7fUGvN9B4ekUo2zwdxo/ew964CaLpEMto8qelT7VnwyEfGr1yGGPX Q0taS07mn/Fl8mu KB/AjWO/b3zDfPvVNzxB3Iylb4ONl3WXg X-AuthUser: kurti@invicto.ai The sample code in samples/rust/rust_print_main.rs contained pr_info! calls without a newline. This commit updates those calls, ensuring that the output is properly formatted when the sample is run. Fixes: f431c5c581fa ("samples: rust: print: Add sample code for Arc printin= g") Fixes: 47cb6bf7860c ("rust: use derive(CoercePointee) on rustc >=3D 1.84.0") Reported-by: Miguel Ojeda Closes: https://github.com/Rust-for-Linux/linux/issues/1139 Signed-off-by: Alban Kurti --- samples/rust/rust_print_main.rs | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/samples/rust/rust_print_main.rs b/samples/rust/rust_print_main= .rs index 7e8af5f176a33925881c7d65b34c823028b7b93b..7ef3cecc65a15627276699c6912= 73608253c9df5 100644 --- a/samples/rust/rust_print_main.rs +++ b/samples/rust/rust_print_main.rs @@ -23,10 +23,10 @@ fn arc_print() -> Result { let b =3D UniqueArc::new("hello, world", GFP_KERNEL)?; =20 // Prints the value of data in `a`. - pr_info!("{}", a); + pr_info!("{}\n", a); =20 // Uses ":?" to print debug fmt of `b`. - pr_info!("{:?}", b); + pr_info!("{:?}\n", b); =20 let a: Arc<&str> =3D b.into(); let c =3D a.clone(); @@ -42,7 +42,7 @@ fn arc_print() -> Result { =20 use core::fmt::Display; fn arc_dyn_print(arc: &Arc) { - pr_info!("Arc says {arc}"); + pr_info!("Arc says {arc}\n"); } =20 let a_i32_display: Arc =3D Arc::new(42i32, GFP_KERNEL= )?; @@ -53,7 +53,7 @@ fn arc_dyn_print(arc: &Arc) { } =20 // Pretty-prints the debug formatting with lower-case hexadecimal inte= gers. - pr_info!("{:#x?}", a); + pr_info!("{:#x?}\n", a); =20 Ok(()) } --=20 2.48.1