On 1/11/2025 3:25 PM, Ricardo Ribalda wrote:
> Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame.
> There is no need to do a 64 bit division here.
>
> Also, the driver only works with whole fps.
>
> Found with cocci:
> drivers/media/platform/qcom/venus/venc.c:418:1-7: WARNING: do_div() does a 64-by-32 division, please consider using div64_u64 instead.
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Ricardo Ribalda <ribalda@chromium.org>
> ---
> drivers/media/platform/qcom/venus/venc.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platform/qcom/venus/venc.c
> index 17bec44c9825..2c1836712362 100644
> --- a/drivers/media/platform/qcom/venus/venc.c
> +++ b/drivers/media/platform/qcom/venus/venc.c
> @@ -412,8 +412,7 @@ static int venc_s_parm(struct file *file, void *fh, struct v4l2_streamparm *a)
> do_div(us_per_frame, timeperframe->denominator);
>
> us_per_frame = max(USEC_PER_SEC, us_per_frame);
> - fps = (u64)USEC_PER_SEC;
> - do_div(fps, us_per_frame);
> + fps = USEC_PER_SEC / (u32)us_per_frame;
> fps = min(VENUS_MAX_FPS, fps);
>
> inst->fps = fps;
>
Reviewed-by: Vikash Garodia <quic_vgarodia@quicinc.com>