From nobody Mon Feb 9 17:57:51 2026 Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2F21193070 for ; Sat, 11 Jan 2025 09:55:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.222.170 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589335; cv=none; b=u1OKAUOMPbzOVXErpClHtpk0c7dbWDms1iTvTkFEeBgmNRUe9tXdQrtX9xSRthXkkbuFU6oxspkDOkCrgImcWdtcO73qBFY4SxbaFFNNprTueYOtyV0XWtJt+VQ1y2CSToYZcT7g0WIaCrlbkDCHmAWW76PC+egOOa3p9am9ios= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736589335; c=relaxed/simple; bh=jFMkE+aUW4A2Tjf06APpBG1sAvp2ejflRJ8B5s0jBLU=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=EvMylIobWCAbmJALgwYgx9hO65y7bFCdE8WSqM76rx6hs/wzGKEreoa2nLhjc9BkYVrMF7Yfgwxhc7RhCRCz6fzotun4c61ENoRsEb1JGwDaqWUsBCdzKjMb9ga28HAOUD4dqQwiJUSqHRE2ASgAkDAspbnURG99s5uW3Yp85zU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org; spf=pass smtp.mailfrom=chromium.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b=mCcEB6AR; arc=none smtp.client-ip=209.85.222.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=chromium.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=chromium.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="mCcEB6AR" Received: by mail-qk1-f170.google.com with SMTP id af79cd13be357-7b6ea711805so351897185a.1 for ; Sat, 11 Jan 2025 01:55:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1736589332; x=1737194132; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=f3BoX2c5ZbHlzZ/xObQ8c1PFxHvs7MLN/22FFGinwVE=; b=mCcEB6ARKeodZcnA1Gx8oNr0n9S6uBgT4tEHYUrfrd7tMsEO7wYPvOQ0fK/n63Csj+ RFrq4t1x2v/PutZLK5hQlHThygxjHiv4blcS/bs0Rr2U0DB1D/kMEVRFW2msX4wL84rH ClMYhX4zc2NlCWB+x+wv4fq4N23H693Egy3O4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1736589332; x=1737194132; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=f3BoX2c5ZbHlzZ/xObQ8c1PFxHvs7MLN/22FFGinwVE=; b=HJMEiw0LO/IAT6UU8yNV/93MaOTbDzethjxkmmTOP4m3cu16KrFp6xlsL2oSj1pGyH fGX5nJ/tTghnv44PTnYbjRD1bNDdTRA7oybwBZ7CKMDW+mot0RaNM5/xvxrV1uGWu8IW KnnaelCxl9B6nXM17si6y4JVKc2iEr1/zCKDc/HfLCBPzwr345bbxGKJWfwJ3OM6O7C6 CSBB6jUO15UylGCsnd59uF0td+RCW7i35ZLJ0tJKwe0ol+ReqrSu2cwVkkiN/W9Hwh3A gtOxRIL6dXMuoFPEU+bUjOmOKTPbmrsldEQPAKYiBTGVXhd+wOGhwveYMwoEnEKTWz9D snMA== X-Forwarded-Encrypted: i=1; AJvYcCX1HZ2opNKjGL1lsJwe5jZPzFm0ahE6Q+LOwQNrakDvzo4FYCszRCQByGpJSoUcTSJ0LBSRKo7a83lR/2g=@vger.kernel.org X-Gm-Message-State: AOJu0YypnnwNviiLCU/edoooqbQWheNo8BUdLF4jr2+huvVX9daYEOnS absLljUgsojInM9G5+7ZThWL87WywQrJ4CDyhzZNEVeBNaC/46Y9SQ2944L+LKpEtwAh7OOTZSE 7fQ== X-Gm-Gg: ASbGncsQ9Q5UelNpGe0+hRNMKoIglCWsp/Mdq2dmfagzqxtSArTzRx2PQOUGv/XQnbQ bUmX+m6JBpUP3vbI/SVLupIeWluN7EiNQxJtQ7T0v/Xn6xASMl9bjqiujd5530+6caGJvu6ub3a IZdFlhEee6yVd1HjJr/MH9DFcXwVmpIg/QmXyH1iA2FXTW0+tV/6eLPMZtdVnx4JgXi01ZNRmBH PcgdCvSYqFdeXUG5mVrms1CaoR6kK8S940LwFkvo0U+nwDDOxcvUemTPfeWsjJ9p+dgPAmFf1Rl rRgkMEPKJGlarY6LTef9VoE+TeXLg3TVRZi0 X-Google-Smtp-Source: AGHT+IHlflZapXB2U5EwdDsff9V9lka7ZWi7FvO7mOnx6N5gTF17d6mrdBuskWw0aArQ5dE890/KbQ== X-Received: by 2002:a05:620a:2481:b0:7b6:ece3:825d with SMTP id af79cd13be357-7bcd9726520mr1906864685a.12.1736589332721; Sat, 11 Jan 2025 01:55:32 -0800 (PST) Received: from denia.c.googlers.com (172.174.245.35.bc.googleusercontent.com. [35.245.174.172]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7bce327b8besm267096785a.59.2025.01.11.01.55.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 11 Jan 2025 01:55:31 -0800 (PST) From: Ricardo Ribalda Date: Sat, 11 Jan 2025 09:55:18 +0000 Subject: [PATCH v6 5/6] media: venus: venc: Make the range of us_per_frame explicit Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Message-Id: <20250111-fix-cocci-v6-5-1aa7842006cc@chromium.org> References: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org> In-Reply-To: <20250111-fix-cocci-v6-0-1aa7842006cc@chromium.org> To: Mauro Carvalho Chehab , Stanimir Varbanov , Vikash Garodia , Bryan O'Donoghue , Hans Verkuil Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, Ricardo Ribalda X-Mailer: b4 0.13.0 Fps bigger than 0.000232829 fps, this fits in a 32 bit us_per_frame. There is no need to do a 64 bit division here. Also, the driver only works with whole fps. Found with cocci: drivers/media/platform/qcom/venus/venc.c:418:1-7: WARNING: do_div() does a = 64-by-32 division, please consider using div64_u64 instead. Reviewed-by: Bryan O'Donoghue Signed-off-by: Ricardo Ribalda Reviewed-by: Vikash Garodia --- drivers/media/platform/qcom/venus/venc.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/media/platform/qcom/venus/venc.c b/drivers/media/platf= orm/qcom/venus/venc.c index 17bec44c9825..2c1836712362 100644 --- a/drivers/media/platform/qcom/venus/venc.c +++ b/drivers/media/platform/qcom/venus/venc.c @@ -412,8 +412,7 @@ static int venc_s_parm(struct file *file, void *fh, str= uct v4l2_streamparm *a) do_div(us_per_frame, timeperframe->denominator); =20 us_per_frame =3D max(USEC_PER_SEC, us_per_frame); - fps =3D (u64)USEC_PER_SEC; - do_div(fps, us_per_frame); + fps =3D USEC_PER_SEC / (u32)us_per_frame; fps =3D min(VENUS_MAX_FPS, fps); =20 inst->fps =3D fps; --=20 2.47.1.613.gc27f4b7a9f-goog