phy: rockchip: naneng-combphy: compatible reset with old DT

[PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

Posted by Chukun Pan 1 year, 1 month ago

Changes in v2:
  Matches the '-ENOENT' error.
  Use devm_reset_control_get_exclusive.

Chukun Pan (1):
  phy: rockchip: naneng-combphy: compatible reset with old DT

 drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

-- 
2.25.1

Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

Posted by Vinod Koul 1 year ago

On Mon, 06 Jan 2025 18:00:00 +0800, Chukun Pan wrote:
> Changes in v2:
>   Matches the '-ENOENT' error.
>   Use devm_reset_control_get_exclusive.
> 
> Chukun Pan (1):
>   phy: rockchip: naneng-combphy: compatible reset with old DT
> 
> [...]

Applied, thanks!

[1/1] phy: rockchip: naneng-combphy: compatible reset with old DT
      commit: bff68d44135ce6714107e2f72069a79476c8073d

Best regards,
-- 
~Vinod

Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

Posted by Valentin Kleibel 12 months ago

Hi,

>> Chukun Pan (1):
>>    phy: rockchip: naneng-combphy: compatible reset with old DT
>>
>> [...]
> 
> Applied, thanks!
> 
> [1/1] phy: rockchip: naneng-combphy: compatible reset with old DT
>        commit: bff68d44135ce6714107e2f72069a79476c8073d

Thanks for your work!
We found your patch after NVMes stopped working on a rock 3A with newer 
kernels and successfully applied it to kernel 6.1.128 (currently in debian).

As the commit breaking NVMe functionality on rk3568 platforms 
(fd3ac6e80497 "phy: rockchip: naneng-combphy: fix phy reset") was 
already backported to 6.1.y, 6.6.y, 6.12.y it would be great to have 
this fix in these releases as well.

Best regards,
Valentin

Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

Posted by Diederik de Haas 11 months, 3 weeks ago

On Tue Feb 11, 2025 at 2:03 PM CET, Valentin Kleibel wrote:
>>> Chukun Pan (1):
>>>    phy: rockchip: naneng-combphy: compatible reset with old DT
>> 
>> Applied, thanks!
>> 
>> [1/1] phy: rockchip: naneng-combphy: compatible reset with old DT
>>        commit: bff68d44135ce6714107e2f72069a79476c8073d
>
> Thanks for your work!
> We found your patch after NVMes stopped working on a rock 3A with newer 
> kernels and successfully applied it to kernel 6.1.128 (currently in debian).

FTR: I've reported it in Debian here: https://bugs.debian.org/1098250

I confirmed it (also) broke on kernel 6.12.8-1.

Cheers,
  Diederik

Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

Posted by Salvatore Bonaccorso 11 months, 3 weeks ago

Hi,

On Tue, Feb 18, 2025 at 12:45:34PM +0100, Diederik de Haas wrote:
> On Tue Feb 11, 2025 at 2:03 PM CET, Valentin Kleibel wrote:
> >>> Chukun Pan (1):
> >>>    phy: rockchip: naneng-combphy: compatible reset with old DT
> >> 
> >> Applied, thanks!
> >> 
> >> [1/1] phy: rockchip: naneng-combphy: compatible reset with old DT
> >>        commit: bff68d44135ce6714107e2f72069a79476c8073d
> >
> > Thanks for your work!
> > We found your patch after NVMes stopped working on a rock 3A with newer 
> > kernels and successfully applied it to kernel 6.1.128 (currently in debian).
> 
> FTR: I've reported it in Debian here: https://bugs.debian.org/1098250
> 
> I confirmed it (also) broke on kernel 6.12.8-1.

FWIW, we have several users in Debian reporting the problem, so if it
can be applied to mainline and then flow down to one of the next round
of stable series down to 6.1.y that would be highly appreicated.

Diederik, if you were able to test the fix, you might contribute a
Tested-by (although as I undestsand its not strictly needed at this
point as commit should be on way to mainline and stable series)?

Regards,
Salvatore

Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

Posted by Diederik de Haas 11 months, 3 weeks ago

On Fri Feb 21, 2025 at 8:18 AM CET, Salvatore Bonaccorso wrote:
> On Tue, Feb 18, 2025 at 12:45:34PM +0100, Diederik de Haas wrote:
>> On Tue Feb 11, 2025 at 2:03 PM CET, Valentin Kleibel wrote:
>> >>> Chukun Pan (1):
>> >>>    phy: rockchip: naneng-combphy: compatible reset with old DT
>> >> 
>> >> Applied, thanks!
>> >> 
>> >> [1/1] phy: rockchip: naneng-combphy: compatible reset with old DT
>> >>        commit: bff68d44135ce6714107e2f72069a79476c8073d
>> >
>> > Thanks for your work!
>> > We found your patch after NVMes stopped working on a rock 3A with newer 
>> > kernels and successfully applied it to kernel 6.1.128 (currently in debian).
>> 
>> FTR: I've reported it in Debian here: https://bugs.debian.org/1098250
>> 
>> I confirmed it (also) broke on kernel 6.12.8-1.
>
> FWIW, we have several users in Debian reporting the problem, so if it
> can be applied to mainline and then flow down to one of the next round
> of stable series down to 6.1.y that would be highly appreicated.
>
> Diederik, if you were able to test the fix, you might contribute a
> Tested-by (although as I undestsand its not strictly needed at this
> point as commit should be on way to mainline and stable series)?

AFAIK a Tested-by could increase the chances of the maintainer accepting
the patch, but that has already happened (commit date: 2025-02-04).
The patch was already verified to fix the problem before submission:
https://lore.kernel.org/all/20250103171109.2726312-1-liujianfeng1994@gmail.com/

So AFAICT another Tested-by would either have no effect or a delaying
effect (adding it would change a bunch of commit IDs probably triggering
various CIs to run again).
I'm not aware of anything (else) I could do wrt this patch.

Cheers,
  Diederik

Re: [PATCH v2 0/1] phy: rockchip: naneng-combphy: compatible reset with old DT

Posted by Heiko Stübner 11 months, 3 weeks ago

Am Freitag, 21. Februar 2025, 09:57:14 MEZ schrieb Diederik de Haas:
> On Fri Feb 21, 2025 at 8:18 AM CET, Salvatore Bonaccorso wrote:
> > On Tue, Feb 18, 2025 at 12:45:34PM +0100, Diederik de Haas wrote:
> >> On Tue Feb 11, 2025 at 2:03 PM CET, Valentin Kleibel wrote:
> >> >>> Chukun Pan (1):
> >> >>>    phy: rockchip: naneng-combphy: compatible reset with old DT
> >> >> 
> >> >> Applied, thanks!
> >> >> 
> >> >> [1/1] phy: rockchip: naneng-combphy: compatible reset with old DT
> >> >>        commit: bff68d44135ce6714107e2f72069a79476c8073d
> >> >
> >> > Thanks for your work!
> >> > We found your patch after NVMes stopped working on a rock 3A with newer 
> >> > kernels and successfully applied it to kernel 6.1.128 (currently in debian).
> >> 
> >> FTR: I've reported it in Debian here: https://bugs.debian.org/1098250
> >> 
> >> I confirmed it (also) broke on kernel 6.12.8-1.
> >
> > FWIW, we have several users in Debian reporting the problem, so if it
> > can be applied to mainline and then flow down to one of the next round
> > of stable series down to 6.1.y that would be highly appreicated.
> >
> > Diederik, if you were able to test the fix, you might contribute a
> > Tested-by (although as I undestsand its not strictly needed at this
> > point as commit should be on way to mainline and stable series)?
> 
> AFAIK a Tested-by could increase the chances of the maintainer accepting
> the patch, but that has already happened (commit date: 2025-02-04).
> The patch was already verified to fix the problem before submission:
> https://lore.kernel.org/all/20250103171109.2726312-1-liujianfeng1994@gmail.com/
> 
> So AFAICT another Tested-by would either have no effect or a delaying
> effect (adding it would change a bunch of commit IDs probably triggering
> various CIs to run again).
> I'm not aware of anything (else) I could do wrt this patch.

the patch already is in the fixes-branch of the phy-tree [0], sho should
make its way into 6.14-rc shortly.

Heiko

[0] https://git.kernel.org/pub/scm/linux/kernel/git/phy/linux-phy.git/log/?h=fixes