From nobody Wed Feb 11 03:26:06 2026 Received: from mail-m49198.qiye.163.com (mail-m49198.qiye.163.com [45.254.49.198]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB8BC1DA63D for ; Mon, 6 Jan 2025 10:00:11 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=45.254.49.198 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736157614; cv=none; b=iwnrGEWSm2DljqQ9OIdfsoxi1CHIOs6w4stIIUhc5CaiJpPEyiXL34DphPT3EkrhksPu8GfyGp7YPursxXLLrOhYlnKhx6UEwbfWrKHPvOtZ7hA486hMoKuvfAYFCJBQx6UrBzcFU9zk6J/kx/5zck+7x60BRl/C3wPhX8EVVIc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1736157614; c=relaxed/simple; bh=ftWSzQhWnwxCyauMWh4iP6xk77vJ/Ef4yce1GPnjwgQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=tf/goAE+c+dryp0vkSrUh5PBTA7GrvPNGncclIlQksDACLqgTSE0McvMVATXGlKdN7c1/wpdAjyli2OGugougL9KXIvtM8zhTARPW2w/DN7aT7VPmxM6nxIxGHK3J56draWlhNGHavlmhksjyOmLEL93YTBhX1/8EMpbSVnQCl4= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=jmu.edu.cn; spf=pass smtp.mailfrom=jmu.edu.cn; arc=none smtp.client-ip=45.254.49.198 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=jmu.edu.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=jmu.edu.cn Received: from amadeus-Vostro-3710.lan (unknown [IPV6:240e:3b3:2c05:ad20::1]) by smtp.qiye.163.com (Hmail) with ESMTP id 7d57e693; Mon, 6 Jan 2025 18:00:08 +0800 (GMT+08:00) From: Chukun Pan To: Vinod Koul Cc: Heiko Stuebner , Philipp Zabel , Kishon Vijay Abraham I , Jianfeng Liu , linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org, Chukun Pan Subject: [PATCH v2 1/1] phy: rockchip: naneng-combphy: compatible reset with old DT Date: Mon, 6 Jan 2025 18:00:01 +0800 Message-Id: <20250106100001.1344418-2-amadeus@jmu.edu.cn> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20250106100001.1344418-1-amadeus@jmu.edu.cn> References: <20250106100001.1344418-1-amadeus@jmu.edu.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFITzdXWS1ZQUlXWQ8JGhUIEh9ZQVkZQx1OVktDTRlCTU4ZGEseGVYeHw5VEwETFhoSFy QUDg9ZV1kYEgtZQVlJT0seQUgZSEFJGEtOQRofSUtBQUpZV1kWGg8SFR0UWUFZT0tIVUpLSU9PT0 tVSktLVUtZBg++ X-HM-Tid: 0a943b0eb88503a2kunm7d57e693 X-HM-MType: 10 X-HM-Sender-Digest: e1kMHhlZQR0aFwgeV1kSHx4VD1lBWUc6Pzo6Nyo*ETIONR8*HgFKHzxC GChPCSJVSlVKTEhNSk5MTUtDQ01CVTMWGhIXVRoWGh8eDgg7ERYOVR4fDlUYFUVZV1kSC1lBWUlP Sx5BSBlIQUkYS05BGh9JS0FBSllXWQgBWUFKSU1ONwY+ Content-Type: text/plain; charset="utf-8" The device tree of RK3568 did not specify reset-names before. So add fallback to old behaviour to be compatible with old DT. Fixes: fbcbffbac994 ("phy: rockchip: naneng-combphy: fix phy reset") Cc: Jianfeng Liu Signed-off-by: Chukun Pan Reviewed-by: Jonas Karlman Tested-by (although as I undestsand its not strictly needed at this --- drivers/phy/rockchip/phy-rockchip-naneng-combphy.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c b/drivers/p= hy/rockchip/phy-rockchip-naneng-combphy.c index a1532ef8bbe9..8c3ce57f8915 100644 --- a/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c +++ b/drivers/phy/rockchip/phy-rockchip-naneng-combphy.c @@ -324,7 +324,10 @@ static int rockchip_combphy_parse_dt(struct device *de= v, struct rockchip_combphy =20 priv->ext_refclk =3D device_property_present(dev, "rockchip,ext-refclk"); =20 - priv->phy_rst =3D devm_reset_control_get(dev, "phy"); + priv->phy_rst =3D devm_reset_control_get_exclusive(dev, "phy"); + /* fallback to old behaviour */ + if (PTR_ERR(priv->phy_rst) =3D=3D -ENOENT) + priv->phy_rst =3D devm_reset_control_array_get_exclusive(dev); if (IS_ERR(priv->phy_rst)) return dev_err_probe(dev, PTR_ERR(priv->phy_rst), "failed to get phy res= et\n"); =20 --=20 2.25.1