[PATCH v2 3/3] dt-bindings: iio: adis16480: add devices to adis16480

Darius Berghe posted 3 patches 2 weeks, 2 days ago
There is a newer version of this series
[PATCH v2 3/3] dt-bindings: iio: adis16480: add devices to adis16480
Posted by Darius Berghe 2 weeks, 2 days ago
Add the adis16486, adis16487 and adis16489 Six Degrees
of Freedom Inertial Sensors to the list of compatible devices
of the adis16480 iio subsystem driver.

adis16486 is similar to adis16485, has the exact same channels
but acceleration and delta velocity scales are different.

adis16487 is fallback compatible with adis16485.

adis16489 is similar to adis16488 but lacks the magnetometer
and has a different accelerometer scale.

Signed-off-by: Darius Berghe <darius.berghe@analog.com>
---
 Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml
index e3eec38897bf..2d3e6ecec6a5 100644
--- a/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml
@@ -15,7 +15,9 @@ properties:
       - adi,adis16375
       - adi,adis16480
       - adi,adis16485
+      - adi,adis16486
       - adi,adis16488
+      - adi,adis16489
       - adi,adis16490
       - adi,adis16495-1
       - adi,adis16495-2
@@ -29,6 +31,9 @@ properties:
       - adi,adis16547-1
       - adi,adis16547-2
       - adi,adis16547-3
+    - items
+      - const: adi,adis16487
+      - const: adi,adis16485
 
   reg:
     maxItems: 1
-- 
2.46.1
Re: [PATCH v2 3/3] dt-bindings: iio: adis16480: add devices to adis16480
Posted by Krzysztof Kozlowski 2 weeks, 1 day ago
On 07/11/2024 14:45, Darius Berghe wrote:
> Add the adis16486, adis16487 and adis16489 Six Degrees
> of Freedom Inertial Sensors to the list of compatible devices
> of the adis16480 iio subsystem driver.
> 
> adis16486 is similar to adis16485, has the exact same channels
> but acceleration and delta velocity scales are different.
> 
> adis16487 is fallback compatible with adis16485.

This was never tested - visible easily from the diff. No need to ask
reviewers to do the tools job. Tools are for that.

<form letter>
Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC. It might happen, that command when run on an older
kernel, gives you outdated entries. Therefore please be sure you base
your patches on recent Linux kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

You missed at least devicetree list (maybe more), so this won't be
tested by automated tooling. Performing review on untested code might be
a waste of time.

Please kindly resend and include all necessary To/Cc entries.
</form letter>

Best regards,
Krzysztof