[v2] Implement setup_interface() in the DaVinci NAND controller

[PATCH v2 0/6] Implement setup_interface() in the DaVinci NAND controller

Bastien Curutchet posted 6 patches 2 weeks, 3 days ago

Diff against v3 v4
Download series mbox

There is a newer version of this series

drivers/memory/ti-aemif.c           | 102 +++++++++++++++++++---------
drivers/mtd/nand/raw/Kconfig        |   4 +-
drivers/mtd/nand/raw/davinci_nand.c |  93 +++++++++++++++++++++++--
include/linux/memory/ti-aemif.h     |  31 +++++++++
4 files changed, 191 insertions(+), 39 deletions(-)
create mode 100644 include/linux/memory/ti-aemif.h

Expand all Fold all

[PATCH v2 0/6] Implement setup_interface() in the DaVinci NAND controller

Posted by Bastien Curutchet 2 weeks, 3 days ago

Hi all,

This patch series aims to implement the setup_interface() operation in
the DaVinci NAND controller to enable the use of all ONFI modes and
improve the NAND access speed.

PATCH 2 depends on PATCH 1
PATCH 6 depends on PATCH 2-4-5

This NAND controller is present in the DaVinci (OMAP L138) and Keystone2
SoCs and functions as a 'child' of the AEMIF controller. So its timings
are set by the AEMIF controller itself from device-tree properties.
Implementing the setup_interface() callback implies being able to update
dynamically these timings, so the first two patches of the series modify
the AEMIF driver to provide its 'children' a way to modify their chip
select timing configuration.

The remaining patches implement the setup_interface() operation.
The computation of the register's contents is directly based on
§20.3.2.3 of the OMAP-L138 TRM [1]

This has been tested on two platforms based upon the DaVinci SoC. One is
interfaced with a Macronix MX30UF4G18AC NAND, the other with a Toshiba
NAND.

[1] : https://www.ti.com/lit/ug/spruh77c/spruh77c.pdf

Change log:

 * v2
   Cover letter :
     - Add dependency details
     - Remove the question about ti-aemif.h location
   PATCH 1 :
     - Fix aemif_cs_timings's description in the comments
   PATCH 2 :
     - Fix typo in the config_cs_lock's description in the comments
     - Move include/memory/ti-aemif.h to include/linux/memory/ti-aemif.h
   PATCH 3 [NEW] :
     - Fix dependency issue with aemif controller in Kconfig
   PATCH 5 :
     - Add details about the clock bindings in the commit log
     - Replace devm_clk_get() with devm_clk_get_enabled()
     - Use dev_err_probe() to return the devm_clk_get_enabled() error

Bastien Curutchet (6):
  memory: ti-aemif: Create aemif_set_cs_timings()
  memory: ti-aemif: Export aemif_set_cs_timings()
  mtd: rawnand: davinci: Always depends on TI_AEMIF
  mtd: rawnand: davinci: Order headers alphabetically
  mtd: rawnand: davinci: Add clock resource
  mtd: rawnand: davinci: Implement setup_interface() operation

 drivers/memory/ti-aemif.c           | 102 +++++++++++++++++++---------
 drivers/mtd/nand/raw/Kconfig        |   4 +-
 drivers/mtd/nand/raw/davinci_nand.c |  93 +++++++++++++++++++++++--
 include/linux/memory/ti-aemif.h     |  31 +++++++++
 4 files changed, 191 insertions(+), 39 deletions(-)
 create mode 100644 include/linux/memory/ti-aemif.h

-- 
2.47.0