[v2] Fix dtc warnings when building the LAN966x device tree overlay

[PATCH v2 0/2] Fix dtc warnings when building the LAN966x device tree overlay

Posted by Herve Codina 1 year, 3 months ago

dtc generates 3 kinds of warnings when it builds the LAN966x dtso.

- missing or empty reg/ranges property
    .../pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
    .../pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
    .../pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
  Patch 1 in this series fixes these warnings

- Missing interrupt-parent
   .../pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
  This warning was quickly silenced by Philipp [1].
  Patch 2 in this series fixes the warning and should replace the patch
  applied by Philipp to silence the warning.

- Warning (avoid_unnecessary_addr_size)
   /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
  This warning should be fixed in dtc.
  A patch has already be sent by Philip to fix it [2].

[1] https://lore.kernel.org/all/57793bb01e02f03e215dfa6f8783df18034ae2ea.camel@pengutronix.de/
[2] https://lore.kernel.org/devicetree-compiler/20241025161307.3629901-1-p.zabel@pengutronix.de/T/#u

Compare to the previous iteration, this v2 series mainly renames clock
nodes.

Best regards,
Hervé

Changes v1 -> v2
  v1: https://lore.kernel.org/lkml/20241028122405.27090-1-herve.codina@bootlin.com/

  - Patch 1
    Rename clock nodes

  - Patch 2
    Add 'Reviewed-by: Rob Herring (Arm) <robh@kernel.org>'

Herve Codina (2):
  misc: lan966x_pci: Fix dtc warns 'missing or empty reg/ranges
    property'
  misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent'

 drivers/misc/lan966x_pci.dtso | 46 +++++++++++++++++++++--------------
 1 file changed, 28 insertions(+), 18 deletions(-)

-- 
2.46.2

Re: [PATCH v2 0/2] Fix dtc warnings when building the LAN966x device tree overlay

Posted by Herve Codina 1 year, 3 months ago

Hi Philipp,


On Tue, 29 Oct 2024 09:43:34 +0100
Herve Codina <herve.codina@bootlin.com> wrote:

> dtc generates 3 kinds of warnings when it builds the LAN966x dtso.
> 
> - missing or empty reg/ranges property
>     .../pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
>     .../pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
>     .../pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
>   Patch 1 in this series fixes these warnings
> 
> - Missing interrupt-parent
>    .../pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
>   This warning was quickly silenced by Philipp [1].
>   Patch 2 in this series fixes the warning and should replace the patch
>   applied by Philipp to silence the warning.
> 
> - Warning (avoid_unnecessary_addr_size)
>    /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
>   This warning should be fixed in dtc.
>   A patch has already be sent by Philip to fix it [2].
> 
> [1] https://lore.kernel.org/all/57793bb01e02f03e215dfa6f8783df18034ae2ea.camel@pengutronix.de/
> [2] https://lore.kernel.org/devicetree-compiler/20241025161307.3629901-1-p.zabel@pengutronix.de/T/#u
> 

Both patches in this series have been reviewed by Rob.

I think it is a green light to have them applied in the reset tree.
Your opinion?

Best regards,
Hervé

Re: [PATCH v2 0/2] Fix dtc warnings when building the LAN966x device tree overlay

Posted by Philipp Zabel 1 year, 3 months ago

On Do, 2024-10-31 at 16:01 +0100, Herve Codina wrote:
> Hi Philipp,
> 
> 
> On Tue, 29 Oct 2024 09:43:34 +0100
> Herve Codina <herve.codina@bootlin.com> wrote:
> 
> > dtc generates 3 kinds of warnings when it builds the LAN966x dtso.
> > 
> > - missing or empty reg/ranges property
> >     .../pci-ep-bus@0/cpu_clk: missing or empty reg/ranges property
> >     .../pci-ep-bus@0/ddr_clk: missing or empty reg/ranges property
> >     .../pci-ep-bus@0/sys_clk: missing or empty reg/ranges property
> >   Patch 1 in this series fixes these warnings
> > 
> > - Missing interrupt-parent
> >    .../pci-ep-bus@0/oic@e00c0120: Missing interrupt-parent
> >   This warning was quickly silenced by Philipp [1].
> >   Patch 2 in this series fixes the warning and should replace the patch
> >   applied by Philipp to silence the warning.
> > 
> > - Warning (avoid_unnecessary_addr_size)
> >    /fragment@0/__overlay__: unnecessary #address-cells/#size-cells without "ranges", "dma-ranges" or child "reg" property
> >   This warning should be fixed in dtc.
> >   A patch has already be sent by Philip to fix it [2].
> > 
> > [1] https://lore.kernel.org/all/57793bb01e02f03e215dfa6f8783df18034ae2ea.camel@pengutronix.de/
> > [2] https://lore.kernel.org/devicetree-compiler/20241025161307.3629901-1-p.zabel@pengutronix.de/T/#u
> > 
> 
> Both patches in this series have been reviewed by Rob.
> 
> I think it is a green light to have them applied in the reset tree.
> Your opinion?

Applied to reset/next, thanks!

[1/2] misc: lan966x_pci: Fix dtc warns 'missing or empty reg/ranges property'
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=344ea0d36b8c
[2/2] misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent'
      https://git.pengutronix.de/cgit/pza/linux/commit/?id=cf3e10cc0e88

I've dropped the Makefile patch ("misc: Silence warning when building
the LAN966x device tree overlay").

regards
Philipp