From nobody Sun Feb 8 09:34:28 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8D1142038D5; Tue, 29 Oct 2024 08:43:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730191428; cv=none; b=MRYwE0UTyt/wrHtOMvHSQ913R6d6t9oR6Nvg/7vjx/ACk/vKruI+83HeVQifuyNYV/cy3DUPzCJkiMLoM3Ce7rlnf5Es61vsvhsSOGET22x6yMe8ktGx8R/1w/dHs+9nsGZAvDX7TsVBRGS1Wl9Zlrhrv7DaYevMc4im9Aaz8Cw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730191428; c=relaxed/simple; bh=2NPTcLzosjlG2WPk5zm2GqcFUGGwRN1nqa58VDYz+p4=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=QDsA4wuS5LOeYNV/FrD6+7iOik26vsuFaIhHPKiplyjJ9Gw3MCsOznlJp9GHwt4knDk7C7u+Sms5AChV3Fisd/M0+mPINVCNSqjQ0M5Fw5ngiHqHempxc023vtm2yzVRRjubfksAgrjAdmSvSQ6w8yE8GqXsB9yZb1XxyN3XlKI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=EOrml9Ge; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="EOrml9Ge" Received: by mail.gandi.net (Postfix) with ESMTPA id 5737B240007; Tue, 29 Oct 2024 08:43:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1730191424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SF2CF/mYzu+f+El79p7kcj4eITCPHgWzeq/9zQhGDbI=; b=EOrml9GeqClhFgrerplkL+YSEHChSF9HUZU5TnrOEk/2nBffFq1BSGicFRVBVhDtP7d7HX j0GsExMQmGHNb8yLz7vSlaFFqDhmsTSOm4ywDTxEAtzKkKR0Qs0bQmCBQ0rl6BdtnMNAk8 oAYr/HGDuWBz+u2c4a7RaKJFVIqPfzu/m/5YzL4EqayN5ziQqHVc8H7uPB1ES2nqfM6yy3 rjsjtgwZYw8F1I943+37ptWzmOH/3pcz3jNsAy2+tVYRATGCqqsjCCqDXAkaPpoanW8IdW 7ZF75NKlUX6cbGAwkKZm3DYjuVuO4ckjRbxSpsrcDvi1k8XidGGQY/9en+hEeA== From: Herve Codina To: Philipp Zabel , Stephen Rothwell , Rob Herring Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Allan Nielsen , Horatiu Vultur , Steen Hegelund , Thomas Petazzoni , Herve Codina Subject: [PATCH v2 1/2] misc: lan966x_pci: Fix dtc warns 'missing or empty reg/ranges property' Date: Tue, 29 Oct 2024 09:43:35 +0100 Message-ID: <20241029084338.194942-2-herve.codina@bootlin.com> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241029084338.194942-1-herve.codina@bootlin.com> References: <20241029084338.194942-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: herve.codina@bootlin.com Content-Type: text/plain; charset="utf-8" dtc generates the following warnings when building the LAN966x device tree overlay (lan966x_pci.dtso): Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/cpu_clk: m= issing or empty reg/ranges property Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/ddr_clk: m= issing or empty reg/ranges property Warning (simple_bus_reg): /fragment@0/__overlay__/pci-ep-bus@0/sys_clk: m= issing or empty reg/ranges property Indeed, related nodes are under the pci-ep-bus (simple-bus) which is not correct. Put them outside this node. Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.a= u/ Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device") Signed-off-by: Herve Codina Reviewed-by: Rob Herring (Arm) --- The referenced commit is in the reset tree --- drivers/misc/lan966x_pci.dtso | 36 +++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/misc/lan966x_pci.dtso b/drivers/misc/lan966x_pci.dtso index 7282687df25f..e9b304c6ced3 100644 --- a/drivers/misc/lan966x_pci.dtso +++ b/drivers/misc/lan966x_pci.dtso @@ -19,6 +19,24 @@ __overlay__ { #address-cells =3D <3>; #size-cells =3D <2>; =20 + cpu_clk: clock-600000000 { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <600000000>; /* CPU clock =3D 600MHz */ + }; + + ddr_clk: clock-30000000 { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <30000000>; /* Fabric clock =3D 30MHz */ + }; + + sys_clk: clock-15625000 { + compatible =3D "fixed-clock"; + #clock-cells =3D <0>; + clock-frequency =3D <15625000>; /* System clock =3D 15.625MHz */ + }; + pci-ep-bus@0 { compatible =3D "simple-bus"; #address-cells =3D <1>; @@ -39,24 +57,6 @@ oic: oic@e00c0120 { reg =3D <0xe00c0120 0x190>; }; =20 - cpu_clk: cpu_clk { - compatible =3D "fixed-clock"; - #clock-cells =3D <0>; - clock-frequency =3D <600000000>; // CPU clock =3D 600MHz - }; - - ddr_clk: ddr_clk { - compatible =3D "fixed-clock"; - #clock-cells =3D <0>; - clock-frequency =3D <30000000>; // Fabric clock =3D 30MHz - }; - - sys_clk: sys_clk { - compatible =3D "fixed-clock"; - #clock-cells =3D <0>; - clock-frequency =3D <15625000>; // System clock =3D 15.625MHz - }; - cpu_ctrl: syscon@e00c0000 { compatible =3D "microchip,lan966x-cpu-syscon", "syscon"; reg =3D <0xe00c0000 0xa8>; --=20 2.46.2 From nobody Sun Feb 8 09:34:28 2026 Received: from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net [217.70.183.193]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DEAF8204010; Tue, 29 Oct 2024 08:43:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.193 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730191429; cv=none; b=aGceawhvVSZOfr0qWlRXe1uz1ze+GjYioHNwjdO6TphjpaTuktixCiFFz6k/5QxL74G6SLYdLlS1mcx5Rzmndl4OpMRbwEhuwrMcJopZClmrMD/R5pjW3vL2Otyfz2ytR44BOiqknJlfsIW66hUhCo7AI05663HSTAMh49yDfPQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1730191429; c=relaxed/simple; bh=HMcBWFfujWBix5ITgC7z0CppRyqxsoeqQ5rZJujM0Ns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=BFAlUSUCvPho8udbRpem7/PqRHVjJMDMtFhREkJcbIFam0+Jv6rVeSPttoZxDomtuivI9BZt1YV5NDrrNSOCDabRMZEIAdsh4PK0y9uxJhYjafqTXG9xvWAW3qg6bGAkDy6mL8XnokrCi8rL8GNzKl1dBI5Jhapyl2pfCw0BSvo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=D2lLN4XA; arc=none smtp.client-ip=217.70.183.193 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="D2lLN4XA" Received: by mail.gandi.net (Postfix) with ESMTPA id CF05A24000E; Tue, 29 Oct 2024 08:43:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=gm1; t=1730191425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=pEwLQTEOeLx41I6eLhkhYWSRhXIhGZLm/T+Wzn00paw=; b=D2lLN4XA84Rvs2AUkW45UW5cjKfvyjYwmN0ZWi5zF0lhl+l4xcFQxmpzrk1zO85L5oXVUd wWQcdS7hLNG4bC06yw1tmw45tQDyD6m0WHx+fCp0mfCgJLWC6/yHTCXwczrupF0+NUsGq8 +4076/8TFOF6k5SE7OTqlFE7t2CBIAvKCXo1Q6q+StcUVJTG2dtdho/OZJWkSvZPMP5F7g afIMmlNv5/ZkxRrvMeqaigpNnntv3bh71zZLbBdPV3Dveq0uf2n29lnlXrJBpqF5lllQSz JsCr/g+i20ICzNAH3HRRYmNGPCy7ugD6IhnoPy0Ut321vZqQ+ELNIDKUIed+vA== From: Herve Codina To: Philipp Zabel , Stephen Rothwell , Rob Herring Cc: linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Arnd Bergmann , Greg Kroah-Hartman , Allan Nielsen , Horatiu Vultur , Steen Hegelund , Thomas Petazzoni , Herve Codina Subject: [PATCH v2 2/2] misc: lan966x_pci: Fix dtc warn 'Missing interrupt-parent' Date: Tue, 29 Oct 2024 09:43:36 +0100 Message-ID: <20241029084338.194942-3-herve.codina@bootlin.com> X-Mailer: git-send-email 2.46.2 In-Reply-To: <20241029084338.194942-1-herve.codina@bootlin.com> References: <20241029084338.194942-1-herve.codina@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: herve.codina@bootlin.com Content-Type: text/plain; charset="utf-8" dtc generates the following warning when building the LAN966x devicetree overlay (lan966x_pci.dtso): Warning (interrupts_property): /fragment@0/__overlay__/pci-ep-bus@0/oic@e= 00c0120: Missing interrupt-parent The oic interrupt parent is the PCI device itself. The PCI device node is the node on which the dtbo will be applied and this node already has properties needed. In order to remove the warning, add the missing properties in the overlay fragment node. Properties in this node will not be added when the overlay is applied (which is what we expect) but makes dtc happy. Reported-by: Stephen Rothwell Closes: https://lore.kernel.org/all/20241025110919.64b1cffb@canb.auug.org.a= u/ Fixes: 185686beb464 ("misc: Add support for LAN966x PCI device") Signed-off-by: Herve Codina Reviewed-by: Rob Herring (Arm) --- The referenced commit is in the reset tree --- drivers/misc/lan966x_pci.dtso | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/misc/lan966x_pci.dtso b/drivers/misc/lan966x_pci.dtso index e9b304c6ced3..7b196b0a0eb6 100644 --- a/drivers/misc/lan966x_pci.dtso +++ b/drivers/misc/lan966x_pci.dtso @@ -15,6 +15,16 @@ / { fragment@0 { target-path =3D ""; + + /* + * These properties allow to avoid a dtc warnings. + * The real interrupt controller is the PCI device itself. It + * is the node on which the device tree overlay will be applied. + * This node has those properties. + */ + #interrupt-cells =3D <1>; + interrupt-controller; + __overlay__ { #address-cells =3D <3>; #size-cells =3D <2>; --=20 2.46.2