.../bindings/display/msm/dp-controller.yaml | 1 + .../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 9 +++ drivers/phy/qualcomm/phy-qcom-edp.c | 74 +++++++++++++------ 4 files changed, 61 insertions(+), 24 deletions(-)
This series adds support for the DisplayPort controller and eDP PHY v5 found on the Qualcomm SA8775P platform. --- v2: Fixed review comments from Dmitry and Bjorn - Made aux_cfg array as const. - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. v3: Fixed review comments from Dmitry, Konrad and Bjorn - Used a for loop to write the dp_phy_aux_cfg registers. - Pre-defined the aux_cfg size to prevent any magic numbers. - Added all the necessary DPTX controllers for this platform. v4: Fixed review comments from Dmitry and Krzysztof - Removed the "reviewed by" and kept only the "acked by" for patch 1. - Updated the commit message of patch 5 to mention specifically about the validation of "only" MDSS0 DPTX0 and DPTX1. v5: Fixed review comment from Dmitry in patch 5 - Aligned the register starting address for display port as part of device description with respect to other targets. Below patches are applied: [1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p commit: 7adb3d221a4d6a4f5e0793c3bd35f1168934035c [2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings commit: 913463587d528d766a8e12c7790995e273ec84fb [3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P commit: 3f12bf16213c30d8e645027efd94a19c13ee0253 --- Soutrik Mukhopadhyay (5): dt-bindings: phy: Add eDP PHY compatible for sa8775p phy: qcom: edp: Introduce aux_cfg array for version specific aux settings phy: qcom: edp: Add support for eDP PHY on SA8775P dt-bindings: display: msm: dp-controller: document SA8775P compatible drm/msm/dp: Add DisplayPort controller for SA8775P .../bindings/display/msm/dp-controller.yaml | 1 + .../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + drivers/gpu/drm/msm/dp/dp_display.c | 9 +++ drivers/phy/qualcomm/phy-qcom-edp.c | 74 +++++++++++++------ 4 files changed, 61 insertions(+), 24 deletions(-) -- 2.17.1
On Fri, Oct 18, 2024 at 12:37:01PM +0530, Soutrik Mukhopadhyay wrote: > This series adds support for the DisplayPort controller > and eDP PHY v5 found on the Qualcomm SA8775P platform. > > --- > v2: Fixed review comments from Dmitry and Bjorn > - Made aux_cfg array as const. > - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. > > v3: Fixed review comments from Dmitry, Konrad and Bjorn > - Used a for loop to write the dp_phy_aux_cfg registers. > - Pre-defined the aux_cfg size to prevent any magic numbers. > - Added all the necessary DPTX controllers for this platform. > > v4: Fixed review comments from Dmitry and Krzysztof > - Removed the "reviewed by" and kept only the "acked by" for > patch 1. > - Updated the commit message of patch 5 to mention specifically > about the validation of "only" MDSS0 DPTX0 and DPTX1. > > v5: Fixed review comment from Dmitry in patch 5 > - Aligned the register starting address for display port as part > of device description with respect to other targets. > > Below patches are applied: > > [1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p > commit: 7adb3d221a4d6a4f5e0793c3bd35f1168934035c > [2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings > commit: 913463587d528d766a8e12c7790995e273ec84fb > [3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P > commit: 3f12bf16213c30d8e645027efd94a19c13ee0253 Please in future skip applied patches instead of including them into the series. No need to resend the series just for this issue though. > > --- > > Soutrik Mukhopadhyay (5): > dt-bindings: phy: Add eDP PHY compatible for sa8775p > phy: qcom: edp: Introduce aux_cfg array for version specific aux > settings > phy: qcom: edp: Add support for eDP PHY on SA8775P > dt-bindings: display: msm: dp-controller: document SA8775P compatible > drm/msm/dp: Add DisplayPort controller for SA8775P > > .../bindings/display/msm/dp-controller.yaml | 1 + > .../devicetree/bindings/phy/qcom,edp-phy.yaml | 1 + > drivers/gpu/drm/msm/dp/dp_display.c | 9 +++ > drivers/phy/qualcomm/phy-qcom-edp.c | 74 +++++++++++++------ > 4 files changed, 61 insertions(+), 24 deletions(-) > > -- > 2.17.1 > -- With best wishes Dmitry
On 18.10.2024 12:08 PM, Dmitry Baryshkov wrote: > On Fri, Oct 18, 2024 at 12:37:01PM +0530, Soutrik Mukhopadhyay wrote: >> This series adds support for the DisplayPort controller >> and eDP PHY v5 found on the Qualcomm SA8775P platform. >> >> --- >> v2: Fixed review comments from Dmitry and Bjorn >> - Made aux_cfg array as const. >> - Reused edp_swing_hbr_rbr and edp_swing_hbr2_hbr3 for v5. >> >> v3: Fixed review comments from Dmitry, Konrad and Bjorn >> - Used a for loop to write the dp_phy_aux_cfg registers. >> - Pre-defined the aux_cfg size to prevent any magic numbers. >> - Added all the necessary DPTX controllers for this platform. >> >> v4: Fixed review comments from Dmitry and Krzysztof >> - Removed the "reviewed by" and kept only the "acked by" for >> patch 1. >> - Updated the commit message of patch 5 to mention specifically >> about the validation of "only" MDSS0 DPTX0 and DPTX1. >> >> v5: Fixed review comment from Dmitry in patch 5 >> - Aligned the register starting address for display port as part >> of device description with respect to other targets. >> >> Below patches are applied: >> >> [1/5] dt-bindings: phy: Add eDP PHY compatible for sa8775p >> commit: 7adb3d221a4d6a4f5e0793c3bd35f1168934035c >> [2/5] phy: qcom: edp: Introduce aux_cfg array for version specific aux settings >> commit: 913463587d528d766a8e12c7790995e273ec84fb >> [3/5] phy: qcom: edp: Add support for eDP PHY on SA8775P >> commit: 3f12bf16213c30d8e645027efd94a19c13ee0253 > > Please in future skip applied patches instead of including them into the > series. No need to resend the series just for this issue though. (you would normally do this by rebasing your tree against -next and having git rebase-skip the ones already present) Konrad
On Fri, 18 Oct 2024 12:37:01 +0530, Soutrik Mukhopadhyay wrote: > This series adds support for the DisplayPort controller > and eDP PHY v5 found on the Qualcomm SA8775P platform. > Applied, thanks! [4/5] dt-bindings: display: msm: dp-controller: document SA8775P compatible https://gitlab.freedesktop.org/lumag/msm/-/commit/c51ff89a8139 [5/5] drm/msm/dp: Add DisplayPort controller for SA8775P https://gitlab.freedesktop.org/lumag/msm/-/commit/dcb380d19e58 Best regards, -- Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
© 2016 - 2024 Red Hat, Inc.