Hi folks,

This series adds support for the drivers for the Exynos 990 SoC. It
consists of the pinctrl driver and the chipid driver. The product ID
of this chip for chipid is 0xe9830000. The pinctrl bank types are the
same as in the Exynos 850 chip.

Changes in v2:
 - Moved bindings from SoC bringup commit
 - Moved device tree changes from SoC bringup commit
 - Ordered pinctrl nodes by unit address in SoC DT
 - Moved the exynos990-wakeup-eint binding to the correct if.
 - Added pinctrl aliases to SoC DT.

Kind regards,
Igor

Igor Belwon (5):
  dt-bindings: pinctrl: samsung: Add exynos990-pinctrl compatible
  dt-bindings: pinctrl: samsung: add exynos990-wakeup-eint compatible
  pinctrl: samsung: Add Exynos 990 SoC pinctrl configuration
  arm64: dts: exynos: Add Exynos 990 pinctrl nodes
  arm64: dts: exynos: Add button support for c1s

 .../samsung,pinctrl-wakeup-interrupt.yaml     |    1 +
 .../bindings/pinctrl/samsung,pinctrl.yaml     |    1 +
 arch/arm64/boot/dts/exynos/exynos990-c1s.dts  |   49 +
 .../boot/dts/exynos/exynos990-pinctrl.dtsi    | 2195 +++++++++++++++++
 arch/arm64/boot/dts/exynos/exynos990.dtsi     |   57 +
 .../pinctrl/samsung/pinctrl-exynos-arm64.c    |  140 ++
 drivers/pinctrl/samsung/pinctrl-samsung.c     |    2 +
 drivers/pinctrl/samsung/pinctrl-samsung.h     |    1 +
 8 files changed, 2446 insertions(+)
 create mode 100644 arch/arm64/boot/dts/exynos/exynos990-pinctrl.dtsi

-- 
2.45.2

On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote:
> Hi folks,
> 
> This series adds support for the drivers for the Exynos 990 SoC. It
> consists of the pinctrl driver and the chipid driver. The product ID
> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
> same as in the Exynos 850 chip.
> 
> Changes in v2:
>  - Moved bindings from SoC bringup commit
>  - Moved device tree changes from SoC bringup commit
>  - Ordered pinctrl nodes by unit address in SoC DT
>  - Moved the exynos990-wakeup-eint binding to the correct if.

Moved? That's not what I asked for. Are you sure you have this warning
free? That's a requirement for Samsung (see maintainer profile).

Best regards,
Krzysztof

On 16/10/2024 09:06, Krzysztof Kozlowski wrote:
> On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote:
>> Hi folks,
>>
>> This series adds support for the drivers for the Exynos 990 SoC. It
>> consists of the pinctrl driver and the chipid driver. The product ID
>> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
>> same as in the Exynos 850 chip.
>>
>> Changes in v2:
>>  - Moved bindings from SoC bringup commit
>>  - Moved device tree changes from SoC bringup commit
>>  - Ordered pinctrl nodes by unit address in SoC DT
>>  - Moved the exynos990-wakeup-eint binding to the correct if.
> 
> Moved? That's not what I asked for. Are you sure you have this warning
> free? That's a requirement for Samsung (see maintainer profile).

Ah, I see now what you did - you removed the interrupt. That's
surprising. I don't understand why.

Best regards,
Krzysztof

On Wed, 16 Oct 2024 09:19:58 +0200, Krzysztof Kozlowski wrote:
> On 16/10/2024 09:06, Krzysztof Kozlowski wrote:
>> On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote:
>>> Hi folks,
>>>
>>> This series adds support for the drivers for the Exynos 990 SoC. It
>>> consists of the pinctrl driver and the chipid driver. The product ID
>>> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
>>> same as in the Exynos 850 chip.
>>>
>>> Changes in v2:
>>>  - Moved bindings from SoC bringup commit
>>>  - Moved device tree changes from SoC bringup commit
>>>  - Ordered pinctrl nodes by unit address in SoC DT
>>>  - Moved the exynos990-wakeup-eint binding to the correct if.
>> 
> Moved? That's not what I asked for. Are you sure you have this warning
> free? That's a requirement for Samsung (see maintainer profile).
>
> Ah, I see now what you did - you removed the interrupt. That's
> surprising. I don't understand why.

Hi Krzysztof,

Thank you for the review.
The interrupt was actually my oversight. This SoCs pin controller does
not mux interrupts (much like E850 and Tensor). It's still compatible
with the Exynos7 model as a fallback though.

Best regards,
Igor

On 16/10/2024 16:41, Igor Belwon wrote:
> On Wed, 16 Oct 2024 09:19:58 +0200, Krzysztof Kozlowski wrote:
>> On 16/10/2024 09:06, Krzysztof Kozlowski wrote:
>>> On Tue, Oct 15, 2024 at 11:04:45PM +0200, Igor Belwon wrote:
>>>> Hi folks,
>>>>
>>>> This series adds support for the drivers for the Exynos 990 SoC. It
>>>> consists of the pinctrl driver and the chipid driver. The product ID
>>>> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
>>>> same as in the Exynos 850 chip.
>>>>
>>>> Changes in v2:
>>>>  - Moved bindings from SoC bringup commit
>>>>  - Moved device tree changes from SoC bringup commit
>>>>  - Ordered pinctrl nodes by unit address in SoC DT
>>>>  - Moved the exynos990-wakeup-eint binding to the correct if.
>>>
>> Moved? That's not what I asked for. Are you sure you have this warning
>> free? That's a requirement for Samsung (see maintainer profile).
>>
>> Ah, I see now what you did - you removed the interrupt. That's
>> surprising. I don't understand why.
> 
> Hi Krzysztof,
> 
> Thank you for the review.
> The interrupt was actually my oversight. This SoCs pin controller does
> not mux interrupts (much like E850 and Tensor). It's still compatible
> with the Exynos7 model as a fallback though.

OK, if this was conscious decision then looks fine. Mention this shortly
in respective commit msg and split the patchset so only pinctrl bits are
here.

Thanks for the work!

Best regards,
Krzysztof

Hi Igor,

thanks for your patches!

On Tue, Oct 15, 2024 at 11:05 PM Igor Belwon
<igor.belwon@mentallysanemainliners.org> wrote:

I love your mail address :D

> This series adds support for the drivers for the Exynos 990 SoC. It
> consists of the pinctrl driver and the chipid driver. The product ID
> of this chip for chipid is 0xe9830000. The pinctrl bank types are the
> same as in the Exynos 850 chip.

It looks OK to me, I expect Krzysztof to handle the pinctrl
series and send it to me by pull request as he keeps track
of all the Exynos pinctrl.

Yours,
Linus Walleij