[PATCH v8 0/9] Add support for sam9x7 SoC family

Varshini Rajendran posted 9 patches 1 month, 2 weeks ago
.../devicetree/bindings/arm/atmel-at91.yaml   |    6 +
.../devicetree/bindings/misc/atmel-ssc.txt    |    1 +
.../power/reset/atmel,sama5d2-shdwc.yaml      |    3 +
.../reset/atmel,at91sam9260-reset.yaml        |    4 +
arch/arm/boot/dts/microchip/Makefile          |    3 +
.../dts/microchip/at91-sam9x75_curiosity.dts  |  324 +++++
arch/arm/boot/dts/microchip/sam9x7.dtsi       | 1220 +++++++++++++++++
drivers/power/reset/Kconfig                   |    4 +-
drivers/power/reset/at91-sama5d2_shdwc.c      |    1 +
9 files changed, 1564 insertions(+), 2 deletions(-)
create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
create mode 100644 arch/arm/boot/dts/microchip/sam9x7.dtsi
[PATCH v8 0/9] Add support for sam9x7 SoC family
Posted by Varshini Rajendran 1 month, 2 weeks ago
This patch series adds support for the new SoC family - sam9x7.
 - The device tree, configs and drivers are added
 - Clock driver for sam9x7 is added
 - Support for basic peripherals is added
 - Target board SAM9X75 Curiosity is added

 Changes in v8:
 --------------

 - Dropped patches that are applied from the series
 - Picked up Reviewed-by tags
 - Changed the node name from leds to led-controller in the board dts
   file.

 Changes in v7:
 --------------

 - Addressed all the review comments in the patches
 - Dropped patches that are applied from the series
 - Removed sfr node from the DT to add it later after creating the right
   DT documentation for microchip sfr IPs.
 - All the specific changes are captured in the corresponding patches

 Changes in v6:
 --------------

 - Addressed all the review comments in the patches
 - Picked up all Acked-by and Reviewed-by tags
 - Reverted the IRQ patch to that of version 3 of the same series
 - All the specific changes are captured in the corresponding patches

 Changes in v5:
 --------------

 - Addressed all the review comments in the patches
 - Picked up all Acked-by and Reviewed-by tags
 - Dropped applied patches from the series
 - Addressed the ABI breakage reported in the IRQ patch
 - All the specific changes are captured in the corresponding patches

 Changes in v4:
 --------------

 - Addressed all the review comments in the patches
 - Picked up all Acked-by and Reviewed-by tags
 - Dropped applied patches from the series
 - Added pwm node and related dt binding documentation
 - Added support for exporting some clocks to DT
 - Dropped USB related patches and changes. See NOTE.
 - All the specific changes are captured in the corresponding patches

 NOTE: Owing to the discussion here
 https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/
 the USB related changes are dropped from this series in order to enable
 us to work on the mentioned issues before adding new compatibles as
 said. The issues/warnings will be addressed in subsequent patches.
 After which the USB related support for sam9x7 SoCs will be added. Hope
 this works out fine.

 Changes in v3:
 --------------

 - Fixed the DT documentation errors pointed out in v2.
 - Dropped Acked-by tag in tcb DT doc patch as it had to be adapted
   according to sam9x7 correctly.
 - Picked by the previously missed tags.
 - Dropped this patch "dt-bindings: usb: generic-ehci: Document clock-names
   property" as the warning was not found while validating DT-schema for
   at91-sam9x75_curiosity.dtb.
 - Dropped redundant words in the commit message.
 - Fixed the CHECK_DTBS warnings validated against
   at91-sam9x75_curiosity.dtb.
 - Renamed dt nodes according to naming convention.
 - Dropped unwanted status property in dts.
 - Removed nodes that are not in use from the board dts.
 - Removed spi DT doc patch from the series as it was already applied
   and a fix patch was applied subsequently. Added a patch to remove the
   compatible to adapt sam9x7.
 - Added sam9x7 compatibles in usb dt documentation.


 Changes in v2:
 --------------

 - Added sam9x7 specific compatibles in DT with fallbacks
 - Documented all the newly added DT compatible strings
 - Added device tree for the target board sam9x75 curiosity and
   documented the same in the DT bindings documentation
 - Removed the dt nodes that are not supported at the moment
 - Removed the configs added by previous version that are not supported
   at the moment
 - Fixed all the corrections in the commit message
 - Changed all the instances of copyright year to 2023
 - Added sam9x7 flag in PIT64B configuration
 - Moved macro definitions to header file
 - Added another divider in mck characteristics in the pmc driver
 - Fixed the memory leak in the pmc driver
 - Dropped patches that are no longer needed
 - Picked up Acked-by and Reviewed-by tags

Varshini Rajendran (9):
  dt-bindings: atmel-ssc: add microchip,sam9x7-ssc
  power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7
  power: reset: at91-reset: add reset support for sam9x7 SoC
  power: reset: at91-reset: add sdhwc support for sam9x7 SoC
  dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7
  dt-bindings: power: reset: atmel,sama5d2-shdwc: add sam9x7
  ARM: dts: at91: sam9x7: add device tree for SoC
  dt-bindings: arm: add sam9x75 curiosity board
  ARM: dts: microchip: sam9x75_curiosity: add sam9x75 curiosity board

 .../devicetree/bindings/arm/atmel-at91.yaml   |    6 +
 .../devicetree/bindings/misc/atmel-ssc.txt    |    1 +
 .../power/reset/atmel,sama5d2-shdwc.yaml      |    3 +
 .../reset/atmel,at91sam9260-reset.yaml        |    4 +
 arch/arm/boot/dts/microchip/Makefile          |    3 +
 .../dts/microchip/at91-sam9x75_curiosity.dts  |  324 +++++
 arch/arm/boot/dts/microchip/sam9x7.dtsi       | 1220 +++++++++++++++++
 drivers/power/reset/Kconfig                   |    4 +-
 drivers/power/reset/at91-sama5d2_shdwc.c      |    1 +
 9 files changed, 1564 insertions(+), 2 deletions(-)
 create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
 create mode 100644 arch/arm/boot/dts/microchip/sam9x7.dtsi

-- 
2.25.1
Re: [PATCH v8 0/9] Add support for sam9x7 SoC family
Posted by Varshini.Rajendran@microchip.com 1 week, 6 days ago
Hi Claudiu, all,

Thanks for merging the Device tree files of the SoC and board.

I would like to know if the rest of the series can be merged. All the 
patches have Ab and/or Rb tags. Let me know if there are any other 
dependencies in order to merge them.

On 10/10/24 5:31 pm, Varshini Rajendran wrote:
> Varshini Rajendran (9):
>    dt-bindings: atmel-ssc: add microchip,sam9x7-ssc
>    power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7
>    power: reset: at91-reset: add reset support for sam9x7 SoC
>    power: reset: at91-reset: add sdhwc support for sam9x7 SoC
>    dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7
>    dt-bindings: power: reset: atmel,sama5d2-shdwc: add sam9x7

-- 
Thanks and Regards,
Varshini Rajendran.

Re: [PATCH v8 0/9] Add support for sam9x7 SoC family
Posted by Varshini.Rajendran@microchip.com 1 month ago
Hi all,


Thanks for your time and efforts for reviewing this series.

As I mentioned already in [1], since all patches have been Acked / 
Reviewed already and the comments from v7 are fixed with trivial 
changes, it would be really helpful if this series can be merged. Not to 
mention there are so many other patches in queue to be sent which depend 
on the same.

[1] 
https://lore.kernel.org/lkml/33e94a83-e08d-4588-87f5-bd51903ee27a@microchip.com/


On 10/10/24 5:31 pm, Varshini Rajendran wrote:
> This patch series adds support for the new SoC family - sam9x7.
>   - The device tree, configs and drivers are added
>   - Clock driver for sam9x7 is added
>   - Support for basic peripherals is added
>   - Target board SAM9X75 Curiosity is added
> 
>   Changes in v8:
>   --------------
> 
>   - Dropped patches that are applied from the series
>   - Picked up Reviewed-by tags
>   - Changed the node name from leds to led-controller in the board dts
>     file.
> 
>   Changes in v7:
>   --------------
> 
>   - Addressed all the review comments in the patches
>   - Dropped patches that are applied from the series
>   - Removed sfr node from the DT to add it later after creating the right
>     DT documentation for microchip sfr IPs.
>   - All the specific changes are captured in the corresponding patches
> 
>   Changes in v6:
>   --------------
> 
>   - Addressed all the review comments in the patches
>   - Picked up all Acked-by and Reviewed-by tags
>   - Reverted the IRQ patch to that of version 3 of the same series
>   - All the specific changes are captured in the corresponding patches
> 
>   Changes in v5:
>   --------------
> 
>   - Addressed all the review comments in the patches
>   - Picked up all Acked-by and Reviewed-by tags
>   - Dropped applied patches from the series
>   - Addressed the ABI breakage reported in the IRQ patch
>   - All the specific changes are captured in the corresponding patches
> 
>   Changes in v4:
>   --------------
> 
>   - Addressed all the review comments in the patches
>   - Picked up all Acked-by and Reviewed-by tags
>   - Dropped applied patches from the series
>   - Added pwm node and related dt binding documentation
>   - Added support for exporting some clocks to DT
>   - Dropped USB related patches and changes. See NOTE.
>   - All the specific changes are captured in the corresponding patches
> 
>   NOTE: Owing to the discussion here
>   https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/
>   the USB related changes are dropped from this series in order to enable
>   us to work on the mentioned issues before adding new compatibles as
>   said. The issues/warnings will be addressed in subsequent patches.
>   After which the USB related support for sam9x7 SoCs will be added. Hope
>   this works out fine.
> 
>   Changes in v3:
>   --------------
> 
>   - Fixed the DT documentation errors pointed out in v2.
>   - Dropped Acked-by tag in tcb DT doc patch as it had to be adapted
>     according to sam9x7 correctly.
>   - Picked by the previously missed tags.
>   - Dropped this patch "dt-bindings: usb: generic-ehci: Document clock-names
>     property" as the warning was not found while validating DT-schema for
>     at91-sam9x75_curiosity.dtb.
>   - Dropped redundant words in the commit message.
>   - Fixed the CHECK_DTBS warnings validated against
>     at91-sam9x75_curiosity.dtb.
>   - Renamed dt nodes according to naming convention.
>   - Dropped unwanted status property in dts.
>   - Removed nodes that are not in use from the board dts.
>   - Removed spi DT doc patch from the series as it was already applied
>     and a fix patch was applied subsequently. Added a patch to remove the
>     compatible to adapt sam9x7.
>   - Added sam9x7 compatibles in usb dt documentation.
> 
> 
>   Changes in v2:
>   --------------
> 
>   - Added sam9x7 specific compatibles in DT with fallbacks
>   - Documented all the newly added DT compatible strings
>   - Added device tree for the target board sam9x75 curiosity and
>     documented the same in the DT bindings documentation
>   - Removed the dt nodes that are not supported at the moment
>   - Removed the configs added by previous version that are not supported
>     at the moment
>   - Fixed all the corrections in the commit message
>   - Changed all the instances of copyright year to 2023
>   - Added sam9x7 flag in PIT64B configuration
>   - Moved macro definitions to header file
>   - Added another divider in mck characteristics in the pmc driver
>   - Fixed the memory leak in the pmc driver
>   - Dropped patches that are no longer needed
>   - Picked up Acked-by and Reviewed-by tags
> 
> Varshini Rajendran (9):
>    dt-bindings: atmel-ssc: add microchip,sam9x7-ssc
>    power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7
>    power: reset: at91-reset: add reset support for sam9x7 SoC
>    power: reset: at91-reset: add sdhwc support for sam9x7 SoC
>    dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7
>    dt-bindings: power: reset: atmel,sama5d2-shdwc: add sam9x7
>    ARM: dts: at91: sam9x7: add device tree for SoC
>    dt-bindings: arm: add sam9x75 curiosity board
>    ARM: dts: microchip: sam9x75_curiosity: add sam9x75 curiosity board
> 
>   .../devicetree/bindings/arm/atmel-at91.yaml   |    6 +
>   .../devicetree/bindings/misc/atmel-ssc.txt    |    1 +
>   .../power/reset/atmel,sama5d2-shdwc.yaml      |    3 +
>   .../reset/atmel,at91sam9260-reset.yaml        |    4 +
>   arch/arm/boot/dts/microchip/Makefile          |    3 +
>   .../dts/microchip/at91-sam9x75_curiosity.dts  |  324 +++++
>   arch/arm/boot/dts/microchip/sam9x7.dtsi       | 1220 +++++++++++++++++
>   drivers/power/reset/Kconfig                   |    4 +-
>   drivers/power/reset/at91-sama5d2_shdwc.c      |    1 +
>   9 files changed, 1564 insertions(+), 2 deletions(-)
>   create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
>   create mode 100644 arch/arm/boot/dts/microchip/sam9x7.dtsi
> 

-- 
Thanks and Regards,
Varshini Rajendran.

Re: [PATCH v8 0/9] Add support for sam9x7 SoC family
Posted by Rob Herring (Arm) 1 month, 2 weeks ago
On Thu, 10 Oct 2024 17:31:42 +0530, Varshini Rajendran wrote:
> This patch series adds support for the new SoC family - sam9x7.
>  - The device tree, configs and drivers are added
>  - Clock driver for sam9x7 is added
>  - Support for basic peripherals is added
>  - Target board SAM9X75 Curiosity is added
> 
>  Changes in v8:
>  --------------
> 
>  - Dropped patches that are applied from the series
>  - Picked up Reviewed-by tags
>  - Changed the node name from leds to led-controller in the board dts
>    file.
> 
>  Changes in v7:
>  --------------
> 
>  - Addressed all the review comments in the patches
>  - Dropped patches that are applied from the series
>  - Removed sfr node from the DT to add it later after creating the right
>    DT documentation for microchip sfr IPs.
>  - All the specific changes are captured in the corresponding patches
> 
>  Changes in v6:
>  --------------
> 
>  - Addressed all the review comments in the patches
>  - Picked up all Acked-by and Reviewed-by tags
>  - Reverted the IRQ patch to that of version 3 of the same series
>  - All the specific changes are captured in the corresponding patches
> 
>  Changes in v5:
>  --------------
> 
>  - Addressed all the review comments in the patches
>  - Picked up all Acked-by and Reviewed-by tags
>  - Dropped applied patches from the series
>  - Addressed the ABI breakage reported in the IRQ patch
>  - All the specific changes are captured in the corresponding patches
> 
>  Changes in v4:
>  --------------
> 
>  - Addressed all the review comments in the patches
>  - Picked up all Acked-by and Reviewed-by tags
>  - Dropped applied patches from the series
>  - Added pwm node and related dt binding documentation
>  - Added support for exporting some clocks to DT
>  - Dropped USB related patches and changes. See NOTE.
>  - All the specific changes are captured in the corresponding patches
> 
>  NOTE: Owing to the discussion here
>  https://lore.kernel.org/linux-devicetree/CAL_JsqJ9PrX6fj-EbffeJce09MXs=B7t+KS_kOinxaRx38=WxA@mail.gmail.com/
>  the USB related changes are dropped from this series in order to enable
>  us to work on the mentioned issues before adding new compatibles as
>  said. The issues/warnings will be addressed in subsequent patches.
>  After which the USB related support for sam9x7 SoCs will be added. Hope
>  this works out fine.
> 
>  Changes in v3:
>  --------------
> 
>  - Fixed the DT documentation errors pointed out in v2.
>  - Dropped Acked-by tag in tcb DT doc patch as it had to be adapted
>    according to sam9x7 correctly.
>  - Picked by the previously missed tags.
>  - Dropped this patch "dt-bindings: usb: generic-ehci: Document clock-names
>    property" as the warning was not found while validating DT-schema for
>    at91-sam9x75_curiosity.dtb.
>  - Dropped redundant words in the commit message.
>  - Fixed the CHECK_DTBS warnings validated against
>    at91-sam9x75_curiosity.dtb.
>  - Renamed dt nodes according to naming convention.
>  - Dropped unwanted status property in dts.
>  - Removed nodes that are not in use from the board dts.
>  - Removed spi DT doc patch from the series as it was already applied
>    and a fix patch was applied subsequently. Added a patch to remove the
>    compatible to adapt sam9x7.
>  - Added sam9x7 compatibles in usb dt documentation.
> 
> 
>  Changes in v2:
>  --------------
> 
>  - Added sam9x7 specific compatibles in DT with fallbacks
>  - Documented all the newly added DT compatible strings
>  - Added device tree for the target board sam9x75 curiosity and
>    documented the same in the DT bindings documentation
>  - Removed the dt nodes that are not supported at the moment
>  - Removed the configs added by previous version that are not supported
>    at the moment
>  - Fixed all the corrections in the commit message
>  - Changed all the instances of copyright year to 2023
>  - Added sam9x7 flag in PIT64B configuration
>  - Moved macro definitions to header file
>  - Added another divider in mck characteristics in the pmc driver
>  - Fixed the memory leak in the pmc driver
>  - Dropped patches that are no longer needed
>  - Picked up Acked-by and Reviewed-by tags
> 
> Varshini Rajendran (9):
>   dt-bindings: atmel-ssc: add microchip,sam9x7-ssc
>   power: reset: at91-poweroff: lookup for proper pmc dt node for sam9x7
>   power: reset: at91-reset: add reset support for sam9x7 SoC
>   power: reset: at91-reset: add sdhwc support for sam9x7 SoC
>   dt-bindings: reset: atmel,at91sam9260-reset: add sam9x7
>   dt-bindings: power: reset: atmel,sama5d2-shdwc: add sam9x7
>   ARM: dts: at91: sam9x7: add device tree for SoC
>   dt-bindings: arm: add sam9x75 curiosity board
>   ARM: dts: microchip: sam9x75_curiosity: add sam9x75 curiosity board
> 
>  .../devicetree/bindings/arm/atmel-at91.yaml   |    6 +
>  .../devicetree/bindings/misc/atmel-ssc.txt    |    1 +
>  .../power/reset/atmel,sama5d2-shdwc.yaml      |    3 +
>  .../reset/atmel,at91sam9260-reset.yaml        |    4 +
>  arch/arm/boot/dts/microchip/Makefile          |    3 +
>  .../dts/microchip/at91-sam9x75_curiosity.dts  |  324 +++++
>  arch/arm/boot/dts/microchip/sam9x7.dtsi       | 1220 +++++++++++++++++
>  drivers/power/reset/Kconfig                   |    4 +-
>  drivers/power/reset/at91-sama5d2_shdwc.c      |    1 +
>  9 files changed, 1564 insertions(+), 2 deletions(-)
>  create mode 100644 arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dts
>  create mode 100644 arch/arm/boot/dts/microchip/sam9x7.dtsi
> 
> --
> 2.25.1
> 
> 
> 


My bot found new DTB warnings on the .dts files added or changed in this
series.

Some warnings may be from an existing SoC .dtsi. Or perhaps the warnings
are fixed by another series. Ultimately, it is up to the platform
maintainer whether these warnings are acceptable or not. No need to reply
unless the platform maintainer has comments.

If you already ran DT checks and didn't see these error(s), then
make sure dt-schema is up to date:

  pip3 install dtschema --upgrade


New warnings running 'make CHECK_DTBS=y microchip/at91-sam9x75_curiosity.dtb' for 20241010120142.92057-1-varshini.rajendran@microchip.com:

arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/dma-controller@f0008000: failed to match any schema with compatible: ['microchip,sam9x7-dma', 'atmel,sama5d4-dma']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/dma-controller@f0008000: failed to match any schema with compatible: ['microchip,sam9x7-dma', 'atmel,sama5d4-dma']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/ssc@f0010000: failed to match any schema with compatible: ['microchip,sam9x7-ssc', 'atmel,at91sam9g45-ssc']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/ssc@f0010000: failed to match any schema with compatible: ['microchip,sam9x7-ssc', 'atmel,at91sam9g45-ssc']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/timer@f0028000: failed to match any schema with compatible: ['microchip,sam9x7-pit64b', 'microchip,sam9x60-pit64b']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/timer@f0028000: failed to match any schema with compatible: ['microchip,sam9x7-pit64b', 'microchip,sam9x60-pit64b']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/timer@f0040000: failed to match any schema with compatible: ['microchip,sam9x7-pit64b', 'microchip,sam9x60-pit64b']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/timer@f0040000: failed to match any schema with compatible: ['microchip,sam9x7-pit64b', 'microchip,sam9x60-pit64b']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/matrix@ffffde00: failed to match any schema with compatible: ['microchip,sam9x7-matrix', 'atmel,at91sam9x5-matrix', 'syscon']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/matrix@ffffde00: failed to match any schema with compatible: ['microchip,sam9x7-matrix', 'atmel,at91sam9x5-matrix', 'syscon']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/ecc-engine@ffffe000: failed to match any schema with compatible: ['microchip,sam9x7-pmecc', 'atmel,at91sam9g45-pmecc']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/ecc-engine@ffffe000: failed to match any schema with compatible: ['microchip,sam9x7-pmecc', 'atmel,at91sam9g45-pmecc']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/mpddrc@ffffe800: failed to match any schema with compatible: ['microchip,sam9x7-ddramc', 'atmel,sama5d3-ddramc']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/mpddrc@ffffe800: failed to match any schema with compatible: ['microchip,sam9x7-ddramc', 'atmel,sama5d3-ddramc']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/smc@ffffea00: failed to match any schema with compatible: ['microchip,sam9x7-smc', 'atmel,at91sam9260-smc', 'syscon']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/smc@ffffea00: failed to match any schema with compatible: ['microchip,sam9x7-smc', 'atmel,at91sam9260-smc', 'syscon']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/syscon@fffffe60: failed to match any schema with compatible: ['microchip,sam9x7-gpbr', 'atmel,at91sam9260-gpbr', 'syscon']
arch/arm/boot/dts/microchip/at91-sam9x75_curiosity.dtb: /apb/syscon@fffffe60: failed to match any schema with compatible: ['microchip,sam9x7-gpbr', 'atmel,at91sam9260-gpbr', 'syscon']