[v3] clk: qcom: gcc-sm8550: Fix shared clk parking breakage

[PATCH v3 0/2] clk: qcom: gcc-sm8550: Fix shared clk parking breakage

Stephen Boyd posted 2 patches 1 year, 3 months ago

Diff against v1 v2
Download series mbox

drivers/clk/qcom/clk-rcg.h       |  1 +
drivers/clk/qcom/clk-rcg2.c      | 36 ++++++++++++++++++++--
drivers/clk/qcom/dispcc-sc7180.c |  8 ++---
drivers/clk/qcom/gcc-sm8550.c    | 52 ++++++++++++++++----------------
4 files changed, 64 insertions(+), 33 deletions(-)

Expand all Fold all

[PATCH v3 0/2] clk: qcom: gcc-sm8550: Fix shared clk parking breakage

Posted by Stephen Boyd 1 year, 3 months ago

Amit Pundir reported[1] that a recent commit 01a0a6cc8cfd ("clk: qcom:
Park shared RCGs upon registration") broke USB and audio on sm8550-hdk.
These two patches fix the issue by skipping the parking bit of the
shared RCGs for all clks except for the ones that were causing trouble,
i.e. the display RCGs on sc7180.

The first patch is all that's required, while the second patch can be
applied anytime to simplify the QUP clks that don't need to be parked.

Changes from v2: https://lore.kernel.org/r/20240827231237.1014813-1-swboyd@chromium.org
 * Reword first patch commit text to clarify further

Changes from v1: https://lore.kernel.org/r/20240819233628.2074654-1-swboyd@chromium.org
 * Revert most of the bad patch, except for the sc7180 display clks that still
   want to park at init
 * Re-order series

[1] https://lore.kernel.org/CAMi1Hd1KQBE4kKUdAn8E5FV+BiKzuv+8FoyWQrrTHPDoYTuhgA@mail.gmail.com/

Stephen Boyd (2):
  clk: qcom: dispcc-sc7180: Only park display clks at init
  clk: qcom: gcc-sm8550: Don't use shared clk_ops for QUPs

 drivers/clk/qcom/clk-rcg.h       |  1 +
 drivers/clk/qcom/clk-rcg2.c      | 36 ++++++++++++++++++++--
 drivers/clk/qcom/dispcc-sc7180.c |  8 ++---
 drivers/clk/qcom/gcc-sm8550.c    | 52 ++++++++++++++++----------------
 4 files changed, 64 insertions(+), 33 deletions(-)


base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
-- 
https://chromeos.dev