x86/ioapic: Robustness fix and cleanup

[patch 00/15] x86/ioapic: Robustness fix and cleanup

Posted by Thomas Gleixner 1 year, 4 months ago

Breno reported a panic during testing with failslab in the IO-APIC
code. This is a historical leftover and can be handled gracefully.

While looking at that I stumbled over quite some historical leftovers of
debug printks, overly big comments for trivialities and a pile of coding
style violations.

So after fixing the failslab problem I just went through and modernized the
(IO)APIC code.

The series is also available from git:

    git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/apic

Thanks,

	tglx
---
 arch/x86/include/asm/apic.h         |   33 -
 arch/x86/kernel/apic/apic.c         |   81 +--
 arch/x86/kernel/apic/io_apic.c      |  749 ++++++++++++++----------------------
 arch/x86/kernel/mpparse.c           |   12 
 drivers/iommu/intel/irq_remapping.c |   11 
 5 files changed, 369 insertions(+), 517 deletions(-)

Re: [patch 00/15] x86/ioapic: Robustness fix and cleanup

Posted by Breno Leitao 1 year, 4 months ago

On Fri, Aug 02, 2024 at 06:15:33PM +0200, Thomas Gleixner wrote:
> Breno reported a panic during testing with failslab in the IO-APIC
> code. This is a historical leftover and can be handled gracefully.
> 
> While looking at that I stumbled over quite some historical leftovers of
> debug printks, overly big comments for trivialities and a pile of coding
> style violations.
> 
> So after fixing the failslab problem I just went through and modernized the
> (IO)APIC code.
> 
> The series is also available from git:
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/apic

I've tested these patches on top of linux-next tree (3608d6aca5e7 (" 
Merge branch 'dsa-en7581' into main")) and I do see panics anymore.

Tested-by: Breno Leitao <leitao@debian.org>

Re: [patch 00/15] x86/ioapic: Robustness fix and cleanup

Posted by Qiuxu Zhuo 1 year, 4 months ago

Hi Thomas,

> From: Thomas Gleixner <tglx@linutronix.de>
> To: LKML <linux-kernel@vger.kernel.org>
> Cc: x86@kernel.org, Breno Leitao <leitao@debian.org>
> Subject: [patch 00/15] x86/ioapic: Robustness fix and cleanup
> 
> Breno reported a panic during testing with failslab in the IO-APIC
> code. This is a historical leftover and can be handled gracefully.
> 
> While looking at that I stumbled over quite some historical leftovers of
> debug printks, overly big comments for trivialities and a pile of coding
> style violations.
> 
> So after fixing the failslab problem I just went through and modernized the
> (IO)APIC code.
> 
> The series is also available from git:
> 
>     git://git.kernel.org/pub/scm/linux/kernel/git/tglx/devel.git x86/apic
> 

Tested this branch on an Intel Sandy Bridge server and an Ice Lake server.
Both servers booted okay and worked well. No regressions were found.
If the testing is sufficient, feel free to add:

   Tested-by: Qiuxu Zhuo <qiuxu.zhuo@intel.com>

Thanks!
-Qiuxu