[PATCH V2] irqchip/gic-v4.1: Replace GIC version with ID_AA64PFR0_EL1_GIC_V4P1

Anshuman Khandual posted 1 patch 1 year, 6 months ago
drivers/irqchip/irq-gic-v4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
[PATCH V2] irqchip/gic-v4.1: Replace GIC version with ID_AA64PFR0_EL1_GIC_V4P1
Posted by Anshuman Khandual 1 year, 6 months ago
Replace open encoding for GIC version code with ID_AA64PFR0_EL1_GIC_V4P1 in
gic_cpuif_has_vsgi().

Cc: Marc Zyngier <maz@kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Catalin Marinas <catalin.marinas@arm.com>
Cc: Will Deacon <will@kernel.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
---
This patch applies on v6.11-rc1.

ID_AA64PFR0_EL1.GIC field value for V4P1 has been fixed via a recent
commit f3dfcd25455b ("arm64/sysreg: Correct the values for GICv4.1").

Changes in V2:

- Updated the subject line per Marc

Changes in V1:

https://lore.kernel.org/all/20240724054623.667595-1-anshuman.khandual@arm.com/

 drivers/irqchip/irq-gic-v4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v4.c b/drivers/irqchip/irq-gic-v4.c
index ca32ac19d284..58c28895f8c4 100644
--- a/drivers/irqchip/irq-gic-v4.c
+++ b/drivers/irqchip/irq-gic-v4.c
@@ -97,7 +97,7 @@ bool gic_cpuif_has_vsgi(void)
 
 	fld = cpuid_feature_extract_unsigned_field(reg, ID_AA64PFR0_EL1_GIC_SHIFT);
 
-	return fld >= 0x3;
+	return fld >= ID_AA64PFR0_EL1_GIC_V4P1;
 }
 #else
 bool gic_cpuif_has_vsgi(void)
-- 
2.30.2
[tip: irq/core] irqchip/gic-v4.1: Replace bare number with ID_AA64PFR0_EL1_GIC_V4P1
Posted by tip-bot2 for Anshuman Khandual 1 year, 6 months ago
The following commit has been merged into the irq/core branch of tip:

Commit-ID:     bb4531976523c6e394188c4f4a7eeaf5e9efdd48
Gitweb:        https://git.kernel.org/tip/bb4531976523c6e394188c4f4a7eeaf5e9efdd48
Author:        Anshuman Khandual <anshuman.khandual@arm.com>
AuthorDate:    Fri, 02 Aug 2024 14:26:01 +05:30
Committer:     Thomas Gleixner <tglx@linutronix.de>
CommitterDate: Fri, 02 Aug 2024 14:54:25 +02:00

irqchip/gic-v4.1: Replace bare number with ID_AA64PFR0_EL1_GIC_V4P1

Use ID_AA64PFR0_EL1_GIC_V4P1 instead of '3' in gic_cpuif_has_vsgi() to
check for the GIC version.

Signed-off-by: Anshuman Khandual <anshuman.khandual@arm.com>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Reviewed-by: Zenghui Yu <yuzenghui@huawei.com>
Acked-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/all/20240802085601.1824057-1-anshuman.khandual@arm.com
---
 drivers/irqchip/irq-gic-v4.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/irqchip/irq-gic-v4.c b/drivers/irqchip/irq-gic-v4.c
index ca32ac1..58c2889 100644
--- a/drivers/irqchip/irq-gic-v4.c
+++ b/drivers/irqchip/irq-gic-v4.c
@@ -97,7 +97,7 @@ bool gic_cpuif_has_vsgi(void)
 
 	fld = cpuid_feature_extract_unsigned_field(reg, ID_AA64PFR0_EL1_GIC_SHIFT);
 
-	return fld >= 0x3;
+	return fld >= ID_AA64PFR0_EL1_GIC_V4P1;
 }
 #else
 bool gic_cpuif_has_vsgi(void)