Hi,

This series fixes a long-standing issue in the gs101 clocking / uart
handling.

We can now disable clocks that had previously been marked critical, and
still get a working earlycon.

There is a preparatory patch, and then a patch to drop an incorrect clock
counting work-around. That 2nd patch is essentially the last remaining patch
[1] with all review comments addressed, from the series [2] that was sent
earlier this year, see lore links below.

Patch 2 can not come before or without patch 1.

Signed-off-by: André Draszik <andre.draszik@linaro.org>

[1] https://lore.kernel.org/all/20240130093812.1746512-6-andre.draszik@linaro.org/
[2] https://lore.kernel.org/all/20240130093812.1746512-1-andre.draszik@linaro.org/
[3] https://lore.kernel.org/all/d45de3b2bb6b48653842cf1f74e58889ed6783ae.camel@linaro.org/

Changes in v4:
- new patch "clk: samsung: gs101: allow earlycon to work unconditionally"
- update commit message for patch 2
- Link to v3: https://lore.kernel.org/r/20240710-gs101-non-essential-clocks-2-v3-0-5dcb8d040d1c@linaro.org

---
André Draszik (2):
      clk: samsung: gs101: allow earlycon to work unconditionally
      clk: samsung: gs101: don't mark non-essential (UART) clocks critical

 drivers/clk/samsung/clk-gs101.c | 106 ++++++++++++++++++++++++++++++++++++++--
 1 file changed, 102 insertions(+), 4 deletions(-)
---
base-commit: 523b23f0bee3014a7a752c9bb9f5c54f0eddae88
change-id: 20240430-gs101-non-essential-clocks-2-6a3280fa1be8

Best regards,
-- 
André Draszik <andre.draszik@linaro.org>

Quoting André Draszik (2024-07-12 10:09:42)
> Hi,
> 
> This series fixes a long-standing issue in the gs101 clocking / uart
> handling.
> 
> We can now disable clocks that had previously been marked critical, and
> still get a working earlycon.
> 
> There is a preparatory patch, and then a patch to drop an incorrect clock
> counting work-around. That 2nd patch is essentially the last remaining patch
> [1] with all review comments addressed, from the series [2] that was sent
> earlier this year, see lore links below.

Is there a binding update for the chosen node to have a clocks property?

Hi Stephen,

On Thu, 2024-07-18 at 13:55 -0700, Stephen Boyd wrote:
> Quoting André Draszik (2024-07-12 10:09:42)
> > Hi,
> > 
> > This series fixes a long-standing issue in the gs101 clocking / uart
> > handling.
> > 
> > We can now disable clocks that had previously been marked critical, and
> > still get a working earlycon.
> > 
> > There is a preparatory patch, and then a patch to drop an incorrect clock
> > counting work-around. That 2nd patch is essentially the last remaining patch
> > [1] with all review comments addressed, from the series [2] that was sent
> > earlier this year, see lore links below.
> 
> Is there a binding update for the chosen node to have a clocks property?

I didn't think that was necessary (and no, I don't have a binding update at
the moment). It gets the clock associated with the serial port (of_stdout),
if any, and works off that.

Did I miss something?

Cheers,
Andre

Quoting André Draszik (2024-07-25 00:12:48)
> 
> I didn't think that was necessary (and no, I don't have a binding update at
> the moment). It gets the clock associated with the serial port (of_stdout),
> if any, and works off that.
> 
> Did I miss something?

No, I missed it. I was thinking it was the chosen node but it's actually
the serial node.