[PATCH 0/2] fix handling of incorrect arguments by mipi_dsi_msleep

Tejas Vipin posted 2 patches 1 year, 8 months ago
drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +++---
include/drm/drm_mipi_dsi.h                  | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
[PATCH 0/2] fix handling of incorrect arguments by mipi_dsi_msleep
Posted by Tejas Vipin 1 year, 8 months ago
mipi_dsi_msleep is currently defined such that it treats ctx as an
argument passed by value. In the case of ctx being passed by
reference, it doesn't raise an error, but instead evaluates the
resulting expression in an undesired manner. Since the majority of the
usage of this function passes ctx by reference (similar to
other functions), mipi_dsi_msleep can be modified to treat ctx as a
pointer and do it correctly, and the other calls to this macro can be
adjusted accordingly.

Tejas Vipin (2):
  drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep
  drm/mipi-dsi: fix handling of ctx in mipi_dsi_msleep

 drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +++---
 include/drm/drm_mipi_dsi.h                  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

-- 
2.45.2
Re: [PATCH 0/2] fix handling of incorrect arguments by mipi_dsi_msleep
Posted by Neil Armstrong 1 year, 8 months ago
Hi,

On Wed, 12 Jun 2024 19:05:41 +0530, Tejas Vipin wrote:
> mipi_dsi_msleep is currently defined such that it treats ctx as an
> argument passed by value. In the case of ctx being passed by
> reference, it doesn't raise an error, but instead evaluates the
> resulting expression in an undesired manner. Since the majority of the
> usage of this function passes ctx by reference (similar to
> other functions), mipi_dsi_msleep can be modified to treat ctx as a
> pointer and do it correctly, and the other calls to this macro can be
> adjusted accordingly.
> 
> [...]

Thanks, Applied to https://gitlab.freedesktop.org/drm/misc/kernel.git (drm-misc-next)

[1/2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/a13aaf157467e694a3824d81304106b58d4c20d6
[2/2] drm/mipi-dsi: fix handling of ctx in mipi_dsi_msleep
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/66055636a146c435cd226fb5a334176304652f3c

-- 
Neil