From nobody Thu Feb 12 12:34:57 2026 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13D9416F0D0 for ; Wed, 12 Jun 2024 13:37:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.174 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718199428; cv=none; b=CwlFHRmSmKxVxsJ/Cq8IxfmKYTMPLnYJGTN7R85ILHfpEeC/v6D2CJuPq2vx7oieD4TG+NY4z3NqLfsa+UgysSLKl2YCK79704D7GnRxuh7NgmkDnPg7t8VVHN9P7Qq3A4ArrECHlRAg/Pkshc4J+JAr69LZsX6v0QmxojS1LJ4= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718199428; c=relaxed/simple; bh=GFsMcBMoylWGTX0MPT2kFGiqHvgCA2BZtYfK1BgDqqM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=u8/Ung2VDZFli9dITgrvKsf+uOgGvmwRl3FUEme+0oBM+4rKXNU+jrh6iUhj69kN+yH4i+H0gENp5vHTb/mEPqYcIVl2SYIidVO3NHW7y6eODWivi1mtwIKlrOR+q6ISEhvip93itEQXEc8SIf9YGY0dRG2gc2fg6r1J7Y3GUN0= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bSwoOzXB; arc=none smtp.client-ip=209.85.215.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bSwoOzXB" Received: by mail-pg1-f174.google.com with SMTP id 41be03b00d2f7-6e57506bb2dso1815189a12.0 for ; Wed, 12 Jun 2024 06:37:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718199426; x=1718804226; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=oWKGCz3EWFmYzxcw2AH10wBEqhDAZAXMwRxOW8+/rNE=; b=bSwoOzXBmfJVXSQk7E19kUl/gcbPNxR6x5J7y/Gg/xdPqTMv970vE2F6GiIruaIBAd koASniU0AGtIV7Mz0rD8dxqqRNtcm0wqOwSk7NTxcZ4QHROX5mLjoptAZEwP4MCv3CMi 48YwmME1MMaEwXjyG8fhLq7+iB1ZMUHtswgME2gX2ZOmMoYKGQhhNoG6riAFHpRnmS2C 9XgcvHgoeE11Sdq5VjExoZhW1LwHwv+3utLZrgWoZ/gGshlIhSBJyp8eQ1SOEz0zMhqn UNF3pyBKlgoFAi++YDR4eva6JHV1UuGOUQ0p1Ze9XfQfN6+iBMVhAZKopSumw1gR4RUg LWFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718199426; x=1718804226; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=oWKGCz3EWFmYzxcw2AH10wBEqhDAZAXMwRxOW8+/rNE=; b=hKp+Q8RNhzWOCjglKl5nGBCjHHgpech+ULjoH6NCqC/iK03hAxaT0Gz44ybgUOfyAI 5LojpdAg+8NKoVf6dTX4S6uOiKqpSdioDJnsckvkGOFj3QdyAdoSTHHunZHY7tivKp/8 PC7pCPPtnlsY8QuHZySzNpM3UcEgRr++Wopx+aAsQiZyoJyr+de/geHbT/1rM5ZV6AjH CRw5ZA6kLUrIr/GuxUnJHmdpcLDKaRp52wdocal627ko3+Dvu5uDBI0K8VZxJOPJh2VT 6L94EZw/STPBy2Tg/hUIsdOEJMiEg3igy5YZNj4sqqZblroUrUZs+xO2DJ5m1VRtDGA+ w7OQ== X-Forwarded-Encrypted: i=1; AJvYcCVOvfjyF2Xm94nEn3JCCjj2BqW3gE1ZJelOOsEuiezMbEGAJQFwejlhqS6cBtXuNaQfVpbuDRsgCBmmL05tLuINJ0uxeWU6nsZpjOSc X-Gm-Message-State: AOJu0YwYwPJiqnAD4ajcIGTiQo6PzcCjAuR1XB4jE+sMtEjNa5iBC6DV dnVMEeAI5DDCDj8RKyj82clfOMiP4Uy+QvEw8010VQhLJPb835aL X-Google-Smtp-Source: AGHT+IGk2WNb7MVw3PvR+Dd5n5F6ztFXUCd2N90utcqQ6HM1yzqO4d0rKoJRZPGLEL6Elpt27tujyQ== X-Received: by 2002:a17:902:d4d0:b0:1f7:e32f:f057 with SMTP id d9443c01a7336-1f83b5f7b15mr20751715ad.34.1718199426278; Wed, 12 Jun 2024 06:37:06 -0700 (PDT) Received: from distilledx.localdomain ([103.246.195.195]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f845e0ca86sm7291815ad.0.2024.06.12.06.37.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 06:37:06 -0700 (PDT) From: Tejas Vipin To: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com Cc: Tejas Vipin , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, linus.walleij@linaro.org, dmitry.baryshkov@linaro.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 1/2] drm/panel : himax-hx83102: fix incorrect argument to mipi_dsi_msleep Date: Wed, 12 Jun 2024 19:05:42 +0530 Message-ID: <20240612133550.473279-2-tejasvipin76@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240612133550.473279-1-tejasvipin76@gmail.com> References: <20240612133550.473279-1-tejasvipin76@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" mipi_dsi_msleep should be modified to accept ctx as a pointer and the function call should be adjusted accordingly. Fixes: a2ab7cb169da3 ("drm/panel: himax-hx83102: use wrapped MIPI DCS funct= ions")=20 Signed-off-by: Tejas Vipin Reviewed-by: Douglas Anderson --- drivers/gpu/drm/panel/panel-himax-hx83102.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/panel/panel-himax-hx83102.c b/drivers/gpu/drm/= panel/panel-himax-hx83102.c index 6009a3fe1b8f..6e4b7e4644ce 100644 --- a/drivers/gpu/drm/panel/panel-himax-hx83102.c +++ b/drivers/gpu/drm/panel/panel-himax-hx83102.c @@ -286,7 +286,7 @@ static int boe_nv110wum_init(struct hx83102 *ctx) mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83102_SETBANK, 0x00); hx83102_enable_extended_cmds(&dsi_ctx, false); =20 - mipi_dsi_msleep(dsi_ctx, 50); + mipi_dsi_msleep(&dsi_ctx, 50); =20 return dsi_ctx.accum_err; }; @@ -391,7 +391,7 @@ static int ivo_t109nw41_init(struct hx83102 *ctx) mipi_dsi_dcs_write_seq_multi(&dsi_ctx, HX83102_SETBANK, 0x00); hx83102_enable_extended_cmds(&dsi_ctx, false); =20 - mipi_dsi_msleep(dsi_ctx, 60); + mipi_dsi_msleep(&dsi_ctx, 60); =20 return dsi_ctx.accum_err; }; @@ -538,7 +538,7 @@ static int hx83102_prepare(struct drm_panel *panel) dsi_ctx.accum_err =3D ctx->desc->init(ctx); =20 mipi_dsi_dcs_exit_sleep_mode_multi(&dsi_ctx); - mipi_dsi_msleep(dsi_ctx, 120); + mipi_dsi_msleep(&dsi_ctx, 120); mipi_dsi_dcs_set_display_on_multi(&dsi_ctx); if (dsi_ctx.accum_err) goto poweroff; --=20 2.45.2 From nobody Thu Feb 12 12:34:57 2026 Received: from mail-pl1-f173.google.com (mail-pl1-f173.google.com [209.85.214.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3AB3917C9F6 for ; Wed, 12 Jun 2024 13:37:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718199432; cv=none; b=TmAyKeHQsHZ7KAz1atev/+Wwn64ecaRBDZUluBpigXrj0IlHiGxuBlS/zKCSkPdObQyHqqbe6fzq7ZZJ42D8hSg6kh2OBF+4GJYBRa18whAW7PV33S1zdSx5MsLAeKhwD6wC2JVISSMjGBSb+22UQioytBAO8dKcIUKinqU3Ark= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718199432; c=relaxed/simple; bh=ZBa7BSruQYc69oMtdtEp/dyK2qiYEo1o7+5F9JmxO6E=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Q27QmkwnNHJ921On6J/JMcCxZ0QWSDTJnRUwySAPdEx8yifOWamJTQtp3k3tocZ4g3axdWZ9UVHaphCu4ntuYBsegVkpHe/NMUrEZmG24EIbKL03tjhhuHH+b32FjjCq4KU/PLDZtwy695FlP+LVVby1deF4bVHVQYLJim+tdfc= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=LP6MbhX7; arc=none smtp.client-ip=209.85.214.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="LP6MbhX7" Received: by mail-pl1-f173.google.com with SMTP id d9443c01a7336-1f32a3b9491so51074925ad.0 for ; Wed, 12 Jun 2024 06:37:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1718199430; x=1718804230; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=v/n0skyDCqk0A4g17wGPYh0p/6wetdSwsLx+Vq4wTy8=; b=LP6MbhX7OkwxtXvR0HdFkgSu9YkndIFhgRhqk9L7uK2avB02OQXG9k93OBgTPVFaEN JbkG4PaPnGO8dYDuuIDcaDm4maZES7cQT6BYeDzaiVE17TGyOFxzwKtmLBNXTUGxUCtk uvq/3h+wO7OBdniAZTqvAsSMPIl+7KHPlUdwUUyj5SGmAHwBiM0q/Y3dNvHaxYET7J97 8Y63eFPJjgEYxD//IZoWGH2tGI+BgrVgptsDqQZewlkVoZr3MTWQK+rhrjsNwkhHusgZ qSLIYzF+w/k7OhqNR3juj6KvA0ILb+OQhcK16gQ6nQApH/i7NkjSAwyj9kuUJp2RWB7a +YCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718199430; x=1718804230; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=v/n0skyDCqk0A4g17wGPYh0p/6wetdSwsLx+Vq4wTy8=; b=VPtKL0xxDWbHGVH3mklIzONQGH5wTAxHf0cJ383JGCCJ+WnGIDvE+UVUB/JPt0B3tH iW/8tVhRfqHJ+FhGaZl2eXbhDiLUm0kb9AhTonE4IAqAOPiOyg1mOrCA8eZ006Tq13XQ FVtCkJuvIyZ4ufRpDW9ESg7W0vzrmSPKf/oXdlPjr68mGTjc1qepuPxfJ4+JcdphlxSe ROy5rC4vcMHUPyI604yveNF8LyeMhXYFBcm6wtt1mokxtpo9TuMyHCa2loubrKPg7i6f zLNpdCQIiQatmvNbQPJETpC9YIpkXKhHVq9bw+QBPpAuMvg9T9P8aLBX09UJ9z6o/3IS QoJQ== X-Forwarded-Encrypted: i=1; AJvYcCUIiNC6vcBGlWvIDYachU828fYBIxHI1cOpLckHkRhFUmBaq8CgHaOwsm31n9w+FDz5UpZTRWwb0d8EKOlL9CSc493ZOOzJFqwRuAAn X-Gm-Message-State: AOJu0YzQ34luYuzdo08XKv3oC9ZvMq1mty7CdsSOZ+dKE470QMYyqzPI eemDPFx/WhS9zcL9X1YxvXIYMzSUfOGr3zC3n75nddWgIFYwOp67 X-Google-Smtp-Source: AGHT+IGcY5lrA68E4+hHXL1ibBHgiWf7Aag49KQay59rhRT3xV22h/I+PhvUY5tYGnv77TorH4ctkA== X-Received: by 2002:a17:902:dacb:b0:1f8:4932:2f05 with SMTP id d9443c01a7336-1f849323126mr6170465ad.64.1718199430429; Wed, 12 Jun 2024 06:37:10 -0700 (PDT) Received: from distilledx.localdomain ([103.246.195.195]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-1f845e0ca86sm7291815ad.0.2024.06.12.06.37.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jun 2024 06:37:10 -0700 (PDT) From: Tejas Vipin To: neil.armstrong@linaro.org, quic_jesszhan@quicinc.com Cc: Tejas Vipin , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, daniel@ffwll.ch, linus.walleij@linaro.org, dmitry.baryshkov@linaro.org, dianders@chromium.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] drm/mipi-dsi: fix handling of ctx in mipi_dsi_msleep Date: Wed, 12 Jun 2024 19:05:43 +0530 Message-ID: <20240612133550.473279-3-tejasvipin76@gmail.com> X-Mailer: git-send-email 2.45.2 In-Reply-To: <20240612133550.473279-1-tejasvipin76@gmail.com> References: <20240612133550.473279-1-tejasvipin76@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" ctx would be better off treated as a pointer to account for most of its usage so far, and brackets should be added to account for operator=20 precedence for correct evaluation. Fixes: f79d6d28d8fe7 ("drm/mipi-dsi: wrap more functions for streamline han= dling")=20 Signed-off-by: Tejas Vipin Reviewed-by: Douglas Anderson Suggested-by: Douglas Anderson --- include/drm/drm_mipi_dsi.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/drm/drm_mipi_dsi.h b/include/drm/drm_mipi_dsi.h index bd5a0b6d0711..71d121aeef24 100644 --- a/include/drm/drm_mipi_dsi.h +++ b/include/drm/drm_mipi_dsi.h @@ -293,7 +293,7 @@ ssize_t mipi_dsi_generic_read(struct mipi_dsi_device *d= si, const void *params, =20 #define mipi_dsi_msleep(ctx, delay) \ do { \ - if (!ctx.accum_err) \ + if (!(ctx)->accum_err) \ msleep(delay); \ } while (0) =20 --=20 2.45.2