[PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup

Tree Davies posted 24 patches 1 year, 8 months ago
.../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  16 +--
drivers/staging/rtl8192e/rtl8192e/rtl_core.c  |   6 +-
drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    |   8 +-
drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |   2 +-
drivers/staging/rtl8192e/rtl819x_HTProc.c     |   2 +-
drivers/staging/rtl8192e/rtl819x_TSProc.c     |   2 +-
drivers/staging/rtl8192e/rtllib.h             |  28 ++--
drivers/staging/rtl8192e/rtllib_crypt_ccmp.c  |   4 +-
drivers/staging/rtl8192e/rtllib_crypt_tkip.c  |  10 +-
drivers/staging/rtl8192e/rtllib_crypt_wep.c   |   4 +-
drivers/staging/rtl8192e/rtllib_rx.c          |  45 +++---
drivers/staging/rtl8192e/rtllib_tx.c          | 131 +++++++++---------
12 files changed, 126 insertions(+), 132 deletions(-)
[PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup
Posted by Tree Davies 1 year, 8 months ago
This patch series v2 attacks CamelCase variable renames, removes
un-used variables and adjusts alignment issues found in
rtllib_rx.c and rtllib_tx.c.

NOTE: Patch #9 doesn't completely resolve CamelCase violation as the 
correct abreviation of megahertz is MHz as called out by Dan Carpenter. 

Thank you in advance to all reviewers.
~Tree

Changes since v1:
#09: Change bforced_tx20Mhz to forced_tx_20MHz, and update commit message 
#21: Update subject prefix with 'Staging: rtl8192e:'
#22: Update subject prefix with 'Staging: rtl8192e:'
#23: Update subject prefix with 'Staging: rtl8192e:'
#24: Update subject prefix with 'Staging: rtl8192e:'

Tree Davies (24):
  Staging: rtl8192e: Rename variable bHwSec
  Staging: rtl8192e: Rename variable bIsMulticast
  Staging: rtl8192e: Rename variable HTCurrentOperaRate
  Staging: rtl8192e: Rename variable HTOpMode
  Staging: rtl8192e: Rename variable bRTSEnable
  Staging: rtl8192e: Rename variable bRTSBW
  Staging: rtl8192e: Rename variable bCTSEnable
  Staging: rtl8192e: Rename variable bRTSUseShortGI
  Staging: rtl8192e: Rename variable bforced_tx20Mhz
  Staging: rtl8192e: Rename variable bPacketBW
  Staging: rtl8192e: Rename variable bBroadcast
  Staging: rtl8192e: Rename variable CntAfterLink
  Staging: rtl8192e: Rename variable bUseShortGI
  Staging: rtl8192e: Rename function TsStartAddBaProcess()
  Staging: rtl8192e: Fix alignment to match open parenthesis
  Staging: rtl8192e: Rename function rtllib_query_BandwidthMode
  Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode
  Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI
  Staging: rtl8192e: Rename variable bUseShortPreamble
  Staging: rtl8192e: Rename variable bRTSSTBC
  Staging: rtl8192e: Remove parameter bIsAmsdu from rtllib_classify()
  Staging: rtl8192e: Remove variable IsAmsdu from rtllib_xmit_inter()
  Staging: rtl8192e: Fix alignment to match open parenthesis in
    rtllib_tx.c
  Staging: rtl8192e: Fix alignment to match open parenthesis in
    rtllib_rx.c

 .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  16 +--
 drivers/staging/rtl8192e/rtl8192e/rtl_core.c  |   6 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    |   8 +-
 drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |   2 +-
 drivers/staging/rtl8192e/rtl819x_HTProc.c     |   2 +-
 drivers/staging/rtl8192e/rtl819x_TSProc.c     |   2 +-
 drivers/staging/rtl8192e/rtllib.h             |  28 ++--
 drivers/staging/rtl8192e/rtllib_crypt_ccmp.c  |   4 +-
 drivers/staging/rtl8192e/rtllib_crypt_tkip.c  |  10 +-
 drivers/staging/rtl8192e/rtllib_crypt_wep.c   |   4 +-
 drivers/staging/rtl8192e/rtllib_rx.c          |  45 +++---
 drivers/staging/rtl8192e/rtllib_tx.c          | 131 +++++++++---------
 12 files changed, 126 insertions(+), 132 deletions(-)

-- 
2.30.2
Re: [PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup
Posted by Philipp Hortmann 1 year, 8 months ago
On 6/12/24 05:22, Tree Davies wrote:
> This patch series v2 attacks CamelCase variable renames, removes
> un-used variables and adjusts alignment issues found in
> rtllib_rx.c and rtllib_tx.c.
> 
> NOTE: Patch #9 doesn't completely resolve CamelCase violation as the
> correct abreviation of megahertz is MHz as called out by Dan Carpenter.
> 
> Thank you in advance to all reviewers.
> ~Tree
> 
> Changes since v1:
> #09: Change bforced_tx20Mhz to forced_tx_20MHz, and update commit message
> #21: Update subject prefix with 'Staging: rtl8192e:'
> #22: Update subject prefix with 'Staging: rtl8192e:'
> #23: Update subject prefix with 'Staging: rtl8192e:'
> #24: Update subject prefix with 'Staging: rtl8192e:'
> 
> Tree Davies (24):
>    Staging: rtl8192e: Rename variable bHwSec
>    Staging: rtl8192e: Rename variable bIsMulticast
>    Staging: rtl8192e: Rename variable HTCurrentOperaRate
>    Staging: rtl8192e: Rename variable HTOpMode
>    Staging: rtl8192e: Rename variable bRTSEnable
>    Staging: rtl8192e: Rename variable bRTSBW
>    Staging: rtl8192e: Rename variable bCTSEnable
>    Staging: rtl8192e: Rename variable bRTSUseShortGI
>    Staging: rtl8192e: Rename variable bforced_tx20Mhz
>    Staging: rtl8192e: Rename variable bPacketBW
>    Staging: rtl8192e: Rename variable bBroadcast
>    Staging: rtl8192e: Rename variable CntAfterLink
>    Staging: rtl8192e: Rename variable bUseShortGI
>    Staging: rtl8192e: Rename function TsStartAddBaProcess()
>    Staging: rtl8192e: Fix alignment to match open parenthesis
>    Staging: rtl8192e: Rename function rtllib_query_BandwidthMode
>    Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode
>    Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI
>    Staging: rtl8192e: Rename variable bUseShortPreamble
>    Staging: rtl8192e: Rename variable bRTSSTBC
>    Staging: rtl8192e: Remove parameter bIsAmsdu from rtllib_classify()
>    Staging: rtl8192e: Remove variable IsAmsdu from rtllib_xmit_inter()
>    Staging: rtl8192e: Fix alignment to match open parenthesis in
>      rtllib_tx.c
>    Staging: rtl8192e: Fix alignment to match open parenthesis in
>      rtllib_rx.c
> 
>   .../staging/rtl8192e/rtl8192e/r8192E_dev.c    |  16 +--
>   drivers/staging/rtl8192e/rtl8192e/rtl_core.c  |   6 +-
>   drivers/staging/rtl8192e/rtl8192e/rtl_dm.c    |   8 +-
>   drivers/staging/rtl8192e/rtl8192e/rtl_wx.c    |   2 +-
>   drivers/staging/rtl8192e/rtl819x_HTProc.c     |   2 +-
>   drivers/staging/rtl8192e/rtl819x_TSProc.c     |   2 +-
>   drivers/staging/rtl8192e/rtllib.h             |  28 ++--
>   drivers/staging/rtl8192e/rtllib_crypt_ccmp.c  |   4 +-
>   drivers/staging/rtl8192e/rtllib_crypt_tkip.c  |  10 +-
>   drivers/staging/rtl8192e/rtllib_crypt_wep.c   |   4 +-
>   drivers/staging/rtl8192e/rtllib_rx.c          |  45 +++---
>   drivers/staging/rtl8192e/rtllib_tx.c          | 131 +++++++++---------
>   12 files changed, 126 insertions(+), 132 deletions(-)
> 

Tested-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Re: [PATCH v2 00/24] Staging: rtl8192e: Maintenance renames and cleanup
Posted by Dan Carpenter 1 year, 8 months ago
On Tue, Jun 11, 2024 at 08:22:06PM -0700, Tree Davies wrote:
> This patch series v2 attacks CamelCase variable renames, removes
> un-used variables and adjusts alignment issues found in
> rtllib_rx.c and rtllib_tx.c.
> 
> NOTE: Patch #9 doesn't completely resolve CamelCase violation as the 
> correct abreviation of megahertz is MHz as called out by Dan Carpenter. 

Thanks!

Reviewed-by: Dan Carpenter <dan.carpenter@linaro.org>

regards,
dan carpenter