From nobody Thu Feb 12 14:09:56 2026 Received: from mail-io1-f50.google.com (mail-io1-f50.google.com [209.85.166.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CE52F4FA for ; Wed, 12 Jun 2024 03:22:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162557; cv=none; b=mQo59MQKE+5/N8UuEfWgTcBs3r3dMKWuO/pCZWyd7+IQ8i5ulj7g9fnwyg1RTA+PB2SEg6Pvn0vaUVHYcWeDWpKajg/Lnr5HF+BsiPdFxFcLINnKEHxZqqAHL2kPRrkQGlkkZk2YvAS+ZbCmKORhZHr3teTvfPyyQKqs8tdaWoU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162557; c=relaxed/simple; bh=LaU6dQaJxZXXUJQeF0eU9sdx2/otptNdwAGBmWkZyaE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=gvcQib3y0ZFOsberbxBOxykNV40ukSQUMAwBMePVgW1sMOSUX2nabWCgJ6haqs8/dnCT/0mVfzv64uMjDkUmbBpGV1XJKxMU5GtH7U+otrgDL0hETBXhftlNze2rQvtO5n7WoqaImSmpH2wUkhbF9RRQCe59VhEWWW+Ob2XyOFE= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Z6C2z4NK; arc=none smtp.client-ip=209.85.166.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Z6C2z4NK" Received: by mail-io1-f50.google.com with SMTP id ca18e2360f4ac-7eb715a3411so71459639f.2 for ; Tue, 11 Jun 2024 20:22:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162554; x=1718767354; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=W9ddKnwqsJlVTx2fCcXGsBbSpiYsicphmf2Gt297Zag=; b=Z6C2z4NKXVSlyHKIGlmgFjIVn9qOjCsUNlCERRf8dUn1P/mCS+uOZgAu/qwRYptQxE J6XTZUr4eW4A3pB/GMcwMD+tir7F2m3eWprdmclDpOTjR4G/+5rwFJ5nGjREUb3VRVW3 R/ZmYj5pGw6OmVjaBOIvJ7b9lcjIjywNBfMX28U2lkn73xljZ6c1mjtzWr1LT3doJyhl TozMxReToRHQDasozOUCn8v7UPLs6Z6aMr1ro0oURT7yvMOgY8hDJ7R1dZVB7uObxaO1 DB9EJHNCfBi0ugxJ03ZMqiSR2TlrnCyjCmIsnmtOZ+B+SmVSnNmioSp4FLAYAPL/XoUX WG0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162554; x=1718767354; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=W9ddKnwqsJlVTx2fCcXGsBbSpiYsicphmf2Gt297Zag=; b=JgGrEt69E/UcmcKLJGAfohmTJGvCDB8GkW61fUv+0dDCF0zdww01wwh+T2awXQxW4n ywJLBPSMUy+fTXvBC3QdY+wKYQhylbF93rOnRCda85m3cpdLQNp598R5naE6h9QzX0gR EmXunQ5b5+J1Nfu6R+KpeQCaoxVlzUPGShUGXTnoReCzYrkCQNg7TbKztZPbnp0Xk5yu FKoUqK+EjUEELdTQP2Cf3HihxNLzIqQByIuFJDGnuzj1rOJFvmJDGnAs8nlMiEI0ojSB OovOWNfTefEvstC+2dhJjdwVMgC+6RAnKqVPiCQpkqEPAf4bU3FH6WPjU7vZXYDaUM29 nENA== X-Forwarded-Encrypted: i=1; AJvYcCWHTex7i/yySa+BOoL8wlgl5BmcV6Hyoza2xSy7rUaeGnzrB1vtnXc2tvVrFhE8Zl8lpF559VhVFL6NoudCUTN9sT2qB2SgGAThx39s X-Gm-Message-State: AOJu0YxiC8zB/w3NbZMcLHQ7ybOy+lLoFGyyxNe8qvcgTsgzLCH7qN9w 4X6EphILIeREShnsuOZo+6A1MP5Th7zQBQI+KrJVws356s+PIRYswWpWA0dibpk= X-Google-Smtp-Source: AGHT+IHHz3bKu1atGUUrnNmNiCS5fZ/nu6nktF9MFYPNfiVFZU2nkjAfyA4uugdWzGNSMg5LI/sPlw== X-Received: by 2002:a05:6e02:216f:b0:375:a48d:fd9e with SMTP id e9e14a558f8ab-375cd1d1e96mr6679325ab.24.1718162554091; Tue, 11 Jun 2024 20:22:34 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:33 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 01/24] Staging: rtl8192e: Rename variable bHwSec Date: Tue, 11 Jun 2024 20:22:07 -0700 Message-Id: <20240612032230.9738-2-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bHwSec to hw_sec to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_crypt_ccmp.c | 4 ++-- drivers/staging/rtl8192e/rtllib_crypt_tkip.c | 10 +++++----- drivers/staging/rtl8192e/rtllib_crypt_wep.c | 4 ++-- drivers/staging/rtl8192e/rtllib_rx.c | 8 ++++---- drivers/staging/rtl8192e/rtllib_tx.c | 6 +++--- 7 files changed, 18 insertions(+), 18 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index a0fc33f984e8..27dfa268cd68 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -934,7 +934,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, =20 pdesc->NoEnc =3D 1; pdesc->SecType =3D 0x0; - if (cb_desc->bHwSec) { + if (cb_desc->hw_sec) { static u8 tmp; =20 if (!tmp) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 62af48c20229..46bc3561f56f 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -105,7 +105,7 @@ struct cb_desc { u8 bCmdOrInit:1; u8 tx_dis_rate_fallback:1; u8 tx_use_drv_assinged_rate:1; - u8 bHwSec:1; + u8 hw_sec:1; =20 u8 nStuckCount; =20 diff --git a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c b/drivers/staging= /rtl8192e/rtllib_crypt_ccmp.c index cbb8c8dbe9b0..230552dd2b4d 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_ccmp.c @@ -182,7 +182,7 @@ static int rtllib_ccmp_encrypt(struct sk_buff *skb, int= hdr_len, void *priv) *pos++ =3D key->tx_pn[0]; =20 hdr =3D (struct ieee80211_hdr *)skb->data; - if (!tcb_desc->bHwSec) { + if (!tcb_desc->hw_sec) { struct aead_request *req; struct scatterlist sg[2]; u8 *aad =3D key->tx_aad; @@ -265,7 +265,7 @@ static int rtllib_ccmp_decrypt(struct sk_buff *skb, int= hdr_len, void *priv) key->dot11rsna_stats_ccmp_replays++; return -4; } - if (!tcb_desc->bHwSec) { + if (!tcb_desc->hw_sec) { size_t data_len =3D skb->len - hdr_len - CCMP_HDR_LEN; struct aead_request *req; struct scatterlist sg[2]; diff --git a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c b/drivers/staging= /rtl8192e/rtllib_crypt_tkip.c index 0244b524a7d4..a45fcb13bd54 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_tkip.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_tkip.c @@ -268,7 +268,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int= hdr_len, void *priv) =20 hdr =3D (struct ieee80211_hdr *)skb->data; =20 - if (!tcb_desc->bHwSec) { + if (!tcb_desc->hw_sec) { if (!tkey->tx_phase1_done) { tkip_mixing_phase1(tkey->tx_ttak, tkey->key, hdr->addr2, tkey->tx_iv32); @@ -285,7 +285,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int= hdr_len, void *priv) memmove(pos, pos + 8, hdr_len); pos +=3D hdr_len; =20 - if (tcb_desc->bHwSec) { + if (tcb_desc->hw_sec) { *pos++ =3D Hi8(tkey->tx_iv16); *pos++ =3D (Hi8(tkey->tx_iv16) | 0x20) & 0x7F; *pos++ =3D Lo8(tkey->tx_iv16); @@ -301,7 +301,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int= hdr_len, void *priv) *pos++ =3D (tkey->tx_iv32 >> 16) & 0xff; *pos++ =3D (tkey->tx_iv32 >> 24) & 0xff; =20 - if (!tcb_desc->bHwSec) { + if (!tcb_desc->hw_sec) { icv =3D skb_put(skb, 4); crc =3D ~crc32_le(~0, pos, len); icv[0] =3D crc; @@ -319,7 +319,7 @@ static int rtllib_tkip_encrypt(struct sk_buff *skb, int= hdr_len, void *priv) tkey->tx_iv32++; } =20 - if (!tcb_desc->bHwSec) + if (!tcb_desc->hw_sec) return ret; return 0; } @@ -371,7 +371,7 @@ static int rtllib_tkip_decrypt(struct sk_buff *skb, int= hdr_len, void *priv) iv32 =3D pos[4] | (pos[5] << 8) | (pos[6] << 16) | (pos[7] << 24); pos +=3D 8; =20 - if (!tcb_desc->bHwSec || (skb->cb[0] =3D=3D 1)) { + if (!tcb_desc->hw_sec || (skb->cb[0] =3D=3D 1)) { if ((iv32 < tkey->rx_iv32 || (iv32 =3D=3D tkey->rx_iv32 && iv16 <=3D tkey->rx_iv16)) && tkey->initialized) { diff --git a/drivers/staging/rtl8192e/rtllib_crypt_wep.c b/drivers/staging/= rtl8192e/rtllib_crypt_wep.c index 21c2b7666d6f..bd732c562b82 100644 --- a/drivers/staging/rtl8192e/rtllib_crypt_wep.c +++ b/drivers/staging/rtl8192e/rtllib_crypt_wep.c @@ -102,7 +102,7 @@ static int prism2_wep_encrypt(struct sk_buff *skb, int = hdr_len, void *priv) /* Copy rest of the WEP key (the secret part) */ memcpy(key + 3, wep->key, wep->key_len); =20 - if (!tcb_desc->bHwSec) { + if (!tcb_desc->hw_sec) { /* Append little-endian CRC32 and encrypt it to produce ICV */ crc =3D ~crc32_le(~0, pos, len); icv =3D skb_put(skb, 4); @@ -155,7 +155,7 @@ static int prism2_wep_decrypt(struct sk_buff *skb, int = hdr_len, void *priv) /* Apply RC4 to data and compute CRC32 over decrypted data */ plen =3D skb->len - hdr_len - 8; =20 - if (!tcb_desc->bHwSec) { + if (!tcb_desc->hw_sec) { arc4_setkey(&wep->rx_ctx_arc4, key, klen); arc4_crypt(&wep->rx_ctx_arc4, pos, pos, plen + 4); =20 diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 86b8d342ac80..3bff54efe66e 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -282,10 +282,10 @@ rtllib_rx_frame_decrypt(struct rtllib_device *ieee, s= truct sk_buff *skb, struct cb_desc *tcb_desc =3D (struct cb_desc *) (skb->cb + MAX_DEV_ADDR_SIZE); =20 - tcb_desc->bHwSec =3D 1; + tcb_desc->hw_sec =3D 1; =20 if (ieee->need_sw_enc) - tcb_desc->bHwSec =3D 0; + tcb_desc->hw_sec =3D 0; } =20 hdr =3D (struct ieee80211_hdr *)skb->data; @@ -321,10 +321,10 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ie= ee, struct sk_buff *skb, struct cb_desc *tcb_desc =3D (struct cb_desc *) (skb->cb + MAX_DEV_ADDR_SIZE); =20 - tcb_desc->bHwSec =3D 1; + tcb_desc->hw_sec =3D 1; =20 if (ieee->need_sw_enc) - tcb_desc->bHwSec =3D 0; + tcb_desc->hw_sec =3D 0; } =20 hdr =3D (struct ieee80211_hdr *)skb->data; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index b1bde5c0050a..87d1ff943617 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -751,14 +751,14 @@ static int rtllib_xmit_inter(struct sk_buff *skb, str= uct net_device *dev) =20 if (encrypt) { if (ieee->hwsec_active) - tcb_desc->bHwSec =3D 1; + tcb_desc->hw_sec =3D 1; else - tcb_desc->bHwSec =3D 0; + tcb_desc->hw_sec =3D 0; skb_reserve(skb_frag, crypt->ops->extra_mpdu_prefix_len + crypt->ops->extra_msdu_prefix_len); } else { - tcb_desc->bHwSec =3D 0; + tcb_desc->hw_sec =3D 0; } frag_hdr =3D skb_put_data(skb_frag, &header, hdr_len); =20 --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E08A21DFF0 for ; Wed, 12 Jun 2024 03:22:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.169 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162557; cv=none; b=Vmugnq7tlbDTJO1/h5+a0Ny+IVGEqBFEK1FRD8wfxpTt/WPHqYbKCNVeQXXYmqTIo8CaDu8Ue4lkD/AhQYoVpHM9z8So7g6TDYSDfefp4V3nWhK+WCuhzoiRmj3g+RSHhtMgskfgvHZPHT42EtNSjqFq/hYfYl6LAjaKGBLaBCc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162557; c=relaxed/simple; bh=Z2Og8hD3ZwqLqSZxTqFmWZuV5tskamWURf9scY/q4VE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=IHIqd8MNXW7I5vskaOTpF2R2K45Itb4k9PrH9c11uUpOsD7GS9jWBm9ybmX2klaSzWat6ojfBZr4ccITbU2/m2mlVq7VmAcWJ2C4kBEAoVsNaeoAG2Vlrf1saKJue/xdIRocFwk1OKr9hDn+JQnd4KxY0+DZjBT6fHy36S1cpJY= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=FKdKoqnC; arc=none smtp.client-ip=209.85.166.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="FKdKoqnC" Received: by mail-il1-f169.google.com with SMTP id e9e14a558f8ab-375932c94f0so8805815ab.0 for ; Tue, 11 Jun 2024 20:22:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162555; x=1718767355; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=kn6Y3ZurmMy+llEC4r5fkl0HupmvFt8cRPelN9RG3Yg=; b=FKdKoqnCR8MyNn0lEettBPWUcFHzUire574qHCL+L8mcSuwIcwyrV/eyuNmbfng+7D eTJ2p86XWZISNU+W+w0AGM16lXMcDIVooFvZBkVYYTdnNAdGJejQzBZ4Lyf3Ubux+McI PT6krMgcwLwjjeFnAk9DFAvpw3pD1gxbw/Xjruni9fK7vL+Lcr0xkpJiA5zMPlUfwOCL LDTyInBM3ojQaYIXKpyxac1S+GPVMKFdnCBIbiwzorJwmzWBCvyqvuhJ2/2U6GyCySid dw0sh0qfrHGBqtLkZ9WoRlMjs2OdNEPWW3H5FrDPXl531CvMlNdDhB6EEe8qiKCIPfBZ V2QA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162555; x=1718767355; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kn6Y3ZurmMy+llEC4r5fkl0HupmvFt8cRPelN9RG3Yg=; b=eMe0i/ZGACHB1etw55H2D6aRBkJCkJgITE+Lr8kBOqLEUFXY3qtQ5l1ecX53Kkt8+i dOKhdXo35cZhvaiCbRrjh6pTMAiXevML2x5/lsEoPPGzwbOe/QBFrxbpYo+WNqsV1S4F quAJoAb0SGmqVQVnKovv51lZH4EC8MTlZKoI6vPfsi6wYXcxj0qAM1Dw1EQNQNJOi63Y Iqh/hy/N7RpHNqRlYMuLyxKDLk6FG9x1g5+dyP0a2MgbiVpijbZqIa/gX9sUSrzTjp/G UByXnITWaql+Sbg0952+HiMG7ymd4Bh0jpXMV38mlkhuHah/nYf9l0O5081BAtm5ZF+x 0mxQ== X-Forwarded-Encrypted: i=1; AJvYcCWpxVqBcCerBcjbJ4RtbWgER4Rnyy/+IE88geynbn6fPfCOVeLGhXkU+eF6Q+/Aum0fCDAbZkuixivBMuAUz97zIvH+zZoJNdqp4+K0 X-Gm-Message-State: AOJu0YxpxzVy7bEvpN2wCa2ned9/52dLcQS0EMSuVysYqW3Lxv0XrBBA tu3S5awkY7cMJAtVUfeVQy5wmTKHvcOMvBcVFEyFuAOE7AC1Aji3tLp/Hl6M7Qs= X-Google-Smtp-Source: AGHT+IHlb1SEKPZ48DLEKbZ8JbrKYCfG1s8maoccY1eQUTqDbRm0E8V53nWrYeQDI2gx7GqagFjmhQ== X-Received: by 2002:a05:6e02:1c8a:b0:374:8e4e:86c6 with SMTP id e9e14a558f8ab-375cd14f8e3mr8105285ab.4.1718162554971; Tue, 11 Jun 2024 20:22:34 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:34 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 02/24] Staging: rtl8192e: Rename variable bIsMulticast Date: Tue, 11 Jun 2024 20:22:08 -0700 Message-Id: <20240612032230.9738-3-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bIsMulticast to is_multicast to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib_tx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 87d1ff943617..8856191a1228 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -538,7 +538,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) u8 src[ETH_ALEN]; struct lib80211_crypt_data *crypt =3D NULL; struct cb_desc *tcb_desc; - u8 bIsMulticast =3D false; + u8 is_multicast =3D false; u8 IsAmsdu =3D false; bool bdhcp =3D false; =20 @@ -655,14 +655,14 @@ static int rtllib_xmit_inter(struct sk_buff *skb, str= uct net_device *dev) ether_addr_copy(header.addr3, dest); } =20 - bIsMulticast =3D is_multicast_ether_addr(header.addr1); + is_multicast =3D is_multicast_ether_addr(header.addr1); =20 header.frame_control =3D cpu_to_le16(fc); =20 /* Determine fragmentation size based on destination (multicast * and broadcast are not fragmented) */ - if (bIsMulticast) { + if (is_multicast) { frag_size =3D MAX_FRAG_THRESHOLD; qos_ctl |=3D QOS_CTL_NOTCONTAIN_ACK; } else { @@ -774,7 +774,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) /* The last fragment has the remaining length */ bytes =3D bytes_last_frag; } - if ((qos_activated) && (!bIsMulticast)) { + if ((qos_activated) && (!is_multicast)) { frag_hdr->seq_ctrl =3D cpu_to_le16(rtllib_query_seqnum(ieee, skb_frag, header.addr1)); @@ -809,7 +809,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) skb_put(skb_frag, 4); } =20 - if ((qos_activated) && (!bIsMulticast)) { + if ((qos_activated) && (!is_multicast)) { if (ieee->seq_ctrl[UP2AC(skb->priority) + 1] =3D=3D 0xFFF) ieee->seq_ctrl[UP2AC(skb->priority) + 1] =3D 0; else --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EB461208A8 for ; Wed, 12 Jun 2024 03:22:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162558; cv=none; b=ANH1rzmQ/nN9HHjV2fPhy1Wjbhivtnk1b0aDfN+43GvuFxXORtjnubGKcBZQf5I6AiA/v0gScU7Td466FfcKbtqars3+Z4NvgljVVDqhZth8c8hsmyV8AejMa1bQpD0E2QSD6WTwUsu6sDZAvHaod0kjEwZcdFszGNS5MdGpQ4o= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162558; c=relaxed/simple; bh=UnmB/RJmdXqhKRC4QCOmL/T/yVwrSMTmzh7khofAmpk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=XBaOne6S+PgTh+OBb55zWJO3JBSZrbKz+JExJow9EJTak2jS9DJevTMSOy8s4CaaknDAmMcWcuEOkJe+lWvMIwCHYwCkLkyrliJ4xTFzCGeddpMyedlmNSU4h1E8yBRZXudX3M3tQByKe73BgK0+ac6OnFcqPz/ebdtS5ubqgUs= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=iM7pffaD; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="iM7pffaD" Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5b9f9e7176eso2997746eaf.2 for ; Tue, 11 Jun 2024 20:22:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162556; x=1718767356; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1GXRj6n9mBHwLqddHwXCNNC1CDrIqC2G4HITZu8QmAU=; b=iM7pffaDvW/1wqHFaq4qpOWsFag1DBCJcByaabAxUeHUqMi031OChuUTKRoqFYSUL9 WyJHjb89o5ZnE7z4kvryWf40ctgRxygWQAqPlO9b5+4ZmUPn7ypb/NUgZvWFb9nENlKf i1oR5i/tO1MuBFYfXnSYzpEOOociRDkSWozDuoviByT7URZJX7jIZc+lIGKQlvBTnNPe 7/MrX6d/5sl6woxdCWXLcDuovOMFDLXo97iRYre8oSo6u483QMLxK//pYOnZCXtwX6jg PsMD1p3lOY9kCCe3ycCtferl0I7MAiAG4kVAcfx4d6BCiAmbTRkB2qLdc2DbQ6yMK+WL DXDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162556; x=1718767356; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1GXRj6n9mBHwLqddHwXCNNC1CDrIqC2G4HITZu8QmAU=; b=f4bi2Sxxg7LZVbt1N3RFtFJzXURTOhYkfgG1oDfBN2aNyBwz/50tYxrx0RvLvQYjGj 9EBhEqp9KPRruW+CVu0dGsJif9gazxusx98wiccYag84rQGGDDAF5tdUANzeJoEOUyMb fpMUvxcm6YE4+9rNUORFGSi2sA4vFg8xQz6fdcThLSGs2xbY1tyLKeMJAizs9psylfXm JuzMqDWGtOaYirVOl0zBrd5jo8a1tqOmiphHpXMli11omz9GsaBcuGyzrqbEHyk4Mc2j e14BR+lEMc5NSWxuWIhfphfuFgYcR8xiLCRRJ0iw79TQuPvd06gs9GUJq04wZWeOxkWA /wvQ== X-Forwarded-Encrypted: i=1; AJvYcCVaKp7TVWNXTO454ZZTwVKtBIs5+TcksZFLgq5+JnLnR7D/5qM4YZep+nmpmpqny/mql2+BvU/ns+E/Sr6qDsOjirwWjih8A5vlLLgt X-Gm-Message-State: AOJu0YwBw5EAgGeJK227jCUq3+qZcIe3frMyQ625bU/EEesJdi77NuMI mKj0c85tgLON2yqJ95uwKr/bFbsKCg9HO1ZFassZN/zg5HGy3fBK4jkpHRxQnlk= X-Google-Smtp-Source: AGHT+IGaJkZgaXaAECx5apOGxtFYL2uPvtMgrrrC3AGi63URAQ5W2zli4XmPhP+FUKvhG0cr7tEHfg== X-Received: by 2002:a05:6358:5328:b0:19f:4d0f:eca7 with SMTP id e5c5f4694b2df-19f69d29b4emr100263155d.4.1718162555702; Tue, 11 Jun 2024 20:22:35 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:35 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 03/24] Staging: rtl8192e: Rename variable HTCurrentOperaRate Date: Tue, 11 Jun 2024 20:22:09 -0700 Message-Id: <20240612032230.9738-4-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable HTCurrentOperaRate to ht_curr_op_rate to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl819x_HTProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_HTProc.c b/drivers/staging/rt= l8192e/rtl819x_HTProc.c index 36a734ded7dc..e38cd0c9c013 100644 --- a/drivers/staging/rtl8192e/rtl819x_HTProc.c +++ b/drivers/staging/rtl8192e/rtl819x_HTProc.c @@ -496,7 +496,7 @@ void ht_on_assoc_rsp(struct rtllib_device *ieee) ieee->HTHighestOperaRate =3D ht_get_highest_mcs_rate(ieee, ieee->dot11ht_oper_rate_set, pMcsFilter); - ieee->HTCurrentOperaRate =3D ieee->HTHighestOperaRate; + ieee->ht_curr_op_rate =3D ieee->HTHighestOperaRate; =20 ht_info->current_op_mode =3D pPeerHTInfo->opt_mode; } diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 46bc3561f56f..6dc641f78202 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1198,7 +1198,7 @@ struct rtllib_device { u8 reg_dot11tx_ht_oper_rate_set[16]; u8 dot11ht_oper_rate_set[16]; u8 reg_ht_supp_rate_set[16]; - u8 HTCurrentOperaRate; + u8 ht_curr_op_rate; u8 HTHighestOperaRate; u8 tx_dis_rate_fallback; u8 tx_use_drv_assinged_rate; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 8856191a1228..360d1cc446d0 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -510,8 +510,8 @@ static u8 rtllib_current_rate(struct rtllib_device *iee= e) if (ieee->mode & IEEE_MODE_MASK) return ieee->rate; =20 - if (ieee->HTCurrentOperaRate) - return ieee->HTCurrentOperaRate; + if (ieee->ht_curr_op_rate) + return ieee->ht_curr_op_rate; else return ieee->rate & 0x7F; } --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 79EF320DF7 for ; Wed, 12 Jun 2024 03:22:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162559; cv=none; b=WacYc+JA9ubRjjJmX7VoQH5C7dhE/U0PsEifUJ8Awx5cXjfx+aUfK17w/p+X9aT72gLls28l04gZgbMrl4s2bQmxj1VQd+RvW0E/zKdkhAVrrd3wYFF/JeHJ86uKVYDH8fbOT/3lg4FsWQvAM2ZMJfjlHoAAV/1uKix/8rVTuBc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162559; c=relaxed/simple; bh=MNGZfx/m8G/rOwnxNGd4tIVSOsIacMXC8rkJWcI6FKI=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=embuu/CaPf3QgshlEzvdAdrv7/w4xYfogvRCGbn22cd/WigQl9w1/2cBY2ytoGj7cLxj9b/o65pBTVQP4flwrzgq1Lua+SHhMSDLE+XqewIt7L0a7B//KORORxg4bUqtTowSMVQJ7Nvq4gdhFBN1HQLRjfxK9pRsMwpMgMGCHYk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=VuTI85gv; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="VuTI85gv" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5b2ed25b337so952207eaf.0 for ; Tue, 11 Jun 2024 20:22:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162556; x=1718767356; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Ih+jocFy4KluPcELXVg85YttXvFxOSqGBEasMdYF/eA=; b=VuTI85gvQz8Tu3n5JeqgvkSpuwwPDwHnhGvOoNqmcCqaFopsKMgv/4pDKAuZLfE//l 3dOXNDPaI1MXqlJt2IiVufrYI12WtOgZ+AZk1VPnNTvcmemYO4ueNRrnGlwg9cjg0Q7X fR9SpziRyBs+wVXGyuXksTGBIISP/Wv9y4gk3B4h0NOtlCeUVnxm7SOxH97Dnu0i1uXn z/x/lQGfRuoSSMPZtOTkJ3t6GSCbRKamm69CRK36kE7GabFd0mNkQlqQO0lhgZHyu1GZ N88IVe6ElH1SlIA7Irb3KA5+j7x0UkFc0WQLIf5JbW4WO/mp5wbnf7umhu9N8KwlVxAv nImA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162556; x=1718767356; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Ih+jocFy4KluPcELXVg85YttXvFxOSqGBEasMdYF/eA=; b=bDOVB1I/dbA7/yRyoTma/ynHLlSxXphuv/tFE3KDUa6/U3ylM9eco94JxNA6txsRIt UIMwvrYSnziesjX0OW031AQfYY7WKog2h8iVNe3Mlz6bKwVQS+I7DmNRtrV+OOE+E9rp 0rZFAAf0BBDAsz3fTV6OOl2U5fo5eRhtEzKEexrozocYmrzeReWCm6WHhm4jO7dFiFwK 2YjkJ1jJLVQkc84f2k7XwAbpvcaFPVR4zwAOXT2DDRJEARna4jQgGZQqPYVSiTDxEqSM J9HRFM4o6ezM5WuFmIb4jodED1qbthiA83aILSUlt9aZoRpv57TAHbqldeeapTrJjfRx casw== X-Forwarded-Encrypted: i=1; AJvYcCXg6r2fCI3K43GnrRHWw+6kgASWvfrhmT8pSqF7brmN4/lyUTmYwrG4eZfCmvuy43ROv3juBEfX/Rwfp3F2knLzc/fi1AE+9YUe5a7A X-Gm-Message-State: AOJu0YxRPYDbM8lHv5XzdzIKKUxI/EqmoyPBntquXCpC8oiMs7W/ee3p JUnckwuF2bnb2uSRGSmntwzTz0IzC9WjfOT3wV3/QTwitAOODe4KRg5WKHTLjdY= X-Google-Smtp-Source: AGHT+IHBuiTxrdPRHM4jtIqD5RsNI+BOh+MI67NlK2/uiXzoHG78x2okPV55dQLCkk6gbMYYzfFfhw== X-Received: by 2002:a05:6358:e4a3:b0:19f:5550:84b2 with SMTP id e5c5f4694b2df-19f69d9a729mr92606055d.22.1718162556481; Tue, 11 Jun 2024 20:22:36 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:36 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 04/24] Staging: rtl8192e: Rename variable HTOpMode Date: Tue, 11 Jun 2024 20:22:10 -0700 Message-Id: <20240612032230.9738-5-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable HTOpMode to ht_op_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib_tx.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 360d1cc446d0..83082a990fbd 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -417,11 +417,11 @@ static void rtllib_query_protectionmode(struct rtllib= _device *ieee, break; } if (ht_info->current_ht_support && ht_info->enable_ht) { - u8 HTOpMode =3D ht_info->current_op_mode; + u8 ht_op_mode =3D ht_info->current_op_mode; =20 - if ((ht_info->cur_bw_40mhz && (HTOpMode =3D=3D 2 || - HTOpMode =3D=3D 3)) || - (!ht_info->cur_bw_40mhz && HTOpMode =3D=3D 3)) { + if ((ht_info->cur_bw_40mhz && (ht_op_mode =3D=3D 2 || + ht_op_mode =3D=3D 3)) || + (!ht_info->cur_bw_40mhz && ht_op_mode =3D=3D 3)) { tcb_desc->rts_rate =3D MGN_24M; tcb_desc->bRTSEnable =3D true; break; --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43C24282F1 for ; Wed, 12 Jun 2024 03:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162559; cv=none; b=NFr30vQ2WhAt/CLOPH9yT3vt56B9uT8Li6+coehyow0nbSgjggKz+bfnKGQ6CMP3OW8TD9AhjIn/Zmc3gyVYcU3xH+B6xlIbwNDHr0HA1oltSYESFpUFfrFKYvzTHpGCfJ3uX6Bf/rHZ5969rSZppWHCAsKIBglvvFWED+EETBg= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162559; c=relaxed/simple; bh=54IIdVY7ciiHv8FfEFOv/C1olmIKHuzoK3dEis8XOpA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=C+PSu6ODb+uqr4HvJi/mAKLnprEnnF3vql4jYwKU7VhzZVxpj+EPe5x9V0fsaeMFTM7OwT0HIEfOzaUAMIgoz4l23QF+dr+0jGvszPUjvzlG3ubHOGII/RNa66RtTj7NE0h9V0jSTxRSOLR/vMQHH7cR+T9i8MfYQn4YuSTrlqk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=URPjdJ8z; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="URPjdJ8z" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3d23a0a32afso538335b6e.3 for ; Tue, 11 Jun 2024 20:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162557; x=1718767357; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=VRdNCIuE1fAcIlopHPfrxao68P6nIKXQy67ti/GMEzk=; b=URPjdJ8z55rhXqQ4HBYFqNi7FycuPQmaolVCZtbp9o0vNEUsRvO/VRjFSi5i6YAowW /CVGR83R66GCzcydTYhyQukYbcgc251A7hG3BiSkDbKSp5cv9pVDXUk3sQ2Mx0cDGM99 MCLxY3fe6GE+TdzwxkN3sR75MyKurUpOzm+i3bfPtpIsawGUzZ9QPfQUfOeTVUX+M8uH 2LKU42mf0C6EDQgqGEDJkQnIewp+CJSSp/JQ2aAV65EZgx6ZJoNivsrPekHetoQrH+fE 85WJ0GtwwMa2yGAmsRwgzEdap/2sCoSumR9/axGJ0wo9JVqi0H1OzgEAmD7iexd6+4Da w7ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162557; x=1718767357; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=VRdNCIuE1fAcIlopHPfrxao68P6nIKXQy67ti/GMEzk=; b=RBH6WiBtl/fxKEMpnt6HYAiaorHECxY6FueIjSNopJV2BZoSrBgaJzlsoDE2cn+6Gp gQUj4UzM5VB4juiXnNRXN+w73J2se5F9XELauG4EPz1cQPENGnGwmwHzDWtYAj8msDI+ RwdWZsYlkM625Syi5Mls0DunuZI8kruiZlsyOAR9T6qBek4qG6bzqxWX+FKWKJMnSUGS +sSK/ZhckDM2VihkKDxayq2mShHIFu8f3BQNQFd5wKeqb47ItPcfu8PuvUtE8pfYrImP zK6NWuUgzeRQ6Rbh27WcS+0QoxDVCdubbM4qxZTlmNIZwRvQ7HTG1vCo9whQhacocKn3 cPog== X-Forwarded-Encrypted: i=1; AJvYcCUZ+4rk9bi7KjTv9JLNntROllt9ydsiH75RzRzB/nR0MDWbFkayHV7IfFGjAuicsYApOkviUeDmrrL7ypY5RmtM758qoYF5cJV5s+58 X-Gm-Message-State: AOJu0YzpV0vHIouOytVMeOT/r13nxOV8Y0Qpj7cXc4oPUwgVqszZRmNV I/t5lLeZhT/I0EzNlwcarwzupCDgegc7Le57H3s/9bEeI8QWc2kWmKsSN3thREU= X-Google-Smtp-Source: AGHT+IEgTVRl9RJkhDsO1gIVutg9vxMpQtIebArdKX/AqnlOo+SeVCMLu/htOQ4dRUClFgXHGNiqHQ== X-Received: by 2002:a05:6808:1789:b0:3d2:25c6:c521 with SMTP id 5614622812f47-3d23e0ce2c9mr775622b6e.51.1718162557225; Tue, 11 Jun 2024 20:22:37 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:36 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 05/24] Staging: rtl8192e: Rename variable bRTSEnable Date: Tue, 11 Jun 2024 20:22:11 -0700 Message-Id: <20240612032230.9738-6-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bRTSEnable to rts_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 18 +++++++++--------- 3 files changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 27dfa268cd68..0263f3d7179c 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -892,7 +892,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, pTxFwInfo->RxAMD =3D 0; } =20 - pTxFwInfo->RtsEnable =3D (cb_desc->bRTSEnable) ? 1 : 0; + pTxFwInfo->RtsEnable =3D (cb_desc->rts_enable) ? 1 : 0; pTxFwInfo->CtsEnable =3D (cb_desc->bCTSEnable) ? 1 : 0; pTxFwInfo->RtsSTBC =3D (cb_desc->bRTSSTBC) ? 1 : 0; pTxFwInfo->RtsHT =3D (cb_desc->rts_rate & 0x80) ? 1 : 0; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 6dc641f78202..a305848dabd5 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -111,7 +111,7 @@ struct cb_desc { =20 /* Tx Firmware Related flags (10-11)*/ u8 bCTSEnable:1; - u8 bRTSEnable:1; + u8 rts_enable:1; u8 bUseShortGI:1; u8 bUseShortPreamble:1; u8 tx_enable_fw_calc_dur:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 83082a990fbd..be8de6703e5d 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -386,10 +386,10 @@ static void rtllib_query_protectionmode(struct rtllib= _device *ieee, =20 if (ieee->mode < WIRELESS_MODE_N_24G) { if (skb->len > ieee->rts) { - tcb_desc->bRTSEnable =3D true; + tcb_desc->rts_enable =3D true; tcb_desc->rts_rate =3D MGN_24M; } else if (ieee->current_network.buseprotection) { - tcb_desc->bRTSEnable =3D true; + tcb_desc->rts_enable =3D true; tcb_desc->bCTSEnable =3D true; tcb_desc->rts_rate =3D MGN_24M; } @@ -402,16 +402,16 @@ static void rtllib_query_protectionmode(struct rtllib= _device *ieee, if (ht_info->iot_action & HT_IOT_ACT_FORCED_CTS2SELF) { tcb_desc->bCTSEnable =3D true; tcb_desc->rts_rate =3D MGN_24M; - tcb_desc->bRTSEnable =3D true; + tcb_desc->rts_enable =3D true; break; } else if (ht_info->iot_action & (HT_IOT_ACT_FORCED_RTS | HT_IOT_ACT_PURE_N_MODE)) { - tcb_desc->bRTSEnable =3D true; + tcb_desc->rts_enable =3D true; tcb_desc->rts_rate =3D MGN_24M; break; } if (ieee->current_network.buseprotection) { - tcb_desc->bRTSEnable =3D true; + tcb_desc->rts_enable =3D true; tcb_desc->bCTSEnable =3D true; tcb_desc->rts_rate =3D MGN_24M; break; @@ -423,18 +423,18 @@ static void rtllib_query_protectionmode(struct rtllib= _device *ieee, ht_op_mode =3D=3D 3)) || (!ht_info->cur_bw_40mhz && ht_op_mode =3D=3D 3)) { tcb_desc->rts_rate =3D MGN_24M; - tcb_desc->bRTSEnable =3D true; + tcb_desc->rts_enable =3D true; break; } } if (skb->len > ieee->rts) { tcb_desc->rts_rate =3D MGN_24M; - tcb_desc->bRTSEnable =3D true; + tcb_desc->rts_enable =3D true; break; } if (tcb_desc->ampdu_enable) { tcb_desc->rts_rate =3D MGN_24M; - tcb_desc->bRTSEnable =3D false; + tcb_desc->rts_enable =3D false; break; } goto NO_PROTECTION; @@ -443,7 +443,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, tcb_desc->bUseShortPreamble =3D true; return; NO_PROTECTION: - tcb_desc->bRTSEnable =3D false; + tcb_desc->rts_enable =3D false; tcb_desc->bCTSEnable =3D false; tcb_desc->rts_rate =3D 0; tcb_desc->RTSSC =3D 0; --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 087CB2C697 for ; Wed, 12 Jun 2024 03:22:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162560; cv=none; b=aU5KHbtJqZ1X4QlnWXvRS4O4M6XwuFUE118lD2O2yx0rFl2yREuUXoCm2E/KrbT0VKxjRGC972jnobJOIDNAyRE0RuN1P1NXzU35nEsbY+jZk7UpTe7tlj7MLZMXMqEwY8BRGzj3xUsvRbhV9ttLNw92LmsJ6TWHFKf2EZjwcQM= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162560; c=relaxed/simple; bh=jZscMWxL7wrIFx2GZ4mN7wJ5/mjd6vwOTRZBjWSLoBc=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Lvh+y2ubFiCS9Qm36zwqhGuh45g050kWrr+oLPrugprEznGMihWpiteWHkPXC8PJcDxYdKFf3BNbwdnzbxLUqGCDQru6cFND0TB2b4D7EhJVw6ZfjH9NIEoXGp0KnPFSoV4JhAu8ndi3fc28yg7mvOAoCy1vmzJlHT/D47gt20k= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=gXd9H+SV; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="gXd9H+SV" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5bad217c51aso2198332eaf.1 for ; Tue, 11 Jun 2024 20:22:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162558; x=1718767358; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=P3pqpAJUhbdkefnBX1dLZjdOSci96N6yUXA1/JKUCTg=; b=gXd9H+SVQzqHpXGiiajNlcDITetXqdpuIC28wpqcM3L+atNk0PDdEDP6PRb+3pnaYc uwQcwbju3bCFUQI1ichJbvGUV+0E1rE6P03yfzdoSqbOOXfPOHu1W+WyzknqNUMKonG8 tHccd/gwGzbV0cldHDUAzaFKaZ5JttsjE9SSov2NNyOHI3XcNHmYfZ1Bq8AXot4FkMJ6 yLCvbEJ+1pquJrPRDqKZaR+givTFXPNmeh15uvgyePa64KDp5kWWJdnNrFJQXGRCXpds clcAgvvL6HCygC+s9Q9y71BgPAqu/u9L+3/9GBXjAyB8uNcfF2i0y3C3iZQhjPLly3ma ECJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162558; x=1718767358; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=P3pqpAJUhbdkefnBX1dLZjdOSci96N6yUXA1/JKUCTg=; b=cApQ57jqvLUcDTpOLkeP3qLPeQ7Z5NkVkTDz49SaQLJx88C574O084RfHM6fe+MO0Q mqLJTDiugGwISwdxHqMTHAQwjqv+hf4YWvtYxBY4GJXQrsxziOUeLpHsFJh2mi65K+3P G/gMljtZQJJDhOcBfJO/wHH4q1m4nZ6Z5Gmng0FGUPnB56Ud4OEITSWFxPvH48R2huyz C8rNjurfZ0JW5KDVuZ3UW/q7rbrjNfY1cCTRvgoRVNIGXbSWz93YVJY6xjyMGXpkbHx0 hcJC9gxQ2epqo1M3SkDGqdO+3GaO0hYs1x4AtKh7hymR/vTPW6+rBtc1hYZZuuu9rnhq wzNw== X-Forwarded-Encrypted: i=1; AJvYcCWQsp7h1+YBtORnM0xT9rZqJBw/StiomyFkcdk70Ex1k7hKVUvqSdF10V+t6MZdV310c027uHwkHUer4ln0YZuQiRrT/qdls3TTNXbj X-Gm-Message-State: AOJu0Yw7CVZ1yrvMkauOFBKidggF7x+UPuhy9TL+jLBrE4IwwrlQoTv2 JVI9m7KluLUnh40AJOKgZsUB7QKgf46yV9ZjcTQYB61ZmesnrLm0U/Jk0iXvB3g= X-Google-Smtp-Source: AGHT+IGqui4QJBWV32iB7YGIW6z2TauZoN4z1bETO7wduWaByH9ah0NJvmU1zTHqXN4T1LrZQN3/jA== X-Received: by 2002:a05:6358:8419:b0:19f:3ade:eb78 with SMTP id e5c5f4694b2df-19f69d866c3mr93468055d.28.1718162558054; Tue, 11 Jun 2024 20:22:38 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:37 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 06/24] Staging: rtl8192e: Rename variable bRTSBW Date: Tue, 11 Jun 2024 20:22:12 -0700 Message-Id: <20240612032230.9738-7-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bRTSBW to rts_bw to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index a305848dabd5..0131765e451e 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -119,7 +119,7 @@ struct cb_desc { u8 bRTSSTBC:1; u8 RTSSC:1; =20 - u8 bRTSBW:1; + u8 rts_bw:1; u8 bPacketBW:1; u8 rts_use_short_preamble:1; u8 bRTSUseShortGI:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index be8de6703e5d..8c9072538688 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -376,7 +376,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, tcb_desc->bRTSUseShortGI =3D false; tcb_desc->bCTSEnable =3D false; tcb_desc->RTSSC =3D 0; - tcb_desc->bRTSBW =3D false; + tcb_desc->rts_bw =3D false; =20 if (tcb_desc->bBroadcast || tcb_desc->multicast) return; @@ -447,7 +447,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, tcb_desc->bCTSEnable =3D false; tcb_desc->rts_rate =3D 0; tcb_desc->RTSSC =3D 0; - tcb_desc->bRTSBW =3D false; + tcb_desc->rts_bw =3D false; } =20 static void rtllib_txrate_selectmode(struct rtllib_device *ieee, --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9592F374D3 for ; Wed, 12 Jun 2024 03:22:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162561; cv=none; b=dszIya24MhjSjwYw4QheW0oJY1sPtuHb0cUoL7GalFycIEeVRxbEDf/MeUpouuI13RHGn9kVIdWCQBHx+vpKyS4iX/2W8jvg8VJD2j3h6Pnew5cxH7cXFUcMw39IJ4FxKtgZZBQOTkSCy7zewYZgl6Vzqd6UETnzowxJ6S6xQQc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162561; c=relaxed/simple; bh=GxUQdypfFx8mKG5Keo9Q+CYF+U0ENbg51vKbh73Q4yE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=nO/IonAWoh554Q5WzTAgBbqENbeJAnbgi7PYe/umBMoHVXlE4LZrNtFaM1YHk9Ja3/KBoqaYdEVAtp8X59No6mhuLokcbfMYvXXQAHSs+EAME2LaFYWSdPXuFvpmn3LEHGJ9rnLLye9ch6MxmNU/f7nJtou7Kdr8p5b+UWfCg6w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=geJXBF2E; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="geJXBF2E" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7025f4f4572so371525b3a.1 for ; Tue, 11 Jun 2024 20:22:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162559; x=1718767359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Tu1YovfLQEAsBdhGanL9XJ+Gga/xI5TxCjPr1vPzUmU=; b=geJXBF2EvhSs1QAkvDyN8YAWHFJm6DfVO+Hrqu6lVNE+3agPo8bamY4+tnXz2LsBsP w+7FmjiZrcLBFSeEA2Nrh1E1F83oIpwO2IQn7ho5F+ERhAF1yq0iQX2Vtv2FvkOrW3WD KpsSLctq7NCPcrXhkJXnlrS38Oljnn8sl8QCmiSFbCnbon7eiz4cSKqe+OBS41j8Bupv Ms+VPU9dKi5P0pLa+VZs7wV3EoAKDduA1u3bzU33hlKjr820w7G6Oz9FRbXuG5pk62Rh 4cZ2l7VH0y9rgWjOUnjdSOcx2BSgakCopSyJE/8JeYrSt0R/ccVAfJR930A8I6KwLi7w sjDw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162559; x=1718767359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Tu1YovfLQEAsBdhGanL9XJ+Gga/xI5TxCjPr1vPzUmU=; b=JgLnlRf7grc4Cse6P5rv/EaHfSTnTZ2iPw52kY7Ui9qYMQBi1wsJmHhjcwoI13rSay 2G0YzHZZA61LecHICS2GiHBmmCKx3CqbGOGEF8GKFBtnpLPHv1qcu3VdpH6pDcUlhUGM svPyGIeVcyTLU7SOu7HP4PbRw7gca/17wlZ6xHsc0TpD5JMB5VI2gpPY8VV6dgYA+9fB xZRJ7Uza9UeVxslTula0xYPpk9TWjNHDPP9PSWRFEXiTdymWwJqSAc21qWcad5cXf6Tl bFWTJfyiZr3Of+GPA/oKuqfT4jhSryMlsJHi+8nZYiwaE1dLplk1ZBMttQvoqrV8kuDx obwg== X-Forwarded-Encrypted: i=1; AJvYcCUOFXrxFp4rWvZJ8+dRegX/r5Ceq+ddadoFBJLkg3luMALoMpxV4Xf6zAOpI+k6yicET+MKx1jAsfB7uRBDRvteWIRSZaQb+NzdYYRk X-Gm-Message-State: AOJu0Yz9ZWPhuy5oRjpxFv7kCFCyxFTCx9h38EvV60Z2s0g8FGpxN3MW mxZ17KKSvUF1bXoz0DAvu8vfValiloPhNCBe/5nVCdh/U1jrU7HXye+sIovQx7E= X-Google-Smtp-Source: AGHT+IGbK31oLFywfNaLnSP9D1b26MHKW4EJL/Us0ks3qOwNu0Lp2kbhXjyFeoVfuTZbSyY/tnEc4w== X-Received: by 2002:a05:6a20:96cf:b0:1b5:88f5:5823 with SMTP id adf61e73a8af0-1b86d376213mr5016905637.27.1718162558807; Tue, 11 Jun 2024 20:22:38 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:38 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 07/24] Staging: rtl8192e: Rename variable bCTSEnable Date: Tue, 11 Jun 2024 20:22:13 -0700 Message-Id: <20240612032230.9738-8-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bCTSEnable to cts_enable to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 10 +++++----- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 0263f3d7179c..4117530f19b1 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -893,7 +893,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, } =20 pTxFwInfo->RtsEnable =3D (cb_desc->rts_enable) ? 1 : 0; - pTxFwInfo->CtsEnable =3D (cb_desc->bCTSEnable) ? 1 : 0; + pTxFwInfo->CtsEnable =3D (cb_desc->cts_enable) ? 1 : 0; pTxFwInfo->RtsSTBC =3D (cb_desc->bRTSSTBC) ? 1 : 0; pTxFwInfo->RtsHT =3D (cb_desc->rts_rate & 0x80) ? 1 : 0; pTxFwInfo->RtsRate =3D _rtl92e_rate_mgn_to_hw(cb_desc->rts_rate); diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 0131765e451e..2282c709654d 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -110,7 +110,7 @@ struct cb_desc { u8 nStuckCount; =20 /* Tx Firmware Related flags (10-11)*/ - u8 bCTSEnable:1; + u8 cts_enable:1; u8 rts_enable:1; u8 bUseShortGI:1; u8 bUseShortPreamble:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 8c9072538688..c0fe00d0df02 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -374,7 +374,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, =20 tcb_desc->bRTSSTBC =3D false; tcb_desc->bRTSUseShortGI =3D false; - tcb_desc->bCTSEnable =3D false; + tcb_desc->cts_enable =3D false; tcb_desc->RTSSC =3D 0; tcb_desc->rts_bw =3D false; =20 @@ -390,7 +390,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, tcb_desc->rts_rate =3D MGN_24M; } else if (ieee->current_network.buseprotection) { tcb_desc->rts_enable =3D true; - tcb_desc->bCTSEnable =3D true; + tcb_desc->cts_enable =3D true; tcb_desc->rts_rate =3D MGN_24M; } return; @@ -400,7 +400,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, =20 while (true) { if (ht_info->iot_action & HT_IOT_ACT_FORCED_CTS2SELF) { - tcb_desc->bCTSEnable =3D true; + tcb_desc->cts_enable =3D true; tcb_desc->rts_rate =3D MGN_24M; tcb_desc->rts_enable =3D true; break; @@ -412,7 +412,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, } if (ieee->current_network.buseprotection) { tcb_desc->rts_enable =3D true; - tcb_desc->bCTSEnable =3D true; + tcb_desc->cts_enable =3D true; tcb_desc->rts_rate =3D MGN_24M; break; } @@ -444,7 +444,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, return; NO_PROTECTION: tcb_desc->rts_enable =3D false; - tcb_desc->bCTSEnable =3D false; + tcb_desc->cts_enable =3D false; tcb_desc->rts_rate =3D 0; tcb_desc->RTSSC =3D 0; tcb_desc->rts_bw =3D false; --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F3A3208D6 for ; Wed, 12 Jun 2024 03:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.179 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162561; cv=none; b=UP9h72cOi3ngpIvBCAu4PS7CgQn69Jnt6xsq0NsGFVYmclixyZhGi40BB1CB9YRMpg5N2/jy9u3fUaiG0S37FdL/aJlk5e6p6BNSgky5Xne4r8D2YEn+An7MX1Sj3TO7vLVNzOecIM6VdkxLYoNq5sdc/rI1Is5sbX/bQfuCPSk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162561; c=relaxed/simple; bh=pOnS++sX2eAGvOC3LVoYaJxWzWEYFDsnsJR5WVz99MQ=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BouualOSb+c4PPwPSZBKSc3hf3EXTUVXrm1P5TpS6SfA5goUWZf2BXE9e1uHX/jlbIx5FgGzqJAnI+1lvChj64On+biytCEoLBG4yTxS7cNGmG6Imn8/BEEMBsc3q4ze14jj6qcStGt+T2Tzi9FY+EQXZI+C/Ztb/eiXrCyrkcI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=MZujluSK; arc=none smtp.client-ip=209.85.210.179 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="MZujluSK" Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-70432d3406bso2743115b3a.1 for ; Tue, 11 Jun 2024 20:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162559; x=1718767359; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=XPNFt3LcUqDEQ/+6JbVhxGeiAYv8XI9NoJl7wWcKnq8=; b=MZujluSKiwREEA3IB0m69rX4NhJkFzfiA5s17FLnVod5wKeSJpJe6esAZjMEn7qWeE GrCyZeqcdj/UjxkUMWrvTDLFPHX/N/yf/Myizkc3AzROJFRPlmLFqPwaX81cKCinRglG KLCzG0gneBVxTeWdDB0PcI1RhCqauhAm3OLaOsNuRBif4UcFT/Eb6Pt4qNZQsZ7nYnVs RGF8ZWIGYc/fVcqZkpRGVU73QdVbPJTQ+LjqUzgrovYNUmCxOUZdHQqkuSXVjs1AM7aB N2DyuaL5AqVuexzJwsZrekBR5rkku6l7+RNNEq2y7wRHWSkS/4lgkqxMmezhUTRIO7D2 rRNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162559; x=1718767359; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XPNFt3LcUqDEQ/+6JbVhxGeiAYv8XI9NoJl7wWcKnq8=; b=tYMCz5IzhyP9RiwSPEUaitzGMuwJ2e+elZDE/ceOqFrvzrEY5pcqYPqpMIsXSMVS9Q 6OOM5S5LSDFWHfL4+v+DocxCGxg+cAhOQt+6pU8T6wNpgv2QcrBi//hVuHcTFkqSYdTw GCAZXhqMabFg9XkMELUMdsW5o4SMxbDRQZcDciQMZknM5SRYYq8Em5uTJYirvNXYolEu wVxe90lUZI6ky3d+lRyCbcdg7U9xNc67oI2+6vgnzhsH2kMcTNhJ5zR23V4z3KPhSDjC QPJsKVSKPwjezZwoOODE8LHxa303qTfxc4x35Mb5rGWChjc6sOQ9woz9Ag4Dd+9hWvk2 9JXg== X-Forwarded-Encrypted: i=1; AJvYcCXcpUxBna56nGbsXABiW08H+KKo71PW8dqbjyYDBsGvX55QYI5iGmFwraZHcjx51gEos43rJSk41/fFHoV7UuBAtCWZkcPlPhYPtzwg X-Gm-Message-State: AOJu0YzDbQukEsT/Ccs0u6Ok01kV5J3Rxe9D2Rf+6TicSHaTiezOEwlj L4/uxXktu1wl7+IRuVS2XNqGB/aWceUQWOoAhSPHBFfbfZ3aRR6Eepf27XGT5us= X-Google-Smtp-Source: AGHT+IEQJGR6U1fEbe28j7h6mSnmwjW4DcaEydeXJwwspteYCWurPxelf5gyminIUv8C58P8nHoXvg== X-Received: by 2002:a05:6a20:daa6:b0:1b8:807a:49c2 with SMTP id adf61e73a8af0-1b8a9c85cfdmr910712637.50.1718162559553; Tue, 11 Jun 2024 20:22:39 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:39 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 08/24] Staging: rtl8192e: Rename variable bRTSUseShortGI Date: Tue, 11 Jun 2024 20:22:14 -0700 Message-Id: <20240612032230.9738-9-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bRTSUseShortGI to rts_use_short_gi to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 4117530f19b1..a52db6b1fdb5 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -901,7 +901,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, pTxFwInfo->RtsSubcarrier =3D cb_desc->RTSSC; pTxFwInfo->RtsShort =3D (pTxFwInfo->RtsHT =3D=3D 0) ? (cb_desc->rts_use_short_preamble ? 1 : 0) : - (cb_desc->bRTSUseShortGI ? 1 : 0); + (cb_desc->rts_use_short_gi ? 1 : 0); if (priv->current_chnl_bw =3D=3D HT_CHANNEL_WIDTH_20_40) { if (cb_desc->bPacketBW) { pTxFwInfo->TxBandwidth =3D 1; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 2282c709654d..bd18d866ce22 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -122,7 +122,7 @@ struct cb_desc { u8 rts_bw:1; u8 bPacketBW:1; u8 rts_use_short_preamble:1; - u8 bRTSUseShortGI:1; + u8 rts_use_short_gi:1; u8 multicast:1; u8 bBroadcast:1; u8 drv_agg_enable:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index c0fe00d0df02..d376c35a5ad7 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -373,7 +373,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, struct rt_hi_throughput *ht_info; =20 tcb_desc->bRTSSTBC =3D false; - tcb_desc->bRTSUseShortGI =3D false; + tcb_desc->rts_use_short_gi =3D false; tcb_desc->cts_enable =3D false; tcb_desc->RTSSC =3D 0; tcb_desc->rts_bw =3D false; --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 05B4A3F8ED for ; Wed, 12 Jun 2024 03:22:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.177 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162562; cv=none; b=pH2Oz/JcBj2NhA4TIEIv2ZR56SP1Shh+Oud75k9DWHHwuMKJDL+9iCar4jixa3BwFxmZ5wpx6XH4a7cWlLrpiL1/rZj810HBg0MIYfbPIFc+iaeQ17bspybMDWbctkjeev2OIIYjqzkzRNpfQsnHqY7fU3Q0hT4BSs2iu/30tss= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162562; c=relaxed/simple; bh=g04zKuym8MOAIEks5WqlwbJO0ymKVXZ1rE4I4gyez2k=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=NykiCtEfa5FIeJW3hPEZ1pMjhYEVCyghDqkfXixyTumnAG+xiIMsd6nowEYmpVzmxuV3AJF2S56E8wEgrMBeMz4Q724y28yCb1tZm9w6rj2HDOxk4m/Ch7DRUgiS4eyg7TuGheJOO8Tdtnqe6K6SM9K2ceAVeLbHdt8lQREpbPM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=OTkLChne; arc=none smtp.client-ip=209.85.210.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="OTkLChne" Received: by mail-pf1-f177.google.com with SMTP id d2e1a72fcca58-7042882e741so3105896b3a.2 for ; Tue, 11 Jun 2024 20:22:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162560; x=1718767360; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0WkFr6xEvivvd+B09wKWKgC46Hg539bA2/mgjCH1xUA=; b=OTkLChneav9SNPisdjyfgE/D4j2S7Z4aaymyNH3FC+OyCX5mlIUXZWoMKzEqAPW/Aq Ir6ZhPtXtMi/Nl7FpdCcO86n/X/zS8C+AQimn4ooTfsXBjdcgethC/GKCtTQlKCfwUmE 2HZI+M9hurHfRaYPrbii1NTIbMEmL/6Zw3ifCNny42cfi1pGNoPa7Dlvu72L77ze5hZD sUGySBcjTAban8I6azvcI+9AtQghNpirg/typzlXWh2wLmOMLSkde/yNN03DDfJWPncH zr1/7n3+xLg/LSbd9y0b9CJyGLxBi2p1RDerXj3rinbSwHDraU/KRKUFXb2mO2NzJupG Q31g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162560; x=1718767360; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0WkFr6xEvivvd+B09wKWKgC46Hg539bA2/mgjCH1xUA=; b=KTpo7KhXwYTZDmbeiHkrm1AQ5dL3L/O+iGY2xOE8WMb8U0Lm0niD2Rpb2c7JxbdcAL nSWj0rm1Om2SQb2txdaKlWYNGD+MjkpBaUGyzTinZUCFQCbNEHv4smlfBFzDnBLg4lLg jSFoC9vIhwWgEjk08g7Pkoj1PYk8A2q0Gr9V37BcU/Zv3mvJ4NsO22R7t0dgW9bvdWV5 OL2bl6cZefecKEq6cBQKapHe5qjICI7dB8CEiIKXXgsNzNOHtsMs2lIc/y5f/cEFFlpu e2yd/Bp/+zX9s3BobOXh2J2Y5iYoJsd5XO0Q/PYJikrdEGeTDWTrSljI8SrVqTfzSrsT VD7g== X-Forwarded-Encrypted: i=1; AJvYcCXeBqCpyllWYAh/vZ9fjPAR9a4gdVN6/pgLE2mKfxZ77aRzTBoAvpoD0wTlw1A2jL3T5GqsRvos43Mn4UEI1tpDqEilT3/WRijBDnIT X-Gm-Message-State: AOJu0YywEK+VOunF29AC3/TAtWEq2/AUlNmNxSt4gqm8pN8DLH24ngqe VOHjnMJJBaxF0ozVLK33egR4Ax4G0xsIX3gmzzXOqbQErvmRzj1BZram/MNQDoM= X-Google-Smtp-Source: AGHT+IGolqUbZjcHpSurAz5mByQrnFKrL1mfB+aDiqNFOrZ9uOqP7glwG77mTIjrxe0GUiqlkn1weg== X-Received: by 2002:a05:6a20:a11b:b0:1af:cc75:3f79 with SMTP id adf61e73a8af0-1b8ab6ab340mr823758637.55.1718162560248; Tue, 11 Jun 2024 20:22:40 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:39 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 09/24] Staging: rtl8192e: Rename variable bforced_tx20Mhz Date: Tue, 11 Jun 2024 20:22:15 -0700 Message-Id: <20240612032230.9738-10-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bforced_tx20Mhz to forced_tx_20MHz to remove hungarian notation and make it snake_case. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Change bforced_tx20Mhz to forced_tx_20MHz, and update commit message drivers/staging/rtl8192e/rtl8192e/rtl_dm.c | 8 ++++---- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_dm.c index 5392d2daf870..f546e6d368b4 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_dm.c @@ -377,7 +377,7 @@ static void _rtl92e_dm_init_bandwidth_autoswitch(struct= net_device *dev) =20 priv->rtllib->bandwidth_auto_switch.threshold_20Mhzto40Mhz =3D BW_AUTO_SW= ITCH_LOW_HIGH; priv->rtllib->bandwidth_auto_switch.threshold_40Mhzto20Mhz =3D BW_AUTO_SW= ITCH_HIGH_LOW; - priv->rtllib->bandwidth_auto_switch.bforced_tx20Mhz =3D false; + priv->rtllib->bandwidth_auto_switch.forced_tx_20MHz =3D false; priv->rtllib->bandwidth_auto_switch.bautoswitch_enable =3D false; } =20 @@ -388,14 +388,14 @@ static void _rtl92e_dm_bandwidth_autoswitch(struct ne= t_device *dev) if (priv->current_chnl_bw =3D=3D HT_CHANNEL_WIDTH_20 || !priv->rtllib->bandwidth_auto_switch.bautoswitch_enable) return; - if (!priv->rtllib->bandwidth_auto_switch.bforced_tx20Mhz) { + if (!priv->rtllib->bandwidth_auto_switch.forced_tx_20MHz) { if (priv->undecorated_smoothed_pwdb <=3D priv->rtllib->bandwidth_auto_switch.threshold_40Mhzto20Mhz) - priv->rtllib->bandwidth_auto_switch.bforced_tx20Mhz =3D true; + priv->rtllib->bandwidth_auto_switch.forced_tx_20MHz =3D true; } else { if (priv->undecorated_smoothed_pwdb >=3D priv->rtllib->bandwidth_auto_switch.threshold_20Mhzto40Mhz) - priv->rtllib->bandwidth_auto_switch.bforced_tx20Mhz =3D false; + priv->rtllib->bandwidth_auto_switch.forced_tx_20MHz =3D false; } } =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index bd18d866ce22..ab52fd66c705 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1018,7 +1018,7 @@ struct tx_pending { struct bandwidth_autoswitch { long threshold_20Mhzto40Mhz; long threshold_40Mhzto20Mhz; - bool bforced_tx20Mhz; + bool forced_tx_20MHz; bool bautoswitch_enable; }; =20 diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index d376c35a5ad7..ba76d2fcc750 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -362,7 +362,7 @@ static void rtllib_query_BandwidthMode(struct rtllib_de= vice *ieee, if ((tcb_desc->data_rate & 0x80) =3D=3D 0) return; if (ht_info->cur_bw_40mhz && ht_info->cur_tx_bw40mhz && - !ieee->bandwidth_auto_switch.bforced_tx20Mhz) + !ieee->bandwidth_auto_switch.forced_tx_20MHz) tcb_desc->bPacketBW =3D true; } =20 --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f45.google.com (mail-oo1-f45.google.com [209.85.161.45]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 199F347A4C for ; Wed, 12 Jun 2024 03:22:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.45 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162564; cv=none; b=leaRekdCZ5ZD3tfLi+4iVN6jXX7vFLqCtaXmAMfVKGApusacP8yPxK690TCJW2+HwsY0JR11tBYGHHx1ycjIAxQSRDT+2OtaItpntnapCB8D/Y3BTde4nRQ0/W3nBym/mR/log64MObSbEUm7PDFyQB2NdpClk5Uf7RjFtzNOBk= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162564; c=relaxed/simple; bh=yEvhe5zcXooYHpUfZbWvNC4CUpB1uvDEagS/CWcMKl0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=TbKXY6qBSvWHAqmKnm5Tmt+FRtD9oioUlPleqZd01FSHYIOhSL1O2mpiPWF3OnsRiSxJpWSQ6s3OokbDyyHPwPIDyAtHb6+wv4WxM5YUaSfU7357mRJYZ/xnlCcgiO8T1V2ushwZknqtgx0R2eVUpIjCVysharquRRFPL5j9fKk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=jvNdzKDV; arc=none smtp.client-ip=209.85.161.45 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="jvNdzKDV" Received: by mail-oo1-f45.google.com with SMTP id 006d021491bc7-5bad217c51aso2198341eaf.1 for ; Tue, 11 Jun 2024 20:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162561; x=1718767361; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IAXnGG9HDug0Dq5esLT95FpBApufxXlkCmYmEp4KdDM=; b=jvNdzKDVf2lP2tZ2feJdK6+N8DIR8hdcd7WzDX319rWUbea3OA/SxbOECFRMMzj/U+ IA8jSbllkr5TpjvBkXUi+gamJ9DFSxbDOlDmiFc3K35j+pUY8TKGuIzMTdBeyPrZIMyD UHzq1mAMfjXQ7zxdKgDvrqdjkV9xDkRTo6B+ZYHfmKM/LupmUxZuj0lwIqJJJoEa2AIa sndExMKGfnMgEJ9WtZ06aMfP1FnhiaUfxACV+tRNCkWwNPR+yBJQXK5XhIUQ1onLppbW dwYa5H4AZrMOzaS7EqkIS4PvYtKgrV9HEfZ8YuPBg2Mh97S+Dk17MTu8FGFabCQmny90 n5lg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162561; x=1718767361; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IAXnGG9HDug0Dq5esLT95FpBApufxXlkCmYmEp4KdDM=; b=WCIZ7hUPpGJS5LfASaaC8C6CXdHzBx5XJk/eLIDPGxTt8mrLOvUrwvSOZiq9U7LQwV tH+0ZBf1WQKJiWq5imqZYugPw5i+4g2y/B0QoH1Y6O+t9qY6UEnuZ+cRiqZg3a/B2w0l Q0pg9GOhgDcvjDK8l8Ld8YZMxtzW5Y+EOKm07KO79CUymib25a9ticy3mMxelm66gt2W d9HMex/E3xSxVKPXPax908kVwGuyCn19PjtSprnsTqpj+3+fAiDa2fO4RS2rV7RYvQgO bhZ8T4EyNDrPgNT6KvO5iy+SOZoOE1uaoUyQdDW2r2YuVFPE1dOhRL34Ly+Ly/junjdV kyKw== X-Forwarded-Encrypted: i=1; AJvYcCXFypJVjI3n0uHgbtcqJI2Qu8HI87AEXIqIIMw+6t/p1qdQs/1VNFfX8RzalWF5NR1E7Pf6I7ED6V3/BRekDMjxgG6EhT9vXZkK6Cei X-Gm-Message-State: AOJu0YwuQwp+eTd/QKCw2N9tAqf2j2AlwoUbzw+Djq2owR85tTglIxlC moh8ymDne2gkR42Aw44fKzjyAH3k+muCYlgCFoPG/LzTNnmU4sacyThPg8CsDFg= X-Google-Smtp-Source: AGHT+IGNzkXfTLzUyM1dxjmWpxPlb3gEuzHU+oLu8U1CS3fxRl2I8x9VOX7JJKwBxiufWm2+wJgIgQ== X-Received: by 2002:a05:6359:4c86:b0:19f:2c7e:a226 with SMTP id e5c5f4694b2df-19f69cf9c16mr96921355d.5.1718162561096; Tue, 11 Jun 2024 20:22:41 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:40 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 10/24] Staging: rtl8192e: Rename variable bPacketBW Date: Tue, 11 Jun 2024 20:22:16 -0700 Message-Id: <20240612032230.9738-11-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bPacketBW to packet_bw to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index a52db6b1fdb5..8dec4e1b89b8 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -903,7 +903,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, (cb_desc->rts_use_short_preamble ? 1 : 0) : (cb_desc->rts_use_short_gi ? 1 : 0); if (priv->current_chnl_bw =3D=3D HT_CHANNEL_WIDTH_20_40) { - if (cb_desc->bPacketBW) { + if (cb_desc->packet_bw) { pTxFwInfo->TxBandwidth =3D 1; pTxFwInfo->TxSubCarrier =3D 0; } else { diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index ab52fd66c705..1f4c1f1f0274 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -120,7 +120,7 @@ struct cb_desc { u8 RTSSC:1; =20 u8 rts_bw:1; - u8 bPacketBW:1; + u8 packet_bw:1; u8 rts_use_short_preamble:1; u8 rts_use_short_gi:1; u8 multicast:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index ba76d2fcc750..a3c211c1b0fa 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -351,7 +351,7 @@ static void rtllib_query_BandwidthMode(struct rtllib_de= vice *ieee, { struct rt_hi_throughput *ht_info =3D ieee->ht_info; =20 - tcb_desc->bPacketBW =3D false; + tcb_desc->packet_bw =3D false; =20 if (!ht_info->current_ht_support || !ht_info->enable_ht) return; @@ -363,7 +363,7 @@ static void rtllib_query_BandwidthMode(struct rtllib_de= vice *ieee, return; if (ht_info->cur_bw_40mhz && ht_info->cur_tx_bw40mhz && !ieee->bandwidth_auto_switch.forced_tx_20MHz) - tcb_desc->bPacketBW =3D true; + tcb_desc->packet_bw =3D true; } =20 static void rtllib_query_protectionmode(struct rtllib_device *ieee, --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-io1-f53.google.com (mail-io1-f53.google.com [209.85.166.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC8DB20DF7 for ; Wed, 12 Jun 2024 03:22:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.53 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162564; cv=none; b=Qla4v0XHqjWU1FiT1iB+baPL7IjX/akz0YBJK2k53TIyAQXLyK9l39akxrSSAvAaJuY0WFSOfYsdCHPteuNpUN2WlMF24Q2yqR2LYgoMz8VrZg32b8A2DIr9CIkwgyzabjEhq/G12EtX538a2ubfQIzK52nhVxT7INrl31H0w0I= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162564; c=relaxed/simple; bh=QbUBSmjsgcQ+yp9vq20Gros3Iliy6wnVzFRdga3AKA8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=KFZlL41WxEz2iWHETOnxxUEznuAN8A2rsxF1rBJmrbIDE5AhnsPYghklwGLxD/LVcF9rW+uovnBXqHicI2ksLLg+WkmNmz0ItE8MjFlCf4P07PrIcLLrtFztrXpZZMbfiNqBFInj4Xv43DYZLAiI3Uqbmxvk+1o3HkevDrDbTGw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=G5lcZRzj; arc=none smtp.client-ip=209.85.166.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="G5lcZRzj" Received: by mail-io1-f53.google.com with SMTP id ca18e2360f4ac-7eb75c0d0a7so130381839f.3 for ; Tue, 11 Jun 2024 20:22:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162562; x=1718767362; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C8sMnW0eAHI5c5WMUrja3LieEYZJVOVr7MzsVIly6Xw=; b=G5lcZRzj/m8y4hOw1iGlSs4N2PPJlD9xpAzlrUxIzN5W1kcjANnv0oktDtbVZoWXJi SZPoch4tPy/pmFwsw2Ruy7bVknXLbrryyhsf+GA36MmoTYo6MU2rRPtGWFlSqyY+x3in 0VsI1qdDJlnd03zZ+4/Mcq3/qTuauocU9S6aswOBPGD1zg/Ix8sO2fDQj1Xksdf0bcy8 IOCuuystleBdMKjSWExMCA3nZO8dgCg+uyETP7Cia6wiMKy6Z2cRLiCG33fXfadN8VJN QBqyJYLZ8uTNbWzTtXIppFsBpU9RXI4S/mA9wns0/H+OyCC9KinZAepR1Vr1tu1SDAoK fmYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162562; x=1718767362; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C8sMnW0eAHI5c5WMUrja3LieEYZJVOVr7MzsVIly6Xw=; b=nkkuCCeT4aumCsOmzQVQwzY4tOuoHuDbrIkzjTnEBQ+0Vhsv+RFw/X+xtfv58mAsNt hdHLZJVHp+DkZ6F1rU3Lv/S0ebQyeIUcJza42x6SZ3wooMVuRnoz485MTDGx2JgjKjwZ EPSpSzMr77l1ncY3uMmIDZDc5HS06mmYgcYZLIWvlJJtq3b73iIJeXz9cW7gC9vHBmeC 9CtypTT7BA1UiO7spN3sp772kckTsRmQCyI1LNt2kxz4wfQ2e2/Ha8JAUqmF4hQjVrS+ xf8QulNfwL2/JfcsKwmpUFUP6+NcUuvaxbG2/ImbM2qEh0IM9Z/3ZaIurLdvJTyRa4H2 pz/w== X-Forwarded-Encrypted: i=1; AJvYcCVJyGjoP/1vMawtSOM9SKXmrf87E0wouUJ7WxhzjnNxSoQVIMlbIKgUCjwyKmjJf2wmL8kdaUcTilvctTYHvTmAArbsbZI1kOIS2Y8v X-Gm-Message-State: AOJu0YxIpXDVLrtYMt0X81z6SIiUBbKfiWvNyjO3PhTfk2GcdqdMH24T owkG6j7F3GyV3Yg0bTbX3dCxTn4J0Ex4fovoOAnqjboybk3dBbX3qOJFX78S7e0= X-Google-Smtp-Source: AGHT+IF3I99/RtSbV0Y2cndGX1Hmd3671JjmeV4fsfA2l42oyupsJUr/uEOXN4rZkhrE4xj0rJEwOQ== X-Received: by 2002:a05:6e02:2185:b0:374:9a3f:d197 with SMTP id e9e14a558f8ab-375cd1062c8mr7052755ab.15.1718162562053; Tue, 11 Jun 2024 20:22:42 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:41 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 11/24] Staging: rtl8192e: Rename variable bBroadcast Date: Tue, 11 Jun 2024 20:22:17 -0700 Message-Id: <20240612032230.9738-12-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bBroadcast to broadcast to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 1f4c1f1f0274..812aeabb4a52 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -124,7 +124,7 @@ struct cb_desc { u8 rts_use_short_preamble:1; u8 rts_use_short_gi:1; u8 multicast:1; - u8 bBroadcast:1; + u8 broadcast:1; u8 drv_agg_enable:1; u8 reserved2:1; =20 diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index a3c211c1b0fa..1ea7157127f6 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -356,7 +356,7 @@ static void rtllib_query_BandwidthMode(struct rtllib_de= vice *ieee, if (!ht_info->current_ht_support || !ht_info->enable_ht) return; =20 - if (tcb_desc->multicast || tcb_desc->bBroadcast) + if (tcb_desc->multicast || tcb_desc->broadcast) return; =20 if ((tcb_desc->data_rate & 0x80) =3D=3D 0) @@ -378,7 +378,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, tcb_desc->RTSSC =3D 0; tcb_desc->rts_bw =3D false; =20 - if (tcb_desc->bBroadcast || tcb_desc->multicast) + if (tcb_desc->broadcast || tcb_desc->multicast) return; =20 if (is_broadcast_ether_addr(skb->data + 16)) @@ -845,9 +845,9 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) if (is_multicast_ether_addr(header.addr1)) tcb_desc->multicast =3D 1; if (is_broadcast_ether_addr(header.addr1)) - tcb_desc->bBroadcast =3D 1; + tcb_desc->broadcast =3D 1; rtllib_txrate_selectmode(ieee, tcb_desc); - if (tcb_desc->multicast || tcb_desc->bBroadcast) + if (tcb_desc->multicast || tcb_desc->broadcast) tcb_desc->data_rate =3D ieee->basic_rate; else tcb_desc->data_rate =3D rtllib_current_rate(ieee); --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA5FB5026B for ; Wed, 12 Jun 2024 03:22:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162565; cv=none; b=WDiqT8sMGG4zFGm09yOHbJGHtwi2elt5HSPJIBUWEdGHmjjKRsDVZcL2lJZlz7FTRApbjn+jke3Uh1TuWjKQ+Ss8BzsVTY5YQ0t6hnMYHHkDsQEiSvvmnscmHsa/ffTozrENIl2FCiQykFvR1NopBi24BMwKr5JsrIomkon4fyc= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162565; c=relaxed/simple; bh=hWiAurK3lrTP0rDgK7hX2BScnXR8rmfbaqqkvHClJ+Q=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=BvAM+S8ZfHyScKHQL7YygYKGumpSEI3m0SRnsiD61bFox2jzDvadYuLU+sEY2lie9XIWqQkOKwEz2v/gdnONwribRFitLuh/jH4DsP7vzcaf4ci6VePzUX3lIxmtGlmDtOu7Fa0fVwbu6ldMnfM9+STx2o30cV9gmlnZ3JCmTBQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=cpyZEGNa; arc=none smtp.client-ip=209.85.210.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="cpyZEGNa" Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6fa0edb64bdso418549a34.1 for ; Tue, 11 Jun 2024 20:22:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162563; x=1718767363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/BAaKVw7/fbvmr5oqNSLigQILIKiz64CgFfcGxrWE8s=; b=cpyZEGNakvWH6vNlg5ae1Nt4C2qkxWyFPHzu0gcU5nlsgUizfmk20KTuAtDe5VC8+D D8buwmf9lVLDUimhrOHn0Xeedsr8uWgTR1tEyYxTOhkU0cbUpFqlXc/nBb9lMstOZwrw H7ndtpFtEvIL6+FMhS3uqKArcHH92yA8ojToaI0Hx5jyjy65exStHUdXfVUmCTk94X9e zZSN+Sr5V12HjtKvQwnG6Wo0C4ejrTa8sZmgxOh/a1xwxcWH9qYHpJVYlFtLICH+LSTZ 5XlM93fWF8QPYgWtrYnJBK0thsf65iTPuv/EbygKJHhbOXuGWiDzg9GHZ6JCaW3VY7GB 1qag== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162563; x=1718767363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/BAaKVw7/fbvmr5oqNSLigQILIKiz64CgFfcGxrWE8s=; b=jSVhrgjr12w9OmfI4zg6APnKnw0FbH4bykAyIcVMpo0dZlZekcd+Gr6TZWc0/qlgCF viVdaBZ8pv7IHLEwGur5LIOO46hDkhPseCy9JN51kPpYTEHE7wENgVuHIRsV/3TZpKbY sdwh5H54Ef0nGfZ4sDuWhHoSOTSDTF6iVNZcPbY5+hcEVqJHOUs5pQJIQEmmSOeyIjLQ rLj9Uhwya8ZjOVAL0C9+HRmBG3CZidTbnNRb62GzgpkU5duFmeQYLldEXuoWfk6NXDFI k3yBUyiFq9cVWJcypLWJQLFsAohbB1ATICrxOHRsvJ3HhQsC4dIHt+RGVgXThc5q2Ojh iwqw== X-Forwarded-Encrypted: i=1; AJvYcCVmSfIDqVbpSSisSMQ6Hgi/a41GQUiv3951GsmK45y+onvDk3b8XkL1/EMh0mJ1Jt1KAxxnZOz1nStEMH2X/tKNLuLGHDl33eg8ZWJ/ X-Gm-Message-State: AOJu0YyLrYJKBqD+HtfEyQpmUn0ZV0n43Kh+p6Uj7jfwbosM6xtcyl0R PL93najD2qsuzl1Un6GQs7s+TK7h1XytbVYctQbQ0PVCpo15cI38t6bQyiRo+GA= X-Google-Smtp-Source: AGHT+IHu4RK9r5PLGcNNH5dewJx4wVVzrbLrTch7hody5C+rbtRU8z9ZFO1NVAMzG57d+R+2jxzQDw== X-Received: by 2002:a05:6830:1bcc:b0:6f9:6060:8582 with SMTP id 46e09a7af769-6fa1c4361f3mr590351a34.32.1718162562795; Tue, 11 Jun 2024 20:22:42 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:42 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 12/24] Staging: rtl8192e: Rename variable CntAfterLink Date: Tue, 11 Jun 2024 20:22:18 -0700 Message-Id: <20240612032230.9738-13-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable CntAfterLink to cnt_after_link to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/rtl_core.c | 6 +++--- drivers/staging/rtl8192e/rtl8192e/rtl_wx.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 4 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c b/drivers/staging= /rtl8192e/rtl8192e/rtl_core.c index 08d057ab8f74..9eeae01dc98d 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_core.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_core.c @@ -951,10 +951,10 @@ static void _rtl92e_watchdog_wq_cb(void *data) return; =20 if (priv->rtllib->link_state >=3D MAC80211_LINKED) { - if (priv->rtllib->CntAfterLink < 2) - priv->rtllib->CntAfterLink++; + if (priv->rtllib->cnt_after_link < 2) + priv->rtllib->cnt_after_link++; } else { - priv->rtllib->CntAfterLink =3D 0; + priv->rtllib->cnt_after_link =3D 0; } =20 rtl92e_dm_watchdog(dev); diff --git a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c b/drivers/staging/r= tl8192e/rtl8192e/rtl_wx.c index d131ef525f46..c21a0560410a 100644 --- a/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c +++ b/drivers/staging/rtl8192e/rtl8192e/rtl_wx.c @@ -241,7 +241,7 @@ static int _rtl92e_wx_set_scan(struct net_device *dev, (ieee->link_state <=3D RTLLIB_ASSOCIATING_AUTHENTICATED)) return 0; if ((priv->rtllib->link_state =3D=3D MAC80211_LINKED) && - (priv->rtllib->CntAfterLink < 2)) + (priv->rtllib->cnt_after_link < 2)) return 0; } =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 812aeabb4a52..b48d9d416ead 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1168,7 +1168,7 @@ struct rtllib_device { bool disable_mgnt_queue; =20 unsigned long status; - u8 CntAfterLink; + u8 cnt_after_link; =20 enum rt_op_mode op_mode; =20 diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 1ea7157127f6..b5eb3968581d 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -280,7 +280,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, if (is_multicast_ether_addr(hdr->addr1)) return; =20 - if (tcb_desc->bdhcp || ieee->CntAfterLink < 2) + if (tcb_desc->bdhcp || ieee->cnt_after_link < 2) return; =20 if (ht_info->iot_action & HT_IOT_ACT_TX_NO_AGGREGATION) --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-ot1-f50.google.com (mail-ot1-f50.google.com [209.85.210.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 706B3282F1 for ; Wed, 12 Jun 2024 03:22:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162565; cv=none; b=cX3lGDc0EXAE8pQuRGEiNqRdFzdGGPj70I6uSzWofbljZUUex+amdl6Xbqafm/mYgHQUh5zbyCKeO8P/uPt0IS0EtZW0Q0EoUWPLy8T3uuqvdXz+gNOT0xn6GXgsv39UPM/FngyaSKvX5JSGjSEsJkIKB1+KWSONN82Vu6Q+i1Q= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162565; c=relaxed/simple; bh=d/GLHSk4K2U7JU80kpJxoLSuODyAXPIsWBntT7Ha3+w=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=HDuQZGlO6y+8XH4Wkg50ICipzy3mJ5hPAksnW/NWiINBb/wuAMPPviIxLko9eK2rfmIdP3lWxWIZu7iE2AySBNf23VQkV3nIa+aGZ/kAC6JI4x3g2sFiHHp1+AMzjTbHIIaPFJxx9HnAWsaKWYJHR/vighNUcT8IGdPMA2Pdg14= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=an1DW/ln; arc=none smtp.client-ip=209.85.210.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="an1DW/ln" Received: by mail-ot1-f50.google.com with SMTP id 46e09a7af769-6f855b2499cso3397461a34.1 for ; Tue, 11 Jun 2024 20:22:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162563; x=1718767363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=t8iTeXIWdySRsFuZkHSgHpEI9lD6ZbZRxodFJ0iQZsg=; b=an1DW/ln6LTQSSwA0KJtzrBQ2O4r9xTjSq5g2BwM8naop5MC2WSX8AT/T1DGkOUCtz JbCbKA8WWR9mDmJxme3oPSvVBLzLsZ1EMcfzdy6F8Mm4lXEY4X2CwMQYgWginndvUQtf wOxXjUsyo5KAH6M6i+Wz1sD7Yu52Wk88tNfodOo0nUkxc6weorSpmFtE2lP4KODwFC5E mQ2sNQImTbNIreHG5jPr0dfGg3NO+3VBDCKio33SPXtLkt03FwV2XTZceryVV1PKxODa IZdyyQpW4rlUPCvJ2+/9vCz6izJ2LWHyTdUFgiSsxGoL0QZsbGO3dbboxL3SRt2RGROI Z6Ow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162563; x=1718767363; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=t8iTeXIWdySRsFuZkHSgHpEI9lD6ZbZRxodFJ0iQZsg=; b=lvqChs7ov7qspudOL34a1CJMIarEOMt8df5LM8KbWGlDV+VWuRF7j+QZOmaYCsb8eB bWCPxOUmqGTPThRVV7XKm9uPAmp787QdpeFAQBZN4M4N1lVJ3X0tSpLKzW6DPQdjdJbM 4jzGMZY3DbZOhjveyfaatqyP1Q09xRoC4Z3bYQkyrf2tT+YevGUwZ5fsKOzS8StSkDkE Hx1KTH14QgpLSVVde5ja3ZKWXoU/A1HR6QknyOeXfN1D9keVt9fbSyhapRquJsGUku9y 1/xuTsLEqmZgTbjofOPufVyzu9N6p+BV16QzMArs8vFYKJBb5XXTu3S+Fi+mEQXElJZ6 A0YQ== X-Forwarded-Encrypted: i=1; AJvYcCXrjdIx53I/MGMYgCzGGlVnBDZ7kJ3ojBV7UWUQ0DEy77pcdNr7dSGdo6bnQcCYJY/hsCOn68r1SU2dkN/pVCfRTETctFZV6Xv0tAIz X-Gm-Message-State: AOJu0YypL0iddHKrCA/OWpbjDuLsx0xLRLZ7BBt35676PkkzKUAlbL37 GIY1llWTqFzRDtaNyJQ974Ww5+ekV9D+kn2OZPuI1Wuxi9CcikzZKfGoDp5UYNQ= X-Google-Smtp-Source: AGHT+IGgZ8FKR+wy88PA9JF/snS/F09xgEthe5Q+Zz4XhVS7QFzZGoEv67GT4nT2eqA2TFV+R1wNlA== X-Received: by 2002:a05:6830:22e4:b0:6f0:cdca:5619 with SMTP id 46e09a7af769-6fa1c444f2cmr559524a34.37.1718162563538; Tue, 11 Jun 2024 20:22:43 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:43 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 13/24] Staging: rtl8192e: Rename variable bUseShortGI Date: Tue, 11 Jun 2024 20:22:19 -0700 Message-Id: <20240612032230.9738-14-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bUseShortGI to use_short_gi to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 8dec4e1b89b8..f38d172ddb4b 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -859,7 +859,7 @@ static u8 _rtl92e_query_is_short(u8 TxHT, u8 TxRate, st= ruct cb_desc *tcb_desc) { u8 tmp_Short; =20 - tmp_Short =3D (TxHT =3D=3D 1) ? ((tcb_desc->bUseShortGI) ? 1 : 0) : + tmp_Short =3D (TxHT =3D=3D 1) ? ((tcb_desc->use_short_gi) ? 1 : 0) : ((tcb_desc->bUseShortPreamble) ? 1 : 0); if (TxHT =3D=3D 1 && TxRate !=3D DESC90_RATEMCS15) tmp_Short =3D 0; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index b48d9d416ead..54cf5ee628f0 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -112,7 +112,7 @@ struct cb_desc { /* Tx Firmware Related flags (10-11)*/ u8 cts_enable:1; u8 rts_enable:1; - u8 bUseShortGI:1; + u8 use_short_gi:1; u8 bUseShortPreamble:1; u8 tx_enable_fw_calc_dur:1; u8 ampdu_enable:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index b5eb3968581d..d46963fe9bbc 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -335,15 +335,15 @@ static void rtllib_query_HTCapShortGI(struct rtllib_d= evice *ieee, { struct rt_hi_throughput *ht_info =3D ieee->ht_info; =20 - tcb_desc->bUseShortGI =3D false; + tcb_desc->use_short_gi =3D false; =20 if (!ht_info->current_ht_support || !ht_info->enable_ht) return; =20 if (ht_info->cur_bw_40mhz && ht_info->cur_short_gi_40mhz) - tcb_desc->bUseShortGI =3D true; + tcb_desc->use_short_gi =3D true; else if (!ht_info->cur_bw_40mhz && ht_info->cur_short_gi_20mhz) - tcb_desc->bUseShortGI =3D true; + tcb_desc->use_short_gi =3D true; } =20 static void rtllib_query_BandwidthMode(struct rtllib_device *ieee, --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-ot1-f43.google.com (mail-ot1-f43.google.com [209.85.210.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5340F5A4C0 for ; Wed, 12 Jun 2024 03:22:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.43 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162567; cv=none; b=iKOV7q0pb+7bh0Qs2gisdM0qlnxh8v9oaL2JuGR1Mwr/m5i6oxdKihmjnEOhBS8Eq8Cq+1237M5z7obmalBTdV/G/Au/e+FjpdFRCkuFZ8YMYBJBYWXPWnmCVTdqp+a6HXkZdTckgUOfIytIGVwSLFnBSIufVQapofjWJMFYZWo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162567; c=relaxed/simple; bh=zJhkNdPgm9Ule1PChKDhhPWqoRCFvb4zAD7FJ7GBYus=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=O5cVEO8gtoclM9V6cemNVv2fzjU3+QCb1WvqHQmyOtsdqzXATSP9640q01aycKE5ljAh/7GJqEo01Jilh2cRFMj1eejx/I9lGI9DLdQkZjPZRkMhb9wDCMOInbvQhbn1vAjmGE0dnNDUpTw41xvHe/sXEXs1/ivL50cVD/67P7s= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=dqc7/0yr; arc=none smtp.client-ip=209.85.210.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="dqc7/0yr" Received: by mail-ot1-f43.google.com with SMTP id 46e09a7af769-6f9fbec4fd9so788203a34.2 for ; Tue, 11 Jun 2024 20:22:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162564; x=1718767364; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=KjAz9q75b4Ze8yKWVjcn/FNlgPRsBeKVRN/bGRj7ze4=; b=dqc7/0yrZEsf2SclgY/n9qvZryPZCB+ruOSnG5yh+CeC2u6HjGTd1zgqIGwt1dS7xu YXb83MFo+w0nxU9Nt/BKbkqVMb3lhaB/SSHPvvWZir6Gigl7pqFUyAhibZpV+wGOrIpE 5m7sH6MeCaVOaO1bS2XlYkmtLuz4OOgwTgtJnTXENQg8mrctLhOZx87JJ9azHKPszZ2n HOVSBQ50kZrIBDvUoFN3RsIpG9XO3yuvnQxpxOWNcQ18X3nivGlsyyF2Zww6WxXy7Eq/ N65vTGIEyqqu79w/zta2qIXr2svVPtcl1PTxj3P2V6uxJ/aS3md4XotIrvAYaTvhaCGj 5FWA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162564; x=1718767364; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=KjAz9q75b4Ze8yKWVjcn/FNlgPRsBeKVRN/bGRj7ze4=; b=SmhzR08AM0ADrMRXoNLmqctF4zScTURm+yFIdL3IToHPpblMwVL0puUdKlYhJAkQAR 0mIx7PelyaOh6AfdX33ns6HnH+2jAZKn/Zb/lPkP+h7R0TOn8otUiHhipH/zOc354f/W HHPjtYxsZWz7n7U7v58WghFg8K+s7GyjK08YTPvUS/TGMczrXtqnAnPhxUusA9nxB/ab AGqjgxZ0TMcF4zoL2xRz9h38a26p4HD5AfyZ7C0jqS/JPz9v2X5dyfhwtIVVc8J3tEey zVpOLkXMnoHqZFYkQEpsA9a24s5HoU6xIfMkec7hsiGKd2zi4RE8wxh4jarQaS/tuApG KU+g== X-Forwarded-Encrypted: i=1; AJvYcCVfztls2kCRZeYh2+NtOvyDURDlL1tgjw6Ub8mOxkygJEmYaY8kb1kHfI9rvZqnBTp+5kr7sO3QP/4kYdTEgdPo8DbJ4kL6F10n4oeQ X-Gm-Message-State: AOJu0Yz/u89aw23myEG30MK1OwOV0lA4h7NOXBtZkb426IuEPMfcQxuP vYQNpwAOOQCZJYAXqnTk3JhKVesixPTjrB0jXz8ZE910x4ObuaepU4+vFW2Jppo= X-Google-Smtp-Source: AGHT+IHXzsUbD3hiUa31hFAFrbYvZNr5A8pj4kxldfs2e7njUiR6drW5I4rub3AOvwcD+2ZqiMa4fQ== X-Received: by 2002:a05:6830:14cc:b0:6f9:76e8:15c1 with SMTP id 46e09a7af769-6fa1bf7ed24mr569978a34.16.1718162564380; Tue, 11 Jun 2024 20:22:44 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:43 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 14/24] Staging: rtl8192e: Rename function TsStartAddBaProcess() Date: Tue, 11 Jun 2024 20:22:20 -0700 Message-Id: <20240612032230.9738-15-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable TsStartAddBaProcess to rtllib_ts_start_add_ba_process to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl819x_TSProc.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl819x_TSProc.c b/drivers/staging/rt= l8192e/rtl819x_TSProc.c index 7cdeca7ed8c2..ed6a488bc7ac 100644 --- a/drivers/staging/rtl8192e/rtl819x_TSProc.c +++ b/drivers/staging/rtl8192e/rtl819x_TSProc.c @@ -431,7 +431,7 @@ void remove_all_ts(struct rtllib_device *ieee) } } =20 -void TsStartAddBaProcess(struct rtllib_device *ieee, struct tx_ts_record *= pTxTS) +void rtllib_ts_start_add_ba_process(struct rtllib_device *ieee, struct tx_= ts_record *pTxTS) { if (pTxTS->add_ba_req_in_progress =3D=3D false) { pTxTS->add_ba_req_in_progress =3D true; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 54cf5ee628f0..a35079f6dc65 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -1770,7 +1770,7 @@ void rtllib_reset_ba_entry(struct ba_record *ba); bool rtllib_get_ts(struct rtllib_device *ieee, struct ts_common_info **ppT= S, u8 *addr, u8 TID, enum tr_select tx_rx_select, bool bAddNewTs); void rtllib_ts_init(struct rtllib_device *ieee); -void TsStartAddBaProcess(struct rtllib_device *ieee, +void rtllib_ts_start_add_ba_process(struct rtllib_device *ieee, struct tx_ts_record *pTxTS); void remove_peer_ts(struct rtllib_device *ieee, u8 *addr); void remove_all_ts(struct rtllib_device *ieee); diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index d46963fe9bbc..6514d53c9679 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -301,7 +301,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, } else if (tcb_desc->bdhcp =3D=3D 1) { ; } else if (!ts->disable_add_ba) { - TsStartAddBaProcess(ieee, ts); + rtllib_ts_start_add_ba_process(ieee, ts); } return; } else if (!ts->using_ba) { --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA47C6F077 for ; Wed, 12 Jun 2024 03:22:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162568; cv=none; b=JGKqpkTug5zEfNp1nw/Yp8mtuYNvXPmUgATTjLB3Pq19r3oYRxpMuVj/kIuT7A27Pz+BTBcVOLm9o0tDE4FQb07gwDL5RjJ7Q7632v84O9Ct0lDJlghfyin/iIUnQK2ktnEFd5OvcDY22akxnxb/5ohseyqD58O/kYi9neFf2qw= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162568; c=relaxed/simple; bh=ntP5CddFKzxSIvMkfKkjwYRPCYeJfHWhrugRVal2F7E=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=Zk6K1WxENoMWqVDv9CRD96k36XtWe2zYcAZY9mmNfUi7iUArnzIXJzSGjxyuONHV6WPhy22/qvi0RYZziOh/oRBJJJDe+r2wLe6sp7lh8G7GfMjtA7pL3gt6w0csaDgbYMCyJvIIRP69pv1tYFqst3/xDJPNskyx3fGkULYuYlg= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=H3dFIRgE; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="H3dFIRgE" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5baf982f56dso1714077eaf.3 for ; Tue, 11 Jun 2024 20:22:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162566; x=1718767366; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NCKBtGjcOvea+CqwVQjR7UgfHciXiKLeVB+o0+sSG38=; b=H3dFIRgEOCPv+BExN29HbuIbFL2rXcjd75OAH9KEdSMqnU83YrKvY59JQ8NkXBQ0zZ y3GIK1xU2FlWY2hCcQZmBrtCZ0iUl70f2QY6jwdaOI8DVs3JALX+ZjitUxZx2etvtgNa ju0rOlZVZYqZ3qg+To3LGAuvAbE9+M5+SpFqrfbqqROuxqEchtFY15oUOkQTeyFBdPWK cIFriZC9ghaLJx7GakWMO7PdPhluh40GZ8BSR47LvLWeaMy7cCS4KQhvEPcl1kmF0zHU CJP9XkF2ajggyCFKHK5VZ7XGb5yj6t3+MlzexZJA67YXGFIzXVEppXN9vZXNXj1vuLce ZV2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162566; x=1718767366; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NCKBtGjcOvea+CqwVQjR7UgfHciXiKLeVB+o0+sSG38=; b=gYowIVdxZBgbnd7ygtcfk7Xk6uRGe/F7Kkv1s1gqYwOyu0IJY1s8zHLQQk6E6rDBwf Gsyv/Go9V5jPLrfLga0B5SqQXhSosd95AtCw8eiq725e2dgDmzTGAC0dTSK51et9BfDO hRsTy0PQh9cAAxBBe68lKyOqItOmPZVhv1/epNj4GNzNQTUV1V2Q7Jh1Bezgm8Jaax4R vaMeHYAp3Rc3VsqNL4NmewCIt1+ozR0Fgc3cs+VipwTAGLE2+FR3BXj4Jl5/uscbDJFX j0xNouZsvFk8ap1xKCN5L+uBVr50oTD2CDV15e2HJ2CIA0OXXKrUclLm3zRwJfoWyKGc iaMg== X-Forwarded-Encrypted: i=1; AJvYcCVzO0Jnn1PhIQ/3wj1UYmFgeXuwsLXkw8rmJ3y2IHnYCVUtbFY09LU0SMTnWglejj+y7AuKMrDNoczqMk++C6r4E/QBvKAXEGSw1Z8L X-Gm-Message-State: AOJu0YzN+7Mtsoo/jLT2/VcV0FRRNZYEx7NBYVaB44X1O5cmteUlmpzK 6V0f+/dah7sKj0gMJP1Q/EZf6YM9in27cTmWZcgROIWoV9TBfWZwhOd+dTpQeaM= X-Google-Smtp-Source: AGHT+IEq2ayhxxtHGON6heGtAGEhhMCRP+iqH2sPnHGV3IfxIOg0c3o/rSjd+rEweEURdDIj0r7y5w== X-Received: by 2002:a05:6358:914c:b0:19f:1e0c:e1a3 with SMTP id e5c5f4694b2df-19f69d7b6dbmr94139655d.22.1718162565777; Tue, 11 Jun 2024 20:22:45 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:44 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 15/24] Staging: rtl8192e: Fix alignment to match open parenthesis Date: Tue, 11 Jun 2024 20:22:21 -0700 Message-Id: <20240612032230.9738-16-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Added tabs and spaces to fix warning: Alignment should match open parenthesis Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib_tx.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 6514d53c9679..24ae90915b10 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -290,7 +290,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, return; if (ht_info->current_ampdu_enable) { if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&ts), hdr->addr1, - skb->priority, TX_DIR, true)) { + skb->priority, TX_DIR, true)) { netdev_info(ieee->dev, "%s: can't get TS\n", __func__); return; } @@ -420,7 +420,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, u8 ht_op_mode =3D ht_info->current_op_mode; =20 if ((ht_info->cur_bw_40mhz && (ht_op_mode =3D=3D 2 || - ht_op_mode =3D=3D 3)) || + ht_op_mode =3D=3D 3)) || (!ht_info->cur_bw_40mhz && ht_op_mode =3D=3D 3)) { tcb_desc->rts_rate =3D MGN_24M; tcb_desc->rts_enable =3D true; @@ -476,7 +476,7 @@ static u16 rtllib_query_seqnum(struct rtllib_device *ie= ee, struct sk_buff *skb, struct tx_ts_record *ts =3D NULL; =20 if (!rtllib_get_ts(ieee, (struct ts_common_info **)(&ts), dst, - skb->priority, TX_DIR, true)) + skb->priority, TX_DIR, true)) return 0; seqnum =3D ts->tx_cur_seq; ts->tx_cur_seq =3D (ts->tx_cur_seq + 1) % 4096; @@ -548,8 +548,8 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) * creating it... */ if (!(ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE) || - ((!ieee->softmac_data_hard_start_xmit && - (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) { + ((!ieee->softmac_data_hard_start_xmit && + (ieee->softmac_features & IEEE_SOFTMAC_TX_QUEUE)))) { netdev_warn(ieee->dev, "No xmit handler.\n"); goto success; } --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 68FB9763E4 for ; Wed, 12 Jun 2024 03:22:47 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162568; cv=none; b=G8otMam8RVOenKND6ReIcRJiiiQekI2xPyhX/hBn6rdGk82YrLnVdPP6N7HnD9Hg3g97Jeb0qXwWgEWGmoPvrhlNv7Y0hrbbD+6h+XqQgiXj/Ie6SLWeJSCryrWeZ117UWZtkfJ0u+u8k6NEVYbQluLvVqzZkM0+laVUqf5JOeA= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162568; c=relaxed/simple; bh=xqYhFHFq3mDjhjbf+ydGJnOq96SvYxfTi4zxwowpm20=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DPB5O1yZuv87JhvCVraX0R8idpdsIhyj2df5+1xLW0e35ZLs6iIzGHFrO+zSLkfhWemg3sjZCTBBZHcHddBdFlDkCFa0qwMUsi0uLToJ6IaPiaqwOmDjMMg0tqMjtlRDda4EQRkBcMPtMte4N/KTYLpZOVy2r1Kwd2DfQqGMDYo= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=mHOP3CEe; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="mHOP3CEe" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-6e40ee57f45so1483054a12.0 for ; Tue, 11 Jun 2024 20:22:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162567; x=1718767367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/+OGqMxIyTYTRN2LvPValmPFKV1Pwn8huMgM/8/nKaY=; b=mHOP3CEeRVbz0awQdg8XyiR1+GR89/1f7dEIEEepCyIfOmff9J17LwUfbV4FmsZ4WP QFqOL5gwPuN4rNjSmB2p5qaQSi9xdbZZVpmoYD86L1TbwahcXSRrPxrqktVRTw6DvMOl NJ53htbrcTa/5o5IYj+e1yShbVFz6+bjgplEJzBy35hUQk7kUXLISLU/JL1wVvRaVDnc n/6pAgLSsm4QFg9aCRj8Z8IHX/K0d3IebxY7jnuGB/US43j1b65MQ/Dr2+IJtnwxD3fC /P8iiteBBW7cCivj5KfpFMDugpNDzFHdHWoyAGOaN59wn0OgwpipHvTFMEqfcpSx31FS WKjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162567; x=1718767367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=/+OGqMxIyTYTRN2LvPValmPFKV1Pwn8huMgM/8/nKaY=; b=g1lyjK+Y1oMY5/Xj1cy+J4kPC+Nuvp21pq4FwSZ5IKy79YKLe8I5uhaYDtc1Z4uf1g IHWRensgbcb2VhpRXJt/FcdVJXKIM3lNRp0f0V0XNBI5Gfhf/DYLzWLhronGONs6e4F9 B5GgJ0mbRHYSrYei8RoBJZraajOvAEm4g2h4dkIraRRE/evsf2z4sQD9bjvNwrEDybp/ ImuQnsgAGey/KRiySagdNriDCaLvigt+S76gRzISTwfnece83paO3+A6e/tl2Dvmzmlf Wn7GlGF+gJHyRx31PUcv96CSTDl5HZOs3TAaGnw9dLoZhKXmpIhgWuB7AnzMLDxZ0ymc Ntpg== X-Forwarded-Encrypted: i=1; AJvYcCWlqxZmrmsDGHhpdvr0sFFxdKMeJoNQNc5+GG9jeXqYPauqGMYIEncZJfHdZrKpE2fkbO2gy37L2caFiSe9i5CKt52QeQTEgGvQiE6Q X-Gm-Message-State: AOJu0YzZohBsJyBDLzH9/YJBjs8QZiAHHE1eYfTrGyb3nIKZZlApZIPb 1DjOwoLijJehT7h2OKA4KH3JJLgdbGzO1bmg3AsLV+7uP1pzS/WqiCR5CcW3nn0= X-Google-Smtp-Source: AGHT+IEZP/8LQIrVJ6fkZMgUyIwe3/bpxWI3Eq9BKhb8OVPt/JCV+CHgIa+UVL4HfOivalNdMRFykQ== X-Received: by 2002:a05:6a20:3caa:b0:1b7:f59d:fd12 with SMTP id adf61e73a8af0-1b8a9e7f04amr1064259637.55.1718162566665; Tue, 11 Jun 2024 20:22:46 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:46 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 16/24] Staging: rtl8192e: Rename function rtllib_query_BandwidthMode Date: Tue, 11 Jun 2024 20:22:22 -0700 Message-Id: <20240612032230.9738-17-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function rtllib_query_BandwidthMode to rtllib_query_bandwidth_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 24ae90915b10..06c3166a5b47 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -346,7 +346,7 @@ static void rtllib_query_HTCapShortGI(struct rtllib_dev= ice *ieee, tcb_desc->use_short_gi =3D true; } =20 -static void rtllib_query_BandwidthMode(struct rtllib_device *ieee, +static void rtllib_query_bandwidth_mode(struct rtllib_device *ieee, struct cb_desc *tcb_desc) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; @@ -872,7 +872,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) rtllib_tx_query_agg_cap(ieee, txb->fragments[0], tcb_desc); rtllib_query_HTCapShortGI(ieee, tcb_desc); - rtllib_query_BandwidthMode(ieee, tcb_desc); + rtllib_query_bandwidth_mode(ieee, tcb_desc); rtllib_query_protectionmode(ieee, tcb_desc, txb->fragments[0]); } --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 511847D3E8 for ; Wed, 12 Jun 2024 03:22:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.180 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162569; cv=none; b=sDu+izn6J9HO8O3oOLn9fCz4nnhLAZacZH5J3b4VB9WRZOB2zgmD1rV6iwGnce8Zv5R7VyWZdd/4ydeN3DLZF95l6QBqB7yG1Spx+2fZMBsW40imltEQlddNRugdQFYGPbWsKsEIGsx5g3X6VDodBtFqPyb/JbFRCBP75256N6g= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162569; c=relaxed/simple; bh=PMBr1YYNuZJA6HyrdZulTQpmDuqmO4Ov8c7SotPvG2g=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=FsvzGbofWHJ4m2b8gWe1Gg0y9my0+eWnj+/118Xny3bjlNoR1Hqsc4AhioQ931TrwEz0R+7MHizeg5pD1/ONI1L1eEqvQw8lCT6XC+S7ydbbGAp4JlMoF2EzEZppufR0QlEtN9mOVQoGIHzvLYSVaKjvrjS21xvtZ6lhFebwHis= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=mC4JRqdR; arc=none smtp.client-ip=209.85.215.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="mC4JRqdR" Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-656d8b346d2so4598748a12.2 for ; Tue, 11 Jun 2024 20:22:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162567; x=1718767367; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GRT6W8iVB5TH/crkmlwaDlIVBxRo8bFFTV9sN1VFjZc=; b=mC4JRqdRIx6S/JYk2QiJTkGurdiyRcxj9+UQfY8K0z5LERcYSMjnjhbJBrnH2vVr4S TdtLwkKmKxvK1AjpTcsdadgVfG9AjE343/BwduqBqUNTlTccUvElccRmFl2i1nBzs1co v2KNedNwlCcIDeZsBaXMIZiY2PfiWZPpqhVnmQH2/bj5oHfBhWIxIMDIATuG33+EGShJ i1oxy5WS2Z0wuh9A3mjJnDOwSFMXH/DfK1Hsh+SitPEhaTlrAdstwj2Cc/08WUnfisUb 9CgjR2slDXVGqJH9Iids7jVydihagOd+npeF4OdaQHLh48s4Lkk5CCX5vASLA5FhoyqK oASQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162567; x=1718767367; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GRT6W8iVB5TH/crkmlwaDlIVBxRo8bFFTV9sN1VFjZc=; b=kNVbl9uhpdbu505DWj42bSPVM62rokv7O9lwAzOmhtuQFPCt36SuRXoWp5RcMLaJyl 80yi4DzKHjpNA1v+nWzSQmq/UZpG+fwzRFwKOkXwCZrVuePJHGHJtBbW0Zc6RsNTuath 6N076LYjXtO4VOiKPwkg6drfN6ZjqJWmNpgQgCcF/DMVYypdvduuBYumrz25jI+ekusE zSuvPMIFuRVZrv0ahkB7vlQCQtkUPdJK0IAB3Kox4+0LOmlJpp9cdVR+C+9IcOfU0FO3 Lfc86MbnmEfKfiZbOerfsfT1z8pm7cbildFTOvw1QYi2cUiUM4i4HJXe7bifNi/2JmIw Ngqg== X-Forwarded-Encrypted: i=1; AJvYcCWluoUQlPmf0r0PyoomN0TaoLGK8ci/VlkJigrrRvUhD6gfz5dhkycSGQQiPDcZF4weJI1sqSYkRUjlIKx/iEE8HKRrdKnSXJOJWbX8 X-Gm-Message-State: AOJu0Yw9ZcGfcPzFThhNkRJ7mZPe7OlfBMfnfpV91qTpVFuvkayhbVkr PcwrV+sN2FIeAPdHfIceALvCiRklrnLQslr9QGCDxJDUVYC7m340ArPtG/LWTEo= X-Google-Smtp-Source: AGHT+IGZdQyolydFOX1yTIyzNKpwzTfV5AzcpkckaHLJKdXgYjzu4RuXNrxgsTNujadAQhl/3iDzyQ== X-Received: by 2002:a05:6a20:3d8a:b0:1b4:4568:4c3e with SMTP id adf61e73a8af0-1b8a9b77ac9mr892626637.9.1718162567564; Tue, 11 Jun 2024 20:22:47 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:47 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 17/24] Staging: rtl8192e: Rename function rtllib_query_ShortPreambleMode Date: Tue, 11 Jun 2024 20:22:23 -0700 Message-Id: <20240612032230.9738-18-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function rtllib_query_ShortPreambleMode to rtllib_query_short_preamble_mode to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 06c3166a5b47..93b9f0609428 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -319,7 +319,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, } } =20 -static void rtllib_query_ShortPreambleMode(struct rtllib_device *ieee, +static void rtllib_query_short_preamble_mode(struct rtllib_device *ieee, struct cb_desc *tcb_desc) { tcb_desc->bUseShortPreamble =3D false; @@ -868,7 +868,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) tcb_desc->bdhcp =3D 1; } =20 - rtllib_query_ShortPreambleMode(ieee, tcb_desc); + rtllib_query_short_preamble_mode(ieee, tcb_desc); rtllib_tx_query_agg_cap(ieee, txb->fragments[0], tcb_desc); rtllib_query_HTCapShortGI(ieee, tcb_desc); --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f42.google.com (mail-oo1-f42.google.com [209.85.161.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B22838002E for ; Wed, 12 Jun 2024 03:22:49 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.42 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162571; cv=none; b=Brc++oEqpj4NnVx2Q+wAZ5YcE8zPwJk+dq8jiUr5te6UBdKijn7jjyRUeXcQnfHtan6GI950PXjG+raykxeQQYM5ZCxoAWlDrEaendb+VlU9E+gZ+spPfLZKLPSPO23eUGKTGtAvjDmwwJ6+C9ic/pLfeezCv/su8xvCaxQjlF0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162571; c=relaxed/simple; bh=mipjevFOZ2dmGJOw6Kz0lN3TbrBvmglYVOnhL96glEE=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=c+p/RZwVOweZbWSYcsrWd6CzgYPQLLhKeIChcFwGDKwR5GlpVGZlK95SHCO48ugiLkV3TpxqNyFvT/J+/43qeNyJ5rYdv7tcMJ+I7iXkOZafWiehxILOQEuCRyfJ8VgLx8LmMNaBL6TdwyvF7Hqo43vqRePAdCFAZHYc9x8RmKQ= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=HFDlC0So; arc=none smtp.client-ip=209.85.161.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="HFDlC0So" Received: by mail-oo1-f42.google.com with SMTP id 006d021491bc7-5b96a781b63so2368133eaf.1 for ; Tue, 11 Jun 2024 20:22:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162569; x=1718767369; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=5mN2Oo5HuRfYFaYNQRaLC/1WniMLC8Zh3ZlO0PShWS0=; b=HFDlC0So1ksFFS8RsrCHvLX5DGs9ivjD/cUw6iBEizr4nXOXcPy+ZMa2C9uTBlfw7w 4F3rBf94uwfrDONYkEe5u4AKMl1qoen3ROgZnLIebSYQWRmD6kTe+SdOrt/dqTyWaVKh 9fFbHoCXk0Tnvi5In5lZqeZpj3HA7ZWaB8l/9NcJOtf4l+dBTAcxutVBCbf9yHxnSII4 mtkkH2Ucs2HpCqfc962SIifuE8e3IXVHHuayYfEEHm8ij18Qv4dLh96i+xS56bnDMIRB dfdvrqxv50kx/gM+FY168V3IUY8ZWv+34B8svCZl6JUIhYOa058p0zznneRCYf8X/VEH pdsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162569; x=1718767369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=5mN2Oo5HuRfYFaYNQRaLC/1WniMLC8Zh3ZlO0PShWS0=; b=Miq/Fu+xAtockiSjUv4B5ALkYpKzh3ChpKK66U/1UqBcTGWQWsxzYX0rjjeBNgBC2l 2kTKvTquyeWnEkbD1PRmHblQr4Q8Gsd0UwHvcaW+c92Q9jw5tx3DklCIviWhKV4p8MgW KwI6qiDJoYHqYJmun1QZsOuIw/oTrFimSsraMnaL9jdO4+iD6wumWpp+DbRzTHE7MBpm Hgi+Y6CJ6wcY65QYdO4u+8z9fo+OI6kaHrK/NXiycfnmY/3s/QPCWvLKkwS6gNBmIH3T 6TqRuCWVpji8FFQK5yflTNQej+7bZi+qDYqWrwS/7kxN8DLsLRSsd5wxPHW/pQBpE+C6 Fyhg== X-Forwarded-Encrypted: i=1; AJvYcCXlwziZNkd/rz6lJ/7F9ZWK8WmCWqbeRcl9P8o6ZZlnDFykXXBig7ZLoaXgr8yxlyrjpyqxBWALqBwoVaL0rjUyZKo/Ap+UM0hwPOV2 X-Gm-Message-State: AOJu0YzNPI9XFgxB/6VAIc0wiD5jzZW5iog8Jh4qURdIRAuEecDMWeNn k6qWMrA2kR2NHloXT8rtpP7amm+Js5k/pZQYBiVIECwIWi33ww54es6nll9fwpsWN8Hs+fBB3ip y9os= X-Google-Smtp-Source: AGHT+IHHrQEiUTsBKjWQW8t2x2dF0rfY+q0Yk+bIn3X2BUvy8WXZn5NIHh+HdzxMfQcp2PFaUBVHlA== X-Received: by 2002:a05:6358:9106:b0:19f:4d5a:c688 with SMTP id e5c5f4694b2df-19f69d2ca8fmr72735855d.15.1718162568669; Tue, 11 Jun 2024 20:22:48 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:48 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 18/24] Staging: rtl8192e: Rename function rtllib_query_HTCapShortGI Date: Tue, 11 Jun 2024 20:22:24 -0700 Message-Id: <20240612032230.9738-19-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename function rtllib_query_HTCapShortGI to rtllib_query_ht_cap_short_gi to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 93b9f0609428..6a979151d1d0 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -330,7 +330,7 @@ static void rtllib_query_short_preamble_mode(struct rtl= lib_device *ieee, tcb_desc->bUseShortPreamble =3D true; } =20 -static void rtllib_query_HTCapShortGI(struct rtllib_device *ieee, +static void rtllib_query_ht_cap_short_gi(struct rtllib_device *ieee, struct cb_desc *tcb_desc) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; @@ -871,7 +871,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) rtllib_query_short_preamble_mode(ieee, tcb_desc); rtllib_tx_query_agg_cap(ieee, txb->fragments[0], tcb_desc); - rtllib_query_HTCapShortGI(ieee, tcb_desc); + rtllib_query_ht_cap_short_gi(ieee, tcb_desc); rtllib_query_bandwidth_mode(ieee, tcb_desc); rtllib_query_protectionmode(ieee, tcb_desc, txb->fragments[0]); --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5475780C14 for ; Wed, 12 Jun 2024 03:22:50 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162571; cv=none; b=oaKTsBLaUTNt0WEjdyZZyb5moBXogrpYwvjCubT8ePbxtRlCyCjT9+jQoBSigtJyGj6/mdQwuIFUWRMMgs5qltF+ubiOmZJft/ZAbZMsQe/Ui0AQHI88or47XWRYsRisso0dX5+wDCKC6QY1m0GGKCBgOi9ezW62BCHFND6cmIY= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162571; c=relaxed/simple; bh=1HQdO3CVCBt1jv7/Hcgi7TyzvW2t1arGQSRLfS88Mxk=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=hprgkc5yrIJCmW69udXxNYjmX7SMIbuSNRwNCAdeToJ3BSVFY99ATDd6ImLeHWDAJKD7sAlk4wpe8CiaiNJycCg/+CdNh6hXBA50ldvLH6y+aG6xGtPLF9wq161bdK1izCwGiuTs3vcTmwZyHXZfBT/TLD2UZG4Itb2vB9m6BBw= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=H9GGNvhR; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="H9GGNvhR" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-70599522368so1512486b3a.2 for ; Tue, 11 Jun 2024 20:22:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162569; x=1718767369; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=LNlXJ31YIbCQqnMFI7ayEiu4pLngypLxNb6gVxuSZNE=; b=H9GGNvhRHTsgXzJxRLFl06Rp7Bf1i6J2CVUQ4b5yjxDMihNzHDWkUA492uQemncgx8 FiA/TSeboHhH/6ATPOqGGj3AiFGEXcaHKzHNyF+Ode2Vc8DnFTkBuR2Wlj38bXua+JJU mSyqgy1UmFXR6kKhhk6isfohHldrgLKvDcCSJetPFc9AUXepm7zeIwED/SHghce9/FP7 3NaDd0IeR3lRGfBSqd5YNDzmqhDcHUIFr9pgLCLZi1mxPTpLFnypXU4XMmDZVgfPx6Jg keCQutEO/sS5JKCbjAgvZ8+ClhjYPfzm4M29LhkMX8NiYOIs7ZK+TDDz4Law6eOSmA6s UZTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162569; x=1718767369; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=LNlXJ31YIbCQqnMFI7ayEiu4pLngypLxNb6gVxuSZNE=; b=mHiuqkN6yv/VaKUIuedTO0xcKUbtgKUbGdEeg0emUifZOzrL1YGBf5himgGlJiWvwp fsAEK3ozRKtsU0klNlw9ur2wkJ0Vy68y0FEY8wiXEoOU34+1AmLGBogPvWSY9WGPpqUF YrwvJn03RHErp1/QDMV9KgkcAtT0hAwuWrLtN3aSVqwOt6eVdTONZSPJzSh8UcVVZoEx 2W4ezqmhzGfdr4CRLaExpB9+03gV1/q4t8FCoeimGVzBe26ahSSm5OLeT+zphbxJyzf4 FIStlJ8DHPEinxUrBPPkMPYp0unxTAA2mPdF5+MdhViuhRGE3qsN3FxcxkKyGiVGvqBz NKwA== X-Forwarded-Encrypted: i=1; AJvYcCX/mChBBWzm3JI0zmvXKIoPNnJ/2Ww7sx8UShqJgEC/mlE6YPcsxMoFS3WwHUFHJyDdu5nb/jF8VQzK5RvZGEl8QYI1lRs74HGOdzLM X-Gm-Message-State: AOJu0YxiXj8tF7stfQsNxogfTOb23HITmqJ6rBoqnZ+ebO8+LBkayIfq mAy448QB+OuD7PxwTESrAgsh+9LqVb0XBBHeyw6qDZeI5i3wNYqrNUn2oNADRQ4= X-Google-Smtp-Source: AGHT+IG3eAhcKdCbyYwlrRUkf+6AyYpjJl/kQQ5xhFG3MVQzE6WHkQiC47DK1qgkL8VZmL8TcTQ1+w== X-Received: by 2002:a05:6a00:60c9:b0:705:c029:c998 with SMTP id d2e1a72fcca58-705c029d008mr96466b3a.3.1718162569523; Tue, 11 Jun 2024 20:22:49 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:49 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 19/24] Staging: rtl8192e: Rename variable bUseShortPreamble Date: Tue, 11 Jun 2024 20:22:25 -0700 Message-Id: <20240612032230.9738-20-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bUseShortPreamble to use_short_preamble to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 6 +++--- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index f38d172ddb4b..46e42fad5834 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -860,7 +860,7 @@ static u8 _rtl92e_query_is_short(u8 TxHT, u8 TxRate, st= ruct cb_desc *tcb_desc) u8 tmp_Short; =20 tmp_Short =3D (TxHT =3D=3D 1) ? ((tcb_desc->use_short_gi) ? 1 : 0) : - ((tcb_desc->bUseShortPreamble) ? 1 : 0); + ((tcb_desc->use_short_preamble) ? 1 : 0); if (TxHT =3D=3D 1 && TxRate !=3D DESC90_RATEMCS15) tmp_Short =3D 0; =20 diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index a35079f6dc65..61d383a560f6 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -113,7 +113,7 @@ struct cb_desc { u8 cts_enable:1; u8 rts_enable:1; u8 use_short_gi:1; - u8 bUseShortPreamble:1; + u8 use_short_preamble:1; u8 tx_enable_fw_calc_dur:1; u8 ampdu_enable:1; u8 bRTSSTBC:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 6a979151d1d0..1aad5253ae4e 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -322,12 +322,12 @@ static void rtllib_tx_query_agg_cap(struct rtllib_dev= ice *ieee, static void rtllib_query_short_preamble_mode(struct rtllib_device *ieee, struct cb_desc *tcb_desc) { - tcb_desc->bUseShortPreamble =3D false; + tcb_desc->use_short_preamble =3D false; if (tcb_desc->data_rate =3D=3D 2) return; else if (ieee->current_network.capability & WLAN_CAPABILITY_SHORT_PREAMBLE) - tcb_desc->bUseShortPreamble =3D true; + tcb_desc->use_short_preamble =3D true; } =20 static void rtllib_query_ht_cap_short_gi(struct rtllib_device *ieee, @@ -440,7 +440,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, goto NO_PROTECTION; } if (ieee->current_network.capability & WLAN_CAPABILITY_SHORT_PREAMBLE) - tcb_desc->bUseShortPreamble =3D true; + tcb_desc->use_short_preamble =3D true; return; NO_PROTECTION: tcb_desc->rts_enable =3D false; --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oi1-f178.google.com (mail-oi1-f178.google.com [209.85.167.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 38F86823D0 for ; Wed, 12 Jun 2024 03:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.178 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162572; cv=none; b=eNu9f0SCF3vl83qfpDgkAh2bWcXq4cPzNMqQc8GDKgQsvL8MOHpmRFTH2X9SFUNR5S7Ze/Xq7jcrn2dI9WbQxMJDu4qIJyzIC0VsOOo5Q0nnR+eumSb95tZttRLGFx1xZZzfsjxwcT/dS6cV+UNXfr05uWhlZPQ7dcRVq8HWft0= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162572; c=relaxed/simple; bh=c8MR3plf46KFfyFHzwWDM6RMkQukkKt3JMAeSqgetE8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=cEAxMNXN7UYtLumrLMUYtyfea5Odu5Gc2ST1TiGOpBKGwsjDkUdcrI5ZZpozhz1Scmy38G2O8OwNjmgSq5a9+RjdDQoLzs/5p2pT42g4b7Dec+N0KhISWBr5L/Tz1VDYICQvFt8yS32a/zYynFNJYDBA/2QSRwQIJrANQXjHiMM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Jgc9GWOw; arc=none smtp.client-ip=209.85.167.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Jgc9GWOw" Received: by mail-oi1-f178.google.com with SMTP id 5614622812f47-3c9d70d93dbso1094266b6e.3 for ; Tue, 11 Jun 2024 20:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162570; x=1718767370; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MlD23f+arzcg415XUQcgi2kkZZjdw3Csp3SRxDpwH5A=; b=Jgc9GWOwgK3BzR17S7a/7kPAAEYKK0+1oV7nqCYx/rKdkjPU/kYOhEwI9ozgEXLc33 9u9mqiy9UZ6qj2bzSTJoBw8HzCAbBhvXxTZ/Vg7d2zALt8UDFmPiDlX6g3Om85iWT32b GdI1g0uYMxBjqzJ5Dlze5o20TvYr16FonI9Aowt2DHlji6hPJeU870AJgEBM6FMRNwYC NkBhHIc7g+u/794giREdFsTd/ACm4EJMVRkbDUgFc446X3XyXJNMAmQ4r0ck0KLO0NWy zy6HHt59IfPP17tz1m80NqaUt/gt9mG+/fZFFKRP/AeGjTRtiV2GhdKmTuvh3j3h15qV Sjiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162570; x=1718767370; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MlD23f+arzcg415XUQcgi2kkZZjdw3Csp3SRxDpwH5A=; b=DaBlj9cU7jWTfyZ0jGEaObq5u5kP7L+3jRYQVI52bDsR9M3d63Th6jk4NY+OS1qo+d 3rzX6OQibNrbAL7qnjHTgD4DSVmxYY+z8NTr2EGAkWo2zhWOHV/ORLOe/zEenndEWo2J 8nQVlUji5aWpt7EKxDkpbZIm0yQd+auSFMDVQJPZQPc0phcnkYoyKIpriKzHml6XhgIq QpSZeMVnA8r0oId+5pyM735da6W6ya7GrVRQCtpknejfq+Usrcd2zMhKQCGik0aLTXph 4H68dudx/Zpx9z7abn5c9h5Vsa5LI0E9WYt82sR9s8EHs76B09zBobLHXzbVHR2M6kK8 2gYw== X-Forwarded-Encrypted: i=1; AJvYcCVAjGRpf+SSI4odGoCGPchPzbxy+SQ5TCg+aTD9yyaxLlor3sM6tT2+01v433L1Wd1FyS4qpdVCJtTxsyaBWYVrFFqqoB/nQIZObGmA X-Gm-Message-State: AOJu0Yy8HOFGShZe4jlwygMCgQ5eAlPHAbCOJT4mSu/7auKSy5CFpSkw aY+WbOTVce2F1KZ7/G/yz8yDQr0zGuyfm8NjurcIuUWrSj49inzpmizPpoIMKCI= X-Google-Smtp-Source: AGHT+IHbieTndi1KMRbPXtZyNMt7QLIoX+75W/r+HgGQcQ8UzS+ezzdKinncxF4lvj+2qyjawM8FBg== X-Received: by 2002:a05:6808:13c8:b0:3d2:243e:e4b7 with SMTP id 5614622812f47-3d23e04d2d4mr638193b6e.23.1718162570315; Tue, 11 Jun 2024 20:22:50 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:49 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 20/24] Staging: rtl8192e: Rename variable bRTSSTBC Date: Tue, 11 Jun 2024 20:22:26 -0700 Message-Id: <20240612032230.9738-21-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Rename variable bRTSSTBC to rtsstbc to fix checkpatch warning Avoid CamelCase. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: No Change drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c | 2 +- drivers/staging/rtl8192e/rtllib.h | 2 +- drivers/staging/rtl8192e/rtllib_tx.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c b/drivers/stagi= ng/rtl8192e/rtl8192e/r8192E_dev.c index 46e42fad5834..b3d4b3394284 100644 --- a/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c +++ b/drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c @@ -894,7 +894,7 @@ void rtl92e_fill_tx_desc(struct net_device *dev, struc= t tx_desc *pdesc, =20 pTxFwInfo->RtsEnable =3D (cb_desc->rts_enable) ? 1 : 0; pTxFwInfo->CtsEnable =3D (cb_desc->cts_enable) ? 1 : 0; - pTxFwInfo->RtsSTBC =3D (cb_desc->bRTSSTBC) ? 1 : 0; + pTxFwInfo->RtsSTBC =3D (cb_desc->rtsstbc) ? 1 : 0; pTxFwInfo->RtsHT =3D (cb_desc->rts_rate & 0x80) ? 1 : 0; pTxFwInfo->RtsRate =3D _rtl92e_rate_mgn_to_hw(cb_desc->rts_rate); pTxFwInfo->RtsBandwidth =3D 0; diff --git a/drivers/staging/rtl8192e/rtllib.h b/drivers/staging/rtl8192e/r= tllib.h index 61d383a560f6..022851b7f1a9 100644 --- a/drivers/staging/rtl8192e/rtllib.h +++ b/drivers/staging/rtl8192e/rtllib.h @@ -116,7 +116,7 @@ struct cb_desc { u8 use_short_preamble:1; u8 tx_enable_fw_calc_dur:1; u8 ampdu_enable:1; - u8 bRTSSTBC:1; + u8 rtsstbc:1; u8 RTSSC:1; =20 u8 rts_bw:1; diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 1aad5253ae4e..b6bf10dc1772 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -372,7 +372,7 @@ static void rtllib_query_protectionmode(struct rtllib_d= evice *ieee, { struct rt_hi_throughput *ht_info; =20 - tcb_desc->bRTSSTBC =3D false; + tcb_desc->rtsstbc =3D false; tcb_desc->rts_use_short_gi =3D false; tcb_desc->cts_enable =3D false; tcb_desc->RTSSC =3D 0; --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f41.google.com (mail-oo1-f41.google.com [209.85.161.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CDD4922094 for ; Wed, 12 Jun 2024 03:22:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.41 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162573; cv=none; b=oYd8wIuWfgnoxHwHvxjS/1tghpYg45ZVEuaZuik+U8LOyM0L+ZiLxeoLM/Sbc4OZD7UtIwmbjeFd9EzEEEOSCFAcVUGeheeEGkm1NTt066WG+S2lz4q+7cemmAu4qTxvary9/UHe89GEFBQxv11+A8tQncB0kyyc/IBEC284qtU= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162573; c=relaxed/simple; bh=B6419FpNbp+/aBwLGzQozNilV2BWM00eMrzVMInnBmw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=owDjP54dCHiATTJlg7/ele0zZxxd6hZasfnSq9mp1Mx76HFEhT9Nvf322dMHZw5IDrPxiFU9hsQO3UMRAG3VJlYQXrxJuPco/6nou6XOyWPMMrwXNBe+ZiTOXSouMCprM3sTmUbWIEYkMS6Zn0P5UM+PQ+23opnNk1Gki9uIT7w= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=DqpE3oa0; arc=none smtp.client-ip=209.85.161.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="DqpE3oa0" Received: by mail-oo1-f41.google.com with SMTP id 006d021491bc7-5b2ed25b337so952275eaf.0 for ; Tue, 11 Jun 2024 20:22:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162571; x=1718767371; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=IkUXIIgxnRHbQ4O/B4sWA8g/vJGypFpqBBuA1kYA6/A=; b=DqpE3oa0leLXwa3u/k9c3NfkcN+9rgh0zjNw2FdAumEZtkReOStYoA4S6CbNOxyK/D 2kzpGc5SkGQFo440mpqJHc0VL5ftvSh1cRT3GhkGIb89kuo5tjiapRUgHlyp6OXabxO0 EkhJavIbxdphUfvcxsFO4cXzoT/DMaJW7Yczo8km5PV2VraGvFjOBXBOOZmI9NVpzcCN VoGS18bYt3HDIjislOdpG86JV6mEFtoY279Y2p2+G88GINBnXqia9OxGclFEKnkP85lO vJrqrALTQa4ELGIRQwEszcbpCGRIAJEWASxgh5E65BEZO4gFuSNP0A3K6FRBmeoxIZpC d4Mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162571; x=1718767371; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=IkUXIIgxnRHbQ4O/B4sWA8g/vJGypFpqBBuA1kYA6/A=; b=cQsBIMP24jbAdTbNEN5hnPRo/OcpbN0z7CVv0wdOyYbuk10NruorYGOGUp3USuYfKj VoLPUm6cr9gP68SWsFYqQg2MYt3W2QSfsHngBj20OVEECsOYg7/IKFjxZkSP5Ch3Y20i dtQtHUD1zodYnLYu7skxloxrznfzjDPjCXpLZKp+qvkaei76jmTM/sfmjqrHLYrbfvXy M+cacJ0pXK/4J2CcTt4P8VlqQz9aFmS3pa73zR+4qYN5J2nte1XwPwRJPmE5v1dAPD3N qsUvQ55xdCpXh/LpsdzZ69y1oq6u2c08vwFV19qlVmMiLWa9QPilPauB2udiBA7K62wA jYfA== X-Forwarded-Encrypted: i=1; AJvYcCWC73xec9DONt6yEfUrMCeXItHPL9kAHrewdYKCk3EV5oDY+S7Mj0yMhw/vuAqMQ32CdstXP6KclzMtgs84FaKWgwjcrCIR+BMO2bcL X-Gm-Message-State: AOJu0YzAf0q+7EDBOaTt9hdnlI6Hw1Fv0cI2mhD8RtMaNg9Qx9ZH9K87 IhfrMkZLF6KKlVkH9zspWZehopQorK3sAHLRoHXoiG43E/bXrwcWz0ntSrC1JdRpe0IFs+Xf+jd WEus= X-Google-Smtp-Source: AGHT+IH79lwqNICQ6D0Z3MD9ooOOiJHmZx/dsVgvZvVnkLxSkBzX3m7OiQRxy640o3aaBXoBFOrElw== X-Received: by 2002:a05:6358:6f18:b0:19f:3764:3c4a with SMTP id e5c5f4694b2df-19f69d35b19mr86669355d.8.1718162570962; Tue, 11 Jun 2024 20:22:50 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:50 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 21/24] Staging: rtl8192e: Remove parameter bIsAmsdu from rtllib_classify() Date: Tue, 11 Jun 2024 20:22:27 -0700 Message-Id: <20240612032230.9738-22-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove argument, bIsAmsdu from rtllib_classify() as it is never used. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Update subject prefix with 'Staging: rtl8192e:' drivers/staging/rtl8192e/rtllib_tx.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index b6bf10dc1772..9a9bd8450354 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -228,7 +228,7 @@ static struct rtllib_txb *rtllib_alloc_txb(int nr_frags= , int txb_size, return NULL; } =20 -static int rtllib_classify(struct sk_buff *skb, u8 bIsAmsdu) +static int rtllib_classify(struct sk_buff *skb) { struct ethhdr *eth; struct iphdr *ip; @@ -607,7 +607,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) } } =20 - skb->priority =3D rtllib_classify(skb, IsAmsdu); + skb->priority =3D rtllib_classify(skb); crypt =3D ieee->crypt_info.crypt[ieee->crypt_info.tx_keyidx]; encrypt =3D !(ether_type =3D=3D ETH_P_PAE && ieee->ieee802_1x) && crypt &= & crypt->ops; if (!encrypt && ieee->ieee802_1x && --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oa1-f54.google.com (mail-oa1-f54.google.com [209.85.160.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B65FA82C76 for ; Wed, 12 Jun 2024 03:22:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.54 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162574; cv=none; b=hkqbjLhLk/BSGrWK9EPh5Dm+gbO0KY2TiLhxr4/OtPLIBt8LXxs9CY/4nqigPWB3E6SaNrnf9OrLIBfPDUlTx0ONM7WmvxMb0UXaoAPKgItJioRLvGIbYHWX6bDxCwTkXliDVWPQGPEclR8EvPTmJLclxsBaclLEWBypckq87c8= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162574; c=relaxed/simple; bh=a0AR5YGMHIOP52fU6nssMemSeg/SfHbIA2c8V//RH98=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=DIBKrzofjuKUpWXceL7dKaTVLZGZhz/ZyI76/JUBvC1BwzAhrMAYCBQY1NqI+KwIStPlNzcxuyeyw0pLTcTxh3EOZyk+O/FOMNlnKVVfdmdTeDaIPWcw4re/w8mH14B+fhoDUa9VlHeWcIXvOBuzjf6mB86XDuj+Swo6ntuPgyU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=Cgq47L+r; arc=none smtp.client-ip=209.85.160.54 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="Cgq47L+r" Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-254c56efe06so1416897fac.2 for ; Tue, 11 Jun 2024 20:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162572; x=1718767372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=MbK3BP5tI5o4/49SrdtlAw9SnoV1ioIONkhc+yAhOBo=; b=Cgq47L+r0SrwzxrDGuaHBdUzsXlfKMulF+dBkRvibVpTumI0iUrI3BG9Piv+OGI5Ou IFiq0SkWSMA0K/TqIWBhOO7wgKpZHPN5HVG3QoJuuOaiWI+6/DNR4D2Z7+OJT7oUzTIA j5K2eEyZ5EVXIhYopzKMOVSzjnzvInXlDGBR9RbTBBKs8FBLRNk1xM13dQnX+/4j4Yo9 nZjXF+bNK8sdC8dI3TjlMM2cz9YbrEUfsEYwesUbyh7FANiebEEUzi/Tr0It0h/01/I6 HtpgMonNnCZqIbCvNKD9LeKNRe5PwHQalj2Sgj94Muq5WwSo2sMfFz6KgAZiZgR/QbNP PnRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162572; x=1718767372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=MbK3BP5tI5o4/49SrdtlAw9SnoV1ioIONkhc+yAhOBo=; b=BxzT19d78fiCoeoBs7KzcMMB4zABgsmP0G6vVbCdcAYqVit6nLFGOA2Zr1vwsnp2N7 wyYMnyIJfaW3WQXWk5Ncv1nXbOcOtRecSmbsSisoACeJ2nuE6hhDRsgIFbitf2awo53m lBvwrzxGvQcf1YUH/4zyJBhl96opNTDGC4shSt6IpiGd8qOdpUQ143ZcfrqRfS8tyOCk 4CiFDld9hMzP0kQG4SUAtRRCARi94e6dYYHIySP1Fey1s9C34/oMfHH9exBKCs9YK17v S0S71ItCdfohWEkgZxxyp3X9kKL7jQ8csRMHnPJv3+hck3qU2oFe7Y6PXIfECET5QlpG 40CA== X-Forwarded-Encrypted: i=1; AJvYcCUD2c1/T7NMILHvkO2eW97lE75MLQt6JoUXtg3BX1ZnM3P2vm6RNOenMXntYVBKNnevvLnTvlOpEvwOZKY2Dz20fC37wEgrVvyflODR X-Gm-Message-State: AOJu0Yx2eywr4+zDavMBxvZ4bIKjZEZNHOUWQNflQhkYwCt1h2sbU4Z5 XGznsbT2xSgGTGycnIypPB9QLX76gGW9W3wj+adsnMCWlOI1EoaQPydhc0Lcw8FPRzwAqbKIKzg WFVw= X-Google-Smtp-Source: AGHT+IGS438Lm1LZwydy3UhOIIMDpANz2Yfv5F5W81izEj3Zx99F0lRsPMzouhO+ihHx5LfZroGGdg== X-Received: by 2002:a05:6870:7248:b0:254:930c:fa08 with SMTP id 586e51a60fabf-25514c03a65mr735213fac.12.1718162571800; Tue, 11 Jun 2024 20:22:51 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:51 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 22/24] Staging: rtl8192e: Remove variable IsAmsdu from rtllib_xmit_inter() Date: Tue, 11 Jun 2024 20:22:28 -0700 Message-Id: <20240612032230.9738-23-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Remove boolean variable, IsAmsdu, and code which does not execute because it is never set to true. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Update subject prefix with 'Staging: rtl8192e:' drivers/staging/rtl8192e/rtllib_tx.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 9a9bd8450354..2f5005689a36 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -539,7 +539,6 @@ static int rtllib_xmit_inter(struct sk_buff *skb, struc= t net_device *dev) struct lib80211_crypt_data *crypt =3D NULL; struct cb_desc *tcb_desc; u8 is_multicast =3D false; - u8 IsAmsdu =3D false; bool bdhcp =3D false; =20 spin_lock_irqsave(&ieee->lock, flags); @@ -648,11 +647,7 @@ static int rtllib_xmit_inter(struct sk_buff *skb, stru= ct net_device *dev) ether_addr_copy(header.addr1, ieee->current_network.bssid); ether_addr_copy(header.addr2, src); - if (IsAmsdu) - ether_addr_copy(header.addr3, - ieee->current_network.bssid); - else - ether_addr_copy(header.addr3, dest); + ether_addr_copy(header.addr3, dest); } =20 is_multicast =3D is_multicast_ether_addr(header.addr1); --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f50.google.com (mail-oo1-f50.google.com [209.85.161.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F10A839E5 for ; Wed, 12 Jun 2024 03:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.50 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162575; cv=none; b=fugmRNmo0eEbeJIamaCcJqdA+BxLafU1BRCYtKy7uw5UtDH/GVgwIp3nprQnv4P8MbCs3A+ZmvPtjxmQKFbJ+pGhuHXB8S/wxJZwEMqEiKLR7pTVRUAhXQQ8CPp+GuwrLz5i2dXWhMVQHMuX0xumbLUxkDmstp1f6/Y0i4evTjE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162575; c=relaxed/simple; bh=+hkSQsHkHuNFjHWC3sYMEtLK6wx5aCSN95mhnv+qW/U=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=sRvh7d/OAQk2XzYOkKEpfPFhYWCQUog58v+xWrgFqwVmCdRbIhb9q1/EC8dlFX/gc4t2JuG9YeYF8jzeSg5CijkW/xrok5SjA00Q2Opq3TI0eDz2KbZSjdLzqaTCP8hrCsE9T/phMzf/Vbuo29wxwh2R/DXWFgCE8S/YIvWtB84= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=TJAMnp/1; arc=none smtp.client-ip=209.85.161.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="TJAMnp/1" Received: by mail-oo1-f50.google.com with SMTP id 006d021491bc7-5b52b0d0dfeso3181229eaf.0 for ; Tue, 11 Jun 2024 20:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162572; x=1718767372; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7nb8O2azIXxdt4GxCY1fQnfF3h/5DHYmDEmQNF62iLI=; b=TJAMnp/1mAyMhE/2F98FiREC10pC8aO0V09fKEVjv8MpiIihI/OzxLUprBozlD+3QX wkLntI8BdWw2RSxiEabzPwcdAdTsMqI9qdm1pryWfPlMLhCs1UFZs6MYEOJqfi8NWFif wVI7k10LRSIwoFq83U5Nwj+Mrs+/J74JGsiik8rXEjvREDYFEPDAmXtMtG5x/7JOvWAP fTkqWRr9wabto1dJ56WcJ/Vujbwne9AvMFf9tVYeCkW5R+mLQJT/XnFh54VcSqhpUW5j hYNv0UV8sB3u23K9IQxbe56GfUg/WiPeCzd4Ii6G9uujp6MMFQlx/gHV3zITJ8Z7VoUO sefw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162572; x=1718767372; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7nb8O2azIXxdt4GxCY1fQnfF3h/5DHYmDEmQNF62iLI=; b=BODPcn6cdKZYUas+vH4W6WKOLcbNK8TCAAuNmZUnR7lbWjZas8vPOJq8ahczSaUfGh wMIPsCDnNqT+pnf8V8Nrsb9jrX/2iDIDks8ibLzNeNwlHlZ3OcVyxxVluE2jC7B/3UuV fjujSN2586PvlPvSm17QXLMS6eA9BtvXiV4Z0plcywb29U93yUJ7IYq1gqKbcZeA1UwQ 4tl4G2EQ38YjSDU9kQXcW/QqB6zdNEwegP/3JAeVrmWoe4DW3Lru5OqEYY8lYPHLT9X+ q8x9jBKMRGQbiGnI9OqRHqTnBDHkjbpuPF/izJDxruoQHzX3okU9NOuYXr544aAh0fiw bAIA== X-Forwarded-Encrypted: i=1; AJvYcCXRy+FmBi7hGqY6535SeiOXaiVgCdL0slEiK37MbPyoi7q0oFiM76ydVR/r3O0i97G33GoAAW8+tUD+JUk1rvQzJSXaKHg8aiylCa5S X-Gm-Message-State: AOJu0Yw8Uz8Dx/KEjzWqHeTH9xNQGzqvnoToKS/uwbqCMQmvMAnHYAVW KWxxmIeP9+RTmSL55ZFOnGQl2yze19j4m+YDOvGeV6UN4OtULAxENkrQIaeq/Pc= X-Google-Smtp-Source: AGHT+IEnGI7AT5ngPRYTMTtEcNd8mtD023Qkq2VHWARRINuGHnkE+kMqpXdURqn/Qa4rIy63aBHtsQ== X-Received: by 2002:a05:6358:6f9c:b0:19f:4d27:fb76 with SMTP id e5c5f4694b2df-19f69cf707emr88629155d.7.1718162572397; Tue, 11 Jun 2024 20:22:52 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:52 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 23/24] Staging: rtl8192e: Fix alignment to match open parenthesis in rtllib_tx.c Date: Tue, 11 Jun 2024 20:22:29 -0700 Message-Id: <20240612032230.9738-24-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add spaces and tabs to fix warning: Alignment should match open parenthesis. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Update subject prefix with 'Staging: rtl8192e:' drivers/staging/rtl8192e/rtllib_tx.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_tx.c b/drivers/staging/rtl8192= e/rtllib_tx.c index 2f5005689a36..8e2abd16eb86 100644 --- a/drivers/staging/rtl8192e/rtllib_tx.c +++ b/drivers/staging/rtl8192e/rtllib_tx.c @@ -320,7 +320,7 @@ static void rtllib_tx_query_agg_cap(struct rtllib_devic= e *ieee, } =20 static void rtllib_query_short_preamble_mode(struct rtllib_device *ieee, - struct cb_desc *tcb_desc) + struct cb_desc *tcb_desc) { tcb_desc->use_short_preamble =3D false; if (tcb_desc->data_rate =3D=3D 2) @@ -331,7 +331,7 @@ static void rtllib_query_short_preamble_mode(struct rtl= lib_device *ieee, } =20 static void rtllib_query_ht_cap_short_gi(struct rtllib_device *ieee, - struct cb_desc *tcb_desc) + struct cb_desc *tcb_desc) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; =20 @@ -347,7 +347,7 @@ static void rtllib_query_ht_cap_short_gi(struct rtllib_= device *ieee, } =20 static void rtllib_query_bandwidth_mode(struct rtllib_device *ieee, - struct cb_desc *tcb_desc) + struct cb_desc *tcb_desc) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; =20 --=20 2.30.2 From nobody Thu Feb 12 14:09:56 2026 Received: from mail-oo1-f52.google.com (mail-oo1-f52.google.com [209.85.161.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ECDD183A14 for ; Wed, 12 Jun 2024 03:22:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162576; cv=none; b=h/dOeUpQsKx1jI/ykAxtbvFFczWDB/ec0bvAvjFIGlHF0477c/gkdXWEEMEyO0tfFHceyqRFVCj28HAv3v7l0qCM7VXNkWJEU5MOI7sqQNC8sJJto2QCco5JRPTVjySuTXkg4YiJ8yqIYlZt8VhocUfkKrRozDqf0YcDNj5CaNE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1718162576; c=relaxed/simple; bh=5lYQdNuUHz8/GTVUO7BqqszIM5H7aPs0vexG3JfhGeA=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=p53Se5yaf7O9CFMIPtE6vxlNZLb6ixUBiCenq2k5UTc0ay30niTmE7hHoWf0bZlUBOg7qjHHhh2LpycgtjLRIM0ZVrrOgDS7fSSvGlgOnhcS5QUJBVNEOZM/jSyP4T2S03Ivts8RaJp6HBLY4ASRYNoQxW+wB90yEJWMrH9gsCU= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net; spf=pass smtp.mailfrom=darkphysics.net; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b=dCkE886t; arc=none smtp.client-ip=209.85.161.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=darkphysics.net Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=darkphysics.net header.i=@darkphysics.net header.b="dCkE886t" Received: by mail-oo1-f52.google.com with SMTP id 006d021491bc7-5b53bb4bebaso3403939eaf.0 for ; Tue, 11 Jun 2024 20:22:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=darkphysics.net; s=google; t=1718162573; x=1718767373; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=jmqxGFNhFO/LKAwg0O4NLTkC1jcwbpMGmNWI2cJ3ekw=; b=dCkE886tqYHws3YHq4mgxho04rI5/kIJI+zzl/cxnolBESoAgYudrTJYV2Ojtb85oE vdTRzXDPbFtHIuc7RIkfQQZjckIQnxeDBwB/ZcobyNmU1P7qVwowMCs14w5lDQV2XARD kK7uViO4P5lNkIiiUtVt9N+ENWjZRrAnCp5iK2JgtI2ZDTX3MF5QMsIitz0Mt7IwfOmS hF9h3pqJc+ddbxpo92FmwDBT2bQfMDTTBQSOK+e8wqj5s3OnF4kljTVdKqrlNP+sIrsn /VEy5DUDdfUuj9bGBTmNcSKL0FOG4WS+VATKxIiuAAD2ezMiGkBPoJ/tWBzU+158lZeN mDOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1718162573; x=1718767373; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=jmqxGFNhFO/LKAwg0O4NLTkC1jcwbpMGmNWI2cJ3ekw=; b=bZPRQeXW2aAYjqIoF7YW6T49j4pC7xPJ4Ty4ho383rvxDVfHi7nmefZa2qjCfXnTLJ Tte3PbZTqjcgVASXveitj4XNVkIHG9SdD8XQq7LJ+JEh05axDJrygT4j+bzFDnizzVue LFWe/T9Ms87KsFK0xWkBaAPRO1NCShcBI+Q/Q7fNx7PzqRF2k44UwOuGf9ktBo2oSqV7 0YDFr3OvnFoqe9V3UAteMO3+2SPLmGYYBI2DhzTCXbHZPRjac+RiVqzXTD1Gsi+ZR8jX NjCHHKnjP61QlhyWaL0rlHZv2iuIwfO1nZn44EFbgpt5uIGFsdcVdUQUPVfPTLj0oNPY zbAw== X-Forwarded-Encrypted: i=1; AJvYcCVeBzj2mPZnY5tOW9b1uMcw0f0HmuW8lAiYKnRGx4e9fHskSKA/ysn2RmEX7CwxAY2m8yIFo0vXn1yhGPQRDZk/0cvySuZHLHRAqz6G X-Gm-Message-State: AOJu0YyaJ6eE1Wm8fBQOO+aJ1g+kinVA4X+GvZJWf/QUaZhnGTlliJPB e/Pl0NSCB7qcxDY0MHh4dE/SYcxTRjFG0H3waziXH0++AmhO3tA0PN640VZsXxE= X-Google-Smtp-Source: AGHT+IETnZqpy9qMIhAYwfn4Ereu8xqT/+82iztRkoZQbUm5OxrUwKu7I9DdD4Qh3UC2mkNl37aCLw== X-Received: by 2002:a05:6359:1a94:b0:19f:6aab:1af6 with SMTP id e5c5f4694b2df-19f6aab1c6dmr44896855d.5.1718162573092; Tue, 11 Jun 2024 20:22:53 -0700 (PDT) Received: from lunchbox.darkphysics (c-76-146-178-2.hsd1.wa.comcast.net. [76.146.178.2]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-6e8e8a84949sm5635411a12.32.2024.06.11.20.22.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 11 Jun 2024 20:22:52 -0700 (PDT) From: Tree Davies To: gregkh@linuxfoundation.org, philipp.g.hortmann@gmail.com, anjan@momi.ca Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, Tree Davies Subject: [PATCH v2 24/24] Staging: rtl8192e: Fix alignment to match open parenthesis in rtllib_rx.c Date: Tue, 11 Jun 2024 20:22:30 -0700 Message-Id: <20240612032230.9738-25-tdavies@darkphysics.net> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20240612032230.9738-1-tdavies@darkphysics.net> References: <20240612032230.9738-1-tdavies@darkphysics.net> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Add spaces and tabs to fix warning: Alignment should match open parenthesis. Signed-off-by: Tree Davies Reviewed-by: Dan Carpenter Tested-by: Philipp Hortmann --- v2: Update subject prefix with 'Staging: rtl8192e:' drivers/staging/rtl8192e/rtllib_rx.c | 37 ++++++++++++++-------------- 1 file changed, 18 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8192e/rtllib_rx.c b/drivers/staging/rtl8192= e/rtllib_rx.c index 3bff54efe66e..84ca5d769b7e 100644 --- a/drivers/staging/rtl8192e/rtllib_rx.c +++ b/drivers/staging/rtl8192e/rtllib_rx.c @@ -55,7 +55,7 @@ static inline void rtllib_monitor_rx(struct rtllib_device= *ieee, /* Called only as a tasklet (software IRQ) */ static struct rtllib_frag_entry * rtllib_frag_cache_find(struct rtllib_device *ieee, unsigned int seq, - unsigned int frag, u8 tid, u8 *src, u8 *dst) + unsigned int frag, u8 tid, u8 *src, u8 *dst) { struct rtllib_frag_entry *entry; int i; @@ -84,7 +84,7 @@ rtllib_frag_cache_find(struct rtllib_device *ieee, unsign= ed int seq, /* Called only as a tasklet (software IRQ) */ static struct sk_buff * rtllib_frag_cache_get(struct rtllib_device *ieee, - struct ieee80211_hdr *hdr) + struct ieee80211_hdr *hdr) { struct sk_buff *skb =3D NULL; u16 fc =3D le16_to_cpu(hdr->frame_control); @@ -143,7 +143,7 @@ rtllib_frag_cache_get(struct rtllib_device *ieee, * should have already been received */ entry =3D rtllib_frag_cache_find(ieee, seq, frag, tid, hdr->addr2, - hdr->addr1); + hdr->addr1); if (entry) { entry->last_frag =3D frag; skb =3D entry->skb; @@ -155,7 +155,7 @@ rtllib_frag_cache_get(struct rtllib_device *ieee, =20 /* Called only as a tasklet (software IRQ) */ static int rtllib_frag_cache_invalidate(struct rtllib_device *ieee, - struct ieee80211_hdr *hdr) + struct ieee80211_hdr *hdr) { u16 fc =3D le16_to_cpu(hdr->frame_control); u16 sc =3D le16_to_cpu(hdr->seq_ctrl); @@ -181,7 +181,7 @@ static int rtllib_frag_cache_invalidate(struct rtllib_d= evice *ieee, } =20 entry =3D rtllib_frag_cache_find(ieee, seq, -1, tid, hdr->addr2, - hdr->addr1); + hdr->addr1); =20 if (!entry) { netdev_dbg(ieee->dev, @@ -202,8 +202,7 @@ static int rtllib_frag_cache_invalidate(struct rtllib_d= evice *ieee, */ static inline int rtllib_rx_frame_mgmt(struct rtllib_device *ieee, struct sk_buff *skb, - struct rtllib_rx_stats *rx_stats, u16 type, - u16 stype) + struct rtllib_rx_stats *rx_stats, u16 type, u16 stype) { /* On the struct stats definition there is written that * this is not mandatory.... but seems that the probe @@ -228,7 +227,7 @@ rtllib_rx_frame_mgmt(struct rtllib_device *ieee, struct= sk_buff *skb, =20 /* Called by rtllib_rx_frame_decrypt */ static int rtllib_is_eapol_frame(struct rtllib_device *ieee, - struct sk_buff *skb, size_t hdrlen) + struct sk_buff *skb, size_t hdrlen) { struct net_device *dev =3D ieee->dev; u16 fc, ethertype; @@ -346,7 +345,7 @@ rtllib_rx_frame_decrypt_msdu(struct rtllib_device *ieee= , struct sk_buff *skb, /* this function is stolen from ipw2200 driver*/ #define IEEE_PACKET_RETRY_TIME (5 * HZ) static int is_duplicate_packet(struct rtllib_device *ieee, - struct ieee80211_hdr *header) + struct ieee80211_hdr *header) { u16 fc =3D le16_to_cpu(header->frame_control); u16 sc =3D le16_to_cpu(header->seq_ctrl); @@ -404,7 +403,7 @@ static int is_duplicate_packet(struct rtllib_device *ie= ee, } =20 static bool add_reorder_entry(struct rx_ts_record *ts, - struct rx_reorder_entry *pReorderEntry) + struct rx_reorder_entry *pReorderEntry) { struct list_head *list =3D &ts->rx_pending_pkt_list; =20 @@ -521,8 +520,8 @@ void rtllib_flush_rx_ts_pending_pkts(struct rtllib_devi= ce *ieee, } =20 static void rx_reorder_indicate_packet(struct rtllib_device *ieee, - struct rtllib_rxb *prxb, - struct rx_ts_record *ts, u16 SeqNum) + struct rtllib_rxb *prxb, + struct rx_ts_record *ts, u16 SeqNum) { struct rt_hi_throughput *ht_info =3D ieee->ht_info; struct rx_reorder_entry *pReorderEntry =3D NULL; @@ -1911,7 +1910,7 @@ int rtllib_parse_info_param(struct rtllib_device *iee= e, switch (info_element->id) { case MFIE_TYPE_SSID: if (rtllib_is_empty_essid(info_element->data, - info_element->len)) { + info_element->len)) { network->flags |=3D NETWORK_EMPTY_ESSID; break; } @@ -2190,10 +2189,10 @@ static inline int rtllib_network_init( network->wzc_ie_len =3D 0; =20 if (rtllib_parse_info_param(ieee, - beacon->info_element, - (stats->len - sizeof(*beacon)), - network, - stats)) + beacon->info_element, + (stats->len - sizeof(*beacon)), + network, + stats)) return 1; =20 network->mode =3D 0; @@ -2559,7 +2558,7 @@ static void rtllib_rx_mgt(struct rtllib_device *ieee, schedule_work(&ieee->ps_task); } else if (ieee80211_is_probe_resp(header->frame_control)) { netdev_dbg(ieee->dev, "received PROBE RESPONSE\n"); - rtllib_process_probe_response(ieee, - (struct rtllib_probe_response *)header, stats); + rtllib_process_probe_response(ieee, (struct rtllib_probe_response *)head= er, + stats); } } --=20 2.30.2