[PATCH RESEND v5 0/2] regulator: sun20i: Add Allwinner D1 LDOs driver

Chen-Yu Tsai posted 2 patches 1 year, 7 months ago
There is a newer version of this series
.../allwinner,sun20i-d1-system-ldos.yaml      |  37 +++++
drivers/regulator/Kconfig                     |   8 +
drivers/regulator/Makefile                    |   1 +
drivers/regulator/sun20i-regulator.c          | 156 ++++++++++++++++++
4 files changed, 202 insertions(+)
create mode 100644 Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-system-ldos.yaml
create mode 100644 drivers/regulator/sun20i-regulator.c
[PATCH RESEND v5 0/2] regulator: sun20i: Add Allwinner D1 LDOs driver
Posted by Chen-Yu Tsai 1 year, 7 months ago
From: Chen-Yu Tsai <wens@csie.org>

Hi,

This is a resend of the Allwinner D1 LDO driver series, separated by
subsystem. This part contains just the regulator driver bits. The sunxi
SRAM binding part will be sent out after the merge window due to a
conflict in next.

Original cover letter:

This series adds the binding and driver for one of the two pairs of LDOs
inside the Allwinner D1 SoC. I am splitting up the two pairs of LDOs to
unblock merging the SoC devicetree; the analog LDOs depend on the audio
codec binding, but they are not required to boot.

A binding and driver change is required for the SRAM controller, to
accept the regulators device as its child node.

The example for the regulator device binding is in SRAM controller
binding document, per Rob's request to keep MFD examples in one place.

Because of this, at least the first 3 patches need to be taken together
through the regulator tree, though it should be fine to merge the whole
series that way.

Changes in v5:
 - Correct the voltage calculation for the non-linearity around 1.6 V.

Changes in v4:
 - Fix the order of the maintainer/description sections
 - Replace unevaluatedProperties with "additionalProperties: false"
 - Drop the analog LDOs until the codec binding is ready
 - Drop the analog LDOs until the codec binding is ready
 - Remove unevaluatedProperties from regulators schema reference
 - Check the compatible string instead of the node name

Changes in v3:
 - Add "reg" property to bindings
 - Add "unevaluatedProperties: true" to regulator nodes
 - Minor changes to regulator node name patterns
 - Remove system-ldos example (now added in the parent binding)
 - Adjust control flow in sun20i_regulator_get_regmap() for clarity
 - Require the regulators node to have a unit address
 - Reference the regulator schema from the SRAM controller schema
 - Move the system LDOs example to the SRAM controller schema
 - Reorder the patches so the example passes validation

Changes in v2:
 - Remove syscon property from bindings
 - Update binding examples to fix warnings and provide context
 - Use decimal numbers for .n_voltages instead of field widths
 - Get the regmap from the parent device instead of a property/phandle



Samuel Holland (2):
  regulator: dt-bindings: Add Allwinner D1 system LDOs
  regulator: sun20i: Add Allwinner D1 LDOs driver

 .../allwinner,sun20i-d1-system-ldos.yaml      |  37 +++++
 drivers/regulator/Kconfig                     |   8 +
 drivers/regulator/Makefile                    |   1 +
 drivers/regulator/sun20i-regulator.c          | 156 ++++++++++++++++++
 4 files changed, 202 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-system-ldos.yaml
 create mode 100644 drivers/regulator/sun20i-regulator.c

-- 
2.39.2
Re: [PATCH RESEND v5 0/2] regulator: sun20i: Add Allwinner D1 LDOs driver
Posted by Mark Brown 1 year, 7 months ago
On Tue, 07 May 2024 12:13:41 +0800, Chen-Yu Tsai wrote:
> This is a resend of the Allwinner D1 LDO driver series, separated by
> subsystem. This part contains just the regulator driver bits. The sunxi
> SRAM binding part will be sent out after the merge window due to a
> conflict in next.
> 
> Original cover letter:
> 
> [...]

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git for-next

Thanks!

[1/2] regulator: dt-bindings: Add Allwinner D1 system LDOs
      commit: 622bab1884847fcf3f9bfdf1d534fac3a5fe859f
[2/2] regulator: sun20i: Add Allwinner D1 LDOs driver
      commit: 4e70b26c873dfff317039458a6ea66314bbdce99

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark
Re: [PATCH RESEND v5 0/2] regulator: sun20i: Add Allwinner D1 LDOs driver
Posted by Mark Brown 1 year, 7 months ago
On Tue, May 07, 2024 at 12:13:41PM +0800, Chen-Yu Tsai wrote:

> This is a resend of the Allwinner D1 LDO driver series, separated by
> subsystem. This part contains just the regulator driver bits. The sunxi
> SRAM binding part will be sent out after the merge window due to a
> conflict in next.

...

> A binding and driver change is required for the SRAM controller, to
> accept the regulators device as its child node.

This says that the driver depends on the SRAM change which isn't getting
merged this time round?
Re: [PATCH RESEND v5 0/2] regulator: sun20i: Add Allwinner D1 LDOs driver
Posted by Chen-Yu Tsai 1 year, 7 months ago
On Tue, May 7, 2024 at 10:46 PM Mark Brown <broonie@kernel.org> wrote:
>
> On Tue, May 07, 2024 at 12:13:41PM +0800, Chen-Yu Tsai wrote:
>
> > This is a resend of the Allwinner D1 LDO driver series, separated by
> > subsystem. This part contains just the regulator driver bits. The sunxi
> > SRAM binding part will be sent out after the merge window due to a
> > conflict in next.
>
> ...
>
> > A binding and driver change is required for the SRAM controller, to
> > accept the regulators device as its child node.
>
> This says that the driver depends on the SRAM change which isn't getting
> merged this time round?

The SRAM driver change was already merged. The regulator DT binding doesn't
depend on the SRAM binding change; it's the other way around: the SRAM
binding change adds a reference to the new regulator binding.

Hope that explains things.

ChenYu