From nobody Wed Dec 17 15:33:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 43D895491A; Tue, 7 May 2024 04:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715055231; cv=none; b=lIYdwwl3aLWjP+8u8H3Urkf3xLrnWSgAA3j8SNUhveUw9a8GQQxIJWeECa2ElagyRQiSf/v3s37hcZ9kL3v52QT1/yp2hROP5fTY9AYUceMkyGNa8Ya3lbbvRrbZC67AEuwP2+JlpDr93Vc5+63vhvTdnY+0FYVLKZIc0zMDvvo= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715055231; c=relaxed/simple; bh=Mk/kaGfo1nd9dUr4W4lbqu4SomACMK5r/e5cywhFtl8=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=h1vT74AwZybEC8sHh3ev/KIe/MLjHN+1ebYtg2Pv2boqgx39Yh22S+NJ2+3ACZRK/f7yaeYJr6Z9hFgs6j1oxJzq/ESfB/u2+vRkhndtL3cmJ58MSOyQuC57n8EX47QN9Q7kkSdmXa6AoLzz7V/thhPKaMKLxR2X3GLM1pUFWLM= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=p+XCp7id; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="p+XCp7id" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B9FB9C4AF63; Tue, 7 May 2024 04:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715055230; bh=Mk/kaGfo1nd9dUr4W4lbqu4SomACMK5r/e5cywhFtl8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=p+XCp7idKyIjVMcsKA+oB+O2qyzftDDngJzIZxvQmEXSUwKsST0zsEanCp6cRHZtE hGbX3Vh7oCrNjogrFU9Exq8+4bwyMW6CDyU/qooWEnhAGblj7NOfOeq7vMrIF5CDak C7vHmcqE1zMCd/lVNP7dioy10PL+OBawKYdBRxgbeT6E1rdMuNURjwtWUyxL4AiWw1 FOny4W7GPANtuk27HUHnVbeiTe4KEN0C2rR/LfERkKlDff8MHO8+FKpJBjA2JlSgnG W/bgcllCUzj/ryPEAhZFONPi201g87QERhy7DKMov4rrN6eDZ2d2fMDs4D5Q/WFDmb WZB6NQZRge7zQ== Received: by wens.tw (Postfix, from userid 1000) id 46D695F834; Tue, 7 May 2024 12:13:48 +0800 (CST) From: Chen-Yu Tsai To: Mark Brown Cc: Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Krzysztof Kozlowski , Chen-Yu Tsai Subject: [PATCH RESEND v5 1/2] regulator: dt-bindings: Add Allwinner D1 system LDOs Date: Tue, 7 May 2024 12:13:42 +0800 Message-Id: <20240507041343.272569-2-wens@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240507041343.272569-1-wens@kernel.org> References: <20240507041343.272569-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Samuel Holland The Allwinner D1 SoC contains two pairs of in-package LDOs. The pair of "system" LDOs is for general purpose use. LDOA generally powers the board's 1.8 V rail. LDOB powers the in-package DRAM, where applicable. Reviewed-by: Krzysztof Kozlowski Signed-off-by: Samuel Holland Signed-off-by: Chen-Yu Tsai --- .../allwinner,sun20i-d1-system-ldos.yaml | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/regulator/allwinner,s= un20i-d1-system-ldos.yaml diff --git a/Documentation/devicetree/bindings/regulator/allwinner,sun20i-d= 1-system-ldos.yaml b/Documentation/devicetree/bindings/regulator/allwinner,= sun20i-d1-system-ldos.yaml new file mode 100644 index 000000000000..ec6695c8d2e3 --- /dev/null +++ b/Documentation/devicetree/bindings/regulator/allwinner,sun20i-d1-syste= m-ldos.yaml @@ -0,0 +1,37 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/regulator/allwinner,sun20i-d1-system-ld= os.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Allwinner D1 System LDOs + +maintainers: + - Samuel Holland + +description: + Allwinner D1 contains a pair of general-purpose LDOs which are designed = to + supply power inside and outside the SoC. They are controlled by a regist= er + within the system control MMIO space. + +properties: + compatible: + enum: + - allwinner,sun20i-d1-system-ldos + + reg: + maxItems: 1 + +patternProperties: + "^ldo[ab]$": + type: object + $ref: regulator.yaml# + unevaluatedProperties: false + +required: + - compatible + - reg + +additionalProperties: false + +... --=20 2.39.2 From nobody Wed Dec 17 15:33:21 2025 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3285A54916; Tue, 7 May 2024 04:13:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715055231; cv=none; b=ZZTku3mn456Tff5jLpRvTV+fegJCtPTE6nVsbkKc9zkmhg5fmqFIkWGYBg6TAnXOJPt2Qz+A50MoS+ZowzflPQS2QFuLLQJZZ6WNGgwvMxuUs2pSuzn7HRCfy3zcn1MsK7krQe9Nc+DLcIYbUBl5BO7F8LLLKuKStRYbNO8IJGQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1715055231; c=relaxed/simple; bh=6L6sXbNBZJLJS9PELLxrP3wkMEE0uhyIQvVrET3+le0=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=F5IzN+vAz6I95OMppAbqD2bXpFxNXvY9/XBqX+UcF97sSJLDJ6+W+NhXLHjgIFbne7OcLvDsqZlz7H8N22xaUcl4XhtkOHzUpXL3xJ2qO1yKbWDr4KptUbu5cxqL9VLCMr4x2y4p0cFx3Ei2SyvJzyIjSJ8jCzDHHGY0SO0JgHI= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=NEtwGz9w; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="NEtwGz9w" Received: by smtp.kernel.org (Postfix) with ESMTPSA id B2796C4AF18; Tue, 7 May 2024 04:13:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1715055230; bh=6L6sXbNBZJLJS9PELLxrP3wkMEE0uhyIQvVrET3+le0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NEtwGz9w0No/aNe1JEwU0wXJG1vnyjeAVO3nIyNOHDKsqMKClVDS6asRN2O8WavLD QYBYhkVAm2/tLwdBEbF+orZxn5ZLTmGBqGsvGXVG0sg2OBlUSQV+japBZTZQzuUNS4 dWDDjzqz4f0cgjAjO91VULzUOKCUKjUR0Uw0G1D1TtayLU0mmBfZD0Ff81yRr+mtaU jPfJHPzHX6epWKezbsV5yGyHaAixRdJEQTFRNUC8cO3fhc/No/JxC9SuRL2i8b9wEw 0p1art0E4nMJk4X5oBiPzmrE86OSVLMVUFLqYXGzdQ2FzhEQlRUSIJaHkf1EbR7h0t 0XjzAdjALnLkw== Received: by wens.tw (Postfix, from userid 1000) id 52A8E6000C; Tue, 7 May 2024 12:13:48 +0800 (CST) From: Chen-Yu Tsai To: Mark Brown Cc: Samuel Holland , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jernej Skrabec , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, Andre Przywara , Chen-Yu Tsai Subject: [PATCH RESEND v5 2/2] regulator: sun20i: Add Allwinner D1 LDOs driver Date: Tue, 7 May 2024 12:13:43 +0800 Message-Id: <20240507041343.272569-3-wens@kernel.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: <20240507041343.272569-1-wens@kernel.org> References: <20240507041343.272569-1-wens@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Samuel Holland D1 contains two pairs of LDOs, "analog" LDOs and "system" LDOs. They are similar and can share a driver, but only the system LDOs have a DT binding defined so far. The system LDOs have a single linear range. The voltage step is not an integer, so a custom .list_voltage is needed to get the rounding right. Signed-off-by: Samuel Holland Reviewed-by: Andre Przywara Reviewed-by: Jernej Skrabec Signed-off-by: Chen-Yu Tsai --- drivers/regulator/Kconfig | 8 ++ drivers/regulator/Makefile | 1 + drivers/regulator/sun20i-regulator.c | 156 +++++++++++++++++++++++++++ 3 files changed, 165 insertions(+) create mode 100644 drivers/regulator/sun20i-regulator.c diff --git a/drivers/regulator/Kconfig b/drivers/regulator/Kconfig index 7db0a29b5b8d..acdb02a4ac0c 100644 --- a/drivers/regulator/Kconfig +++ b/drivers/regulator/Kconfig @@ -1415,6 +1415,14 @@ config REGULATOR_STW481X_VMMC This driver supports the internal VMMC regulator in the STw481x PMIC chips. =20 +config REGULATOR_SUN20I + tristate "Allwinner D1 internal LDOs" + depends on ARCH_SUNXI || COMPILE_TEST + select MFD_SYSCON + default ARCH_SUNXI + help + This driver supports the internal LDOs in the Allwinner D1 SoC. + config REGULATOR_SY7636A tristate "Silergy SY7636A voltage regulator" depends on MFD_SY7636A diff --git a/drivers/regulator/Makefile b/drivers/regulator/Makefile index 46fb569e6be8..ba15fa5f30ad 100644 --- a/drivers/regulator/Makefile +++ b/drivers/regulator/Makefile @@ -163,6 +163,7 @@ obj-$(CONFIG_REGULATOR_STM32_VREFBUF) +=3D stm32-vrefbu= f.o obj-$(CONFIG_REGULATOR_STM32_PWR) +=3D stm32-pwr.o obj-$(CONFIG_REGULATOR_STPMIC1) +=3D stpmic1_regulator.o obj-$(CONFIG_REGULATOR_STW481X_VMMC) +=3D stw481x-vmmc.o +obj-$(CONFIG_REGULATOR_SUN20I) +=3D sun20i-regulator.o obj-$(CONFIG_REGULATOR_SY7636A) +=3D sy7636a-regulator.o obj-$(CONFIG_REGULATOR_SY8106A) +=3D sy8106a-regulator.o obj-$(CONFIG_REGULATOR_SY8824X) +=3D sy8824x.o diff --git a/drivers/regulator/sun20i-regulator.c b/drivers/regulator/sun20= i-regulator.c new file mode 100644 index 000000000000..8af6b8037ee0 --- /dev/null +++ b/drivers/regulator/sun20i-regulator.c @@ -0,0 +1,156 @@ +// SPDX-License-Identifier: GPL-2.0-only +// +// Copyright (c) 2021-2022 Samuel Holland +// + +#include +#include +#include +#include +#include +#include + +#define SUN20I_SYS_LDO_CTRL_REG 0x150 + +struct sun20i_regulator_data { + const struct regulator_desc *descs; + unsigned int ndescs; +}; + +/* regulator_list_voltage_linear() modified for the non-integral uV_step. = */ +static int sun20i_d1_system_ldo_list_voltage(struct regulator_dev *rdev, + unsigned int selector) +{ + const struct regulator_desc *desc =3D rdev->desc; + unsigned int fraction, uV; + + if (selector >=3D desc->n_voltages) + return -EINVAL; + + uV =3D desc->min_uV + (desc->uV_step * selector); + fraction =3D selector + (desc->min_uV % 4); + + if (uV > 1606667) + uV +=3D 6667; + else + fraction++; + + /* Produce correctly-rounded absolute voltages. */ + return uV + (fraction / 3); +} + +static const struct regulator_ops sun20i_d1_system_ldo_ops =3D { + .list_voltage =3D sun20i_d1_system_ldo_list_voltage, + .map_voltage =3D regulator_map_voltage_ascend, + .set_voltage_sel =3D regulator_set_voltage_sel_regmap, + .get_voltage_sel =3D regulator_get_voltage_sel_regmap, +}; + +static const struct regulator_desc sun20i_d1_system_ldo_descs[] =3D { + { + .name =3D "ldoa", + .supply_name =3D "ldo-in", + .of_match =3D "ldoa", + .ops =3D &sun20i_d1_system_ldo_ops, + .type =3D REGULATOR_VOLTAGE, + .owner =3D THIS_MODULE, + .n_voltages =3D 32, + .min_uV =3D 1593333, + .uV_step =3D 13333, /* repeating */ + .vsel_reg =3D SUN20I_SYS_LDO_CTRL_REG, + .vsel_mask =3D GENMASK(7, 0), + }, + { + .name =3D "ldob", + .supply_name =3D "ldo-in", + .of_match =3D "ldob", + .ops =3D &sun20i_d1_system_ldo_ops, + .type =3D REGULATOR_VOLTAGE, + .owner =3D THIS_MODULE, + .n_voltages =3D 64, + .min_uV =3D 1166666, + .uV_step =3D 13333, /* repeating */ + .vsel_reg =3D SUN20I_SYS_LDO_CTRL_REG, + .vsel_mask =3D GENMASK(15, 8), + }, +}; + +static const struct sun20i_regulator_data sun20i_d1_system_ldos =3D { + .descs =3D sun20i_d1_system_ldo_descs, + .ndescs =3D ARRAY_SIZE(sun20i_d1_system_ldo_descs), +}; + +static struct regmap *sun20i_regulator_get_regmap(struct device *dev) +{ + struct regmap *regmap; + + /* + * First try the syscon interface. The system control device is not + * compatible with "syscon", so fall back to getting the regmap from + * its platform device. This is ugly, but required for devicetree + * backward compatibility. + */ + regmap =3D syscon_node_to_regmap(dev->parent->of_node); + if (!IS_ERR(regmap)) + return regmap; + + regmap =3D dev_get_regmap(dev->parent, NULL); + if (regmap) + return regmap; + + return ERR_PTR(-EPROBE_DEFER); +} + +static int sun20i_regulator_probe(struct platform_device *pdev) +{ + const struct sun20i_regulator_data *data; + struct device *dev =3D &pdev->dev; + struct regulator_config config; + struct regmap *regmap; + + data =3D of_device_get_match_data(dev); + if (!data) + return -EINVAL; + + regmap =3D sun20i_regulator_get_regmap(dev); + if (IS_ERR(regmap)) + return dev_err_probe(dev, PTR_ERR(regmap), "Failed to get regmap\n"); + + config =3D (struct regulator_config) { + .dev =3D dev, + .regmap =3D regmap, + }; + + for (unsigned int i =3D 0; i < data->ndescs; ++i) { + const struct regulator_desc *desc =3D &data->descs[i]; + struct regulator_dev *rdev; + + rdev =3D devm_regulator_register(dev, desc, &config); + if (IS_ERR(rdev)) + return PTR_ERR(rdev); + } + + return 0; +} + +static const struct of_device_id sun20i_regulator_of_match[] =3D { + { + .compatible =3D "allwinner,sun20i-d1-system-ldos", + .data =3D &sun20i_d1_system_ldos, + }, + { }, +}; +MODULE_DEVICE_TABLE(of, sun20i_regulator_of_match); + +static struct platform_driver sun20i_regulator_driver =3D { + .probe =3D sun20i_regulator_probe, + .driver =3D { + .name =3D "sun20i-regulator", + .of_match_table =3D sun20i_regulator_of_match, + }, +}; +module_platform_driver(sun20i_regulator_driver); + +MODULE_AUTHOR("Samuel Holland "); +MODULE_DESCRIPTION("Allwinner D1 internal LDO driver"); +MODULE_LICENSE("GPL"); --=20 2.39.2