From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>

Clarify PSE regulator as voltage regulator, not current.
The PSE (Power Sourcing Equipment) regulator is defined as a voltage
regulator, maintaining fixed voltage while accommodating varying current.

Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>
---
 drivers/net/pse-pd/pse_core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
index bad29eaa4d01..795ab264eaf2 100644
--- a/drivers/net/pse-pd/pse_core.c
+++ b/drivers/net/pse-pd/pse_core.c
@@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
 	 */
 	rdesc->id = id;
 	rdesc->name = name;
-	rdesc->type = REGULATOR_CURRENT;
+	rdesc->type = REGULATOR_VOLTAGE;
 	rdesc->ops = &pse_pi_ops;
 	rdesc->owner = pcdev->owner;
 

-- 
2.34.1

Mon, Apr 22, 2024 at 03:35:47PM CEST, kory.maincent@bootlin.com wrote:
>From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
>
>Clarify PSE regulator as voltage regulator, not current.
>The PSE (Power Sourcing Equipment) regulator is defined as a voltage
>regulator, maintaining fixed voltage while accommodating varying current.
>
>Reviewed-by: Andrew Lunn <andrew@lunn.ch>
>Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>

This looks like a fix. Can you provide "Fixes" tag please and perhaps
send this to -net tree?

Thanks!

>---
> drivers/net/pse-pd/pse_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/pse-pd/pse_core.c b/drivers/net/pse-pd/pse_core.c
>index bad29eaa4d01..795ab264eaf2 100644
>--- a/drivers/net/pse-pd/pse_core.c
>+++ b/drivers/net/pse-pd/pse_core.c
>@@ -294,7 +294,7 @@ devm_pse_pi_regulator_register(struct pse_controller_dev *pcdev,
> 	 */
> 	rdesc->id = id;
> 	rdesc->name = name;
>-	rdesc->type = REGULATOR_CURRENT;
>+	rdesc->type = REGULATOR_VOLTAGE;
> 	rdesc->ops = &pse_pi_ops;
> 	rdesc->owner = pcdev->owner;
> 
>
>-- 
>2.34.1
>
>

On Mon, 22 Apr 2024 17:02:18 +0200
Jiri Pirko <jiri@resnulli.us> wrote:

> Mon, Apr 22, 2024 at 03:35:47PM CEST, kory.maincent@bootlin.com wrote:
> >From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> >
> >Clarify PSE regulator as voltage regulator, not current.
> >The PSE (Power Sourcing Equipment) regulator is defined as a voltage
> >regulator, maintaining fixed voltage while accommodating varying current.
> >
> >Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> >Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>  
> 
> This looks like a fix. Can you provide "Fixes" tag please and perhaps
> send this to -net tree?

Indeed I should have used the Fixes tag.
The PoE patch series that introduce this issue is currently in net-next.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com

On Mon, Apr 22, 2024 at 06:20:30PM +0200, Kory Maincent wrote:
> On Mon, 22 Apr 2024 17:02:18 +0200
> Jiri Pirko <jiri@resnulli.us> wrote:
> 
> > Mon, Apr 22, 2024 at 03:35:47PM CEST, kory.maincent@bootlin.com wrote:
> > >From: Kory Maincent (Dent Project) <kory.maincent@bootlin.com>
> > >
> > >Clarify PSE regulator as voltage regulator, not current.
> > >The PSE (Power Sourcing Equipment) regulator is defined as a voltage
> > >regulator, maintaining fixed voltage while accommodating varying current.
> > >
> > >Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> > >Signed-off-by: Kory Maincent <kory.maincent@bootlin.com>  
> > 
> > This looks like a fix. Can you provide "Fixes" tag please and perhaps
> > send this to -net tree?
> 
> Indeed I should have used the Fixes tag.
> The PoE patch series that introduce this issue is currently in net-next.

With Fixes tag:
Acked-by: Oleksij Rempel <o.rempel@pengutronix.de>

-- 
Pengutronix e.K.                           |                             |
Steuerwalder Str. 21                       | http://www.pengutronix.de/  |
31137 Hildesheim, Germany                  | Phone: +49-5121-206917-0    |
Amtsgericht Hildesheim, HRA 2686           | Fax:   +49-5121-206917-5555 |